[Wikidata-bugs] [Maniphest] T286260: APCu caches are set to expire in 2073 instead of an hour if exptime is a unix timestamp

2021-07-14 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. This is done, I'll file a ticket about fully deprecating unix timestamp as expiry TASK DETAIL https://phabricator.wikime

[Wikidata-bugs] [Maniphest] T285919: Allow links to dag.wikipedia.org from Wikidata

2021-07-14 Thread Ladsgroup
Ladsgroup closed subtask T286260: APCu caches are set to expire in 2073 instead of an hour if exptime is a unix timestamp as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T285919 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T277862: selenium-daily-beta-WikibaseLexeme broken since mid feb 2021

2021-07-13 Thread Ladsgroup
Ladsgroup added a comment. I know in the old ruby browser tests we could mark different browser tests to be for beta or CI only. I think it makes sense here if possible. I haven't looked into it yet. TASK DETAIL https://phabricator.wikimedia.org/T277862 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T185629: jquery.ui.ooMenu.js should not cause warning "jQuery.fn.offset() requires an element connected to a document"

2021-07-13 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. I'm fixing all of these TASK DETAIL https://phabricator.wikimedia.org/T185629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T185629: jquery.ui.ooMenu.js should not cause warning "jQuery.fn.offset() requires an element connected to a document"

2021-07-13 Thread Ladsgroup
Ladsgroup added a comment. In T185629#5182888 <https://phabricator.wikimedia.org/T185629#5182888>, @Seb35 wrote: > Instead of solving this task, it would be better (but harder) to rewrite the current ooMenu without using jQuery.ui.widget but OOUI, given this component got depr

[Wikidata-bugs] [Maniphest] T286260: APCu caches are set to expire in 2073 instead of an hour if exptime is a unix timestamp

2021-07-13 Thread Ladsgroup
Ladsgroup added a comment. so this is fixed from wikibase point of view but we need to come to a decision to either merged the fix patch or fully deprecate using unix for expiry. TASK DETAIL https://phabricator.wikimedia.org/T286260 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T285919: Allow links to dag.wikipedia.org from Wikidata

2021-07-13 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. With the rolling restart of php-fpm and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/704320 being merged this is fully fixed. TASK DETAIL https://phabricator.wikimedia.org/T285919 EMAIL P

[Wikidata-bugs] [Maniphest] T286193: Drop subscribing to "other" aspect when using statements

2021-07-13 Thread Ladsgroup
Ladsgroup added a comment. Other usage is going down https://grafana.wikimedia.org/d/00160/wikidata-entity-usage?viewPanel=15&orgId=1&refresh=5m&from=now-30d&to=now F34549576: image.png <https://phabricator.wikimedia.org/F34549576> It'll take a wh

[Wikidata-bugs] [Maniphest] T286479: wikidata-query-gui-build job broken (unable to resolve dependency tree)

2021-07-12 Thread Ladsgroup
Ladsgroup added a comment. Form me it was this: amsa@amsa-Latitude-7480:~/gui$ npm run deploy > wikidata-query-gui@0.1.4 deploy /home/amsa/gui > grunt deploy Warning: Task "build-for-deploy" not found. Use --force to continue. Aborted

[Wikidata-bugs] [Maniphest] T259900: Update Java code example in the Wikidata Query UI

2021-07-12 Thread Ladsgroup
Ladsgroup added a comment. I deploy this. TASK DETAIL https://phabricator.wikimedia.org/T259900 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan, Ladsgroup Cc: Ladsgroup, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot

[Wikidata-bugs] [Maniphest] T286381: Drop fineGrainedLuaTracking config

2021-07-12 Thread Ladsgroup
Ladsgroup added a comment. It's default in Wikibase as well. Plus not many third party installations use wikibase client altogether. TASK DETAIL https://phabricator.wikimedia.org/T286381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lads

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-12 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T283040 WORKBOARD https

[Wikidata-bugs] [Maniphest] T233105: Month and year are sometimes parsed as the first day of the month

2021-07-12 Thread Ladsgroup
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. This is waiting on review (of https://github.com/wmde/Time/pull/148/files) if I understand it correctly. TASK

[Wikidata-bugs] [Maniphest] T281669: Frustrating delay between entering a value for a statement and being able to save

2021-07-11 Thread Ladsgroup
Ladsgroup closed this task as "Declined". Ladsgroup added a comment. I'm really sorry to say this but we decided not to fix this issue. It is a very valid issue and we understand the frustration but on the other hand the code behind this is extremely old and problematic maki

[Wikidata-bugs] [Maniphest] T280910: Wikidata Client usage tracking for redirect resolving Lua functions

2021-07-11 Thread Ladsgroup
Ladsgroup added a comment. So the patch I made above would fix the statement usage and tested locally ^. Fixing label and other usages has an intricacy. We look up values of other usages through other means (like term store) meaning we should not follow redirect directly, unless we load

[Wikidata-bugs] [Maniphest] T286381: Drop fineGrainedLuaTracking config

2021-07-09 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: User-Ladsgroup. TASK DESCRIPTION It's s

[Wikidata-bugs] [Maniphest] T285049: Run CI tests daily on master for ungated extensions

2021-07-08 Thread Ladsgroup
Ladsgroup added a comment. The jjb succeeds with the patch and there are job configs that look sensible but I'm fairly sure the project part wouldn't work, I'm not sure how can I inject the env variable here. TASK DETAIL https://phabricator.wikimedia.org/T285049 EMAIL PREF

[Wikidata-bugs] [Maniphest] T285049: Run CI tests daily on master for ungated extensions

2021-07-08 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup updated the task description. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T285049 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: DannyS712

[Wikidata-bugs] [Maniphest] T229319: InvalidArgumentSuggestion in PropertySuggester (action=wbsgetsuggestions) with invalid ID

2021-07-07 Thread Ladsgroup
Ladsgroup added a comment. Using `Status` seems most sensible thing here IMHO. It decouples the SuggesterParamsParser and the API module and gives them a shared language to speak. TASK DETAIL https://phabricator.wikimedia.org/T229319 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T259900: Update Java code example in the Wikidata Query UI

2021-07-07 Thread Ladsgroup
Ladsgroup added a comment. What about rdf4j https://rdf4j.org/documentation/programming/repository/? (section 1.6.2) TASK DETAIL https://phabricator.wikimedia.org/T259900 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup

[Wikidata-bugs] [Maniphest] T286280: Replace wfGetDB() by injecting new Db-Service in Client's SpecialEntityUsage class

2021-07-07 Thread Ladsgroup
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286280

[Wikidata-bugs] [Maniphest] T286282: Replace wfGetDB() by injecting new Db-Service in Client's populateInterwiki. maintenance script

2021-07-07 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286282

[Wikidata-bugs] [Maniphest] T286250: Replace wfGetDB() by injecting new Db-Service in Repo's DispatchStats class

2021-07-07 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286250

[Wikidata-bugs] [Maniphest] T286251: Replace wfGetDB() by injecting new Db-Service in Repo's SqlEntityIdPager class

2021-07-07 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286251 WORKBOARD

[Wikidata-bugs] [Maniphest] T286252: Replace wfGetDB() by injecting new Db-Service in Repo's SqlItemsWithoutSitelinksFinder class

2021-07-07 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286252 WORKBOARD

[Wikidata-bugs] [Maniphest] T285670: Design System: Upgrade dev docker image

2021-07-07 Thread Ladsgroup
Ladsgroup added a comment. https://github.com/wmde/wikit/pull/443 TASK DETAIL https://phabricator.wikimedia.org/T285670 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, karapayneWMDE, Aklapper, Michael, Invadibot

[Wikidata-bugs] [Maniphest] T286253: Replace wfGetDB() by injecting new Db-Service in Repo's WikiPageEntityStore class

2021-07-06 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286253

[Wikidata-bugs] [Maniphest] T286254: Replace wfGetDB() by injecting new Db-Service in Repo's SiteLinkUniquenessValidator class

2021-07-06 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T286254

[Wikidata-bugs] [Maniphest] T280910: Usage tracking for redirect resolving Lua functions

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. okay, that's not great and needs fixing indeed but I suggest fixing it by making it transient TASK DETAIL https://phabricator.wikimedia.org/T280910 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgro

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. I was thinking of asking WMF

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. I spent more than two hours just trying to make this work. It's quite messy, at the end I just abandoned it. Let's try to move the data instead. TASK DETAIL https://phabricator.wikimedia.org/T272128 EMAIL PREFERENCES https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. group() would work here but sometimes doesn't, depending on how we are transforming data. TASK DETAIL https://phabricator.wikimedia.org/T272128 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: M

[Wikidata-bugs] [Maniphest] T272128: Fix tracking for query service UI

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. One note, it's not as easy as it looks because one of the paths has an extra node. E.g. `wikibase.queryService.ui.app.result.received.success.sum` and `wikibase.queryService.ui.embed.app.result.received.success.sum` And so far `wikibase.queryServi

[Wikidata-bugs] [Maniphest] T282086: Improve Wikibase secondary CI message (Github Actions)

2021-07-06 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. It's a bit hard to test.

[Wikidata-bugs] [Maniphest] T285919: Allow links to dag.wikipedia.org from Wikidata

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. It's the same underlying problem. TASK DETAIL https://phabricator.wikimedia.org/T285919 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Vahurzpu, Urbanecm, Ladsgroup, Masssly, Lotje, Aklapper, Inva

[Wikidata-bugs] [Maniphest] T286209: Create a tests to prevent unexpected usage of ILoadBalancer and ILBFactory instances in Wikibase

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. Where the test should reside? In Lib? I want to avoid that as lib should be dismantled. In Client and repo separately? then how are going to test lib? Maybe we shouldn't test lib in this regard at all. TASK DETAIL https://phabricator.wikimedia.org/T286209

[Wikidata-bugs] [Maniphest] T280910: Usage tracking for redirect resolving Lua functions

2021-07-06 Thread Ladsgroup
Ladsgroup added a comment. "X" usage is deprecated and has caused all sorts of issues including a major outage in ruwiki, we really should avoid using it unless absolutely necessary. If I understand it correctly, the usage is transient so if I check P1

[Wikidata-bugs] [Maniphest] T285919: Allow links to dag.wikipedia.org from Wikidata

2021-07-05 Thread Ladsgroup
Ladsgroup added a comment. For now, please use https://www.wikidata.org/wiki/Special:SetSiteLink/Q33 and Special:SetSiteLink in general until I figure out how APCu cache stopped getting expired. TASK DETAIL https://phabricator.wikimedia.org/T285919 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-05 Thread Ladsgroup
Ladsgroup added a comment. Marius said we can remove it, let me make a patch on this. TASK DETAIL https://phabricator.wikimedia.org/T283040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Michael

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-05 Thread Ladsgroup
Ladsgroup added a comment. Let me double check with Marius but after that, let's remove this. TASK DETAIL https://phabricator.wikimedia.org/T283040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Lucas_Werkmeister_WMDE, Lads

[Wikidata-bugs] [Maniphest] T285919: Allow links to dag.wikipedia.org from Wikidata

2021-07-03 Thread Ladsgroup
Ladsgroup added a comment. It's clearly the caching of the APCu of nodes, just trying it on mwdebug2002 made it work: https://www.wikidata.org/w/index.php?title=Q4115189&diff=1453291485&oldid=1453122467 Why caches have not been expired after two days is interesting, pr

[Wikidata-bugs] [Maniphest] T285045: Consider dropping IE support in wikit

2021-07-02 Thread Ladsgroup
Ladsgroup added a comment. My 2c from a rather different perspective. Support for IE11 in WMF is in this weird stage of "no support for new products but keeping support for widely used/old interfaces" but it's not going to stay like this forever, we drop support for old

[Wikidata-bugs] [Maniphest] T247300: Investigate what it takes to add a __EXPECTED_UNCONNECTED_PAGE__ magic word to exclude pages from Special:UnconnectedPages

2021-07-02 Thread Ladsgroup
Ladsgroup added a comment. Exactly, I want to emphasize that page_props is not a scalability/performance concern. ALL of page_props (with wikidata, etc.) in enwiki is just 2.8GB, it's 25th biggest table. To compare, output of autoreview logs of flaggedrevs in ruwiki in just two yea

[Wikidata-bugs] [Maniphest] T285102: Don’t open entity suggestions when a valid value is already selected

2021-07-02 Thread Ladsgroup
Ladsgroup reassigned this task from Ladsgroup to Lucas_Werkmeister_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T285102 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Ladsgroup Cc: Ladsgroup, Michael, Moebeus, Manuel

[Wikidata-bugs] [Maniphest] T285104: Deploy Shellbox instance (shellbox-constraints) for Wikidata constraint regexes

2021-07-02 Thread Ladsgroup
Ladsgroup added a comment. The main person working on this is Kunal and he was busy with deploying shellbox for Score last week and dc switchover, next week is WMF holiday so I guess the week after that we can start looking at it (/me secretly wishes we had several clones of Kunal) TASK

[Wikidata-bugs] [Maniphest] T97577: [Story] Magic Word __EXPECTED_UNCONNECTED_PAGE__ to exclude pages from Special:UnconnectedPages

2021-07-01 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T97577 WORKBOARD

[Wikidata-bugs] [Maniphest] T285670: Design System: Upgrade dev docker image

2021-07-01 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. https://github.com/wmde/wikit

[Wikidata-bugs] [Maniphest] T251480: Normalize pagenames/filenames on save

2021-07-01 Thread Ladsgroup
Ladsgroup added a comment. I have been investigating this but I found a weird case, maybe introduced in new refactoring but ValueParsers are totally cut off from the rest of the code and are basically dead code now. For example check for usages of `WikibaseRepo::getValueParserFactory` is

[Wikidata-bugs] [Maniphest] T283862: Wikibase\Lib\Store\RevisionedUnresolvedRedirectException: Unresolved redirect from Q107001580 to Q41215189

2021-07-01 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. This happens basically on every type

[Wikidata-bugs] [Maniphest] T285102: Don’t open entity suggestions when a valid value is already selected

2021-07-01 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T285102

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-01 Thread Ladsgroup
Ladsgroup added a comment. Thanks for clarifying. I'm not native either, that definitely contributed to the confusion. Now I have more questions! In T283040#7189715 <https://phabricator.wikimedia.org/T283040#7189715>, @Michael wrote: > Based on the code, "Ot

[Wikidata-bugs] [Maniphest] T277738: Add missing keyboard navigation events to popover component

2021-07-01 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. https://github.com/wmde/wikit/pull/440 TASK DETAIL https://phabricator.wikimedia.org/T277738 WORKBOARD https://phabricator.wikimedia.org/project

[Wikidata-bugs] [Maniphest] T277738: Add missing keyboard navigation events to popover component

2021-07-01 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T277738 WORKBOARD

[Wikidata-bugs] [Maniphest] T283040: Aspect values are poorly documented in API help pages

2021-07-01 Thread Ladsgroup
Ladsgroup added a comment. > in particular, most of the documentation for the "Other" aspect seems out of date as it seems to actually include Alias-usage and existence checks, but not Description usage Description usage is not "Other" usage AFAIK. Am I missing

[Wikidata-bugs] [Maniphest] T285795: Decide on languages on EntityStub rdf builders

2021-07-01 Thread Ladsgroup
Ladsgroup added a comment. In T285795#7189591 <https://phabricator.wikimedia.org/T285795#7189591>, @daniel wrote: > `flavor=dump` is used primarily for updating WDQS, right? In that case, the data is polled because it is know to have changed. So caching seems pointless...

[Wikidata-bugs] [Maniphest] T285795: Decide on languages on EntityStub rdf builders

2021-07-01 Thread Ladsgroup
Ladsgroup added a comment. I think using fallback chain would be better, if the item has label in `de-at` show that, if not, then show `de` and then `en`, etc. TASK DETAIL https://phabricator.wikimedia.org/T285795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T222951: [Maintenance] Do not bind against LabelsProvider in ChangeOps

2021-07-01 Thread Ladsgroup
Ladsgroup added a comment. It sounds good to me. Please remove that TODO. TASK DETAIL https://phabricator.wikimedia.org/T222951 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Lucas_Werkmeister_WMDE, sarhan.alaa, sarhan

[Wikidata-bugs] [Maniphest] T285919: Allow links to dag.wikipedia.org from Wikidata

2021-07-01 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. This just needs caching to expire. The cache is for a day, so give it a day. TASK DETAIL https://phabricator.wikimedia.org/T285

[Wikidata-bugs] [Maniphest] T285795: Decide on languages on EntityStub rdf builders

2021-06-30 Thread Ladsgroup
Ladsgroup added a comment. Then in technical point of view having the request language (the third option) makes sense. It remains with community consultation and product to decide on what to do next. TASK DETAIL https://phabricator.wikimedia.org/T285795 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T284394: Add Wikidata support for banwikisource

2021-06-30 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T284394 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Maintenance_bot, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Nan

[Wikidata-bugs] [Maniphest] T284931: Add Wikidata support for shiwiki

2021-06-30 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T284931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Maintenance_bot, Aklapper, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Nan

[Wikidata-bugs] [Maniphest] T284459: Add Wikidata support for dagwiki

2021-06-30 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T284459 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Maintenance_bot, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Nan

[Wikidata-bugs] [Maniphest] T284931: Add Wikidata support for shiwiki

2021-06-30 Thread Ladsgroup
Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T284931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Maintenance_bot, Aklapper, Invadibot, maantietaja

[Wikidata-bugs] [Maniphest] T284394: Add Wikidata support for banwikisource

2021-06-30 Thread Ladsgroup
Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T284394 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Maintenance_bot, Invadibot, maantietaja

[Wikidata-bugs] [Maniphest] T284459: Add Wikidata support for dagwiki

2021-06-30 Thread Ladsgroup
Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T284459 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Maintenance_bot, Invadibot, maantietaja

[Wikidata-bugs] [Maniphest] T285795: Decide on languages on EntityStub rdf builders

2021-06-29 Thread Ladsgroup
Ladsgroup added a subscriber: Manuel. Ladsgroup added a comment. This is technically a task for Lydia and @Manuel to decide on. TASK DETAIL https://phabricator.wikimedia.org/T285795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc

[Wikidata-bugs] [Maniphest] T285795: Decide on languages on EntityStub rdf builders

2021-06-29 Thread Ladsgroup
Ladsgroup updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Addshore, Lydia_Pintscher, Tarrow, daniel, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T285795: Decide on languages on EntityStub rdf builders

2021-06-29 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: wdwb-tech, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore. TASK DESCRIPTION When an item uses entities (e.g. saying an statement of P31 <https://phabricator.wikimedia.org/P31>:Q5), the non-dump (flavo

[Wikidata-bugs] [Maniphest] T144248: No RDF builder defined for data type globe-coordinate nor for value type bad in DispatchingValueSnakRdfBuilder::getValueBuilder

2021-06-29 Thread Ladsgroup
Ladsgroup added a comment. One note: This still might happen in production but the chance of it happening is extremely low. So if you see one or two in production, just ignore them. Reasoning is mentioned in T285138#7183036 <https://phabricator.wikimedia.org/T285138#7183036> TASK

[Wikidata-bugs] [Maniphest] T264822: (MS 7) Security Readiness Review For Wikidata Query Builder

2021-06-29 Thread Ladsgroup
Ladsgroup added a comment. Created T285761: Add proper security headers to Query Builder <https://phabricator.wikimedia.org/T285761> for headers. Does T276366: Replace vue-cli with vite and webpack with rollup <https://phabricator.wikimedia.org/T276366> mitigate the medium s

[Wikidata-bugs] [Maniphest] T285761: Add proper security headers to Query Builder

2021-06-29 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata, Wikidata Query Builder, Wikidata-Campsite. TASK DESCRIPTION Including CSP: https://securityheaders.com/?q=https%3A%2F%2Fquery-builder-test.toolforge.org%2F&followRedirects=on TASK DETAIL https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] T285634: June 2021: appservers accumulating active php-fpm workers, requiring rolling restarts to avoid user-visible latency impact

2021-06-29 Thread Ladsgroup
Ladsgroup added a comment. This is basically done, we just need to wait to see if it continues to happen. TASK DETAIL https://phabricator.wikimedia.org/T285634 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Tarrow

[Wikidata-bugs] [Maniphest] T285634: June 2021: appservers accumulating active php-fpm workers, requiring rolling restarts to avoid user-visible latency impact

2021-06-29 Thread Ladsgroup
Ladsgroup added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. On to find and revert/fix the culprit TASK DETAIL https://phabricator.wikimedia.org/T285634 EMAIL

[Wikidata-bugs] [Maniphest] T269960: Schema properties in client code loads the whole item in every page view

2021-06-28 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. This is done. Unfortunately (or fortantely) the second issue didn't have much performance issues given the fact that short description from wikidata is enabled on some wikis and it's bound to ParserCac

[Wikidata-bugs] [Maniphest] T219215: Don’t suggest edits to real items in API sandbox

2021-06-28 Thread Ladsgroup
Ladsgroup added a comment. In T219215#7179955 <https://phabricator.wikimedia.org/T219215#7179955>, @Lucas_Werkmeister_WMDE wrote: > (I had already scheduled it for deployment later today…) And? It's assigned to me, I already said I would do it Monday. TASK

[Wikidata-bugs] [Maniphest] T283168: remove special configurations for Dagbani in Wikibase code

2021-06-26 Thread Ladsgroup
Ladsgroup moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Deploying on Monday TASK DETAIL https://phabricator.wikimedia.org/T283168 WORKBOARD https://phabricator.wikimedia.org/project/board/3539

[Wikidata-bugs] [Maniphest] T274157: Remove WikibaseRepo idGeneratorRateLimiting option

2021-06-26 Thread Ladsgroup
Ladsgroup moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Deploying on Monday TASK DETAIL https://phabricator.wikimedia.org/T274157 WORKBOARD https://phabricator.wikimedia.org/project/board/3539

[Wikidata-bugs] [Maniphest] T284538: effectively lower Item ID rate limit for bad Item creation requests

2021-06-26 Thread Ladsgroup
Ladsgroup moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Deploying on Monday TASK DETAIL https://phabricator.wikimedia.org/T284538 WORKBOARD https://phabricator.wikimedia.org/project/board/3539

[Wikidata-bugs] [Maniphest] T219215: Don’t suggest edits to real items in API sandbox

2021-06-26 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. I'll deploy it on Monday. TASK D

[Wikidata-bugs] [Maniphest] T285104: Deploy Shellbox instance (shellbox-constraints) for Wikidata constraint regexes

2021-06-23 Thread Ladsgroup
Ladsgroup closed subtask T285105: MediaWiki should support routing to different shellbox instances as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T285104 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: JMeybohm

[Wikidata-bugs] [Maniphest] T285105: MediaWiki should support routing to different shellbox instances

2021-06-23 Thread Ladsgroup
Ladsgroup moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T285105 WORKBOARD https://phabricator.wikimedia.org/project/board/35

[Wikidata-bugs] [Maniphest] T285230: Replace ILBFactory by injecting new Db-Service in Repo's pruneItemsPerSite maintenance script

2021-06-23 Thread Ladsgroup
Ladsgroup moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T285230 WORKBOARD https://phabricator.wikimedia.org/project/board/35

[Wikidata-bugs] [Maniphest] T283246: Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used

2021-06-23 Thread Ladsgroup
Ladsgroup closed subtask T285230: Replace ILBFactory by injecting new Db-Service in Repo's pruneItemsPerSite maintenance script as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T283246 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] T285290: Replace ILBFactory by injecting new Db-Service in Client's UpdateRepo class and add MaxLag functionality

2021-06-23 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T285290 WORKBOARD https://phabricator.wikimedia.org/project/board/35

[Wikidata-bugs] [Maniphest] T283246: Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used

2021-06-23 Thread Ladsgroup
Ladsgroup closed subtask T285290: Replace ILBFactory by injecting new Db-Service in Client's UpdateRepo class and add MaxLag functionality as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T283246 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T285288: Use DomainDb in SpecialUnconnectedPages

2021-06-23 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T285288 WORKBOARD https://phabricator.wikimedia.org/project/board/35

[Wikidata-bugs] [Maniphest] T283246: Use DomainDB abstraction in all places in Wikibase where DB connections are created or ILBFactory / ILoadBalancer are otherwise used

2021-06-23 Thread Ladsgroup
Ladsgroup closed subtask T285288: Use DomainDb in SpecialUnconnectedPages as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T283246 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Michael, Invadibot, m

[Wikidata-bugs] [Maniphest] T285290: Replace ILBFactory by injecting new Db-Service in Client's UpdateRepo class and add MaxLag functionality

2021-06-23 Thread Ladsgroup
Ladsgroup added a comment. Yes and no, it makes sense internally (to the core's internals and implementation) but it's conceptually less cohesive, if it's related to replication, then it should be on ReplicationWaiter, not connection manager or others. TASK

[Wikidata-bugs] [Maniphest] T281669: Frustrating delay between entering a value for a statement and being able to save

2021-06-22 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T281669 WORKBOARD

[Wikidata-bugs] [Maniphest] T285230: Replace ILBFactory by injecting new Db-Service in Repo's pruneItemsPerSite maintenance script

2021-06-22 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T285230

[Wikidata-bugs] [Maniphest] T285230: Replace ILBFactory by injecting new Db-Service in Repo's pruneItemsPerSite maintenance script

2021-06-22 Thread Ladsgroup
Ladsgroup added a comment. We don't need to readd that, LoadBalancer::resolveGroups says it adds the default group anyway. TASK DETAIL https://phabricator.wikimedia.org/T285230 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgro

[Wikidata-bugs] [Maniphest] T285288: Use DomainDb in SpecialUnconnectedPages

2021-06-22 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T285288

[Wikidata-bugs] [Maniphest] T285228: Replace ILBFactory by using the new Db-Service in Repo's dispatchChanges maint. script and classes SqlChangeDispatchCoordinator and LockManagerSqlChangeDispatchCoo

2021-06-22 Thread Ladsgroup
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T285228

[Wikidata-bugs] [Maniphest] T180771: Add monolingual language code nan-hani, cdo-hani, hak-hans, hak-hant

2021-06-22 Thread Ladsgroup
Ladsgroup added a comment. Okay, I have had enough of the json dumps moving around breaking the script. I ran this hadoop query (that's basically two weeks old) SELECT regexp_extract(claim.mainsnak.datavalue.value,',\"language\"\\:"(.+?)"'

[Wikidata-bugs] [Maniphest] T285290: Replace ILBFactory by injecting new Db-Service in Client's UpdateRepo class and add MaxLag functionality

2021-06-22 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T285290 WORKBOARD

[Wikidata-bugs] [Maniphest] T285307: Partial random dumps

2021-06-22 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: MediaWiki-extensions-WikibaseRepository, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION It's still useful to have so we can parallelize reading massive dumps. Similar to XML dumps. TASK DETAIL

[Wikidata-bugs] [Maniphest] T285290: Replace ILBFactory by injecting new Db-Service in Client's UpdateRepo class and add MaxLag functionality

2021-06-22 Thread Ladsgroup
Ladsgroup added a comment. LGTM :D TASK DETAIL https://phabricator.wikimedia.org/T285290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Addshore, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde

[Wikidata-bugs] [Maniphest] T285290: Replace ILBFactory by injecting new Db-Service in Client's UpdateRepo class and add MaxLag functionality

2021-06-22 Thread Ladsgroup
Ladsgroup added a comment. I'm a little bit hesitant to add getMaxLag to DomainDb as it would violate ISP but OTOH, I don't have a better idea. TASK DETAIL https://phabricator.wikimedia.org/T285290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefer

[Wikidata-bugs] [Maniphest] T285087: Add convenience methods to create RepoDomainDb/ClientDomainDb from IDatabase

2021-06-21 Thread Ladsgroup
Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Some not done yet: amsa@amsa-Latitude-7480:~/Wikibase$ grep -ri LBFactorySingle lib/tests/phpunit/Rdbms/LocalRepoDbTestHelper.php:use

[Wikidata-bugs] [Maniphest] T285224: Replace ILoadBalancer with using the new Db-Service in Client's DirectSqlStore

2021-06-21 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T285224

<    1   2   3   4   5   6   7   8   9   10   >