[Wikidata-bugs] [Maniphest] T271264: Add Wikidata support for trwikivoyage

2021-01-19 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. In two hours, it'll be usable. TASK DETAIL https://phabricator.wikimedia.org/T271264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper,

[Wikidata-bugs] [Maniphest] T271264: Add Wikidata support for trwikivoyage

2021-01-19 Thread Ladsgroup
Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T271264 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Maintenance_bot, Hazizibinmahdi

[Wikidata-bugs] [Maniphest] T271938: Use the DS Checkbox component in the Query Builder Limit component

2021-01-19 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Ladsgroup added a comment. https://github.com/wmde/query-builder/pull/162 TASK DETAIL https://phabricator.wikimedia.org/T271938 WORKBOARD https

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-19 Thread Ladsgroup
Ladsgroup added a comment. The tests for diff renderer is really fragile. it'll break with basically every change in diff renderer (it also breaks with change of wiki's language). It needs a rework... TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T272222: OAuth broken in MW 1.35 bundle

2021-01-19 Thread Ladsgroup
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T27

[Wikidata-bugs] [Maniphest] T272222: OAuth broken in MW 1.35 bundle

2021-01-19 Thread Ladsgroup
Ladsgroup added a comment. This is a bug in oauth extension itself. TASK DETAIL https://phabricator.wikimedia.org/T27 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, WMDE-leszek, Aklapper, JeroenDeDauw

[Wikidata-bugs] [Maniphest] T272222: OAuth broken in MW 1.35 bundle

2021-01-19 Thread Ladsgroup
Ladsgroup added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Ladsgroup added a comment. I can reproduce it. TASK DETAIL https://phabricator.wikimedia.org/T27 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc

[Wikidata-bugs] [Maniphest] T271938: Use the DS Checkbox component in the Query Builder Limit component

2021-01-19 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from ❌ Blocked to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T271938 WORKBOARD https

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-19 Thread Ladsgroup
Ladsgroup added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Ladsgroup added a comment. Yes, it's correct. I'm incident manager for wikidata team this week. I see how this can be moved forward. TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL P

[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-18 Thread Ladsgroup
Ladsgroup added subscribers: Jakob_WMDE, Ladsgroup. Ladsgroup added a comment. I don't know why we decided to go with github (maybe @Jakob_WMDE remembers?) I'm definitely fine with moving to gerrit. TASK DETAIL https://phabricator.wikimedia.org/T272130 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T265238: (MS 4) negate query

2021-01-18 Thread Ladsgroup
Ladsgroup moved this task from Test (Verification) to ❌ Blocked on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Ladsgroup added a comment. Moving back to blocked until we create and use the DS component (https://github.com/wmde/wikit/pull/350 and co) TASK DETAIL

[Wikidata-bugs] [Maniphest] T272053: (MS 2) Make the last condition removable as well

2021-01-18 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. Devouring the cookie: https://github.com/wmde/query

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

2021-01-18 Thread Ladsgroup
Ladsgroup added a subscriber: Lydia_Pintscher. Ladsgroup added a comment. In T269224#6744325 <https://phabricator.wikimedia.org/T269224#6744325>, @Lucas_Werkmeister_WMDE wrote: > In T269224#6740250 <https://phabricator.wikimedia.org/T269224#6740250>, @Ladsgroup wrote: &

[Wikidata-bugs] [Maniphest] T272140: Duplicates in the result set

2021-01-18 Thread Ladsgroup
Ladsgroup added subscribers: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Ladsgroup. Ladsgroup added a comment. So I looked at this. It's a bigger problem in general and it's due to the way we handle "not matching". It's slightly complex, so bear with me. so the

[Wikidata-bugs] [Maniphest] T271820: (MS 5) Implement Query-Builder URL sharing

2021-01-18 Thread Ladsgroup
Ladsgroup added a comment. > does the w.wiki URL shortener have a size limit for the URL? Yes, it's 1500 characters (see T220703 <https://phabricator.wikimedia.org/T220703>) TASK DETAIL https://phabricator.wikimedia.org/T271820 EMAIL PREFERENCES https://phabricator

[Wikidata-bugs] [Maniphest] T272015: Use and wire up the NegateToggle component in QueryCondition component

2021-01-15 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. https://github.com/wmde/query-builder/pull/156 TASK

[Wikidata-bugs] [Maniphest] T272014: Adjust the store: state, action, mutation, getters for the negation

2021-01-15 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. https://github.com/wmde/query-builder/pull/156 TASK

[Wikidata-bugs] [Maniphest] T272168: Result error: Incorrect display of the query result

2021-01-15 Thread Ladsgroup
Ladsgroup added a comment. hmm, thanks. https://w.wiki/uVn Says "?instance" is item of entity, meaning that the filter is not working correctly. It goes through the ladder of P279 <https://phabricator.wikimedia.org/P279> and removes the ones that have Q5 but Q5 itself

[Wikidata-bugs] [Maniphest] T272168: Result error: Incorrect display of the query result

2021-01-15 Thread Ladsgroup
Ladsgroup added a comment. I think, not 100% sure, is that the human you chose is not Q5. TASK DETAIL https://phabricator.wikimedia.org/T272168 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Lydia_Pintscher, Ladsgroup, amy_rc

[Wikidata-bugs] [Maniphest] T272168: Result error: Incorrect display of the query result

2021-01-15 Thread Ladsgroup
Ladsgroup added a comment. Ha, I can't reproduce it F34004247: image.png <https://phabricator.wikimedia.org/F34004247> Maybe it got fixed? TASK DETAIL https://phabricator.wikimedia.org/T272168 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] T272168: Result error: Incorrect display of the query result

2021-01-15 Thread Ladsgroup
Ladsgroup added a comment. Ah, you're right. I see. let me check TASK DETAIL https://phabricator.wikimedia.org/T272168 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Lydia_Pintscher, Ladsgroup, amy_rc, Aklapper, Akuckartz, Na

[Wikidata-bugs] [Maniphest] T272168: Result error: Incorrect display of the query result

2021-01-15 Thread Ladsgroup
Ladsgroup added a comment. The without part is not implemented yet and that's why it's disabled. See T265238: (MS 4) negate query <https://phabricator.wikimedia.org/T265238> for implementation. TASK DETAIL https://phabricator.wikimedia.org/T272168 EMAIL PRE

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

2021-01-15 Thread Ladsgroup
Ladsgroup added a comment. I removed that extra margin from my PR then. TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Charlie_WMDE, Lydia_Pintscher, Aklapper

[Wikidata-bugs] [Maniphest] T272012: Adjust buildQuery to produce correct SPARQL

2021-01-14 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. https://github.com/wmde/query-builder/pull/154 TASK

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

2021-01-14 Thread Ladsgroup
Ladsgroup added a comment. This would fix three issues: https://github.com/wmde/query-builder/pull/153 - Changing the breakpoint from 36em to 38em so the trash icon doesn't get squeezed - Remove the part that removes the extra margin in smallest layout - Adding a really small m

[Wikidata-bugs] [Maniphest] T266702: Move WDQS UI to microsites

2021-01-14 Thread Ladsgroup
Ladsgroup added a comment. @Dzahn Added tests ^ please take a look when you have time TASK DETAIL https://phabricator.wikimedia.org/T266702 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, dcausse, Ladsgroup, BBlack

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

2021-01-13 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T271937 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Ladsgroup Cc: Ladsgroup, Huji, Lucas_Werkmeister_WMDE, Alter-paule,

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

2021-01-13 Thread Ladsgroup
Ladsgroup added a comment. I confirm the patch fixes both issues: F33997945: image.png <https://phabricator.wikimedia.org/F33997945> F33997947: image.png <https://phabricator.wikimedia.org/F33997947> TASK DETAIL https://phabricator.wikimedia.org/T271937 EMAIL PREFERE

[Wikidata-bugs] [Maniphest] T271937: RTL languages in Glosses should be aligned to right when editing

2021-01-13 Thread Ladsgroup
Ladsgroup added a comment. In T271937#6744007 <https://phabricator.wikimedia.org/T271937#6744007>, @Lucas_Werkmeister_WMDE wrote: > @Ladsgroup I assume those language inputs should //all// be RTL, since they contain Persian language names? Funnily enough, they have the

[Wikidata-bugs] [Maniphest] T239931: Reduce the impact of the sanitizer on wikidata

2021-01-13 Thread Ladsgroup
Ladsgroup added a comment. I see. The impact doesn't show up in the term store and db, where it matters the most. So it's good to consider done IMO. TASK DETAIL https://phabricator.wikimedia.org/T239931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] T239931: Reduce the impact of the sanitizer on wikidata

2021-01-13 Thread Ladsgroup
Ladsgroup added a comment. It shouldn't hit ParserCache anymore but it seems we got it again? https://grafana.wikimedia.org/d/00106/parser-cache?viewPanel=8&from=now-12h&orgId=1&to=now&var-contentModel=wikibase_item&var-contentModel=wikibase_prop

[Wikidata-bugs] [Maniphest] T267631: Add debounce to PropertyLookup

2021-01-12 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Ladsgroup added a comment. https://github.com/wmde/query-builder/pull/147 TASK DETAIL https://phabricator.wikimedia.org/T267631 WORKBOARD https

[Wikidata-bugs] [Maniphest] T266702: Move WDQS UI to microsites

2021-01-12 Thread Ladsgroup
Ladsgroup added a comment. Filed T271851: Clean up gui from the wdqs deploy repo and puppet <https://phabricator.wikimedia.org/T271851> for clean up TASK DETAIL https://phabricator.wikimedia.org/T266702 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] T271851: Clean up gui from the wdqs deploy repo and puppet

2021-01-12 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added a project: Wikidata Query UI. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Since T266702: Move WDQS UI to microsites <https://phabricator.wikimedia.org/T266702> i

[Wikidata-bugs] [Maniphest] T271809: More automation for the deployment of cxserver and Wikidata when creating new wikis

2021-01-12 Thread Ladsgroup
Ladsgroup added a comment. So on the Wikidata-side, it's documented here: https://wikitech.wikimedia.org/wiki/Add_a_wiki#Wikidata Technically it's rather straightforward to automate (it's just rebuilding sites table for all wikis) but in reality, the script fails from tim

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

2021-01-12 Thread Ladsgroup
Ladsgroup added a comment. In T269224#6740202 <https://phabricator.wikimedia.org/T269224#6740202>, @Michael wrote: > In T269224#6736658 <https://phabricator.wikimedia.org/T269224#6736658>, @Lucas_Werkmeister_WMDE wrote: > >> The example at https://develope

[Wikidata-bugs] [Maniphest] T266702: Move WDQS UI to microsites

2021-01-12 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. This is done now. Thanks to everyone who helped! macro-deployed <https://phab.wmfusercontent.org/file/data/2d5uvrv25hlfmxj4edhg/PHID-FILE-mxb5p3d3useylsggljvw/meme-323px-Athena_1_rocket_launching_from_Kodi

[Wikidata-bugs] [Maniphest] T266702: Move WDQS UI to microsites

2021-01-12 Thread Ladsgroup
Ladsgroup updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266702 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, dcausse, Ladsgroup, BBlack, Gehel, Dzahn, Addshore, Aklapper, Ramtin0071

[Wikidata-bugs] [Maniphest] T270424: Create Grafana boards for QueryService UI metrics specific to the QueryBuilder

2021-01-12 Thread Ladsgroup
Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T270424 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Lydia_Pintscher, Aklapper, Michael

[Wikidata-bugs] [Maniphest] T270424: Create Grafana boards for QueryService UI metrics specific to the QueryBuilder

2021-01-11 Thread Ladsgroup
Ladsgroup added subscribers: Lydia_Pintscher, Ladsgroup. Ladsgroup moved this task from ❌ Blocked to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Ladsgroup added a comment. https://grafana-rw.wikimedia.org/d/RA1j2T0Mk/wikidata-query-builder?orgId=1

[Wikidata-bugs] [Maniphest] T270413: Add Wikidata support for niawiktionary

2021-01-11 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. Wait two hours and it's ready. TASK DETAIL https://phabricator.wikimedia.org/T270413 EMAIL PREF

[Wikidata-bugs] [Maniphest] T270279: Add Wikidata support for diqwiktionary

2021-01-11 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. Wait two hours and it's ready. TASK DETAIL https://phabricator.wikimedia.org/T270279 EMAIL PREF

[Wikidata-bugs] [Maniphest] T270417: Add Wikidata support for niawiki

2021-01-11 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. Wait two hours and it's ready. TASK DETAIL https://phabricator.wikimedia.org/T270417 EMAIL PREF

[Wikidata-bugs] [Maniphest] T267631: Add debounce to PropertyLookup

2021-01-11 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T267631 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T271007: Add Wikidata support for uzwikimedia

2021-01-10 Thread Ladsgroup
Ladsgroup changed the status of subtask T270987: Create a wiki for Wikimedians of the Uzbek language User Group from "Open" to "Stalled". TASK DETAIL https://phabricator.wikimedia.org/T271007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefere

[Wikidata-bugs] [Maniphest] T271548: Add Wikidata support for in_techwikimedia

2021-01-09 Thread Ladsgroup
Ladsgroup changed the status of subtask T271539: Create Indic MediaWiki Developers User Group wiki from "Open" to "Stalled". TASK DETAIL https://phabricator.wikimedia.org/T271548 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreference

[Wikidata-bugs] [Maniphest] T269470: (MS 2) A Decorator visually frames the query conditions

2021-01-08 Thread Ladsgroup
Ladsgroup added a comment. I got some of the issues fixed in https://github.com/wmde/query-builder/pull/143 but e.g. the third case, I don't what's pushing the input to stop shrinking. TASK DETAIL https://phabricator.wikimedia.org/T269470 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T265243: get initial metrics

2021-01-08 Thread Ladsgroup
Ladsgroup added a comment. T271567: statsv seems to be down <https://phabricator.wikimedia.org/T271567> TASK DETAIL https://phabricator.wikimedia.org/T265243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Michael, Lad

[Wikidata-bugs] [Maniphest] T266702: Move WDQS UI to microsites

2021-01-08 Thread Ladsgroup
Ladsgroup added a comment. Thanks. You can also simply use this form too: https://integration.wikimedia.org/ci/job/operations-puppet-catalog-compiler/build?delay=0sec I did it and put the result in the patch. Let's merge it next week. TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] T266702: Move WDQS UI to microsites

2021-01-08 Thread Ladsgroup
Ladsgroup added a comment. My knowledge in here is not that great but this should work ^ TASK DETAIL https://phabricator.wikimedia.org/T266702 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, dcausse, Ladsgroup, BBlack

[Wikidata-bugs] [Maniphest] T266456: Handling partially supported datatypes

2021-01-06 Thread Ladsgroup
Ladsgroup added a comment. Yeah, this would fix most of it https://github.com/wmde/query-builder/pull/124 TASK DETAIL https://phabricator.wikimedia.org/T266456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup

[Wikidata-bugs] [Maniphest] T266702: Move WDQS UI to microsites

2021-01-04 Thread Ladsgroup
Ladsgroup added a comment. In T266702#6662363 <https://phabricator.wikimedia.org/T266702#6662363>, @Addshore wrote: > Notes from the call: > > - Branches for gui deploy repo - for WDQS and WCQS > - in the meantime, keep both approaches to deployment of GUI &g

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

2021-01-04 Thread Ladsgroup
Ladsgroup added a comment. In T269224#6719125 <https://phabricator.wikimedia.org/T269224#6719125>, @Michael wrote: > Ok, then let's try `document.URL` 👍 > > If you have a link to share that goes into more detail as to what is available to JS in an iframe, then

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

2021-01-04 Thread Ladsgroup
Ladsgroup moved this task from Done to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Ladsgroup added a comment. It got deployed and it seems it didn't work. I investigated and this came up. ^ TASK DETAIL https://phabricator.wikimedia.org/T2

[Wikidata-bugs] [Maniphest] T180771: Add monolingual language code nan-hani, cdo-hani, hak-hans, hak-hant

2021-01-01 Thread Ladsgroup
Ladsgroup added a subscriber: Mbch331. Ladsgroup added a comment. @Mbch331 Does langcom approve this patch then? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/555688/ TASK DETAIL https://phabricator.wikimedia.org/T180771 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T268546: Convert EntitySchema to AbstractSchema

2020-12-22 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup assigned this task to Reedy. TASK DETAIL https://phabricator.wikimedia.org/T268546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy, Ladsgroup Cc: Aklapper, Reedy, Naike, Alter-paule,

[Wikidata-bugs] [Maniphest] T268570: Convert PropertySuggester to AbstractSchema

2020-12-22 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup assigned this task to Reedy. TASK DETAIL https://phabricator.wikimedia.org/T268570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy, Ladsgroup Cc: Aklapper, Reedy, Naike, Alter-paule,

[Wikidata-bugs] [Maniphest] T253245: Re-run SS1 to get an accurate list of whitelisted external identifiers

2020-12-22 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T253245 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, ItamarWMDE, Hazizibinmahdi, Ferdinand0101, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

2020-12-20 Thread Ladsgroup
Ladsgroup added a comment. These specs seem to be rather old. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

2020-12-18 Thread Ladsgroup
Ladsgroup added a comment. This doesn't a design spec attached to it. Am I missing something? (I was thinking of implementing it without design system for now, with less than optimal look) but can't find any design to get some inspiration from :D TASK DETA

[Wikidata-bugs] [Maniphest] T266702: Move WDQS UI to microsites

2020-12-18 Thread Ladsgroup
Ladsgroup added a comment. What can we do to move this forward? TASK DETAIL https://phabricator.wikimedia.org/T266702 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, dcausse, Ladsgroup, BBlack, Gehel, Dzahn, Addshore

[Wikidata-bugs] [Maniphest] T269224: Track outcome of Query Builder queries via embedded query service js

2020-12-17 Thread Ladsgroup
Ladsgroup added a comment. In T269224#6699377 <https://phabricator.wikimedia.org/T269224#6699377>, @Michael wrote: > This still needs a few things: > > [ ] the change needs to be deployed > [ ] we need Grafana boards for it I was doing it as part of the sto

[Wikidata-bugs] [Maniphest] T270349: Some design system icons need RTL version

2020-12-16 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata Design System, RTL. Restricted Application added a subscriber: Aklapper. Restricted Application added projects: Wikidata, I18n. TASK DESCRIPTION The icons in the design system sometimes need to be flipped for RTL interfaces like

[Wikidata-bugs] [Maniphest] T269142: Create "quiet" button variant

2020-12-15 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Ladsgroup added a comment. https://github.com/wmde/wikit/pull/324 TASK DETAIL https://phabricator.wikimedia.org/T269142 WORKBOARD https

[Wikidata-bugs] [Maniphest] T266713: Uncaught Error: Syntax error, unrecognized expression: unsupported pseudo: wikibase-statementview

2020-12-15 Thread Ladsgroup
Ladsgroup added a comment. carltondance <https://phab.wmfusercontent.org/file/data/gwgsu4dfokvzu2iydwrf/PHID-FILE-sq2cyn5s7xihg7ozsms7/meme-aWwke.gif> TASK DETAIL https://phabricator.wikimedia.org/T266713 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T269142: Create "quiet" button variant

2020-12-15 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T269142 WORKBOARD https

[Wikidata-bugs] [Maniphest] T269142: Create "quiet" button variant

2020-12-15 Thread Ladsgroup
Ladsgroup updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T269142 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-15 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Ladsgroup added a comment. https://github.com/wmde/query-builder/pull/102 TASK DETAIL https://phabricator.wikimedia.org/T269439 WORKBOARD https

[Wikidata-bugs] [Maniphest] T269435: Add Wikidata support for wawikisource

2020-12-15 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. It should be usable in two hours when caches expire. TASK DETAIL https://phabricator.wikimedia.org/T269435 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T268461: Add Wikidata support for skrwiktionary

2020-12-15 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. It should be usable in two hours when caches expire. TASK DETAIL https://phabricator.wikimedia.org/T268461 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T268415: Add Wikidata support for skrwiki

2020-12-15 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. It should be usable in two hours when caches expire. TASK DETAIL https://phabricator.wikimedia.org/T268415 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T269443: Add Wikidata support for madwiki

2020-12-15 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. It should be usable in two hours when caches expire. TASK DETAIL https://phabricator.wikimedia.org/T269443 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T269430: Add Wikidata support for eowikivoyage

2020-12-15 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. It should be usable in two hours when caches expire. TASK DETAIL https://phabricator.wikimedia.org/T269430 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T269438: Postcss requires dir=ltr or dir=rtl, we have dir=auto

2020-12-14 Thread Ladsgroup
Ladsgroup added a comment. And this is used in termbox: https://github.com/wikimedia/wikibase-termbox/blob/f4fe65079bb45193432ef81105387b939c2f4569/src/types/server/rtl-detect.d.ts TASK DETAIL https://phabricator.wikimedia.org/T269438 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T269438: Postcss requires dir=ltr or dir=rtl, we have dir=auto

2020-12-14 Thread Ladsgroup
Ladsgroup added a comment. We also have banana-i18n installed, you can use https://github.com/wikimedia/banana-i18n/blob/a120a55cb1315975281212ca86cd3b7b5ff19b62/src/emitter.js#L248 if needed. Whatever you prefer. TASK DETAIL https://phabricator.wikimedia.org/T269438 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T270093: wmf-21 Wikibase phpunit tests are failing

2020-12-14 Thread Ladsgroup
Ladsgroup assigned this task to Michael. Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. Restricted Application added a project: User-Michael. Thanks! rebased on deploy1001 TASK DETAIL https://phabricator.wikimedia.org/T270093 EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-14 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T269439 WORKBOARD https

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-14 Thread Ladsgroup
Ladsgroup added a comment. Why not? It's Christmas! *insert jingle bells music* TASK DETAIL https://phabricator.wikimedia.org/T269439 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: guergana.tzatchkova, Ladsgroup, Aklapper, Mi

[Wikidata-bugs] [Maniphest] T270093: wmf-21 Wikibase phpunit tests are failing

2020-12-14 Thread Ladsgroup
Ladsgroup added a comment. It needs to be rebased on deploy1001, otherwise fine. I can do it. Let's wait to see if jenkins is happy. TASK DETAIL https://phabricator.wikimedia.org/T270093 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lads

[Wikidata-bugs] [Maniphest] T270093: wmf-21 Wikibase phpunit tests are failing

2020-12-14 Thread Ladsgroup
Ladsgroup added a comment. In T270093#6688626 <https://phabricator.wikimedia.org/T270093#6688626>, @Lucas_Werkmeister_WMDE wrote: > Seems to be T269608 <https://phabricator.wikimedia.org/T269608> – the fixes aren’t on wmf.21, I guess. Shall we backport? It'll bl

[Wikidata-bugs] [Maniphest] T269960: Schema properties in client code loads the whole item in every page view

2020-12-14 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. This is done I assume? TASK DETAIL https://phabricator.wikimedia.org/T269960 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] T269960: Schema properties in client code loads the whole item in every page view

2020-12-14 Thread Ladsgroup
Ladsgroup added a comment. https://grafana.wikimedia.org/d/00316/memcache?viewPanel=22&orgId=1&from=now-1h&to=now This basically shows a 100MB/s drop in memcache traffic F33945415: image.png <https://phabricator.wikimedia.org/F33945415> Also, a 2% increase in

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

2020-12-13 Thread Ladsgroup
Ladsgroup added a comment. Regarding that why number of RL modules should be kept at minimum T264334#6523308 <https://phabricator.wikimedia.org/T264334#6523308> might be useful. TLDR, it's a cost to get a way bigger gain. TASK DETAIL https://phabricator.wikimedia.org/T22

[Wikidata-bugs] [Maniphest] T266713: Uncaught Error: Syntax error, unrecognized expression: unsupported pseudo: wikibase-statementview

2020-12-12 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. At first I completely broke it then completely fixed it (and tried it). I call it done, reopen if it continues to logspam T

[Wikidata-bugs] [Maniphest] T266713: Uncaught Error: Syntax error, unrecognized expression: unsupported pseudo: wikibase-statementview

2020-12-12 Thread Ladsgroup
Ladsgroup added a comment. The module that uses that file is `wikibase.view.ControllerViewFactory` let me wrap the whole thing around that and see how it goes. TASK DETAIL https://phabricator.wikimedia.org/T266713 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T198946: Add Schema property 'sameAs' pointing to Wikidata entries

2020-12-11 Thread Ladsgroup
Ladsgroup added a comment. Caused: T269960: Schema properties in client code loads the whole item in every page view <https://phabricator.wikimedia.org/T269960> TASK DETAIL https://phabricator.wikimedia.org/T198946 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T269960: Schema properties in client code loads the whole item in every page view

2020-12-11 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The code added as part of T198946: Add Schema property 'sameAs' pointing to Wikidata entries <https://phabricator.wikimedia.org/T198946>

[Wikidata-bugs] [Maniphest] T269754: Investigate building metrics for time to fix production errors

2020-12-10 Thread Ladsgroup
Ladsgroup added a comment. The numbers: time-from-create-to-tag-wikidata Average: 13.595595850480109 Median 0.028981481481481483 Number 135 time-from-create-to-resolve Average: 48.324862117552335 Median 15.882303240740741 Number 115 time-from-tag-wikidata-to-resolve Average

[Wikidata-bugs] [Maniphest] T269754: Investigate building metrics for time to fix production errors

2020-12-09 Thread Ladsgroup
Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T269754 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Ladsgroup, Hazizibinmahdi, Akuckartz

[Wikidata-bugs] [Maniphest] T269754: Investigate building metrics for time to fix production errors

2020-12-09 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata Infrastructure Reliability Sprint Dec 2020, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Using phabricator API TASK DETAIL https://phabricator.wikimedia.org/T269754 WORKBOARD https

[Wikidata-bugs] [Maniphest] T269675: Do an anlysis of wikidata requests in xhgui and arclamp

2020-12-08 Thread Ladsgroup
Ladsgroup added a comment. Okay, I built flame graphs of anything that has wikibase in it for a total day. Note on how to use these files, they are not just large svg files, they have javascript code in them and they are pretty interactive, you can zoom in, click on a part to zoom to

[Wikidata-bugs] [Maniphest] T269675: Do an anlysis of wikidata requests in xhgui and arclamp

2020-12-08 Thread Ladsgroup
Ladsgroup added a comment. https://performance.wikimedia.org/arclamp/svgs/daily/2020-12-07.excimer.index.svgz and this TASK DETAIL https://phabricator.wikimedia.org/T269675 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper

[Wikidata-bugs] [Maniphest] T269675: Do an anlysis of wikidata requests in xhgui and arclamp

2020-12-08 Thread Ladsgroup
Ladsgroup added a comment. This took so long to find: https://performance.wikimedia.org/arclamp/logs/daily/ I leave it here for now. TASK DETAIL https://phabricator.wikimedia.org/T269675 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Wikidata-bugs] [Maniphest] T269675: Do an anlysis of wikidata requests in xhgui and arclamp

2020-12-08 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata Infrastructure Reliability Sprint Dec 2020, Wikidata. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: User-Ladsgroup. TASK DESCRIPTION Similar to T243915: Performance audit of Wikibase

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Ladsgroup
Ladsgroup added a comment. Indeed, we should get the list of the ones that are string value type but different rdf builder, can work on that a bit later. TASK DETAIL https://phabricator.wikimedia.org/T269439 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Ladsgroup
Ladsgroup added a comment. That's an interesting observation. The Commons media data type is a string value type so if we want to check in json, it works but the rdf output checks against a different value (its own prefix, etc.) TASK DETAIL https://phabricator.wikimedia.org/T269439

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Ladsgroup
Ladsgroup added a comment. I'm not sure if that's the case. `P14` is a commons media datatype which we don't support yet and that query is not done correctly. What we do support seems to work (Should not show https://www.wikidata.org/wiki/Q84365153) and it doesn't

[Wikidata-bugs] [Maniphest] T269315: Fatal error: Cannot pass parameter 1 by reference (Wikibase\DataModel\Entity)

2020-12-04 Thread Ladsgroup
Ladsgroup edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DETAIL https://phabricator.wikimedia.org/T269315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore, hashar

[Wikidata-bugs] [Maniphest] T269134: Extend QueryRepresentation to contain a list of conditions

2020-12-04 Thread Ladsgroup
Ladsgroup moved this task from To Do to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. https://github.com/wmde/query-builder/pull/94

[Wikidata-bugs] [Maniphest] T269412: Wire tags into MenuItems in QB

2020-12-03 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 5) board. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. https://github.com/wmde/wikit/pull/312 TASK DETAIL

<    5   6   7   8   9   10   11   12   13   14   >