[Wikidata-bugs] [Maniphest] [Updated] T231887: investigation for ensuring editing with the same credentials

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-6. TASK DETAIL https://phabricator.wikimedia.org/T231887 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Pablo-WMDE Cc: Matthias_Geisler_WMDE, Addshore, Aklapper, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Updated] T232998: Pass wgEditSubmitButtonLabelPublish variable from bridge config (init) to ProcessDialog component

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a project: Wikidata-Bridge-Sprint-6. TASK DETAIL https://phabricator.wikimedia.org/T232998 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Updated] T228261: Extract TermTextField to a 3rd repo and use it from there

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge; removed Wikidata-Bridge-Sprint-5, Wikidata-Bridge-Sprint-4, Wikidata-Bridge-Sprint-3, Wikidata-Bridge-Sprint-2. TASK DETAIL https://phabricator.wikimedia.org/T228261 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://gerrit.wikimedia.org/r/534766 was done when this issue was first discussed and may or may not help with resolving this, now that there is a formal ticket for it. TASK DETAIL https://phabricator.wikimedia.org/T232595 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Created] T233791: Add cancel button

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - pimp EventEmittingButton to contain the cancel modification - add asset (@Charlie_WMDE are we right in assuming this is

[Wikidata-bugs] [Maniphest] [Created] T233793: React to escape

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T233793 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T233795: Add cancel button to app and emit close event

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T233795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T233794: React to app's cancel event

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - in `subscribeToAppEvents()` - in `mock-entry` TASK DETAIL https://phabricator.wikimedia.org/T233794 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Edited] T233793: React to escape

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T233793 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Edited] T233791: Add cancel button

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T233791 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, Charlie_WMDE, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Created] T233796: browser test canceling

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-6. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T233796 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Edited] T233795: Add cancel button to app and emit close event

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T233795 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T224834: test data for demo system

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a comment. We created https://en.wikipedia.beta.wmflabs.org/wiki/Data-Bridge as the place for the showcase (needs to be changed per the task) but decided to maintain https://de.wikipedia.beta.wmflabs.org/wiki/Data-Bridge as the technical playground (table with one line per

[Wikidata-bugs] [Maniphest] [Commented On] T231209: investigation about permissions and protection

2019-09-25 Thread Pablo-WMDE
Pablo-WMDE added a comment. Maybe we can illustrate the different versions we envision in a sequence diagram <https://wikitech.wikimedia.org/wiki/User:Pablo_Grass_(WMDE)/wikidata/data-bridge/sequence> to ease others understanding the differences and consequences. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Claimed] T233791: Add cancel button

2019-09-26 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T233791 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, Charlie_WMDE, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T233796: browser test canceling

2019-09-27 Thread Pablo-WMDE
Pablo-WMDE added a comment. A first browser test, for esc, is already there. TASK DETAIL https://phabricator.wikimedia.org/T233796 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Edited] T233796: browser test canceling

2019-09-27 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T233796 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Updated] T233314: Disable/Prevent Browser Cache of Ajax-request to Special:EntityData

2019-10-02 Thread Pablo-WMDE
Pablo-WMDE added a comment. Restricted Application added a project: Wikidata. Apparently this was discovered in the wild now: T233314 <https://phabricator.wikimedia.org/T233314> TASK DETAIL https://phabricator.wikimedia.org/T233314 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Merged] T128667: Special:EntityData with flavor is cached but not purged properly

2019-10-02 Thread Pablo-WMDE
Pablo-WMDE merged a task: T233314: Disable/Prevent Browser Cache of Ajax-request to Special:EntityData. Pablo-WMDE added subscribers: Michael, Pablo-WMDE. TASK DETAIL https://phabricator.wikimedia.org/T128667 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T233314: Disable/Prevent Browser Cache of Ajax-request to Special:EntityData

2019-10-02 Thread Pablo-WMDE
Pablo-WMDE closed this task as a duplicate of T128667: Special:EntityData with flavor is cached but not purged properly. TASK DETAIL https://phabricator.wikimedia.org/T233314 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T234428: close.svg is not cached in the browser

2019-10-07 Thread Pablo-WMDE
Pablo-WMDE added a comment. Looking good for me (on DE beta): F30580528: Bildschirmfoto von 2019-10-07 12-43-28.png <https://phabricator.wikimedia.org/F30580528> TASK DETAIL https://phabricator.wikimedia.org/T234428 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Edited] T234060: Exhibit native behavior on key+click on bridge link

2019-10-07 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T234060 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Matthias_Geisler_WMDE, Michael, Lucas_Werkmeister_WMDE, Pablo-WMDE, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] [Edited] T232468: Illustrate loading

2019-10-08 Thread Pablo-WMDE
Pablo-WMDE updated the task description. Restricted Application added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T232468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Michael, Lydia_Pintscher, Charlie_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T231209: investigation about permissions and protection

2019-10-08 Thread Pablo-WMDE
Pablo-WMDE added a comment. - FTR traditional wikibase <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/46200e8624c099ec3045fbb51cc8e58d2e1cfc3f/repo/resources/wikibase.ui.entityViewInit.js> and termbox <https://gerrit.wikimedia.org/r/plugins/gitiles/wikibas

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

2019-10-08 Thread Pablo-WMDE
Pablo-WMDE added a comment. Personal opinion: in edit mode, form fields inside the grayed-out areas look like they are read-only now. F30592702: Bildschirmfoto von 2019-10-08 18-50-51.png <https://phabricator.wikimedia.org/F30592702> TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T228857: Investigate common.js bundle content/size

2019-10-08 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Lucas_Werkmeister_WMDE With regards to browserslist behaving funny: try, to rule something <https://mattermost.wikimedia.de/swe/pl/pt1aw1yrqjdgupyh1tkr9rnq3o> out, to run the build in an env where the directories from data-bridge up are not present. TASK

[Wikidata-bugs] [Maniphest] [Commented On] T235069: Termbox in labs should be able to recover crashes

2019-10-09 Thread Pablo-WMDE
Pablo-WMDE added a comment. Surprised (after a full 3 seconds of thinking about it) this is not covered by this <https://gerrit.wikimedia.org/r/plugins/gitiles/wikibase/termbox/+/bd69d5a25d8bdd10d8de5ac397c4b5b8b4c3bc33/infrastructure/templates/termbox.service.j2#4>. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T229241: restrict length of string value input

2019-10-09 Thread Pablo-WMDE
Pablo-WMDE added a comment. > I would just keep it simple for now and mark it as unstable and only for use with the bridge. > Just include what you need there, and call it something like wbbridgesettings for now? > I can defiantly see a need for more things like this in the futu

[Wikidata-bugs] [Maniphest] [Commented On] T231209: investigation about permissions and protection

2019-10-09 Thread Pablo-WMDE
Pablo-WMDE added a comment. Discussed with @Lydia_Pintscher and @Charlie_WMDE Client: destroy bridge-enabled links if user does not have permission to edit on client Repo: show message that editing is not permitted. factor reason (e.g. a block) into the message TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Created] T235208: Show updated information after saving

2019-10-10 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added a project: Wikidata-Bridge. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION As a user I want to see that information inside the article and infobox which I just saved

[Wikidata-bugs] [Maniphest] [Updated] T227758: [investigate] purging strategy

2019-10-10 Thread Pablo-WMDE
Pablo-WMDE added a subscriber: Charlie_WMDE. Pablo-WMDE added a comment. These are sound explanations - updated our sequence diagram <https://wikitech.wikimedia.org/wiki/User:Pablo_Grass_(WMDE)/wikidata/data-bridge/sequence> to contain the "purging strategy". Should be actio

[Wikidata-bugs] [Maniphest] [Closed] T227758: [investigate] purging strategy

2019-10-10 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T227758 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Pablo-WMDE Cc: Charlie_WMDE, Michael, aaron, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Edited] T235261: Investigate why Termbox CSR failed to override mismatching SSR markup

2019-10-11 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T235261 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: alaa_wmde, Aklapper, Jakob_WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Claimed] T235036: Implement RepoConfigRepository via wbdatabridgeconfig API

2019-10-14 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T235036 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T235429: Mismatched frontend JS and backend DOM should not be shipped

2019-10-15 Thread Pablo-WMDE
Pablo-WMDE added a comment. //Somewhat// related: T128486: [Story] Purge Special:EntityData JSON after edit <https://phabricator.wikimedia.org/T128486> TASK DETAIL https://phabricator.wikimedia.org/T235429 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Claimed] T235037: Set up RepoConfigRepository in init and pass into launch / app

2019-10-15 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T235037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Unassigned] T235037: Set up RepoConfigRepository in init and pass into launch / app

2019-10-15 Thread Pablo-WMDE
Pablo-WMDE removed Pablo-WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T235037 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Michael

[Wikidata-bugs] [Maniphest] [Commented On] T235037: Set up RepoConfigRepository in init and pass into launch / app

2019-10-15 Thread Pablo-WMDE
Pablo-WMDE added a comment. Moving this back to todo, because https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/542957/ already contains the using and polluting dist just for the 1-line-change to `client/data-bridge/src/mediawiki/createServices.ts` is not worth it. TASK

[Wikidata-bugs] [Maniphest] [Unblock] T229241: restrict length of string value input

2019-10-15 Thread Pablo-WMDE
Pablo-WMDE closed subtask T235036: Implement RepoConfigRepository via wbdatabridgeconfig API as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T229241 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMD

[Wikidata-bugs] [Maniphest] [Closed] T235036: Implement RepoConfigRepository via wbdatabridgeconfig API

2019-10-15 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T235036 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318

[Wikidata-bugs] [Maniphest] [Commented On] T229241: restrict length of string value input

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. This can now be observed on beta <https://de.wikipedia.beta.wmflabs.org/wiki/Data-Bridge>. F30760549: Bildschirmfoto von 2019-10-16 11-49-45.png <https://phabricator.wikimedia.org/F30760549> TASK DETAIL https://phabricator.wikimedia.org/T2

[Wikidata-bugs] [Maniphest] [Updated] T235623: header height too big

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. Might by caused by the close button dimensions - T235624: close button size is not correct <https://phabricator.wikimedia.org/T235624> TASK DETAIL https://phabricator.wikimedia.org/T235623 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T235622: scrollbar breaks the modal

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. "underneath" (on a layer under) vs. "below" (south of)? TASK DETAIL https://phabricator.wikimedia.org/T235622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Ak

[Wikidata-bugs] [Maniphest] [Updated] T228896: investigate page reload vs. in place replacement after edit

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. This is, as I see it, replaced by T235208: Show updated information after saving <https://phabricator.wikimedia.org/T235208> TASK DETAIL https://phabricator.wikimedia.org/T228896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T128486: [Story] Purge Special:EntityData JSON after edit

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. Crazy idea suggested by a pragmatic fellow programmer: why don't we simply use our API if we don't want stale information? TASK DETAIL https://phabricator.wikimedia.org/T128486 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Commented On] T235622: scrollbar breaks the modal

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. That is my interpretation as well, but @Charlie_WMDE calls the shots. TASK DETAIL https://phabricator.wikimedia.org/T235622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Pablo

[Wikidata-bugs] [Maniphest] [Commented On] T229241: restrict length of string value input

2019-10-17 Thread Pablo-WMDE
Pablo-WMDE added a comment. Given that neither of the newly filed issues originated in this story, would it be fair to call this done? TASK DETAIL https://phabricator.wikimedia.org/T229241 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo

[Wikidata-bugs] [Maniphest] [Commented On] T233305: delayed kicking in of Bridge

2019-10-17 Thread Pablo-WMDE
Pablo-WMDE added a comment. > init.js ... Why do we send it through Babel etc. at all? > trading some development convenience for a drastic reduction in script size. We should be able to find a configuration that works for us, instead of us working around the tool chain we pic

[Wikidata-bugs] [Maniphest] [Created] T235765: Attach link listeners

2019-10-17 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added a project: Wikidata-Bridge. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION As as user I want links which qualify for bridge to truly opened in bridge. To achieve this, the

[Wikidata-bugs] [Maniphest] [Retitled] T235765: Attach link listeners sooner

2019-10-17 Thread Pablo-WMDE
Pablo-WMDE renamed this task from "Attach link listeners " to "Attach link listeners sooner". TASK DETAIL https://phabricator.wikimedia.org/T235765 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo

[Wikidata-bugs] [Maniphest] [Created] T235771: Move service creation out of init

2019-10-17 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added a project: Wikidata-Bridge. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION As as user I want links which qualify for bridge to truly opened in bridge. A smaller `init` file

[Wikidata-bugs] [Maniphest] [Commented On] T233305: delayed kicking in of Bridge

2019-10-17 Thread Pablo-WMDE
Pablo-WMDE added a comment. Created the two tickets we discussed (thanks for having the same idea!). TASK DETAIL https://phabricator.wikimedia.org/T233305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Pablo-WMDE Cc

[Wikidata-bugs] [Maniphest] [Commented On] T232595: Make it possible to collapse the "All entered languages" section when at the end of the section

2019-10-17 Thread Pablo-WMDE
Pablo-WMDE added a comment. Observation: two "fewer languages" buttons can look funny if there are no "more languages" at all. (observed with latest termbox on my dev system) F30811091: Bildschirmfoto von 2019-10-17 17-44-49.png <https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Updated] T233305: delayed kicking in of Bridge

2019-10-18 Thread Pablo-WMDE
Pablo-WMDE added a comment. I suggest we close this now and take on T235765 <https://phabricator.wikimedia.org/T235765> and T235771 <https://phabricator.wikimedia.org/T235771>. On completion of the latter we should take a look at the size of the init bundle and re-evaluat

[Wikidata-bugs] [Maniphest] [Closed] T233305: delayed kicking in of Bridge

2019-10-18 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board. TASK DETAIL https://phabricator.wikimedia.org/T233305 WORKBOARD https://phabricator.wikimedia.org/project/board/4316/ EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] [Commented On] T233305: delayed kicking in of Bridge

2019-10-21 Thread Pablo-WMDE
Pablo-WMDE added a comment. > I am not yet satisfied with the (lack of) discussion about my second suggestion, to stop using webpack for the init module We should look at arguments, and compare pros and cons. So far we only have a suggestion for a change in technology but no measura

[Wikidata-bugs] [Maniphest] [Unblock] T219158: 'IP visibility' and 'Terms of use' information on termbox editing

2019-10-28 Thread Pablo-WMDE
Pablo-WMDE closed subtask T221835: Add CC0 License overlay popup on termbox editing as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T219158 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: W

[Wikidata-bugs] [Maniphest] [Closed] T221835: Add CC0 License overlay popup on termbox editing

2019-10-28 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T221835 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Addshore, Aklapper, Lea_WMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] [Commented On] T236677: Impossible to uncollapose termbox

2019-10-28 Thread Pablo-WMDE
Pablo-WMDE added a comment. In my case (logged in) HierarchyRequestError: Node cannot be inserted at the specified point in the hierarchy happens right after page load and TypeError: "e is undefined" upon click on "in more languages". F3090

[Wikidata-bugs] [Maniphest] [Triaged] T236677: Impossible to uncollapose termbox

2019-10-28 Thread Pablo-WMDE
Pablo-WMDE triaged this task as "High" priority. Pablo-WMDE added a comment. Talked with product and this was considered as `High` priority, leaning towards `UBN` looking at the behavior I experienced (error right on load). TASK DETAIL https://phabricator.wikimedia.org/T236

[Wikidata-bugs] [Maniphest] [Updated] T236709: Error when executing helmfile commands for the termbox service

2019-10-29 Thread Pablo-WMDE
Pablo-WMDE added a comment. Discussed that with Jakob yesterday and am watching this, was under the assumption that it would unlock itself during the course of today - one way or the other. Seeing T236677: Impossible to uncollapose termbox <https://phabricator.wikimedia.org/T236677> c

[Wikidata-bugs] [Maniphest] [Updated] T235622: scrollbar breaks the modal

2019-10-29 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-8; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T235622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Pablo-WMDE, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T236147: close icon is too bold

2019-10-29 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-8; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T236147 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Charlie_WMDE, darthmon_wmde, Michael

[Wikidata-bugs] [Maniphest] [Edited] T236148: bridge header label not centered in desktop view

2019-10-29 Thread Pablo-WMDE
Pablo-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T236148 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Charlie_WMDE, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T236148: bridge header label not centered in desktop view

2019-10-29 Thread Pablo-WMDE
Pablo-WMDE added a comment. The example screenshots are sort of funny as they compare apples (a German one with a long button label) and oranges (an English one with a short button label). TASK DETAIL https://phabricator.wikimedia.org/T236148 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T236147: close icon is too bold

2019-10-29 Thread Pablo-WMDE
Pablo-WMDE added a comment. I vaguely remember that the way buttons were crafted for termbox (and that is where this our button originates) was very deliberate, with usability for mobile users as priority. Aside of aligning perfectly with OOUI specification, was this taken into account

[Wikidata-bugs] [Maniphest] [Created] T236913: Use of deprecated Language::clearCaches in LexemeDiffVisualizerIntegrationTest

2019-10-30 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Lexicographical data, Wikidata. TASK DESCRIPTION 14:41:00 Use of Language::clearCaches was deprecated in MediaWiki 1.35. [Called from Wikibase\Lexeme\Tests\MediaWiki\Diff\LexemeDiffVisualizerIntegrationTest::tearDown in /workspace

[Wikidata-bugs] [Maniphest] [Commented On] T236913: Use of deprecated Language::clearCaches in LexemeDiffVisualizerIntegrationTest

2019-10-30 Thread Pablo-WMDE
Pablo-WMDE added a comment. Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/547206 TASK DETAIL https://phabricator.wikimedia.org/T236913 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Closed] T236913: Use of deprecated Language::clearCaches in LexemeDiffVisualizerIntegrationTest

2019-10-30 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T236913 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, darthmon_wmde, DannyS712, Nandana,

[Wikidata-bugs] [Maniphest] [Changed Status] T236237: Set up Grafana board for data bridge openings by property datatype

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE changed the task status from "Open" to "Stalled". TASK DETAIL https://phabricator.wikimedia.org/T236237 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE, Pablo-WMDE Cc: Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Blocker] T231204: track Bridge openings by property datatype

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE changed the status of subtask T236237: Set up Grafana board for data bridge openings by property datatype from "Open" to "Stalled". TASK DETAIL https://phabricator.wikimedia.org/T231204 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/e

[Wikidata-bugs] [Maniphest] [Retitled] T236237: [stalled] Set up Grafana board for data bridge openings by property datatype

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE renamed this task from "Set up Grafana board for data bridge openings by property datatype" to "[stalled] Set up Grafana board for data bridge openings by property datatype". TASK DETAIL https://phabricator.wikimedia.org/T236237 EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T236236: Get property datatype in store bridge init action and call tracker

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T236236 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Unblock] T231204: track Bridge openings by property datatype

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE closed subtask T236235: Implement and set up tracker in init module as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T231204 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Tonina_Zhelyazkova_WMDE, Ch

[Wikidata-bugs] [Maniphest] [Closed] T236235: Implement and set up tracker in init module

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T236235 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, Pablo-WMDE Cc: Michael, Matthias_Geisler_WMDE, Aklapper, Lucas_Werkme

[Wikidata-bugs] [Maniphest] [Commented On] T233397: Viewing existing references in the Bridge

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE added a comment. "in case of 0 references title is not visible" contradicts the latest comment - @Charlie_WMDE help, please. "TBD" is still not addressed - @Lydia_Pintscher @Charlie_WMDE help, please! TASK DETAIL https://phabricator.wikimedia.org/T23339

[Wikidata-bugs] [Maniphest] [Created] T237023: Create references (section) component

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata-Bridge, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - Iterates over getter result and shows one reference component each - just show headline in case of no references - don't do the b

[Wikidata-bugs] [Maniphest] [Created] T237022: Create references store getter

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata-Bridge, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Returns array of references (we don't artificially remove information from the return value - as compared to store values) TASK D

[Wikidata-bugs] [Maniphest] [Created] T237024: Create reference (the single one) component

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata-Bridge, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - shows all snaks of this reference - display serialized form of datavalue if its value is an object - display value form of

[Wikidata-bugs] [Maniphest] [Created] T237025: Add reference component(s) to app

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata-Bridge, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - add to app - add browser tests TASK DETAIL https://phabricator.wikimedia.org/T237025 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T233397: Viewing existing references in the Bridge

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-8; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T233397 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Charlie_WMDE, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T237022: Create references store getter

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-8; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T237022 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Michael

[Wikidata-bugs] [Maniphest] [Updated] T237023: Create references (section) component

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-8; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T237023 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Michael

[Wikidata-bugs] [Maniphest] [Updated] T237024: Create reference (the single one) component

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-8; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T237024 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Michael

[Wikidata-bugs] [Maniphest] [Updated] T237025: Add reference component(s) to app

2019-10-31 Thread Pablo-WMDE
Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-8; removed Wikidata-Bridge. TASK DETAIL https://phabricator.wikimedia.org/T237025 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Pablo-WMDE, darthmon_wmde, Michael

[Wikidata-bugs] [Maniphest] [Created] T237116: browser test edit link visibility based on permission

2019-11-01 Thread Pablo-WMDE
Pablo-WMDE created this task. Pablo-WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-8. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T237116 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T236147: close icon is too bold

2019-11-04 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Charlie_WMDE wrote > **stick to whatever desktop is doing** and want to **diverge the UI for mobile** This is fine, us devs want to actually work like that - it is building a responsive product, as stated in the bonfire slides. The thing is that

[Wikidata-bugs] [Maniphest] [Closed] T236234: Implement PropertyDatatypeRepository via ForeignApi

2019-11-05 Thread Pablo-WMDE
Pablo-WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T236234 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma,

[Wikidata-bugs] [Maniphest] [Unblock] T231204: track Bridge openings by property datatype

2019-11-05 Thread Pablo-WMDE
Pablo-WMDE closed subtask T236234: Implement PropertyDatatypeRepository via ForeignApi as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T231204 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Tonina_Zhelya

[Wikidata-bugs] [Maniphest] [Reopened] T236234: Implement PropertyDatatypeRepository via ForeignApi

2019-11-05 Thread Pablo-WMDE
Pablo-WMDE reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T236234 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma,

[Wikidata-bugs] [Maniphest] [Block] T231204: track Bridge openings by property datatype

2019-11-05 Thread Pablo-WMDE
Pablo-WMDE reopened subtask T236234: Implement PropertyDatatypeRepository via ForeignApi as "Open". TASK DETAIL https://phabricator.wikimedia.org/T231204 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Tonina_Zhelya

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T235771: immediate kicking in of the Bridge: Move service creation out of init

2019-11-05 Thread Pablo-WMDE
Pablo-WMDE added a subscriber: Lucas_Werkmeister_WMDE. Pablo-WMDE added a comment. Some inspiration for how this could be measure can be found in @Lucas_Werkmeister_WMDE post T233305#763 <https://phabricator.wikimedia.org/T233305#763> TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T235765: immediate kicking in of the Bridge: Attach link listeners sooner

2019-11-05 Thread Pablo-WMDE
Pablo-WMDE added a comment. Some inspiration for how this could be measured can be found in @Lucas_Werkmeister_WMDE post T233305#763 <https://phabricator.wikimedia.org/T233305#763> TASK DETAIL https://phabricator.wikimedia.org/T235765 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T235152: don't show bridge edit pens when editor can't edit the article

2019-11-06 Thread Pablo-WMDE
Pablo-WMDE added a comment. During the sprint start we quickly discussed this and concluded that we will move the missing functionality (blocked on the client) into a dedicated ticket. TASK DETAIL https://phabricator.wikimedia.org/T235152 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T232468: Illustrate loading

2019-11-06 Thread Pablo-WMDE
Pablo-WMDE added a comment. During the task break down we discussed that there seems to be an interesting ratio between the effort it takes to use/show the progress bar and the animations mentioned. This is particularly alienating as it was mentioned that it is hard to imagine how these

[Wikidata-bugs] [Maniphest] [Commented On] T235154: show error when editor can't edit the statement because of permission errors on the repository

2019-11-06 Thread Pablo-WMDE
Pablo-WMDE added a comment. During the task break down the question came up which does not seem to be answered: What if a user is not allowed to edit for multiple reasons? Do we show (and explain) all of them? Or is there a hierarchy and we only show the most severe one? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235154: show error when editor can't edit the statement because of permission errors on the repository

2019-11-06 Thread Pablo-WMDE
Pablo-WMDE added a comment. Another question: the links that are mentioned are apparently not supposed to run through `Special:MyLanguage` <https://www.mediawiki.org/wiki/Template:Localized_link> - is that intentional? TASK DETAIL https://phabricator.wikimedia.org/T235154

[Wikidata-bugs] [Maniphest] [Commented On] T235154: show error when editor can't edit the statement because of permission errors on the repository

2019-11-06 Thread Pablo-WMDE
Pablo-WMDE added a comment. Another question: How does this error state affect the save/publish button? The mock-ups show it hidden, but the AC do not mention it. TASK DETAIL https://phabricator.wikimedia.org/T235154 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T237507: Let the user know when they're blocked on the client

2019-11-20 Thread Pablo-WMDE
Pablo-WMDE added a comment. Discussed with @Charlie_WMDE during task break-down (N° 10): - error reasons for client and repo will be shown in the interface alongside - client reason(s) will be clustered first - repo reason(s) will be clustered second TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T235154: show error when editor can't edit the statement because of permission errors on the repository

2019-11-25 Thread Pablo-WMDE
Pablo-WMDE added a comment. How AdvancedSearch passes its wikitext messages through parsing and adds them to JS <https://gerrit.wikimedia.org/g/mediawiki/extensions/AdvancedSearch/+/d836260a5ee9734b8abdec80c7ab833aa729ad19/includes/Hooks.php#61>. TASK DETAIL

<    4   5   6   7   8   9   10   11   12   13   >