[Wikidata-bugs] [Maniphest] [Commented On] T88275: No language fallback applied for property labels on qualifiers and references in JS UI.

2015-03-12 Thread adrianheine
adrianheine added a comment. I realized that we probably can skip step 3. (and remove most of `wbUsedEntities` right now) since we don't re-render anything anymore :) I'll try that out. TASK DETAIL https://phabricator.wikimedia.org/T88275 REPLY HANDLER ACTIONS Reply to comment or attach

[Wikidata-bugs] [Maniphest] [Unblock] T55845: Browsertests for currently used datavalues (tracking)

2015-03-12 Thread adrianheine
adrianheine closed blocking task T88543: Browsertests for geo value input as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T55845 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Lowered Priority] T88543: Browsertests for geo value input

2015-03-12 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. adrianheine lowered the priority of this task from High to Normal. TASK DETAIL https://phabricator.wikimedia.org/T88543 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Closed] T63601: DataTypes should pass jshint

2015-03-12 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. We don't use the DataTypes project on gerrit currently. TASK DETAIL https://phabricator.wikimedia.org/T63601 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Updated] T86182: Allow list of available languages to be configurable

2015-03-12 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. What's currently missing is the actual configuration interface. I wrote a proposal regarding that in https://phabricator.wikimedia.org/T78007. I think, though, that for most current needs we could just hard-code our

[Wikidata-bugs] [Maniphest] [Commented On] T55849: Migrate current selenium tests to cucumber

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Are there still unmigrated tests? TASK DETAIL https://phabricator.wikimedia.org/T55849 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Unblock] T70019: Use pre-fetched labels throughout EntityView

2015-03-10 Thread adrianheine
adrianheine closed blocking task T70020: Use EntityIdHtmlLinkFormatter for format properties in EntityView as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T70019 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T70020: Use EntityIdHtmlLinkFormatter for format properties in EntityView

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://phabricator.wikimedia.org/rEWBAbaf7578c5e675a455a43f3afee3aa59d8fe4c81b TASK DETAIL https://phabricator.wikimedia.org/T70020

[Wikidata-bugs] [Maniphest] [Closed] T69394: [Monolingual] Can not search for language names in my language

2015-03-10 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine closed this task as Resolved. adrianheine claimed this task. adrianheine added a comment. Done in https://github.com/wmde/ValueView/commit/dceacfc4aff1b794fa90045f738db838f93c88b8. TASK DETAIL https://phabricator.wikimedia.org/T69394

[Wikidata-bugs] [Maniphest] [Closed] T75360: save button not activated when changing order of statements

2015-03-10 Thread adrianheine
adrianheine closed this task as Invalid. adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T75360 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Closed] T60180: changes to ordering don't persist under certain condition

2015-03-10 Thread adrianheine
adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. Moving is not supported anymore. TASK DETAIL https://phabricator.wikimedia.org/T60180 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Commented On] T59665: editing data values using server-side parser/validation will disable save button until server responds

2015-03-10 Thread adrianheine
adrianheine added a comment. This has been the case for all datavalue types for a year. I suppose users adapted to it. Close? TASK DETAIL https://phabricator.wikimedia.org/T59665 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Retitled] T87370: Use ContentLanguages object for special pages JS

2015-03-10 Thread adrianheine
adrianheine changed the title from Use ContentLanguages object for special pages to Use ContentLanguages object for special pages JS. TASK DETAIL https://phabricator.wikimedia.org/T87370 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Retitled] T87369: Use ContentLanguages object for terms JS

2015-03-10 Thread adrianheine
adrianheine changed the title from Use ContentLanguages object for terms to Use ContentLanguages object for terms JS. TASK DETAIL https://phabricator.wikimedia.org/T87369 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Changed Project Column] T93073: When entering new statement + qualifier, the qualifier is not rendered on save

2015-03-24 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. TASK DETAIL https://phabricator.wikimedia.org/T93073 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Closed] T93073: When entering new statement + qualifier, the qualifier is not rendered on save

2015-03-24 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T93073 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T93741: Create place to put common Wikibase services

2015-03-24 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I think the following interfaces might be candidates for moving there - Wikibase\Lib\EntityIdFormatter - Wikibase\Lib\SnakFormatter - Wikibase\Lib\Store\EntityLookup - Wikibase\Lib\Store\LabelLookup TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T93773: Remove wbUserCanEdit and wbUserIsBlocked config variables

2015-03-24 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I agree. It would be great if the toolbar controller would just initialize on top of existing toolbars and not add missing ones on the fly. We would need to add empty toolbars for statements to the static HTML

[Wikidata-bugs] [Maniphest] [Commented On] T93863: order in other language box by order of babel boxes

2015-03-25 Thread adrianheine
adrianheine added a comment. Afaik they are not cached, but injected afterwards with the TextInjector. So, no issue with caching. TASK DETAIL https://phabricator.wikimedia.org/T93863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Commented On] T94159: Put lastrevid of linked entities in mw.config.values.wbUsedEntities

2015-03-30 Thread adrianheine
adrianheine added a comment. That sounds great :) I think you can and should use `wbgetentities`. If you set `props=claims|info`, you only get the claims and meta data, which shouldn't be to expensive. TASK DETAIL https://phabricator.wikimedia.org/T94159 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Changed Project Column] T89300: Add qualifier button should automatically focus text box

2015-03-30 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T89300 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Updated] T94393: Switch wikidata qunit jobs from qunit to qunit-karma

2015-03-30 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-03-24. TASK DETAIL https://phabricator.wikimedia.org/T94393 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T94394: Remove explicit jquery.qunit loading from DataValuesJavaScript

2015-03-30 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-03-24. TASK DETAIL https://phabricator.wikimedia.org/T94394 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-03-24. TASK DETAIL https://phabricator.wikimedia.org/T94395 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94395 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Created] T94394: Remove explicit jquery.qunit loading from DataValuesJavaScript

2015-03-30 Thread adrianheine
adrianheine created this task. adrianheine claimed this task. adrianheine added projects: Wikidata, DataValues-JavaScript. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T94394 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Created] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine created this task. adrianheine claimed this task. adrianheine added projects: Wikidata, ValueView. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T94395 REPLY HANDLER ACTIONS Reply to comment or attach files

[Wikidata-bugs] [Maniphest] [Updated] T94393: Switch wikidata qunit jobs from qunit to qunit-karma

2015-03-30 Thread adrianheine
adrianheine added a blocking task: T94395: Remove explicit jquery.qunit loading from ValueView. TASK DETAIL https://phabricator.wikimedia.org/T94393 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine added a blocked task: T94393: Switch wikidata qunit jobs from qunit to qunit-karma. TASK DETAIL https://phabricator.wikimedia.org/T94395 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T94395: Remove explicit jquery.qunit loading from ValueView

2015-03-30 Thread adrianheine
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://github.com/wmde/ValueView/pull/167 TASK DETAIL https://phabricator.wikimedia.org/T94395 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94394: Remove explicit jquery.qunit loading from DataValuesJavaScript

2015-03-30 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94394 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94393: Switch wikidata qunit jobs from qunit to qunit-karma

2015-03-30 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94393 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Updated] T94394: Remove explicit jquery.qunit loading from DataValuesJavaScript

2015-03-30 Thread adrianheine
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://github.com/wmde/DataValuesJavascript/pull/75 TASK DETAIL https://phabricator.wikimedia.org/T94394 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Commented On] T70380: Factor dispatch logic out of maintenance script

2015-03-31 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. Why is this in review? TASK DETAIL https://phabricator.wikimedia.org/T70380 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T93745: Move view related code into separate directory

2015-03-31 Thread adrianheine
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T93745 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94552: Add language fallback for badge labels

2015-03-31 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94552 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Updated] T94552: Add language fallback for badge labels

2015-03-31 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-03-24. TASK DETAIL https://phabricator.wikimedia.org/T94552 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Project Column] T94552: Add language fallback for badge labels

2015-03-31 Thread adrianheine
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T94552 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Created] T94552: Add language fallback for badge labels

2015-03-31 Thread adrianheine
adrianheine created this task. adrianheine claimed this task. adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T94552 REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Updated] T93745: Move view related code into separate directory

2015-04-01 Thread adrianheine
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://gerrit.wikimedia.org/r/#/c/201175/ and parent changes. TASK DETAIL https://phabricator.wikimedia.org/T93745 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Changed Project Column] T93745: Move view related code into separate directory

2015-04-01 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-03-24 workboard. TASK DETAIL https://phabricator.wikimedia.org/T93745 WORKBOARD https://phabricator.wikimedia.org/project/board/1128/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Commented On] T94159: Put lastrevid of linked entities in mw.config.values.wbUsedEntities

2015-03-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a comment. I'm currently working on removing wbUsedEntities, see https://gerrit.wikimedia.org/r/#/c/197290/. You would have to do an API request then, anyways. As for the current page, `wgCurRevisionId` gives you the revid, but I

[Wikidata-bugs] [Maniphest] [Lowered Priority] T62341: Load widgets on demand

2015-03-27 Thread adrianheine
adrianheine lowered the priority of this task from High to Low. adrianheine added a comment. Currently we are trying to do less on page load within the current architecture, but we are not planning to completely defer initialization. TASK DETAIL https://phabricator.wikimedia.org/T62341

[Wikidata-bugs] [Maniphest] [Updated] T88428: Drop referenced entities from JS config

2015-03-27 Thread adrianheine
adrianheine removed a blocking task: T88426: Server-side rendering for all property links in the JS UI. TASK DETAIL https://phabricator.wikimedia.org/T88428 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T88426: Server-side rendering for all property links in the JS UI

2015-03-27 Thread adrianheine
adrianheine removed a blocked task: T88428: Drop referenced entities from JS config. TASK DETAIL https://phabricator.wikimedia.org/T88426 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T94159: Put lastrevid of linked entities in mw.config.values.wbUsedEntities

2015-03-27 Thread adrianheine
adrianheine added a comment. Can you give me a use-case for editing an entity referenced by the entity you're currently on? I think it makes more sense to provide the lastrevid with `wbgetclaims`, and I think you definitely should run `wbgetclaims` before doing `wbsetclaims`, otherwise you

[Wikidata-bugs] [Maniphest] [Created] T94563: Support language fallbacks in wbformatvalue

2015-03-31 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: daniel. adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Currently, only one language can be passed via `lang` option. The API

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine added a comment. The failing ExpertExtender tests also need focus apparently. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T90492: Make Wikibase Repo work with a custom File collection, not only Wikimedia Commons

2015-03-03 Thread adrianheine
adrianheine added a comment. I'd suggest to introduce an ExpertFactory replacing the currently used ExpertStore. Then we could control instantiation arguments for the experts and the ValueViewBuilder would get simpler. ContentLanguages could be passed through the ExpertFactory, too. Currently

[Wikidata-bugs] [Maniphest] [Changed Project Column] T85252: Edit buttons are getting cached, although their visibility depends on user rights

2015-03-04 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T85252 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T88950: Migrate all relevant Lua modules from mw.wikibase.getEntity to mw.wikibase.getEntityObject

2015-03-04 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T88950 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Raised Priority] T85799: mw-debug.log missing in Jenkins jobs (Failed to be created Permission denied)

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from Normal to Needs Triage. TASK DETAIL https://phabricator.wikimedia.org/T85799 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Raised Priority] T87858: Adjust AuthorityControl Gadget to snakview name changes

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from High to Unbreak Now!. TASK DETAIL https://phabricator.wikimedia.org/T87858 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Raised Priority] T85252: Edit buttons are getting cached, although their visibility depends on user rights

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-03 workboard. adrianheine raised the priority of this task from High to Needs Triage. TASK DETAIL https://phabricator.wikimedia.org/T85252 WORKBOARD https://phabricator.wikimedia.org/project/board/1034/ REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Commented On] T88441: investigate how language fallbacks can be done in entity search

2015-03-04 Thread adrianheine
adrianheine added a comment. Some questions: - Who/what (else) is using SearchEntities? - How will we build language fallback chains? Who will configure them? I think that's pretty important for deciding what the API looks like (bool vs list of languages) - Can we really get away

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine added a comment. Thank you, @Krinkle! TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T90756: Maintenance script to update a client wiki's subscriptions based on the usage tracking table.

2015-03-04 Thread adrianheine
adrianheine added a subscriber: adrianheine. adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://gerrit.wikimedia.org/r/#/c/193815/ TASK DETAIL https://phabricator.wikimedia.org/T90756 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Commented On] T89698: API function wbsetqualifier blocks frontend

2015-03-04 Thread adrianheine
adrianheine added a comment. I think the current behavior is not too bad. The Wikibase JavaScript code found some value it cannot allow you to edit because the UI is not able to represent the current state. What's broken about this is that the UI is not able to handle non-standard calendar

[Wikidata-bugs] [Maniphest] [Commented On] T87579: investigate solutions for items with a large number of aliases

2015-03-04 Thread adrianheine
adrianheine added a comment. Other ideas: - Horizontal table with headers in the left column (below language, maybe right-aligned) - Horizontal table without the headers at all Why is the description between aliases and label? To me it seems like aliases and labels are of the same kind, just

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T75496: Support new types of Entities in Wikibase Repository

2015-02-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T75496 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T77985: Add mechanism for registering new entity types, to work with things like EntityViewFactory

2015-02-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T77985 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T76021: Create extension mechanism for Wikibase Repository

2015-02-27 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T76021 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-02-27 Thread adrianheine
adrianheine added subscribers: WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW. adrianheine added a comment. The focusing tests fail. We should either try to detect if they could possibly pass and otherwise skip them or remove them altogether. @Tobi_WMDE_SW @snaterlicious @WMDE-Fisch What do you think

[Wikidata-bugs] [Maniphest] [Created] T91377: Make Wikibase qunit tests independent of focus

2015-03-03 Thread adrianheine
adrianheine created this task. adrianheine added subscribers: adrianheine, JanZerebecki, WMDE-Fisch, Snaterlicious, Tobi_WMDE_SW, Aklapper. adrianheine added projects: Continuous-Integration, Wikidata, § Wikidata-Sprint-2015-02-25. TASK DESCRIPTION TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Created] T91376: Make ValueView qunit tests independent of focus.

2015-03-03 Thread adrianheine
adrianheine created this task. adrianheine added subscribers: Tobi_WMDE_SW, Snaterlicious, WMDE-Fisch, JanZerebecki, adrianheine. adrianheine added projects: § Wikidata-Sprint-2015-02-25, Wikidata, Continuous-Integration. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION

[Wikidata-bugs] [Maniphest] [Created] T91385: Use MessageProvider for views in Wikibase

2015-03-03 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Currently, the MessageProvider is only used for the ValueView; it could and should be used for all the views

[Wikidata-bugs] [Maniphest] [Raised Priority] T91376: Make ValueView qunit tests independent of focus.

2015-03-03 Thread adrianheine
adrianheine moved this task to Review on the § Wikidata-Sprint-2015-02-25 workboard. adrianheine raised the priority of this task from Normal to High. TASK DETAIL https://phabricator.wikimedia.org/T91376 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Changed Project Column] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine moved this task to Doing on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T74184 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Changed Project Column] T91377: Make Wikibase qunit tests independent of focus

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. TASK DETAIL https://phabricator.wikimedia.org/T91377 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T77982: Implement Unit Selector widget

2015-03-03 Thread adrianheine
adrianheine closed blocking task T77981: QuantityValueParser: Allow unit to be specified via options as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T77982 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T77981: QuantityValueParser: Allow unit to be specified via options

2015-03-03 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T77981 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Unblock] T77977: Unit support (tracking)

2015-03-03 Thread adrianheine
adrianheine closed blocking task T77981: QuantityValueParser: Allow unit to be specified via options as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T77977 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Unblock] T55845: Browsertests for currently used datavalues (tracking)

2015-03-03 Thread adrianheine
adrianheine closed blocking task T88545: Browsertests for URL value input as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T55845 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Lowered Priority] T88545: Browsertests for URL value input

2015-03-03 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-02-25 workboard. adrianheine lowered the priority of this task from High to Normal. TASK DETAIL https://phabricator.wikimedia.org/T88545 WORKBOARD https://phabricator.wikimedia.org/project/board/1079/ REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Unblock] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine closed blocking task T91377: Make Wikibase qunit tests independent of focus as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Closed] T91377: Make Wikibase qunit tests independent of focus

2015-03-03 Thread adrianheine
adrianheine closed this task as Invalid. adrianheine claimed this task. adrianheine added a comment. They already are, it's just ValueView. TASK DETAIL https://phabricator.wikimedia.org/T91377 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Updated] T91376: Make ValueView qunit tests independent of focus.

2015-03-03 Thread adrianheine
adrianheine added a project: Patch-For-Review. adrianheine added a comment. https://github.com/wmde/ValueView/pull/161 TASK DETAIL https://phabricator.wikimedia.org/T91376 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine added a comment. AFAIK we are the only ones with focus tests. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T90453: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength

2015-03-03 Thread adrianheine
adrianheine added a comment. In https://phabricator.wikimedia.org/T90453#1073327, @Krinkle wrote: - The relevant software is incorrectly using the ResourceLoader module system. (E.g. using it as a complete class registry.) This has all kinds of scalability impacts and semantic fragileness

[Wikidata-bugs] [Maniphest] [Updated] T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit

2015-03-03 Thread adrianheine
adrianheine added a blocking task: T91377: Make Wikibase qunit tests independent of focus. TASK DETAIL https://phabricator.wikimedia.org/T74184 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Updated] T91377: Make Wikibase qunit tests independent of focus

2015-03-03 Thread adrianheine
adrianheine added a blocked task: T74184: fix the qunit tests for wikidata: mwext-Wikibase-qunit. TASK DETAIL https://phabricator.wikimedia.org/T91377 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Claimed] T90268: BadMethodCallException from line 244 of EntityViewPlaceholderExpander.php

2015-02-24 Thread adrianheine
adrianheine claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T90268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T90268: BadMethodCallException from line 244 of EntityViewPlaceholderExpander.php

2015-02-24 Thread adrianheine
adrianheine added a project: § Wikidata-Sprint-2015-02-03. TASK DETAIL https://phabricator.wikimedia.org/T90268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T90459: wikidata qunit test on labs-vagrant have errors

2015-02-24 Thread adrianheine
adrianheine added a comment. [ef7b5d6d] Exception Caught: Non-daemonized mode is no longer supported. Please install the mediawiki/services/jobrunner service and update $wgJobTypeConf as needed. TASK DETAIL https://phabricator.wikimedia.org/T90459 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Commented On] T87237: RFC: Possible redesign of the EntityTermsProvider interface

2015-02-26 Thread adrianheine
adrianheine added a comment. Following Thiemo's analysis, I think we don't gain much by artificially grouping the terms properties and items have. The fact that we are not able to come up with a sane name for this adds up to the feeling that this is arbitrary and does not really correspond

[Wikidata-bugs] [Maniphest] [Commented On] T88441: investigate how language fallbacks can be done in entity search

2015-02-26 Thread adrianheine
adrianheine added a comment. @Lydia_Pintscher: If this is resolved, who reviewed it? TASK DETAIL https://phabricator.wikimedia.org/T88441 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T90720: Introduce wikibase.view.ViewFactory

2015-02-26 Thread adrianheine
adrianheine added a comment. Why did you create a separate task for this? There already is a 1:1 relation for task and change here. TASK DETAIL https://phabricator.wikimedia.org/T90720 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Closed] T93183: Narrow fields in Special:NewItem and Special:NewProperty

2015-03-24 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T93183 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T93183: Narrow fields in Special:NewItem and Special:NewProperty

2015-03-24 Thread adrianheine
adrianheine moved this task to Done on the § Wikidata-Sprint-2015-03-11 workboard. TASK DETAIL https://phabricator.wikimedia.org/T93183 WORKBOARD https://phabricator.wikimedia.org/project/board/1095/ REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T77991: File based caching: Decide on file format

2015-03-24 Thread adrianheine
adrianheine closed blocking task T77990: File based caching: Split of site lookup for readonly access as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T77991 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T77990: File based caching: Split of site lookup for readonly access

2015-03-24 Thread adrianheine
adrianheine closed this task as Resolved. adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T77990 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Unblock] T47532: Add file-based cached implementation of SiteStore

2015-03-24 Thread adrianheine
adrianheine closed blocking task T77990: File based caching: Split of site lookup for readonly access as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T47532 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T93773: Remove wbUserCanEdit and wbUserIsBlocked config variables

2015-03-24 Thread adrianheine
adrianheine added a comment. Adrian_WMDE: aude: We could also replace the config var with a $( '.wikibase-toolbar' ).length 0 check Adrian_WMDE: That would be pretty crude, but work TASK DETAIL https://phabricator.wikimedia.org/T93773 REPLY HANDLER ACTIONS Reply to comment

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T93207: Better namespace URI for the wikibase ontology

2015-03-19 Thread adrianheine
adrianheine added a subscriber: adrianheine. TASK DETAIL https://phabricator.wikimedia.org/T93207 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T93809: CommonsMedia gadget broken

2015-03-25 Thread adrianheine
adrianheine added a comment. I suppose https://phabricator.wikimedia.org/rEWBA00145a8dcbdb548216a39b69ccc713734d37bdfe introduced that. The ValueView appears to not be rendered anymore on snakview initialization. A maybe related issue is that the valueview never switches `valueview-ineditmode

[Wikidata-bugs] [Maniphest] [Updated] T87432: Identify messages that belong to WikibaseView

2015-01-23 Thread adrianheine
adrianheine added a comment. PHP: - wikibase-label-empty (not clean, see https://phabricator.wikimedia.org/T87433) - wikibase-description-empty - wikibase-aliases-label - wikibase-aliases-empty - wikibase-property-footer - wikibase-propertypage-datatype - wikibase-ui-pendingquantitycounter

[Wikidata-bugs] [Maniphest] [Updated] T87434: Split entityViewInit into WikibaseRepo and WikibaseView part

2015-01-23 Thread adrianheine
adrianheine removed projects: Wikidata-Sprint-2015-01-08§, Tracking. adrianheine set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T87434 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Edited] T87433: Split wikibase.utilities into WikibaseView and lib part

2015-01-23 Thread adrianheine
adrianheine edited the task description. adrianheine set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T87433 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T75020: Move JS and PHP view code to separate repo

2015-01-23 Thread adrianheine
adrianheine added a comment. Additional subtask I need to create (and do): Move messages between lib and repo (messages used in lib need to be moved to lib, messages used in repo need to be moved to WikibaseView) TASK DETAIL https://phabricator.wikimedia.org/T75020 REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Created] T87434: Split entityViewInit into WikibaseRepo and WikibaseView part

2015-01-23 Thread adrianheine
adrianheine created this task. adrianheine added a subscriber: adrianheine. adrianheine added projects: Tracking, Wikidata-Sprint-2015-01-08§, Wikidata, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Most of the file should stay

<    1   2   3   4   5   6   7   8   9   10   >