adrianheine removed a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T50143
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a comment.
@Lydia_Pintscher I'm in favor of that approach, too. In practice (i. e., entity
suggesters), labels and aliases identify items, not descriptions. Also, as you
said, they are of the same kind, while label and description just serve the
same purpose
adrianheine added a comment.
@Lydia_Pintscher I'm in favor of that approach, too. In practice (i. e., entity
suggesters), labels and aliases identify items, not descriptions. Also, as you
said, they are of the same kind, while label and description just serve the
same purpose
adrianheine added a comment.
In https://phabricator.wikimedia.org/T88475#1791752, @aude wrote:
> https://phabricator.wikimedia.org/F2928636 reminder, this is still a problem
> and also why we need to be able to reorder statement groups.
How does reordering statement group
adrianheine added a comment.
Ah, sorry, this is about ordering, not grouping. That's all right :)
TASK DETAIL
https://phabricator.wikimedia.org/T88475
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ricordisamoa, Snaterlicious
adrianheine added a comment.
But we are not actually planning on putting »the most relevant statements« on
top, are we?
TASK DETAIL
https://phabricator.wikimedia.org/T88475
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc
adrianheine added a comment.
I tried to break this down into tasks. Part 1 and Part 2 can be done in
parallel, Part 3 needs all tasks from both Part 1 and Part 2 finished, Part 4
needs Part 3 done.
Part 1 (Preparation of `Wikibase\View` and `Wikibase\DataModel\Services`)
- [Task] [PHP, view
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T116164
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, JanZerebecki, Aklapper, Wikidata-bugs, aude, greg
adrianheine added a comment.
I think I made changes that affected behavior in this case, so we should
re-investigate the status quo.
TASK DETAIL
https://phabricator.wikimedia.org/T51124
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
adrianheine added a comment.
When executing the cucumber command locally, the result directory is filled
correctly. Last successful run
<https://integration.wikimedia.org/ci/job/browsertests-Wikidata-PerformanceTests-linux-firefox-sauce/333/>
was on Aug, 6. Failing runs have no build art
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
A special page for editing statements could have this feature.
TASK DETAIL
https://phabricator.wikimedia.org/T113168
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I suppose it also shouldn't apply to the edit box below.
TASK DETAIL
https://phabricator.wikimedia.org/T98014
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc
adrianheine edited projects, added MediaWiki-extensions-WikibaseView; removed
MediaWiki-extensions-WikibaseRepository.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Sjoerddebruin
adrianheine edited projects, added MediaWiki-extensions-WikibaseView; removed
MediaWiki-extensions-WikibaseRepository.
TASK DETAIL
https://phabricator.wikimedia.org/T50136
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper
adrianheine edited the task description.
adrianheine edited projects, added MediaWiki-extensions-WikibaseView; removed
MediaWiki-extensions-WikibaseRepository.
Herald added a subscriber: Aklapper.
TASK DETAIL
https://phabricator.wikimedia.org/T62341
EMAIL PREFERENCES
https
adrianheine removed a blocking task: T62341: Load widgets on demand.
TASK DETAIL
https://phabricator.wikimedia.org/T54136
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ash_Crow, Agabi10, Aklapper, MGChecker, Wikidata-bugs, Bene
adrianheine removed a blocking task: T40968: Keyboard-navigability of the repo
UI.
TASK DETAIL
https://phabricator.wikimedia.org/T54136
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ash_Crow, Agabi10, Aklapper, MGChecker, Wikidata
adrianheine edited the task description.
adrianheine added a project: MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T114767
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Sjoerddebruin, Ricordisamoa
adrianheine added a project: MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T102792
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ricordisamoa, JanZerebecki, thiemowmde, Lydia_Pintscher, Aklapper
adrianheine added projects: ValueView, MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T104331
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ricordisamoa, Jc3s5h, Lydia_Pintscher, daniel, aude
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I can reproduce this. Setting `margin-left` to 0 on the badge worked around it.
TASK DETAIL
https://phabricator.wikimedia.org/T87570
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine changed the title from "badges are cut off" to "[Bug] badges are
cut off".
adrianheine set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T87570
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianh
adrianheine moved this task to ready to go on the Wikidata workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T87570
WORKBOARD
https://phabricator.wikimedia.org/project/board/71/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc
adrianheine edited projects, added MediaWiki-extensions-WikibaseView; removed
MediaWiki-extensions-WikibaseRepository.
TASK DETAIL
https://phabricator.wikimedia.org/T87570
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine
adrianheine edited projects, added MediaWiki-extensions-WikibaseView; removed
MediaWiki-extensions-WikibaseRepository.
TASK DETAIL
https://phabricator.wikimedia.org/T70903
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper
adrianheine edited the task description.
adrianheine edited projects, added MediaWiki-extensions-WikibaseView; removed
MediaWiki-extensions-WikibaseRepository.
adrianheine set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T40968
EMAIL PREFERENCES
https
adrianheine added a blocked task: T40968: Keyboard-navigability of the repo UI.
TASK DETAIL
https://phabricator.wikimedia.org/T54136
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ash_Crow, Agabi10, Aklapper, MGChecker, Wikidata-bugs
adrianheine added a blocking task: T54136: [Epic] Redesign Item UI for Wikidata
repo.
TASK DETAIL
https://phabricator.wikimedia.org/T40968
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Liuxinyu970226, Wikidata-bugs
adrianheine removed a blocked task: T54136: [Epic] Redesign Item UI for
Wikidata repo.
TASK DETAIL
https://phabricator.wikimedia.org/T40968
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Liuxinyu970226, Wikidata-bugs
adrianheine removed a blocked task: T54136: [Epic] Redesign Item UI for
Wikidata repo.
TASK DETAIL
https://phabricator.wikimedia.org/T62341
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Yair_rand, thiemowmde, Tobi_WMDE_SW
adrianheine edited the task description.
adrianheine added a project: MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T98014
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: daniel, Aklapper
adrianheine added a comment.
I suppose you mean you cannot reproduce the issue, right? Fyi, it's indeed only
one scenario that should be run, so that's alright.
TASK DETAIL
https://phabricator.wikimedia.org/T116164
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a comment.
In https://phabricator.wikimedia.org/T117421#1783027, @Bene wrote:
> As we distinguish identifier statements from "normal" ones, I guess we also
> need the entity suggester for properties to distinguish between those and
> support non-id
adrianheine added a comment.
In https://phabricator.wikimedia.org/T78007#1782201, @thiemowmde wrote:
> - "add" and "remove" is not more or less information than "type" or "data".
> - Not sure what's wrong with Daniels suggestion. I'm fine wi
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
A lot of these things are about `DataValues`, right? I think those can be
tackled without talking about the Wikibase data model.
@THiemowmde and I just talked about sitelinks, and we came to the following
conclusion
adrianheine added a comment.
Also, should you be able to add a new statement to both / all statement
sections? With which properties?
TASK DETAIL
https://phabricator.wikimedia.org/T117421
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
adrianheine claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T117689
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: gerritbot, adrianheine, Jonas, Aklapper, Wikidata-bugs, aude, Mbch331
adrianheine claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T117692
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: gerritbot, adrianheine, Jonas, Aklapper, Wikidata-bugs, aude, Mbch331
adrianheine added a comment.
In https://phabricator.wikimedia.org/T117421#1781489, @Lydia_Pintscher wrote:
> Where is what configured? That this section exists? Or what it contains? We
> could show it only if statements with the identifier datatype exist?
Where is configured which sta
adrianheine edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Sjoerddebruin, Jonas, Ricordisamoa, matej_suchanek, Tobi_WMDE_SW, Aklapper,
Snaterlicious
adrianheine edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Sjoerddebruin, Jonas, Ricordisamoa, matej_suchanek, Tobi_WMDE_SW, Aklapper,
Snaterlicious
adrianheine created this task.
adrianheine added subscribers: Jonas, adrianheine.
adrianheine added projects: MediaWiki-extensions-WikibaseView,
Wikidata-Sprint-2015-11-03, Wikidata.
Herald added a subscriber: Aklapper.
TASK DESCRIPTION
Managing edit mode should be done in a ViewController
adrianheine changed the title from "Introduce ViewController for managing edit
mode in referenceview" to "[Task] Introduce ViewController for managing edit
mode in referenceview".
adrianheine set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T11768
adrianheine created this task.
adrianheine added subscribers: Jonas, adrianheine.
adrianheine added projects: MediaWiki-extensions-WikibaseView,
Wikidata-Sprint-2015-11-03, Wikidata.
Herald added a subscriber: Aklapper.
TASK DESCRIPTION
Introduce remove toolbar for when edit mode
adrianheine claimed this task.
TASK DETAIL
https://phabricator.wikimedia.org/T117675
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: gerritbot, adrianheine, Jonas, Aklapper, Wikidata-bugs, aude, Mbch331
adrianheine moved this task to Review on the Wikidata-Sprint-2015-11-03
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T117689
WORKBOARD
https://phabricator.wikimedia.org/project/board/1594/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine moved this task to Review on the Wikidata-Sprint-2015-11-03
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T117692
WORKBOARD
https://phabricator.wikimedia.org/project/board/1594/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine added a project: MediaWiki-extensions-WikibaseView.
adrianheine set Security to None.
Herald added a project: Wikidata.
TASK DETAIL
https://phabricator.wikimedia.org/T117558
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jonas
adrianheine added a project: ValueView.
TASK DETAIL
https://phabricator.wikimedia.org/T117558
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jonas, adrianheine
Cc: gerritbot, adrianheine, Aklapper, Wikidata-bugs, aude, Mbch331
adrianheine added a project: MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T78007
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ricordisamoa, Tobi_WMDE_SW, JeroenDeDauw, Wikidata-bugs, jeblad
adrianheine added a project: MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T115972
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: gerritbot, matej_suchanek, Aklapper, Wikidata-bugs, aude, Mbch331
adrianheine added a project: MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T117421
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Lydia_Pintscher, Aklapper, Sjoerddebruin, Liuxinyu970226, Ltrlg
adrianheine moved this task to Done on the Wikidata-Sprint-2015-11-03 workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T117064
WORKBOARD
https://phabricator.wikimedia.org/project/board/1594/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine added a project: MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T116153
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, thiemowmde, Snaterlicious, Aklapper, Tobi_WMDE_SW
adrianheine added a project: MediaWiki-extensions-WikibaseView.
TASK DETAIL
https://phabricator.wikimedia.org/T110043
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Jonas, thiemowmde, Lydia_Pintscher, Sjoerddebruin
adrianheine added a comment.
From what I see this is not related to
https://phabricator.wikimedia.org/T98471. The fix applied there is still
applied and works for all statements. So, I think this needs investigating from
scratch.
TASK DETAIL
https://phabricator.wikimedia.org/T110043
EMAIL
adrianheine added projects: MediaWiki-extensions-WikibaseView,
MediaWiki-extensions-UniversalLanguageSelector.
adrianheine set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T117886
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T112550
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: daniel, adrianheine
Cc: adrianheine, hoo, Tobi_WMDE_SW, Jonas, thiemowmde, JeroenDeDauw, Bene,
aude
adrianheine created this task.
adrianheine assigned this task to Lydia_Pintscher.
adrianheine added subscribers: adrianheine, Snaterlicious.
adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseView,
MediaWiki-extensions-WikibaseRepository, RfC, Wikidata-Sprint-2015-11-03.
Herald
adrianheine added a comment.
@Lydia_Pintscher pointed out that we have a lot more IDs:
- `wb-item-$ENTITYID` on entity views
- `$PROPERTYID` on statement groups
- `sitelinks-$SITELINKGROUPID` on sitelink groups
TASK DETAIL
https://phabricator.wikimedia.org/T117953
EMAIL PREFERENCES
https
adrianheine added a comment.
In https://phabricator.wikimedia.org/T117421#1785205, @Bene wrote:
> I don't think this will cause lots of confusion as the two sections are
> clearly separated by a heading. It's rather intuitive that one can only add
> properties of the right type to
adrianheine added a comment.
They hurt if you are on someone else's HTML page and start using unqualified
`id`s, or if you have something twice on a page.
TASK DETAIL
https://phabricator.wikimedia.org/T117953
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a comment.
Decision: We continue using IDs as we do currently for the time being.
TASK DETAIL
https://phabricator.wikimedia.org/T117953
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lydia_Pintscher, adrianheine
Cc: Snaterlicious
adrianheine added a comment.
I have some questions (@lydia_pintscher):
- Does this apply for items and properties?
- Where is this configured? I think this is very Wikidata-specific, and, as I
mention frequently, such things should not go into Wikibase. Instead, Wikibase
should be flexible
adrianheine added a comment.
I'm strongly against putting information in keys, and I'm against `data` and
`source` keys. They break extensibility and composability.
TASK DETAIL
https://phabricator.wikimedia.org/T78007
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine edited Description.
PROJECT DETAIL
https://phabricator.wikimedia.org/project/profile/71/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: JanZerebecki, thiemowmde, Mbch331, Abraham, Jonas, johl, Lucie, LikeLifer,
Bene, Ricordisamoa
adrianheine added a comment.
The messages are still in repo, while used in view.
TASK DETAIL
https://phabricator.wikimedia.org/T45855
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, adrianheine, JeroenDeDauw, aude
adrianheine added a comment.
- The example allows all languages known to ULS plus `zxx` and `und`, but minus
`en`, `fr` and `de. It's obviously artificial :)
- I don't see why you would need to reuse parts in the serialization. Can you
give me a use-case for that?
- Merging and filtering
adrianheine added a comment.
@daniel It really depends on the level you want to set this switch on. If you
want to append an URL parameter and then have all API requests magically fail
or be slow or anything, then that's obviously not done. If you want to pass
different things in unit tests
adrianheine added a comment.
I would probably switch to the mathematical operation names: ›Union‹ instead of
›Merging‹, ›Difference‹ instead of ›Filtering‹.
TASK DETAIL
https://phabricator.wikimedia.org/T78007
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a comment.
As far as I understood it, this usage of deprecated would be semantically
wrong. Deprecated to me means that this claim is not, was never and never will
be true. Normal however means that his claim has been true at some place in
time or, more generally, is true
adrianheine added a comment.
I don't like these task lists in descriptions, but I added them anyway. I think
creating subtasks would have been a better way, though.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Jonas, Aklapper, Wikidata-bugs, adrianheine, Lydia_Pintscher, aude
adrianheine added a subscriber: adrianheine.
TASK DETAIL
https://phabricator.wikimedia.org/T95684
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Ricordisamoa, Bugreporter, Liuxinyu970226, daniel, aude,
JanZerebecki, hoo
adrianheine removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Sjoerddebruin, Jonas, Ricordisamoa, matej_suchanek, Tobi_WMDE_SW, Aklapper
adrianheine edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Jonas, Aklapper, Wikidata-bugs, adrianheine, Lydia_Pintscher, aude
adrianheine moved this task to Review on the Wikidata-Sprint-2015-10-13
workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
WORKBOARD
https://phabricator.wikimedia.org/project/board/1551/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
adrianheine added a comment.
With https://gerrit.wikimedia.org/r/#/c/246769/, I consider this done. There
are still more views that could be constructed in the view factory, but there
are few if any options passed through these.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL
adrianheine created this task.
adrianheine added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
Herald added a subscriber: Aklapper.
TASK DESCRIPTION
When pressing a ›new statement‹ button, an empty statement in edit mode is
added. This statement has an expanded, empty references
adrianheine added a comment.
In https://phabricator.wikimedia.org/T87759#1737591, @Jonas wrote:
> When removing a reference the API request for removing should be sent when
> the save button of the statement is clicked.
Actually, this is not true: There shouldn't be an API r
adrianheine added a comment.
That does not answer my question. Let me rephrase it: »For which [remove]
button do we need a task of making sure it does not trigger an API call?«
Remember that a `Statement` has multiple `Reference`s which in turn have a
`SnakList` which has multiple `Snak`s
adrianheine created this task.
adrianheine added projects: MediaWiki-extensions-WikibaseRepository, Wikidata.
Herald added a subscriber: Aklapper.
TASK DESCRIPTION
We need browser tests for adding a reference to a new statement that is
currently added. Each test should try the add button
adrianheine added a comment.
> [Task] Referenceview must *not* trigger any API request when clicking
> [remove]
Which remove button does this refer to?
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings
adrianheine added a comment.
> [Task] The referenceview must bubble up "change" events to the
> referencelistview, then to the statementview
There is no `referencelistview`, there's just a `listview` of `referenceview`
widgets in `statementview`.
TAS
adrianheine added a comment.
> [Task] Reference views must switch back to non-edit mode when statementview's
> saving is done
That currently happens because the `statementview` recreates all it's child
widgets on save.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
adrianheine edited the task description.
adrianheine set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T115974
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wikidata-bugs, aude
adrianheine edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Sjoerddebruin, Jonas, Ricordisamoa, matej_suchanek, Tobi_WMDE_SW, Aklapper,
Snaterlicious
adrianheine added a comment.
> [Task] Add new bool parameter "editReferencesAlongWithStatement" to
> referenceview to disable save+cancel
I suggest that we don't do this. Instead, we could a) use `statementGuid` as a
flag (crude, but no so incorrect) or b) replac
adrianheine edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T87759
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Sjoerddebruin, Jonas, Ricordisamoa, matej_suchanek, Tobi_WMDE_SW, Aklapper,
Snaterlicious
adrianheine added a comment.
This should be implemented at least down to the `snakview`. Sitelinks and terms
are probably not important, since there's not so much passing through going on.
TASK DETAIL
https://phabricator.wikimedia.org/T75380
EMAIL PREFERENCES
https
adrianheine added a blocked task: T76216: language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T98208
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Liuxinyu970226, daniel, thiemowmde, Lydia_Pintscher, Bene
adrianheine removed a blocking task: T87754: Apply language fallbacks in
JavaScript-formatted entity ids.
TASK DETAIL
https://phabricator.wikimedia.org/T98208
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine
adrianheine added a blocking task: T87754: Apply language fallbacks in
JavaScript-formatted entity ids.
TASK DETAIL
https://phabricator.wikimedia.org/T98208
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: adrianheine, Liuxinyu970226
adrianheine removed a blocked task: T98208: [Bug] Widget to edit badges should
use language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T87754
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wikidata-bugs, aude
adrianheine added a blocked task: T98208: [Bug] Widget to edit badges should
use language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T87754
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Aklapper, Wikidata-bugs, aude
adrianheine added a blocking task: T98208: [Bug] Widget to edit badges should
use language fallback.
TASK DETAIL
https://phabricator.wikimedia.org/T76216
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc: Ricordisamoa, Aklapper, He7d3r
adrianheine added a comment.
I think after https://gerrit.wikimedia.org/r/#/c/199296 this would be the same
as https://phabricator.wikimedia.org/T87754. It's probably somewhere in that
commit chain.
TASK DETAIL
https://phabricator.wikimedia.org/T98208
EMAIL PREFERENCES
https
adrianheine added a comment.
There are obviously a lot of different fail cases:
- Endpoints that return a failure
- Endpoints that return something which triggers a failure (for example a parse
error) in JS
- Endpoints that don't return anything
You can simulate all of them by passing
adrianheine added a subscriber: adrianheine.
adrianheine added a comment.
I also get the
`Wikibase\Tests\RepoHooksTest::testImportHandleRevisionXMLTag_hook` failure.
TASK DETAIL
https://phabricator.wikimedia.org/T111343
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel
adrianheine added a comment.
How is this done? It's part of https://gerrit.wikimedia.org/r/#/c/201182/ (not
done, not merged yet).
TASK DETAIL
https://phabricator.wikimedia.org/T87754
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: adrianheine
Cc
401 - 500 of 1136 matches
Mail list logo