[Wikidata-bugs] [Maniphest] T276366: Replace vue-cli with vite and webpack with rollup

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T276366 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Manuel, WMDE-leszek, santhosh, Aklapper, bete, Michael, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja

[Wikidata-bugs] [Maniphest] T170401: Ignore deprecated statements when checking “type” and “value type” constraints

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T170401 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Mohammed_Sadat_WMDE, Lydia_Pintscher, amy_rc, Ayack, Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. went through the list of repos again. I created a PR for those who don't have phpcs as part of `composer test` https://github.com/wmde/WikibaseDataModelServices/pull/248 https://github.com/wmde/WikibaseDataModelSerialization/pull/261 https://github.com/wmde

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. @thiemowmde thank you for the detailed info. I will go through the repos again TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Addshore, JeroenDeDauw

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. PR for the one repo that is not running code sinffer in `composer test` can be found here <https://github.com/wmde/WikibaseInternalSerialization/pull/136> TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. @Addshore I only found one repo that doesn't run `phpcs` as part of `composer test`. maybe we need to update the doku <https://wmde.github.io/wikidata-wikibase-team/pages/repositories.html> TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFE

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. wmde/Time <https://github.com/wmde/Time> has runs `phpcs` as part of `composer test ` as can be seen here <https://github.com/wmde/Time/blob/master/composer.json#L54> TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERE

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete added a comment. this <https://github.com/wmde/Serialization> repository already runs phpcs as part of `composer test` TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Ad

[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig, thiemowmde, Aklapper, Invadibot

[Wikidata-bugs] [Maniphest] T277528: WMDE's lib-version-check should publish new version to npm upon releasing it on github

bete added a comment. PR link: https://github.com/wmde/lib-version-check/pull/5 TASK DETAIL https://phabricator.wikimedia.org/T277528 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, WMDE-leszek, Aklapper, Invadibot, maantietaja

[Wikidata-bugs] [Maniphest] T279782: The short-url copied should include the leading "https://"

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T279782 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301

[Wikidata-bugs] [Maniphest] T279624: Tooltip-Button missing border on focus

bete added a comment. yes, it does have a border for me. (on my local machine, It works just fine on both FF and chrome) on toolforge, I can't even focus on it with keyboard. TASK DETAIL https://phabricator.wikimedia.org/T279624 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T277853: Wire up DateValueInput and create browser tests

bete added a comment. Will be merged once everything else in done TASK DETAIL https://phabricator.wikimedia.org/T277853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana

[Wikidata-bugs] [Maniphest] T277853: Wire up DateValueInput and create browser tests

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T279624: Tooltip-Button missing border on focus

bete added a comment. I can't recreate this issue on FF and chrome. (with keyboard navigation) does the issue happen on the same browsers as well ? FYI: I can use keyboard navigation to focus on the tooltip on toolforge TASK DETAIL https://phabricator.wikimedia.org/T279624 EMAIL

[Wikidata-bugs] [Maniphest] T277853: Wire up DateValueInput and create browser tests

bete removed bete as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T277853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T277853: Wire up DateValueInput and create browser tests

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T277854: Ensure that link-sharing still works with Date Queries

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277854 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T277850: Create DateValueInput component

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277850 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T277851: Adjust QueryRepresentation to include DateValue

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277851 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T273162: (MS 5) shorten URL for visual query sharing

bete added a comment. @amy_rc sorry for the late reply. it was deployed on toolforge but i found there was a problem with it. I just fixed the problem and is now deployed (like 10 mins ago). I don't know how often new merges are deployed. but i'd say you can test it again tomorrow

[Wikidata-bugs] [Maniphest] T277847: Adjust the RootState to store the parsed value

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277847 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T273162: (MS 5) shorten URL for visual query sharing

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T273162 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Ladsgroup, Aklapper, Lydia_Pintscher, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T277057: Create FormatValueRepository

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277057 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen

[Wikidata-bugs] [Maniphest] T277038: Create ParseValueRepository

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277038 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen

[Wikidata-bugs] [Maniphest] T276942: accessibility improvement: trash can should be focussed last

bete added a comment. awesome! I'll merge it TASK DETAIL https://phabricator.wikimedia.org/T276942 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Charlie_WMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] T276942: accessibility improvement: trash can should be focussed last

bete added a comment. @Charlie_WMDE yes, its worked on a different branch. this one is only about that trash can icon. TASK DETAIL https://phabricator.wikimedia.org/T276942 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper

[Wikidata-bugs] [Maniphest] T276942: accessibility improvement: trash can should be focussed last

bete added a comment. @Charlie_WMDE The PR has been approved. If you can, can you take a look at it and see if you approve ? (i will merge it after that) https://604f621fa9112ed9534f9f82--clicky-sparqly.netlify.app/ TASK DETAIL https://phabricator.wikimedia.org/T276942 EMAIL

[Wikidata-bugs] [Maniphest] T274273: Accessibility improvement: set focus to and/or-toggle after new condition

bete added a comment. @Charlie_WMDE can be tested here https://604f3f6d294def25e536b0b8--clicky-sparqly.netlify.app/ TASK DETAIL https://phabricator.wikimedia.org/T274273 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper

[Wikidata-bugs] [Maniphest] T276942: accessibility improvement: trash can should be focussed last

bete added a comment. PR can be found here <https://github.com/wmde/query-builder/pull/222> TASK DETAIL https://phabricator.wikimedia.org/T276942 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Charlie_WMDE, maant

[Wikidata-bugs] [Maniphest] T276942: accessibility improvement: trash can should be focussed last

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T276942 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Charlie_WMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T274273: Accessibility improvement: set focus to and/or-toggle after new condition

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T274273 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Charlie_WMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T267010: Create BouncingDots loader mixin

bete added a comment. PR can be found here <https://github.com/wmde/wikit/pull/391> TASK DETAIL https://phabricator.wikimedia.org/T267010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Michael, Aklapper, Sarai-WMDE, maant

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

bete added a comment. @Ladsgroup the DS ticket is merged now , FYI TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, bete Cc: Ladsgroup, Michael, bete, Aklapper, Charlie_WMDE

[Wikidata-bugs] [Maniphest] T267010: Create BouncingDots loader mixin

bete added a comment. A mixin would be simpler to implement. but we don't have a way of documenting that in the storybook. so I'd go with a component approach TASK DETAIL https://phabricator.wikimedia.org/T267010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T267010: Create BouncingDots loader mixin

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T267010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Michael, Aklapper, Sarai-WMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

bete added a comment. this <https://github.com/wmde/wikit/pull/386> PR has to be merged and released first, before starting this ticket TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: b

[Wikidata-bugs] [Maniphest] T274346: Add named slot for icon to Design System components with label

bete added a comment. PR: https://github.com/wmde/wikit/pull/386 TASK DETAIL https://phabricator.wikimedia.org/T274346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, ItamarWMDE, Michael, Tarrow, Sarai-WMDE, Akuckartz, Nandana

[Wikidata-bugs] [Maniphest] T274259: position the popover based on a prop

bete added a comment. https://119bc6d25deb9bf2eb5d77a16ade033ac6931053--wmde-wikit.netlify.app/?path=/story/vue_popover--all TASK DETAIL https://phabricator.wikimedia.org/T274259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper

[Wikidata-bugs] [Maniphest] T274346: Add named slot for icon to Design System components with label

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T274346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, ItamarWMDE, Michael, Tarrow, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T274259: position the popover based on a prop

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T274259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T272958: (MS 5) Create link component

bete removed bete as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T272958 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, Ladsgroup, Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] T273052: Value type not detected in the visual query after using 'regardless of value'

bete added a comment. @Charlie_WMDE https://602a85cd44dfc31887fa386c--clicky-sparqly.netlify.app TASK DETAIL https://phabricator.wikimedia.org/T273052 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Ladsgroup, Michael, Charlie_WMDE

[Wikidata-bugs] [Maniphest] T273052: Value type not detected in the visual query after using 'regardless of value'

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T273052 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Ladsgroup, Michael, Charlie_WMDE, amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T273777: Expand existing browser tests

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T273777 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T273775: Rewrite the existing SauceLabs/Nightwatch Browser Test to Cypress and drop SauceLabs

bete added a comment. PR: #192 <https://github.com/wmde/query-builder/pull/192> TASK DETAIL https://phabricator.wikimedia.org/T273775 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Addshore, Aklapper, Michael, Akuckartz, Nandana

[Wikidata-bugs] [Maniphest] T273771: Integrate Cypress into our GitHub CI

bete added a comment. to run the tests locally, simply run docker-compose --env-file .env -f docker-compose.yml -f docker-compose.e2e.yml up e2e TASK DETAIL https://phabricator.wikimedia.org/T273771 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T273771: Integrate Cypress into our GitHub CI

bete added a subscriber: Jakob_WMDE. bete added a comment. Cypress is now successfully integrated with github actions CI. thank you for the work @Jakob_WMDE and @Michael @Jakob_WMDE thank you for the excellent points you wrote down in the PR <https://github.com/wmde/query-builder/p

[Wikidata-bugs] [Maniphest] T273775: Rewrite the existing SauceLabs/Nightwatch Browser Test to Cypress and drop SauceLabs

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T273775 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Addshore, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen

[Wikidata-bugs] [Maniphest] T273771: Integrate Cypress into our GitHub CI

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T273771 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T272958: (MS 5) Create link

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T272958 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Ladsgroup, Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. In T273039#676 <https://phabricator.wikimedia.org/T273039#676>, @Sarai-WMDE wrote: >> It is entirely possible to instead have a prop that says something like inheritStyles=true or isStandalone=false. > > The prop option sou

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. In T273039#6799706 <https://phabricator.wikimedia.org/T273039#6799706>, @ItamarWMDE wrote: >> We could, in the future, extend that to support routing libraries like vue-router. > > This argument is enough to win me over. Usually I'm not in

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. In T273039#6799656 <https://phabricator.wikimedia.org/T273039#6799656>, @Michael wrote: > In T273039#6799614 <https://phabricator.wikimedia.org/T273039#6799614>, @Sarai-WMDE wrote: > >> Is it safe to assume that we'd probabl

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. @Michael unfortunately , I don't have the notes, as I was note part of the meeting. but maybe @Sarai-WMDE has them ? TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. @Michael yes! future extensions are another good reason for components. I believe @ItamarWMDE and @Sarai-WMDE already had a deep dive into this topic. but maybe with the points mentioned above, that might help them get closer to a decision TASK DETAIL https

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. @Lydia_Pintscher I put all my findings here. please feel free if you've any questions TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, Michael, Sarai

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. **conclusion:** As far as implementation goes, there doesn't seem to be too much technical difficulty in going either way. echoing on some of the points @Michael mentioned above, I'll list some of the pros and cons. I haven't found much info on veutify

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. Implementation using props (vue components) can be accomplished easily. an example can be found here <https://stackoverflow.com/a/61952210> TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. **regarding the second acceptance criteria:** Its a much rarer case. However, we can expand our mixin to accept a third parameter (font-size) to override the size. default value can just be set to 'inherit' so the link can inherit the font-size of the parent. TASK

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. So far, I focused mostly on implementation using mixing (since we have more experience with the component approach). **regarding the first criteria**, mentioned above: It's possible to achieve the desired effect with mixins. code snippet: @mixin link

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. In T273039#6790844 <https://phabricator.wikimedia.org/T273039#6790844>, @Michael wrote: > Some initial brainstormy thoughts: > > Pro Component > > - better abstraction/encapsulation of "internals" > - same argument as

[Wikidata-bugs] [Maniphest] T272055: Set max width for entire UI

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T272055 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Charlie_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen

[Wikidata-bugs] [Maniphest] T267829: Make the lookup menu scroll active through keyboard

bete added a subscriber: Michael. bete added a comment. @Sarai-WMDE I have discussed this issue with @Michael . we think the last two BDDs are an oversight and are not meant to be implemented for the lookup menu. we implemented them only for the dropdon menus. (in T268771 <ht

[Wikidata-bugs] [Maniphest] T268771: Allow looping within OptionsMenu via keyboard

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T268771 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T267829: Make the lookup menu scroll active through keyboard

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T267829 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T270549: "limited support" string placeholder shown in propertylookup after scroll

bete added a comment. @Lydia_Pintscher fix is deployed and can be tested TASK DETAIL https://phabricator.wikimedia.org/T270549 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: guergana.tzatchkova, Aklapper, Lydia_Pintscher, Manishsamota

[Wikidata-bugs] [Maniphest] T268508: Load more results for PropertyLookup on scroll

bete added a comment. @Lydia_Pintscher made the fixes. can be tested again TASK DETAIL https://phabricator.wikimedia.org/T268508 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Lydia_Pintscher, Aklapper, Michael, Manishsamota, Akuckartz

[Wikidata-bugs] [Maniphest] T266877: Announce menu values to screen readers

bete added a comment. did some tests with orca screen reader and it seems like there is no work needed from our side. orca read out the menu items, including the descriptions, when navigating the dropdown menu items. i will move this ticket to test verification so others can confirm

[Wikidata-bugs] [Maniphest] T266877: Announce menu values to screen readers

bete moved this task from Ready to pick up to Wikidata Query Builder - sprint 5 on the Wikidata Query Builder board. bete edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 5); removed Wikidata Query Builder. TASK DETAIL https://phabricator.wikimedia.org/T266877

[Wikidata-bugs] [Maniphest] T266877: Announce menu values to screen readers

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T266877 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: ItamarWMDE, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Orienteerix

[Wikidata-bugs] [Maniphest] T268508: Load more results for PropertyLookup on scroll

bete added a comment. @Lydia_Pintscher looking into it now TASK DETAIL https://phabricator.wikimedia.org/T268508 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Lydia_Pintscher, Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi

[Wikidata-bugs] [Maniphest] T269438: Postcss requires dir=ltr or dir=rtl, we have dir=auto

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T269438 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen

[Wikidata-bugs] [Maniphest] T268508: Load more results for PropertyLookup on scroll

bete added a comment. https://github.com/wmde/query-builder/pull/93 TASK DETAIL https://phabricator.wikimedia.org/T268508 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T268508: Load more results for PropertyLookup on scroll

bete moved this task from Ready to pick up to Wikidata Query Builder - sprint 5 on the Wikidata Query Builder board. bete edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 5); removed Wikidata Query Builder. TASK DETAIL https://phabricator.wikimedia.org/T268508

[Wikidata-bugs] [Maniphest] T268508: Load more results for PropertyLookup on scroll

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T268508 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T267671: Make the Query Builder configurable at build time

bete moved this task from Ready to pick up to Wikidata Query Builder - sprint 4 on the Wikidata Query Builder board. bete edited projects, added Wikidata Query Builder ( Wikidata Query Builder - sprint 4); removed Wikidata Query Builder. TASK DETAIL https://phabricator.wikimedia.org/T267671

[Wikidata-bugs] [Maniphest] T267671: Make the Query Builder configurable at build time

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T267671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: guergana.tzatchkova, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T267736: Make it possible to add the ValueTypeDropdown value to the state

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T267736 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T267735: Create ValueTypeDropdown component in QB

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T267735 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T265917: Firefox doesn't show active styles while LookupMenu-item is clicked

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T265917 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper

[Wikidata-bugs] [Maniphest] T265917: Firefox doesn't show active styles while LookupMenu-item is clicked

bete moved this task from Incoming to Wikidata Query Builder - sprint 3 on the Wikidata Query Builder board. bete edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 3); removed Wikidata Query Builder. TASK DETAIL https://phabricator.wikimedia.org/T265917 WORKBOARD

[Wikidata-bugs] [Maniphest] T265884: Keyboard navigation for selecting an item

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T265884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Jakob_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T263568: First simple query - showing the result list

bete added a subscriber: Charlie_WMDE. bete added a comment. @Charlie_WMDE do we have figma specs on how the iframe should look like ? meaning, how the iframe should fir in the query builder block TASK DETAIL https://phabricator.wikimedia.org/T263568 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T263568: First simple query - showing the result list

bete moved this task from Backlog to Wikidata Query Builder - sprint 1 on the Wikidata Query Builder board. bete edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 1); removed Wikidata Query Builder. TASK DETAIL https://phabricator.wikimedia.org/T263568 WORKBOARD

[Wikidata-bugs] [Maniphest] T263565: First simple query - input of string values only with dynamic Property

bete moved this task from Ready to pick up to Wikidata Query Builder - sprint 1 on the Wikidata Query Builder board. bete edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 1); removed Wikidata Query Builder. TASK DETAIL https://phabricator.wikimedia.org/T263565

[Wikidata-bugs] [Maniphest] T263568: First simple query - showing the result list

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T263568 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Lydia_Pintscher, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T264318: Set up store and wire it to text input component

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T264318 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: Aklapper, Jakob_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T263539: Set up a test system

bete added a comment. i wanted to bring this issue up over the meeting but i forgot. why do we have different enviroments in prodcution (docker) and test (non-docker). doesn't that defeat the purpose of using docker (even if its a trivial issue) also, when we were working on the CI