daniel added a comment.
With the fix live and working, and T201170 filed for the proper solution, this can probably be closed.TASK DETAILhttps://phabricator.wikimedia.org/T199983EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Daniel_Mietchen
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Other users are reporting the same problem, with other languages and items, at https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Interface_language_bug
See {T201170} for a complete
daniel created this task.daniel added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTIONWikibase in many cases relies on the uer's UI language as defined by the RequestContext and $wgLang for output generation, via
daniel removed a subtask: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..
TASK DETAILhttps://phabricator.wikimedia.org/T198561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc
daniel added a subtask: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..
TASK DETAILhttps://phabricator.wikimedia.org/T200918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc
daniel edited parent tasks, added: T200918: Make sure code that accesses the text table or uses rev_text_id triggers warnings before switching to write-new; removed: T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI.
TASK D
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONTBDThis undoes {T201164}, see there for an explanation.TASK DETAILhttps://phabricator.wikimedia.org/T200918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, aude
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, User-Daniel, Multi-Content-Revisions (MCR Deployment).
TASK DESCRIPTIONRevisionStore::getQueryInfo currently triggers a deprecation warning when called with the "t
daniel edited subtasks, added: T194731: Show diffs for all slots [MCR]; removed: T174036: Diffs page should show diffs and content from multiple slots [MCR].
TASK DETAILhttps://phabricator.wikimedia.org/T200569EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
daniel removed a parent task: T200569: Make ApiComparePages API module aware of MCR.
TASK DETAILhttps://phabricator.wikimedia.org/T174036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, danielCc: Anomie, Liuxinyu970226, TomT0m, Smalyshev, Lokal_Profil
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...For ApiComparePages, we need to first figure out {T174036}{T194731}.TASK DETAILhttps://phabricator.wikimedia.org/T200569EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie
daniel closed subtask T198701: Create RevisionStoreFactory [MCR] as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, danielCc: Jdforrester-WMF, Addshore, Cparle, daniel
daniel closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T198701EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, Anomie, gerritbot, Aklapper, daniel, Addshore, Gaboe420, Versusxo, Majestic
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T195212EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper
daniel edited projects, added Multi-Content-Revisions (MCR-SDC Statement Support - phase 3); removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T194730EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
daniel removed a parent task: T194750: Deploy Structured Data on Commons baseline .
TASK DETAILhttps://phabricator.wikimedia.org/T194730EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Ramsey-WMF, MarkTraceur, Cparle, daniel, Lahi, PDrouin
daniel removed a subtask: T194730: Ensure that Wikibase data access to MediaInfo on file description pages works with MCR .
TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit
daniel added a parent task: T194750: Deploy Structured Data on Commons baseline .
TASK DETAILhttps://phabricator.wikimedia.org/T194730EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Ramsey-WMF, MarkTraceur, Cparle, daniel, Lahi, PDrouin
daniel added a subtask: T194730: Ensure that Wikibase data access to MediaInfo on file description pages works with MCR .
TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit
daniel added a parent task: T194750: Deploy Structured Data on Commons baseline .
TASK DETAILhttps://phabricator.wikimedia.org/T200216EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: daniel, Liuxinyu970226, TomT0m, Smalyshev, Lokal_Profil
daniel added a subtask: T200216: Make undo work with SDC by showing a UI to confirm undo without allowing an edit.
TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit, Ramsey-WMF
daniel edited projects, added Multi-Content-Revisions (MCR-SDC Statement Support - phase 3); removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T190066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
daniel added a parent task: T199352: Deploy Structured Data on Commons with arbitrary Statements.
TASK DETAILhttps://phabricator.wikimedia.org/T190066EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, gerritbot, EBjune, EBernhardson, dcausse
daniel added a subtask: T190066: Expose all slots to the search interface.
TASK DETAILhttps://phabricator.wikimedia.org/T199352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey
daniel edited projects, added Multi-Content-Revisions (MCR-SDC Statement Support - phase 3); removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
daniel added a subtask: T198297: Use PageUpdater to create dummy revisions.
TASK DETAILhttps://phabricator.wikimedia.org/T174043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONThis is a placeholder ticket for an RFC about how the content of multiple slots should be represented in XML dumps.
Preliminary thoughts: https://www.mediawiki.org/wiki/Multi-Content_Revisions/DumpsTASK DETAILhttps
daniel added a comment.
In T199121#4437696, @ArielGlenn wrote:
This is surely the wrong place to drop a link, but it can always be moved. Have some thoughts about MCR, two-pass dumps, and the XML schema: https://www.mediawiki.org/wiki/User:ArielGlenn/MCR_and_dumps
It's totally the right place
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: Tgr
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Multi-Content-Revisions (MCR Deployment).
TASK DESCRIPTIONTBDTASK DETAILhttps://phabricator.wikimedia.org/T200918EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett
daniel closed this task as "Resolved".daniel added a comment.
mergedTASK DETAILhttps://phabricator.wikimedia.org/T200568EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: gerritbot, daniel, Fjalapeno, Tgr, CCicalese_WMF, Aklapper
daniel closed subtask T200568: Make API query modules aware of MCR as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: Tgr, Fjalapeno, gerritbot, Aklapper, daniel, Lah
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata.daniel added a comment.
not needed for SDCTASK DETAILhttps://phabricator.wikimedia.org/T200570EMAIL PREFERENCEShttps
daniel edited projects, added Multi-Content-Revisions; removed Wikidata, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons.daniel added a comment.
Not needed for SDCTASK DETAILhttps://phabricator.wikimedia.org/T200572EMAIL PREFERENCEShttps
daniel added a subtask: T174032: Make relevant API modules aware of MCR.
TASK DETAILhttps://phabricator.wikimedia.org/T174043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente
daniel edited parent tasks, added: T174043: Deploy Multi-Content Revisions; removed: T194750: Deploy Structured Data on Commons baseline .
TASK DETAILhttps://phabricator.wikimedia.org/T174032EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc
daniel removed a subtask: T174032: Make relevant API modules aware of MCR.
TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit, Ramsey-WMF, daniel, Lahi, PDrouin-WMF, Gq86
daniel added a subtask: T200568: Make API query modules aware of MCR.
TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit, Ramsey-WMF, daniel, Lahi, PDrouin-WMF, Gq86
daniel added a parent task: T194750: Deploy Structured Data on Commons baseline .
TASK DETAILhttps://phabricator.wikimedia.org/T200568EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: gerritbot, daniel, Fjalapeno, Tgr, CCicalese_WMF, Aklapper
daniel added a subtask: T200569: Make ApiComparePages API module aware of MCR.
TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, Abit, Ramsey-WMF, daniel, Lahi, PDrouin-WMF, Gq86
daniel added a parent task: T194750: Deploy Structured Data on Commons baseline .
TASK DETAILhttps://phabricator.wikimedia.org/T200569EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: gerritbot, daniel, Fjalapeno, Tgr, CCicalese_WMF, Aklapper
daniel added a comment.
The patches that are up for review at this point do not fully cover the necessary functionality. Most importantly, there is no code yet that allows different slots to be configured for storing certain types of entities.TASK DETAILhttps://phabricator.wikimedia.org
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...In later iterations, SlotRoleHandlers should provide layout hints that can cause the output for some slots to be placed differently.
NOTE: One seemingly trivial aspect of this that should not be underestimated
daniel removed a parent task: T194048: Introduce RevisionRenderer (baseline).
TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22
daniel added a subtask: T200915: Allow SlotRoleHandlers to control page layout.
TASK DETAILhttps://phabricator.wikimedia.org/T174043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86
daniel added a parent task: T200915: Allow SlotRoleHandlers to control page layout.
TASK DETAILhttps://phabricator.wikimedia.org/T194046EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo
daniel removed a subtask: T194046: Introduce SlotRoleHandler and SlotRoleRegistry for declaring slot roles..
TASK DETAILhttps://phabricator.wikimedia.org/T194048EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, danielCc: gerritbot, Aklapper, daniel
daniel added a parent task: T200915: Allow SlotRoleHandlers to control page layout.
TASK DETAILhttps://phabricator.wikimedia.org/T194048EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo
daniel closed this task as "Invalid".daniel added a comment.
Abandoned. With the current design of RevisionRenderer/RenderedRevision, no SlotRenderingProvider is needed.TASK DETAILhttps://phabricator.wikimedia.org/T194049EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett
daniel closed subtask T194049: Introduce SlotRenderingProvider as "Invalid".
TASK DETAILhttps://phabricator.wikimedia.org/T194037EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, daniel, Gaboe420, Versusxo, Majestic
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* renderRevision( RevisionRecord $revRec, ParserOptions $options ): ParserOutput;RenderedRevison;
RenderedRevision would in turn support at least:
* getCombinedParserOutput()
* getRevision()
* maybe also
daniel renamed this task from "Introduce RevisionRenderer" to "Introduce RevisionRenderer (baseline)".
TASK DETAILhttps://phabricator.wikimedia.org/T194048EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, danielCc: gerritbot, Aklapp
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...The service should eventually also support single-slot mode, user-specific vs canonical rendering, and previews. In a first iteration, it only needs to support one method:
* renderRevision( RevisionRecord $revRec
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).daniel added a comment.
Kicking this off the SDC board. Will be needed for fully refactored PageUpdater, so it remains debt to be addressed for MCR.TASK DETAILhttps
daniel added a comment.
Instead of splitting, I changed the description to no longer call for WikiPagedoEditUpdates to be replaced. That method is actually OK for now.TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
daniel renamed this task from "Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates" to "Replace usages of Content::getSecondaryDataUpdates".daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONCurrently, code that needs to
daniel added a comment.
This task should be split: for SDC, we need to replace calls to Content::getSecondaryDataUpdates, but we can leave calls to WikiPage::doUpdates to be cleaned up laterTASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org
daniel added a parent task: T199352: Deploy Structured Data on Commons with arbitrary Statements.
TASK DETAILhttps://phabricator.wikimedia.org/T194037EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, daniel, Gaboe420, Versusxo
daniel added a subtask: T194037: Track dependencies for multiple Content objects per page.
TASK DETAILhttps://phabricator.wikimedia.org/T199352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata.
TASK DETAILhttps://phabricator.wikimedia.org/T194042EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
daniel added a subtask: T196087: Refactored implementation of MCR page update interface.
TASK DETAILhttps://phabricator.wikimedia.org/T174043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86
daniel removed a subtask: T196087: Refactored implementation of MCR page update interface.
TASK DETAILhttps://phabricator.wikimedia.org/T199352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Cparle, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86
daniel edited parent tasks, added: T174043: Deploy Multi-Content Revisions; removed: T199352: Deploy Structured Data on Commons with arbitrary Statements.
TASK DETAILhttps://phabricator.wikimedia.org/T196087EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC Statement Support - phase 3).
TASK DETAILhttps://phabricator.wikimedia.org/T198342EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, aude
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T198706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: ArielGlenn
daniel edited projects, added Multi-Content-Revisions (MCR-SDC Statement Support - phase 3); removed Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T198342EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel
daniel removed a parent task: T198311: Enable MCR migration stage "write both, read new" on commons beta..
TASK DETAILhttps://phabricator.wikimedia.org/T198342EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, aude, Addsho
daniel removed a subtask: T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..
TASK DETAILhttps://phabricator.wikimedia.org/T198311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie
daniel added a project: User-Daniel.
TASK DETAILhttps://phabricator.wikimedia.org/T199983EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Nikerabbit, Tagishsimon, zeljkofilipin, hoo, Nikki, Niharika, hashar, Jdforrester-WMF, aaron, Stashbot
daniel added a comment.
If memory serves, it was a conscious decision to only check the main snak for cross-references. But one of the "let's see if this is good enough" kind, not of the "it has to be that way" kind.TASK DETAILhttps://phabricator.wikimedia.org/T119614EM
daniel added a subscriber: Ramsey-WMF.daniel added a comment.
In T197616#4462111, @greg wrote:
So, summary: given those limitations of the production testwiki setup (mostly lack of real user traffic) what is the plan for testing against this wiki and could it also (or instead of) be done in Beta
daniel added a comment.
In T197616#4456669, @Fjalapeno wrote:
From what is being said, it sounds like the main question that needs to be answered is:
"Why not do this in beta instead of as part of group 0?"
We should definitely also do it on beta. Which means setting up Wikib
daniel added a comment.
@Krinkle In my mind, the purpose of testwiki and friends is to have an early warning for a train deploy breaking something on the production cluster. For that to work, we need one test wiki per significantly different wiki setup. Commons will in the future be the only wiki
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* Config: as similar to commonswiki as possible; should be set to $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD right away.
Having a test-commons.wikimedia.org
daniel added a comment.
In T157014#4460961, @Addshore wrote:
I seem to remember @daniel had some concerns around the topics of i18n, l10n and resourceloader, but I can't find them documented anywhere.
I breain dumped here: https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/I18n-JS
daniel added a comment.
In T194770#651, @matej_suchanek wrote:
This is certainly the cause. @daniel, is it possible that it was dropped intentionally in rEWBAa872ae062070c0d415cafd62dc08269319498fae?
Not intentionally, no. Looks like a bug. As far as I can tell from briefly looking
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...UndoAction may later gain editing ability, or may otherwise be consolidated with code that is being factored out of EditPage. For now, this approach allows us to implement undo logic that will work for SDC without
daniel renamed this task from "Make action="" fail gracefully for non-main slots." to "Make undo fail gracefully for non-main slots.".
TASK DETAILhttps://phabricator.wikimedia.org/T194412EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpref
daniel renamed this task from "Make action="" work with multiple slots." to "Make undo work with multiple slots.".daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONWhen using action="">the "undo" function to undo
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...It would probably be acceptable to not offer the ability to manually edit during an undo (check with product/UX), at least if the undo spans multiple slots. Or manual editing is only offered for the main slot
daniel lowered the priority of this task from "Normal" to "Low".
TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Tgr, CCicalese_WMF, Anomie, Aklapper, -jem-, Lokal_Profi
daniel added a parent task: T194042: Replace usages of WikiPage::prepareContentForEdit.
TASK DETAILhttps://phabricator.wikimedia.org/T194048EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo
daniel added a subtask: T194048: Introduce RevisionRenderer.
TASK DETAILhttps://phabricator.wikimedia.org/T194042EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle
daniel closed subtask T174023: Implement MCR storage layer as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T174022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Agabi10, Liuxinyu970226, TomT0m, Smalyshev, Lokal_Profil, -jem-
daniel closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T174023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, S
daniel closed subtask T174023: Implement MCR storage layer as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T174044EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Addshore, gerritbot, Anomie, jcrespo, Aklapper, daniel, AndyTan
daniel closed subtask T194015: Make PageArchive aware of MCR as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T174023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente,
daniel closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T194015EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, CCicalese_WMF, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci,
daniel added a comment.
an "undo without edit" could have all fields' content as or as data stored in the session server-side.
No need for even that, all data is already stored on the server side.TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFER
daniel added a comment.
maybe we need undo-without-edit anyway if some slots don't support editing but support undo?
Yes. This is already the case for SDC. MediaInfo does not support direct editing.TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps
daniel added a comment.
The longer I think about this, the more I want ParserOptions creation to have a Title for context.
The reason is that default parser behavior may vary with the type of page. The special case for conversion tables in WikiPage::makeParserOptions() is the point in case.
We
daniel added a comment.
I have been working on one corner of the SiteInfo stuff at the hackathon again. I should sit down with Amir to discuss next steps. The implementation is not so hard, what is tricky is staying compatible with configuration manually added to existing installs.
Both of us
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...At present, undo simply fails if multiple slots are involved, see {T194412}* A diff for each slot should be shown for confirmation (T174036), {T194731}.
* If undo supports editing, it needs to support preview
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...This means that the logic for undoing edits needs to be extracted from EditPage.
Note that it may be temporarily acceptable to only support undos that do not touch multiple slotsAt present, undo simply fails
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* A diff for each slot should be shown for confirmation (T194731T174036)TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
daniel closed subtask T190063: Tracking dependencies for multiple Content objects per page (MCR) as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T194037EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, daniel
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC Statement Support - phase 3), Structured-Data-Commons.daniel added a comment.
Dropping this off the SDC board, since full implementation of this is not necessary for SDC. Some of the subtasks are needed
daniel closed subtask T190063: Tracking dependencies for multiple Content objects per page (MCR) as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T199352EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, P
daniel added a parent task: T194037: Track dependencies for multiple Content objects per page.
TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo
601 - 700 of 5223 matches
Mail list logo
