[Wikidata-bugs] [Maniphest] [Updated] T238959: Make TextPassDumper work with 0.11 dump schema

2019-11-23 Thread daniel
daniel added a parent task: T238972: switch xml/sql (and adds-changes) dumps to use 0.11 schema with content from multiple slots. TASK DETAIL https://phabricator.wikimedia.org/T238959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc

[Wikidata-bugs] [Maniphest] [Updated] T238959: Make TextPassDumper work with 0.11 dump schema

2019-11-23 Thread daniel
daniel added a parent task: T238921: MCR: Include all slots in XML dumps per default. TASK DETAIL https://phabricator.wikimedia.org/T238959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: CCicalese_WMF, Aklapper, Fjalapeno, ArielGlenn

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-11-28 Thread daniel
daniel added a comment. In T238878#5700408 <https://phabricator.wikimedia.org/T238878#5700408>, @Nuria wrote: > Can someone explain why the content table is as large as the revision table? I though these tables were not used much other than commons but content table is big

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-12-03 Thread daniel
daniel added a comment. > I was thinking it made sense to exclude rev-deleted revisions: if a page only has (SDC) revisions that are partly restricted for most people, that we might not want to count those. If you want to count //pages//, then you are only looking at the curr

[Wikidata-bugs] [Maniphest] [Updated] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-12-03 Thread daniel
daniel added a comment. In T238878#5708511 <https://phabricator.wikimedia.org/T238878#5708511>, @matthiasmullie wrote: > So page_latest can never point to a revdel'ed revision? SHOULD never ;) And confusingly, rev_deleted is unrelated to "revision deletion&q

[Wikidata-bugs] [Maniphest] [Commented On] T193603: [UI] Change title of the field of a lemma language

2018-05-23 Thread daniel
daniel added a comment. That field should be called "variant" or "spelling", it should not make any reference to "language". For the reference, the message key is wikibaselexeme-form-field-language-labelTASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T195368: Add Lexeme to Wikibase's ontology.owl

2018-05-23 Thread daniel
daniel added a comment. I think they should not live in the same file, for practical reasons. It's much easier to deploy one static file per extension. This also makes it easier to use the ontology URL as the vocabulary URI. Note that the ontology URL / vocabulary URI will *not* vary be

[Wikidata-bugs] [Maniphest] [Commented On] T195368: Add Lexeme to Wikibase's ontology.owl

2018-05-23 Thread daniel
daniel added a comment. why not just http://wikiba.se/ontology# ? In any case, whatever we use, it should resolve to the actual file. As to the BETA tag... I think we can remove that from the wikibase core ontology now (should make a ticket). It'S probably good to have it for Lexeme for now

[Wikidata-bugs] [Maniphest] [Commented On] T195368: Add Lexeme to Wikibase's ontology.owl

2018-05-23 Thread daniel
daniel added a comment. why not just http://wikiba.se/ontology# ? Sorry, I created confusion by making a silly copy&paste mistake. I meant to say: why not just http://wikiba.se/lexeme#?TASK DETAILhttps://phabricator.wikimedia.org/T195368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Created] T195448: Special:EntitiesWithoutLabel fails with an internal error when called on Lexeme or Form type

2018-05-24 Thread daniel
daniel created this task.daniel added a project: Lexicographical data.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONExample: https://www.wikidata.org/wiki/Special:EntitiesWithoutLabel?language=de&type=lexeme Same thing for forms: https://www.wikidata

[Wikidata-bugs] [Maniphest] [Created] T195449: Special:SetLabel and friends should not accept Labels or Forms as input

2018-05-24 Thread daniel
daniel created this task.daniel added a project: Lexicographical data.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONSpecial:SetLabel shoudl reject entity types that do not support labels. Observed behavior: when clicking "set label", the fo

[Wikidata-bugs] [Maniphest] [Created] T195450: Special:ListDatatypes does not properly show information for wikibase-lexeme and wikibase-form

2018-05-24 Thread daniel
daniel created this task.daniel added a project: Lexicographical data.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONIt seems like localization is missing for the following keys: wikibase-listdatatypes-wikibase-lexeme-head wikibase-listdatatypes-wikibase

[Wikidata-bugs] [Maniphest] [Updated] T194239: Request creation of mcr-dev VPS project

2018-05-24 Thread daniel
daniel added a project: Structured-Data-Commons.Herald added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T194239EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Bstorm, bd808, Tgr, daniel, aude, Addshore, Aklapper, Zylc

[Wikidata-bugs] [Maniphest] [Updated] T195212: ServiceContainer: Allow extensions to manipulate services upon creation

2018-05-24 Thread daniel
daniel added a project: MediaWiki-ServiceContainer. TASK DETAILhttps://phabricator.wikimedia.org/T195212EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Tgr, gerritbot, Aklapper, daniel, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30

[Wikidata-bugs] [Maniphest] [Updated] T195520: Multiple projects reporting Cannot access the database: No working replica DB server

2018-05-24 Thread daniel
daniel added subscribers: Lydia_Pintscher, daniel.daniel added a project: Wikidata.daniel added a comment. Pinging @Lydia_Pintscher. This mostly affected Wikidiata, the site was down for a while (an hour)? As far as I can tell, this is unrelated to the lexeme deployment. It may be related to the

[Wikidata-bugs] [Maniphest] [Updated] T85414: synchronize schema on production with what is created on install

2018-05-25 Thread daniel
daniel added a comment. This being out of whack eventually caused a site outage T195520: Multiple projects reporting Cannot access the database: No working replica DB server.TASK DETAILhttps://phabricator.wikimedia.org/T85414EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T192306: Create MCR test wiki on WM Cloud

2018-05-28 Thread daniel
daniel added a comment. @Tgr thank you for setting this up! Rough plan, going forward: test PageUpdater on mcr-base (https://gerrit.wikimedia.org/r/c/434183/) run core selenium tests merge PageUpdater test multi-content RevisionStore on mcr-full with (https://gerrit.wikimedia.org/r/c

[Wikidata-bugs] [Maniphest] [Updated] T194729: Allow Wikibase Entities to be stored in alternative slots [MCR]

2018-05-29 Thread daniel
daniel added a subtask: T174038: Implement MCR page update interface. TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Cparle, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF

[Wikidata-bugs] [Maniphest] [Updated] T174038: Implement MCR page update interface

2018-05-29 Thread daniel
daniel added a parent task: T194729: Allow Wikibase Entities to be stored in alternative slots [MCR]. TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Aklapper, daniel

[Wikidata-bugs] [Maniphest] [Commented On] T177453: Add wikibase client support for searching wikidata items

2018-05-30 Thread daniel
daniel added a comment. This ticket conflates tow very different things, which makes it difficult to discuss tradeoffs: #1 looking up properties by label (PropertyIdResolver) #2 interactively searching for items based on some search input For #1 performance is an issue, and API calls are a no-go

[Wikidata-bugs] [Maniphest] [Commented On] T192306: Create MCR test wiki on WM Cloud

2018-05-30 Thread daniel
daniel added a comment. @Tgr since there are only so few selenium tests for core, and the changes that PageUpdater makes mostly impact when and how hook functions are called, I now think we should test it against mcr-full before merging it. I'll edit my previous comment accordingly

[Wikidata-bugs] [Maniphest] [Commented On] T143706: Implement TermLookup based on Elastic

2018-05-30 Thread daniel
daniel added a comment. Note: there are several places in the code that call TermIndex::getTermsOfEntities(). These would need to be converted to using a TermLookup in order to benefit from this.TASK DETAILhttps://phabricator.wikimedia.org/T143706EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T143706: Implement TermLookup based on Elastic

2018-05-30 Thread daniel
daniel added a comment. To enable this, the entry for 'PrefetchingTermLookup' in data-access/src/PerRepositoryServiceWiring.php needs to be changed to instantiate an ElasticTermLookup instead of a BufferingTermLookup, depending on config.TASK DETAILhttps://phabricator.wikimedia.org/T1

[Wikidata-bugs] [Maniphest] [Closed] T67267: Specify whether TimeValue stores timestamps in UTC or local time.

2018-05-30 Thread daniel
daniel closed this task as "Resolved".daniel claimed this task.daniel added a comment. This has been resolved a long time ago. The spec reads: timestamp in a format resembling ISO 8601, the year always being signed and having between 1 and 16 digits, e.g. +2013-01-01T00:00:00Z. The mont

[Wikidata-bugs] [Maniphest] [Unblock] T87764: Bugs related to time datatype (tracking)

2018-05-30 Thread daniel
daniel closed subtask T67267: Specify whether TimeValue stores timestamps in UTC or local time. as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T87764EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Mike_Peel, PokestarFan,

[Wikidata-bugs] [Maniphest] [Retitled] T174036: Diffs page should show diffs and content from multiple slots [MCR]

2018-05-31 Thread daniel
daniel renamed this task from "Allow the diffs to show multiple slots [MCR]" to "Diffs page should show diffs and content from multiple slots [MCR]". TASK DETAILhttps://phabricator.wikimedia.org/T174036EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emai

[Wikidata-bugs] [Maniphest] [Created] T196172: Test schema migration script

2018-06-01 Thread daniel
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 1). TASK DESCRIPTIONBefore attempting the schema conversion on a live system, want to run the populateContentTables scri

[Wikidata-bugs] [Maniphest] [Commented On] T196172: Test schema migration script

2018-06-06 Thread daniel
daniel added a comment. @jcrespo, @Marostegui Excellent, thank you!TASK DETAILhttps://phabricator.wikimedia.org/T196172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespo, danielCc: Marostegui, jcrespo, Aklapper, aude, Addshore, Anomie, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Commented On] T192306: Create MCR test wiki on WM Cloud

2018-06-13 Thread daniel
daniel added a comment. I have created a branch called McrStorageLayerTest on mcr-full.wmflabs now. It has three changes on it: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/406595 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/416465 https://gerrit.wikimedia.org/r/c/mediawiki/core

[Wikidata-bugs] [Maniphest] [Commented On] T192306: Create MCR test wiki on WM Cloud

2018-06-13 Thread daniel
daniel added a comment. Copy of https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/MCR-StorageLayerTesting#PageUpdater_test_plan. Will edit to mark my progress. edit page: page creation works, updates link tables, updates page count page editing works, updates link tables, updates page

[Wikidata-bugs] [Maniphest] [Commented On] T196172: Test schema migration script

2018-06-13 Thread daniel
daniel added a comment. @Anomie Did you just shave off 80% of the runtime? Wow!TASK DETAILhttps://phabricator.wikimedia.org/T196172EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: ops-monitoring-bot, Marostegui, jcrespo, Aklapper, aude

[Wikidata-bugs] [Maniphest] [Closed] T174038: Initial implementation of MCR page update interface

2018-06-14 Thread daniel
daniel closed this task as "Resolved".daniel added a comment. \o/TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majestic

[Wikidata-bugs] [Maniphest] [Unblock] T194729: Allow Wikibase Entities to be stored in alternative slots [MCR]

2018-06-14 Thread daniel
daniel closed subtask T174038: Initial implementation of MCR page update interface as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Cparle, daniel, Lahi, PDrouin

[Wikidata-bugs] [Maniphest] [Unblock] T174023: Implement MCR storage layer

2018-06-14 Thread daniel
daniel closed subtask T174024: Implement MCR revision retrieval interface as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1

[Wikidata-bugs] [Maniphest] [Closed] T174024: Implement MCR revision retrieval interface

2018-06-14 Thread daniel
daniel closed this task as "Resolved".daniel added a comment. This is now implemented. Note however that the new features are still disabled per default. At some point, we'll still have to change $wgMultiContentRevisionSchemaMigrationStage to MIGRATION_NEW.T

[Wikidata-bugs] [Maniphest] [Unblock] T174038: Initial implementation of MCR page update interface

2018-06-14 Thread daniel
daniel closed subtask T174024: Implement MCR revision retrieval interface as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Aklapper, daniel

[Wikidata-bugs] [Maniphest] [Unblock] T174038: Initial implementation of MCR page update interface

2018-06-14 Thread daniel
daniel closed subtask T196653: Test MCR Storage Layer Patches as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Aklapper, daniel, Gaboe420

[Wikidata-bugs] [Maniphest] [Unblock] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-06-14 Thread daniel
daniel closed subtask T196653: Test MCR Storage Layer Patches as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, daniel, Gaboe420, Versusxo, Majestic

[Wikidata-bugs] [Maniphest] [Closed] T196653: Test MCR Storage Layer Patches

2018-06-14 Thread daniel
daniel closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T196653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, danielCc: gerritbot, Addshore, Marostegui, daniel, Aklapper, jcrespo, Anomie, CCicalese_WMF, Gaboe420

[Wikidata-bugs] [Maniphest] [Unblock] T174024: Implement MCR revision retrieval interface

2018-06-14 Thread daniel
daniel closed subtask T196653: Test MCR Storage Layer Patches as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174024EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Abit, tstarling, Addshore, gerritbot, Aklapper, daniel

[Wikidata-bugs] [Maniphest] [Updated] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-06-15 Thread daniel
daniel edited parent tasks, added: T196087: Refactored implementation of MCR page update interface; removed: T174038: Initial implementation of MCR page update interface. TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T174038: Initial implementation of MCR page update interface

2018-06-15 Thread daniel
daniel removed a subtask: T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates. TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T174023: Implement MCR storage layer

2018-06-15 Thread daniel
daniel removed a subtask: T195069: Factor PageStore and PageRecord out of WikiPage. TASK DETAILhttps://phabricator.wikimedia.org/T174023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey

[Wikidata-bugs] [Maniphest] [Updated] T196087: Refactored implementation of MCR page update interface

2018-06-15 Thread daniel
daniel added a subtask: T195069: Factor PageStore and PageRecord out of WikiPage. TASK DETAILhttps://phabricator.wikimedia.org/T196087EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Aklapper, CCicalese_WMF, Lahi, PDrouin-WMF, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T174038: Initial implementation of MCR page update interface

2018-06-15 Thread daniel
daniel removed a subtask: T194034: Make rollback inherit all slots from the target version. TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Aklapper, daniel, Gaboe420

[Wikidata-bugs] [Maniphest] [Updated] T194034: Make rollback inherit all slots from the target version

2018-06-15 Thread daniel
daniel edited parent tasks, added: T174023: Implement MCR storage layer; removed: T174038: Initial implementation of MCR page update interface. TASK DETAILhttps://phabricator.wikimedia.org/T194034EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc

[Wikidata-bugs] [Maniphest] [Updated] T174023: Implement MCR storage layer

2018-06-15 Thread daniel
daniel added a subtask: T194034: Make rollback inherit all slots from the target version. TASK DETAILhttps://phabricator.wikimedia.org/T174023EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente

[Wikidata-bugs] [Maniphest] [Updated] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-06-15 Thread daniel
daniel added a comment. After looking at the code again, it seems to me we want to do T196087: Refactored implementation of MCR page update interface first, and then this. The idea is that we would want to split/refactor DerivedPageDataUpdater before we start using it in more parts of the code. If

[Wikidata-bugs] [Maniphest] [Updated] T194038: Introduce ContentHandler::getSecondaryDataUpdates to replace Content::getSecondaryDataUpdates

2018-06-15 Thread daniel
daniel added a parent task: T190063: Tracking dependencies for multiple Content objects per page (MCR). TASK DETAILhttps://phabricator.wikimedia.org/T194038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, daniel, Gaboe420

[Wikidata-bugs] [Maniphest] [Updated] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-06-15 Thread daniel
daniel added a parent task: T190063: Tracking dependencies for multiple Content objects per page (MCR). TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, daniel, Gaboe420

[Wikidata-bugs] [Maniphest] [Updated] T197252: Can't correctly unserialize cached EntityRevision on WikibaseClient (Wikipedia)

2018-06-15 Thread daniel
daniel added a comment. Note that we really want to get rid of PHP serialization for caching (and in general), see T161647: RFC: Deprecate using php serialization inside MediaWiki and T169328: Protect against PHP code execution via memcached/unserialize.TASK DETAILhttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Created] T197616: Create test version of commons in group0

2018-06-18 Thread daniel
daniel created this task.daniel added projects: Structured-Data-Commons, Release-Engineering-Team.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONThe Structured Data on Commons (SDC) project will change the setup of Commons considerably. Most importantly

[Wikidata-bugs] [Maniphest] [Edited] T197616: Create test version of commons in group0

2018-06-18 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Having a test-commons.wikimedia.org in deployment group 0 on the live cluster will allow us to do two things:...TASK DETAILhttps://phabricator.wikimedia.org/T197616EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-06-18 Thread daniel
daniel removed a parent task: T196087: Refactored implementation of MCR page update interface. TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, gerritbot, daniel, Gaboe420, Versusxo

[Wikidata-bugs] [Maniphest] [Updated] T196087: Refactored implementation of MCR page update interface

2018-06-18 Thread daniel
daniel removed a subtask: T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates. TASK DETAILhttps://phabricator.wikimedia.org/T196087EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Aklapper, CCicalese_WMF, Lahi

[Wikidata-bugs] [Maniphest] [Commented On] T197616: Create test version of commons in group0

2018-06-18 Thread daniel
daniel added a comment. @greg This is not urgent. We discussed it briefly and found it to be a good idea. This ticket is here so we can exchange further thoughts. The beta setup is probably not going to cover all the angles for e.g. wikibase change propagation. It may be good enough to test the

[Wikidata-bugs] [Maniphest] [Commented On] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-06-18 Thread daniel
daniel added a comment. For some reason, Phabricator won't let me add T196087: Refactored implementation of MCR page update interface as a subtask, after I removed it as a parent task. What the hell?TASK DETAILhttps://phabricator.wikimedia.org/T194043EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater

2018-06-19 Thread daniel
daniel created this task.daniel triaged this task as "High" priority.daniel added projects: Wikidata, Structured-Data-Commons, MediaWiki-Platform-Team, Multi-Content-Revisions (MCR-SDC phase 1).Herald added a subscriber: Aklapper. TASK DESCRIPTIONThere is considerable confusion about wh

[Wikidata-bugs] [Maniphest] [Block] T196087: Refactored implementation of MCR page update interface

2018-06-19 Thread daniel
daniel reopened subtask T174038: Initial implementation of MCR page update interface as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T196087EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Aklapper, CCicalese_WMF, Lahi, P

[Wikidata-bugs] [Maniphest] [Block] T194729: Allow Wikibase Entities to be stored in alternative slots [MCR]

2018-06-19 Thread daniel
daniel reopened subtask T174038: Initial implementation of MCR page update interface as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Cparle, daniel, Lahi, PDrouin

[Wikidata-bugs] [Maniphest] [Reopened] T174038: Initial implementation of MCR page update interface

2018-06-19 Thread daniel
daniel reopened this task as "Open".daniel added a comment. Reopening until T193690: RFC: Use ar_page_id to determine the parent IDs for undeleted revisions is resolved.TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Edited] T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater

2018-06-19 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* A CAS check is performed based on rev_id, ensuring the that current revision did not change after it was compared against editRevId to detect an edit conflict. * see also {T58849} for how editRevId and parentRevId

[Wikidata-bugs] [Maniphest] [Unblock] T174030: Implement DB schema migration tools for MCR

2018-06-19 Thread daniel
daniel closed subtask T182682: [MCR] Script(s) for populating new tables (slots, content, content_models, slot_roles) as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174030EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc

[Wikidata-bugs] [Maniphest] [Closed] T182682: [MCR] Script(s) for populating new tables (slots, content, content_models, slot_roles)

2018-06-19 Thread daniel
daniel closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T182682EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: Abit, Addshore, gerritbot, Anomie, thiemowmde, aude, Aklapper, Gaboe420, Versusxo, Majestic

[Wikidata-bugs] [Maniphest] [Claimed] T194412: Make action=undo work with non-main slots.

2018-06-19 Thread daniel
daniel claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T194412EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Anomie, Tgr, daniel, CCicalese_WMF, Aklapper, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF

[Wikidata-bugs] [Maniphest] [Claimed] T194736: Implement automatic conflict resolution for all slots [MCR]

2018-06-19 Thread daniel
daniel claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T194736EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Agabi10, Liuxinyu970226, TomT0m, Smalyshev, Lokal_Profil, -jem-, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente

[Wikidata-bugs] [Maniphest] [Updated] T194736: Implement automatic conflict resolution for all slots [MCR]

2018-06-19 Thread daniel
daniel added a comment. I just realized that this ticket is moot as long as EditPage can only edit the main slot. As long as this is the case, conflicts can only affect the main slot, and merging the main slot is sufficient. So this is really part of the T174033: Refactor EditPage to allow

[Wikidata-bugs] [Maniphest] [Updated] T194736: Implement automatic conflict resolution for all slots [MCR]

2018-06-19 Thread daniel
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC phase 1), Structured-Data-Commons. TASK DETAILhttps://phabricator.wikimedia.org/T194736EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Agabi10

[Wikidata-bugs] [Maniphest] [Updated] T194734: Implement edit conflict resolution for MCR

2018-06-19 Thread daniel
daniel added a comment. I just realized that this ticket is moot as long as EditPage can only edit the main slot. As long as this is the case, conflicts can only affect the main slot, and merging the main slot is sufficient. So this is really part of the T174033: Refactor EditPage to allow

[Wikidata-bugs] [Maniphest] [Updated] T194734: Implement edit conflict resolution for MCR

2018-06-19 Thread daniel
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC phase 2), Structured-Data-Commons. TASK DETAILhttps://phabricator.wikimedia.org/T194734EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, -jem

[Wikidata-bugs] [Maniphest] [Updated] T194734: Implement edit conflict resolution for MCR

2018-06-19 Thread daniel
daniel edited parent tasks, added: T174033: Refactor EditPage to allow multiple slots to be edited atomically [MCR]; removed: T194750: Deploy Structured Data on Commons baseline. TASK DETAILhttps://phabricator.wikimedia.org/T194734EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Updated] T194736: Implement automatic conflict resolution for all slots [MCR]

2018-06-19 Thread daniel
daniel removed a parent task: T174033: Refactor EditPage to allow multiple slots to be edited atomically [MCR]. TASK DETAILhttps://phabricator.wikimedia.org/T194736EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Agabi10, Liuxinyu970226, TomT0m

[Wikidata-bugs] [Maniphest] [Updated] T174038: Initial implementation of MCR page update interface

2018-06-19 Thread daniel
daniel removed a subtask: T190063: Tracking dependencies for multiple Content objects per page (MCR). TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Aklapper, daniel

[Wikidata-bugs] [Maniphest] [Updated] T194750: Deploy Structured Data on Commons baseline

2018-06-19 Thread daniel
daniel added a subtask: T190063: Tracking dependencies for multiple Content objects per page (MCR). TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Abit, Ramsey-WMF, daniel, Lahi, PDrouin

[Wikidata-bugs] [Maniphest] [Updated] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-06-19 Thread daniel
daniel removed a project: Patch-For-Review.daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONCurrently, code that needs to purge or update data derived from page content (during purge, import, undeletion, etc) does so by calling WikiPage::doUpdates and/or by running

[Wikidata-bugs] [Maniphest] [Commented On] T194043: Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates

2018-06-19 Thread daniel
daniel added a comment. I have rewritten the task description to decouple this from T196087. It has become clear to me that the proper implementation of this is blocked by the full refactoring of DerivedPageDataUpdater. So I'm proposing an intermediate implementation that matches what we

[Wikidata-bugs] [Maniphest] [Unblock] T183488: MCR schema migration stage 2: populate new fields

2018-06-20 Thread daniel
daniel closed subtask T174030: Implement DB schema migration tools for MCR as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: Abit, gerritbot, Jdforrester-WMF, Anomie

[Wikidata-bugs] [Maniphest] [Closed] T174030: Implement DB schema migration tools for MCR

2018-06-20 Thread daniel
daniel closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174030EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: Aklapper, daniel, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, S

[Wikidata-bugs] [Maniphest] [Unblock] T174038: Initial implementation of MCR page update interface

2018-06-20 Thread daniel
daniel closed subtask T174030: Implement DB schema migration tools for MCR as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot, Aklapper, daniel

[Wikidata-bugs] [Maniphest] [Unblock] T174045: DB schema migration for MCR

2018-06-20 Thread daniel
daniel closed subtask T174030: Implement DB schema migration tools for MCR as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174045EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Jdforrester-WMF, MZMcBride, Aklapper, daniel, Lah

[Wikidata-bugs] [Maniphest] [Created] T197817: Test $wgMultiContentRevisionSchemaMigrationStage = MIGRATION_WRITE_BOTH on testwiki

2018-06-20 Thread daniel
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Multi-Content-Revisions. TASK DESCRIPTIONTo try out writing to the new, MCR enabled database schema, we want this setting o

[Wikidata-bugs] [Maniphest] [Created] T197816: Enable writing of new MCR schema on live systems

2018-06-20 Thread daniel
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Multi-Content-Revisions.Herald added a subscriber: Aklapper. TASK DESCRIPTIONBefore we can back-fill the new schema, we want to start writing to the new sc

[Wikidata-bugs] [Maniphest] [Created] T197818: Set $wgMultiContentRevisionSchemaMigrationStage = MIGRATION_WRITE_BOTH on commons beta.

2018-06-20 Thread daniel
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Multi-Content-Revisions. TASK DESCRIPTIONTo make sure writing to the new MCR enabled database schema works, we should enable it on a beta

[Wikidata-bugs] [Maniphest] [Edited] T197817: Test $wgMultiContentRevisionSchemaMigrationStage = MIGRATION_WRITE_BOTH on testwiki

2018-06-20 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... $wgMultiContentRevisionSchemaMigrationStage = MIGRATION_WRITE_BOTH; We could also do this on a testwiki dedicated to commons, see {T197616}.TASK DETAILhttps://phabricator.wikimedia.org/T197817EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T194750: Deploy Structured Data on Commons baseline

2018-06-20 Thread daniel
daniel added a subtask: T197816: Enable writing of new MCR schema on live systems. TASK DETAILhttps://phabricator.wikimedia.org/T194750EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Abit, Ramsey-WMF, daniel, Lahi, PDrouin-WMF, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T197816: Enable writing of new MCR schema on live systems

2018-06-20 Thread daniel
daniel added a parent task: T194750: Deploy Structured Data on Commons baseline. TASK DETAILhttps://phabricator.wikimedia.org/T197816EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aude, Addshore, Anomie, Jdforrester-WMF, gerritbot, Abit, Aklapper

[Wikidata-bugs] [Maniphest] [Edited] T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater

2018-06-21 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* $baseRevId of doEditContent: The revision ID this edit was based offreverts to, if any. Not stored, but passed to some hooks. Doesn't seems to be used for anything by core, but some extensions,

[Wikidata-bugs] [Maniphest] [Updated] T197816: Enable writing of new MCR schema on live systems

2018-06-21 Thread daniel
daniel edited projects, added Multi-Content-Revisions (MCR-SDC phase 1); removed Multi-Content-Revisions. TASK DETAILhttps://phabricator.wikimedia.org/T197816EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aude, Addshore, Anomie, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Updated] T197817: Test $wgMultiContentRevisionSchemaMigrationStage = MIGRATION_WRITE_BOTH on testwiki

2018-06-21 Thread daniel
daniel edited projects, added Multi-Content-Revisions (MCR-SDC phase 1); removed Multi-Content-Revisions. TASK DETAILhttps://phabricator.wikimedia.org/T197817EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Abit, gerritbot, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Updated] T197818: Set $wgMultiContentRevisionSchemaMigrationStage = MIGRATION_WRITE_BOTH on commons beta.

2018-06-21 Thread daniel
daniel edited projects, added Multi-Content-Revisions (MCR-SDC phase 1); removed Multi-Content-Revisions. TASK DETAILhttps://phabricator.wikimedia.org/T197818EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aude, Addshore, Anomie, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Edited] T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater

2018-06-22 Thread daniel
daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* rev_parent_id field: The ID of the revision that was current immediately before an edit. Used to display size differences in the page history (compare T193690) NewRevisionFromEditComplete hook: * $baseID: this

[Wikidata-bugs] [Maniphest] [Closed] T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater

2018-06-22 Thread daniel
daniel closed this task as "Resolved".daniel added a comment. With the updated documentation in EditPage and the clarified semantics in WikiPage and PageUpdater, this is now resolved. The remaining patch is not crucial.TASK DETAILhttps://phabricator.wikimedia.org/T197685EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Unblock] T174038: Initial implementation of MCR page update interface

2018-06-22 Thread daniel
daniel closed subtask T197685: Clarify semantics of "base revision" and "parent revision" in EditPage, WikiPage, and PageUpdater as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Unblock] T194729: Allow Wikibase Entities to be stored in alternative slots [MCR]

2018-06-22 Thread daniel
daniel closed subtask T174038: Initial implementation of MCR page update interface as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Cparle, daniel, Lahi, PDrouin

[Wikidata-bugs] [Maniphest] [Closed] T174038: Initial implementation of MCR page update interface

2018-06-22 Thread daniel
daniel closed this task as "Resolved".daniel added a comment. With T197685 resolved, this can no be closed again.TASK DETAILhttps://phabricator.wikimedia.org/T174038EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, gerritbot

[Wikidata-bugs] [Maniphest] [Retitled] T194412: Make action=undo fail gracefully for non-main slots.

2018-06-23 Thread daniel
daniel renamed this task from "Make action="" work with non-main slots." to "Make action="" fail gracefully for non-main slots.".daniel updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONThe undo action should be able to handle slot

[Wikidata-bugs] [Maniphest] [Closed] T194412: Make action=undo fail gracefully for non-main slots.

2018-06-23 Thread daniel
daniel closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T194412EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Anomie, Tgr, daniel, CCicalese_WMF, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, G

[Wikidata-bugs] [Maniphest] [Unblock] T189808: Make action=undo work with multiple slots.

2018-06-23 Thread daniel
daniel closed subtask T194412: Make action="" fail gracefully for non-main slots. as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T189808EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: CCicalese_WMF, Anomie, Aklapper,

[Wikidata-bugs] [Maniphest] [Updated] T196087: Refactored implementation of MCR page update interface

2018-06-25 Thread daniel
daniel added a subtask: T198075: RFC: factoring page update logic out of WIkiPage. TASK DETAILhttps://phabricator.wikimedia.org/T196087EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, Aklapper, CCicalese_WMF, Lahi, PDrouin-WMF, Gq86

[Wikidata-bugs] [Maniphest] [Block] T174030: Implement DB schema migration tools for MCR

2018-06-25 Thread daniel
daniel reopened subtask T182682: [MCR] Script(s) for populating new tables (slots, content, content_models, slot_roles) as "Open". TASK DETAILhttps://phabricator.wikimedia.org/T174030EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc

<    1   2   3   4   5   6   7   8   9   10   >