daniel reopened this task as "Open".daniel added a comment.
Oops, Legoktm intercepted this in the process of being merged. Still needs some formalities resolved. With Brad on vacation, I'll take that on.TASK DETAILhttps://phabricator.wikimedia.org/T182682EMAIL P
daniel assigned this task to Addshore.Herald added a project: User-Addshore.
TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, danielCc: Aklapper, Cparle, daniel, Lahi, PDrouin-WMF, Gq86
daniel added a subtask: T197619: Introduce SCHEMA_COMPAT_XXX constants to allow more fine grained control over the migration process.
TASK DETAILhttps://phabricator.wikimedia.org/T197818EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aude, Addshore
daniel renamed this task from "Set $wgMultiContentRevisionSchemaMigrationStage = MIGRATION_WRITE_BOTH on commons beta." to "Enable MCR migration stage "write both, read old" on commons beta.".daniel updated the task description. (Show Detail
daniel renamed this task from "Test $wgMultiContentRevisionSchemaMigrationStage = MIGRATION_WRITE_BOTH on testwiki" to "Enable MCR migration stage "write both, read old" on testwiki".daniel updated the task description. (Show Detail
daniel renamed this task from "Enable writing of new MCR schema on live systems" to "Enable MCR migration stage "write both, read old" on live systems".daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... $wgMultiConte
daniel created this task.daniel added projects: Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 2).Herald added a subscriber: Aklapper.Herald added a project: Wikidata.
TASK DESCRIPTIONBefore we can back-fill the new schema, we want to start writing to the new schema. This means
daniel created this task.daniel added projects: Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 2), Wikidata.
TASK DESCRIPTIONTo try out the new, MCR enabled database schema, we want this setting on testwiki:
$wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONBefore we can back-fillfully switching to the new schema, we want to start writing towe should exercise the new schemaretrieval code. This means setting...This should then also become the default for vanilla
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION... $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD;
This should then also becomeFor new, we'll keep reading from the default for vanilla installs of MediaWiki.
daniel created this task.daniel added projects: Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 2), Wikidata.
TASK DESCRIPTIONTo try out the new, MCR enabled database schema, we should enable the new retrieval code on a beta wiki first:
$wgMultiContentRevisionSchemaMigrationStage
daniel added a subtask: T197817: Enable MCR migration stage "write both, read old" on testwiki.
TASK DETAILhttps://phabricator.wikimedia.org/T198309EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Abit, Anomie, Tgr, Aklapper, daniel, Lah
daniel added a parent task: T198311: Enable MCR migration stage "write both, read new" on commons beta..
TASK DETAILhttps://phabricator.wikimedia.org/T197818EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aude, Addshore, Anomie, Jdfor
daniel added a subtask: T197818: Enable MCR migration stage "write both, read old" on commons beta..
TASK DETAILhttps://phabricator.wikimedia.org/T198311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Tgr, Anomie, Abit, da
daniel added a parent task: T198309: Enable MCR migration stage "write both, read new" on testwiki.
TASK DETAILhttps://phabricator.wikimedia.org/T197817EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Abit, gerritbot, Jdfor
daniel added a parent task: T198308: Enable MCR migration stage "write both, read new" on live systems.
TASK DETAILhttps://phabricator.wikimedia.org/T197816EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aude, Addshore, Anomie, Jdfor
daniel added a subtask: T197816: Enable MCR migration stage "write both, read old" on live systems.
TASK DETAILhttps://phabricator.wikimedia.org/T198308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Tgr, Anomie, Abit, da
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 2).
TASK DESCRIPTIONThe following setting switches MediaWiki to the new, MCR enabled dabase schema for revisi
daniel added a comment.
Oh, this is missing the requirements for loading entities!TASK DETAILhttps://phabricator.wikimedia.org/T194729EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, danielCc: gerritbot, Aklapper, Cparle, daniel, Gaboe420, Versusxo
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...1. Change WikiPageEntityStore to use the new storage facilities in core (RevisionStore and PageUpdater) instead of Revision.
1. WikiPageEntityRevisionLookup::loadEntity should now use RevisionStore. loadEntityBlob
daniel added a parent task: T198308: Enable MCR migration stage "write both, read new" on live systems.
TASK DETAILhttps://phabricator.wikimedia.org/T183488EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: Abit, gerritbot, Jdfor
daniel added a subtask: T183488: MCR schema migration stage 2: populate new fields.
TASK DETAILhttps://phabricator.wikimedia.org/T198308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Tgr, Anomie, Abit, daniel, Lahi, PDrouin-WMF, Gq86
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...We could also do this on a testwiki dedicated to commons, see {T197616}.
NOTE: this requires populateContentTables.php to be run first. TASK DETAILhttps://phabricator.wikimedia.org/T198309EMAIL PREFERENCEShttps
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...Perhaps commons.wikimedia.beta.wmflabs.org would be a good choice.
NOTE: this requires populateContentTables.php to be run first.TASK DETAILhttps://phabricator.wikimedia.org/T198311EMAIL PREFERENCEShttps
daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC phase 2), Structured-Data-Commons.daniel added a comment.
Dropping this from the SDC backlogTASK DETAILhttps://phabricator.wikimedia.org/T183490EMAIL PREFERENCEShttps://phabricator.wikimedia.org
daniel edited projects, added Multi-Content-Revisions; removed Patch-For-Review, Multi-Content-Revisions (MCR-SDC phase 2), Structured-Data-Commons.daniel added a comment.
Dropping this from the SDC backlogTASK DETAILhttps://phabricator.wikimedia.org/T183487EMAIL PREFERENCEShttps
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 2).
TASK DESCRIPTIONAny code that accesses rev_text_id and ar_text_id fields prevents us from enabling storing e
daniel added a subtask: T198341: Remove all references to the rev_text_id and ar_text_id fields.
TASK DETAILhttps://phabricator.wikimedia.org/T183487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore
daniel added a parent task: T183487: MCR schema migration stage 3: drop support for legacy fields.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 2).
TASK DESCRIPTIONThe 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInf
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 2).
TASK DESCRIPTIONSince Revision::getRevisionText() uses the old_text field which is obtained by joining rev_
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONAny code that accesses rev_text_id and ar_text_id fields prevents us from enabling storing extra slots besides the main slot. In order to enable for MCR support, all references to these fields have to be removed from
daniel added a comment.
Is that stack trace representative? is it always INSERT INTO revision_comment_temp?
It's quite possible that this was caused by the MCR patches, but so far, I don't have any clue as to how or why.TASK DETAILhttps://phabricator.wikimedia.org/T198350EMAIL PREFER
daniel added a comment.
I created a patch that reverts the MCR patches related to RevisionStore, but keeps the change that introduces PageUpdater.
We could deploy the branch with the RevisionStore stuff reverted, and see if it still blows up. Whether or not it does, we'll know more abou
daniel added a comment.
In T198350#4321620, @matmarex wrote:
In T198350#4320899, @AlexisJazz wrote:
Assuming this was not a case of "It compiles, ship it!" I am curious as to why this wasn't noticed when testing.
It appears to require multiple users making actions on a wiki simu
daniel added a comment.
@Aklapper As far as I can see, recent instance of the first two issues T179884 and T197464#4321254, were probably caused by this. The "overwriting image" one (T198177) seems off. It may still be a consequence somehow, but that issue is about updates to the i
daniel added a comment.
The DBPerformance log shows a spike during the time wmf-10 was deployed on group1: https://logstash.wikimedia.org/goto/7c86a7d63a305c220a37a3a49844ef2c. The vast majority of entries are for commonswiki. Here are a few examples:
Sub-optimal transaction on DB(s) [10.64.48.23
daniel added a comment.
After staring at the code a bit, my best guess is:
The MCR refactoring introduced doAtomicSection() to RevisionStore::insertRevisionOn(), to preserve consistency between the revision, slots, and content tables. The atomic section also includes the code for writing the
daniel added a comment.
Here are a few things I poked at, without finding anything relevant:
@Tgr suspects that the something is grabbing a FOR UPDATE lock on revision_comment_temp. But the only code that seems to do that seems to be in WikiPage::doDeleteArticleReal(), which shouldn't be c
daniel added a comment.
The above patch is an alternative attempt to fix the lock retention issue. It's the best I can think of. Not sure this will fix the problem, though.TASK DETAILhttps://phabricator.wikimedia.org/T198350EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/
daniel created this task.daniel added projects: Structured-Data-Commons, Multi-Content-Revisions (MCR-SDC phase 1).Herald added a project: Wikidata.
TASK DESCRIPTIONWe want to be able to write extra slots, such as the media-info slot for SDC, before we disable support for the old schema. Otherwise
daniel added a subtask: T198413: Allow multiple slots to be used while still writing to the old schema.
TASK DETAILhttps://phabricator.wikimedia.org/T198311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Tgr, Anomie, Abit, daniel, Lahi
daniel added a parent task: T198311: Enable MCR migration stage "write both, read new" on commons beta..
TASK DETAILhttps://phabricator.wikimedia.org/T198413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Anomie, Tgr, Aklapper, daniel, Lah
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONWe want to be able to write extra slots, such as the media-info slot for SDC, before we disable support for the old schema. Otherwise, enabling additional slots would be blocked on {T183487}, which is probably going to
daniel renamed this task from "Allow multiple slots to be used while still writing to the old schema" to "Allow multiple slots to be used while still writing to the old as well as the new schema".
TASK DETAILhttps://phabricator.wikimedia.org/T198413EM
daniel closed subtask T182682: [MCR] Script(s) for populating new tables (slots, content, content_models, slot_roles) as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T174030EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc
daniel closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T182682EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, danielCc: daniel, Abit, Addshore, gerritbot, Anomie, thiemowmde, aude, Aklapper, Gaboe420
daniel claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T198413EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Anomie, Tgr, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi
daniel created this task.daniel added a project: Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONProblem:
MediaWiki allows the content of old revisions to be suppressed (aka "oversighted" aka "rev-deleted"). Wikibase so far bypasses this check and will disp
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* EntityRevision should support privileged access, allowing users with the appropriate permissions to access suppressed content. Revision and RevisionStore use "audience" parameters for this, a similar appr
daniel triaged this task as "High" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T198467EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Addshore, WMDE-leszek, Lydia_Pintscher, daniel, Lahi, Gq86, GoranSMilovanovi
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Multi-Content-Revisions.
TASK DESCRIPTIONThe rev_text_id and ar_text_id are no longer populated when SCHEMA_COMPAT_WRITE_OLD is no longer set in $wgMultiContentrevisionMigrationS
daniel added a subtask: T198341: Remove all references to the rev_text_id and ar_text_id fields.
TASK DETAILhttps://phabricator.wikimedia.org/T198492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, aude, Addshore, Anomie, Jdforrester-WMF
daniel added a parent task: T198492: Drop rev_text_id and ar_text_id when running update.php.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude
daniel added a comment.
Well, SCHEMA_COMPAT_WRITE_OLD is effectively the default now.
Dropping these fields basically means only SCHEMA_COMPAT_WRITE_NEW | SCHEMA_COMPAT_READ_NEW is supported. So it can only be done after migration is complete.
I was planning to create a few more tickets to track
daniel renamed this task from "MCR schema migration stage 3: drop support for legacy fields" to "MCR schema migration stage 3: drop support for legacy fields (wmf production)".
TASK DETAILhttps://phabricator.wikimedia.org/T183487EMAIL PREFERENCEShttps://phabricator.wikimedi
daniel renamed this task from "MCR schema migration stage 4: Migrate External Store URLs" to "MCR schema migration stage 4: Migrate External Store URLs (wmf production)".
TASK DETAILhttps://phabricator.wikimedia.org/T183490EMAIL PREFERENCEShttps://phabricator.wikimedi
daniel removed a parent task: T183487: MCR schema migration stage 3: drop support for legacy fields (wmf production).
TASK DETAILhttps://phabricator.wikimedia.org/T198492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, aude, Addshore
daniel removed a subtask: T198492: Drop rev_text_id and ar_text_id when running update.php.
TASK DETAILhttps://phabricator.wikimedia.org/T183487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude
daniel added a parent task: T107595: [RFC] Multi-Content Revisions.
TASK DETAILhttps://phabricator.wikimedia.org/T198492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, aude, Addshore, Anomie, Jdforrester-WMF, Tgr, gerritbot, daniel, Lahi
daniel added a subtask: T198492: Drop rev_text_id and ar_text_id when running update.php.
TASK DETAILhttps://phabricator.wikimedia.org/T107595EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: brion, danielCc: Nirmos, CCicalese_WMF, PokestarFan, Rical, Ayack
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Multi-Content-Revisions, MW-1.33-release.
TASK DESCRIPTIONOnce all code has been ported to use the new MCR schema, B/C code for the legacy schema should be removed:
remove support f
daniel removed subscribers: aude, Addshore, gerritbot.daniel added a project: MW-1.33-release.daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONThe rev_text_id and ar_text_id are no longer populated when SCHEMA_COMPAT_WRITE_OLD is no longer set in
daniel added a parent task: T198557: Remove support for legacy pre-MCR schema.
TASK DETAILhttps://phabricator.wikimedia.org/T198312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, aude, Addshore, Anomie, Jdforrester-WMF, Tgr, gerritbot
daniel renamed this task from "Enable new MCR storage schemas on live systems" to "Set the WMF cluster to use the new MCR-only schema".
TASK DETAILhttps://phabricator.wikimedia.org/T198312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To
daniel added a subtask: T198312: Enable new MCR storage schemas on live systems.
TASK DETAILhttps://phabricator.wikimedia.org/T198557EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Fjalapeno, CCicalese_WMF, Aklapper, daniel, Lahi, Gq86
daniel edited subscribers, added: CCicalese_WMF, Fjalapeno; removed: aude, Addshore, Anomie, Jdforrester-WMF, Tgr.daniel removed a project: Multi-Content-Revisions (MCR-SDC phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T198312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* archive.ar_content_format
WARNING: This marks the POINT OF NO RETURN for MCR deployment to the WMF cluster!
TASK DETAILhttps://phabricator.wikimedia.org/T198312EMAIL PREFERENCEShttps://phabricator.wikimedia.org
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...This enables the use of multiple slots per revision, and renders the following database fields unused:...TASK DETAILhttps://phabricator.wikimedia.org/T198312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings
daniel added a subtask: T198308: Enable MCR migration stage "write both, read new" on live systems.
TASK DETAILhttps://phabricator.wikimedia.org/T198312EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Fjalapeno, CCicalese_WMF, Aklapper,
daniel added a parent task: T198312: Set the WMF cluster to use the new MCR-only schema.
TASK DETAILhttps://phabricator.wikimedia.org/T198308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Tgr, Anomie, Abit, daniel, Lahi, PDrouin-WMF, Gq86
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons.
TASK DESCRIPTIONThe following setting switches fully MediaWiki to the new, MCR enabled database schema for revision storage:
$wgMultiContentRevisionSchemaMigr
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONThe following setting fully switches MediaWiki to the new, MCR enabled database schema for revision storage:...TASK DETAILhttps://phabricator.wikimedia.org/T198312EMAIL PREFERENCEShttps://phabricator.wikimedia.org
daniel added a subtask: T198309: Enable MCR migration stage "write both, read new" on testwiki.
TASK DETAILhttps://phabricator.wikimedia.org/T198558EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Fjalapeno, CCicalese_WMF, Aklapper, da
daniel added a parent task: T198558: Set testwiki to use the new MCR-only schema.
TASK DETAILhttps://phabricator.wikimedia.org/T198309EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Abit, Anomie, Tgr, Aklapper, daniel, Lahi, PDrouin-WMF, Gq86
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Structured-Data-Commons.
TASK DESCRIPTIONThe following setting switches fully MediaWiki to the new, MCR enabled database schema for revision storage:
$wgMultiContentRevisionSchemaMigr
daniel added a parent task: T198559: Set beta wikis to use the new MCR-only schema.
TASK DETAILhttps://phabricator.wikimedia.org/T198311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, Tgr, Anomie, Abit, daniel, Lahi, PDrouin-WMF, Gq86
daniel added a subtask: T198311: Enable MCR migration stage "write both, read new" on commons beta..
TASK DETAILhttps://phabricator.wikimedia.org/T198559EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, CCicalese_WMF, Fjalapeno, da
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Multi-Content-Revisions, MW-1.32-release.
TASK DESCRIPTIONMediaWiki 1.32 should support MCR, but still remain backwards compatible. This allows wiki instances to back out of MCR with
daniel added a subtask: T198308: Enable MCR migration stage "write both, read new" on live systems.
TASK DETAILhttps://phabricator.wikimedia.org/T198561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: greg, Aklapper, CCicalese_WMF, Fjalape
daniel added a parent task: T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs.
TASK DETAILhttps://phabricator.wikimedia.org/T198308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, T
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONBefore fully switching to the new schema, we should exercise the new retrieval code. This means setting
$wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;
This keeps
daniel created this task.daniel triaged this task as "Normal" priority.daniel added projects: Wikidata, Multi-Content-Revisions (MCR-SDC phase 2).
TASK DESCRIPTIONWe want to enable MCR in forward-compatible mode for use in CI and on development systems.
The new default
daniel added a subtask: T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs.
TASK DETAILhttps://phabricator.wikimedia.org/T198308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Fjalapeno, CCi
daniel added a parent task: T198308: Enable MCR migration stage "write both, read new" on live systems.
TASK DETAILhttps://phabricator.wikimedia.org/T198561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: greg, Aklapper, CCicalese_WMF,
daniel removed a parent task: T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs.
TASK DETAILhttps://phabricator.wikimedia.org/T198308EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc:
daniel removed a subtask: T198308: Enable MCR migration stage "write both, read new" on live systems.
TASK DETAILhttps://phabricator.wikimedia.org/T198561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: greg, Aklapper, CCicalese_WMF,
daniel added a subtask: T198311: Enable MCR migration stage "write both, read new" on commons beta..
TASK DETAILhttps://phabricator.wikimedia.org/T198561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: greg, Aklapper, CCicalese_WMF, Fjalape
daniel edited projects, added Multi-Content-Revisions (MCR-SDC phase 2); removed Multi-Content-Revisions.
TASK DETAILhttps://phabricator.wikimedia.org/T198561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: greg, Aklapper, CCicalese_WMF, Fjalapeno
daniel added a parent task: T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs.
TASK DETAILhttps://phabricator.wikimedia.org/T198311EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Aklapper, T
daniel edited projects, added Multi-Content-Revisions (MCR-SDC phase 1); removed Multi-Content-Revisions (MCR-SDC phase 2).
TASK DETAILhttps://phabricator.wikimedia.org/T198561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: greg, Aklapper
daniel edited projects, added Multi-Content-Revisions (MCR-SDC phase 2); removed Multi-Content-Revisions (MCR-SDC phase 1).
TASK DETAILhttps://phabricator.wikimedia.org/T198561EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: greg, Aklapper
daniel added a comment.
@Anomie you are correct, but I don't see this as a huge problem, for two reasons:
rolling back to main-slot-only after people have started to use extra slots extensively is unlikely.
if it does happen, it would be temporary
the breakage would not be worse than wha
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...NOTE: **This enables the usage of extra slots on the live systems!**
If we are forced to roll this back, we will lose access to the content of the new, extra slots. Rolling forward again would restore that access for
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...WARNING: This marks the **POINT OF NO RETURN** for MCR deployment to the WMF cluster! Rolling this back would render all content of new revisions inaccessible!
TASK DETAILhttps://phabricator.wikimedia.org
daniel renamed this task from "lxcaaa" to " Deploy Structured Data on Commons baseline ".daniel raised the priority of this task from "High" to "Needs Triage".daniel added a subscriber: Aklapper.daniel removed projects: TCB-Team, Mail, New-Ed
daniel renamed this task from "6xcaaa" to "Allow Wikibase Entities to be stored in alternative slots [MCR]".daniel lowered the priority of this task from "High" to "Normal".daniel removed projects: TCB-Team, Mail, New-Editor-Experiences, Language-20
daniel added a comment.
@ArielGlen found the bug:
In https://phabricator.wikimedia.org/source/mediawiki/browse/master/maintenance/categoryChangesAsRdf.php$223 we have:
$tables += $extra_tables;
But += does not work as expected on indexed arrays in PHP. using array_merge instead fixes the issue
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...With this setting enabled, update.php should convert to the new schema, if that did not previously happen. If update.php detects $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH
daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...NOTE: $wgMultiContentRevisionSchemaMigrationStage will only have a pre-existing value on wikis that were installed off a snapshot or master, since $wgMultiContentRevisionSchemaMigrationStage did not exist in 1.31
401 - 500 of 5375 matches
Mail list logo
