[Wikidata-bugs] [Maniphest] [Updated] T186726: Security review WikibaseLexeme extension

2018-03-05 Thread thiemowmde
thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from ready to go to in progress on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T186726WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T186726: Security review WikibaseLexeme extension

2018-03-05 Thread thiemowmde
thiemowmde added a comment. I uploaded fixes for two issues: https://gerrit.wikimedia.org/r/416406 https://github.com/wmde/php-vuejs-templating/pull/6 FormIdFormatter and SenseIdFormatter are dummy implementations. The escaping is fine. I created T188899: [Task] Remove hard-coded demo data

[Wikidata-bugs] [Maniphest] [Updated] T188899: [Task] Remove hard-coded demo data from Lexeme code base

2018-03-05 Thread thiemowmde
thiemowmde added a parent task: T168260: Deploy WikibaseLexeme extension on Wikimedia cluster. TASK DETAILhttps://phabricator.wikimedia.org/T188899EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: RazShuty, Ladsgroup, Jonas, Aleksey_WMDE, WMDE

[Wikidata-bugs] [Maniphest] [Updated] T168260: Deploy WikibaseLexeme extension on Wikimedia cluster

2018-03-05 Thread thiemowmde
thiemowmde added a subtask: T188899: [Task] Remove hard-coded demo data from Lexeme code base. TASK DETAILhttps://phabricator.wikimedia.org/T168260EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, daniel, Lahi, Gq86, Cinemantique

[Wikidata-bugs] [Maniphest] [Created] T188899: [Task] Remove hard-coded demo data from Lexeme code base

2018-03-05 Thread thiemowmde
thiemowmde created this task.thiemowmde added projects: Wikidata, Lexicographical data, Technical-Debt.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIn T186726: Security review WikibaseLexeme extension the #security-reviews team stumbled across hard-coded demo data in the Lexeme code base

[Wikidata-bugs] [Maniphest] [Raised Priority] T188378: Error for some Lua modules "The time allocated for running scripts has expired"

2018-03-05 Thread thiemowmde
thiemowmde raised the priority of this task from "Lowest" to "Normal".thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde added a project: Performance.thiemowmde added a comment. What generally changed since November

[Wikidata-bugs] [Maniphest] [Updated] T74157: [Story] Use rc_source and drop RC_TYPE

2018-03-05 Thread thiemowmde
thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from needs discussion or investigation to in progress on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T74157WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T179793: Consider dropping the "wb_items_per_site.wb_ips_site_page" index

2018-03-04 Thread thiemowmde
thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde moved this task from incoming to in progress on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T179793WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T188182: Special:Nearby no longer shows descriptions on Wikidata

2018-03-04 Thread thiemowmde
thiemowmde added subscribers: pmiazga, Lea_Lacroix_WMDE.thiemowmde added a comment. Looks like said MFEnableWikidataDescriptions flag was introduced via https://gerrit.wikimedia.org/r/402126 (T182362) and https://gerrit.wikimedia.org/r/408357 (T182217) some weeks ago. But since this is disabled

[Wikidata-bugs] [Maniphest] [Triaged] T188182: Special:Nearby no longer shows descriptions on Wikidata

2018-03-02 Thread thiemowmde
thiemowmde added subscribers: Lydia_Pintscher, thiemowmde.thiemowmde added projects: Regression, MobileFrontend, Wikidata.org.thiemowmde triaged this task as "Low" priority.thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemo

[Wikidata-bugs] [Maniphest] [Triaged] T184948: limit page creation rate on Wikidata

2018-03-02 Thread thiemowmde
thiemowmde triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T184948EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: hoo, Sjoerddebruin, Addshore, Ladsgroup, gerritbot, Aklapper, Lydia_Pintscher, G

[Wikidata-bugs] [Maniphest] [Triaged] T188629: Completely remove support for detail and detailHTML in wbcheckconstraints response

2018-03-02 Thread thiemowmde
thiemowmde triaged this task as "Low" priority.thiemowmde added a project: Technical-Debt.thiemowmde moved this task from incoming to ready to go on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T188629WORKBOARDhttps://phabricator.wikimedia.org/project/boar

[Wikidata-bugs] [Maniphest] [Triaged] T150690: Special:Pages using property/P

2018-03-02 Thread thiemowmde
thiemowmde triaged this task as "Low" priority.thiemowmde added a project: Need-volunteer. TASK DETAILhttps://phabricator.wikimedia.org/T150690EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Mikey641, IKhitron, Aklapper, eranroz,

[Wikidata-bugs] [Maniphest] [Triaged] T134731: Mark changes to non-local sitelinks as minor

2018-03-02 Thread thiemowmde
thiemowmde triaged this task as "Low" priority.thiemowmde added a project: Need-volunteer. TASK DETAILhttps://phabricator.wikimedia.org/T134731EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aklapper, jeblad, Zppix, Lahi, Gq86, GoranSM

[Wikidata-bugs] [Maniphest] [Triaged] T188728: Replace claim with violation message in Special:ConstraintReport

2018-03-02 Thread thiemowmde
thiemowmde added subscribers: Jan_Dittrich, Lydia_Pintscher, thiemowmde.thiemowmde triaged this task as "Normal" priority.thiemowmde added a project: WMDE-Design.thiemowmde added a comment.Herald added a project: Design. I'm very happy with the proposed change for multiple reasons:

[Wikidata-bugs] [Maniphest] [Triaged] T188722: Remove Moldovan Wikipedia from WDQS

2018-03-02 Thread thiemowmde
thiemowmde added subscribers: daniel, thiemowmde, Addshore.thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde triaged this task as "Low" priority.thiemowmde added a project: MediaWiki-extensions-WikibaseRepository.thiemo

[Wikidata-bugs] [Maniphest] [Triaged] T188381: Avoid joining three tables just to get the latest revision ID

2018-03-02 Thread thiemowmde
thiemowmde triaged this task as "Low" priority.thiemowmde added a project: Technical-Debt. TASK DETAILhttps://phabricator.wikimedia.org/T188381EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, thiemowmdeCc: gerritb

[Wikidata-bugs] [Maniphest] [Closed] T188735: Violation messages on Special:ConstraintReport don’t include links

2018-03-02 Thread thiemowmde
thiemowmde added a project: Wikidata-Sprint-2018-02-28.thiemowmde closed this task as "Resolved".thiemowmde moved this task from incoming to in progress on the Wikidata board.thiemowmde assigned this task to Lucas_Werkmeister_WMDE. TASK DETAILhttps://phabricator.wikimedia.org/T188735WORK

[Wikidata-bugs] [Maniphest] [Triaged] T188279: Investigate optimzing wb_terms

2018-03-02 Thread thiemowmde
thiemowmde triaged this task as "Normal" priority.thiemowmde added a comment. The term_entity_type is not needed any more in Wikibase code, as far as I'm aware of. Third parties can extract the entity type from the first letter of term_full_entity_id, if needed. The mapping for term_t

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T143706: Implement TermLookup based on Elastic

2018-03-02 Thread thiemowmde
thiemowmde edited subscribers, added: WMDE-leszek; removed: Rzuwig, JanZerebecki.thiemowmde added a comment. Yea, there is an interface violation in WikibaseClient::getPrefetchingTermLookup as well as WikibaseRepo::getPrefetchingTermLookup. I uploaded https://gerrit.wikimedia.org/r/415816

[Wikidata-bugs] [Maniphest] [Commented On] T186726: Security review WikibaseLexeme extension

2018-03-02 Thread thiemowmde
thiemowmde added a comment. I added the WIP originally. The only open dependency is a separate security review of https://github.com/wmde/php-vuejs-templating, which needs a separate #security-reviews ticket. Everything else is resolved, so this is ready to go from my point of view. :-)TASK

[Wikidata-bugs] [Maniphest] [Unblock] T71753: [Story] Wikibase / Wikidata support on Wikiquote

2018-03-01 Thread thiemowmde
thiemowmde closed subtask T71752: Refactor EntityContent (tracking) as "Invalid". TASK DETAILhttps://phabricator.wikimedia.org/T71753EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Yair_rand, PokestarFan, Liuxinyu970226, Micru

[Wikidata-bugs] [Maniphest] [Closed] T71752: Refactor EntityContent (tracking)

2018-03-01 Thread thiemowmde
thiemowmde closed this task as "Invalid".thiemowmde added a comment. Yes and no. Refactoring EntityContent is an ongoing task that will never end. We don't need this ticket to do this, especially since this tickets description is quite vague and not really actionable.TASK D

[Wikidata-bugs] [Maniphest] [Commented On] T188599: Add monolingual language code sju

2018-03-01 Thread thiemowmde
thiemowmde added a comment. Adding language codes generally needs consensus by the language committee, which is a part of the community, as far as I'm aware of. Yes, the patch is already uploaded – by a volunteer. Therefor the tag.TASK DETAILhttps://phabricator.wikimedia.org/T188599EMAIL

[Wikidata-bugs] [Maniphest] [Triaged] T188378: Error for some Lua modules "The time allocated for running scripts has expired"

2018-03-01 Thread thiemowmde
thiemowmde triaged this task as "Lowest" priority.thiemowmde added projects: Need-volunteer, MediaWiki-extensions-WikibaseClient.thiemowmde added a comment. Scratching the limits is basically the point of these maintenance pages. Whenever something like this is done, it is pretty much

[Wikidata-bugs] [Maniphest] [Updated] T114903: Migrate wb_terms to using prefixed entity IDs instead of numeric IDs

2018-03-01 Thread thiemowmde
thiemowmde removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T114903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, Stashbot, gerritbot, PokestarFan, Pasleim, Ricordisamoa, JanZerebecki, hoo, daniel

[Wikidata-bugs] [Maniphest] [Triaged] T114903: Migrate wb_terms to using prefixed entity IDs instead of numeric IDs

2018-03-01 Thread thiemowmde
thiemowmde triaged this task as "Normal" priority.thiemowmde added a project: Technical-Debt. TASK DETAILhttps://phabricator.wikimedia.org/T114903EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ladsgroup, Stashbot, gerritbot, P

[Wikidata-bugs] [Maniphest] [Retitled] T188534: [Bug] Format constraint incorrectly interprets regexes containing unwrapped "|"

2018-03-01 Thread thiemowmde
thiemowmde renamed this task from "Format constraint incorrectly interprets regexes containing unwrapped "|"" to "[Bug] Format constraint incorrectly interprets regexes containing unwrapped "|"".thiemowmde added a subscriber: Jonas. TASK DETAILhttps:

[Wikidata-bugs] [Maniphest] [Triaged] T188534: Format constraint incorrectly interprets regexes containing unwrapped "|"

2018-03-01 Thread thiemowmde
thiemowmde triaged this task as "Normal" priority.thiemowmde added a project: Easy.thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board.thiemowmde added a comment. Yea, simply add (?:…) around all regexes, no matter what they contain. This is a

[Wikidata-bugs] [Maniphest] [Triaged] T188580: Add monolingual language code smn

2018-03-01 Thread thiemowmde
thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Easy, Community-consensus-needed, Need-volunteer, MediaWiki-extensions-WikibaseRepository. TASK DETAILhttps://phabricator.wikimedia.org/T188580EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Triaged] T188579: Add monolingual language code sms

2018-03-01 Thread thiemowmde
thiemowmde added projects: Easy, Community-consensus-needed, Need-volunteer, MediaWiki-extensions-WikibaseRepository.thiemowmde triaged this task as "Low" priority. TASK DETAILhttps://phabricator.wikimedia.org/T188579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Triaged] T188596: Add monolingual language code sjd

2018-03-01 Thread thiemowmde
thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Need-volunteer, Easy, Community-consensus-needed, MediaWiki-extensions-WikibaseRepository. TASK DETAILhttps://phabricator.wikimedia.org/T188596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] [Updated] T188599: Add monolingual language code sju

2018-03-01 Thread thiemowmde
thiemowmde added a project: MediaWiki-extensions-WikibaseRepository. TASK DETAILhttps://phabricator.wikimedia.org/T188599EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby-WMNO, thiemowmdeCc: Nikerabbit, gerritbot, jhsoby-WMNO, Giuliamocci, Adrian1985

[Wikidata-bugs] [Maniphest] [Triaged] T188599: Add monolingual language code sju

2018-03-01 Thread thiemowmde
thiemowmde added projects: Community-consensus-needed, Easy, Need-volunteer.thiemowmde triaged this task as "Low" priority. TASK DETAILhttps://phabricator.wikimedia.org/T188599EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jhsoby-WMNO, th

[Wikidata-bugs] [Maniphest] [Commented On] T139228: Better match language names when creating Wikidata items

2018-03-01 Thread thiemowmde
thiemowmde added a comment. Oh, absolutely right. Thanks! It's just an other approach: I was more thinking in the line of teaching all suggesters to understand word boundaries, no matter what the content of the suggester is. Reusing the ULS API when searching for languages is definitely worth

[Wikidata-bugs] [Maniphest] [Commented On] T139228: Better match language names when creating Wikidata items

2018-03-01 Thread thiemowmde
thiemowmde added a comment. Sure. That's not what I wanted to imply. What OOUI can do is to look at the UX pattern and apply it via it's own, independent client-side code. What a word-boundary is is defined in RegExp. OOUI can reuse this definition (being aware it will not work in languages where

[Wikidata-bugs] [Maniphest] [Triaged] T139228: Better match language names when creating Wikidata items

2018-02-28 Thread thiemowmde
thiemowmde added projects: OOUI, WMDE-Design, Need-volunteer.thiemowmde triaged this task as "Normal" priority.thiemowmde added a comment.Herald added a project: Design. Special:NewItem is using OOUI now, which means this needs to be filled as an upstream feature request

[Wikidata-bugs] [Maniphest] [Closed] T139227: Enable sorting of interwiki links in Wikibase Client

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Invalid".thiemowmde added a project: MediaWiki-extensions-InterwikiSorting.thiemowmde added a comment. To clean our backlogs I'm going to close this for now, for the following reasons: I don't see a problem on https://en.wikipedia.org/wiki/Main_Page.

[Wikidata-bugs] [Maniphest] [Updated] T92365: [Story] Centralize Wikibase documentation process and assign responsibilities

2018-02-28 Thread thiemowmde
thiemowmde added subscribers: Lea_Lacroix_WMDE, thiemowmde.thiemowmde added a project: Documentation.thiemowmde added a comment. @Lea_Lacroix_WMDE, do you think this ticket is helpful? I suggest to close it as invalid because it is barely actionable. Closing this would not mean we don't care about

[Wikidata-bugs] [Maniphest] [Updated] T89350: Impose standard on capitalizing concept terms in messages

2018-02-28 Thread thiemowmde
thiemowmde added projects: Documentation, Easy.thiemowmde added a subscriber: Lea_Lacroix_WMDE.thiemowmde added a comment. I also vote for capitalization. This is especially important for (intentionally) vague concepts like "Entity", "Item", "Property", and "F

[Wikidata-bugs] [Maniphest] [Commented On] T110335: [Task] Merging WikibaseQuality branches "reverted" a lot of relevant changes

2018-02-28 Thread thiemowmde
thiemowmde added a comment. I would not walk through the diffs, but through the individual commits. As I said in this tasks description I did not spotted all changes that still might be worth cherry-picking. Spotting these is what this ticket here is about.TASK DETAILhttps

[Wikidata-bugs] [Maniphest] [Triaged] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-02-28 Thread thiemowmde
thiemowmde moved this task from incoming to ready to go on the Wikidata board.thiemowmde triaged this task as "Normal" priority.thiemowmde added a project: Technical-Debt.thiemowmde added a comment. This is an actual bug, still relevant.TASK DETAILhttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Unblock] T118860: [RFC] Use Role Object Pattern to represent derived data in the data model

2018-02-28 Thread thiemowmde
thiemowmde closed subtask T132443: [Task] Discuss design of (De)Serializer interfaces as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T118860EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, thiemowmdeCc: Tobi_WMDE_SW, Bene, Lydia

[Wikidata-bugs] [Maniphest] [Declined] T132443: [Task] Discuss design of (De)Serializer interfaces

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Declined".thiemowmde added a comment. I close this for now to reduce our backlog. This does not mean these unspecific "mixed" interfaces do not need discussion any more. But we can continue working on this code whenever the need ari

[Wikidata-bugs] [Maniphest] [Unblock] T56098: [Epic][UI] Front-end performance: Improve loading time of items

2018-02-28 Thread thiemowmde
thiemowmde closed subtask T124783: [Task] Investigate how to improve loading time of individual widgets as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T56098EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Agabi10, Multi

[Wikidata-bugs] [Maniphest] [Declined] T124783: [Task] Investigate how to improve loading time of individual widgets

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Declined".thiemowmde added a comment. No expectations are given. In general it is very unlikely people are ever working on the jQueryUI based parts of the code again.TASK DETAILhttps://phabricator.wikimedia.org/T124783EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Unblock] T56098: [Epic][UI] Front-end performance: Improve loading time of items

2018-02-28 Thread thiemowmde
thiemowmde closed subtask T118968: [Task] Investigate if removing of events improves loading times as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T56098EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Agabi10, Multi

[Wikidata-bugs] [Maniphest] [Declined] T118968: [Task] Investigate if removing of events improves loading times

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Declined".thiemowmde added a comment. I'm afraid there is nothing actionable here. That part of the jQueryUI based UI is very, very unlikely to ever be touched again.TASK DETAILhttps://phabricator.wikimedia.org/T118968EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Closed] T110533: [Bug] The ValueView CI does not run its own QUnit tests

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Resolved".thiemowmde claimed this task.thiemowmde added a comment. Fixed via T177816: Turn pseudo-extension data-values/value-view into a npm package.TASK DETAILhttps://phabricator.wikimedia.org/T110533EMAIL PREFERENCEShttps://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Lowered Priority] T110335: [Task] Merging WikibaseQuality branches "reverted" a lot of relevant changes

2018-02-28 Thread thiemowmde
thiemowmde lowered the priority of this task from "High" to "Low".thiemowmde added a subscriber: Lucas_Werkmeister_WMDE.thiemowmde added a comment. @Lucas_Werkmeister_WMDE, you are currently most familiar with these code bases. Do you think it's worth looking at the

[Wikidata-bugs] [Maniphest] [Commented On] T107864: [Task] Create ValueParserFactory integration test for the global wgValueParsers setting

2018-02-28 Thread thiemowmde
thiemowmde added a comment. @Lydia_Pintscher, is it worth spending time on a test that makes sure …action="">, …parser=globecoordinate, and …parser=null will work forever? I mean, even if somebody removes these three lines of configuration some day, the worst thing that will happen

[Wikidata-bugs] [Maniphest] [Declined] T103086: [Story] Have an "always fail" feature in WikibaseJavaScriptApi for testing purposes

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Declined".thiemowmde removed a project: Story.thiemowmde added a comment. This ticket is proposing a solution disconnected from a story, and is more of an RfC than anything else because of this. Closing for now as there are no plans to work on

[Wikidata-bugs] [Maniphest] [Lowered Priority] T99907: [RFC] Human-readable serialization of TimeValue precisions in RDF

2018-02-28 Thread thiemowmde
thiemowmde lowered the priority of this task from "High" to "Low". TASK DETAILhttps://phabricator.wikimedia.org/T99907EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Liuxinyu970226, mkroetzsch, Smalyshev, daniel, thiemowmde,

[Wikidata-bugs] [Maniphest] [Updated] T98468: [Story] Include example JSON blobs in API module descriptions

2018-02-28 Thread thiemowmde
thiemowmde added a project: Documentation.thiemowmde added a subscriber: Lea_Lacroix_WMDE. TASK DETAILhttps://phabricator.wikimedia.org/T98468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Lea_Lacroix_WMDE, Addshore, Lucie, hoo, aude

[Wikidata-bugs] [Maniphest] [Declined] T96659: Force or fix Packagist update trigger or get rid of Packagist dependency

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Declined".thiemowmde added a comment. I'm still running into this on a regular basis. Luckily I can work around it now because I became administrator for all packages I care about (poke me if you need to become administrator too). Since getting rid of

[Wikidata-bugs] [Maniphest] [Unblock] T77977: [Epic] Unit support

2018-02-28 Thread thiemowmde
thiemowmde closed subtask T95425: [Bug] Quantity formatter rounding causes significant data loss as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T77977EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: PokestarFan, Ash_Crow, P

[Wikidata-bugs] [Maniphest] [Closed] T95425: [Bug] Quantity formatter rounding causes significant data loss

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Resolved".thiemowmde claimed this task.thiemowmde added a comment. Since https://github.com/DataValues/Number/pull/68 we are not applying artificial rounding any more when the precision is shown. \o/TASK DETAILhttps://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Unblock] T56318: Quantity datatype (tracking)

2018-02-28 Thread thiemowmde
thiemowmde closed subtask T95425: [Bug] Quantity formatter rounding causes significant data loss as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T56318EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: TerraCodes, jebl

[Wikidata-bugs] [Maniphest] [Declined] T93867: [Task] Consolidate "Created a new item" summary line messages

2018-02-28 Thread thiemowmde
thiemowmde closed this task as "Declined".thiemowmde added a comment.Herald removed a subscriber: Liuxinyu970226. The first two message keys are not used in the code any more, but must stay because there are still edit summaries with these message keys in the database. qqq.json

[Wikidata-bugs] [Maniphest] [Unblock] T90435: [Epic] Wikidata watchlist improvements (client)

2018-02-28 Thread thiemowmde
thiemowmde closed subtask T93867: [Task] Consolidate "Created a new item" summary line messages as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T90435EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Zac

[Wikidata-bugs] [Maniphest] [Commented On] T68651: Make last character optional in globe/geo/lat-long parsers

2018-02-28 Thread thiemowmde
thiemowmde added a comment. I'm a big fan of parsers that do their very best to figure out what the user means. The examples provided here and not unambiguous, as far as I can tell, and can not lead to problematic edge cases. Personally I would be willing to work on this any time when approved

[Wikidata-bugs] [Maniphest] [Lowered Priority] T66515: [Story] Direct link to download the raw JSON data of each Entity

2018-02-28 Thread thiemowmde
thiemowmde lowered the priority of this task from "Normal" to "Low".thiemowmde added a project: Easy.thiemowmde added a comment. I still believe this would be helpful. Even if the only thing it would do is to trigger the explorer gene in some curious people. That alone would be

[Wikidata-bugs] [Maniphest] [Triaged] T188354: Remove phpunit/phpunit dependencies from extensions's composer.json

2018-02-28 Thread thiemowmde
thiemowmde triaged this task as "Normal" priority.thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T188354WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Updated] T188354: Remove phpunit/phpunit dependencies from extensions's composer.json

2018-02-28 Thread thiemowmde
thiemowmde added projects: Wikidata, Lexicographical data, MediaWiki-extensions-WikibaseMediaInfo.thiemowmde added subscribers: Lydia_Pintscher, WMDE-leszek, Ladsgroup, daniel. TASK DETAILhttps://phabricator.wikimedia.org/T188354EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T188108: Investigation: Measure load times when the complete lexeme data is loaded to display lexeme in the statement

2018-02-28 Thread thiemowmde
thiemowmde added a comment. Looks good, thanks! Since this was brought up, here are some numbers from the Wikidata Item "Germany" for comparison: 622 statements 684 qualifiers 579 non-empty references, containing 1789 snaks (that's an average of 3 snaks per reference) 3095 value snaks,

[Wikidata-bugs] [Maniphest] [Declined] T114482: [Task] Do a "clean up open pull requests on GitHub" day

2018-02-27 Thread thiemowmde
thiemowmde closed this task as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T114482EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Ricordisamoa, hoo, aude, daniel, JanZerebecki, Jonas, Bene, JeroenDeDauw, To

[Wikidata-bugs] [Maniphest] [Updated] T68651: Make last character optional in globe/geo/lat-long parsers

2018-02-27 Thread thiemowmde
thiemowmde added projects: Need-volunteer, DataValues.thiemowmde moved this task from incoming to ready to go on the Wikidata board. TASK DETAILhttps://phabricator.wikimedia.org/T68651WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Declined] T65932: Entity does not exist message should link to Special:Search

2018-02-27 Thread thiemowmde
thiemowmde closed this task as "Declined".thiemowmde added a comment. To clean our backlogs I'm going to decline my own wish. The search is always visible in the top-right corner. As far as I know nobody ever run into the described issue again, not even myself. Adding an other link to th

[Wikidata-bugs] [Maniphest] [Unblock] T96040: Wikibase special pages (tracking)

2018-02-27 Thread thiemowmde
thiemowmde closed subtask T65932: Entity does not exist message should link to Special:Search as "Declined". TASK DETAILhttps://phabricator.wikimedia.org/T96040EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: PokestarFan,

[Wikidata-bugs] [Maniphest] [Commented On] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-27 Thread thiemowmde
thiemowmde added a comment. @Legoktm wrote: Please don't do this until someone fixes the structure test […] As argued in https://gerrit.wikimedia.org/r/413731 I feel asking people to not do stuff isn't the best approach. The least thing needed would be a PHPCS sniff that enforces all code bases

[Wikidata-bugs] [Maniphest] [Retitled] T178994: [Task] Consistently use interfaces in the WikibaseLexeme code base

2018-02-27 Thread thiemowmde
thiemowmde renamed this task from "[Task] Necessary refactorings to restore consistency in the WikibaseLexeme code base" to "[Task] Consistently use interfaces in the WikibaseLexeme code base".thiemowmde removed thiemowmde as the assignee of this task.thiemowmd

[Wikidata-bugs] [Maniphest] [Triaged] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

2018-02-27 Thread thiemowmde
thiemowmde moved this task from incoming to ready to go on the Wikidata board.thiemowmde triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T188395WORKBOARDhttps://phabricator.wikimedia.org/project/board/71/EMAIL PREFERENCEShttps://phabricator.wik

[Wikidata-bugs] [Maniphest] [Created] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`

2018-02-27 Thread thiemowmde
thiemowmde created this task.thiemowmde added projects: Wikidata, Technical-Debt, Wikibase-DataModel, Easy, Need-volunteer.Herald added a subscriber: Aklapper. TASK DESCRIPTIONIn some Wikibase components, the shortcut composer test is set up to only run PHPUnit and a small subset of tests

[Wikidata-bugs] [Maniphest] [Reopened] T185486: [Bug] wblexemeeditformelements API requires to resubmit unrelated values

2018-02-27 Thread thiemowmde
thiemowmde reopened this task as "Open".thiemowmde added a comment. There is no such thing as a non-public API. All APIs are public. The only thing we can do is mark one as unstable (and we did), but this does not make it private. So to close this ticket I would like to know how we

[Wikidata-bugs] [Maniphest] [Triaged] T156220: Wikidata autocomplete breaks with URL ...?uselang=en-US

2018-02-23 Thread thiemowmde
thiemowmde added projects: Mediawiki-extensions-PropertySuggester, Need-volunteer.thiemowmde triaged this task as "Lowest" priority.thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde added a comment. The reason for this be

[Wikidata-bugs] [Maniphest] [Commented On] T187855: Undefined index in WikibaseClient $this->getRepositoryDefinitions()->getDatabaseNames()['']

2018-02-23 Thread thiemowmde
thiemowmde added a comment. @Tgr, how old is this Vagrant box you are using? I suspect the error might already be fixed via https://gerrit.wikimedia.org/r/410133. Can you please have a look?TASK DETAILhttps://phabricator.wikimedia.org/T187855EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Edited] T188086: [Task] Update Wikibase code bases to use Wikibase CodeSniffer 0.3.0

2018-02-23 Thread thiemowmde
thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONList of code bases that currently use the Wikibase CiCodeSniffer <0.3.0:...[] #Wikidata.org https://gerrit.wikimedia.org/r/413730 [x] WikimediaBadges https://gerrit.wikimedia.org/r/4102643731 [] #DataVal

[Wikidata-bugs] [Maniphest] [Changed Project Column] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-23 Thread thiemowmde
thiemowmde moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.thiemowmde added a project: WorkType-Maintenance. TASK DETAILhttps://phabricator.wikimedia.org/T188011WORKBOARDhttps://phabricator.wikimedia.org/project/board/609/EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Updated] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-23 Thread thiemowmde
thiemowmde added a project: Patch-For-Review.thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...List of components that need an update: * TBD[] #ArticlePlaceholder [] #Cognate [] #MediaWiki-extensions-InterwikiSorting [] Wikibase [x] WikibaseLexeme https

[Wikidata-bugs] [Maniphest] [Commented On] T187775: Investigation: Constraints for a database schema to store representations of a Lexeme

2018-02-23 Thread thiemowmde
thiemowmde added a comment. Estimated table sizes: wbl_lexemes The latest Item ID is currently Q49977198. Thats 9 bytes. 9 * 3 = 27 bytes per row. 27 * 1 million Lexemes = 26 megabytes. wbl_lemmata Lexeme IDs will be similar to Item IDs, so 9 bytes again. Lets say language codes are 5 bytes

[Wikidata-bugs] [Maniphest] [Commented On] T187775: Investigation: Constraints for a database schema to store representations of a Lexeme

2018-02-23 Thread thiemowmde
thiemowmde added a comment. wb_terms is plural. Most MediaWiki core tables are plural. I also like plural names for tables more. But in the end it really does not matter. I used VARBINARY and VARCHAR BINARY as they currently are on other Wikibase tables. From https://dev.mysql.com/doc/refman/5.7

[Wikidata-bugs] [Maniphest] [Updated] T188086: [Task] Update Wikibase code bases to use Wikibase CodeSniffer 0.3.0

2018-02-23 Thread thiemowmde
thiemowmde added a subtask: T167436: [Task] Use Wikibase CodeSniffer standard in all Wikibase code repositories. TASK DETAILhttps://phabricator.wikimedia.org/T188086EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Jonas, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Updated] T167436: [Task] Use Wikibase CodeSniffer standard in all Wikibase code repositories

2018-02-23 Thread thiemowmde
thiemowmde added a parent task: T188086: [Task] Update Wikibase code bases to use Wikibase CodeSniffer 0.3.0. TASK DETAILhttps://phabricator.wikimedia.org/T167436EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: PokestarFan, gerritbot, Ladsgroup

[Wikidata-bugs] [Maniphest] [Triaged] T188086: [Task] Update Wikibase code bases to use Wikibase CodeSniffer 0.3.0

2018-02-23 Thread thiemowmde
thiemowmde moved this task from incoming to ready to go on the Wikidata board.thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Patch-For-Review, User-thiemowmde, Need-volunteer, Easy. TASK DETAILhttps://phabricator.wikimedia.org/T188086WORK

[Wikidata-bugs] [Maniphest] [Created] T188086: [Task] Update Wikibase code bases to use Wikibase CodeSniffer 0.3.0

2018-02-23 Thread thiemowmde
thiemowmde created this task.thiemowmde added projects: Wikidata, DataValues, WorkType-Maintenance.Herald added a subscriber: Aklapper. TASK DESCRIPTIONList of code bases that currently use the Wikibase CideSniffer <0.3.0: #ArticlePlaceholder https://gerrit.wikimedia.org/r/410258 #Cogn

[Wikidata-bugs] [Maniphest] [Closed] T167436: [Task] Use Wikibase CodeSniffer standard in all Wikibase code repositories

2018-02-23 Thread thiemowmde
thiemowmde closed this task as "Resolved".thiemowmde removed a project: User-thiemowmde.thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* [x] WikimediaBadges * [ * [x] #datavalues components:...* [ ] ~~diff~~ * [ ] s* [x] serialization https://githu

[Wikidata-bugs] [Maniphest] [Edited] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-22 Thread thiemowmde
thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...If a code base requires it's own PHPUnit version (this is the case for all PHP components that are not MediaWiki extensions), the suggestion is to go for this dependency in composer.json:dependency

[Wikidata-bugs] [Maniphest] [Triaged] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-22 Thread thiemowmde
thiemowmde moved this task from incoming to ready to go on the Wikidata board.thiemowmde triaged this task as "Low" priority.thiemowmde added projects: Need-volunteer, Easy.thiemowmde added a comment. I already uploaded https://gerrit.wikimedia.org/r/410795 and https://githu

[Wikidata-bugs] [Maniphest] [Updated] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-22 Thread thiemowmde
thiemowmde added a project: User-thiemowmde. TASK DETAILhttps://phabricator.wikimedia.org/T188011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Jonas, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, thiemowmde, Aklapper, Asad_Ali_Palijo, Lahi

[Wikidata-bugs] [Maniphest] [Created] T188011: [Task] Use PHPUnit 6 forward compatibility aliases in all Wikibase code bases

2018-02-22 Thread thiemowmde
thiemowmde created this task.thiemowmde added projects: Wikidata, DataValues, Technical-Debt.Herald added a subscriber: Aklapper. TASK DESCRIPTIONPHPUnit backported namespaced class names from PHPUnit 6 back to the older versions 4 and 5. We can start using these right now. This will make

[Wikidata-bugs] [Maniphest] [Triaged] T187912: Usernames with apostrophes are not well escaped in edit summaries

2018-02-21 Thread thiemowmde
thiemowmde added projects: MediaWiki-extensions-WikibaseRepository, Easy, Regression.thiemowmde moved this task from incoming to ready to go on the Wikidata board.thiemowmde triaged this task as "Normal" priority.thiemowmde added a comment. Seems to be closely related to T187755: Dou

[Wikidata-bugs] [Maniphest] [Triaged] T187888: "Failed to dump Q12129 (Value must be at most 127 characters long.)" when dumping Wikidata as TTL

2018-02-21 Thread thiemowmde
thiemowmde edited projects, added DataValues, Technical-Debt; removed MediaWiki-extensions-WikibaseRepository.thiemowmde moved this task from incoming to needs discussion or investigation on the Wikidata board.thiemowmde triaged this task as "Normal" priority.thiemowmde added

[Wikidata-bugs] [Maniphest] [Commented On] T187775: Investigation: Constraints for a database schema to store representations of a Lexeme

2018-02-21 Thread thiemowmde
thiemowmde added a comment. @WMDE-leszek, something like this would be my draft: CREATE TABLE IF NOT EXISTS wbl_lexemes ( lex_lexeme_id VARBINARY(20) NOT NULL PRIMARY KEY, lex_lexical_category_id VARBINARY(20) NOT NULL, lex_language_item_id VARBINARY(20) NOT NULL ); CREATE TABLE

[Wikidata-bugs] [Maniphest] [Edited] T187775: Investigation: Constraints for a database schema to store representations of a Lexeme

2018-02-21 Thread thiemowmde
thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* Since we know we are exclusively dealing with Item references, but no other entity types, we could store the references as integers. Is this worth it with regards to performance? Or is an indexed

[Wikidata-bugs] [Maniphest] [Commented On] T187775: Investigation: Constraints for a database schema to store representations of a Lexeme

2018-02-20 Thread thiemowmde
thiemowmde added a comment. Personally, I'm totally fine with using any kind of cache, might it be an in-memory one or something else. My worst-case scenario is as follows: Let's say we have 10 million Lexemes, 2 lemmas per Lexeme, 20 bytes per lemma. The cache would need to hold about 0.4

[Wikidata-bugs] [Maniphest] [Edited] T187775: Investigation: Constraints for a database schema to store representations of a Lexeme

2018-02-20 Thread thiemowmde
thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Suggestion is to go with VARCHAR(20) for both columns. Suggestion is to //not// reserve space for repository prefixes. Even on a multi-repository setting the Item references used for lexical categories

[Wikidata-bugs] [Maniphest] [Edited] T187775: Investigation: Constraints for a database schema to store representations of a Lexeme

2018-02-20 Thread thiemowmde
thiemowmde updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* The numbers of rows in the proposed wbl_item_references tables is going to be identical to the total number of Lexemes. There is only one lemma per Lexeme (in only one language),According https

[Wikidata-bugs] [Maniphest] [Commented On] T187775: Investigation: Constraints for a database schema to store representations of a Lexeme

2018-02-20 Thread thiemowmde
thiemowmde added a comment. We should fix https://commons.wikimedia.org/wiki/File:Lexeme_data_model.png then, because it very prominently says there is only "one" lemma. It could be this is meant to be interpreted as "one" value that can somehow contain multiple values. I won

[Wikidata-bugs] [Maniphest] [Updated] T57783: Factor out FormatAutocomments hook code, improve and add tests

2018-02-20 Thread thiemowmde
thiemowmde added a project: Technical-Debt. TASK DETAILhttps://phabricator.wikimedia.org/T57783EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: samuwmde, Ricordisamoa, Aklapper, Wikidata-bugs, thiemowmde, JanZerebecki, aude, Lydia_Pintscher, hoo

[Wikidata-bugs] [Maniphest] [Triaged] T187344: Add language codes for Arabic languages for use in labels, aliases and descriptions to Wikidata

2018-02-20 Thread thiemowmde
thiemowmde added a project: Community-consensus-needed.thiemowmde triaged this task as "Low" priority.thiemowmde added a comment. As for the code, it is currently not possible and not planned to support additional languages for labels and descriptions that are not supported by Medi

<    1   2   3   4   5   6   7   8   9   10   >