[Wikidata-bugs] [Maniphest] T260915: Move DataValues away from “withered” PHPUnit 4

2020-10-29 Thread Daimona
Daimona added a comment. Well done everybody! Should another task be created about the removal of PHPUnit4CompatTrait <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/574a68116410b531c8b3f7952c5e866ec3cfd4c8/repo/tests/phpunit/includes/Parsers/PHPUnit4CompatTrait.

[Wikidata-bugs] [Maniphest] T265091: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms

2020-10-28 Thread Daimona
Daimona added a comment. In T265091#6586803 <https://phabricator.wikimedia.org/T265091#6586803>, @Reedy wrote: > In T265091#6586789 <https://phabricator.wikimedia.org/T265091#6586789>, @Daimona wrote: > >> Dupe of T264926 <https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] T265091: element (".wb-ui-event-emitting-button--edit") still not existing after 3000ms

2020-10-28 Thread Daimona
Daimona added a comment. Dupe of T264926 <https://phabricator.wikimedia.org/T264926>? TASK DETAIL https://phabricator.wikimedia.org/T265091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Reedy, Akuckartz, Dan

[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage

2020-10-27 Thread Daimona
Daimona added a comment. There seem to be more flaky test, not only in WB but also elsewhere (e.g. AbuseFilter and FileImporter at least). I'm convincing myself that it might be a wdio bug, as per comments at T264926 <https://phabricator.wikimedia.org/T264926>. TASK DETAIL

[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage

2020-10-13 Thread Daimona
Daimona triaged this task as "High" priority. Daimona added a comment. I'm seeing this error more and more, e.g. today on r629233 <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/629233>. I'm unsure about the status for other gated extensions, but it's

[Wikidata-bugs] [Maniphest] T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage

2020-10-07 Thread Daimona
Daimona created this task. Daimona added projects: MediaWiki-extensions-WikibaseClient, ci-test-error (WMF-deployed Build Failure). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Recently I've been consistently facing

[Wikidata-bugs] [Maniphest] T105325: [Bug] edit_diff_pst variable is broken on Wikidata

2020-08-31 Thread Daimona
Daimona added a project: TestMe. Daimona added a comment. Based on a couple random edits on wikidata, this seems to be working correctly now. Leaving open for confirmation. If it's still broken, this task can be considered for the upcoming overhaul. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Closed] T254701: Tests failing for the master branch of WikibaseLexeme

2020-06-08 Thread Daimona
Daimona closed this task as "Resolved". Daimona assigned this task to Jakob_WMDE. Daimona added a project: phan. Daimona added a comment. Fixed with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/602735/ Aside, we might conside

[Wikidata-bugs] [Maniphest] [Commented On] T250338: Replace `NewRevisionFromEditComplete` with a new hook

2020-05-27 Thread Daimona
Daimona added a comment. In T250338#6170464 <https://phabricator.wikimedia.org/T250338#6170464>, @DannyS712 wrote: > @Daimona or another phan expert - would you be willing to take a look at the wikibase phan failure? It's coming from an array property, so likely a false

[Wikidata-bugs] [Maniphest] [Commented On] T250720: Wikidata edit filter does not fire when test tool says it should

2020-04-21 Thread Daimona
Daimona added a comment. In T250720#6073559 <https://phabricator.wikimedia.org/T250720#6073559>, @Ahmad252 wrote: > In T250720#6072828 <https://phabricator.wikimedia.org/T250720#6072828>, @Daimona wrote: > >> Haven't checked deeply, but a possible hin

[Wikidata-bugs] [Maniphest] [Closed] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

2020-04-20 Thread Daimona
Daimona closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: matej_suchanek, Daimona, DannyS712, Aklapper, darthmon_wmde, 94rain, Nandana,

[Wikidata-bugs] [Maniphest] [Commented On] T250720: Wikidata edit filter does not fire when test tool says it should

2020-04-20 Thread Daimona
Daimona added a comment. Haven't checked deeply, but a possible hint is that AF doesn't see automatic edit summaries (I think there was a task for that) which, however, it sees when retrospectively examinating edits. TASK DETAIL https://phabricator.wikimedia.org/T250720 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Claimed] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

2020-04-19 Thread Daimona
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: matej_suchanek, Daimona, DannyS712, Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696

[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

2020-04-18 Thread Daimona
Daimona added a comment. In T250570#6068356 <https://phabricator.wikimedia.org/T250570#6068356>, @Daimona wrote: > Or actually, I think it's because checking `getType() == UNDEFINED` (at least in callKeyword and callFunc, perhaps elsewhere) doesn't work well for arrays (i

[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

2020-04-18 Thread Daimona
Daimona added a comment. Or actually, I think it's because checking `getType() == UNDEFINED` (at least in callKeyword and callFunc, perhaps elsewhere) doesn't work well for arrays (it doesn't recurse). Adding AFPData::hasUndefined() as a recursive method would be the solution. TASK

[Wikidata-bugs] [Maniphest] [Commented On] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

2020-04-18 Thread Daimona
Daimona added a comment. I think explicit casts aren't special-cased in the DUNDEFINED check, should be an easy fix TASK DETAIL https://phabricator.wikimedia.org/T250570 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona

[Wikidata-bugs] [Maniphest] [Retitled] T250570: AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else

2020-04-18 Thread Daimona
Daimona renamed this task from "AFPException when saving filter on wikidata" to "AFPException when saving filter on wikidata: Refusing to cast DUNDEFINED to something else". Daimona updated the task description. Daimona edited Stack Trace. TASK DETAIL https://phabricator.w

[Wikidata-bugs] [Maniphest] [Merged] T247782: WikibaseLexeme CI broken due to Title constructor being private

2020-03-17 Thread Daimona
Daimona merged a task: T247806: Make WikibaseLexeme compatible with PHP 7.4. Daimona added subscribers: Jdforrester-WMF, Reedy, Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T247782 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc

[Wikidata-bugs] [Maniphest] [Commented On] T247806: Make WikibaseLexeme compatible with PHP 7.4

2020-03-17 Thread Daimona
Daimona added a comment. Not because of PHP 7.4 :-[ TASK DETAIL https://phabricator.wikimedia.org/T247806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Reedy, Aklapper, Jdforrester-WMF, darthmon_wmde, Nandana, Mringgaard

[Wikidata-bugs] [Maniphest] [Updated] T247806: Make WikibaseLexeme compatible with PHP 7.4

2020-03-17 Thread Daimona
Daimona closed this task as a duplicate of T247782: WikibaseLexeme CI broken due to Title constructor being private. TASK DETAIL https://phabricator.wikimedia.org/T247806 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Reedy, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T247782: WikibaseLexeme CI broken due to Title constructor being private

2020-03-16 Thread Daimona
Daimona added a comment. Meh, I thought these test-only errors would have been spotted by the wmf-gate jobs. Sorry for the breakage :( TASK DETAIL https://phabricator.wikimedia.org/T247782 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona

[Wikidata-bugs] [Maniphest] [Commented On] T247670: PHPUnit warning noise from ClientParserOutputDataUpdaterTest (Wikibase)

2020-03-14 Thread Daimona
Daimona added a comment. It doesn't seem a recent regression, see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+blame/de5e309c258b121bf0626728d8d9a6fd2ab0c717/client/tests/phpunit/includes/ClientParserOutputDataUpdaterTest.php#170 The fix should be as easy

[Wikidata-bugs] [Maniphest] [Commented On] T247595: Make Wikibase compatible with PHP 7.4

2020-03-14 Thread Daimona
Daimona added a comment. Now it should be compatible. Can we enable PHP74 tests as voting? TASK DETAIL https://phabricator.wikimedia.org/T247595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, darthmon_wmde, Nandana

[Wikidata-bugs] [Maniphest] [Updated] T243590: Fix WikibaseDataModel CI for php 7.4

2020-03-13 Thread Daimona
Daimona added a comment. In T243590#5962809 <https://phabricator.wikimedia.org/T243590#5962809>, @Jdforrester-WMF wrote: > Is this the same set of issues that emit errors in the CI run? Apparently, no. Filed T247595 <https://phabricator.wikimedia.org/T247595> for tha

[Wikidata-bugs] [Maniphest] [Created] T247595: Make Wikibase compatible with PHP 7.4

2020-03-13 Thread Daimona
Daimona created this task. Daimona added projects: PHP 7.4 support, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION From T243590#5962809 <https://phabricator.wikimedia.org/T243590#5962809>: 00:18:23.529 There were 3 errors: 00:18:23.529

[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension

2020-02-19 Thread Daimona
Daimona added a comment. That change is not responsible, but the extension is broken: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/47112/artifact/log/mw-error.log TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-19 Thread Daimona
Daimona added a comment. In T237164#5896034 <https://phabricator.wikimedia.org/T237164#5896034>, @Addshore wrote: > It looks like that was removed in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/552166/ but not linked to this ticket. Ah, thanks, I forgot about

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-18 Thread Daimona
Daimona added a comment. For some reason, cache/integration-tests is not being installed, see https://integration.wikimedia.org/ci/job/wikibase-repo-docker/11815/console. This used to work before the test was disabled. Also, the library is currently broken: its public interface is using

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-24 Thread Daimona
Daimona added a comment. In T243296#5829712 <https://phabricator.wikimedia.org/T243296#5829712>, @Addshore wrote: > I'm going to go around and update this in various places that it is used. I can help with review. > Also going forward we will consider if

[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-01-23 Thread Daimona
Daimona added a comment. In T237164#5827203 <https://phabricator.wikimedia.org/T237164#5827203>, @Jdforrester-WMF wrote: > Is this going anywhere, or are we just going to leave it disabled forever? I guess it's going to sit in the bitrot limbo until a new version is

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Daimona
Daimona added a comment. Not if we move the main ruleset file per T243296#5826268 <https://phabricator.wikimedia.org/T243296#5826268>. And, of course, unless it turns out to be impossible to have two different rulesets in MW-CS. TASK DETAIL https://phabricator.wikimedia.org/T243296

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Daimona
Daimona added a comment. In T243296#5826260 <https://phabricator.wikimedia.org/T243296#5826260>, @Lucas_Werkmeister_WMDE wrote: > (Unless “Move the WB ruleset to MW-CS” includes disabling those rules for all of MW-CS?) Sort of, yes. I believe it's possible to have two

[Wikidata-bugs] [Maniphest] [Commented On] T243296: Release a new version of WikibaseCodeSniffer

2020-01-23 Thread Daimona
Daimona added a comment. In T243296#5821602 <https://phabricator.wikimedia.org/T243296#5821602>, @Legoktm wrote: > I think we could ship it inside the MediaWiki-Codesniffer repo so it doesn't fall behind at least. I think this is a great idea to get started with. I guess

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T243296: Release a new version of WikibaseCodeSniffer

2020-01-21 Thread Daimona
Daimona added subscribers: Ladsgroup, Daimona. Daimona added a comment. CC @Ladsgroup as releaser of the last two versions and (AFAICS) most active maintainer. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Raised Priority] T243122: Math master is currently broken due to a Wikibase change

2020-01-18 Thread Daimona
Daimona raised the priority of this task from "Medium" to "Unbreak Now!". Daimona added a comment. In T243122#5814763 <https://phabricator.wikimedia.org/T243122#5814763>, @Physikerwelt wrote: > I think this is not ubn. Why not disable the test? B

[Wikidata-bugs] [Maniphest] [Updated] T243124: Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.

2020-01-18 Thread Daimona
Daimona added a project: MediaWiki-extensions-PropertySuggester. TASK DETAIL https://phabricator.wikimedia.org/T243124 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Reedy, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] [Updated] T243122: Math master is currently broken due to a Wikibase change

2020-01-18 Thread Daimona
Daimona added a parent task: T233864: 1.35.0-wmf.16 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T243122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Created] T243122: Math master is currently broken due to a Wikibase change

2020-01-18 Thread Daimona
Daimona created this task. Daimona added projects: Math, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As observed in r565622 <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/565622/>, tests currently fail on Math because of: >

[Wikidata-bugs] [Maniphest] [Updated] T240884: Standalone service to evaluate user-provided regular expressions

2020-01-17 Thread Daimona
Daimona added a comment. In T240884#5810160 <https://phabricator.wikimedia.org/T240884#5810160>, @sbassett wrote: > In T240884#5810094 <https://phabricator.wikimedia.org/T240884#5810094>, @Ladsgroup wrote: > >> One complicating factor here is that AbuseFilte

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

2020-01-14 Thread Daimona
Daimona added a comment. In T241947#5802594 <https://phabricator.wikimedia.org/T241947#5802594>, @Addshore wrote: > Well, RequestContext::getMain is slightly less evil that the global probably. Yeah, well, a little bit... I believe the only difference is that, w

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

2020-01-14 Thread Daimona
Daimona added a comment. In T241947#5802562 <https://phabricator.wikimedia.org/T241947#5802562>, @Addshore wrote: > In T241947#5776623 <https://phabricator.wikimedia.org/T241947#5776623>, @Daimona wrote: > >> Note: there are two usages in the entry point whi

[Wikidata-bugs] [Maniphest] [Commented On] T241947: Stop using $wgUser in Wikibase

2020-01-05 Thread Daimona
Daimona added a comment. Note: there are two usages in the entry point which I'm unsure how to fix. TASK DETAIL https://phabricator.wikimedia.org/T241947 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Hook696

[Wikidata-bugs] [Maniphest] [Created] T241947: Stop using $wgUser in Wikibase

2020-01-05 Thread Daimona
Daimona created this task. Daimona added projects: Technical-Debt (Deprecation process), MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Updated] T239265: Special:Diff: Bad value for parameter $title: invalid name 'Diff/1_'

2019-11-26 Thread Daimona
Daimona edited projects, added MediaWiki-Special-pages; removed Wikidata, MediaWiki-extensions-Diff. TASK DETAIL https://phabricator.wikimedia.org/T239265 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, Amorymeltzer

[Wikidata-bugs] [Maniphest] [Created] T239265: Special:Diff: Bad value for parameter $title: invalid name 'Diff/1_'

2019-11-26 Thread Daimona
Daimona created this task. Daimona added projects: Wikimedia-production-error, MediaWiki-extensions-Diff. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.5

[Wikidata-bugs] [Maniphest] [Closed] T235326: Wikibase PHPUnit tests are broken

2019-10-15 Thread Daimona
Daimona closed this task as "Resolved". Daimona removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T235326: Wikibase PHPUnit tests are broken

2019-10-12 Thread Daimona
Daimona added a comment. In T235326#5569865 <https://phabricator.wikimedia.org/T235326#5569865>, @Daimona wrote: > In T235326#5569844 <https://phabricator.wikimedia.org/T235326#5569844>, @Ladsgroup wrote: > >> 1.0.0 supposed to be released now. I don't know i

[Wikidata-bugs] [Maniphest] [Claimed] T235326: Wikibase PHPUnit tests are broken

2019-10-12 Thread Daimona
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Ladsgroup, Lucas_Werkmeister_WMDE, thiemowmde, Aklapper, Daimona, Hook696, Daryl-TTMG, RomaAmorRoma

[Wikidata-bugs] [Maniphest] [Commented On] T235326: Wikibase PHPUnit tests are broken

2019-10-12 Thread Daimona
Daimona added a comment. In T235326#5569844 <https://phabricator.wikimedia.org/T235326#5569844>, @Ladsgroup wrote: > 1.0.0 supposed to be released now. I don't know if packagist picked it up or not. Let's hope so. I'm starting with Wikibase-related repos, and doing Wikibas

[Wikidata-bugs] [Maniphest] [Commented On] T235326: Wikibase PHPUnit tests are broken

2019-10-12 Thread Daimona
Daimona added a comment. In T235326#5569744 <https://phabricator.wikimedia.org/T235326#5569744>, @Ladsgroup wrote: > Can you make a pull request? It looks like a breaking change, a major version bump is needed https://github.com/wmde/WikibaseCodeSniffer/pull/55 is for rele

[Wikidata-bugs] [Maniphest] [Commented On] T235326: Wikibase PHPUnit tests are broken

2019-10-12 Thread Daimona
Daimona added a comment. In T235326#5569733 <https://phabricator.wikimedia.org/T235326#5569733>, @Ladsgroup wrote: > In T235326#5569704 <https://phabricator.wikimedia.org/T235326#5569704>, @Daimona wrote: > >> https://github.com/wmde/WikibaseCodeSniffer/pul

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T235326: Wikibase PHPUnit tests are broken

2019-10-12 Thread Daimona
Daimona added subscribers: thiemowmde, Lucas_Werkmeister_WMDE, Ladsgroup. Daimona added a comment. https://github.com/wmde/WikibaseCodeSniffer/pull/54 TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Created] T235326: Wikibase PHPUnit tests are broken

2019-10-12 Thread Daimona
Daimona created this task. Daimona added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Seen e.g. in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/24311/console: > PHP Fatal error: Declaration of Wikibase\Cli

[Wikidata-bugs] [Maniphest] [Triaged] T235326: Wikibase PHPUnit tests are broken

2019-10-12 Thread Daimona
Daimona triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T235326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Daimona, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSM

[Wikidata-bugs] [Maniphest] [Closed] T235007: ReflectionException: Property languageNameCache does not exist

2019-10-09 Thread Daimona
Daimona closed this task as "Resolved". Daimona assigned this task to Ladsgroup. Daimona added a comment. Restricted Application added a project: User-Ladsgroup. Fixed with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/541815/ TASK DETA

[Wikidata-bugs] [Maniphest] [Commented On] T235007: ReflectionException: Property languageNameCache does not exist

2019-10-09 Thread Daimona
Daimona added a comment. What about just calling Language::clearCaches(), instead of making a private property accessible? TASK DETAIL https://phabricator.wikimedia.org/T235007 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc

[Wikidata-bugs] [Maniphest] [Raised Priority] T235007: ReflectionException: Property languageNameCache does not exist

2019-10-09 Thread Daimona
Daimona raised the priority of this task from "High" to "Unbreak Now!". Daimona added a comment. Restricted Application added a subscriber: Liuxinyu970226. It's blocking merges to various extensions. For instance, ArticlePlaceholder <https://gerrit.wikimedia.org/r/#

[Wikidata-bugs] [Maniphest] [Closed] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona
Daimona closed this task as "Resolved". Daimona removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Jdforrester-WMF, Daimona, mmodell,

[Wikidata-bugs] [Maniphest] [Claimed] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Denny

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona
Daimona added a comment. In T233763#5551443 <https://phabricator.wikimedia.org/T233763#5551443>, @Daimona wrote: > AFAICS, mTitle is not defined as property, and this happens as of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/ Uh,

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona
Daimona added a comment. AFAICS, mTitle is not defined as property, and this happens as of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/ IMHO, it's pretty sad that: - This wasn't spotted when updating the class; - Nothing triggered (PHPUnit) tests

[Wikidata-bugs] [Maniphest] [Commented On] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-10-07 Thread Daimona
Daimona added a comment. Curiously, PHPUnit is failing on the WikibaseLexemeCirrusSearch repo with "Call to a member function setFragment() on null". I don't know if it's exactly the same error, but oh well... TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL P

[Wikidata-bugs] [Maniphest] [Created] T234752: Many QUnit warnings: WARN: 'jQuery.Deferred exception: Cannot read property 'id' of undefined'

2019-10-06 Thread Daimona
Daimona created this task. Daimona added projects: Browser-Tests, Lexicographical data. Restricted Application added a project: Wikidata. TASK DESCRIPTION Seen e.g. in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/22927/consoleFull#console-section-5. The QUnit

[Wikidata-bugs] [Maniphest] [Updated] T233981: Call to a member function setFragment() on null

2019-09-28 Thread Daimona
Daimona closed this task as a duplicate of T233763: Error searching Lexeme:Danke on Wikidata: Call to a member function setFragment() on null. TASK DETAIL https://phabricator.wikimedia.org/T233981 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Merged] T233763: Error searching Lexeme:Danke on Wikidata: "Call to a member function setFragment() on null"

2019-09-28 Thread Daimona
Daimona merged a task: T233981: Call to a member function setFragment() on null. Daimona added a subscriber: mmodell. TASK DETAIL https://phabricator.wikimedia.org/T233763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: mmodell, Smalyshev

[Wikidata-bugs] [Maniphest] [Updated] T232862: Lexeme search on Wikidata result in fatal exceptions

2019-09-14 Thread Daimona
Daimona added a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T232862 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Aklapper, Fnielsen, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T232862: Lexeme search on Wikidata result in fatal exceptions

2019-09-13 Thread Daimona
Daimona added a comment. name=message [XXvNjwpAMFAAABEsrycAAADE] /w/index.php?search==L%3Ani=Special%3ASearch=G%C3%A5+til Error from line 57 of /srv/mediawiki/php-1.34.0-wmf.22/extensions/WikibaseLexemeCirrusSearch/src/LexemeResult.php: Call to a member function setFragment() on null

[Wikidata-bugs] [Maniphest] [Commented On] T65632: AbuseFilter *_links variables incorrect on item edits.

2019-08-23 Thread Daimona
Daimona added a comment. I'm sorry, I'm pretty ignorant about wikidata. How exactly am I supposed to reproduce the problem? I tried here <https://wikidata.beta.wmflabs.org/wiki/Q416076>, but I'm unsure if that's right. If it is, then indeed we don't get _links variables. TASK

[Wikidata-bugs] [Maniphest] [Closed] T47537: [Bug] AbuseFilter warnings not triggered when creating an item

2019-08-23 Thread Daimona
Daimona closed this task as "Resolved". Daimona claimed this task. Daimona added a comment. This is now working as intended, see for instance https://wikidata.beta.wmflabs.org/wiki/Special:AbuseLog/411; I also got the warning: F30076822: wikidata-filter-warning.p

[Wikidata-bugs] [Maniphest] [Unblock] T76230: [Epic] data quality and trust

2019-08-23 Thread Daimona
Daimona closed subtask T47537: [Bug] AbuseFilter warnings not triggered when creating an item as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T76230 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: 99of9, Cirdan, Hjfocs

[Wikidata-bugs] [Maniphest] [Closed] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-07-31 Thread Daimona
Daimona closed this task as "Resolved". Daimona added a comment. After my patch, we have: $cfg['suppress_issue_types'][] = 'PhanParamSignatureMismatch'; // False positives with methods taking nullables $cfg['suppress_issue_types'][] = 'PhanParamReqAfterOpt'; // @t

[Wikidata-bugs] [Maniphest] [Closed] T227270: Phan cannot find classes after namespace move

2019-07-31 Thread Daimona
Daimona closed this task as "Resolved". Daimona added a comment. WBLexeme is now importing the base config which supports class_alias. TASK DETAIL https://phabricator.wikimedia.org/T227270 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ T

[Wikidata-bugs] [Maniphest] [Closed] T224775: Use mediawiki/mediawiki-phan-config in extension WikibaseLexeme

2019-07-31 Thread Daimona
Daimona closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T224775 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Umherirrender, darthmon_wmde, DannyS712, Nandana, Mringgaard,

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

2019-07-22 Thread Daimona
Daimona added a comment. So I see AF is mentioned here... I'm glad to help. To give you some context, we do access the text table directly in AbuseFilter::storeVarDump and AbuseFilter::loadVarDump, but that's not for getting revision text, as we save our custom data in the text table. It's

[Wikidata-bugs] [Maniphest] [Updated] T218149: Abuse filter support for depicts and statements

2019-07-16 Thread Daimona
Daimona added a project: AbuseFilter. Daimona added a comment. Tagging, and CC'ing myself in case any help is needed with AF. TASK DETAIL https://phabricator.wikimedia.org/T218149 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Keegan, Daimona Cc

[Wikidata-bugs] [Maniphest] [Claimed] T224775: Use mediawiki/mediawiki-phan-config in extension WikibaseLexeme

2019-07-14 Thread Daimona
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T224775 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, Umherirrender, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Claimed] T227270: Phan cannot find classes after namespace move

2019-07-05 Thread Daimona
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T227270 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Daimona, Ladsgroup, Lucas_Werkmeister_WMDE, Aklapper, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Claimed] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-07-04 Thread Daimona
Daimona claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T226254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Aklapper, alaa_wmde, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john

[Wikidata-bugs] [Maniphest] [Commented On] T227270: Phan cannot find classes after namespace move

2019-07-04 Thread Daimona
Daimona added a comment. Mediawiki-phan 0.6.1 added phan support for class_alias, but wikibase isn't included because for some reason it has its own phan config file, instead of requiring the base one. And for that I sent https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase

[Wikidata-bugs] [Maniphest] [Commented On] T226977: Wikibase Travis CI failing, Failed asserting that file "LocalSettings.php" exists.

2019-07-01 Thread Daimona
Daimona added a comment. In T226977#5297201 <https://phabricator.wikimedia.org/T226977#5297201>, @Lucas_Werkmeister_WMDE wrote: > @Daimona are the coverage builds now fixed as well? (I tried to look at recent jobs in the same Jenkins project but couldn’t make m

[Wikidata-bugs] [Maniphest] [Commented On] T226977: Wikibase Travis CI failing, Failed asserting that file "LocalSettings.php" exists.

2019-07-01 Thread Daimona
Daimona added a comment. Note that this also makes the coverage job fail, see for instance one <https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/14676/console>, two <https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch-docker/1467

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment. In T226244#5273866 <https://phabricator.wikimedia.org/T226244#5273866>, @alaa_wmde wrote: > @Daimona understood. I also think the clean-up work is necessary. I'm not such a fan of statements of the sort "extensions must use mediawiki confi

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment. In T226244#5273853 <https://phabricator.wikimedia.org/T226244#5273853>, @alaa_wmde wrote: > In T226244#5273849 <https://phabricator.wikimedia.org/T226244#5273849>, @gerritbot wrote: > > > Change 518256 had a related patch set upl

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment. @noarave It actually did. It's just that phan completed its analysis and found several errors. Of note, you should also add a phan config file - I can amend your patch, although I don't know if I'll have time to fix all the errors. @hashar Actually, it's not Lexeme

[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment. AIUI, only the last mentioned patch is culprit. The dependency on Wikibase should only be used to tell what MW extensions to install before testing Lexeme, but that shouldn't be related to the phan version to use. What happened, instead, is that IMHO phan72 jobs

[Wikidata-bugs] [Maniphest] [Commented On] T221380: Wikidata: Special:Contributions times out for many high-activity users

2019-04-21 Thread Daimona
Daimona added a comment. name=message [XLxsMQpAADsAAImQla8AAACB] /w/index.php?title=Special:Contributions=20190418104744=1=KrBot WMFTimeoutException from line 39 of /srv/mediawiki/wmf-config/set-time-limit.php: the execution time limit of 60 seconds was exceeded name=trace

[Wikidata-bugs] [Maniphest] [Closed] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content

2019-03-30 Thread Daimona
Daimona closed this task as "Resolved". Daimona claimed this task. Daimona added a comment. Calling resolved, given that the EditFilterMergedContent hook is guaranteed to provide a valid Content object (that is then passed to contentToString). TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org

2019-03-18 Thread Daimona
Daimona added a comment. Just a random comment: data actually used by existing abuse filters like the rank can be moved from added_lines to new AF variables defined via hooks. TASK DETAIL https://phabricator.wikimedia.org/T205254 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T215380: Content too big! Entity: Q27972199

2019-02-06 Thread Daimona
Daimona added a comment. (For the record, it happens every time the entity is edited, which is roughly 900 times in the last 12 hours.)TASK DETAILhttps://phabricator.wikimedia.org/T215380EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona

[Wikidata-bugs] [Maniphest] [Commented On] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org

2019-02-05 Thread Daimona
Daimona added a comment. Description updated! Searching for all of the variables yields 76 matches. Checking by hand is feasible, but not optimal. Is there a list of what data we're looking for (e.g. GUIDs and rank, mentioned in task desc)? I'd like to see if I can extract a regex from there.TASK

[Wikidata-bugs] [Maniphest] [Edited] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org

2019-02-05 Thread Daimona
Daimona updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - edit_diff, edit_diff_pst...TASK DETAILhttps://phabricator.wikimedia.org/T205254EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Lea_Lacroix_WMDE

[Wikidata-bugs] [Maniphest] [Edited] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org

2019-02-05 Thread Daimona
Daimona updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION... - Use of- AbuseFilter text / lines-related variables (from https://www.mediawiki.org/wiki/Extension:AbuseFilter/Rules_format): - *- old_wikitext, new_wikitextt - edit_diff, edit_diff_pst - *_text- added_lines

[Wikidata-bugs] [Maniphest] [Commented On] T106136: Wikidata edits are not tagged by AbuseFilter on item creations

2019-01-11 Thread Daimona
Daimona added a comment. The system used for applying tags is not ideal (relies on global state etc.), but I'm unsure what an alternative could be, since tags cannot be applied when filters are executed (per design in core). To keep the process simple, we use an identifier which can be constructed

[Wikidata-bugs] [Maniphest] [Updated] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content

2019-01-09 Thread Daimona
Daimona added a comment. Hm, unseen in the last 30 days. Maybe this was fixed in rEABF688eccea477a3a537c86066112bda7da202a8463?TASK DETAILhttps://phabricator.wikimedia.org/T73545EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, Krinkle

[Wikidata-bugs] [Maniphest] [Updated] T210929: Timeout exceeded for WikibaseReferenceOnProtectedPage Selenium test

2018-12-01 Thread Daimona
Daimona edited projects, added Wikimedia-production-error (Shared Build Failure); removed Wikimedia-production-error. TASK DETAILhttps://phabricator.wikimedia.org/T210929EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Aklapper

[Wikidata-bugs] [Maniphest] [Created] T210929: Timeout exceeded for WikibaseReferenceOnProtectedPage Selenium test

2018-12-01 Thread Daimona
Daimona created this task.Daimona added projects: Wikidata, MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error.Restricted Application added a subscriber: Aklapper. TASK DESCRIPTIONThe test called "WikibaseReferenceOnProtectedPage can expand collapsed references on a protected

[Wikidata-bugs] [Maniphest] [Updated] T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org

2018-11-16 Thread Daimona
Daimona added a comment. Just a comment: "_text" variables are for page title, and so are "_prefixedtext" variables. So, if you're interested in covering such variables, then you also have to include "_title" and "_prefixedtitle" per T173889.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content

2018-10-18 Thread Daimona
Daimona added a comment. Hm, looking at this, it seems like $revision::getContent() is returning null although $revision is not null. However, looking at RevisionRecord and similar classes, I couldn't find a case when this can happen, given that we use RAW as audience (so deleted content shouldn't

[Wikidata-bugs] [Maniphest] [Updated] T73545: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content

2018-10-15 Thread Daimona
Daimona added a project: User-Daimona. TASK DETAILhttps://phabricator.wikimedia.org/T73545EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Krinkle, Zoglun, Wikidata-bugs, aude, wikibugs-l-list, werdna, Lydia_Pintscher, hoo, dmaza, Daimona, Litanwei

[Wikidata-bugs] [Maniphest] [Updated] T201310: Prefill the representation when adding the first Form

2018-08-20 Thread Daimona
Daimona removed a project: Patch-For-Review.Daimona added a comment. Wrong taskTASK DETAILhttps://phabricator.wikimedia.org/T201310EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DaimonaCc: Daimona, gerritbot, Micru, KaMan, Lydia_Pintscher, Lea_Lacroix_WMDE

  1   2   >