[Wikidata-bugs] [Maniphest] T271933: PHP Fatal Error: Cannot redeclare Wikibase\MediaInfo\Search\closureToAnonymousClass() (previously declared in /srv/mediawiki/php-1.36.0-wmf.26/extensions/WikibaseM

2021-01-13 Thread Krinkle
Krinkle added a comment. In T271933#6744789 <https://phabricator.wikimedia.org/T271933#6744789>, @Cparle wrote: > patch merged to the branch that we think will fix it For future reference, patches must not be merged in wmf unless they are currently being deployed by t

[Wikidata-bugs] [Maniphest] T248840: Don’t polyfill Promise in Bridge modules

2020-12-18 Thread Krinkle
Krinkle edited projects, added Performance-Team (Radar); removed User-Pablo-WMDE. TASK DETAIL https://phabricator.wikimedia.org/T248840 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Pablo-WMDE, WMDE-leszek, Michael

[Wikidata-bugs] [Maniphest] T269960: Schema properties in client code loads the whole item in every page view

2020-12-11 Thread Krinkle
Krinkle added a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T269960 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: darthmon_wmde, Lydia_Pintscher, WMDE-leszek, Lucas_Werkmeister_WMDE, Addshore

[Wikidata-bugs] [Maniphest] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-12-09 Thread Krinkle
Krinkle added a comment. I still find myself very confused by this task and imagine that others might be struggling as well. I'll try to pick up the thread from before and continue to ask clarifying questions. - The authoritive source for describing items is Wikidata.org

[Wikidata-bugs] [Maniphest] T269315: Fatal error: Cannot pass parameter 1 by reference (Wikibase\DataModel\Entity)

2020-12-02 Thread Krinkle
Krinkle renamed this task from "Fatal error: Cannot pass parameter 1 by reference" to "Fatal error: Cannot pass parameter 1 by reference (Wikibase\DataModel\Entity)". TASK DETAIL https://phabricator.wikimedia.org/T269315 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] T269315: Fatal error: Cannot pass parameter 1 by reference

2020-12-02 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T269315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Reedy, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T269315: Fatal error: Cannot pass parameter 1 by reference

2020-12-02 Thread Krinkle
Krinkle renamed this task from "Cannot pass parameter 1 by reference" to "Fatal error: Cannot pass parameter 1 by reference". Krinkle triaged this task as "Unbreak Now!" priority. Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL htt

[Wikidata-bugs] [Maniphest] T204792: Language objects for categories sometimes missing url field (Special:MobileLanguages emits warning "url key is undefined in language object")

2020-11-16 Thread Krinkle
Krinkle removed projects: ULS-CompactLinks, UniversalLanguageSelector. Krinkle added a comment. No, it has no relation to frontend or other ULS code. TASK DETAIL https://phabricator.wikimedia.org/T204792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

2020-11-06 Thread Krinkle
Krinkle added a parent task: T124367: User::loadFromSession called before the end of Setup.php. TASK DETAIL https://phabricator.wikimedia.org/T240083 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Anomie, Krinkle Cc: daniel, Ladsgroup, Addshore

[Wikidata-bugs] [Maniphest] T262009: Add an entry in the WDQS Runbook on killer queries

2020-10-23 Thread Krinkle
Krinkle added a project: Sustainability (Incident Followup). TASK DETAIL https://phabricator.wikimedia.org/T262009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, RKemper, Gehel, CBogen, Akuckartz, Nandana, Namenlos314, jijiki

[Wikidata-bugs] [Maniphest] T264893: Client: Error: invalid entity serialization

2020-10-23 Thread Krinkle
Krinkle updated the task description. Krinkle edited Stack Trace. Restricted Application added a subscriber: Masumrezarock100. TASK DETAIL https://phabricator.wikimedia.org/T264893 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] T264915: Widget not found (from unsafeInfuse, on Special:AboutTopic)

2020-10-23 Thread Krinkle
Krinkle moved this task from Untriaged to Oct2020/1.36.0-wmf.11+ on the Wikimedia-production-error board. Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T264915 WORKBOARD https://phabricator.wikimedia.org/project/board/1055/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T264915: Widget not found (from unsafeInfuse, on Special:AboutTopic)

2020-10-23 Thread Krinkle
Krinkle renamed this task from "Widget not found in unsafeInfuse in AboutTopic" to "Widget not found (from unsafeInfuse, on Special:AboutTopic)". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T264915 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] T264928: MediaWiki::restInPeace: transaction round 'Cognate\CacheUpdateJob::run' still running

2020-10-23 Thread Krinkle
Krinkle added a subscriber: Addshore. Krinkle added a comment. @Micheal @Addshore Ping for triage :) this may've been missed given its age. TASK DETAIL https://phabricator.wikimedia.org/T264928 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T264928: MediaWiki::restInPeace: transaction round 'Cognate\CacheUpdateJob::run' still running

2020-10-23 Thread Krinkle
Krinkle moved this task from Untriaged to Oct2020/1.36.0-wmf.11+ on the Wikimedia-production-error board. Krinkle added a comment. I can't be sure, but it seems likely that this is causing the job to fatal and/or some part of the job updates to not have actually been committed to the DB

[Wikidata-bugs] [Maniphest] T265992: Argument 1 passed to ViolationMessageSerializer::serializeEntityId() must be an instance of EntityId, string given

2020-10-23 Thread Krinkle
Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedia.org/T265992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, Aklapper, Akuckartz, darthmon_wmde, Nandana

[Wikidata-bugs] [Maniphest] T264243: Argument 2 passed to Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup::__construct() must be an instance of Wikibase\Repo\Store\EntityTitleStoreLookup, in

2020-10-01 Thread Krinkle
Krinkle added a comment. How often, for how long, and on how many different servers did we see this error? TASK DETAIL https://phabricator.wikimedia.org/T264243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, WMDE-leszek

[Wikidata-bugs] [Maniphest] T260789: Error: Call to a member function addModules() on null (from ScoreFormatter.php)

2020-09-22 Thread Krinkle
Krinkle reassigned this task from Krinkle to Lucas_Werkmeister_WMDE. TASK DETAIL https://phabricator.wikimedia.org/T260789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Krinkle Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T260789: Error: Call to a member function addModules() on null (from ScoreFormatter.php)

2020-09-22 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle claimed this task. Krinkle added a comment. Logstash query `exception.trace:"Score" AND exception.message:"Call to a member"` confirms no reports after August 22. TASK DETAIL https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] T260789: Error: Call to a member function addModules() on null (from ScoreFormatter.php)

2020-09-22 Thread Krinkle
Krinkle renamed this task from "Call to a member function addModules() on null" to "Error: Call to a member function addModules() on null (from ScoreFormatter.php)". Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] T252091: RFC: Site-wide edit rate limiting with PoolCounter

2020-09-17 Thread Krinkle
Krinkle moved this task from P1: Define to P2: Resource on the TechCom-RFC board. Krinkle added a comment. @Ladsgroup @Addshore This RFC lists WMDE as delivering implemention work but steward is still TBD. Can you confirm who the steward(s) are for the areas this RFC would need to affect

[Wikidata-bugs] [Maniphest] T255054: PHP Warning: No RDF builder defined for data type wikibase-form nor for value type bad.

2020-09-03 Thread Krinkle
Krinkle added a comment. The last ocurrance of `message:"No RDF builder defined for data type"` in Logstash seems to have been on 2020-08-09 with `php-1.36.0-wmf.3`. TASK DETAIL https://phabricator.wikimedia.org/T255054 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults

2020-09-03 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle added a comment. Confirmed gone from Logstash after Aug 26. TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson, Krinkle C

[Wikidata-bugs] [Maniphest] T258628: Fatal error: Call to getFullURL() on null (in Wikibase repo EntityDataRequestHandler.php)

2020-09-03 Thread Krinkle
Krinkle renamed this task from "Call to a member function getFullURL() on null" to "Fatal error: Call to getFullURL() on null (in Wikibase repo EntityDataRequestHandler.php)". Krinkle updated the task description. Krinkle edited Stack Trace. TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] T68051: Implement Lua alternative to {{int:Lang}} / wgUserLanguage

2020-08-26 Thread Krinkle
Krinkle closed subtask T4085: Add a {{USERLANGUAGE}} magic word as Declined. TASK DETAIL https://phabricator.wikimedia.org/T68051 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: matej_suchanek, Want, Perhelion, IKhitron, Iniquity

[Wikidata-bugs] [Maniphest] T260402: Confirm or consider starting some amount of regular QA on upload process

2020-08-13 Thread Krinkle
Krinkle created this task. Krinkle added projects: Sustainability (Incident Followup), Quality-and-Test-Engineering-Team (QTE), MediaViewer, SDC General, Structured Data Engineering. Restricted Application added a subscriber: Aklapper. Restricted Application added projects: Wikidata, Structured

[Wikidata-bugs] [Maniphest] T255305: [Investigation] - Consider if the Wikibase cache for CachingEntityRevisionLookup is needed any more

2020-08-11 Thread Krinkle
Krinkle added a project: Performance-Team (Radar). TASK DETAIL https://phabricator.wikimedia.org/T255305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, Michael, Addshore, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz

[Wikidata-bugs] [Maniphest] T238199: SpecialFewestRevisions::reallyDoQuery takes more than 9h to run

2020-08-10 Thread Krinkle
Krinkle removed a project: Wikimedia-Incident. TASK DETAIL https://phabricator.wikimedia.org/T238199 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: SilentSpike, WMDE-leszek, ArielGlenn, Lea_Lacroix_WMDE, jcrespo, Addshore

[Wikidata-bugs] [Maniphest] T191690: Linking from namespace to Wikibooks via Wikidata in interwiki section

2020-07-30 Thread Krinkle
Krinkle edited projects, added Wikidata, MediaWiki-extensions-WikibaseClient; removed MediaWiki-Interwiki. TASK DETAIL https://phabricator.wikimedia.org/T191690 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Theklan, Akuckartz

[Wikidata-bugs] [Maniphest] T217192: Allow gadgets to be connected via Wikidata interwiki

2020-07-30 Thread Krinkle
Krinkle added a project: MediaWiki-extensions-Gadgets. TASK DETAIL https://phabricator.wikimedia.org/T217192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Dvorapa, Akuckartz, darthmon_wmde, DannyS712, Nandana, Jony, lucamauri

[Wikidata-bugs] [Maniphest] T217192: Allow gadgets to be connected via Wikidata interwiki

2020-07-30 Thread Krinkle
Krinkle edited projects, added MediaWiki-extensions-WikibaseRepository; removed MediaWiki-Interwiki, MediaWiki-Interface, MediaWiki-extensions-Gadgets. TASK DETAIL https://phabricator.wikimedia.org/T217192 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T229593: Correct Wikidata IDs not available from Javascript of Commons categories

2020-07-30 Thread Krinkle
Krinkle added a comment. Untagging from the core components for the interwiki and category systems as the task does not appear to be about a bug or request for those. TASK DETAIL https://phabricator.wikimedia.org/T229593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T229593: Correct Wikidata IDs not available from Javascript of Commons categories

2020-07-30 Thread Krinkle
Krinkle removed a project: MediaWiki-Interwiki. TASK DETAIL https://phabricator.wikimedia.org/T229593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Cparle, Lydia_Pintscher, PDrouin-WMF, Aklapper, kaldari, EgbeRef, CBogen, Vaibhav0199

[Wikidata-bugs] [Maniphest] T229593: Correct Wikidata IDs not available from Javascript of Commons categories

2020-07-30 Thread Krinkle
Krinkle removed a project: MediaWiki-Categories. TASK DETAIL https://phabricator.wikimedia.org/T229593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Cparle, Lydia_Pintscher, PDrouin-WMF, Aklapper, kaldari, EgbeRef, CBogen, Vaibhav0199

[Wikidata-bugs] [Maniphest] T248866: Consider having a linter that could catch config file entries that set unused variables

2020-07-25 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T248866 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Legoktm, Krinkle, Jdforrester-WMF, ArielGlenn, Aklapper, mmodell, Akuckartz, Totolinototo3

[Wikidata-bugs] [Maniphest] T248866: Consider having a linter that could catch config file entries that set unused variables

2020-07-25 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T248866 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Legoktm, Krinkle, Jdforrester-WMF, ArielGlenn, Aklapper, mmodell, Akuckartz, Totolinototo3

[Wikidata-bugs] [Maniphest] T258184: Call to undefined method Wikibase\Client\Hooks\OtherProjectsSidebarGenerator::buildProjectLinkSidebarFromItemId()

2020-07-22 Thread Krinkle
Krinkle removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T258184 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Krinkle Cc: Michael, Lydia_Pintscher, Ladsgroup, Tpt, Addshore, Aklapper

[Wikidata-bugs] [Maniphest] T255706: Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock

2020-07-22 Thread Krinkle
Krinkle added a comment. Still seen in current production. TASK DETAIL https://phabricator.wikimedia.org/T255706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, eprodromou, aaron, Michael, Addshore, Aklapper, thcipriani

[Wikidata-bugs] [Maniphest] T255706: Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock

2020-07-22 Thread Krinkle
Krinkle edited projects, added Wikidata-Campsite; removed Platform Team Workboards (Clinic Duty Team). Krinkle added a comment. This is related to Rdbms in the same way that it relates to PHP and MediaWiki. It uses it, but it's not where the problem is. TASK DETAIL https

[Wikidata-bugs] [Maniphest] T258543: SDC: SimpleCacheWithBagOStuff throwing CacheInvalidArgumentException due to invalid cache key on Commons

2020-07-21 Thread Krinkle
Krinkle renamed this task from "SDC throwing exception due to invalid cache key" to "SDC: SimpleCacheWithBagOStuff throwing CacheInvalidArgumentException due to invalid cache key on Commons". TASK DETAIL https://phabricator.wikimedia.org/T258543 EMAIL

[Wikidata-bugs] [Maniphest] T258543: SDC: SimpleCacheWithBagOStuff throwing CacheInvalidArgumentException due to invalid cache key on Commons

2020-07-21 Thread Krinkle
Krinkle triaged this task as "High" priority. Krinkle moved this task from Untriaged to Jul 2020 / 1.35-wmf.39+ on the Wikimedia-production-error board. Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T258543 WORKBOA

[Wikidata-bugs] [Maniphest] [Closed] T242958: InvalidArgumentException: "property is not provided by source" (via wbeditentity API)

2020-07-02 Thread Krinkle
Krinkle closed this task as "Resolved". Krinkle added a comment. It now responds differnetly, suggesting that the issue has been acknowledge in the code as the user/input error that it is, and thus no longer causes a PHP crash: { "error": { &q

[Wikidata-bugs] [Maniphest] [Triaged] T223789: Add selenium tests to WikibaseCirrusSearch

2020-07-01 Thread Krinkle
Krinkle triaged this task as "Low" priority. TASK DETAIL https://phabricator.wikimedia.org/T223789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Smalyshev, CBogen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSM

[Wikidata-bugs] [Maniphest] [Updated] T223789: Add selenium tests to WikibaseCirrusSearch

2020-07-01 Thread Krinkle
Krinkle removed projects: Patch-For-Review, patch-welcome. TASK DETAIL https://phabricator.wikimedia.org/T223789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Smalyshev, CBogen, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Merged] T255282: mw1384 is misbehaving

2020-06-22 Thread Krinkle
Krinkle closed this task as a duplicate of T245183: PHP7 corruption: Method call executed on unrelated object (also: Call to undefined method). TASK DETAIL https://phabricator.wikimedia.org/T255282 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T250555: test.wikimedia.beta.wmflabs.org pages not loading: Unknown database 'testwikidatawiki'

2020-06-19 Thread Krinkle
Krinkle added a comment. In T250555#6241257 <https://phabricator.wikimedia.org/T250555#6241257>, @Majavah wrote: > Hmh. This is caused by `wmf-config/config/testwiki.yaml` inheriting `wikidataclient-test`, which configures Wikibase to use `testwikidatawiki` instead of `wik

[Wikidata-bugs] [Maniphest] [Updated] T223410: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets

2020-06-17 Thread Krinkle
Krinkle added a comment. In T223410#6233012 <https://phabricator.wikimedia.org/T223410#6233012>, @Catrope wrote: > What's the rationale behind doing the branch cut on Friday, then waiting over 72 hours to deploy it to even test wikis on Monday? From my perspectice,

[Wikidata-bugs] [Maniphest] [Updated] T249839: Fix Flow InvalidDataException in CI builds

2020-06-17 Thread Krinkle
Krinkle removed a parent task: T246358: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty. TASK DETAIL https://phabricator.wikimedia.org/T249839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, kostajh

[Wikidata-bugs] [Maniphest] [Updated] T255704: Fatal LogicException: Role mediainfo is already defined

2020-06-17 Thread Krinkle
Krinkle edited projects, added WikibaseMediaInfo, Structured Data Engineering; removed Wikidata, Wikidata-Campsite. Restricted Application added a project: Structured-Data-Backlog. TASK DETAIL https://phabricator.wikimedia.org/T255704 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Retitled] T255704: Fatal LogicException: Role mediainfo is already defined

2020-06-17 Thread Krinkle
Krinkle renamed this task from "Role mediainfo is already defined" to "Fatal LogicException: Role mediainfo is already defined". Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255704 EMAIL PREFERENCES https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Commented On] T249839: Fix Flow InvalidDataException in CI builds

2020-06-17 Thread Krinkle
Krinkle added a comment. I'll give this a few more days, but otherwise I suggest we disable for now so that other teams can move forward. TASK DETAIL https://phabricator.wikimedia.org/T249839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Edited] T249839: Fix Flow InvalidDataException in CI builds

2020-06-17 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T249839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, kostajh, Pablo-WMDE, Aklapper, Lucas_Werkmeister_WMDE, NavinRizwi, Demian, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Commented On] T249838: Fix WikibaseLexeme UnsupportedObjectExceptions in Wikibase CI builds

2020-06-15 Thread Krinkle
Krinkle added a comment. If these tests aren't important, could they be temporarily disabled? TASK DETAIL https://phabricator.wikimedia.org/T249838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Addshore, Tarrow, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Retitled] T252841: Update the method Wikibase uses to inject edit language links into the language portlet

2020-06-11 Thread Krinkle
Krinkle renamed this task from "Update the method Wikibase uses to inject edit language links into the language portal" to "Update the method Wikibase uses to inject edit language links into the language portlet". TASK DETAIL https://phabricator.wikimedia.org/T25284

[Wikidata-bugs] [Maniphest] [Retitled] T255078: Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTargetEntityIdLookup

2020-06-11 Thread Krinkle
Krinkle renamed this task from "EntityLinkTargetEntityIdLookup RuntimeException when rendering links for wikidata items on commons using interwiki links" to "Fatal "Managed to lookup EntityId but got an unexpected type for namespace" from Wikibase EntityLinkTarge

[Wikidata-bugs] [Maniphest] [Retitled] T249839: Fix Flow InvalidDataException in CI builds

2020-06-11 Thread Krinkle
Krinkle renamed this task from "Fix Flow InvalidDataException in Wikibase CI builds" to "Fix Flow InvalidDataException in CI builds". TASK DETAIL https://phabricator.wikimedia.org/T249839 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferen

[Wikidata-bugs] [Maniphest] [Commented On] T249839: Fix Flow InvalidDataException in Wikibase CI builds

2020-06-11 Thread Krinkle
Krinkle added a comment. @kostajh Some questions/ideas to get on the way: - Is this Flow unit test behaving in as expected? E.g. it's asserting something good, but has an async failure that you expect, but aren't yet catching/asserting. - Or is it asserting something good, but has

[Wikidata-bugs] [Maniphest] [Retitled] T255054: PHP Warning: No RDF builder defined for data type wikibase-form nor for value type bad.

2020-06-10 Thread Krinkle
Krinkle renamed this task from "PHP Warning: Wikibase\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder: No RDF builder defined for data type wikibase-form nor for value type bad. [Called from Wikibase\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder in /srv/mediawiki/php-1.35.0-w

[Wikidata-bugs] [Maniphest] [Updated] T254334: WikibaseClient wblistentityusage API module throws RuntimeException when used as generator

2020-06-10 Thread Krinkle
Krinkle added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T254334 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Dipsacus_fullonum, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, lucamauri

[Wikidata-bugs] [Maniphest] [Created] T254536: CacheAwarePropertyInfoStore performs 4000 Memc ops/s (APC not working?)

2020-06-04 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikidata, Wikidata-Campsite, Sustainability (Incident Prevention). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Background: - T97368: Fix inefficient CacheAwarePropertyInfoStore memcached access pattern <ht

[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code

2020-06-04 Thread Krinkle
Krinkle added a comment. They were likely picked because BaseTemplate is abstract so SkinFallbackTemplate was the only somewhat neutral non-abstract implementation in core to pick. Should straight-forward to replace by direct use of BaseTemplate with `createMock()`. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Edited] T254525: Don't use internal FallbackTemplate inside code

2020-06-04 Thread Krinkle
Krinkle updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Aklapper, Jdlrobson, CostasAthan, darthmon_wmde, Gsklayploy, DannyS712, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Reopened] T254151: MonolingualTextInputWidget does not work outside of file pages

2020-06-03 Thread Krinkle
Krinkle reopened this task as "Open". Krinkle added a project: Performance-Team (Radar). Krinkle added a comment. In T254151#6188612 <https://phabricator.wikimedia.org/T254151#6188612>, @gerritbot wrote: > Change 601337 **merged** by jenkins-bot: >

[Wikidata-bugs] [Maniphest] [Commented On] T223410: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets

2020-05-28 Thread Krinkle
Krinkle added a comment. If there are "general" (non-Wikidata) issues to uncover on group0, we would ideally uncover them without letting Wikidata propagate and corrupt data to group2 and group1 wikis like Wikipedia, and Commons, and also without letting it take down those

[Wikidata-bugs] [Maniphest] [Commented On] T223410: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets

2020-05-27 Thread Krinkle
Krinkle added a comment. In T223410#6171292 <https://phabricator.wikimedia.org/T223410#6171292>, @Krinkle wrote: > We have also done per-wiki promotions directly at times in the past. Actually, this is done every week on Tuesday to promote testwiki (ahead of the rest fr

[Wikidata-bugs] [Maniphest] [Commented On] T223410: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets

2020-05-27 Thread Krinkle
Krinkle added a comment. In T223410#5783502 <https://phabricator.wikimedia.org/T223410#5783502>, @mmodell wrote: > I generally like this proposal, however, I dislike the growing complexity of the groups and their naming. (I was thinking the same). I don't have a prefere

[Wikidata-bugs] [Maniphest] [Commented On] T248866: Consider having a linter that could catch config file entries that set unused variables

2020-05-27 Thread Krinkle
Krinkle added a comment. Does this help? https://wikitech.wikimedia.org/wiki/Technical_debt/Unused_config TASK DETAIL https://phabricator.wikimedia.org/T248866 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Jdforrester

[Wikidata-bugs] [Maniphest] [Commented On] T253624: Evaluate the future of wikibase-codesniffer

2020-05-26 Thread Krinkle
Krinkle added a comment. Note that `.phpcs` is controllable per repository. The same way that we disable some rules in repositories not yet ready to follow a newer convention, it is also possible to enable additional rules on a per-repo bases. So these rulesets could easily be put

[Wikidata-bugs] [Maniphest] [Retitled] T253366: PHPUnit warning from Wikibase\Lib\CachingKartographerEmbeddingHandlerTest

2020-05-21 Thread Krinkle
Krinkle renamed this task from "PHPUnit warnign from Wikibase\Lib\CachingKartographerEmbeddingHandlerTest" to "PHPUnit warning from Wikibase\Lib\CachingKartographerEmbeddingHandlerTest". Krinkle added a project: ci-test-error. TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Created] T253366: PHPUnit warnign from Wikibase\Lib\CachingKartographerEmbeddingHandlerTest

2020-05-21 Thread Krinkle
Krinkle created this task. Krinkle added projects: Wikidata, Wikidata-Campsite, MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - Gerrit change for mediawiki/extension/Translate <https://gerrit.wikimedia.org/r/#/c/mediawiki/extensi

[Wikidata-bugs] [Maniphest] [Commented On] T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same

2020-05-19 Thread Krinkle
Krinkle added a comment. Seen on www.wikidata.org as well. - reqId: `4a83c7b9-dff6-4185-9a7d-b9dac050a1ab` - reqId: `a0bb4945-e080-4b41-a402-4c0edb562eff` - reqId: `081d5f57-ff6a-4f29-9971-fa722d7eae6b` - reqId: `df03dd06-c3cd-4853-b04a-dba00183800f` wikidatawiki /w

[Wikidata-bugs] [Maniphest] [Declined] T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki

2020-05-17 Thread Krinkle
Krinkle closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T122520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Ladsgroup, Krinkle, Stashbot, Reedy, hoo, Aklapper, Krenair, StudiesWorld, dar

[Wikidata-bugs] [Maniphest] [Unblock] T158751: Make populateSitesTable.php more robust

2020-05-17 Thread Krinkle
Krinkle closed subtask T122520: Error running `extensions/Wikibase/lib/maintenance/populateSitesTable.php --force-protocol https` on jbowiki as Declined. TASK DETAIL https://phabricator.wikimedia.org/T158751 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T252091: RFC: Site-wide edit rate limiting with PoolCounter

2020-05-13 Thread Krinkle
Krinkle added a comment. @Ladsgroup wrote: > […] The edit rate on this wiki has been going up to 1,000 edits per minute and has been testing our infrastructure scalability […] The edits have been mostly done by bots […] and bot operators want to edit in full speed w

[Wikidata-bugs] [Maniphest] [Retitled] T252061: [data-update-failed]: Avoiding infinite loop due to possibily undetectable existing records (Wikibase DataUpdateAdapter)

2020-05-13 Thread Krinkle
Krinkle renamed this task from "DeferredUpdates: PHP Warning: [data-update-failed]: A data update callback triggered an exception" to " [data-update-failed]: Avoiding infinite loop due to possibily undetectable existing records (Wikibase DataUpdateAdapter)".

[Wikidata-bugs] [Maniphest] [Unblock] T95663: [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor

2020-05-11 Thread Krinkle
Krinkle closed subtask T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T95663 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Unblock] T110172: [Task] Make Wikibase-JavaScript-API testextension job run composer

2020-05-11 Thread Krinkle
Krinkle closed subtask T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T110172 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki

[Wikidata-bugs] [Maniphest] [Unblock] T107834: [Task] change phpunit CI job for Wikidata.org to use composer

2020-05-11 Thread Krinkle
Krinkle closed subtask T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T107834 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki

[Wikidata-bugs] [Maniphest] [Unblock] T86176: Fix Job for running WBJSAPI QUnit tests on Jenkins

2020-05-11 Thread Krinkle
Krinkle closed subtask T90303: Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T86176 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki

[Wikidata-bugs] [Maniphest] [Commented On] T249587: Wikidata API wbgetentities: Allowed memory size exceeded

2020-05-07 Thread Krinkle
Krinkle added a comment. --- a/includes/api/ApiResult.php +++ b/includes/api/ApiResult.php @@ -396,9 +396,15 @@ class ApiResult implements ApiSerializable { if ( !( $flags & self::NO_SIZE_CHECK ) ) { // self::size needs the validated value. Then

[Wikidata-bugs] [Maniphest] [Updated] T251876: wbsgetsuggestions RevisionedUnresolvedRedirectException logspam

2020-05-06 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T251876 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T251878: UpdateRepoOnMove RevisionedUnresolvedRedirectException logspam

2020-05-06 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T251878 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Updated] T251880: Special:Search RevisionedUnresolvedRedirectException logspam

2020-05-06 Thread Krinkle
Krinkle removed a project: Wikimedia-production-error. TASK DETAIL https://phabricator.wikimedia.org/T251880 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread Krinkle
Krinkle added a comment. @daniel How did it work before? What needed to change? What actually changed? TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Agusbou2015, Pchelolo, daniel

[Wikidata-bugs] [Maniphest] [Updated] T251538: bridge selenium: 'back from a save' errorHandling times out

2020-04-30 Thread Krinkle
Krinkle removed a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T251538 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Lucas_Werkmeister_WMDE, Jakob_WMDE, Aklapper, Pablo-WMDE, Sarai

[Wikidata-bugs] [Maniphest] [Updated] T224546: Make WikibaseLexeme browser tests less flaky

2020-04-30 Thread Krinkle
Krinkle removed a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T224546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Michael, Tarrow, Jdforrester-WMF, Liuxinyu970226, SBisson

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread Krinkle
Krinkle added a parent task: T249962: 1.35.0-wmf.30 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Jdforrester-WMF, Krinkle, Marostegui, Liuxinyu970226, brennen

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread Krinkle
Krinkle added a comment. Definitely a new problem, and it is causing about 200 user actions per hour to be aborted/prevented (presumably edits, but may be other stuff as well). F31788692: Screenshot 2020-04-30 at 18.22.38.png <https://phabricator.wikimedia.org/F31788692> TASK

[Wikidata-bugs] [Maniphest] [Changed Project Column] T250728: Wikibase Client data-bridge selenium test failure

2020-04-23 Thread Krinkle
Krinkle moved this task from Backlog to WMF-deployed Build Failure on the ci-test-error board. Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error. TASK DETAIL https://phabricator.wikimedia.org/T250728 WORKBOARD https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Closed] T157651: sql.php must not run LoadExtensionSchemaUpdates

2020-04-21 Thread Krinkle
Krinkle closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, Krinkle Cc: Demian, Jdforrester-WMF, kostajh, WMDE-leszek, Addshore, Anomie, alaa_wmd

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php must not run LoadExtensionSchemaUpdates

2020-04-21 Thread Krinkle
Krinkle added a comment. In T157651#4765173 <https://phabricator.wikimedia.org/T157651#4765173>, @gerritbot wrote: > [mediawiki/core@master] Structure test for wrong calls in LoadExtensionSchemaUpdates > https://gerrit.wikimedia.org/r/475065 @daniel I noticed a patc

[Wikidata-bugs] [Maniphest] [Retitled] T157651: sql.php must not run LoadExtensionSchemaUpdates

2020-04-21 Thread Krinkle
Krinkle renamed this task from "sql.php runs LoadExtensionSchemaUpdates" to "sql.php must not run LoadExtensionSchemaUpdates". TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To

[Wikidata-bugs] [Maniphest] [Updated] T65015: [Bug] SpamBlacklist hook causes Wikibase LinkTitle api phpunit tests to fail

2020-04-19 Thread Krinkle
Krinkle removed a subscriber: wikibugs-l-list. Krinkle removed a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T65015 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Umherirrender

[Wikidata-bugs] [Maniphest] [Updated] T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI

2020-04-19 Thread Krinkle
Krinkle removed a project: ci-test-error (WMF-deployed Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T227266 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Addshore, Pablo-WMDE, Jakob_WMDE, Ladsgroup, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Updated] T224546: Make WikibaseLexeme browser tests less flaky

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T224546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T65015: [Bug] SpamBlacklist hook causes Wikibase LinkTitle api phpunit tests to fail

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T65015 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T245824: Error in "App closes on clicking the cancel button"

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T245824 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T250305: wmf-quibble-vendor-mysql-php72-docker failed on Special:EntityData

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T250305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc

[Wikidata-bugs] [Maniphest] [Updated] T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI

2020-04-18 Thread Krinkle
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error, Wikimedia-production-error (Shared Build Failure). TASK DETAIL https://phabricator.wikimedia.org/T227266 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T246456: Performance review of Wikidata Bridge

2020-04-14 Thread Krinkle
Krinkle added a subtask: T248840: Don’t polyfill Promise in Bridge modules. TASK DETAIL https://phabricator.wikimedia.org/T246456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: aaron, Krinkle Cc: Jakob_WMDE, Lydia_Pintscher, Addshore, Krinkle

  1   2   3   4   5   6   7   8   9   10   >