[Wikidata-bugs] [Maniphest] T266078: interwikidata.py throws pywikibot.data.api.APIError: param-missing: Either provide the Item "ids" or pairs of "sites" and "titles" for corresponding page

2020-10-22 Thread Ladsgroup
Ladsgroup added a comment. Maybe it's because T264963: Add Wikidata support for smnwiki <https://phabricator.wikimedia.org/T264963> was resolved? TASK DETAIL https://phabricator.wikimedia.org/T266078 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] T264963: Add Wikidata support for smnwiki

2020-10-21 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. Done. It'll be usable up to two hours from now (so caches invalidates) TASK DETAIL https://phabricator.wikimedia.org/T264963 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] T264963: Add Wikidata support for smnwiki

2020-10-21 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. Sure thing TASK DETAIL https://phabricator.wikimedia.org/T264963 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc

[Wikidata-bugs] [Maniphest] T245951: sparql_tests sometimes fails with TimeoutError

2020-10-21 Thread Ladsgroup
Ladsgroup closed subtask T242081: Pywikibot fails to access Wikidata due to high maxlag lately as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T245951 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Dvorapa, Aklapper, Xqt

[Wikidata-bugs] [Maniphest] T243701: Wikidata maxlag repeatedly over 5s since Jan 20, 2020 (primarily caused by the query service)

2020-10-21 Thread Ladsgroup
Ladsgroup added a comment. @Lydia_Pintscher with the T258354: remove noratelimit from bot group for Wikidata <https://phabricator.wikimedia.org/T258354> being done, Can this be called done now? TASK DETAIL https://phabricator.wikimedia.org/T243701 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T265581: Create Message component without icons

2020-10-16 Thread Ladsgroup
Ladsgroup added a comment. In my localhost it's this: F32386827: image.png <https://phabricator.wikimedia.org/F32386827> Which looks fine except the icons of notice and success because they are not in the icon inventory yet. TASK DETAIL https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] T265581: Create Message component without icons

2020-10-16 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 2) board. Ladsgroup added a comment. https://github.com/wmde/wikit/pull/225 TASK DETAIL https://phabricator.wikimedia.org/T265581 WORKBOARD https

[Wikidata-bugs] [Maniphest] T265581: Create Message component without icons

2020-10-16 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 2) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T265581 WORKBOARD https

[Wikidata-bugs] [Maniphest] T265299: Investigate integrating accessibility testing tools into development tooling

2020-10-16 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 2) board. Ladsgroup added a comment. - Fixing one current a11y issue we have: https://github.com/wmde/query-builder/pull/32 - POC adding test for a11y (currently failing due

[Wikidata-bugs] [Maniphest] T265299: Investigate integrating accessibility testing tools into development tooling

2020-10-15 Thread Ladsgroup
Ladsgroup added a comment. **Regarding rules:** So these are rules that pa11y supports <https://github.com/pa11y/pa11y/wiki/HTML-CodeSniffer-Rules> and these are rules that axe-core supports <https://github.com/dequelabs/axe-core/blob/develop/doc/rule-descriptions.md>. Bot

[Wikidata-bugs] [Maniphest] T265583: Wire icons to the message component

2020-10-15 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 2). TASK DESCRIPTION Once T265581: Create Message component without icons <https://phabricator.wikimedia.org/T265581> and T265582: Create icon components

[Wikidata-bugs] [Maniphest] T265582: Create icon components

2020-10-15 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 2). TASK DESCRIPTION the specs are in the parent ticket. Only the two icons so far. TASK DETAIL https://phabricator.wikimedia.org/T265582 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T265581: Create Message component without icons

2020-10-15 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 2). TASK DESCRIPTION To make the work parallelize-able, create the message components without getting into complexities of handing the icon components. TASK DETAIL https

[Wikidata-bugs] [Maniphest] T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]

2020-10-15 Thread Ladsgroup
Ladsgroup merged a task: T265576: Bad value for parameter $oldContent: must be a TextContent|null. Ladsgroup added a subscriber: WMDE-leszek. TASK DETAIL https://phabricator.wikimedia.org/T231084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T265576: Bad value for parameter $oldContent: must be a TextContent|null

2020-10-15 Thread Ladsgroup
Ladsgroup closed this task as a duplicate of T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5]. TASK DETAIL https://phabricator.wikimedia.org/T265576 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T265576: Bad value for parameter $oldContent: must be a TextContent|null

2020-10-15 Thread Ladsgroup
Ladsgroup added a comment. Yup, moving the star to some number like this makes it work: https://www.wikidata.org/w/index.php?diff=125150*4296=235663452 (since 125150 is an item diff but 1 is not) TASK DETAIL https://phabricator.wikimedia.org/T265576 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T265576: Bad value for parameter $oldContent: must be a TextContent|null

2020-10-15 Thread Ladsgroup
Ladsgroup added a comment. This is very likely duplicate of T231084: Assert.php: Bad value for parameter $oldContent: must be a TextContent|null [Story Points 5] <https://phabricator.wikimedia.org/T231084> TASK DETAIL https://phabricator.wikimedia.org/T265576 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T265299: Investigate integrating accessibility testing tools into development tooling

2020-10-15 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 2) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T265299 WORKBOARD https

[Wikidata-bugs] [Maniphest] T114772: Allow entering Wikidata sitelinks to wikis that have non-typical wiki ID (not matching the database name)

2020-10-14 Thread Ladsgroup
Ladsgroup added a comment. Changed the AC, feel free to edit mercilessly. TASK DETAIL https://phabricator.wikimedia.org/T114772 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Michael

[Wikidata-bugs] [Maniphest] T114772: Allow entering Wikidata sitelinks to wikis that have non-typical wiki ID (not matching the database name)

2020-10-14 Thread Ladsgroup
Ladsgroup updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T114772 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Michael, Ladsgroup, Lydia_Pintscher, WMDE

[Wikidata-bugs] [Maniphest] T114772: Allow entering Wikidata sitelinks to wikis that have non-typical wiki ID (not matching the database name)

2020-10-14 Thread Ladsgroup
Ladsgroup added a comment. In T114772#6542465 <https://phabricator.wikimedia.org/T114772#6542465>, @Addshore wrote: > If `-` -> `_` is to be a general path for aliases then I think the description needs to be updated to reflect that. Yeah it's a general thing since name

[Wikidata-bugs] [Maniphest] T114772: Allow storing Wikidata sitelinks to wikis that have non-typical wiki ID (not matching the database name)

2020-10-14 Thread Ladsgroup
Ladsgroup added a comment. In T114772#6541988 <https://phabricator.wikimedia.org/T114772#6541988>, @Addshore wrote: > Okay, it looks like the one reamaining open question is around this example: > >> be_taraskwiki and be-taraskwiki is used to refer to wiki, which

[Wikidata-bugs] [Maniphest] T114772: Allow storing Wikidata sitelinks to wikis that have non-typical wiki ID (not matching the database name)

2020-10-14 Thread Ladsgroup
Ladsgroup updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T114772 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Michael, Ladsgroup, Lydia_Pintscher, WMDE

[Wikidata-bugs] [Maniphest] T114772: [Task] Implement SiteIdMapper PHP service

2020-10-14 Thread Ladsgroup
Ladsgroup updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T114772 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Michael, Ladsgroup, Lydia_Pintscher, WMDE

[Wikidata-bugs] [Maniphest] T114772: [Task] Implement SiteIdMapper PHP service

2020-10-14 Thread Ladsgroup
Ladsgroup updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T114772 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Addshore, Lucas_Werkmeister_WMDE, Pablo-WMDE, Michael, Ladsgroup, Lydia_Pintscher, WMDE

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-10-14 Thread Ladsgroup
Ladsgroup added a comment. These are my opinions only, if anyone wants to double check, that'd be great. In T246415#6536970 <https://phabricator.wikimedia.org/T246415#6536970>, @Addshore wrote: > Looking at the ACs I think we have some open questions still > >

[Wikidata-bugs] [Maniphest] T261326: Deploy the retrained model

2020-10-12 Thread Ladsgroup
Ladsgroup added a comment. This is blocked on T265172: Requesting adding to ores-admin for Ladsgroup <https://phabricator.wikimedia.org/T265172> TASK DETAIL https://phabricator.wikimedia.org/T261326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] T239931: Reduce the impact of the sanitizer on wikidata

2020-10-12 Thread Ladsgroup
Ladsgroup added a comment. Agreed. TASK DETAIL https://phabricator.wikimedia.org/T239931 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Lucas_Werkmeister_WMDE, tfmorris, Pintoch, CBogen, EBernhardson, Ladsgroup, Addshore, Aklapper

[Wikidata-bugs] [Maniphest] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

2020-10-08 Thread Ladsgroup
Ladsgroup added a comment. I want to point out that we don't necessary need nginx or any static file serving software in kubernetes to be able to move this. The GUI can be easily turned to a nodejs app or worst case, you can use https://www.npmjs.com/package/http-server to serve them. TASK

[Wikidata-bugs] [Maniphest] T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features

2020-10-07 Thread Ladsgroup
Ladsgroup added a comment. In T205094#6525519 <https://phabricator.wikimedia.org/T205094#6525519>, @WMDE-leszek wrote: > This seems to be finished. There is still a bunch questions I would have that this task does not seem to be explaining, e.g. how this "abstract sch

[Wikidata-bugs] [Maniphest] T264320: Introduce SPARQL.js and set up boilerplate

2020-10-07 Thread Ladsgroup
Ladsgroup moved this task from Doing to Test (Verification) on the Wikidata Query Builder (Wikidata Query Builder - sprint 1) board. Ladsgroup added a comment. For building types representing the query, I will create follow up tickets. TASK DETAIL https://phabricator.wikimedia.org/T264320

[Wikidata-bugs] [Maniphest] T264821: Hourly read spikes against s8 resulting in occasional user-visible latency & error spikes

2020-10-07 Thread Ladsgroup
Ladsgroup added a comment. An update from IRC, it seems the culprit is wikifeeds: https://grafana.wikimedia.org/d/b1jttnFMz/envoy-telemetry-k8s?viewPanel=4=1=1602010785563=1602037491008=thanos=codfw=k8s=wikifeeds=restbase-for-services F32376861: image.png <https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] T237102: Increase the size of wbt_text_in_lang.wbxl_language

2020-10-07 Thread Ladsgroup
Ladsgroup added a comment. Sure: wikiadmin@10.192.32.183(testwikidatawiki)> desc wbt_text_in_lang; +---+--+--+-+-++ | Field | Type | Null | Key | Default | Ex

[Wikidata-bugs] [Maniphest] T264822: Security Readiness Review For Wikidata Query Builder

2020-10-06 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Security, Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION **Project Information ** - Name of tool/project: Wikidata Query Builder

[Wikidata-bugs] [Maniphest] T237102: Increase the size of wbt_text_in_lang.wbxl_language

2020-10-06 Thread Ladsgroup
Ladsgroup added a comment. In T237102#6521036 <https://phabricator.wikimedia.org/T237102#6521036>, @WMDE-leszek wrote: > @Addshore @Ladsgroup how would I confirm this is done? on local instance: MariaDB [(none)]> use repo; Reading table information for complet

[Wikidata-bugs] [Maniphest] T245818: Audit query pages on Wikidata

2020-10-06 Thread Ladsgroup
Ladsgroup added a comment. In T245818#6135037 <https://phabricator.wikimedia.org/T245818#6135037>, @Ladsgroup wrote: > @Marostegui Thanks. Is there any other page that is also causing problems (not enough to be killed but still enough to be annoying?) ping :D TASK DETAI

[Wikidata-bugs] [Maniphest] T243915: Performance audit of Wikibase/Wikidata, Jan 2020

2020-10-06 Thread Ladsgroup
Ladsgroup closed subtask T243952: JSON representation of an item should not need property info as Invalid. TASK DETAIL https://phabricator.wikimedia.org/T243915 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Michael, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] T243952: JSON representation of an item should not need property info

2020-10-06 Thread Ladsgroup
Ladsgroup closed this task as "Invalid". Ladsgroup added a comment. Oh yeah, you are right. Now that uses APCu instead, it's much faster: https://performance.wikimedia.org/xhgui/run/view?id=5f7ca9b3759dfae580c6b56a I don't see a place to improve this now. Boldly closing this. T

[Wikidata-bugs] [Maniphest] T243915: Performance audit of Wikibase/Wikidata, Jan 2020

2020-10-06 Thread Ladsgroup
Ladsgroup added a comment. Should we call this done? TASK DETAIL https://phabricator.wikimedia.org/T243915 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Michael, Jdforrester-WMF, Agabi10, Aklapper, Addshore, Ladsgroup

[Wikidata-bugs] [Maniphest] T208416: Check whether wikidata-dev project requires NFS or not

2020-10-06 Thread Ladsgroup
Ladsgroup added a comment. I think we are ready. It has been a while now. TASK DETAIL https://phabricator.wikimedia.org/T208416 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Andrew, Ladsgroup Cc: Andrew, Ladsgroup, Tarrow, ItamarWMDE, Bstorm

[Wikidata-bugs] [Maniphest] T264320: Introduce SPARQL.js and set up boilerplate

2020-10-05 Thread Ladsgroup
Ladsgroup added a comment. This is my first TypeScript PR, I hope it's not too horrible: https://github.com/wmde/query-builder/pull/20 TASK DETAIL https://phabricator.wikimedia.org/T264320 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T264320: Introduce SPARQL.js and set up boilerplate

2020-10-05 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 1) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T264320 WORKBOARD https

[Wikidata-bugs] [Maniphest] T114772: [Task] Implement SiteIdMapper PHP service

2020-10-02 Thread Ladsgroup
Ladsgroup added a comment. In T114772#6509151 <https://phabricator.wikimedia.org/T114772#6509151>, @WMDE-leszek wrote: > @Addshore @Ladsgroup: > Having look at this task with developers we were not clear about certain details which are probably obvious but we didn't find

[Wikidata-bugs] [Maniphest] T264318: Set up store and wire it to text input component

2020-10-01 Thread Ladsgroup
Ladsgroup updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T264318 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Jakob_WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-30 Thread Ladsgroup
Ladsgroup added a comment. Three things are mistakes: `PrefetchingPropertyTermLookup_prefetchTerms`, `PrefetchingItemTermLookup_prefetchTerms`, `CachedDatabasePropertyLabelResolver_loadProperties`. The other nine are correct. We can either remove calls to the trait (but it might break some

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-30 Thread Ladsgroup
Ladsgroup added a comment. I'm pretty sure it's not two thirds, the only mistake I found is `CachedDatabasePropertyLabelResolver_loadProperties`, the rest are related to a query but sometimes it's slightly hidden. Let me clean it up. TASK DETAIL https://phabricator.wikimedia.org/T262923

[Wikidata-bugs] [Maniphest] T263564: First simple query - input of string values only with hard-coded Property

2020-09-29 Thread Ladsgroup
Ladsgroup added a comment. I started this: https://github.com/wmde/query-builder/pull/11/files This is the result in my pc: F32368020: image.png <https://phabricator.wikimedia.org/F32368020> One thing: The figma mockup says the color of "Find all items" should be

[Wikidata-bugs] [Maniphest] T264084: Drop unused indexes of wb_changes

2020-09-29 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. The follow up on T264109: Schema change to drop three indexes from wb_changes <https://phabricator.wikimedia.org/T264109> TASK DETAIL https://phabricator.wikimedia.org/T264084 EMAIL PRE

[Wikidata-bugs] [Maniphest] T263539: Set up a test system

2020-09-29 Thread Ladsgroup
Ladsgroup added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T263539 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: bete, Aklapper, Jakob_WMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz

[Wikidata-bugs] [Maniphest] T258354: create new rate-limited bot group for Wikidata

2020-09-29 Thread Ladsgroup
Ladsgroup added a comment. In T258354#6499293 <https://phabricator.wikimedia.org/T258354#6499293>, @Multichill wrote: > Ok, I see, we only put misbehaving bots in this group. I think the proposal is the other way around, we add important bots that needs bypassing

[Wikidata-bugs] [Maniphest] T258354: create new rate-limited bot group for Wikidata

2020-09-29 Thread Ladsgroup
Ladsgroup added a comment. In T258354#6497417 <https://phabricator.wikimedia.org/T258354#6497417>, @Lydia_Pintscher wrote: > So that leaves the suggestion to remove noratelimit from all bots and add accounts that require noratelimit to "accountcreator" group

[Wikidata-bugs] [Maniphest] T264084: Drop unused indexes of wb_changes

2020-09-29 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added a project: Wikidata. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: User-Ladsgroup. TASK DESCRIPTION Result of T262856: Investigate indexes of wb_changes <https://phabricator.wikimedia.org/T262

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-25 Thread Ladsgroup
Ladsgroup added a comment. Hope these answers help. In T246415#6494603 <https://phabricator.wikimedia.org/T246415#6494603>, @Michael wrote: >> lots of them actually coming from mediawiki core and we have no control over destination of queries orig

[Wikidata-bugs] [Maniphest] T263539: Set up a test system

2020-09-25 Thread Ladsgroup
Ladsgroup added a comment. https://github.com/wmde/query-builder/pull/10 TASK DETAIL https://phabricator.wikimedia.org/T263539 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: bete, Aklapper, Jakob_WMDE, Hazizibinmahdi, Akuckartz

[Wikidata-bugs] [Maniphest] T263381: wikibase-* jobs are failing on master

2020-09-25 Thread Ladsgroup
Ladsgroup added a comment. In T263381#6494227 <https://phabricator.wikimedia.org/T263381#6494227>, @Pablo-WMDE wrote: > Hi, > > @Ladsgroup wrote > >> I think **these all** should be removed, > > This sounds like you thought about this alr

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-25 Thread Ladsgroup
Ladsgroup added a comment. In T262923#6490857 <https://phabricator.wikimedia.org/T262923#6490857>, @toan wrote: > Playing around with a new panel on grafana and looking at how these statsd things are called from the code. > > the sta

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-25 Thread Ladsgroup
Ladsgroup added a comment. Okay, Let me give on overview on what has been worked on so far, this is basically a summary of the previous comments and reshaped: - Queries to term store are basically half of the load. - Given that it's actually 1% of queries that actually reach the db

[Wikidata-bugs] [Maniphest] T263539: Set up a test system

2020-09-24 Thread Ladsgroup
Ladsgroup added a comment. @bete I'm not sure what you suggest can be easily incorporated into Toolforge infra, if we had our own VM, it would be a different story and if we use production pipeline, it would have its own pipeline (https://wikitech.wikimedia.org/wiki/Blubber) TASK DETAIL

[Wikidata-bugs] [Maniphest] T263539: Set up a test system

2020-09-24 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 0) board. Ladsgroup added a comment. https://github.com/wmde/query-builder/pull/9 TASK DETAIL https://phabricator.wikimedia.org/T263539 WORKBOARD https

[Wikidata-bugs] [Maniphest] T262856: Investigate indexes of wb_changes

2020-09-23 Thread Ladsgroup
Ladsgroup added a comment. Thank you so much! Let me know If I can be of any help. TASK DETAIL https://phabricator.wikimedia.org/T262856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Marostegui, Ladsgroup Cc: Kormat, Marostegui

[Wikidata-bugs] [Maniphest] T263539: Set up a test system

2020-09-23 Thread Ladsgroup
Ladsgroup claimed this task. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T263539 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, Jakob_WMDE, Hazizibinmahdi, Akuckartz

[Wikidata-bugs] [Maniphest] T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features

2020-09-23 Thread Ladsgroup
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. The only thing left is wb_terms and I assume this will be handled on the wb_terms clean up hike. TASK DETAIL https

[Wikidata-bugs] [Maniphest] T262856: Investigate indexes of wb_changes

2020-09-23 Thread Ladsgroup
Ladsgroup added a comment. So tendril doesn't have anything in sampled queries: https://tendril.wikimedia.org/report/sampled_queries?host=^db=wikiuser=wik=1 (maybe it's not sampling from codfw?) I looked at the code in depth and found a couple of queries. The queries I see

[Wikidata-bugs] [Maniphest] T261331: Metrics: Get the quality score changes per month for at least 2019 and 2020 in a sankey diagram based on the new model

2020-09-22 Thread Ladsgroup
Ladsgroup added a comment. So the script is finished and I could build these: The file names have the the time span of when to when. It's start of Q to Q and in one case, it's Jan 2019 to Jan 2020. F32359042: jan2019 to jan 2020.png <https://phabricator.wikimedia.org/F32359

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-22 Thread Ladsgroup
Ladsgroup removed Ladsgroup as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T262923 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Rosalie_WMDE, toan, Lucas_Werkmeister_WMDE, Aklapper

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-22 Thread Ladsgroup
Ladsgroup added a comment. Filed: T263520: Updating user edit count is pretty expensive in some wikis <https://phabricator.wikimedia.org/T263520> TASK DETAIL https://phabricator.wikimedia.org/T246415 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-22 Thread Ladsgroup
Ladsgroup added a comment. On average 60% of term store queries come from client wikis <https://grafana.wikimedia.org/d/00548/wikibase-sql-term-storage?viewPanel=22=1=30s=now-6h=now>: F32358730: image.png <https://phabricator.wikimedia.org/F32358730> TASK DE

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-21 Thread Ladsgroup
Ladsgroup added a comment. Now we have a dashboard for ratio queries coming from client wikis: https://grafana.wikimedia.org/d/00548/wikibase-sql-term-storage?viewPanel=22=1=30s=now-3h=now Currently, it varies between 60% to 70% TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T261330: Metrics: Get the average quality change per month based on the new model

2020-09-21 Thread Ladsgroup
Ladsgroup added a comment. In T261330#6465625 <https://phabricator.wikimedia.org/T261330#6465625>, @Lydia_Pintscher wrote: > Current status: script that's calculating the scores for past revisions is running and almost finished. Amir is babysitting it. It's done now, you c

[Wikidata-bugs] [Maniphest] T263381: wikibase-* jobs are failing on master

2020-09-21 Thread Ladsgroup
Ladsgroup added a comment. I think these all should be removed, they are duplicating the values from core. TASK DETAIL https://phabricator.wikimedia.org/T263381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Jdforrester-WMF

[Wikidata-bugs] [Maniphest] T262856: Investigate indexes of wb_changes

2020-09-21 Thread Ladsgroup
Ladsgroup added a comment. In T262856#6461221 <https://phabricator.wikimedia.org/T262856#6461221>, @Marostegui wrote: > My advise would be to drop these on an active slave and see if we see performance regressions. Sounds good to me, do you want to do it? TASK DETAI

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-21 Thread Ladsgroup
Ladsgroup added a comment. In T246415#643 <https://phabricator.wikimedia.org/T246415#643>, @Marostegui wrote: > Thank you for all this work Amir, this is really interesting. I am curious about a few things, and if you'd have the time, can you explain further? >

[Wikidata-bugs] [Maniphest] T263381: wikibase-* jobs are failing on master

2020-09-20 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T263381 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T263381: wikibase-* jobs are failing on master

2020-09-20 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata-Campsite, ci-test-error (WMF-deployed Build Failure). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION The `wikibase-client-docker` and `wikibase-repo-docker

[Wikidata-bugs] [Maniphest] T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features

2020-09-18 Thread Ladsgroup
Ladsgroup moved this task from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. In T205094#6466818 <https://phabricator.wikimedia.org/T205094#6466818>, @Michael wrote: > Added (default?) 2 week due date to see

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-18 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T262923 WORKBOARD https

[Wikidata-bugs] [Maniphest] T261488: trial new termbox on desktop on a test system

2020-09-18 Thread Ladsgroup
Ladsgroup added a comment. In T261488#6475138 <https://phabricator.wikimedia.org/T261488#6475138>, @Lydia_Pintscher wrote: > How can I see the beauty? Does this count? https://wikidata.beta.wmflabs.org/wiki/Q15905 :D TASK DETAIL https://phabricator.wikimedia.org/T2614

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-18 Thread Ladsgroup
Ladsgroup added a comment. While I'm here, I did a quick check on matter of pressure of writes on master. And boy I'm not disappointed: - 6% of all of the write pressure is just this: 95904.001 (6.519%) UPDATE `user` SET `user_editcount` = `user_editcount` + ? WHERE

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-18 Thread Ladsgroup
Ladsgroup added a comment. Top queries that put more than 1% of the total load on the replicas: Termbox: 23690016.0 (41.05%) SELECT `wbtl_id` , `wbtl_type_id` , `wbxl_language` , `wbx_text` , `wbit_item_id` FROM `wbt_term_in_lang` JOIN `wbt_text_in_lang

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-18 Thread Ladsgroup
Ladsgroup added a comment. In T246415#6474189 <https://phabricator.wikimedia.org/T246415#6474189>, @Addshore wrote: >> s8 is coming from clients or replicas. > > clients or replicas? I don't quite follow this bit? s/replicas/repos/ I wrote replicas so m

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-09-18 Thread Ladsgroup
Ladsgroup added a comment. What we have done here: We went through the performance schema of replicas in codfw since the switchover (September 2, 17 days ago) to see what is the nature of queries going to replicas. Total latency of selects for s8 replicas is 57712491 seconds (roughly 100

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-18 Thread Ladsgroup
Ladsgroup added subscribers: toan, Rosalie_WMDE, Ladsgroup. Ladsgroup added a comment. we are doing it with @toan @Rosalie_WMDE TASK DETAIL https://phabricator.wikimedia.org/T262923 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc

[Wikidata-bugs] [Maniphest] T258822: ArticlePlaceholder doesn't declare extension.json dependancy on Wikibase

2020-09-17 Thread Ladsgroup
Ladsgroup added a comment. Okay, this is blocked on T258822: ArticlePlaceholder doesn't declare extension.json dependancy on Wikibase <https://phabricator.wikimedia.org/T258822> getting done, once that's done we can pick this up. TASK DETAIL https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] T258822: ArticlePlaceholder doesn't declare extension.json dependancy on Wikibase

2020-09-17 Thread Ladsgroup
Ladsgroup added a subtask: T263101: Make mediawiki core installer stop trying to find extensions early and check if the are loaded or not.. TASK DETAIL https://phabricator.wikimedia.org/T258822 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T262773: Stop archiving the wikidata-bugs mailinglist in pipermail

2020-09-16 Thread Ladsgroup
Ladsgroup added a comment. In T262773#6468887 <https://phabricator.wikimedia.org/T262773#6468887>, @Dzahn wrote: > In T262773#6465226 <https://phabricator.wikimedia.org/T262773#6465226>, @Ladsgroup wrote: > >> What about pywikibugs-l? I assume it's also p

[Wikidata-bugs] [Maniphest] T262773: Stop archiving the wikidata-bugs mailinglist in pipermail

2020-09-16 Thread Ladsgroup
Ladsgroup added a comment. In T262773#6464894 <https://phabricator.wikimedia.org/T262773#6464894>, @Dzahn wrote: > I can only agree with what RLazarus already said. This is just a config change at the list-admin level. The people receiving wikidata-bugs-ow...@lists.wikimedi

[Wikidata-bugs] [Maniphest] T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features

2020-09-16 Thread Ladsgroup
Ladsgroup moved this task from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Now waiting on the core patch getting merged so we can pick up wb_changes_dispatch and dropping wb_terms. TASK DETAIL https

[Wikidata-bugs] [Maniphest] T262773: Stop archiving the wikidata-bugs mailinglist in pipermail

2020-09-16 Thread Ladsgroup
Ladsgroup added a comment. What about pywikibugs-l? I assume it's also pretty big and people can just search in phabricator instead. TASK DETAIL https://phabricator.wikimedia.org/T262773 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup

[Wikidata-bugs] [Maniphest] T261488: trial new termbox on desktop on a test system

2020-09-15 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. Actually getting it behind feature flag wasn't that hard (mostly because of using jquery selector in the old js code). TASK DETAIL https

[Wikidata-bugs] [Maniphest] T262856: Investigate indexes of wb_changes

2020-09-15 Thread Ladsgroup
Ladsgroup added a comment. In T262856#6461884 <https://phabricator.wikimedia.org/T262856#6461884>, @Lucas_Werkmeister_WMDE wrote: >> This table only exists on s8. > > Surely it must also exist on s4 (commonswiki, testcommonswiki) and s3 (testwikidata

[Wikidata-bugs] [Maniphest] T261488: trial new termbox on desktop on a test system

2020-09-15 Thread Ladsgroup
Ladsgroup added a comment. Horrible things I had to do to get it to work: - Make TermboxFlag php class set it to true if the setting is set - In RepoHooks::onBeforePageDisplay() register termbox and termbox.styles modules in case the settings is present or feature toggle is called

[Wikidata-bugs] [Maniphest] T261488: trial new termbox on desktop on a test system

2020-09-15 Thread Ladsgroup
Ladsgroup added a comment. I manged to get it to "work" in my localhost: F32351318: image.png <https://phabricator.wikimedia.org/F32351318> TASK DETAIL https://phabricator.wikimedia.org/T261488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/

[Wikidata-bugs] [Maniphest] T261488: trial new termbox on desktop on a test system

2020-09-15 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T261488 WORKBOARD https

[Wikidata-bugs] [Maniphest] T260869: Wikidata sitelink save, shows error message twice.

2020-09-14 Thread Ladsgroup
Ladsgroup added a comment. I can locally reproduce it too: F32350877: image.png <https://phabricator.wikimedia.org/F32350877> With the Jakob's patch it becomes this: F32350883: image.png <https://phabricator.wikimedia.org/F32350883> Maybe we can use the local

[Wikidata-bugs] [Maniphest] T262856: Investigate indexes of wb_changes

2020-09-14 Thread Ladsgroup
Ladsgroup created this task. Ladsgroup added projects: Wikidata-Campsite, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION While doing T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features <ht

[Wikidata-bugs] [Maniphest] T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features

2020-09-14 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup added a comment. This is mostly done, All tables are migrated except two: - wb_terms, it has some complexities (float data type) that is not yet doable

[Wikidata-bugs] [Maniphest] T262198: Convert P1438 from string to external ID

2020-09-14 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. Restricted Application added a project: User-Ladsgroup. TASK DETAIL https://phabricator.wikimedia.org/T262198 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T173777: ListeriaBot logs in 35000 times a day

2020-09-13 Thread Ladsgroup
Ladsgroup closed this task as "Resolved". Ladsgroup assigned this task to Magnus. Ladsgroup added a comment. This is done. TASK DETAIL https://phabricator.wikimedia.org/T173777 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Magnus, La

[Wikidata-bugs] [Maniphest] T261849: Benchmark old and new model accuracy on new labeled data

2020-09-10 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Item Quality Scoring Improvement (Item Quality Scoring Improvement - Sprint 3) board. Ladsgroup added a comment. So I took a 750 sample of current items in wikidata. I took a stratified sample, like 150 from a certain range of size

[Wikidata-bugs] [Maniphest] T261850: compare model accuracy with and without property suggester

2020-09-10 Thread Ladsgroup
Ladsgroup added a comment. In T261850#6449735 <https://phabricator.wikimedia.org/T261850#6449735>, @Michael wrote: > Thank you for your thorough research. That means we can effectively drop property suggester? Not having to do that extra network request should speed some

  1   2   3   4   5   6   7   8   9   10   >