[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  This patch (in Wikibase, not WikibaseLexeme!) makes the labels show up – it’s 
certainly not an ideal implementation yet, and it remains to be investigated 
which other places are affected by it (and whether we want those other places 
to resolve redirects as well), but it’s a good starting point, I think:
  
diff --git a/repo/WikibaseRepo.entitytypes.php 
b/repo/WikibaseRepo.entitytypes.php
index 63ab398b8e..7f5d11ca23 100644
--- a/repo/WikibaseRepo.entitytypes.php
+++ b/repo/WikibaseRepo.entitytypes.php
@@ -18,6 +18,7 @@
  */
 
 use MediaWiki\MediaWikiServices;
+use ValueFormatters\FormatterOptions;
 use Wikibase\DataAccess\DatabaseEntitySource;
 use Wikibase\DataModel\Entity\EntityDocument;
 use Wikibase\DataModel\Entity\Item;
@@ -27,6 +28,7 @@
 use Wikibase\Lib\DataTypeDefinitions;
 use Wikibase\Lib\EntityTypeDefinitions as Def;
 use Wikibase\Lib\EntityTypeDefinitions;
+use Wikibase\Lib\Formatters\FormatterLabelDescriptionLookupFactory;
 use Wikibase\Lib\Formatters\LabelsProviderEntityIdHtmlLinkFormatter;
 use Wikibase\Lib\Interactors\MatchingTermsLookupSearchInteractor;
 use Wikibase\Lib\SimpleCacheWithBagOStuff;
@@ -245,8 +247,17 @@
);
},
Def::ENTITY_ID_HTML_LINK_FORMATTER_CALLBACK => function( 
Language $language ) {
-   $languageLabelLookupFactory = 
WikibaseRepo::getLanguageFallbackLabelDescriptionLookupFactory();
-   $languageLabelLookup = 
$languageLabelLookupFactory->newLabelDescriptionLookup( $language );
+   $formatterLabelDescriptionLookupFactory = new 
FormatterLabelDescriptionLookupFactory(
+   WikibaseRepo::getTermLookup(),
+   WikibaseRepo::getTermFallbackCache(),
+   new RedirectResolvingLatestRevisionLookup( 
WikibaseRepo::getEntityRevisionLookup() )
+   );
+   $languageFallbackChainFactory = 
WikibaseRepo::getLanguageFallbackChainFactory();
+   $languageFallbackChain = 
$languageFallbackChainFactory->newFromLanguage( $language );
+   $options = new FormatterOptions( [
+   
FormatterLabelDescriptionLookupFactory::OPT_LANGUAGE_FALLBACK_CHAIN => 
$languageFallbackChain,
+   ] );
+   $languageLabelLookup = 
$formatterLabelDescriptionLookupFactory->getLabelDescriptionLookup( $options );
return new LabelsProviderEntityIdHtmlLinkFormatter(
$languageLabelLookup,
WikibaseRepo::getLanguageNameLookup(),

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Slight correction to the above: `FormatterLabelDescriptionLookupFactory` only 
returns a `CachingFallbackLabelDescriptionLookup` wrapping a 
`LanguageFallbackLabelDescriptionLookup` when it’s been given a language 
fallback chain in its formatter options. If it’s only been given a single 
language, then it returns a `LanguageLabelDescriptionLookup`, which doesn’t do 
language fallbacks (sensible) and also doesn’t resolve redirects (probably not 
intentional).
  
  What a mess.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  @Lydia_Pintscher are there any places where we generally want to show item 
labels, but not for redirects? (E.g. Special:AllPages, perhaps?)

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages)

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE edited projects, added Special:NewLexeme revival 
(Special:NewLexeme revival - sprint 11); removed Special:NewLexeme revival.
Lucas_Werkmeister_WMDE added a comment.


  I looked into this a bit, and I think it’s an unfortunate effect of some 
confusing class functionality in Wikibase. There are two relevant 
`FallbackLabelDescriptionLookup` implementations: 
`LanguageFallbackLabelDescriptionLookup`, which looks up labels and 
descriptions using an inner `TermLookup` while applying language fallbacks, and 
`CachingFallbackLabelDescriptionLookup`, which wraps another 
`FallbackLabelDescriptionLookup` and adds caching to it.
  
  One thing `CachingFallbackLabelDescriptionLookup` does that isn’t exactly 
obvious from its name is that it also resolves redirects. The code to do this 
(based on `EntityRevisionLookup`) used to be directly in the class, until it 
was extracted into a separate RedirectResolvingLatestRevisionLookup class 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/567020> for 
T196882 <https://phabricator.wikimedia.org/T196882>.
  
  Both of these `FallbackLabelDescriptionLookup` implementations are 
instantiated in various places. Some places wrap a 
`CachingFallbackLabelDescriptionLookup` around a 
`LanguageFallbackLabelDescriptionLookup`, others return a 
`LanguageFallbackLabelDescriptionLookup` directly. Because only 
`CachingFallbackLabelDescriptionLookup` resolves redirects, this means that 
only the former places will show the labels of redirect targets – more or less 
arbitrarily, I think.
  
  Places that create a wrapping `CachingFallbackLabelDescriptionLookup` (good):
  
  - `FormatterLabelDescriptionLookupFactory`, used to format entity ID values 
(I think)
  - `WikibaseValueFormatterBuilders` likewise(?)
  
  Places that directly return a `LanguageFallbackLabelDescriptionLookup` (bad):
  
  - `LanguageFallbackLabelDescriptionLookupFactory` (I suppose that’s to be 
expected), which in turn is used in //many// places
  - `WikibaseLexeme.datatypes.php` `PT:wikibase-lexeme` 
`formatter-factory-callback` (has a TODO to use 
`LanguageFallbackLabelDescriptionLookupFactory` which wouldn’t really help at 
the moment, per above), used to format the language and lexical category in the 
tooltip (`title`) of Lexeme values (I think)
- (the `PT:wikibase-form` `formatter-factory-callback` uses 
`LanguageFallbackLabelDescriptionLookupFactory`, though)
  - `WikibaseRepo.entitytypes.php` `item` 
`ENTITY_ID_HTML_LINK_FORMATTER_CALLBACK` – I **think** this is the one that’s 
actually used by `LexemeView` to render the language and lexical category
  - `WikibaseLexeme.entitytypes.repo.php` `lexeme` (and `form`) 
`ENTITY_ID_HTML_LINK_FORMATTER_CALLBACK`
  - `WikibaseClient.ServiceWiring` `SidebarLinkBadgeDisplay`, probably unrelated
  
  I don’t know if there’s actually any good reason why these shouldn’t use 
`CachingFallbackLabelDescriptionLookup` as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T305032

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I don’t think we should use wikidiff2, though. The inline diff functions 
don’t seem useful for us, since we want to show a side-by-side diff:
  
>>> wikidiff2_inline_diff( 'This is a example', 'This is an example', 2 )
=> """
   \n
   This is aan 
example\n
   """
  
>>> wikidiff2_inline_json_diff( 'This is a example', 'This is an example', 
2 )
=> "{"diff": [{"type": 3, "lineNumber": 1, "text": "This is aan example", 
"offset": {"from": 0,"to": 0}, "highlightRanges": [{"start": 8, "length": 1, 
"type": 1 },{"start": 9, "length": 2, "type": 0 }]}]}"
  
  And the regular diff contains too much extra HTML that we’d have to strip out 
again (the `` numbers get localized later 
<https://gerrit.wikimedia.org/g/mediawiki/core/+/f08bdf947001f261ffa5707686bf8b079741193b/includes/diff/DifferenceEngine.php#1567>,
 but make no sense in our context):
  
>>> wikidiff2_do_diff( 'This is a example', 'This is an example', 2 )
=> """
   \n
 \n
 \n
   \n
   \n
 \n
 This is a example\n
 \n
 This is an example\n
   \n
   """
  
  Let’s just stick to `WordLevelDiff` for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Ohhh, of course, wikitext diffs can use wikidiff2 
<https://www.mediawiki.org/wiki/Wikidiff2> or an external `diff` executable, 
not necessarily `WordLevelDiff`…

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Hm, but on Beta 
<https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Lucas_Werkmeister_(WMDE)/sandbox=552154=552153>,
 the space isn’t included in a wikitext word-level diff either.
  F35306077: image.png <https://phabricator.wikimedia.org/F35306077>

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Hm, on my local wiki I get this behavior for wikitext diffs as well:
  F35306037: image.png <https://phabricator.wikimedia.org/F35306037>
  But not on Wikipedia 
<https://en.wikipedia.org/w/index.php?title=User:Lucas_Werkmeister_(WMDE)/sandbox=1096580601=1096580594=source>:
  F35306047: image.png <https://phabricator.wikimedia.org/F35306047>
  Not sure what’s going on here…

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Example diffs on Beta:
  
  - label and description 
<https://wikidata.beta.wmflabs.org/w/index.php?title=Q611640=revision=1305338=1305336>
  - sitelink title 
<https://wikidata.beta.wmflabs.org/w/index.php?title=Q611640=1305340=1305339>

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) 
on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Lucas_Werkmeister_WMDE added a comment.


  Should be verifiable on Beta soon; will only be deployed to production around 
July 20 (no deployment train next week).

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311224: Look into best way forward for word-level diff in Wikibase

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the 
Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T311224

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Tacsipacsi, Aklapper, ItamarWMDE, Addshore, Manuel, 
Lydia_Pintscher, Stang, Lucas_Werkmeister_WMDE, noarave, Hellket777, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-05 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T311224: Look into best way forward for 
word-level diff in Wikibase as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311307: Add debug logging for item terms storage after merging

2022-07-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T311307#8049035 <https://phabricator.wikimedia.org/T311307#8049035>, 
@gerritbot wrote:
  
  > Change 810921 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  >
  > [mediawiki/extensions/Wikibase@master] Add debug logging for term storage 
cleanup
  >
  > https://gerrit.wikimedia.org/r/810921
  
  Sorry, disregard, I meant to attach that to T309445 
<https://phabricator.wikimedia.org/T309445>. This task is done and should stay 
closed.

TASK DETAIL
  https://phabricator.wikimedia.org/T311307

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-07-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Coming back to José Barreto for a moment, since that item hasn’t been edited 
yet and is still missing the terms: The missing alias («José Alberto Barreto», 
Spanish) is not only missing from the term store as a whole; it’s not even 
present in the innermost text table:
  
MariaDB [wikidatawiki]> SELECT * FROM wbt_text WHERE wbx_text = 'José 
Alberto Barreto';
Empty set (0.001 sec)
  
  (And just to confirm that this isn’t an input encoding issue with the é – the 
text without the middle name works:)
  
MariaDB [wikidatawiki]> SELECT * FROM wbt_text WHERE wbx_text = 'José 
Barreto';
+--+---+
| wbx_id   | wbx_text  |
+--+---+
| 18515003 | José Barreto  |
+--+---+
1 row in set (0.001 sec)
  
  But there is a trace of this alias in `wbt_term_in_lang` and 
`wbt_item_terms`! Success!!
  
MariaDB [wikidatawiki]> SELECT wbit_item_id, wbit_term_in_lang_id, 
wby_name, wbtl_text_in_lang_id, wbxl_id FROM wbt_item_terms LEFT JOIN 
wbt_term_in_lang ON wbit_term_in_lang_id = wbtl_id LEFT JOIN wbt_type ON 
wbtl_type_id = wby_id LEFT JOIN wbt_text_in_lang ON wbtl_text_in_lang_id = 
wbxl_id LEFT JOIN wbt_text ON wbxl_text_id = wbx_id WHERE wbit_item_id IN 
(61827465) AND wbxl_id IS NULL;

+--+--+--+--+-+
| wbit_item_id | wbit_term_in_lang_id | wby_name | wbtl_text_in_lang_id | 
wbxl_id |

+--+--+--+--+-+
| 61827465 |951539057 | alias|946668473 |   
 NULL |

+--+--+--+--+-+
1 row in set (0.002 sec)
  
  So we must have some race condition here, where the `wbt_text_in_lang` (and 
`wbt_text`) gets cleaned up in parallel to its being used for a new 
`wbt_term_in_lang` (and `wbt_item_terms`) row.

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-07-04 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Okay, I found another broken merge. Museo diocesano di Capua 
<https://www.wikidata.org/w/index.php?title=Q21196221=1671017251=1559840158>
 gained an Italian alias through a merge, but in the entityterms API 
<https://www.wikidata.org/w/api.php?action=query=json=entityterms=Q21196221=2=it>
 (and in the term store) it’s missing. However, in logstash 
<https://logstash.wikimedia.org/goto/b7e836966d8583728a0d542ab28eaae5>, there 
are only two `WikibaseTerms` events for this ID:
  
  - 09:58:28.607 UTC: schedule `saveTermsOfEntity` for Q21196221
  - 09:58:28.813 UTC: run `saveTermsOfEntity` for Q21196221
  
  In the full log events for this request ID 
<https://logstash.wikimedia.org/goto/679396f7a210051aa4fe8ed4adbf12d8>, we see 
a few more events:
  
  - Transaction spent 9ms in writes, under the 3s limit
  - schedule `saveTermsOfEntity` for Q55386461
  - run `saveTermsOfEntity` for Q55386461
  - schedule `saveTermsOfEntity` for Q21196221
  - Possibly redundant parse
  - run `saveTermsOfEntity` for Q21196221
  - schedule `deleteTermsOfEntity` for Q55386461
  - Possibly redundant parse
  - Possibly redundant parse
  
  (In this order – i.e. the Q55386461 `saveTermsOfEntity` //runs// before the 
Q21196221 one is scheduled!)
  
  There is no trace of an error here. So I think we’re looking at two (or more) 
separate issues here: as mentioned in T309445#8039853 
<https://phabricator.wikimedia.org/T309445#8039853>, sometimes writing the 
terms fails due to a database error, and it’s a bug that we don’t retry it; but 
also, unrelatedly, sometimes the terms don’t end up in the term store even 
though `ItemTermStoreWriterAdapter::saveTermsOfEntity` does //not// detect any 
error.
  
  I wonder if this is due to the fact that we’re making several edits (remove 
data from old item, add data to new item, redirect old item to new item) in one 
API request? At least, I assume that explains why we’re seeing some secondary 
data updates run before others are scheduled, and I could imagine that this 
causes some confusion.

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311812: Running PHPCS via Composer broken since July 2022

2022-07-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T311812

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: TheresNoTime, Aklapper, Jakob_WMDE, Lucas_Werkmeister_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, 
bd808
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-07-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T303317#8043724 <https://phabricator.wikimedia.org/T303317#8043724>, 
@gerritbot wrote:
  
  > Change 810315 had a related patch set uploaded (by Noa wmde; author: Noa 
wmde):
  >
  > [mediawiki/extensions/Wikibase@master] Use WordLevelDiff for 
Labels/Description/Aliases
  >
  > https://gerrit.wikimedia.org/r/810315
  
  This implements word-level diffs for the contents of labels, descriptions, 
and aliases. I think diffing the titles of sitelink changes would also be 
fairly doable; diffing statements feels like more work to me, both to define 
(should we diff the labels of item values word by word, or just treat the whole 
thing as one change, because after all the whole item value was changed to a 
different ID) and to implement. Should either of those be part of this task as 
well?

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Hellket777, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311812: Running PHPCS via Composer broken since July 2022

2022-07-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Let’s leave the task open for a few more hours, since I think it might be 
helpful for other projects having the same issue; otherwise, I think we’re done 
here.

TASK DETAIL
  https://phabricator.wikimedia.org/T311812

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: TheresNoTime, Aklapper, Jakob_WMDE, Lucas_Werkmeister_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, 
bd808
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311812: Running PHPCS via Composer broken since July 2022

2022-07-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T311812#8043319 <https://phabricator.wikimedia.org/T311812#8043319>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > So far, we’ve noticed this in Wikibase builds, but I wouldn’t be surprised 
if there are others. #mediawiki-extensions-translate 
<https://phabricator.wikimedia.org/tag/mediawiki-extensions-translate/> also 
seems to use `SlevomatCodingStandard.*` sniffs, for example.
  
  Hm, no, Translate still seems to work, both in CI (gate-and-submit for this 
random change 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/807575>) and 
locally. Not sure why.

TASK DETAIL
  https://phabricator.wikimedia.org/T311812

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Jakob_WMDE, Lucas_Werkmeister_WMDE, Hellket777, Astuthiodit_1, 
786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, bd808
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311812: Running PHPCS via Composer broken since July 2022

2022-07-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T311812

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Jakob_WMDE, Lucas_Werkmeister_WMDE, Hellket777, Astuthiodit_1, 
786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, bd808
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311812: Running PHPCS via Composer broken since July 2022

2022-07-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  So far, we’ve noticed this in Wikibase builds, but I wouldn’t be surprised if 
there are others. #mediawiki-extensions-translate 
<https://phabricator.wikimedia.org/tag/mediawiki-extensions-translate/> also 
seems to use `SlevomatCodingStandard.*` sniffs, for example.

TASK DETAIL
  https://phabricator.wikimedia.org/T311812

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Jakob_WMDE, Lucas_Werkmeister_WMDE, Hellket777, Astuthiodit_1, 
786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, bd808
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311812: Running PHPCS via Composer broken since July 2022

2022-07-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  composer really said
  F35293211: composer.png <https://phabricator.wikimedia.org/F35293211>

TASK DETAIL
  https://phabricator.wikimedia.org/T311812

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Jakob_WMDE, Lucas_Werkmeister_WMDE, Hellket777, Astuthiodit_1, 
786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, Djdungti, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Jdforrester-WMF, Mbch331, bd808
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311812: Running PHPCS via Composer broken since July 2022

2022-07-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, ci-test-error (WMF-deployed 
Build Failure), Composer.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  First observed in this CI build 
<https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/161166/console>:
  
> composer phpcs
composer/installers contains a Composer plugin which is blocked by your 
allow-plugins config. You may add it to the list if you consider it safe. See 
https://getcomposer.org/allow-plugins
You can run "composer config --no-plugins allow-plugins.composer/installers 
[true|false]" to enable it (true) or keep it disabled and suppress this warning 
(false)
dealerdirect/phpcodesniffer-composer-installer contains a Composer plugin 
which is blocked by your allow-plugins config. You may add it to the list if 
you consider it safe. See https://getcomposer.org/allow-plugins
You can run "composer config --no-plugins 
allow-plugins.dealerdirect/phpcodesniffer-composer-installer [true|false]" to 
enable it (true) or keep it disabled and suppress this warning (false)
> phpcs -p -s
ERROR: Referenced sniff 
"SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing" does not exist

Run "phpcs --help" for usage information

Script phpcs -p -s handling the phpcs event returned with error code 3
Script composer phpcs handling the test event returned with error code 3
  
  Somehow, the `slevomat/coding-standard` package doesn’t get installed quite 
properly (though it is in the composer install output), and then PHPCS crashes 
when it can’t load the sniff referenced in the PHPCS file. According to the 
quoted composer output, this seems to be due to the changed default of the 
allow-plugins config <https://getcomposer.org/doc/06-config.md#allow-plugins>, 
where composer decided it was a great idea to have the default behavior change 
based on the calendar date, even if you install the same software version where 
everything worked previously. (See also T298283 
<https://phabricator.wikimedia.org/T298283>.)

TASK DETAIL
  https://phabricator.wikimedia.org/T311812

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Jakob_WMDE, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Djdungti, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, bd808
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Parents / Waiting to Doing on the 
Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Lucas_Werkmeister_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311224: Look into best way forward for word-level diff in Wikibase

2022-06-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a subscriber: Michael.
Lucas_Werkmeister_WMDE added a comment.


  @Michael and I looked at `WordLevelDiff` and `TableDiffFormatter` and 
concluded that `TableDiffFormatter` isn’t very useful to us, but marking 
`WordLevelDiff` as `@newable` should be acceptable, under the same conditions 
as its parent class `Diff` (namely, that T257472 
<https://phabricator.wikimedia.org/T257472> wants to eventually introduce a 
factory for it, at which point `Diff` should no longer be newable).

TASK DETAIL
  https://phabricator.wikimedia.org/T311224

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Tacsipacsi, Aklapper, ItamarWMDE, Addshore, Manuel, 
Lydia_Pintscher, Stang, Lucas_Werkmeister_WMDE, noarave, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311224: Look into best way forward for word-level diff in Wikibase

2022-06-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the 
Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T311224

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Tacsipacsi, Aklapper, ItamarWMDE, Addshore, Manuel, Lydia_Pintscher, Stang, 
Lucas_Werkmeister_WMDE, noarave, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Although I //still// don’t see an exception corresponding to José Barreto 
<https://www.wikidata.org/w/index.php?title=Q61827465=1665692558=1654605108>
 (from T309445#8023533 <https://phabricator.wikimedia.org/T309445#8023533>), 
even when just looking through all the errors for that time regardless of item 
ID or other search terms.
  
  I guess I should look for some missing labels from merges after we deployed 
this logging, and see if there are any without corresponding log events.
  
  (If this is really due to locking errors as above, then I think in principle 
it could happen on any edit, but I guess merges make it much more likely that 
there’s a conflict around the same terms being removed somewhere and added 
elsewhere at the same time.)

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T309445#8028484 <https://phabricator.wikimedia.org/T309445#8028484>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > …and while working on adding the logging, I suddenly find this:
  >
  > name=ItemTermStoreWriterAdapter::saveTermsOfEntity()
  > if ( $entity instanceof Item ) {
  > try {
  > $this->store->storeTerms( $entity->getId(), 
$entity->getFingerprint() );
  > return true;
  > } catch ( TermStoreException $ex ) {
  > return false;
  > }
  > }
  >
  > Small wonder there’s no trace of errors in Logstash…
  
  This turns out to be a red herring, there’s no code that actually throws this 
exception type. However, we can now see **uncaught exceptions** in logstash – 
they get logged to the normal mediawiki-errors board as well, we just didn’t 
find them before because they don’t include the item ID anywhere in the request 
URL or stack trace. These seem to happen in bursts – for example, 45 of them 
all between 5:19 and 5:26 AM today
  F35289127: image.png <https://phabricator.wikimedia.org/F35289127>
  – and the error seems to be consistent:
  
Error 1205: Lock wait timeout exceeded; try restarting transaction
Function: 
Wikibase\Lib\Store\Sql\Terms\DatabaseTermStoreWriterBase::acquireAndInsertTerms
Query: SELECT  wbit_term_in_lang_id AS `value`  FROM `wbt_item_terms`
WHERE wbit_item_id = 41443421   FOR UPDATE
  
  This can happen – I think we need to wrap the deferred update in a try/catch 
block and reschedule the update as a job if it fails. (And then rethrow the 
exception, so MediaWiki knows there was a DB error.) I guess when we wrote this 
code we might have assumed that MediaWiki did this automatically?
  
  (We might also reconsider if the `FOR UPDATE` there is necessary, but I think 
that would be a larger project to change.)

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311307: Add debug logging for item terms storage after merging

2022-06-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the 
Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Lucas_Werkmeister_WMDE added a comment.


  The logging is working fine, see the mediawiki dashboard with the channel set 
to WikibaseTerms 
<https://logstash.wikimedia.org/goto/900a16ea32cbc7224a48affdd8e3298a>.

TASK DETAIL
  https://phabricator.wikimedia.org/T311307

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-30 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T311307: Add debug logging for item terms 
storage after merging as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T308659: Validate lemma length in Special:NewLexeme(Alpha) and label/description/aliases length in Special:NewProperty (CVE-2022-34750)

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the 
Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Lucas_Werkmeister_WMDE added a comment.


  I think we’re done here (but please reopen if the task should still be open 
for security release process purposes).

TASK DETAIL
  https://phabricator.wikimedia.org/T308659

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6005/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: MoritzMuehlenhoff, Zabe, sbassett, Erdinc_Ciftci_WMDE, Michael, ItamarWMDE, 
guergana.tzatchkova, noarave, karapayneWMDE, Manuel, Lydia_Pintscher, Aklapper, 
Lucas_Werkmeister_WMDE, Hellket777, Astuthiodit_1, 786, Biggs657, Invadibot, 
Devnull, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CDanis, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, Wong128hk, Luke081515, 
Wikidata-bugs, aude, Bawolff, Grunny, csteipp, Mbch331, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T308659: Validate lemma length in Special:NewLexeme(Alpha) and label/description/aliases length in Special:NewProperty (CVE-2022-34750)

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Backported the patches to REL1_35 and REL1_37 (1.36 is out of support). 
Leaving the task open for review of the cleanup patch 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/809203> 
(which doesn’t need backporting).

TASK DETAIL
  https://phabricator.wikimedia.org/T308659

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: MoritzMuehlenhoff, Zabe, sbassett, Erdinc_Ciftci_WMDE, Michael, ItamarWMDE, 
guergana.tzatchkova, noarave, karapayneWMDE, Manuel, Lydia_Pintscher, Aklapper, 
Lucas_Werkmeister_WMDE, Hellket777, Astuthiodit_1, 786, Biggs657, Invadibot, 
Devnull, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CDanis, DannyS712, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, Wong128hk, Luke081515, 
Wikidata-bugs, aude, Bawolff, Grunny, csteipp, Mbch331, Jay8g, Krenair, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311640: Wikibase\MediaInfo\Tests\Integration\MultiLingualCaptionsTest::testEditCaptions test failure on REL1_35

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Mainly just creating this “for the record”; assuming that not many more 
REL1_35 backports will be needed before that version falls out of support in 
September 2023, IMHO it’s acceptable to do nothing about this and close it when 
REL1_35 is gone.

TASK DETAIL
  https://phabricator.wikimedia.org/T311640

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, toberto, 
Invadibot, maantietaja, CBogen, ItamarWMDE, Akuckartz, RhinosF1, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Ricordisamoa, 
Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311640: Wikibase\MediaInfo\Tests\Integration\MultiLingualCaptionsTest::testEditCaptions test failure on REL1_35

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, WikibaseMediaInfo, 
ci-test-error, MW-1.35-release.
Restricted Application added a subscriber: Aklapper.
Restricted Application added projects: Structured-Data-Backlog, wdwb-tech.

TASK DESCRIPTION
  Seen here 
<https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php74-noselenium-docker/22113/console>
 for security backport 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/809604>.
  
1) 
Wikibase\MediaInfo\Tests\Integration\MultiLingualCaptionsTest::testEditCaptions
ApiUsageException: The file you submitted was empty.

/workspace/src/includes/api/ApiUsageException.php:71
/workspace/src/includes/api/ApiBase.php:1438
/workspace/src/includes/api/ApiUpload.php:648
/workspace/src/includes/api/ApiUpload.php:616
/workspace/src/includes/api/ApiUpload.php:87
/workspace/src/includes/api/ApiMain.php:1593
/workspace/src/includes/api/ApiMain.php:498
/workspace/src/tests/phpunit/includes/api/ApiTestCase.php:109

/workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/integration/WBMIApiTestCase.php:63

/workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/integration/WBMIApiTestCase.php:115

/workspace/src/extensions/WikibaseMediaInfo/tests/phpunit/integration/MultiLingualCaptionsTest.php:28
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:446
/workspace/src/maintenance/doMaintenance.php:107
=== Logs generated by test case
[objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"EmptyBagOStuff"}
[localisation] [debug] LocalisationCache using store LCStoreNull []
[localisation] [debug] LocalisationCache using store LCStoreNull []
[MessageCache] [debug] MessageCache using store {class} 
{"class":"HashBagOStuff"}
[objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"EmptyBagOStuff"}
[UserOptionsManager] [debug] Loading options from database {"user_id":1}
[GlobalTitleFail] [info] RequestContext::getTitle called with no title set. 
{"exception":{}}
[DeferredUpdates] [debug] DeferredUpdates::run: started 
MWCallableUpdate_EchoHooks::onUserSaveSettings #420693 []
[DeferredUpdates] [debug] DeferredUpdates::run: ended 
MWCallableUpdate_EchoHooks::onUserSaveSettings #420693 []
[localisation] [debug] LocalisationCache::isExpired(en): cache missing, 
need to make one []
[DeferredUpdates] [debug] DeferredUpdates::run: started CdnCacheUpdate 
#420699 []
[squid] [info] CdnCacheUpdate::purge: 
http://127.0.0.1:9413/index.php/User:UTSysop 
http://127.0.0.1:9413/index.php?title=User:UTSysop=history 
{"private":false}
[DeferredUpdates] [debug] DeferredUpdates::run: ended CdnCacheUpdate 
#420699 []
[CentralAuthVerbose] [info] Loading state for global user TestUser 
f7c0c2.3ec from DB {"private":false}
[CentralAuthVerbose] [info] Loading attached wiki list for global user 
TestUser f7c0c2.3ec from DB {"private":false}
[CentralAuthVerbose] [info] Loading groups for global user TestUser 
f7c0c2.3ec {"private":false}
[objectcache] [debug] 
fetchOrRegenerate(global:centralauth-user:5b1af119f9e8e2b806444dc5c022214e): 
miss, new value computed []
[CentralAuthVerbose] [info] Loading CentralAuthUser for user TestUser 
f7c0c2.3ec from cache object {"private":false}
[localisation] [debug] LocalisationCache using store LCStoreNull []
[localisation] [debug] LocalisationCache using store LCStoreNull []
[objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"EmptyBagOStuff"}
[CentralAuthVerbose] [info] Loading state for global user Apitesteditor 
from DB {"private":false}
[CentralAuthVerbose] [info] Loading attached wiki list for global user 
Apitesteditor from DB {"private":false}
[CentralAuthVerbose] [info] Loading groups for global user Apitesteditor 
{"private":false}
[objectcache] [debug] 
fetchOrRegenerate(global:centralauth-user:c7c3ce6008fd368830a3ed99b27f34a9): 
miss, new value computed []
[CentralAuthVerbose] [info] Loading CentralAuthUser for user Apitesteditor 
from cache object {"private":false}
[localisation] [debug] LocalisationCache using store LCStoreNull []
[objectcache] [debug] MainWANObjectCache using store {class} 
{"class":"EmptyBagOStuff"}
[MessageCache] [debug] MessageCache using store {class} 
{"class":"HashBagOStuff"}
[localisation] [debug] LocalisationCache::isExpired(en): cache missing, 
need to make one []
[GlobalTitleFail] [info] RequestContext::getTitle called with no title set. 
{"exception":{}}
[authevents] [info] Login attempt 
{"event":"login","successful&q

[Wikidata-bugs] [Maniphest] T311626: Language name of mul language (“multiple languages”) inconsistently used in termboxes

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Campsite (Team A 
Hearth ).

TASK DESCRIPTION
  John Doe II <https://test.wikidata.org/wiki/Q57591> is a Test Wikidata item 
with a `mul` label (and no other labels).
  
  - In English <https://test.wikidata.org/wiki/Q57591?uselang=en>, the heading 
uses the language name “multiple languages”, but the table (once you show “all 
entered languages”) uses the language name “mul”.
  - In British English <https://test.wikidata.org/wiki/Q57591?uselang=en-gb>, 
the result is the same.
  - In German <https://test.wikidata.org/wiki/Q57591?uselang=de>, the heading 
uses the language name „Mehrsprachig“, but the table uses the language name 
“mul”
  - In mul <https://test.wikidata.org/wiki/Q57591?uselang=mul>, the heading 
doesn’t show a language name (because it’s not a language fallback in this 
case), but the table uses the language name “multiple languages”.
  
  I find this baffling. Why is the specifically English 
<https://gerrit.wikimedia.org/g/mediawiki/extensions/cldr/+/6f74f8389c8d1d824bb2f12c7c55f7dbbd46755e/LocalNames/LocalNamesEn.php#193>
 name “multiple languages” only used when the page is loaded in `mul`, but 
//not// in English itself, nor in any other language?
  
  Meanwhile, on mobile <https://test.m.wikidata.org/wiki/Q57591>, the termbox 
(mobile termbox, new termbox, termbox v2, etc.) always seems to use “mul” as 
the language name – except in mul 
<https://test.m.wikidata.org/wiki/Q57591?uselang=mul>, where you can briefly 
see the language name “multiple languages” before it gets replaced by JS with 
just “mul”.

TASK DETAIL
  https://phabricator.wikimedia.org/T311626

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Manuel, Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306918: Prohibit duplication of mul labels in other languages

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T306918#7884900 <https://phabricator.wikimedia.org/T306918#7884900>, 
@Lydia_Pintscher wrote:
  
  > Thing to consider: Should/could this be done with an abuse filter?
  
  I doubt this could be done with an AbuseFilter – I don’t think the filter 
gets access to the existing item data (the mul label) that wasn’t touched in 
the edit.

TASK DETAIL
  https://phabricator.wikimedia.org/T306918

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Mahir256, Manuel, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306918: Prohibit duplication of mul labels in other languages

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I think we can implement this in much the same way as the blocking of 
identical labels and descriptions (T212869 
<https://phabricator.wikimedia.org/T212869>).

TASK DETAIL
  https://phabricator.wikimedia.org/T306918

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Nikki, Mahir256, Manuel, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311617: Wikibase classic termbox (entity terms view) sometimes reorders user babel languages

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Campsite (Team A 
Hearth ).

TASK DESCRIPTION
  When I load https://test.wikidata.org/wiki/Q172818?uselang=mul, the termbox 
initially shows the languages `mul`, `en`, `de`, `pt`, but then JS runs and 
they get reordered into `mul`, `de`, `en`, `pt` – English and German switch 
places. (My Babel is currently `de-N`, `en-4`, `pt-1`.) There is also an 
accompanying console warning:
  
  > Existing entitytermsforlanguagelistview DOM does not match configured 
languages
  
  This needs to be looked into. (I thought I’d fixed this with T307808 
<https://phabricator.wikimedia.org/T307808>, but clearly there’s still some 
remaining issue.)

TASK DETAIL
  https://phabricator.wikimedia.org/T311617

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Manuel, Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307808: Wikibase classic termbox (entity terms view) drops last user babel language if interface language is not in babel

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Product Verification to Our work 
done on the Wikidata-Campsite (Team A Hearth ) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T307808

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5612/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Manuel, Lydia_Pintscher, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T297393: Implement basic version of mul language code and deploy to Test Wikidata

2022-06-29 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T307808: Wikibase classic termbox (entity 
terms view) drops last user babel language if interface language is not in 
babel as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T297393

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ChristianKl, Bugreporter, Aklapper, Lydia_Pintscher, Manuel, 
Lucas_Werkmeister_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, RhinosF1, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Nikki, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307957: Fix SVG export for maps in WDQI UI

2022-06-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  FWIW, I think the most realistic “fix” for this is that we disable the SVG 
download for maps. I don’t know if it’s even possible to save a Leaflet map as 
an SVG image without horrible hacks (e.g. leaflet-image 
<https://github.com/mapbox/leaflet-image> says it’s incompatible with 
`Leaflet.markercluster`, which is what we use for markers IIRC), and it would 
likely be a major effort at least.
  
  I think several other result views don’t support being downloaded as SVG 
either (probably including the table view); as far as I’m aware, the SVG 
download option is mainly, and perhaps only, useful for the “chart” result 
views (line, scatter, bar, etc.).

TASK DETAIL
  https://phabricator.wikimedia.org/T307957

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, ItamarWMDE, Gehel, Addshore, Aklapper, Bouzinac, 
Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, 
CBogen, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, 
Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311409: Wikibase needs special handling for translatable pages

2022-06-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  The output of Special:UnconnectedPages is determined by the 
`unexpectedUnconnectedPage` page prop, which 
`ClientParserOutputDataUpdater::setUnexpectedUnconnectedPage()` sets for any 
content that is neither
  
  - connected to an item, nor
  - a redirect, nor
  - has the `expectedUnconnectedPage` page prop set.
  
  I guess we could insert a hook here, so that Translate can tell Wikibase to 
not consider the page “unexpected(ly) unconnected”. Or is there a relevant 
standard method directly on the `Content` or `ParserOutput`?

TASK DETAIL
  https://phabricator.wikimedia.org/T311409

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Nikerabbit, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311307: Add debug logging for item terms storage after merging

2022-06-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) 
on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Lucas_Werkmeister_WMDE added a comment.


  Can be tech-verified (look for the new channel in logstash) once wmf.18 
reaches Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T311307

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5983/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Peer Review to Parents / Waiting on 
the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Lucas_Werkmeister_WMDE added a comment.


  It looks like the new profile isn’t fully working yet, at least when used via 
the maintenance script – I get the same results for “Engl” with or without the 
maintenance script:
  
lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en --profile-context language_selector_prefix 
<< /dev/null | jq '.rows | .[] | .snippets | { term, type, text }'
{
  "term": "Engl",
  "type": "label",
  "text": "family name"
}
{
  "term": "ENGL",
  "type": "alias",
  "text": "protein-coding gene in the species Homo sapiens"
}
{
  "term": "English",
  "type": "label",
  "text": "West Germanic language"
}
{
  "term": "England",
  "type": "label",
  "text": "country in north-west Europe, part of the United Kingdom"
}
{
  "term": "English Wikipedia",
  "type": "label",
  "text": "English-language edition of Wikipedia"
}
lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en << /dev/null | jq '.rows | .[] | 
.snippets | { term, type, text }'
{
  "term": "Engl",
  "type": "label",
  "text": "family name"
}
{
  "term": "ENGL",
  "type": "alias",
  "text": "protein-coding gene in the species Homo sapiens"
}
{
  "term": "English",
  "type": "label",
  "text": "West Germanic language"
}
{
  "term": "England",
  "type": "label",
  "text": "country in north-west Europe, part of the United Kingdom"
}
{
  "term": "English Wikipedia",
  "type": "label",
  "text": "English-language edition of Wikipedia"
}
  
  Same for “Deu”:
  
lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en --profile-context language_selector_prefix 
<< /dev/null | jq '.rows | .[] | .snippets | { term, type, text }'
{
  "term": "Deutsche Eislauf-Union",
  "type": "label",
  "text": "voluntary association"
}
{
  "term": "Deutschland",
  "type": "alias",
  "text": "country in Central Europe"
}
{
  "term": "Deutsch",
  "type": "alias",
  "text": "West Germanic language spoken mainly in Central Europe"
}
{
  "term": "Deutsche Demokratische Republik",
  "type": "alias",
  "text": "1949–1990 country in central Europe, unified into modern Germany"
}
{
  "term": "Deutsches Kaiserreich",
  "type": "alias",
  "text": "empire in Central Europe between 1871 and 1918"
}
lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en << /dev/null | jq '.rows | .[] | 
.snippets | { term, type, text }'
{
  "term": "Deutsche Eislauf-Union",
  "type": "label",
  "text": "voluntary association"
}
{
  "term": "Deutschland",
  "type": "alias",
  "text": "country in Central Europe"
}
{
  "term": "Deutsch",
  "type": "alias",
  "text": "West Germanic language spoken mainly in Central Europe"
}
{
  "term": "Deutsche Demokratische Republik",
  "type": "alias",
  "text": "1949–1990 country in central Europe, unified into modern Germany"
}
{
  "term": "Deutsches Kaiserreich",
  "type": "alias",
  "text": "empire in Central Eu

[Wikidata-bugs] [Maniphest] T311410: Append `.index` to tracking namespace in wikibase.queryService.ui.App

2022-06-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  > [ ] move all metrics data in Graphite related to App.js to the .index 
directory
  >   [ ] there should be no longer any data under the old metric names in 
Graphite that could confuse people looking at it later
  
  This sounds like a good state, but for actually doing it, the procedure 
mentioned in T272128#7212540 
<https://phabricator.wikimedia.org/T272128#7212540> – first //copy//, then 
check that the new metric name works, //then// delete the old name – also 
sounds sensible to me. (Though it’s not clear to me whether that procedure was 
actually followed in the end? The SAL message at T272128#7214750 
<https://phabricator.wikimedia.org/T272128#7214750> just says “move”.)

TASK DETAIL
  https://phabricator.wikimedia.org/T311410

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Astuthiodit_1, AWesterinen, 
karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, 
Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, 
merbst, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T302274: INVESTIGATION [Timebox: 4hrs.]: Grafana board for Wikidata Query Service UI not receiving data

2022-06-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I would slightly lean towards A, but both sound okay to me.
  
  The only other tracking I can find is in `QueryExampleDialog`, which is 
outside of “app” (`wikibase.queryService.ui.examples`) and can probably stay as 
it is. (`Banner.js` has a very misleadingly named `trackingNamespace` that 
turns out to be unrelated to Graphite tracking.)

TASK DETAIL
  https://phabricator.wikimedia.org/T302274

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: noarave, ItamarWMDE, Lucas_Werkmeister_WMDE, Manuel, Aklapper, 
Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, 
CBogen, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, 
Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T309445#8023699 <https://phabricator.wikimedia.org/T309445#8023699>, 
@Lydia_Pintscher wrote:
  
  > Does any of the lists of potential merge candidates at 
https://www.wikidata.org/wiki/Help:Merge#Finding_items_to_merge help?
  
  Thanks, I might try some of those later.
  
  
  
  (Aside about localhost: I tried to make my wiki serve API requests in 
parallel more, because I now suspect this is a race condition. Currently, I can 
send requests in parallel and they’ll be processed in parallel, and after 
setting `output_buffering = 0;` in php.init and therefore letting MediaWiki 
taking care of buffering and sending a `Content-Length` response header, the 
browser will also perceive the API requests to have completed as soon as the 
main request is done, so that secondary data updates actually take place 
post-send as expected and can potentially run in parallel to subsequent API 
requests. But for some reason, a `sleep()` in a post-send update will still 
prevent //later// API requests from starting processing, so that post-send 
updates still won’t overlap with requests that came in after the first request 
finished sending the response. It’s possible that session_write_close() 
<https://www.php.net/manual/en/function.session-write-close.php> should help 
with this, or at least that it’s related to sessions – I stopped looking into 
it at this point, and started experimenting on Test Wikidata instead.)
  
  It turns out the merge gadget doesn’t do as many different API things as I 
thought. It has some pre-merge checks and some error handling, but at the API 
level, the merge it does is just:
  
  1. wbmergeitems (with `ignoreconflicts=description`)
  2. purge (“// XXX: Do we even need to purge? Why?”)
  3. load target item
  
  There is no extra API request for blanking the item or anything – if the 
merge makes several edits, they all come from `wbmergeitems`.
  
  If you just create two new items and then merge them with `wbmergeitems` on 
Test Wikidata <https://test.wikidata.org/wiki/Special:BlankPage>, and then 
immediately get their `entityterms`:
  
api = new mw.Api(); now = new Date().toISOString(); item1 = ( await 
api.postWithEditToken( { action: 'wbeditentity', new: 'item', summary: 
'T309445', data: JSON.stringify( { labels: { en: { language: 'en', value: 
`${now} (label)` } } } ) } ) ).entity.id; console.log( item1 ); item2 = ( await 
api.postWithEditToken( { action: 'wbeditentity', new: 'item', summary: 
'T309445', data: JSON.stringify( { descriptions: { en: { language: 'en', value: 
`${now} (description)` } } } ) } ) ).entity.id; console.log( item2 ); await 
api.postWithEditToken( { action: 'wbmergeitems', fromid: item2, toid: item1, 
summary: 'T309445' } ); await api.get( { action: 'query', prop: 'entityterms', 
wbetlanguage: 'en', titles: item1, formatversion: 2 } ).then( r => 
r.query.pages[ 0 ].entityterms );
  
  Then the `entityterms` will fairly often just have the terms of the original 
item (a `label`), without the merged terms of the other item (a `description`). 
But this resolves itself after a second or so (once the secondary data updates 
of the merge finish), and if you repeat the `entityterms` request it’ll show 
all the terms as expected.
  
  So I tried matching the merge gadget more closely, by also purging the page 
and then getting its HTML:
  
api = new mw.Api(); now = new Date().toISOString(); item1 = ( await 
api.postWithEditToken( { action: 'wbeditentity', new: 'item', summary: 
'T309445', data: JSON.stringify( { labels: { en: { language: 'en', value: 
`${now} (label)` } } } ) } ) ).entity.id; console.log( item1 ); item2 = ( await 
api.postWithEditToken( { action: 'wbeditentity', new: 'item', summary: 
'T309445', data: JSON.stringify( { descriptions: { en: { language: 'en', value: 
`${now} (description)` } } } ) } ) ).entity.id; console.log( item2 ); await 
api.postWithEditToken( { action: 'wbmergeitems', fromid: item2, toid: item1, 
summary: 'T309445' } ); await api.post( { action: 'purge', titles: item1 } ); 
await fetch( `https://test.wikidata.org/wiki/${item1}` ); await api.get( { 
action: 'query', prop: 'entityterms', wbetlanguage: 'en', titles: item1, 
formatversion: 2 } ).then( r => r.query.pages[ 0 ].entityterms );
  
  But with this version, the logged `entityterms` are actually always complete 
(at least every time I tried this). It looks like the purge + render gives the 
secondary data updates enough time to finish.
  
  In theory, I think both the merge and the page view could attempt to write 
terms to the term store. (Though I’m not sure if loading an item page that 
isn’t in the parser cache will actually cause the secondary data updates to run 
again.) However, the page view should always have the merged item state, thanks 
to MediaWiki’s ChronologyProtector, so there shouldn’t be any race condition 
there. The only possible race condition I can see at the m

[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  …and while working on adding the logging, I suddenly find this:
  
  name=ItemTermStoreWriterAdapter::saveTermsOfEntity()
if ( $entity instanceof Item ) {
try {
$this->store->storeTerms( $entity->getId(), 
$entity->getFingerprint() );
return true;
} catch ( TermStoreException $ex ) {
return false;
}
}
  
  Small wonder there’s no trace of errors in Logstash…

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311307: Add debug logging for item terms storage after merging

2022-06-27 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the 
Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T311307

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5983/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311307: Add debug logging for item terms storage after merging

2022-06-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Campsite (Team A 
Hearth ), MediaWiki-extensions-WikibaseRepository, Special:NewLexeme revival 
(Special:NewLexeme revival - sprint 10).

TASK DESCRIPTION
  In T309445 <https://phabricator.wikimedia.org/T309445>, we are witnessing 
some strange behavior where the terms of an item aren’t properly updated after 
a merge. We want to find out whether the secondary data updates which are 
supposed to update the terms even take place, by adding some debug logging to 
`ItemHandler::getSecondaryDataUpdates()` and 
`ItemTermStoreWriterAdapter::saveTermsOfEntity()`. This should go to a separate 
channel (like e.g. the `DuplicateParse` channel), which would be configured to 
capture all debug messages. (By default, only messages at level ≥ info go to 
logstash.)

TASK DETAIL
  https://phabricator.wikimedia.org/T311307

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  The simplest explanation for this whole business would be that the secondary 
data updates somehow just don’t happen. I don’t know why this would be – of 
course it’s possible that they crash for some reason, but I’d expect to see 
something in logstash in that case, and I’m not seeing anything – but at this 
point, I think this is a theory worth either confirming or ruling out, by 
**adding some logging.** I suggest that we add a temporary log channel that 
captures messages at any level (like, for example, the `DuplicateParse` 
channel), and make `ItemHandler::getSecondaryDataUpdates()` and 
`ItemTermStoreWriterAdapter::saveTermsOfEntity()` log debug messages indicating 
that the secondary data updates were created and executed, with some basic 
information about the terms being stored (number of labels, descriptions, and 
aliases across all languages; we don’t have access to the revision ID at this 
point, unfortunately).

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I tested it: a regular `index.php?action=purge` or `action.php?action=purge` 
doesn’t trigger secondary data updates, not even when you visit the page 
afterwards; `api.php?action=purge=1` does trigger secondary 
data updates. The merge gadget doesn’t set `forcelinkupdate`, so the secondary 
data updates shouldn’t get triggered by it (other than through the edit).

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-24 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the 
Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5983/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Okay, but after 50 repeats of the code from earlier 
<https://phabricator.wikimedia.org/T309445#7966722> (i.e. 100 items, 50 
merges), I still haven’t been able to reproduce the issue locally once. So now 
I’m back to thinking that the issue doesn’t happen with `wbmergeitems` alone, 
but is related to the combination of API requests the merge gadget makes.
  
  But if it doesn’t happen very often, then trying to find enough merge pairs 
on real Wikidata to test this with might be challenging – porting the merge 
gadget code <https://www.wikidata.org/wiki/MediaWiki:Gadget-Merge.js> to work 
on a local wiki might be more promising.

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Recent merges:
  
  - Perdikas Palaeontological Museum 
<https://www.wikidata.org/w/index.php?title=Q4773891=1665684582=1400305861>:
 the merge added an English alias which //is// present in the term store.
  - Cecilio Angulo 
<https://www.wikidata.org/w/index.php?title=Q56256867=1665696962=1376655670>:
 the merge added a Dutch alias which //is// present in the term store.
  - José Barreto 
<https://www.wikidata.org/w/index.php?title=Q61827465=1665692558=1654605108>:
 the merge added a Spanish alias which //is not// present in the term store.
  - hydrosulfide 
<https://www.wikidata.org/w/index.php?title=Q3771739=1665692289=1627399139>:
 the merge added a Uzbek label which //is// present in the term store.
  - Kummerower See 
<https://www.wikidata.org/w/index.php?title=Q688154=1665692403=1549397177>:
 the merge added a Serbian label which //is// present in the term store.
  
  So the issue still seems to happen occasionally (José Barreto), but not all 
the time, and in fact not even most of the time.

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Found and merged another pair 
<https://www.wikidata.org/w/index.php?title=Q111854511=1665692028=1646443234>,
 again unable to reproduce the issue:
  
  name=before merge
MariaDB [wikidatawiki]> SELECT wbit_item_id, wby_name, wbx_text, 
wbxl_language FROM wbt_item_terms JOIN wbt_term_in_lang ON wbit_term_in_lang_id 
= wbtl_id JOIN wbt_type ON wbtl_type_id = wby_id JOIN wbt_text_in_lang ON 
wbtl_text_in_lang_id = wbxl_id JOIN wbt_text ON wbxl_text_id = wbx_id WHERE 
wbit_item_id IN (111854511, 112670581);

+--+-+-+---+
| wbit_item_id | wby_name| wbx_text 

   | wbxl_language |

+--+-+-+---+
|111854511 | label   | Hum3D

   | en|
|111854511 | description | Hum3D sells high quality 3D models, which 
are all made by themselves. They have the biggest collection of cars on the 
Internet. | en|
|112670581 | label   | Hum3D

   | en|
|112670581 | label   | Hum3D

   | uk|

+--+-+-+---+
4 rows in set (0.004 sec)
  
  name=after merge
MariaDB [wikidatawiki]> SELECT wbit_item_id, wby_name, wbx_text, 
wbxl_language FROM wbt_item_terms JOIN wbt_term_in_lang ON wbit_term_in_lang_id 
= wbtl_id JOIN wbt_type ON wbtl_type_id = wby_id JOIN wbt_text_in_lang ON 
wbtl_text_in_lang_id = wbxl_id JOIN wbt_text ON wbxl_text_id = wbx_id WHERE 
wbit_item_id IN (111854511, 112670581);

+--+-+-+---+
| wbit_item_id | wby_name| wbx_text 

   | wbxl_language |

+--+-+-+---+
|111854511 | label   | Hum3D

   | en|
|111854511 | description | Hum3D sells high quality 3D models, which 
are all made by themselves. They have the biggest collection of cars on the 
Internet. | en|
|111854511 | label   | Hum3D

   | uk|

+--+-+-+---+
3 rows in set (0.001 sec)
  
  (Both had the same English label, so two of the rows got merged into one. But 
all the terms are still there.)
  
  Might be time to look at other recent merges and see if this issue still 
happens at all. Previously I was under the impression that it seemed to happen 
fairly reliably – I hadn’t found any merges where it didn’t happen…

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Managed to find a pair of duplicates via the recent changes tagged as 
sitelink change from connected wiki 
<https://www.wikidata.org/wiki/Special:RecentChanges?hidepageedits=1=1=1=client-linkitem-change=500=3=1=2>
 (the dewiki and ptwiki articles were clearly translations of one another, with 
a left parenthesis missing in the same place in both) and merged them 
<https://www.wikidata.org/w/index.php?title=Q112664122=1665686076=1664718451>
 using the merge gadget. I was //not// able to reproduce the issue.
  
  name=before merge
MariaDB [wikidatawiki]> SELECT wbit_item_id, wby_name, wbx_text, 
wbxl_language FROM wbt_item_terms JOIN wbt_term_in_lang ON wbit_term_in_lang_id 
= wbtl_id JOIN wbt_type ON wbtl_type_id = wby_id JOIN wbt_text_in_lang ON 
wbtl_text_in_lang_id = wbxl_id JOIN wbt_text ON wbxl_text_id = wbx_id WHERE 
wbit_item_id IN (112664122, 112671429);
+--+--+--+---+
| wbit_item_id | wby_name | wbx_text | wbxl_language |
+--+--+--+---+
|112664122 | label| Vyeyra   | de|
|112671429 | label| Vyeyra   | es|
|112671429 | label| Vyeyra   | pt|
+--+--+--+---+
3 rows in set (0.005 sec)
  
  name=after merge
MariaDB [wikidatawiki]> SELECT wbit_item_id, wby_name, wbx_text, 
wbxl_language FROM wbt_item_terms JOIN wbt_term_in_lang ON wbit_term_in_lang_id 
= wbtl_id JOIN wbt_type ON wbtl_type_id = wby_id JOIN wbt_text_in_lang ON 
wbtl_text_in_lang_id = wbxl_id JOIN wbt_text ON wbxl_text_id = wbx_id WHERE 
wbit_item_id IN (112664122, 112671429);
+--+--+--+---+
| wbit_item_id | wby_name | wbx_text | wbxl_language |
+--+--+--+---+
|112664122 | label| Vyeyra   | de|
|112664122 | label| Vyeyra   | es|
|112664122 | label| Vyeyra   | pt|
+--+--+--+---+
3 rows in set (0.001 sec)

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE changed the task status from "Stalled" to "Open".
Lucas_Werkmeister_WMDE moved this task from Parents / Waiting to Peer Review on 
the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5983/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Astuthiodit_1, Nikospappas1312, 786, Biggs657, karapayneWMDE, 
Invadibot, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T298140: Lexeme Language Lookup - Prioritize Items for languages in the Item lookup

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE changed the status of subtask T307869: Request for new 
search profile for Wikidata that boosts Items for languages from 
Stalled to Open.

TASK DETAIL
  https://phabricator.wikimedia.org/T298140

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T307869#8022863 <https://phabricator.wikimedia.org/T307869#8022863>, 
@dcausse wrote:
  
  > The above patch should fix the issue, I forgot that profile repositories 
must have have unique names, sorry about that!
  
  Thanks! I backported it to wmf.17 and scheduled a repeat of the config change 
for Monday.

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Astuthiodit_1, Nikospappas1312, 786, Biggs657, karapayneWMDE, 
Invadibot, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, 
CBogen, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309445: INVESTIGATION: Terms storage missing most item labels after merge, resulting in item IDs being shown

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T309445#7966722 <https://phabricator.wikimedia.org/T309445#7966722>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > Tried reproducing this locally with the following snippet in the dev tools 
console … But didn’t succeed in reproducing the error, both labels are present 
in the terms store afterwards. It’s possible that this bug is related to some 
of the extra stuff that the merge gadget does.
  
  Haven’t been able to reproduce it on Test Wikidata using that wiki’s version 
of the Merge gadget either. I’m not sure how to test this on Wikidata – we’d 
need to have a source of duplicate items that we can test the merge behavior 
with (using the gadget vs. using Special:MergeItems vs. using the API).

TASK DETAIL
  https://phabricator.wikimedia.org/T309445

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: karapayneWMDE, Addshore, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T302324: [EPIC] Refresh WikibaseLexeme readme file

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T306010: Add additional git, npm and 
composer workflow documentation to WikibaseLexeme.git readme as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T302324

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
Universal_Omega, maantietaja, Akuckartz, apaskulin, Nandana, Cpaulf30, Lahi, 
Gq86, GoranSMilovanovic, Ivana_Isadora, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T306010: Add additional git, npm and composer workflow documentation to WikibaseLexeme.git readme

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T306010

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Lucas_Werkmeister_WMDE
Cc: Aklapper, ItamarWMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
Universal_Omega, maantietaja, Akuckartz, apaskulin, Nandana, Cpaulf30, Lahi, 
Gq86, GoranSMilovanovic, Ivana_Isadora, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311171: Query using wikibase:label returns the item id

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I don’t see what the issue here is… if the item has no label in any of the 
listed languages, the label service falls back to the item ID. This is good and 
desirable. Whether an item has a label in a certain language or not is 
essentially arbitrary, so filtering out items that happen to have no label is 
not usually a good thing to do, in my opinion. (Unless you’re working with a 
maintenance query or are otherwise interested specifically in the existence of 
the label.)

TASK DETAIL
  https://phabricator.wikimedia.org/T311171

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, AWesterinen, Aklapper, Astuthiodit_1, 
karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, 
Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T303317: Show word-level diff on textual fields in Wikibase diffs

2022-06-23 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  > Make sure to consider whether the core class WordLevelDiff is marked as 
"newable", meaning that we are able to instantiate it outside of core
  
  WordLevelDiff was last substantially changed in 2016, so it predates the 
stable interface policy (created beginning of 2017). To me it seems plausible 
that marking it newable was simply not done yet, but there wouldn’t be any 
reasons not to do it either. (Alternatively, `TableDiffFormatter` is already 
newable and uses `WordLevelDiff`; we might be able to use `TableDiffFormatter`.)

TASK DETAIL
  https://phabricator.wikimedia.org/T303317

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, noarave, Stang, Lydia_Pintscher, Manuel, Addshore, 
ItamarWMDE, Aklapper, Tacsipacsi, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T305707: INVESTIGATION: Add class prefix linting to new-lexeme repository

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Declined".
Lucas_Werkmeister_WMDE added a comment.


  Declining this; I think we agreed in an informal chat yesterday that this 
isn’t worth pursuing. (It would very likely have to be implemented as a new 
eslint plugin, which would need more time than the 4h we assigned to this 
investigation.)

TASK DETAIL
  https://phabricator.wikimedia.org/T305707

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: guergana.tzatchkova, karapayneWMDE, ItamarWMDE, Lucas_Werkmeister_WMDE, 
Astuthiodit_1, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311139: Map popups in Wikidata query service UI have tiny font size

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Product Verification to Our work 
done on the Wikidata-Campsite (Team A Hearth ) board.
Lucas_Werkmeister_WMDE added a comment.


  {F35265015}

TASK DETAIL
  https://phabricator.wikimedia.org/T311139

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5612/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jheald, Tagishsimon, Lucas_Werkmeister_WMDE, Aklapper, Fernandobacasegua34, 
Astuthiodit_1, AWesterinen, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, 
MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, 
Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311139: Map popups in Wikidata query service UI have tiny font size

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Team A Hearth ).
Lucas_Werkmeister_WMDE added a comment.


  The fix should be live within 30 minutes.

TASK DETAIL
  https://phabricator.wikimedia.org/T311139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jheald, Tagishsimon, Lucas_Werkmeister_WMDE, Aklapper, Fernandobacasegua34, 
Astuthiodit_1, AWesterinen, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, 
MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, 
Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311139: Map popups in Wikidata query service UI have tiny font size

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T311139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jheald, Tagishsimon, Lucas_Werkmeister_WMDE, Aklapper, Fernandobacasegua34, 
Astuthiodit_1, AWesterinen, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, 
MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, 
Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Peer Review to Parents / Waiting on 
the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
Lucas_Werkmeister_WMDE added a comment.


  (The revert 
<https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/807265> was 
deployed, I just forgot to attach it to this task.)

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5983/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Nikospappas1312, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Universal_Omega, maantietaja, 
Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311139: Map popups in Wikidata query service UI have tiny font size

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE attached a referenced file: F35264338: image.png.

TASK DETAIL
  https://phabricator.wikimedia.org/T311139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, AWesterinen, 
karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, 
Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, 
merbst, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311147: Distinguish “loading” and “no results” messages

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE attached a referenced file: F35264493: image.png.

TASK DETAIL
  https://phabricator.wikimedia.org/T311147

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311147: Distinguish “loading” and “no results” messages

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE attached a referenced file: F35264492: image.png.

TASK DETAIL
  https://phabricator.wikimedia.org/T311147

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311147: Distinguish “loading” and “no results” messages

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Special:NewLexeme revival, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  As an editor using Special:NewLexeme, I would like to see a “loading” message 
instead of a “no results” message while loading the initial batch of results in 
the language and lexical category lookups, so that I am accurately updated on 
the status of the lookup.
  
  **Problem:**
  Currently, we show “no results” as soon as the user types anything; once 
search results come in from the API, the “no results” message vanishes (unless 
there actually are no results).
  
  **Example:**
  {F35264492}
  Shortly afterwards:
  {F35264493}
  
  **Screenshots/mockups:**
  
  **BDD**
  GIVEN I am on Special:NewLexeme (or Special:NewLexemeAlpha)
  WHEN I enter something into the language or lexical category lookup
  AND a matching item exists
  THEN a “loading” message is shown (until actual search results appear)
  
  **Acceptance criteria:**
  
  - The new message is introduced and used when appropriate.
  
  **Open questions:**

TASK DETAIL
  https://phabricator.wikimedia.org/T311147

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5674/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T311139: Map popups in Wikidata query service UI have tiny font size

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata Query UI.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  As a WDQS user, I want to be able to see details of a query result on a map.
  
  **Problem:**
  Since the 2022-06-22 query-gui deployment, the font size in the popup for a 
map view is tiny:
  {F35264338}
  
  **Example:**
  Query 
<https://query.wikidata.org/embed.html#%23defaultView%3AMap%0ASELECT%20distinct%20%3Fitem%20%3FitemLabel%20%3Fsitelinks%20%3Fcoord%20%20WITH%20%7B%20SELECT%20%3Fitem%20%0AWHERE%20%0A%7B%0A%20%20%3Fitem%20wdt%3AP131%2Fwdt%3AP131%20wd%3AQ22%20.%20%23%7D%20hint%3APrior%20hint%3ArunFirst%20true.%0A%20%20%7B%3Fitem%20wdt%3AP31%20wd%3AQ55659167.%7D%0A%20%20UNION%0A%20%20%7B%3Fitem%20wdt%3AP31%20wd%3AQ4022%20.%20%7D%0A%20%20UNION%0A%20%20%7B%3Fitem%20wdt%3AP31%20wd%3AQ47521%20.%20%7D%0A%20%20%0A%20%20filter%20not%20exists%20%7B%3Fitem%20wdt%3AP403%20%5B%5D%20.%7D%0A%20%20%0A%7D%20%7D%20as%20%25i%0AWHERE%0A%7B%0A%20%20INCLUDE%20%25i%0A%20%20SERVICE%20wikibase%3Alabel%20%7B%20bd%3AserviceParam%20wikibase%3Alanguage%20%22%5BAUTO_LANGUAGE%5D%2Cen%22.%20%7D%20%0A%20%20%3Fitem%20wikibase%3Asitelinks%20%3Fsitelinks.%0A%20%20%3Fitem%20wdt%3AP625%20%3Fcoord%20.%0A%7D%20order%20by%20desc(%3Fsitelinks)%20%3FitemLabel>
  
  **Screenshots/mockups:**
  
  **BDD**
  GIVEN 
  AND 
  WHEN
  AND
  THEN
  AND
  
  **Acceptance criteria:**
  
  - The text is at a readable font size.
  
  **Open questions:**

TASK DETAIL
  https://phabricator.wikimedia.org/T311139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, AWesterinen, 
karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, 
Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, 
merbst, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T302172: Translation issue in German

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Incoming to Done on the Wikidata 
Query Builder board.
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  This is fixed now:
  {F35264327}

TASK DETAIL
  https://phabricator.wikimedia.org/T302172

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, LBorek, Lydia_Pintscher, YFdyh000, Reedy, 
LucasWerkmeister, Aklapper, ViggieJoe, Astuthiodit_1, Prufkick, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, 
Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T302172: Translation issue in German

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T307669: deploy new version of Query 
Builder to incorporate new translations as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T302172

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: LBorek, Lydia_Pintscher, YFdyh000, Reedy, LucasWerkmeister, Aklapper, 
ViggieJoe, Astuthiodit_1, Prufkick, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, 
Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T301461: Investigate cache issues after WDQS UI deployments

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Backlog to Done on the Wikidata 
Query UI board.
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  Looks like it’s working, I didn’t notice any errors with today’s WDQS UI 
deployment and haven’t heard of any user problems either.

TASK DETAIL
  https://phabricator.wikimedia.org/T301461

WORKBOARD
  https://phabricator.wikimedia.org/project/board/2901/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: RKemper, EBernhardson, RLazarus, ItamarWMDE, toan, Lucas_Werkmeister_WMDE, 
Aklapper, Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, MPhamWMF, 
maantietaja, CBogen, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, 
_jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307669: deploy new version of Query Builder to incorporate new translations

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Incoming to Our work done on the 
Wikidata-Campsite (Team A Hearth ) board.
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  Deployed.

TASK DETAIL
  https://phabricator.wikimedia.org/T307669

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5612/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Linda-Rabea.Heyden_WMDE, Aklapper, Lydia_Pintscher, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T289243: Edge Caches can lead to broken Query Builder for some time after deploy

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  Seems to be fixed now, I didn’t notice any query builder errors after today’s 
deployment.

TASK DETAIL
  https://phabricator.wikimedia.org/T289243

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Ladsgroup, Aklapper, Michael, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T307869#8019798 <https://phabricator.wikimedia.org/T307869#8019798>, 
@gerritbot wrote:
  
  > Change 801793 **merged** by jenkins-bot:
  >
  > [operations/mediawiki-config@master] [cirrus] Add a custom profile for the 
wikibase language selector
  >
  > https://gerrit.wikimedia.org/r/801793
  
  I’m afraid this needs a bit more work:
  
  counterexample
lucaswerkmeister-wmde@mwdebug1001:~$ mwscript 
extensions/Wikibase/repo/maintenance/searchEntities.php wikidatawiki 
--entity-type item --language en --profile-context language_selector_prefix 
<<registerRepository(Object(CirrusSearch\Profile\SearchProfileRepositoryTransformer))
#1 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/WikibaseCirrusSearch/src/Hooks.php(145):
 
Wikibase\Search\Elastic\Hooks::registerSearchProfiles(Object(CirrusSearch\Profile\SearchProfileService),
 Object(Wikibase\Search\Elastic\WikibaseSearchConfig), Array)
#2 
/srv/mediawiki/php-1.39.0-wmf.17/includes/HookContainer/HookContainer.php(338): 
Wikibase\Search\Elastic\Hooks::onCirrusSearchProfileService(Object(CirrusSearch\Profile\SearchProfileService))
#3 
/srv/mediawiki/php-1.39.0-wmf.17/includes/HookContainer/HookContainer.php(137): 
MediaWiki\HookContainer\HookContainer->callLegacyHook('CirrusSearchPro...', 
Array, Array, Array)
#4 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/CirrusSearch/includes/CirrusSearchHookRunner.php(100):
 MediaWiki\HookContainer\HookContainer->run('CirrusSearchPro...', Array)
#5 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/CirrusSearch/includes/Profile/SearchProfileServiceFactory.php(160):
 
CirrusSearch\CirrusSearchHookRunner->onCirrusSearchProfileService(Object(CirrusSearch\Profile\SearchProfileService))
#6 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/CirrusSearch/includes/SearchConfig.php(308):
 
CirrusSearch\Profile\SearchProfileServiceFactory->loadService(Object(CirrusSearch\SearchConfig))
#7 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/WikibaseCirrusSearch/src/EntitySearchElastic.php(156):
 CirrusSearch\SearchConfig->getProfileService()
#8 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/WikibaseCirrusSearch/src/EntitySearchElastic.php(206):
 
Wikibase\Search\Elastic\EntitySearchElastic->loadProfile(Object(CirrusSearch\Search\SearchContext),
 'en')
#9 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/WikibaseCirrusSearch/src/EntitySearchElastic.php(301):
 Wikibase\Search\Elastic\EntitySearchElastic->getElasticSearchQuery('Engl', 
'en', 'item', false, Object(CirrusSearch\Search\SearchContext))
#10 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/includes/Api/CombinedEntitySearchHelper.php(49):
 Wikibase\Search\Elastic\EntitySearchElastic->getRankedSearchResults('Engl', 
'en', 'item', 5, false, 'language_select...')
#11 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/includes/Api/TypeDispatchingEntitySearchHelper.php(48):
 Wikibase\Repo\Api\CombinedEntitySearchHelper->getRankedSearchResults('Engl', 
'en', 'item', 5, false, 'language_select...')
#12 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/maintenance/searchEntities.php(106):
 
Wikibase\Repo\Api\TypeDispatchingEntitySearchHelper->getRankedSearchResults('Engl',
 'en', 'item', 5, false, 'language_select...')
#13 
/srv/mediawiki/php-1.39.0-wmf.17/includes/OrderedStreamingForkController.php(142):
 Wikibase\Repo\Maintenance\SearchEntities->doSearch('Engl')
#14 
/srv/mediawiki/php-1.39.0-wmf.17/includes/OrderedStreamingForkController.php(69):
 OrderedStreamingForkController->consumeNoFork()
#15 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/maintenance/searchEntities.php(65):
 OrderedStreamingForkController->start()
#16 
/srv/mediawiki/php-1.39.0-wmf.17/maintenance/includes/MaintenanceRunner.php(309):
 Wikibase\Repo\Maintenance\SearchEntities->execute()
#17 /srv/mediawiki/php-1.39.0-wmf.17/maintenance/doMaintenance.php(85): 
MediaWiki\Maintenance\MaintenanceRunner->run()
#18 
/srv/mediawiki/php-1.39.0-wmf.17/extensions/Wikibase/repo/maintenance/searchEntities.php(160):
 require_once('/srv/mediawiki/...')
#19 /srv/mediawiki/multiversion/MWScript.php(120): 
require_once('/srv/mediawiki/...')
#20 {main}
  
  I’ll revert it for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Nikospappas1312, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Universal_Omega, maantietaja, 
Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, 
Lewizho99, Maath

[Wikidata-bugs] [Maniphest] T301461: Investigate cache issues after WDQS UI deployments

2022-06-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Thanks! Header looks good to me now:
  
$ curl -sI https://query.wikidata.org | grep -i cache-control
cache-control: no-cache
$ curl -sI https://query.wikidata.org/js/wdqs.min.3e953121da5bfd51eb0d.js | 
grep -i cache-control
cache-control: max-age=3600, must-revalidate
  
  I’ll deploy some WDQS UI and query builder updates later, and hopefully they 
won’t cause any cache issues this time.

TASK DETAIL
  https://phabricator.wikimedia.org/T301461

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: RKemper, EBernhardson, RLazarus, ItamarWMDE, toan, Lucas_Werkmeister_WMDE, 
Aklapper, Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, MPhamWMF, 
maantietaja, CBogen, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, 
_jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T294159: Enable Lexeme access on first set of projects

2022-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  This should now be enabled everywhere.
  {F35260331}

TASK DETAIL
  https://phabricator.wikimedia.org/T294159

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Stang, Base, Mahir256, Aklapper, Jdforrester-WMF, Lea_Lacroix_WMDE, 
Lucas_Werkmeister_WMDE, LucasWerkmeister, Yurik, deryckchan, Lydia_Pintscher, 
dr0ptp4kt, DVrandecic, Theklan, Fernandobacasegua34, Astuthiodit_1, 
Yodas_henchman, 786, Suran38, NguoiDungKhongDinhDanh, Biggs657, karapayneWMDE, 
Invadibot, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, 
Un1tY, Akuckartz, Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, joker88john, 
94rain, CucyNoiD, Nandana, Tks4Fish, Gaboe420, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, Kizule, 
LawExplorer, Lewizho99, Maathavan, Devwaker, Niklitov, _jensen, Urbanecm, 
rosalieper, Bodhisattwa, 4nn1l2, Neuronton, JEumerus, Scott_WUaS, Ananthsubray, 
Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, 
Wikidata-bugs, Snowolf, aude, Dcljr, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T309593: enable Lexeme Lua access on remaining Wikimedia projects

2022-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Incoming to Product Verification on 
the Wikidata-Campsite (Team A Hearth ) board.
Lucas_Werkmeister_WMDE added a comment.


  This should now be enabled everywhere.
  {F35260331}

TASK DETAIL
  https://phabricator.wikimedia.org/T309593

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5612/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: mxn, Alicia_Fagerving_WMSE, Pols12, Mohammed_Sadat_WMDE, Theklan, 
DVrandecic, dr0ptp4kt, deryckchan, Yurik, LucasWerkmeister, 
Lucas_Werkmeister_WMDE, Lea_Lacroix_WMDE, Jdforrester-WMF, Aklapper, Mahir256, 
Base, Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Yodas_henchman, 786, 
Suran38, NguoiDungKhongDinhDanh, Biggs657, karapayneWMDE, Invadibot, Zabe, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, CptViraj, AKA_MBG, Kent7301, Dibya, joker88john, 94rain, CucyNoiD, 
Nandana, Tks4Fish, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, Kizule, LawExplorer, 
Lewizho99, Maathavan, Devwaker, Niklitov, _jensen, Urbanecm, rosalieper, 
Bodhisattwa, 4nn1l2, Neuronton, JEumerus, Scott_WUaS, Ananthsubray, 
Superzerocool, Stanglavine, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, 
Wikidata-bugs, Snowolf, aude, Dcljr, Matanya, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-20 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  To roll out this new feature, we’ll temporarily make the wbsearchentities API 
only expose the new API parameter if it’s been configured in the production 
config (i.e. when there’s another possible value besides `default`). This way, 
we can let the wbsearchentities change roll out with the train, and then 
control using only config changes when the new parameter is available on which 
wikis. So the current plan for deploying this feature is:
  
  - the Wikibase `EntitySearchHelper` interface changes are merged and roll out 
with the train – no change yet
  - the config change for the new profile 
<https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/801793> is 
deployed – no change yet
  - wbsearchentities adds a new parameter iff more than one search profile is 
configured, to roll out with the train – no change yet
  - we configure two API search profiles – observable API change, deployment 
coordinated with significant change announcement, probably deployed to Test 
Wikidata two weeks before real Wikidata
  - later, wbsearchentities always adds the new parameter – no change in 
production (but at this point the parameter becomes available on other wikis 
too)
  
  We’ll start working on the mentioned significant change announcement once the 
`EntitySearchHelper` changes and the config change for the new profile have 
been deployed to production. (The wbsearchentities change probably won’t make 
it into this week’s train, but that should be fine.)

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Nikospappas1312, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Universal_Omega, maantietaja, 
Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T301461: Investigate cache issues after WDQS UI deployments

2022-06-20 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  @RKemper thanks, that would be great!

TASK DETAIL
  https://phabricator.wikimedia.org/T301461

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: RKemper, EBernhardson, RLazarus, ItamarWMDE, toan, Lucas_Werkmeister_WMDE, 
Aklapper, Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, MPhamWMF, 
maantietaja, CBogen, Akuckartz, Nandana, Namenlos314, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, merbst, LawExplorer, Salgo60, 
_jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Manybubbles, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T307869: Request for new search profile for Wikidata that boosts Items for languages

2022-06-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  For the API parameter, we’ll have a config setting defining the possible API 
values and mapping them to the underling profile context value. This means it’s 
the administrator’s responsibility to make the API parameter useful (just like 
it’s already their responsibility to configure WikibaseCirrusSearch more 
generally), and to configure a value that the installed search extensions will 
understand. By default, the mapping would be:
  
$wgWBRepoSettings['searchProfiles'] = [ // name up for discussion
'default' => null,
];
  
  So a default Wikibase install would always pass `null` into the 
`EntitySearchHelper`, leaving it to the search implementation to interpret this 
profile however it wants. (Non-CirrusSearch implementations would ignore it at 
the moment.) In production, we would configure:
  
$wgWBRepoSettings['searchProfiles'] = [
'default' => null,
'language' => 'language_selector_prefix', // 
\Wikibase\Search\Elastic\Hooks::LANGUAGE_SELECTOR_PREFIX
];
  
  We would //not// explicitly include the value that’s equivalent to `null` 
(`EntitySearchElastic::CONTEXT_WIKIBASE_PREFIX` = `'wikibase_prefix_search'`). 
Just `default` and `language`.

TASK DETAIL
  https://phabricator.wikimedia.org/T307869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ItamarWMDE, dcausse, Lucas_Werkmeister_WMDE, MPhamWMF, Aklapper, 
Lydia_Pintscher, Fernandobacasegua34, Astuthiodit_1, Nikospappas1312, 786, 
Suran38, Biggs657, karapayneWMDE, Invadibot, Universal_Omega, maantietaja, 
Juan90264, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Gryllida, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310134: Update error message on blur of Lookup where no item has been selected

2022-06-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I think this still needs an update in WikibaseLexeme.git?

TASK DETAIL
  https://phabricator.wikimedia.org/T310134

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: noarave, Lea_Lacroix_WMDE, Lydia_Pintscher, Erdinc_Ciftci_WMDE, ItamarWMDE, 
Lucas_Werkmeister_WMDE, guergana.tzatchkova, Fernandobacasegua34, 
Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, 
Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Bodhisattwa, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310134: Update error message on blur of Lookup where no item has been selected

2022-06-15 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE changed the subtype of this task from "Bug Report" to 
"Task".

TASK DETAIL
  https://phabricator.wikimedia.org/T310134

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: noarave, Lea_Lacroix_WMDE, Lydia_Pintscher, Erdinc_Ciftci_WMDE, ItamarWMDE, 
Lucas_Werkmeister_WMDE, guergana.tzatchkova, Fernandobacasegua34, 
Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T294637: Improvements to the WikibaseLexeme Lua interface (before full rollout)

2022-06-15 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T294637

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Jarekt, Marsupium, Alicia_Fagerving_WMSE, Premeditated, 
Infovarius, Nikki, daniel, So9q, DVrandecic, Jdforrester-WMF, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, jberkel, 
Psychoslave, Wikidata-bugs, aude, Shizhao, Nemo_bis, Darkdadaah, Mbch331, 
Ltrlg, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T235901: Implement Lua access to Lexemes, Senses and Forms

2022-06-15 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T294637: Improvements to the 
WikibaseLexeme Lua interface (before full rollout) as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T235901

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, DVrandecic, So9q, daniel, Nikki, Infovarius, Premeditated, 
Alicia_Fagerving_WMSE, Marsupium, Lucas_Werkmeister_WMDE, Fernandobacasegua34, 
Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, RhinosF1, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, 
Scott_WUaS, jberkel, Psychoslave, Wikidata-bugs, aude, Shizhao, Nemo_bis, 
Darkdadaah, Mbch331, Ltrlg, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T294637: Improvements to the WikibaseLexeme Lua interface (before full rollout)

2022-06-15 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Then let’s close this task, and I’ll upload a Gerrit change to declare the 
Lua interface stable in its current form. Once the “Lua haswbstatements” 
feature has been implemented, we’ll announce it as a significant (but hopefully 
not breaking) change to the interface, but there’s no need to block the initial 
Lexeme Lua rollout on it.

TASK DETAIL
  https://phabricator.wikimedia.org/T294637

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Jarekt, Marsupium, Alicia_Fagerving_WMSE, Premeditated, 
Infovarius, Nikki, daniel, So9q, DVrandecic, Jdforrester-WMF, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, jberkel, 
Psychoslave, Wikidata-bugs, aude, Shizhao, Nemo_bis, Darkdadaah, Mbch331, 
Ltrlg, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T235901: Implement Lua access to Lexemes, Senses and Forms

2022-06-15 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T235901#7465832 <https://phabricator.wikimedia.org/T235901#7465832>, 
@Lucas_Werkmeister_WMDE wrote:
  
  >> The `senses` and `forms` of a returned lexeme entity aren’t entities 
themselves, they’re ordinary tables. Only the custom `getForms()` and 
`getSenses()` methods take care of properly creating entities.
  >
  > I think we can leave this open for feedback after the initial Beta rollout. 
Should `getForms()` and `getSenses()` exist at all? Or should `.forms` and 
`.senses` contain entity objects already? And in either case, should they be 
indexed numerically (1, 2, …) or by ID (`L1-F1`, `L1-F2`, … – or just `F1`, 
`F2`, …?)? Maybe the initial testers have some feedback on this.
  
  I think we can leave `.forms` and `.senses` as they are at the moment – not 
documented as part of the stable interface, but not particularly hidden either. 
Similar to the `.claims` on all entities (I suppose they’re `.statements` on 
MediaInfo?), where we expect users to use `:getAllStatements()` and other 
functions instead.

TASK DETAIL
  https://phabricator.wikimedia.org/T235901

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, DVrandecic, So9q, daniel, Nikki, Infovarius, Premeditated, 
Alicia_Fagerving_WMSE, Marsupium, Lucas_Werkmeister_WMDE, Fernandobacasegua34, 
Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, RhinosF1, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Neuronton, 
Scott_WUaS, jberkel, Psychoslave, Wikidata-bugs, aude, Shizhao, Nemo_bis, 
Darkdadaah, Mbch331, Ltrlg, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T292621: INVESTIGATION: Fix stats for Wikidata dump downloads dashboard

2022-06-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  > The recent decline in downloads (after 17.3.2022) and the changed shape of 
the line are looking a bit suspicious. Something seems to have changed, 
probably in the way we are measuring this. It is important to understand this 
well enough to interpret the curve right. Could you please add a description to 
the board that documents what has happened?
  
  The pattern seems to be real, at least when looking at successful requests 
(status 200):
  
lucaswerkmeister-wmde@stat1007:~$ zgrep -F /wikidatawiki/ 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-202203*.gz | grep -E 
-e '(latest|wikidata-[0-9]{8})-all\.json\.(gz|bz2)' | grep -F ' 200 ' | cut -d: 
-f1 | uniq -c
   1166 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220301.gz
   1281 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220302.gz
   1236 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220303.gz
   1022 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220304.gz
   1317 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220305.gz
   1164 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220306.gz
   1095 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220307.gz
   1200 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220308.gz
   1171 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220309.gz
   1059 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220310.gz
   1044 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220311.gz
   1184 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220312.gz
   1107 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220313.gz
   1021 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220314.gz
   1242 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220315.gz
   1189 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220316.gz
987 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220317.gz
961 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220318.gz
550 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220319.gz
126 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220320.gz
138 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220321.gz
285 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220322.gz
203 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220323.gz
227 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220324.gz
342 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220325.gz
231 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220326.gz
129 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220327.gz
196 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220328.gz
298 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220329.gz
269 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220330.gz
308 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220331.gz
  
  (Note that the 206 responses (partial content) are much more erratic:)
  
lucaswerkmeister-wmde@stat1007:~$ zgrep -F /wikidatawiki/ 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-202203*.gz | grep -E 
-e '(latest|wikidata-[0-9]{8})-all\.json\.(gz|bz2)' | grep -F ' 206 ' | cut -d: 
-f1 | uniq -c
 60 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220301.gz
120 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220302.gz
419 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220303.gz
321 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220304.gz
105 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220305.gz
120 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220306.gz
   1530 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220307.gz
   1359 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220308.gz
182 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220309.gz
   1273 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220310.gz
400 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220311.gz
352 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220312.gz
 82 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220313.gz
381 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220314.gz
326 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220315.gz
286 
/srv/log/webrequest/archive/dumps.wikimedia.org/access.log-20220

[Wikidata-bugs] [Maniphest] T292621: INVESTIGATION: Fix stats for Wikidata dump downloads dashboard

2022-06-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T292621#8001541 <https://phabricator.wikimedia.org/T292621#8001541>, 
@Manuel wrote:
  
  > In what way are T162346 <https://phabricator.wikimedia.org/T162346> and 
T218711 <https://phabricator.wikimedia.org/T218711> related?
  
  I assume T218711: Regular wikidata JSON dump scanning broken on analytics 
machine <https://phabricator.wikimedia.org/T218711> is unrelated – I don’t know 
what those scans did, but if they’ve been broken for years then I don’t think 
it can be directly related to this task.
  
  T162346: Include truthy nt dumps in the Wikidata Dump Downloads Grafana 
dashboard <https://phabricator.wikimedia.org/T162346> looks like it would still 
be relevant (the truthy dumps still aren’t tracked as far as I can tell), but 
shouldn’t affect the download numbers for the full / incremental dumps.

TASK DETAIL
  https://phabricator.wikimedia.org/T292621

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Manuel, Lucas_Werkmeister_WMDE, Aklapper, Lydia_Pintscher, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T218711: Regular wikidata JSON dump scanning broken on analytics machine

2022-06-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Note that the dump scanning doesn’t even run anymore since T278665: 
wmde-toolkit-analyzer-build.service fails on stat1007 
<https://phabricator.wikimedia.org/T278665> (which was apparently an even 
harder crash than the problem reported here). Consequently, 
`/srv/analytics-wmde/graphite/log/toolkit-analyzer.log` is currently empty.

TASK DETAIL
  https://phabricator.wikimedia.org/T218711

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, elukey, Addshore, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310581: Make LanguageCode::bcp47() available in Lua

2022-06-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Hm, that’s a very good point. Let’s just limit this task to 
`mw.language.bcp47()` for now, then?

TASK DETAIL
  https://phabricator.wikimedia.org/T310581

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Zebulon84, Tacsipacsi, Lucas_Werkmeister_WMDE, mrephabricator, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, 
SundanceRaphael, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Nikki, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T310581: Make LanguageCode::bcp47() available in Lua

2022-06-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I can imagine three possible interfaces (not counting name variations):
  
htmlCode = mw.language.bcp47( languageCode )
htmlCode = mw.language.new( languageCode ).bcp47
htmlCode = mw.language.new( languageCode ):bcp47()
  
  That is, a “static” method on `mw.language`, a field on an `mw.language` 
instance, or a method on an `mw.language` instance. Since `mw.language:getCode` 
is also a method, I think I’m leaning towards the third interface.
  
  There’s probably also some possible bikeshedding over whether we want to use 
the term “BCP 47” (and if yes, on its own or with “code” or “tag”), or call it 
an “HTML language code”, or something else.
  
  (I’m also tempted to add a method like `mw.html:inLanguage()` to `mw.html`, 
which would be a shortcut for setting the `lang` and `dir` attributes – in that 
case, the `bcp47()` method name wouldn’t matter as much, because most users 
wouldn’t use it directly.)

TASK DETAIL
  https://phabricator.wikimedia.org/T310581

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Bodhisattwa, Scott_WUaS, Nikki, alex-mashin, Wikidata-bugs, aude, 
Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T302274: INVESTIGATION: Grafana board for Wikidata Query Service UI not receiving data

2022-06-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  I think we changed the Grafana metric names at some point, perhaps related to 
the Query Builder deployment – it’s possible we just need to update the 
dashboard to look at the new names. Should be possible to investigate by 
looking through the Git history of the query UI.

TASK DETAIL
  https://phabricator.wikimedia.org/T302274

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Manuel, Aklapper, Astuthiodit_1, AWesterinen, 
karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, 
Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, 
merbst, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T302274: Grafana board for Wikidata Query Service UI not receiving data

2022-06-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a project: Wikidata Query UI.

TASK DETAIL
  https://phabricator.wikimedia.org/T302274

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Manuel, Aklapper, Astuthiodit_1, AWesterinen, karapayneWMDE, Invadibot, 
MPhamWMF, maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Namenlos314, 
Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Mahir256, QZanden, 
EBjune, merbst, LawExplorer, Salgo60, _jensen, rosalieper, Scott_WUaS, Jonas, 
Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


  1   2   3   4   5   6   7   8   9   10   >