[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Martaannaj updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Ottomata, Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester
Martaannaj added a comment. @Michaelcochez Should be fixed now, in the case where there are no properties already attributed to the entity the PropertySuggester would simply return a pre-set list, so the request duration would be 0 ms. This in turn would cause the line $this->requestDuration ?: -1 to replace the 0 by -1, causing the error. TASK DETAIL https://phabricator.wikimedia.org/T287797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Michaelcochez, Aklapper, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester
Martaannaj added a comment. @Michaelcochez can you give me an example of an entity where this happens? Because looking at https://wikidata.beta.wmflabs.org/wiki/Q86 (served by the PropertySuggester) the request duration gets logged nicely. In the implementation, in the case where the call to the SchemaTreeRecommender times out the request gets handled by the PropertySuggester. In these cases the request duration gets logged as -1 to indicate that it was supposed to be handled by the SchemaTreeRecommender but something went wrong with the request so it ended up being executed by the PropertySuggester. Maybe this is what you see in the logs? I think that what should be seen is one event log where the recommender used is the 'SchemaTreeRecommender' with the request duration of -1 and then another server side log for the same entity but with the recommender used 'PropertySuggester' TASK DETAIL https://phabricator.wikimedia.org/T287797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Michaelcochez, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester
Martaannaj added a comment. @Michaelcochez can you give me an example of an entity where this happens? Because looking at https://wikidata.beta.wmflabs.org/wiki/Q86 (served by the PropertySuggester) the request duration gets logged nicely. In the implementation, in the case where the call to the SchemaTreeRecommender times out the request gets handled by the PropertySuggester. In these cases the request duration gets logged as -1 to indicate that it was supposed to be handled by the SchemaTreeRecommender but something went wrong with the request so it ended up being executed by the PropertySuggester. Maybe this is what you see in the logs? TASK DETAIL https://phabricator.wikimedia.org/T287797 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Michaelcochez, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Martaannaj added a comment. In T285098#7242437 <https://phabricator.wikimedia.org/T285098#7242437>, @Addshore wrote: > In T285098#7236140 <https://phabricator.wikimedia.org/T285098#7236140>, @Martaannaj wrote: > >> @Addshore >> >> It would still be required to test the event logging on beta right? And for that I believe that the schemas still need to be merged. If that gets done then I can make another patch for deploying the event logging streams to mediawiki-config. After that there should be nothing missing in order to proceed with test.wikidata. > > This is now merged, let us know how testing goes or if you get stuck with anything! Okay, great! I'm looking at the guidelines for checking the event logging in beta and it seems that to do that I should be able to ssh into the deployment-eventlog05.eqiad1.wikimedia.cloud, however, I do not believe that I have the access. Is this something that can be granted? TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Martaannaj added a comment. @Addshore It would still be required to test the event logging on beta right? And for that I believe that the schemas still need to be merged. If that gets done then I can make another patch for deploying the event logging streams to mediawiki-config. After that there should be nothing missing in order to proceed with test.wikidata. TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Martaannaj updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Martaannaj updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Martaannaj updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Martaannaj updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T285098 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Martaannaj Cc: Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore, Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T285098: Production A/B test deployment - Improved Property Suggester/Recommender
Martaannaj added a comment.
In T285098#7212186 <https://phabricator.wikimedia.org/T285098#7212186>,
@Lucas_Werkmeister_WMDE wrote:
> I noticed something strange while testing the wmcloud suggester:
>
> $ curl -s --data-raw '{"Properties":[],"Types":[]}'
'https://recommender.wmcloud.org/recommender' | jq '.recommendations | .[] |
select(.property | contains("entity"))' | head -25
> {
> "property": "t#http://www.wikidata.org/entity/Q13442814;,
> "probability": 0.3913980623938509
> }
> {
> "property": "t#http://www.wikidata.org/entity/Q5;,
> "probability": 0.095606796510795
> }
> {
> "property": "t#http://www.wikidata.org/entity/Q4167836;,
> "probability": 0.05041456380639843
> }
> {
> "property": "t#http://www.wikidata.org/entity/Q523;,
> "probability": 0.03463687290548014
> }
> {
> "property": "t#http://www.wikidata.org/entity/Q16521;,
> "probability": 0.030493683112935314
> }
> {
> "property": "t#http://www.wikidata.org/entity/Q318;,
> "probability": 0.022078375242171346
> }
> {
>
> Some of the suggestions are entity URIs instead of property URIs… and they
start with a random `t#`?
The `t#` is used as a way how to recognise the entities (types) when
building/serving the tree. They definitely shouldn't be included in the
response, I just pushed the fix (the service running on wmcloud also has the
updated version) so now the response should contain only properties.
TASK DETAIL
https://phabricator.wikimedia.org/T285098
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Martaannaj
Cc: Lucas_Werkmeister_WMDE, Martaannaj, Michaelcochez, Michael, Addshore,
Aklapper, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264,
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301,
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30,
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer,
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude,
Lydia_Pintscher, Sjoerddebruin, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
