[Wikidata-bugs] [Maniphest] T268441: Extend MenuItem syntax to include tag

2020-11-24 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T268441 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Michael Cc: Aklapper, guergana.tzatchkova, Akuckartz, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T268639: Investigate how to track the number of queries that return a result vs an error over time

2020-11-24 Thread Michael
Michael created this task. Michael added projects: Wikidata Query Builder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION We want to know how many of the queries executed by the query builder: - return a result - return an error - timeout Challenge

[Wikidata-bugs] [Maniphest] T268638: Create Grafana boards for metrics

2020-11-24 Thread Michael
Michael created this task. Michael added projects: Wikidata Query Builder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION **Acceptance criteria:** [ ] metrics from T268635 <https://phabricator.wikimedia.org/T268635> are tracked on a Grafana board as

[Wikidata-bugs] [Maniphest] T268635: Track local metrics in QueryBuilder

2020-11-24 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T268635 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T268635: Track local metrics in QueryBuilder

2020-11-24 Thread Michael
Michael created this task. Michael added projects: Wikidata Query Builder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION **Metrics to collect:** - Number of page views over time (ideally without bots and scrapers) -> `counter.wikidata.query-builder.p

[Wikidata-bugs] [Maniphest] T265243: get initial metrics

2020-11-24 Thread Michael
Michael added a comment. NOTE: this task is in good parts stalled by T268624: statsv seems to be down or broken <https://phabricator.wikimedia.org/T268624> TASK DETAIL https://phabricator.wikimedia.org/T265243 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T246415: Investigate a different db load groups for wikidata / wikibase

2020-11-24 Thread Michael
Michael removed Michael as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T246415 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: ArielGlenn, Michael, Marostegui, Ladsgroup, WMDE-leszek, Aklapper, Addshore

[Wikidata-bugs] [Maniphest] T268446: Create Messages for user facing text

2020-11-23 Thread Michael
Michael renamed this task from "Create user facing text " to "Create Messages for user facing text ". Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T268446 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] T268508: Load more results for PropertyLookup on scroll

2020-11-23 Thread Michael
Michael created this task. Michael added a project: Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION When the user starts to scroll for more results in the PropertyLookup, we should start asking

[Wikidata-bugs] [Maniphest] T266456: Handling partially supported datatypes

2020-11-23 Thread Michael
Michael added a subtask: T267671: Make the Query Builder configurable at build time. TASK DETAIL https://phabricator.wikimedia.org/T266456 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Sarai-WMDE, Bugreporter, Aklapper, Charlie_WMDE

[Wikidata-bugs] [Maniphest] T267671: Make the Query Builder configurable at build time

2020-11-23 Thread Michael
Michael added a parent task: T266456: Handling partially supported datatypes. TASK DETAIL https://phabricator.wikimedia.org/T267671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: guergana.tzatchkova, Aklapper, Michael, Akuckartz, Nandana

[Wikidata-bugs] [Maniphest] T267671: Make the Query Builder configurable at build time

2020-11-23 Thread Michael
Michael merged a task: T268444: Investigate how to make the QB configurable at build time. Michael added a subscriber: guergana.tzatchkova. TASK DETAIL https://phabricator.wikimedia.org/T267671 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael

[Wikidata-bugs] [Maniphest] T268444: Investigate how to make the QB configurable at build time

2020-11-23 Thread Michael
Michael closed this task as a duplicate of T267671: Make the Query Builder configurable at build time. TASK DETAIL https://phabricator.wikimedia.org/T268444 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, guergana.tzatchkova

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

2020-11-23 Thread Michael
Michael moved this task from Peer Review to ❌ Blocked on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board. Michael added a comment. I'd say let's have another look at this when T267731 <https://phabricator.wikimedia.org/T267731> is merged. Then we can create the P

[Wikidata-bugs] [Maniphest] T267732: Investigate how to switch the language in the UI (can we reuse what's done in the Query Service UI?) -- 8h

2020-11-23 Thread Michael
Michael moved this task from Peer Review to Done on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board. Michael added a comment. As far as I can tell, this is done. But we can only meaningfully test this when T267731 <https://phabricator.wikimedia.org/T267731> is als

[Wikidata-bugs] [Maniphest] T265245: (MS1) query for Items with specific Property but any value

2020-11-23 Thread Michael
Michael added a comment. In T265245#6637658 <https://phabricator.wikimedia.org/T265245#6637658>, @Ladsgroup wrote: > There's an a11y issue with the current design, the a11y tests is now failing (https://github.com/wmde/query-builder/pull/33/checks?check_run_id=1

[Wikidata-bugs] [Maniphest] T267739: Disable Input field depending on state of ValueTypeDropdown

2020-11-20 Thread Michael
Michael added a comment. In context of this task, we also must make sure that the validation doesn't complain about the empty value input TASK DETAIL https://phabricator.wikimedia.org/T267739 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T268343: Production Checklist

2020-11-20 Thread Michael
Michael created this task. Michael added a project: Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Things to do before/as we official go live: [ ] ensure metrics tracking is only enabled

[Wikidata-bugs] [Maniphest] T267731: Investigate how to update translations in the repo automatically from translatewiki -- 4h max

2020-11-18 Thread Michael
Michael added a comment. That is great! So we should probably focus on getting https://github.com/wmde/query-builder/pull/59 merged and then we can get started with this TASK DETAIL https://phabricator.wikimedia.org/T267731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

2020-11-18 Thread Michael
Michael added a comment. In T267733#6627887 <https://phabricator.wikimedia.org/T267733#6627887>, @Ladsgroup wrote: > Mostly it looks good but: > > - The fallback result when there's no label in Persian is RTL but it should be LTR Fixing that might be tricky. We

[Wikidata-bugs] [Maniphest] T267732: Investigate how to switch the language in the UI (can we reuse what's done in the Query Service UI?) -- 8h

2020-11-18 Thread Michael
Michael added a comment. We should probably keep on working on integrating vue-banana-i18n to move those strings of plain copy out of our components. This will make using a language selector much easier once we have it. TASK DETAIL https://phabricator.wikimedia.org/T267732 EMAIL

[Wikidata-bugs] [Maniphest] T261652: Use controls instead of knobs in Storybook

2020-11-17 Thread Michael
Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T261652 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Aklapper, Tonina_Zhelyazkova_WMDE, Akuckartz

[Wikidata-bugs] [Maniphest] T268014: Move existing strings into language files

2020-11-17 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder ( Wikidata Query Builder - sprint 4). TASK DESCRIPTION Once the i18n system is set up in our app, we need to move the existing strings that are supposed to be translated into the `en.json` file and create

[Wikidata-bugs] [Maniphest] T267659: Document DS implementers' doubts and F.A.Qs

2020-11-17 Thread Michael
Michael added a comment. > any plugin or package that you want to use in a composed storybook has to be present in both storybooks, not only the one where it makes sense This should make its way into the readme  TASK DETAIL https://phabricator.wikimedia.org/T267659 EMAIL PREFEREN

[Wikidata-bugs] [Maniphest] T266545: Creating the Dropdown component basic states

2020-11-16 Thread Michael
Michael claimed this task. Michael moved this task from To Do to Doing on the Wikidata Query Builder ( Wikidata Query Builder - sprint 4) board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T266545 WORKBOARD https

[Wikidata-bugs] [Maniphest] T267730: Investigate how to use translations from translatewiki in vue 4h max

2020-11-12 Thread Michael
Michael added a comment. In T267730#6620815 <https://phabricator.wikimedia.org/T267730#6620815>, @Ladsgroup wrote: > In T267730#6620779 <https://phabricator.wikimedia.org/T267730#6620779>, @Michael wrote: > >> Thanks for the PR! >> >> Could y

[Wikidata-bugs] [Maniphest] T267730: Investigate how to use translations from translatewiki in vue 4h max

2020-11-12 Thread Michael
Michael added a comment. Thanks for the PR! Could you explain a bit about why you chose `vue-banana-i18n` over `vue/i18n.js`? TASK DETAIL https://phabricator.wikimedia.org/T267730 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup

[Wikidata-bugs] [Maniphest] T266240: do not just query for truthy data in the query builder

2020-11-11 Thread Michael
Michael added a comment. More background around the datamodel and what those letters above mean: https://www.mediawiki.org/wiki/Wikibase/Indexing/RDF_Dump_Format#Data_model Especially this picture is helpful: https://commons.wikimedia.org/wiki/File:Rdf_mapping-vector.svg TASK DETAIL

[Wikidata-bugs] [Maniphest] T267741: Switch test for wikit-class on root html tag to eslint based solution

2020-11-11 Thread Michael
Michael created this task. Michael added a project: Wikidata Design System. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Maintaining the existing test for the presence of the `wikit` class on published components

[Wikidata-bugs] [Maniphest] T267740: Use Design System Dropdown

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Use the Design System Dropdown (T265464 <https://phabricator.wikimedia.org/T265464>) in the ValueTypeDropdown (T267735

[Wikidata-bugs] [Maniphest] T267739: Disable Input field depending on state of ValueTypeDropdown

2020-11-11 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T267739 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T267739: Disable Input field depending on state of ValueTypeDropdown

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION If the ValueTypeDropdown is set to "any value" then the input field should be disabled. TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] T267738: Adjust QueryRepresentation and SPARQL query

2020-11-11 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T267738 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T267738: Adjust QueryRepresentation and SPARQL query

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - The QueryRepresentation must be adjusted to represent whether we are looking for a specific value or any value for a property

[Wikidata-bugs] [Maniphest] T267736: Make it possible to add the ValueTypeDropdown value to the state

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The `query` getter builds the QueryRepresentation from the RootState, therefore the selected value of the ValueTypeDropdown needs

[Wikidata-bugs] [Maniphest] T267735: Create ValueTypeDropdown component in QB

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This should eventually use the Dropdown component from the Design System created in T265464: (MS1) Create Dropdown component <ht

[Wikidata-bugs] [Maniphest] T267732: Investigate how to switch the language in the UI (can we reuse what's done in the Query Service UI?) -- 8h

2020-11-11 Thread Michael
Michael renamed this task from "How to switch the language in the UI (can we reuse what's done in the Query Service UI?) -- 8h" to "Investigate how to switch the language in the UI (can we reuse what's done in the Query Service UI?) -- 8h". TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] T267733: Investigate how do we handle RTL languages in the components -- 8h max

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder ( Wikidata Query Builder - sprint 4). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - Does changing the language to an RTL language cause RTL-specific bugs? - Do we need to use some

[Wikidata-bugs] [Maniphest] T267732: How to switch the language in the UI (can we reuse what's done in the Query Service UI?) -- 8h

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder ( Wikidata Query Builder - sprint 4). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - have a look at https://github.com/santhoshtr/wikivue/blob/master/src/components

[Wikidata-bugs] [Maniphest] T267731: Investigate how to update translations in the repo automatically from translatewiki -- 4h max

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder ( Wikidata Query Builder - sprint 4). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION already done for other repos like ORES and Wikimedia/WikiLabels <https://github.com/wikime

[Wikidata-bugs] [Maniphest] T267730: Investigate how to use translations from translatewiki in vue 4h max

2020-11-11 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder ( Wikidata Query Builder - sprint 4). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION check other WMDE vue projects for how they do it - Data bridge https://github.com/wikimedia

[Wikidata-bugs] [Maniphest] T267671: Make the Query Builder configurable at build time

2020-11-10 Thread Michael
Michael created this task. Michael added projects: Wikidata Query Builder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Both for CI and maybe for local development, we don't actually want the query service to point to the Wikidata live API. Currently

[Wikidata-bugs] [Maniphest] T266493: Wikibase Exception for wbformatvalue API call with type=unknown

2020-11-10 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266493 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Addshore, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T263553: Investigate i18n solutions for Vue + non-mediawiki applications using TranslateWiki

2020-11-10 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T263553 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Jakob_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T263553: Investigate i18n solutions for Vue + non-mediawiki applications using TranslateWiki

2020-11-10 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T263553 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Jakob_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T267631: Add debounce to PropertyLookup

2020-11-10 Thread Michael
Michael created this task. Michael added projects: Wikidata Query Builder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Without a debounce, we make a call to Wikidata for every key that the user types. As network latency is somewhat random, it is possible

[Wikidata-bugs] [Maniphest] T266240: do not just query for truthy data in the query builder

2020-11-09 Thread Michael
Michael added a comment. The code needs to be adjusted from `?item wdt:P31 wd:Q5 .` to one of the following, which are all equivalent: ?item p:P31 ?instance . ?instance ps:P31 wd:Q5 . ?item p:P31 [ ps:P31 wd:Q5 ] . ?item p:P31/ps:P31 wd:Q5 . (as I

[Wikidata-bugs] [Maniphest] T266553: Use the Lookup component

2020-11-06 Thread Michael
Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T266553 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Lydia_Pintscher, Aklapper, guergana.tzatchkova

[Wikidata-bugs] [Maniphest] T266554: Wire up Lookup component to the store

2020-11-06 Thread Michael
Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T266554 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Lydia_Pintscher, Aklapper, guergana.tzatchkova

[Wikidata-bugs] [Maniphest] T266856: Allow for loading more results for the Lookup component on scroll

2020-11-02 Thread Michael
Michael added a subscriber: ItamarWMDE. Michael added a comment. @ItamarWMDE and I discussed this. We noted that it is important to be mindful of the separation of responsibilities when implementing this feature. It is probably not the responsibility of the Lookup component to know how

[Wikidata-bugs] [Maniphest] T266549: Create a repository that makes requests to Wikidata

2020-11-02 Thread Michael
Michael moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 3) board. Michael added a comment. https://github.com/wmde/query-builder/pull/36 TASK DETAIL https://phabricator.wikimedia.org/T266549 WORKBOARD https

[Wikidata-bugs] [Maniphest] T266877: Announce menu values to screen readers

2020-10-30 Thread Michael
Michael renamed this task from "Announce menu values" to "Announce menu values to screen readers". TASK DETAIL https://phabricator.wikimedia.org/T266877 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper

[Wikidata-bugs] [Maniphest] T266877: Announce menu values

2020-10-30 Thread Michael
Michael created this task. Michael added projects: Wikidata, Accessibility, Wikidata Query Builder, Wikidata Design System. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As we have to implement the Lookup menu and its keyboard navigation ourselves, we have to also

[Wikidata-bugs] [Maniphest] T266549: Create a repository that makes requests to Wikidata

2020-10-30 Thread Michael
Michael moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 3) board. Michael claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T266549 WORKBOARD https://phabricator.wikimedia.org/project/board/5062/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T266856: Allow for loading more results for the Lookup component on scroll

2020-10-30 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 3). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION There might be more results than what we can load in the first batch. We load further results once

[Wikidata-bugs] [Maniphest] T266697: eslint should fail on warnings

2020-10-29 Thread Michael
Michael added a comment. On the topic of eslint, there also seems to be a duplicate linting rule for indent enabled: F32418707: image.png <https://phabricator.wikimedia.org/F32418707> TASK DETAIL https://phabricator.wikimedia.org/T266697 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T266790: add browser tests

2020-10-29 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T266789: show the errors based on the state

2020-10-29 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T266789: show the errors based on the state

2020-10-29 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266789 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T266790: add browser tests

2020-10-29 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T266790: add browser tests

2020-10-29 Thread Michael
Michael renamed this task from "add browser tests for each scenario (no property input, no value input, no input at all)" to "add browser tests". Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266790 EMAIL PREFERENCES https://phabr

[Wikidata-bugs] [Maniphest] T266790: add browser tests for each scenario (no property input, no value input, no input at all)

2020-10-29 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 3). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T266790 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T266787: modify the state to allow for adding (and clearing) errors

2020-10-29 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 3). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - extend the state to support error objects(or just an enum of possible errors?) for each property

[Wikidata-bugs] [Maniphest] T266788: modify the action that runs on clicking "Run Query" to also apply validation

2020-10-29 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 3). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION - if that validation succeeds then the query is executed as usual - if there is an error during

[Wikidata-bugs] [Maniphest] T266789: show the errors based on the state

2020-10-29 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 3). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T266789 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T266698: Add jest-axe to query builder CI

2020-10-28 Thread Michael
Michael added a subtask: T265299: Investigate integrating accessibility testing tools into development tooling. TASK DETAIL https://phabricator.wikimedia.org/T266698 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael

[Wikidata-bugs] [Maniphest] T265299: Investigate integrating accessibility testing tools into development tooling

2020-10-28 Thread Michael
Michael added a parent task: T266698: Add jest-axe to query builder CI. TASK DETAIL https://phabricator.wikimedia.org/T265299 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Michael Cc: Aklapper, Sarai-WMDE, guergana.tzatchkova, Jakob_WMDE

[Wikidata-bugs] [Maniphest] T266698: Add jest-axe to query builder CI

2020-10-28 Thread Michael
Michael created this task. Michael added projects: Accessibility, Wikidata Query Builder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION In T265299#6547393 <https://phabricator.wikimedia.org/T265299#6547393> the options for using axe or p11y are co

[Wikidata-bugs] [Maniphest] T266697: eslint should fail on warnings

2020-10-28 Thread Michael
Michael created this task. Michael added a project: Wikidata Design System. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION We should treat eslint warnings as errors and have CI fail to ensure a high quality of code

[Wikidata-bugs] [Maniphest] T266555: Add an interface boilerplate for the API repository

2020-10-28 Thread Michael
Michael moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 3) board. Michael added a comment. https://github.com/wmde/query-builder/pull/35 TASK DETAIL https://phabricator.wikimedia.org/T266555 WORKBOARD https

[Wikidata-bugs] [Maniphest] T266555: Add an interface boilerplate for the API repository

2020-10-28 Thread Michael
Michael claimed this task. Michael moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 3) board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T266555 WORKBOARD https

[Wikidata-bugs] [Maniphest] T266549: Create a repository that makes requests to Wikidata

2020-10-28 Thread Michael
Michael removed Michael as the assignee of this task. Michael moved this task from Doing to To Do on the Wikidata Query Builder (Wikidata Query Builder - sprint 3) board. Michael removed a project: User-Michael. Michael added a comment. This is not the one I wanted to pick TASK DETAIL

[Wikidata-bugs] [Maniphest] T266549: Create a repository that makes requests to Wikidata

2020-10-28 Thread Michael
Michael moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 3) board. Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T266549 WORKBOARD https

[Wikidata-bugs] [Maniphest] T265884: Keyboard navigation for selecting an item

2020-10-28 Thread Michael
Michael added a comment. Enter behavior GIVEN some text is in the input AND the menu is open and shows some results AND one of the results has been highlighted with the arrow keys WHEN the user presses the Enter key THEN the currently highlighted Item is selected AND the menu

[Wikidata-bugs] [Maniphest] T265884: Keyboard navigation for selecting an item

2020-10-28 Thread Michael
Michael added a comment. Tab navigation GIVEN no text is in the input AND the menu is closed (as it should always be in this case) WHEN the user presses the tab key THEN the focus moves to the next element GIVEN some text is in the input AND the menu is open and shows some

[Wikidata-bugs] [Maniphest] T265884: Keyboard navigation for selecting an item

2020-10-28 Thread Michael
Michael added a comment. Escape navigation GIVEN some text is in the input AND the menu is open and shows some results AND one of the results has been highlighted with the arrow keys WHEN the user presses Escape key THEN the menu is closed AND no item is selected GIVEN

[Wikidata-bugs] [Maniphest] T266646: Create a story that shows the bare LookupMenu component

2020-10-28 Thread Michael
Michael moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 2) board. Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T266646 WORKBOARD https

[Wikidata-bugs] [Maniphest] T266646: Create a story that shows the bare LookupMenu component

2020-10-28 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 2). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION This story can be used for design validation and visual regression tests if we decide to reuse

[Wikidata-bugs] [Maniphest] T263565: First simple query - input of string values only with dynamic Property

2020-10-28 Thread Michael
Michael moved this task from Wikidata Query Builder - sprint 2 to Ready to pick up on the Wikidata Query Builder board. Michael edited projects, added Wikidata Query Builder; removed Wikidata Query Builder (Wikidata Query Builder - sprint 2). TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T266595: Add story for Lookup with error state and warning state

2020-10-27 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 2). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Design specifies that the Lookup component can be both in an error and in a warning state

[Wikidata-bugs] [Maniphest] T266594: The lookup can show disabled items

2020-10-27 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata Query Builder (Wikidata Query Builder - sprint 2). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Some provided results may not be selectable for various reasons. They should be shown with a different

[Wikidata-bugs] [Maniphest] T264089: Create look-up component

2020-10-27 Thread Michael
Michael added a comment. What is currently still missing: - handling for deactivated items - loading state - A story showcasing error and warning states TASK DETAIL https://phabricator.wikimedia.org/T264089 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T266549: Create a repository that makes requests to Wikidata

2020-10-27 Thread Michael
Michael added a comment. This should probably result in a request similar to https://www.wikidata.org/w/api.php?action=wbsearchentities=firs=json=plaintext=en=en=property TASK DETAIL https://phabricator.wikimedia.org/T266549 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T266496: Not possible to add any Math properties

2020-10-26 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266496 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Lydia_Pintscher, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Maosef

[Wikidata-bugs] [Maniphest] T266496: Not possible to add any Math properties

2020-10-26 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite, Math. TASK DESCRIPTION It seems it is currently not possible to add new statements with the `math` datatype. Because of some still unknown error, the js frontend is using `{"value":"a + b&q

[Wikidata-bugs] [Maniphest] T266493: Wikibase Exception for wbformatvalue API call with type=unknown

2020-10-26 Thread Michael
Michael created this task. Michael added projects: Wikidata, Wikidata-Campsite. TASK DESCRIPTION If the `wbformatvalue` api is called with the string `unknwon` for the type, then an Exception is thrown and an internal server error is logged. See the parent ticket for more information

[Wikidata-bugs] [Maniphest] T265521: No formatter defined for value type unknown.

2020-10-26 Thread Michael
Michael added a comment. The error seems to be in the JS when trying to create a new statement with that property. The `setClaim` api call already contains `"type": "unknown"`, which is incorrect. claim "{\"type\":\"statement\",\&

[Wikidata-bugs] [Maniphest] T265521: No formatter defined for value type unknown.

2020-10-26 Thread Michael
Michael added a project: Math. Michael added a comment. Adding the #math <https://phabricator.wikimedia.org/tag/math/> project as it seems that it is properties its datatype that experiences a performance degradation. The cause is still unclear, might very well be in Wikibase. TASK

[Wikidata-bugs] [Maniphest] T265521: No formatter defined for value type unknown.

2020-10-26 Thread Michael
Michael added a comment. This keeps happening in `-wmf.13` and `-wmf.14`: https://logstash.wikimedia.org/goto/f9866a8f6737cbfd5eb32fef328adfd9 It occurs when trying to add a statement for title in LaTeX <https://www.wikidata.org/wiki/Property:P6835>. TASK DETAIL

[Wikidata-bugs] [Maniphest] T265012: Implement the actual lookup behavior

2020-10-26 Thread Michael
Michael claimed this task. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T265012 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Jakob_WMDE, Akuckartz, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T265010: Implement the "no match found" error state

2020-10-26 Thread Michael
Michael added a comment. -> https://github.com/wmde/wikit/pull/232 TASK DETAIL https://phabricator.wikimedia.org/T265010 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, Michael Cc: Michael, Aklapper, Jakob_WMDE, Akuckartz, Nand

[Wikidata-bugs] [Maniphest] T265976: Lexeme daily browser tests (against beta) flaky

2020-10-26 Thread Michael
Michael added a comment. Looking at the last 5 failures as of now, it seems to be covered by just two errors: 3x `Can't call click on element with selector "#wpLoginAttempt" because element wasn't found` 2x `element (".representation-widget_representation-value-input&qu

[Wikidata-bugs] [Maniphest] T266455: Make Wikibase Travis CI use Composer 2

2020-10-26 Thread Michael
Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, Djdungti

[Wikidata-bugs] [Maniphest] T266455: Make Wikibase Travis CI use Composer 2

2020-10-26 Thread Michael
Michael added a subtask: T248908: composer-merge-plugin support for composer 2.0. TASK DETAIL https://phabricator.wikimedia.org/T266455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T266459: Pin composer to v1 in Wikibase Travis CI

2020-10-26 Thread Michael
Michael added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). TASK DETAIL https://phabricator.wikimedia.org/T266459 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Alter-paule, Beast1978, Un1tY, Akuckartz

[Wikidata-bugs] [Maniphest] T266459: Pin composer to v1 in Wikibase Travis CI

2020-10-26 Thread Michael
Michael created this task. Michael added projects: Wikidata, Composer. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Wikibase Travis CI is currently broken on master <https://travis-ci.org/github/wikimedia/mediawiki-extensions-Wikibase/builds/738908782> because w

[Wikidata-bugs] [Maniphest] T266455: Make Wikibase Travis CI use Composer 2

2020-10-26 Thread Michael
Michael changed the task status from "Open" to "Stalled". Michael updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T266455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael

[Wikidata-bugs] [Maniphest] T266455: Make Wikibase Travis CI use Composer 2

2020-10-26 Thread Michael
Michael created this task. Michael added projects: Wikidata, Composer. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION TODO description TASK DETAIL https://phabricator.wikimedia.org/T266455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T265299: Investigate integrating accessibility testing tools into development tooling

2020-10-23 Thread Michael
Michael moved this task from Peer Review to Test (Verification) on the Wikidata Query Builder (Wikidata Query Builder - sprint 2) board. Michael added a comment. The two links provided give me a good overview over which rules are covered. At the same time they illustrate the often emphasized

[Wikidata-bugs] [Maniphest] T265583: Wire icons to the message component

2020-10-23 Thread Michael
Michael claimed this task. Michael moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 2) board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T265583 WORKBOARD https

  1   2   3   4   5   6   7   8   9   10   >