[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions
SBisson removed a project: Wikistories. TASK DETAIL https://phabricator.wikimedia.org/T328497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: SBisson Cc: KSiebert, WMDE-Fisch, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope, Legoktm, TrevorParscal, ori, Ricordisamoa, Krenair, gerritbot, Florian, brion, Nikerabbit, Tgr, pmiazga, Ciencia_Al_Poder, Tacsipacsi, Ltrlg, AntiCompositeNumber, kostajh, Universal_Omega, Michael, alistair3149, Jdlrobson, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, KLawal-WMF, Adamm71, PMenon-WMF, gonzalez.actor, Jersione, Hellket777, LisafBia6531, Wangombe, Astuthiodit_1, vyuen, Gethan, STH, 786, Sgs, fenpedia, lbowmaker, VPuffetMichel, BTullis, Biggs657, karapayneWMDE, toberto, Simonmaignan, Invadibot, LaMagiaaa, DesignerThan, Func, Zabe, Ywats0ns, H0bby, Asartea, diegodlh, Bebiezaza, maantietaja, Parlautan, calbon, Wilmanbeno, GhostInTheMachine, Juan90264, Zblace, Rost_WMDE, Anerka, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Nintendofan885, Akuckartz, Soda, Ironie, Demian, apaskulin, Dzaky17, Hook696, CptViraj, Erdinc_Ciftci_WMDE, darthmon_wmde, Eihel, Jtneill, abi_, taavi, MJL, Kent7301, Chambersjay, FriedrickMILBarbarossa, joker88john, Dinadineke, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Klaas_Z4us_V, Matlin, Tumz24, Gaboe420, Urfiner, Jony, lucamauri, Patriccck, CycloneIsaac, Giuliamocci, tabish.shaikh91, Cpaulf30, Lahi, Gq86, Af420, Xinbenlv, Vacio, Ramsey-WMF, SapphieWillie, dmaza, Bsandipan, Daimona, Xover, Lucas_Werkmeister_WMDE, Gboyers, GoranSMilovanovic, Fz-29, Chicocvenancio, JakeTheDeveloper, Mahir256, QZanden, cmadeo, Viveksr96, Esc3300, merbst, LawExplorer, spatton, RIT_RAJARSHI, Flycatchr, Vali.matei, Samuele2002, Lewizho99, Lemondoge, Maathavan, Wugapodes, elukey, Assassas77, YonaB, _jensen, Jseddon, rosalieper, Jason_Quinn, Agabi10, Bodhisattwa, Mkdw, XanonymusX, Taiwania_Justo, Neuronton, shinjiman, gabriel-wmde, Scott_WUaS, mb, Cirdan, Samwilson, DStrine, Shangkuanlc, Volker_E, XenoRyet, Izno, SBisson, Wong128hk, Luke081515, freephile, Unapersona, IKhitron, abian, MusikAnimal, Zache, Hsarrazin, Wikidata-bugs, Snowolf, Base, aude, AndyRussG, Ebe123, Pcoombe, Dinoguy1000, Amire80, jeblad, jayvdb, Mvolz, RandomDSdevel, Kipod, Shizhao, fbstj, Paladox, Arrbee, santhosh, KartikMistry, Isarra, Alchimista, Billinghurst, TheDJ, Ladsgroup, Jackmcbarn, Mbch331, jayantanth, Jay8g, ashley, jeremyb, PWaigi-WMF, MaryMunyoki ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] [Commented On] T225164: Notifications appear to be broken on Wikidata
SBisson added a comment. @Niharika looking at the DB you don't have any notifications on wikidata. Were you able to see those notifications from another wiki? TASK DETAIL https://phabricator.wikimedia.org/T225164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: SBisson Cc: Reedy, SBisson, Aklapper, Niharika, darthmon_wmde, Premeditated, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Jonas, Luke081515, Wikidata-bugs, aude, Catrope, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T225164: Notifications appear to be broken on Wikidata
SBisson added a comment. @Niharika what do you see on Special:Notifications? Do you have `Show notifications from other wikis` checked in your wikidata or global preferences? TASK DETAIL https://phabricator.wikimedia.org/T225164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: SBisson Cc: SBisson, Aklapper, Niharika, darthmon_wmde, Premeditated, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Jonas, Luke081515, Wikidata-bugs, aude, Catrope, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T224596: Wikibase browser tests blocking merge of unrelated patches
SBisson closed this task as a duplicate of T224546: Make WikibaseLexeme browser tests less flaky. TASK DETAIL https://phabricator.wikimedia.org/T224596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: SBisson Cc: Aklapper, SBisson, E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, zeljkofilipin, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T224596: Wikibase browser tests blocking merge of unrelated patches
SBisson created this task.
SBisson added projects: Wikidata, Browser-Tests.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Trying to merge gerrit:512926
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/512926>
but Wikibase browser tests keep failing.
Output from the last failures:
10:24:10 1) Lexeme:Senses Adding Sense:
10:24:10 element (".wikibase-lexeme-sense-gloss >
.wikibase-lexeme-sense-gloss-value-cell > span") still not existing after
1ms
10:24:10 running chrome
10:24:10 Error: element (".wikibase-lexeme-sense-gloss >
.wikibase-lexeme-sense-gloss-value-cell > span") still not existing after
1ms
10:24:10 at SensePage.getNthSenseData
(extensions/WikibaseLexeme/tests/selenium/pageobjects/sense.page.js:91:66)
10:24:10 at Context.it
(extensions/WikibaseLexeme/tests/selenium/specs/sense.js:30:25)
10:24:10 at Promise.F
(node_modules/core-js/library/modules/_export.js:36:28)
10:24:10 at elements(".wikibase-lexeme-sense-gloss >
.wikibase-lexeme-sense-gloss-value-cell > span") - isExisting.js:46:17
10:24:10 at isExisting(".wikibase-lexeme-sense-gloss >
.wikibase-lexeme-sense-gloss-value-cell > span") - waitForExist.js:67:22
10:24:10
10:24:10 2) Lexeme:Senses Added Sense has statement:
10:24:10 An element could not be located on the page using the given search
parameters (".wikibase-lexeme-sense-statements h2 > span").
10:24:10 running chrome
10:24:10 Error: An element could not be located on the page using the given
search parameters (".wikibase-lexeme-sense-statements h2 > span").
10:24:10 at Context.it
(extensions/WikibaseLexeme/tests/selenium/specs/sense.js:45:34)
10:24:10 at Promise.F
(node_modules/core-js/library/modules/_export.js:36:28)
10:24:10 at getText() - at SensePage.get senseStatements [as
senseStatements]
(extensions/WikibaseLexeme/tests/selenium/pageobjects/sense.page.js:46:61)
10:24:10
10:24:10 3) Lexeme:Senses Anchor exists and is equal to Sense ID:
10:24:10 undefined === ''
10:24:10 running chrome
10:24:10 AssertionError: undefined === ''
10:24:10 at Context.it
(/workspace/src/extensions/WikibaseLexeme/tests/selenium/specs/sense.js:55:10)
10:24:10 at Promise.F
(/workspace/src/node_modules/core-js/library/modules/_export.js:36:28)
TASK DETAIL
https://phabricator.wikimedia.org/T224596
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: SBisson
Cc: Aklapper, SBisson, darthmon_wmde, Premeditated, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs,
aude, zeljkofilipin, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T218702: ParserIntegrationTest for Scribunto failing in Wikibase CI
SBisson added a comment.
We are seeing a similar (but not quite the same) error here. Can it be
related?
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GrowthExperiments/+/497955/
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/40899/console
01:34:35 1) ParserIntegrationTest::testParse with data set
"parserTests.txt: " ('[details omitted]')
01:34:35 === Logs generated by test case
01:34:35 [wfDebug] [debug] ParserTestRunner::runTest: running
{"private":false}
01:34:35 [wfDebug] [debug] Parser: using preprocessor: Preprocessor_Hash
{"private":false}
01:34:35 [MessageCache] [info] MessageCache::load: Loading en... local
cache is empty, global cache is expired/volatile, loading from database
{"private":false}
01:34:35 [PHPUnitCommand] [info] FAILURE in
ParserIntegrationTest::testParse with data set "parserTests.txt: ":
[PHPUnit_Framework_ExpectationFailedException] Failed asserting that two
strings are equal. {"private":false}
01:34:35 ===
01:34:35 Failed asserting that two strings are equal.
01:34:35 --- Expected
01:34:35 +++ Actual
01:34:35 @@ @@
01:34:35 '
01:34:35 -
01:34:35 -'
01:34:35 +'
01:34:35
01:34:35 /workspace/src/tests/phpunit/suites/ParserIntegrationTest.php:53
TASK DETAIL
https://phabricator.wikimedia.org/T218702
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: cscott, SBisson
Cc: SBisson, kostajh, Anomie, cscott, Jdforrester-WMF, ssastry, Arlolra,
gerritbot, Aklapper, TerraCodes, Liuxinyu970226, Addshore, alaa_wmde, Nandana,
Lahi, Gq86, GoranSMilovanovic, QZanden, rafidaslam, LawExplorer, Lemondoge,
SundanceRaphael, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Dinoguy1000,
jayvdb, MrStradivarius, Lydia_Pintscher, Jackmcbarn, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T204159: Fatal "Call getPrefixedText on a non-object" from WikibaseClient on ApiEchoNotifications
SBisson moved this task from Inbox to External on the Growth-Team board.SBisson added a comment. It's probably just a matter of checking that the event object has a title object before trying to call getPrefixedText() on it. https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/master/client/includes/Notifications/PageConnectionPresentationModel.php#24 Moving to "Growth team/External" since I believe it should be fixed in Wikibase and not in Echo but the Growth team is happy to help if needed.TASK DETAILhttps://phabricator.wikimedia.org/T204159WORKBOARDhttps://phabricator.wikimedia.org/project/board/1114/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: SBisson, Krinkle, Aklapper, kostajh, MMiller_WMF, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Taiwania_Justo, Luke081515, Wikidata-bugs, aude, Catrope, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T182318: New filters for edit review on Watchlist can't be opt-out on wikis
SBisson added a subscriber: Etonkovidova.SBisson merged a task: T182272: [wmf.11 - regression] "New filters for edit review" beta feature has no effect on Watchlist . TASK DETAILhttps://phabricator.wikimedia.org/T182318EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: Etonkovidova, gerritbot, TerraCodes, Jay8g, Liuxinyu970226, Aklapper, SBisson, Trizek-WMF, Lea_Lacroix_WMDE, Petar.petkovic, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Iniquity, jmatazzoni, Wikidata-bugs, aude, RandomDSdevel, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T182318: New filters for edit review on Watchlist can't be opt-out on wikis
SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Next-Quarter). TASK DETAILhttps://phabricator.wikimedia.org/T182318EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: gerritbot, TerraCodes, Jay8g, Liuxinyu970226, Aklapper, SBisson, Trizek-WMF, Lea_Lacroix_WMDE, Petar.petkovic, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Iniquity, jmatazzoni, Wikidata-bugs, aude, RandomDSdevel, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T182318: New filters for edit review on Watchlist can't be opt-out on wikis
SBisson claimed this task.SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-Next-Quarter); removed Collaboration-Team-Triage. TASK DETAILhttps://phabricator.wikimedia.org/T182318EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: gerritbot, TerraCodes, Jay8g, Liuxinyu970226, Aklapper, SBisson, Trizek-WMF, Lea_Lacroix_WMDE, Petar.petkovic, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Iniquity, jmatazzoni, Wikidata-bugs, aude, RandomDSdevel, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168487: ORES: Don't highlight changes propagated from Wikidata
SBisson added a comment. From the task description: There should be no highlighting for these rows regardless of whether it's using the original ORES highlighting or the newer highlighting done by RC Page itself. Note that the patch above doesn't handle the original ORES highlighting. Also, not sure how wikidata and log entries end up with scores. The ORES extension fetches scores only for RC_EDIT and RC_NEW.[1] [1] https://phabricator.wikimedia.org/diffusion/EORS/browse/master/includes/Hooks.php;9aad3388866bf99de0862fe7a28deec9979089b9$76TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Catrope, SBissonCc: SBisson, gerritbot, PokestarFan, Catrope, Halfak, Aklapper, Mattflaschen-WMF, bkowshik, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Avner, Lewizho99, Maathavan, Iniquity, jmatazzoni, Izno, Wikidata-bugs, aude, He7d3r, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T150060: Implement functionality for RC page 'Type of change' filters
SBisson added a comment. In T150060#2924130, @jmatazzoni wrote: So, given the above, can we close this ticket? yesTASK DETAILhttps://phabricator.wikimedia.org/T150060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: Etonkovidova, gerritbot, Aklapper, Pginer-WMF, Trizek-WMF, Catrope, Quiddity, Liuxinyu970226, Mattflaschen-WMF, SBisson, jmatazzoni, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T150060: Implement functionality for RC page 'Type of change' filters
SBisson added a comment. In T150060#2922068, @jmatazzoni wrote: In the scheme we've defined, Flow edits (excluding Flow edits that create a new topic) belong with Page edits and only Page edits. That should be our goal. So, to use a negative example, if I uncheck everything except Category changes, I should see Category changes only—and no Flow edits. If that is not what is happening—if Flow edits are slipping through because they're not addressed by the RC page filters—then we should fix that. @SBisson, can you clarify? Will Flow edits be included with Page edits and only Page edits? (If not, do you want to fix it in this ticket or should we create a separate ticket?) tldr: I'm working on T154486, which rolls new topics into the "new pages" filter. I will include all other Flow changes in the "page edits" filter as part of the same ticket, which I've updated accordingly. It's unfortunately not as simple as it sounds since from RC's perspective, all this data is only tagged as "Flow". There's no notion of "new" or anything else. It makes it quite hard to filter. I'll probably have to change how data is stored. The "N" is added during rendering when all the data is loaded and we can check a number of Flow-specific conditions (first version of the first reply to a non-moderated topic - it has nothing to do with the related Topic page).TASK DETAILhttps://phabricator.wikimedia.org/T150060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: Etonkovidova, gerritbot, Aklapper, Pginer-WMF, Trizek-WMF, Catrope, Quiddity, Liuxinyu970226, Mattflaschen-WMF, SBisson, jmatazzoni, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T147122: Flow\Exception\InvalidInputException displayed after enable/disable Flow talk page beta feature
SBisson closed this task as a duplicate of T138310: Flow as a Beta feature: enable, disable and reenable doesn't seem to work. TASK DETAILhttps://phabricator.wikimedia.org/T147122EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: Ashot1997, Trizek-WMF, Quiddity, gerritbot, aaron, bd808, aude, Reedy, Aklapper, Doror, EnricoCNC, Lewizho99, Maathavan, D3r1ck01, Izno, SBisson, Wikidata-bugs, Gryllida, jeblad, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
