Wrh2 added a comment.
I haven't seen the issue re-occur since the change went live, so I think it
should be OK to close this issue now. I just clicked on "Random page" about 50
times and all articles had correct TOCs. Thanks to everyone who helped
investigate.
Since th
Wrh2 added a comment.
While I haven't noticed the issue in the past week, if there's no harm in
doing so I would leave this open for another week just to be certain. The
weekly (Wednesday?) software release seems to have been a trigger for this
issue in the past, but if I'm reading
https
Wrh2 added a comment.
If the template was at fault the behavior should be consistent - currently if
a page is edited or flushed from the cache the banner always shows correctly,
but after some time passes TOCs start showing up within articles, which doesn't
seem like a template issue to me
Wrh2 added a comment.
Cache is cleared fairly regularly even if articles aren't edited - I've made
minor updates to Template:Pagebanner numerous times over the past months, which
forces a cache flush of all articles with page banners.
https://en.wikivoyage.org/wiki/Kedung_Kayang says
Wrh2 added a comment.
In https://phabricator.wikimedia.org/T121135#2182312, @Jdlrobson wrote:
> @Whr2 have there been any reports of this happening on pages that have been
edited since the 4th March? MobileFrontend was causing an issue with TOC
rendering which should have been fi
Wrh2 added a comment.
Pinging Jdlrobson as I believe that this issue is the one being referenced in
the English Wikivoyage discussion earlier today:
https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Pagebanner_-_why_cannot_it_not_be_fixed
TASK DETAIL
https
Wrh2 added a comment.
When the issue occurs it happens on a random subset of articles. I saw it
several times last night, and after hitting "random page" many, many times this
morning I found the following two articles which are showing an in-article TOC:
https://en.wikivoyag
Wrh2 added a comment.
The issue is re-occurring today, even with the cache-buster param:
https://en.wikivoyage.org/wiki/Gilimanuk?_=21947979
TASK DETAIL
https://phabricator.wikimedia.org/T121135
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Wrh2
Wrh2 added a comment.
I'll need to test out the query param the next time the issue occurs. I just
forced a cache flush yesterday, so it will probably be at least 2-3 days.
TASK DETAIL
https://phabricator.wikimedia.org/T121135
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings
Wrh2 added a comment.
Not sure if the following might reveal a pattern that anyone recognizes, here
are the times that I've purged the pagebanner cache on English Wikivoyage after
encountering in-article TOCs during the past two weeks (per
https://en.wikivoyage.org/w/index.php?title
Wrh2 added a comment.
In https://phabricator.wikimedia.org/T121135#1915771, @Tgr wrote:
> Is the problem with the parser cache or Varnish? Do you need an actual purge
> to fix it, or is adding some cachebreaker like `?_=21947979` to the end of
> the URL enough to show the corre
Wrh2 added a comment.
I'm not aware of any other TOC extensions. I suspect that the behavior may
occur during the weekly(?) Mediawiki software updates. Is it possible the
banner extension isn't enabled until after the cache has started rebuilding
following a software update?
TASK DETAIL
Wrh2 added a comment.
Just to clarify (since it seems there may be some confusion), the problem on
both Russian and English Wikivoyage isn't that the banner does not appear, it
is that the TOC appears within the article rather than as part of the banner.
TASK DETAIL
https
Wrh2 added a subscriber: Wrh2.
Wrh2 added a comment.
Yes, this problem occurs regularly on English Wikivoyage. Forcing an update to
https://en.wikivoyage.org/wiki/Template:Pagebanner typically resolves the
issue, but it seems like we have to do so on almost a weekly basis.
TASK DETAIL
Wrh2 added a comment.
I don't recall seeing a "1" for the TOC since we purged the cache for all
articles last week, so it's probably safe to call this issue resolved now.
TASK DETAIL
https://phabricator.wikimedia.org/T115719
EMAIL PREFERENCES
https://phabricator.wikimedia.or
Wrh2 added a comment.
On English Wikivoyage I just made a minor edit to
https://en.wikivoyage.org/wiki/Template:Pagebanner which should hopefully force
a cache purge for all pages using that template. It seems to have done the
trick for the handful of pages that I checked -
https
Wrh2 added a comment.
It may be too early for feedback since the updated extension apparently just
went out today, but in a random sample of articles on Wikivoyage just now I
would say that the majority of them exhibited the behavior with the incorrect
TOC, so it may be premature to mark
Wrh2 added a subscriber: Wrh2.
Wrh2 added a comment.
I'm not sure if this is helpful or not, but when this issue first surfaced it
was proposed that it might be a caching issue, and that over time it would go
away. https://en.wikivoyage.org/wiki/Morro_Bay is an article that I have
edited
Wrh2 created this task.
Wrh2 assigned this task to Jdlrobson.
Wrh2 added a subscriber: Wrh2.
Wrh2 added a project: Wikidata-Page-Banner.
Herald added a subscriber: Aklapper.
Herald added a project: Wikidata.
TASK DESCRIPTION
All page banners on Wikivoyage are being added to the new
Wrh2 added a comment.
The individual who originally reported this issue now also says it is fixed.
Thanks again Sumit - this task can now be closed.
TASK DETAIL
https://phabricator.wikimedia.org/T111710
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Wrh2 added a comment.
The fix seems to be working on Wikivoyage, this issue can be closed.
TASK DETAIL
https://phabricator.wikimedia.org/T111593
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson, Wrh2
Cc: Sumit, gerritbot, Jdlrobson
Wrh2 added a comment.
I was unable to reproduce the issue just now, but have also asked for feedback
from the original reporters at
https://en.wikivoyage.org/wiki/Wikivoyage:Travellers'_pub#banner_not_displaying.
Thanks for the quick attention.
TASK DETAIL
https://phabricator.wikimedia.org
Wrh2 added a comment.
@Sumit - see my second comment on this ticket. I've tried updating my
common.js file with the Javascript Jdlrobson suggested, as well as the
Javascript you provided, but in both cases I'm still able to reproduce the
problem. It appears that either Firefox is firing
Wrh2 created this task.
Wrh2 added subscribers: Wrh2, Jdlrobson.
Wrh2 added a project: Wikidata-Page-Banner.
Herald added a subscriber: Aklapper.
Herald added a project: Wikidata.
TASK DESCRIPTION
See the discussion at
https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub
Wrh2 added a comment.
@Jdlrobson I tried the code you provided in my local common.js, as well as
executing on window.load (since the JQuery load event handler can be flaky) but
was still able to reproduce the issue.
This might not be a great workaround, but if I'm understanding the purpose
Wrh2 added a comment.
Thanks for the quick response & patch!
TASK DETAIL
https://phabricator.wikimedia.org/T111593
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Wrh2
Cc: Sumit, gerritbot, Jdlrobson, Aklapper, Wrh2, Wikidata-bugs,
Wrh2 added a subscriber: Jdlrobson.
Wrh2 set Security to None.
TASK DETAIL
https://phabricator.wikimedia.org/T111593
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Wrh2
Cc: Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher
Wrh2 created this task.
Wrh2 added a subscriber: Wrh2.
Wrh2 added a project: Wikidata-Page-Banner.
Herald added a subscriber: Aklapper.
Herald added a project: Wikidata.
TASK DESCRIPTION
English Wikivoyage pages with the pagebanner extension enabled are not
setting the HTML tag correctly
Wrh2 added a subscriber: Wrh2.
TASK DETAIL
https://phabricator.wikimedia.org/T109811
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Wrh2
Cc: Wrh2, gerritbot, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher,
Malyacko
Wrh2 removed a subscriber: Wrh2.
TASK DETAIL
https://phabricator.wikimedia.org/T77925
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences
Wrh2 added a comment.
In https://phabricator.wikimedia.org/T93106#1173339, @Nemo_bis wrote:
Wikivoyage in what language? What language editions have been contacted about
this proposal?
I'm not sure of all notifications that have been done, but I've seen feedback
solicited in the English
Wrh2 added a comment.
I'm a bit concerned as to whether there are sufficient requirements to ensure
that someone who isn't already familiar with Wikivoyage will be able to
implement a solution that is actually going to be used on Wikivoyage. Currently
page banners work just fine on the full
Wrh2 added a comment.
In https://phabricator.wikimedia.org/T77925#1091036, @Jdlrobson wrote:
@wrh2 any ideas from an editors perspective how you would like this to work
without templates?
Ideally I would imagine an edit button on the banner which when clicked pops
up an input field where
Wrh2 added a comment.
In https://phabricator.wikimedia.org/T77925#1098331, @Sumit wrote:
Just out of curiosity, the wikivoyage home page uses the banner template(
http://en.wikivoyage.org/wiki/Template:Banner ) to render the banners there,
which are not included in mobile. Can we also
Wrh2 added a comment.
In https://phabricator.wikimedia.org/T77925#1078790, @Jdlrobson wrote:
@Wrh2 this would be the hope.
The only remaining question here seems to be how to override the Wikidata
property. Where would such a value get stored (note this extension would
deprecate the need
Wrh2 added a comment.
If this proposal does move forward there needs to be a way to locally override
the Wikidata property, as has been previously mentioned. Additionally, if
possible, a major shortcoming of the current banners is that they require
hiding the h1 tag with display:none CSS
36 matches
Mail list logo
