[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. I haven't seen the issue re-occur since the change went live, so I think it should be OK to close this issue now. I just clicked on "Random page" about 50 times and all articles had correct TOCs. Thanks to everyone who helped investigate. Since the original issue was sporadic, if the problem should re-occur in the future, is is the correct process to open a new ticket or to re-open this ticket? TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Wrh2 Cc: dr0ptp4kt, TerraCodes, EBernhardson, gerritbot, BBlack, faidon, Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, MMax8338, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment.
While I haven't noticed the issue in the past week, if there's no harm in
doing so I would leave this open for another week just to be certain. The
weekly (Wednesday?) software release seems to have been a trigger for this
issue in the past, but if I'm reading
https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Server_switch_2016
("There will be a code freeze for the week of 18 April") correctly then there
was no release this week.
TASK DETAIL
https://phabricator.wikimedia.org/T121135
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson, Wrh2
Cc: TerraCodes, MaxSem, EBernhardson, gerritbot, BBlack, faidon, Tgr, jcrespo,
Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper,
MMax8338, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra,
Jackmcbarn, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment.
If the template was at fault the behavior should be consistent - currently if
a page is edited or flushed from the cache the banner always shows correctly,
but after some time passes TOCs start showing up within articles, which doesn't
seem like a template issue to me. I can update the template, but doing so will
flush all banners on the site and it will be several days until the problem
shows up again - if you don't need to see any example pages to debug further
let me know if it's safe to update the template. Also, are you certain you
want __NOTOC__? That would suppress the TOC from both the article and the
banner if I'm understanding correctly, which doesn't seem right.
To explain what the template code is doing:
toc={{#ifeq: {{{notoc|}}} | true | no | yes }}
Per https://www.mediawiki.org/wiki/Extension:WikidataPageBanner the page
banner extension takes a parameter of "toc=yes" or "toc=no" to determine
whether to display the TOC in the banner or in the article. This template code
says that when a "notoc" param is passed to the template with the exact value
of "true" that the pagebanner will be invoked with "toc=no"; at all other times
it will be invoked with "toc=yes".
TASK DETAIL
https://phabricator.wikimedia.org/T121135
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jdlrobson, Wrh2
Cc: BBlack, faidon, Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2,
Sumit, Jdlrobson, Atsirlin, Aklapper, TerraCodes, D3r1ck01, Izno,
Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. Cache is cleared fairly regularly even if articles aren't edited - I've made minor updates to Template:Pagebanner numerous times over the past months, which forces a cache flush of all articles with page banners. https://en.wikivoyage.org/wiki/Kedung_Kayang says it was last edited on 10 March 2016 and I'm seeing an in-article TOC. TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Wrh2 Cc: faidon, Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, TerraCodes, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. In https://phabricator.wikimedia.org/T121135#2182312, @Jdlrobson wrote: > @Whr2 have there been any reports of this happening on pages that have been edited since the 4th March? MobileFrontend was causing an issue with TOC rendering which should have been fixed since then. > > If you can point me at a new example I can debug this further. I see it multiple times each week, and it has definitely still been occurring since March 4. After hitting "random page" three times on Wikivoyage just now I reached https://en.wikivoyage.org/wiki/Hatsukaichi which is showing the TOC in the article instead of the banner as of 4:10PM Pacific time. TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: faidon, Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, TerraCodes, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. Pinging Jdlrobson as I believe that this issue is the one being referenced in the English Wikivoyage discussion earlier today: https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Pagebanner_-_why_cannot_it_not_be_fixed TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: faidon, Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, TerraCodes, D3r1ck01, Izno, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. When the issue occurs it happens on a random subset of articles. I saw it several times last night, and after hitting "random page" many, many times this morning I found the following two articles which are showing an in-article TOC: https://en.wikivoyage.org/wiki/Jorepokhri https://en.wikivoyage.org/wiki/Megaplatanos F3220727: Megaplatanos.html <https://phabricator.wikimedia.org/F3220727> F3220728: Jorepokhri.html <https://phabricator.wikimedia.org/F3220728> TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. The issue is re-occurring today, even with the cache-buster param: https://en.wikivoyage.org/wiki/Gilimanuk?_=21947979 TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. I'll need to test out the query param the next time the issue occurs. I just forced a cache flush yesterday, so it will probably be at least 2-3 days. TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. Not sure if the following might reveal a pattern that anyone recognizes, here are the times that I've purged the pagebanner cache on English Wikivoyage after encountering in-article TOCs during the past two weeks (per https://en.wikivoyage.org/w/index.php?title=Template:Pagebanner=history): - 19:42, 4 January 2016 - 09:07, 1 January 2016 - 10:05, 27 December 2015 - 18:11, 23 December 2015 - 15:46, 19 December 2015 Earlier in December and in November I either wasn't editing frequently enough to notice that the cache needed purging, or else the issue wasn't occurring as frequently. TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. In https://phabricator.wikimedia.org/T121135#1915771, @Tgr wrote: > Is the problem with the parser cache or Varnish? Do you need an actual purge > to fix it, or is adding some cachebreaker like `?_=21947979` to the end of > the URL enough to show the correct banner? It's not a browser cache issue, if that's what you're asking. I have to edit the shared template to trigger Mediawiki to rebuild the page cache for all articles with page banners when the problem occurs. TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Tgr, jcrespo, Krenair, Legoktm, LtPowers, mark, Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. I'm not aware of any other TOC extensions. I suspect that the behavior may occur during the weekly(?) Mediawiki software updates. Is it possible the banner extension isn't enabled until after the cache has started rebuilding following a software update? TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a comment. Just to clarify (since it seems there may be some confusion), the problem on both Russian and English Wikivoyage isn't that the banner does not appear, it is that the TOC appears within the article rather than as part of the banner. TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T121135: Banners fail to show up occassionally on Russian Wikivoyage
Wrh2 added a subscriber: Wrh2. Wrh2 added a comment. Yes, this problem occurs regularly on English Wikivoyage. Forcing an update to https://en.wikivoyage.org/wiki/Template:Pagebanner typically resolves the issue, but it seems like we have to do so on almost a weekly basis. TASK DETAIL https://phabricator.wikimedia.org/T121135 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Wrh2, Sumit, Jdlrobson, Atsirlin, Aklapper, Wikidata-bugs, aude, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T115719: Various pages display table of contents as '1'
Wrh2 added a comment. I don't recall seeing a "1" for the TOC since we purged the cache for all articles last week, so it's probably safe to call this issue resolved now. TASK DETAIL https://phabricator.wikimedia.org/T115719 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Wrh2 Cc: Atsirlin, gerritbot, Wrh2, Sumit, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T115719: Various pages display table of contents as '1'
Wrh2 added a comment. On English Wikivoyage I just made a minor edit to https://en.wikivoyage.org/wiki/Template:Pagebanner which should hopefully force a cache purge for all pages using that template. It seems to have done the trick for the handful of pages that I checked - https://en.wikivoyage.org/wiki/Culver_City showed the problem earlier this morning but is displaying correctly now. TASK DETAIL https://phabricator.wikimedia.org/T115719 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Wrh2 Cc: Atsirlin, gerritbot, Wrh2, Sumit, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T115719: Various pages display table of contents as '1'
Wrh2 added a comment. It may be too early for feedback since the updated extension apparently just went out today, but in a random sample of articles on Wikivoyage just now I would say that the majority of them exhibited the behavior with the incorrect TOC, so it may be premature to mark this issue as "resolved". The problem only starting occurring in the past several weeks, so assuming it is not yet fixed, it seems likely that it was introduced by a recent change. TASK DETAIL https://phabricator.wikimedia.org/T115719 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Wrh2 Cc: gerritbot, Wrh2, Sumit, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T115719: Various pages display table of contents as '1'
Wrh2 added a subscriber: Wrh2. Wrh2 added a comment. I'm not sure if this is helpful or not, but when this issue first surfaced it was proposed that it might be a caching issue, and that over time it would go away. https://en.wikivoyage.org/wiki/Morro_Bay is an article that I have edited since the extension was updated (most recently on 15-October), it was working fine when I edited it, and today it is showing "1" for the TOC, so I think that rules out a cache problem. TASK DETAIL https://phabricator.wikimedia.org/T115719 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Wrh2, Sumit, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T114342: "toc" is not treated as a valid parameter by the pagebanner extension
Wrh2 created this task. Wrh2 assigned this task to Jdlrobson. Wrh2 added a subscriber: Wrh2. Wrh2 added a project: Wikidata-Page-Banner. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION All page banners on Wikivoyage are being added to the new "Category:WikidataPageBanner with unknown parameters" by the banner extension, due apparently to using the "toc" parameter. According to https://www.mediawiki.org/wiki/Extension:WikidataPageBanner "toc" is a valid parameter, so either the documentation is wrong or the extension is incorrect. See https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Banner_error_category for further details. TASK DETAIL https://phabricator.wikimedia.org/T114342 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Wrh2 Cc: Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111710: Image display problem on Firefox
Wrh2 added a comment. The individual who originally reported this issue now also says it is fixed. Thanks again Sumit - this task can now be closed. TASK DETAIL https://phabricator.wikimedia.org/T111710 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: gerritbot, Sumit, Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111593: MediaWiki:Pagetitle not obeyed on English Wikivoyage when pagebanner present
Wrh2 added a comment. The fix seems to be working on Wikivoyage, this issue can be closed. TASK DETAIL https://phabricator.wikimedia.org/T111593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, Wrh2 Cc: Sumit, gerritbot, Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111710: Image display problem on Firefox
Wrh2 added a comment. I was unable to reproduce the issue just now, but have also asked for feedback from the original reporters at https://en.wikivoyage.org/wiki/Wikivoyage:Travellers'_pub#banner_not_displaying. Thanks for the quick attention. TASK DETAIL https://phabricator.wikimedia.org/T111710 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: gerritbot, Sumit, Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111710: Image display problem on Firefox
Wrh2 added a comment. @Sumit - see my second comment on this ticket. I've tried updating my common.js file with the Javascript Jdlrobson suggested, as well as the Javascript you provided, but in both cases I'm still able to reproduce the problem. It appears that either Firefox is firing the onload event before the image is loaded or else JQuery is failing at a height calculation early in the load process. If I disable Javascript then everything seems to work fine, so this seems to be a problem specific to the positionBanner() method. Am I correct in the belief that the CSS this method appends is only needed when the "pos-x" and "pos-y" values are non-zero? If so I think the method can exit without changing any CSS if those values are zero, which should be a good temporary fix for the majority of pages while the underlying issue is addressed. TASK DETAIL https://phabricator.wikimedia.org/T111710 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: gerritbot, Sumit, Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T111710: Image display problem on Firefox
Wrh2 created this task.
Wrh2 added subscribers: Wrh2, Jdlrobson.
Wrh2 added a project: Wikidata-Page-Banner.
Herald added a subscriber: Aklapper.
Herald added a project: Wikidata.
TASK DESCRIPTION
See the discussion at
https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#banner_not_displaying.
If you browse the site on Firefox, occasionally when an image is not in the
cache the banner displays only partially.
In every case where I've been able to reproduce this bug I've seen a negative
"margin-top" style added to the image, and that appears to come from the
positionBanner() Javascript method. So far as I can tell, since the banner
image width and height are not specified in the HTML, the postitionBanner()
method should only be called once the banner image has downloaded, NOT on
document.ready() as it currently is. Thus, I think that changing
ext.WikidataPageBanner.positionBanner.js to only invoke positionBanner when the
image has loaded might fix the problem:
$( "img.wpb-banner-image" ).load(function() {
positionBanner( $wpbBannerImageContainer );
});
I'm not 100% positive that this change will fix the issue, but based on the
fact that the Javascript currently seems to be getting width/height
calculations wrong only in cases where the image is not cached it makes sense
conceptually that it would fix things.
TASK DETAIL
https://phabricator.wikimedia.org/T111710
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Wrh2
Cc: Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111710: Image display problem on Firefox
Wrh2 added a comment. @Jdlrobson I tried the code you provided in my local common.js, as well as executing on window.load (since the JQuery load event handler can be flaky) but was still able to reproduce the issue. This might not be a great workaround, but if I'm understanding the purpose of the positionBanner() method correctly, the method can exit immediately if both of the following are zero, correct? centerX = $wpbBannerImage.data( 'pos-x' ), centerY = $wpbBannerImage.data( 'pos-y' ); The bug will still be there for banners that use these parameters, but since those are a tiny subset of all banners it should at least resolve the problem until a better fix is found. TASK DETAIL https://phabricator.wikimedia.org/T111710 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Sumit, Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111593: MediaWiki:Pagetitle not obeyed on English Wikivoyage when pagebanner present
Wrh2 added a comment. Thanks for the quick response & patch! TASK DETAIL https://phabricator.wikimedia.org/T111593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Sumit, gerritbot, Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T111593: MediaWiki:Pagetitle not obeyed on English Wikivoyage when pagebanner present
Wrh2 added a subscriber: Jdlrobson. Wrh2 set Security to None. TASK DETAIL https://phabricator.wikimedia.org/T111593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Jdlrobson, Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T111593: MediaWiki:Pagetitle not obeyed on English Wikivoyage when pagebanner present
Wrh2 created this task.
Wrh2 added a subscriber: Wrh2.
Wrh2 added a project: Wikidata-Page-Banner.
Herald added a subscriber: Aklapper.
Herald added a project: Wikidata.
TASK DESCRIPTION
English Wikivoyage pages with the pagebanner extension enabled are not
setting the HTML tag correctly. See for example
https://en.wikivoyage.org/wiki/Yosemite_National_Park - the title should be
"Yosemite National Park – Travel guide at Wikivoyage", but it is just "Yosemite
National Park".
The MediaWiki:Pagetitle value is "$1 – Travel guide at {{SITENAME}}" -
https://en.wikivoyage.org/wiki/MediaWiki:Pagetitle.
Mainspace pages without page banners have their title tags set correctly -
see https://en.wikivoyage.org/wiki/Previous_Featured_travel_topics which has a
title of "Previous Featured travel topics – Travel guide at Wikivoyage".
This bug has serious SEO implications, so any attention would be much
appreciated.
TASK DETAIL
https://phabricator.wikimedia.org/T111593
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Wrh2
Cc: Aklapper, Wrh2, Wikidata-bugs, aude, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T109811: Heading inside banner should be an h1
Wrh2 added a subscriber: Wrh2. TASK DETAIL https://phabricator.wikimedia.org/T109811 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Wrh2, gerritbot, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T77925: Wikidata PageBanner extension
Wrh2 removed a subscriber: Wrh2. TASK DETAIL https://phabricator.wikimedia.org/T77925 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Bene, Nastoshka, zhuyifei1999, Sushrutsg, Andyrom75, Danapit, Glaisher, NiharikaKohli, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, Deskana, LtPowers, Aklapper, Florian, Lydia_Pintscher, KLans_WMF, Jdlrobson, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T93106: GSoC proposal for Wikivoyage PageBanner extension
Wrh2 added a comment. In https://phabricator.wikimedia.org/T93106#1173339, @Nemo_bis wrote: Wikivoyage in what language? What language editions have been contacted about this proposal? I'm not sure of all notifications that have been done, but I've seen feedback solicited in the English Wikivoyage pub (https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Pagebanner_extension_for_wikivoyage), and I posted a link to the phabricator discussion on the Wikivoyage page on meta so that other languages would be notified (https://meta.wikimedia.org/wiki/Wikivoyage/Lounge#Pagebanner_extension). TASK DETAIL https://phabricator.wikimedia.org/T93106 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Wrh2 Cc: Nemo_bis, Wrh2, Jdlrobson, KLans_WMF, Lydia_Pintscher, Florian, Aklapper, LtPowers, Deskana, Shaundd, Matroc, Nicolas_Raoul, Sumit, kaldari, Qgil, NiharikaKohli, Glaisher, Danapit, Andyrom75, Imaculate, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T77925: Wikidata PageBanner extension
Wrh2 added a comment. I'm a bit concerned as to whether there are sufficient requirements to ensure that someone who isn't already familiar with Wikivoyage will be able to implement a solution that is actually going to be used on Wikivoyage. Currently page banners work just fine on the full site, although they are definitely a hack. Is the goal of the extension solely to return a banner image sized appropriately for the user's browser on page load? Will the extension also implement the current Javascript functionality that resizes the banner when the user resizes the browser window? Will the extension implement the table of contents overlay, or the icon overlays (see https://en.wikivoyage.org/wiki/Template:Pagebanner)? Is this proposal solely meant for use on mobile, and something that won't be used for the full site? Or is it part of the GSOC project to figure out how to answer these questions and implement an extension that offers all of the functionality of the current template? I'm fully in support of making current page banners less of a hack, and making them useful on mobile clients, but after several months of discussion I'm unfortunately still not clear on what exactly is supposed to change once this proposal has been implemented. Part of that may be my lack of knowledge of Mediawiki extensions, and if others are very clear on the path forward then please ignore me and move on, but as someone who does software development for a living, I don't think that the discussion above would provide sufficient information for me to begin development. TASK DETAIL https://phabricator.wikimedia.org/T77925 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: NiharikaKohli, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, Deskana, LtPowers, Aklapper, Florian, Lydia_Pintscher, FDMS, KLans_WMF, Jdlrobson, Wrh2, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T77925: Wikidata PageBanner extension
Wrh2 added a comment.
In https://phabricator.wikimedia.org/T77925#1091036, @Jdlrobson wrote:
@wrh2 any ideas from an editors perspective how you would like this to work
without templates?
Ideally I would imagine an edit button on the banner which when clicked pops
up an input field where you can search for an image on commons and saves as a
page property separate to wikitext. Would this be sufficient or would it need
to be part of the wiki text?
Per
In https://phabricator.wikimedia.org/T77925#1091036, @Jdlrobson wrote:
@wrh2 any ideas from an editors perspective how you would like this to work
without templates?
Ideally I would imagine an edit button on the banner which when clicked pops
up an input field where you can search for an image on commons and saves as a
page property separate to wikitext. Would this be sufficient or would it need
to be part of the wiki text?
In https://phabricator.wikimedia.org/T77925#1091036, @Jdlrobson wrote:
@wrh2 any ideas from an editors perspective how you would like this to work
without templates?
Ideally I would imagine an edit button on the banner which when clicked pops
up an input field where you can search for an image on commons and saves as a
page property separate to wikitext. Would this be sufficient or would it need
to be part of the wiki text?
Personally I would like to see this implemented in a way that is transparent,
so that the existing page banner template
(https://en.wikivoyage.org/wiki/Template:Pagebanner) is just modified to invoke
extension code, Common.css and Common.js are tweaked as needed, and nothing
else has to change - every page that current invokes the template stays as-is:
{{pagebanner | Sony Pictures Entertainment banner.jpg | caption=Entrance to
Sony Pictures Studios }}
TASK DETAIL
https://phabricator.wikimedia.org/T77925
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Wrh2
Cc: NiharikaKohli, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd,
Deskana, LtPowers, Aklapper, Florian, Lydia_Pintscher, FDMS, KLans_WMF,
Jdlrobson, Wrh2, Wikidata-bugs, aude
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T77925: Wikidata PageBanner extension
Wrh2 added a comment. In https://phabricator.wikimedia.org/T77925#1098331, @Sumit wrote: Just out of curiosity, the wikivoyage home page uses the banner template( http://en.wikivoyage.org/wiki/Template:Banner ) to render the banners there, which are not included in mobile. Can we also include this functionality in the proposed extension, so that wikivoyage home page has banners in mobile as well? The home page banner template (https://en.wikivoyage.org/wiki/Template:Banner) is completely unrelated to page banners (https://en.wikivoyage.org/wiki/Template:Pagebanner). The home page template is used to render the items in the carousel, which change three times a month, are a different size than the page banners, do not interact with the table of contents, etc. I would strongly suggest that if this effort is going to go forward that it focus on the standard banners at the top of most pages, rather than trying to be a one-size-fits-all solution for any image that displays in full page width. TASK DETAIL https://phabricator.wikimedia.org/T77925 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: NiharikaKohli, Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, Deskana, LtPowers, Aklapper, Florian, Lydia_Pintscher, FDMS, KLans_WMF, Jdlrobson, Wrh2, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T77925: Wikidata PageBanner extension
Wrh2 added a comment. In https://phabricator.wikimedia.org/T77925#1078790, @Jdlrobson wrote: @Wrh2 this would be the hope. The only remaining question here seems to be how to override the Wikidata property. Where would such a value get stored (note this extension would deprecate the need for the template) Wouldn't this new extension be created as a parser hook similar to something like https://www.mediawiki.org/wiki/Extension:GeoCrumbs? We still want some control over the banner so that we don't have a banner appearing on the main page (for example), and we also need to be able to pass any needed overrides. I would envision that the existing template would still be kept, it would just be reconfigured to invoke the extension with the required params. TASK DETAIL https://phabricator.wikimedia.org/T77925 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Qgil, kaldari, Sumit, Nicolas_Raoul, Matroc, Shaundd, Deskana, LtPowers, Aklapper, Florian, Lydia_Pintscher, FDMS, KLans_WMF, Jdlrobson, Wrh2, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T77925: Wikidata PageBanner extension
Wrh2 added a comment. If this proposal does move forward there needs to be a way to locally override the Wikidata property, as has been previously mentioned. Additionally, if possible, a major shortcoming of the current banners is that they require hiding the h1 tag with display:none CSS, and the banner then uses a div for the article name in the banner (using a h1 tag in wiki source causes the page name to appear in the TOC), which is horrible for SEO. If there was a way to move this functionality to an extension and have an h1 tag in the banner that contains the article name without causing a TOC update, that would be an additional win. TASK DETAIL https://phabricator.wikimedia.org/T77925 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Wrh2 Cc: Sumit, Nicolas_Raoul, Matroc, Shaundd, Deskana, LtPowers, Aklapper, Florian, Lydia_Pintscher, FDMS, KLans_WMF, Jdlrobson, Wrh2, Wikidata-bugs, Jdouglas, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
