[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

2021-02-02 Thread daniel
daniel added a comment. @Lucas_Werkmeister_WMDE wrote: > so for a RevisionRecord belonging to a non-local wiki, calling getId() without arguments will now trigger a call to wfDeprecatedMsg(). But wfDeprecatedMsg() is apparently enough to make unit tests fail, and also cause warni

[Wikidata-bugs] [Maniphest] T245989: RecetChanges query API fails with timeout when asking for 5 RC redirects in on Wikidata

2020-12-17 Thread daniel
daniel renamed this task from "Wikidata API fails with timeout when asking for 5 RC redirects" to "RecetChanges query API fails with timeout when asking for 5 RC redirects in on Wikidata". TASK DETAIL https://phabricator.wikimedia.org/T245989 EMAIL

[Wikidata-bugs] [Maniphest] T113034: RFC: Overhaul Interwiki map, unify with Sites and WikiMap

2020-12-09 Thread daniel
daniel lowered the priority of this task from "High" to "Medium". TASK DETAIL https://phabricator.wikimedia.org/T113034 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Addshore, Ladsgroup, kchapman, Lucas_Werkmeist

[Wikidata-bugs] [Maniphest] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-12-03 Thread daniel
daniel added a comment. In T214362#6653148 <https://phabricator.wikimedia.org/T214362#6653148>, @Addshore wrote: > It's a shame that this has made its way into the "icebox" of the #platform_engineering_roadmap_decision_making <https://phabric

[Wikidata-bugs] [Maniphest] T237991: Changes to Structured Data on Commons should trigger page refresh

2020-11-04 Thread daniel
daniel added a project: User-Daniel. TASK DETAIL https://phabricator.wikimedia.org/T237991 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Keegan, Cparle, Multichill, matthiasmullie, Ramsey-WMF, AntiCompositeNumber, Tgr, Addshore, Jarekt

[Wikidata-bugs] [Maniphest] T67267: Specify whether TimeValue stores timestamps in UTC or local time.

2020-10-27 Thread daniel
daniel removed daniel as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T67267 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: PokestarFan, Jc3s5h, Wikidata-bugs, Lydia_Pintscher, daniel, JohnLewis, Akuckartz

[Wikidata-bugs] [Maniphest] T194736: Implement automatic conflict resolution for all slots [MCR]

2020-10-27 Thread daniel
daniel removed daniel as the assignee of this task. daniel added a project: User-Daniel. TASK DETAIL https://phabricator.wikimedia.org/T194736 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Agabi10, TomT0m, Smalyshev, -jem

[Wikidata-bugs] [Maniphest] T205459: Decide how SlotRoleHandlers can provide placeholders for missing slots

2020-10-27 Thread daniel
daniel added a project: User-Daniel. daniel removed daniel as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T205459 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Cparle, Aklapper, gerritbot, daniel, Naike

[Wikidata-bugs] [Maniphest] T260232: BatchRowIterator slow query on commonswiki

2020-09-08 Thread daniel
daniel edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (External Code Reviews). TASK DETAIL https://phabricator.wikimedia.org/T260232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc

[Wikidata-bugs] [Maniphest] T257196: Allow tests to reset/clear non-legacy hook handlers

2020-09-01 Thread daniel
daniel added a comment. The fix for T255056 <https://phabricator.wikimedia.org/T255056> should address this as well. TASK DETAIL https://phabricator.wikimedia.org/T257196 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel,

[Wikidata-bugs] [Maniphest] T257196: Allow tests to reset/clear non-legacy hook handlers

2020-09-01 Thread daniel
daniel closed this task as a duplicate of T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks . TASK DETAIL https://phabricator.wikimedia.org/T257196 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc

[Wikidata-bugs] [Maniphest] T254688: SpecialWhatLinksHere::showIndirectLinks on wikidatawiki needs optimizing

2020-08-24 Thread daniel
daniel added a comment. In T254688#6406171 <https://phabricator.wikimedia.org/T254688#6406171>, @Lydia_Pintscher wrote: > Ok thanks. That special page is rather important for Wikidata and turning it off completely is not an option I fear. My idea was to turn of the "

[Wikidata-bugs] [Maniphest] T254688: SpecialWhatLinksHere::showIndirectLinks on wikidatawiki needs optimizing

2020-08-24 Thread daniel
daniel added a comment. In T254688#6405484 <https://phabricator.wikimedia.org/T254688#6405484>, @Marostegui wrote: > The only workaround we've found is sadly, using `FORCE`, `USE` or `IGNORE INDEX` on the queries to bypass those issues. Sometimes issues get fixed by running an

[Wikidata-bugs] [Maniphest] T254688: SpecialWhatLinksHere::showIndirectLinks on wikidatawiki needs optimizing

2020-08-24 Thread daniel
daniel added a comment. In T254688#6395860 <https://phabricator.wikimedia.org/T254688#6395860>, @Lydia_Pintscher wrote: > Hard to tell without the context of when this is happening for users. Does anyone know? The query in question is generated by https://www.wikidata

[Wikidata-bugs] [Maniphest] T254688: SpecialWhatLinksHere::showIndirectLinks on wikidatawiki needs optimizing

2020-08-18 Thread daniel
daniel added subscribers: Lydia_Pintscher, daniel. daniel edited projects, added Platform Engineering; removed Platform Team Workboards (Clinic Duty Team). daniel added a comment. Back to the inbox for triage. This isn't actionable as it is. We'd probably have to design a new schema

[Wikidata-bugs] [Maniphest] [Updated] T257002: Internal error on Special:Contributions in Wikidata

2020-07-03 Thread daniel
daniel added a comment. might be related to T253289: Remove USE INDEX usertext_timestamp and other references from code <https://phabricator.wikimedia.org/T253289> TASK DETAIL https://phabricator.wikimedia.org/T257002 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

2020-06-12 Thread daniel
daniel added a comment. > The original core test still throws errors that seem related to Wikibase You mean this one? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/475065 As I noted there: > The "dangerous" methods on DatabaseUpdater are no lo

[Wikidata-bugs] [Maniphest] [Commented On] T252091: RFC: Site-wide edit rate limiting with PoolCounter

2020-05-13 Thread daniel
daniel added a comment. For reference, Brad used PooLCounter to impose a limit on Special:Contributions recently, see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/551909 TASK DETAIL https://phabricator.wikimedia.org/T252091 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Updated] T251452: Tests fails on ApiEditPageTest::testEditWhileReadOnly fails with PHP Fatal error on MacOS, php 7.4.1 if Wikibase/repo enabled

2020-05-08 Thread daniel
daniel edited projects, added Wikidata; removed Core Platform Team Workboards (Clinic Duty Team). daniel added a subscriber: Addshore. daniel added a comment. Untagging CPT, tagging #wikidata <https://phabricator.wikimedia.org/tag/wikidata/> . Pinging @Addshore to have a look. TASK

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-05-04 Thread daniel
daniel added a comment. In T251457#6105089 <https://phabricator.wikimedia.org/T251457#6105089>, @Jdforrester-WMF wrote: > UBN patches, and particularly train-blocking UBN patches, should not wait for SWAT, but be deployed immediately (in line with https://wikitech.wikimedia

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-05-04 Thread daniel
daniel added a comment. In T251457#6104041 <https://phabricator.wikimedia.org/T251457#6104041>, @LarsWirzenius wrote: > https://gerrit.wikimedia.org/r/593757 has been merged, but has it been deployed (I assume it will need to be backported to the 1.35.0-wmf.30 branch as wel

[Wikidata-bugs] [Maniphest] [Commented On] T230833: wbsearchentities for lexemes returns 'und' match language on Test Wikidata

2020-05-03 Thread daniel
daniel added a comment. > Using IETF language tags seems like the most useful solution to me I dimly recall a similar discussion from years ago. IIRC, IETF is extensible, and we came up with a way to encode item IDs in language tages, something like `qid-36163` (by fortunate coincide

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-05-01 Thread daniel
daniel added a comment. While I was chatting with @Krinkle on IRC, he found out that https://gerrit.wikimedia.org/r/c/mediawiki/core/+/582022 caused Database::lock() to be treated as a write operation now. This was not the case before, and indeed should not be the case. This means the error

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-05-01 Thread daniel
daniel added a comment. In T251457#6099971 <https://phabricator.wikimedia.org/T251457#6099971>, @Tgr wrote: > MediaWiki automatically wraps the entire request in a transaction if it encounters a write which does not do its own transaction handling. So something unrelated

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-05-01 Thread daniel
daniel added a comment. > I'm not entirely sure I understand it correctly, but PageEditStash::getAndWaitForStashValue uses ILoadBalancer::getAnyOpenConnection and by chance acquires a connection where a transaction was already open for edit? Yes. the question is,

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread daniel
daniel added a comment. @Pchelolo can you provide the rest of the stack trace? This is triggered via SpamBlacklistHooks, and I want to understand why that is being executed inside the DB transaction. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread daniel
daniel added a comment. In T251457#6098793 <https://phabricator.wikimedia.org/T251457#6098793>, @Krinkle wrote: > @daniel How did it work before? What needed to change? What actually changed? I'm not aware of any changes in that area. TASK DETAI

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread daniel
daniel added a comment. So, PageEditStash::parseAndCache() parses the page while holding the lock. PageEditStash->getAndWaitForStashValue() waits for that lock, and it apparently does so within the DB transaction that will be used to write the new revision. If parsing takes l

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread daniel
daniel added a comment. In T251457#6098675 <https://phabricator.wikimedia.org/T251457#6098675>, @Pchelolo wrote: > It's PageEditStash. See my comment above. Saw it and already edited my comment ;) TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCE

[Wikidata-bugs] [Maniphest] [Commented On] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread daniel
daniel added a comment. In T251457#6098402 <https://phabricator.wikimedia.org/T251457#6098402>, @Pchelolo wrote: > @daniel I don't think this is that lock showing up here. Reading the code, it seems like if that lock was taken, we should've seen a bunch more queries in this tr

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread daniel
daniel added a comment. Interesting. RevisionStore::insertRevisionRowOn() does uses GET_LOCK when it detects the auto-increment value of the revision table to be out of sync. This was introduced as a fix for T202032: Duplicate ar_rev_id values in several wikis <ht

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread daniel
daniel added subscribers: DannyS712, daniel. daniel added a comment. Pinging patch author @DannyS712 TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, DannyS712, Jdforrester

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread daniel
daniel edited projects, added Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Liuxinyu970226, brennen

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php must not run LoadExtensionSchemaUpdates

2020-04-21 Thread daniel
daniel added a comment. In T157651#6075764 <https://phabricator.wikimedia.org/T157651#6075764>, @Krinkle wrote: > @daniel I noticed a patch that makes some methods inaccesible to extensions. Does that mean this structure test is no longer needed? Or are there some dangerou

[Wikidata-bugs] [Maniphest] [Commented On] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-21 Thread daniel
daniel added a comment. It seems like all essential patches are merged. Can this be closed now? TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Demian, Jdforrester-WMF, kostajh

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

2020-04-21 Thread daniel
daniel added a comment. In T249598#6073487 <https://phabricator.wikimedia.org/T249598#6073487>, @daniel wrote: > Oh wait, this patch also belongs here, right? > https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/507898 Actually, I think that patch is wr

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

2020-04-20 Thread daniel
daniel added a comment. Oh wait, this patch also belongs here, right? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/507898 TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Closed] T249603: DatabaseUpdater: protect methods for direct database modification

2020-04-20 Thread daniel
daniel closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T249603 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: RhinosF1, Tgr, Aklapper, aaron, gerritbot, Reception123, Catrope, Krinkle, kchapman,

[Wikidata-bugs] [Maniphest] [Unblock] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-20 Thread daniel
daniel closed subtask T249603: DatabaseUpdater: protect methods for direct database modification as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Demian, Jdforrester-WMF

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

2020-04-20 Thread daniel
daniel added a comment. Looks like this is done, can the ticket be closed? TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Jdforrester-WMF, Aklapper, Krinkle, kchapman, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Unblock] T242717: Wikidata daily browser tests fails on Beta due to "Unable to store text to external storage"

2020-04-17 Thread daniel
daniel closed subtask T228088: BetaCluster: ExternalStoreException - Unable to store text to external storage as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T242717 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Krinkle

[Wikidata-bugs] [Maniphest] [Edited] T249603: DatabaseUpdater: protect methods for direct database modification

2020-04-17 Thread daniel
daniel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T249603 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: RhinosF1, Tgr, Aklapper, aaron, gerritbot, Reception123, Catrope, Krinkle, kchapman, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Claimed] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-15 Thread daniel
daniel claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Demian, Jdforrester-WMF, kostajh, WMDE-leszek, Addshore, Anomie, alaa_wmde, daniel, Ladsgroup, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T248459: Math extension randomly fails in gate-and-submit for Wikibase

2020-04-14 Thread daniel
daniel removed a project: Core Platform Team Workboards (Clinic Duty Team). daniel added a comment. Wikibase problem is apparently fixed, untagging CPT. TASK DETAIL https://phabricator.wikimedia.org/T248459 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

2020-04-08 Thread daniel
daniel added a comment. Note the the solution that was just merged is quite far from what is discussed in the task description. If further work is desired here, please re-open. TASK DETAIL https://phabricator.wikimedia.org/T240083 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Closed] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

2020-04-08 Thread daniel
daniel moved this task from Waiting for Review to Done on the Core Platform Team Workboards (Clinic Duty Team) board. daniel closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T240083 WORKBOARD https://phabricator.wikimedia.org/project/board/41

[Wikidata-bugs] [Maniphest] [Unblock] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-08 Thread daniel
daniel closed subtask T249584: Call LoadExtensionSchemaUpdates later as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Jdforrester-WMF, kostajh, WMDE-leszek, Addshore

[Wikidata-bugs] [Maniphest] [Closed] T198557: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts

2020-04-07 Thread daniel
daniel closed this task as "Resolved". daniel added a comment. It's done, as far as I know TASK DETAIL https://phabricator.wikimedia.org/T198557 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Anomie, DannyS712, Jdfor

[Wikidata-bugs] [Maniphest] [Unblock] T198492: Create a maintenance script to drop rev_text_id and ar_text_id from the database.

2020-04-07 Thread daniel
daniel closed subtask T198557: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T198492 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T205094: Investigate restructure SQL directory

2020-04-07 Thread daniel
daniel added a comment. Note: the above patch apparently missed on occurrence of dropTable() TASK DETAIL https://phabricator.wikimedia.org/T205094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, Addshore, Aklapper

[Wikidata-bugs] [Maniphest] [Updated] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-07 Thread daniel
daniel added a subtask: T249584: Call LoadExtensionSchemaUpdates later. TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: kostajh, WMDE-leszek, Addshore, Anomie, alaa_wmde, daniel

[Wikidata-bugs] [Maniphest] [Merged] T249599: DatabaseUpdater should not call hooks in the constructor

2020-04-07 Thread daniel
daniel closed this task as a duplicate of T249584: Call LoadExtensionSchemaUpdates later. TASK DETAIL https://phabricator.wikimedia.org/T249599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, aaron, gerritbot, Krinkle, Ladsgroup

[Wikidata-bugs] [Maniphest] [Triaged] T249603: DatabaseUpdater: protect methods for direct database modification

2020-04-07 Thread daniel
daniel moved this task from Inbox to Ready on the Core Platform Team Workboards (Clinic Duty Team) board. daniel triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T249603 WORKBOARD https://phabricator.wikimedia.org/project/board/4149/ EMAIL P

[Wikidata-bugs] [Maniphest] [Updated] T249598: Wikibase schema updaters must not modify database directly

2020-04-07 Thread daniel
daniel added a parent task: T249603: DatabaseUpdater: protect methods for direct database modification . TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Krinkle, kchapman

[Wikidata-bugs] [Maniphest] [Updated] T249603: DatabaseUpdater: protect methods for direct database modification

2020-04-07 Thread daniel
daniel added a subtask: T249598: Wikibase schema updaters must not modify database directly. TASK DETAIL https://phabricator.wikimedia.org/T249603 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: RhinosF1, Tgr, Aklapper, aaron, gerritbot

[Wikidata-bugs] [Maniphest] [Created] T249603: DatabaseUpdater: protect methods for direct database modification

2020-04-07 Thread daniel
daniel created this task. daniel added projects: Performance-Team, Core Platform Team Workboards (Clinic Duty Team), Growth-Team, Wikidata, MediaWiki-Maintenance-system. Restricted Application added a project: User-RhinosF1. Restricted Application added a subscriber: RhinosF1. TASK DESCRIPTION

[Wikidata-bugs] [Maniphest] [Updated] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-07 Thread daniel
daniel added a comment. T249599: DatabaseUpdater should not call hooks in the constructor <https://phabricator.wikimedia.org/T249599> should address the original issue in this task's title. TASK DETAIL https://phabricator.wikimedia.org/T157651 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T249598: Wikibase schema updaters must not modify database directly

2020-04-07 Thread daniel
daniel added a comment. No patch yet, one one above was tagged with this ticket erronously. TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Krinkle, kchapman, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T249598: Wikibase schema updaters must not modify database directly

2020-04-07 Thread daniel
daniel removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Krinkle, kchapman, Pablo-WMDE, Ladsgroup, alaa_wmde, Anomie, Addshore, WMDE-leszek

[Wikidata-bugs] [Maniphest] [Triaged] T249599: DatabaseUpdater should not call hooks in the constructor

2020-04-07 Thread daniel
daniel triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T249599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, aaron, gerritbot, Krinkle, Ladsgroup, Anomie, Addshore, daniel, Oblanc

[Wikidata-bugs] [Maniphest] [Retitled] T249599: DatabaseUpdater should not call hooks in the constructor

2020-04-07 Thread daniel
daniel renamed this task from "DatabaseUpdater should not do work in the constructor" to "DatabaseUpdater should not call hooks in the constructor". TASK DETAIL https://phabricator.wikimedia.org/T249599 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] [Created] T249599: DatabaseUpdater should not do work in the constructor

2020-04-07 Thread daniel
daniel created this task. daniel added projects: MediaWiki-Maintenance-system, Core Platform Team Workboards (Clinic Duty Team), Wikidata. TASK DESCRIPTION DatabaseUpdater modifies global variables and executes hooks in the constructor. This can be dangerous, see the major outage cause

[Wikidata-bugs] [Maniphest] [Updated] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-07 Thread daniel
daniel removed a project: Wikidata-Campsite. daniel added a comment. In T157651#6035615 <https://phabricator.wikimedia.org/T157651#6035615>, @Ladsgroup wrote: > In T157651#6035601 <https://phabricator.wikimedia.org/T157651#6035601>, @daniel wrote: > >> Ta

[Wikidata-bugs] [Maniphest] [Created] T249598: Wikibase schema updaters must not modify database directly

2020-04-07 Thread daniel
daniel created this task. daniel added projects: Wikidata, Wikidata-Campsite. TASK DESCRIPTION Wikibase uses the LoadExtensionSchemaUpdates hook for database schema updates. Handlers of this hook must not modify the database directly, but mist instead register updates for later execution

[Wikidata-bugs] [Maniphest] [Triaged] T249598: Wikibase schema updaters must not modify database directly

2020-04-07 Thread daniel
daniel triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Krinkle, kchapman, Pablo-WMDE, Ladsgroup, alaa_wmde, Anomie, Adds

[Wikidata-bugs] [Maniphest] [Updated] T157651: sql.php runs LoadExtensionSchemaUpdates

2020-04-07 Thread daniel
daniel added a project: Wikidata-Campsite. daniel added a comment. Restricted Application added a project: Wikidata. Tagging #wikidata-campsite <https://phabricator.wikimedia.org/tag/wikidata-campsite/> for the issues with the wikibase schema updater. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-25 Thread daniel
daniel added a comment. In T233520#5897446 <https://phabricator.wikimedia.org/T233520#5897446>, @Ladsgroup wrote: > This already happens (changing page_touched) through `HTMLCacheUpdateJob` and that's one of the reasons the problem exists, because the try_to_get_cached_pars

[Wikidata-bugs] [Maniphest] [Unblock] T174031: MCR: Include all slots in XML dumps

2020-02-25 Thread daniel
daniel closed subtask T238959: Make TextPassDumperTest work with 0.11 dump schema as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T174031 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: gerritbot, ArielGlenn, Fjalapeno

[Wikidata-bugs] [Maniphest] [Unblock] T238972: switch xml/sql (and adds-changes) dumps to use 0.11 schema with content from multiple slots

2020-02-25 Thread daniel
daniel closed subtask T238959: Make TextPassDumperTest work with 0.11 dump schema as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T238972 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArielGlenn, daniel Cc: Christian75, Schnark, binbot

[Wikidata-bugs] [Maniphest] [Closed] T238959: Make TextPassDumperTest work with 0.11 dump schema

2020-02-25 Thread daniel
daniel closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T238959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: CCicalese_WMF, Aklapper, Fjalapeno, ArielGlenn, gerritbot, daniel, jannee

[Wikidata-bugs] [Maniphest] [Unblock] T198557: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts

2020-02-24 Thread daniel
daniel closed subtask T242764: Test schema update from old versions to MCR-only schema as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T198557 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Jdforrester-WMF, BPirkle, Fjalapeno

[Wikidata-bugs] [Maniphest] [Commented On] T243950: RDF output of an entity loads all referenced entities, it shouldn't

2020-02-16 Thread daniel
daniel added a comment. The intent is to provide "stub" information for all mentioned entities, such as their type, label, and description (but maybe not in all languages?). Basically, this is the information needed to generate a minimal human readable representation of

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-06 Thread daniel
daniel added a comment. In T233520#5855751 <https://phabricator.wikimedia.org/T233520#5855751>, @Addshore wrote: > - updating page_touched would probably trigger a reparse of the page (and currently that doesn't happen for the case described) In practical terms, WikiPa

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-27 Thread daniel
daniel added a comment. @Addshore Investigating this requires a dev setup with Wikibase. I don't have one handy... I think it would be best if we could spend an hour or so investigating this together. Maybe via hangout next week? Send me an invite... TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Retitled] T221949: Remove Title::moveTo

2020-01-24 Thread daniel
daniel renamed this task from "Remove uses of Title::moveTo" to "Remove Title::moveTo". TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, daniel Cc: Art-Baltai,

[Wikidata-bugs] [Maniphest] [Edited] T221949: Remove uses of Title::moveTo

2020-01-24 Thread daniel
daniel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, daniel Cc: Art-Baltai, Peter.ovchyn, daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-01-22 Thread daniel
daniel added a comment. In T214362#5814559 <https://phabricator.wikimedia.org/T214362#5814559>, @Addshore wrote: > Yes, we need this! > This decision is one of the 2 rfcs blocking continued work on constraint checks for Wikidata that was started in either late 2018 o

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage

2020-01-16 Thread daniel
daniel added subscribers: kchapman, CCicalese_WMF. daniel added a comment. In T214362#5808924 <https://phabricator.wikimedia.org/T214362#5808924>, @Addshore wrote: > I see that T227776 <https://phabricator.wikimedia.org/T227776> has had little activity since November, i

[Wikidata-bugs] [Maniphest] [Commented On] T240884: Standalone service to evaluate user-provided regular expressions

2020-01-16 Thread daniel
daniel added a comment. Condensed outcome of a conversation between @Ladsgroup, @Addshore, @Joe, @krinkle, @tstarling, and myself: - If there are other use cases for re2 in MediaWiki, go for a native php binding for re2. - If there are other use cases for gRPC on our cluster, try

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-16 Thread daniel
daniel added a subscriber: Anomie. daniel added a comment. In T233520#5805312 <https://phabricator.wikimedia.org/T233520#5805312>, @Addshore wrote: > Adding core platform team to get some feedback and figure out: > > - When exactly this change in behaviour happened?

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-15 Thread daniel
daniel added a comment. I haven't done a full analysis, but I'm wondering why this is using the ContentAlterParserOutput hook, instead of RevisionDataUpdates? Conceptually, ContentAlterParserOutput is a filter-style hook that shouldn't have side effects. RevisionDataUpdates is specifically

[Wikidata-bugs] [Maniphest] [Commented On] T221949: Remove uses of Title::moveTo

2020-01-14 Thread daniel
daniel added a comment. The sole remaining issue here is to add a test for UserMerge that tests the page move, so we can merge the respective patch with confidence: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/560351 TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T46581: Partial dumps

2019-12-22 Thread daniel
daniel added a comment. Filtering dumps by area of interest is convenient, if a good criterion can be found to identify items relevant to the topic. It would probably make sense to also include any items directly references, to provide the immediate context of the items. ms and However

[Wikidata-bugs] [Maniphest] [Claimed] T198557: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts

2019-12-17 Thread daniel
daniel claimed this task. daniel edited projects, added Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team Workboards (User Stories). daniel added a comment. Moving to clinic duty, since I'm working on this now. TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-12-12 Thread daniel
daniel added a comment. In T238878#5730630 <https://phabricator.wikimedia.org/T238878#5730630>, @Milimetric wrote: > In T238878#5708257 <https://phabricator.wikimedia.org/T238878#5708257>, @daniel wrote: > >> By the way, if you find rev_deleted != 0 for th

[Wikidata-bugs] [Maniphest] [Commented On] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

2019-12-11 Thread daniel
daniel added a comment. In T240083#5732326 <https://phabricator.wikimedia.org/T240083#5732326>, @Anomie wrote: >> `User::saveSettings` is calling `Title::purgeSquid`. It is undocumented why changing preferences requires purging the user page, unconditionally, s

[Wikidata-bugs] [Maniphest] [Updated] T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5]

2019-12-11 Thread daniel
daniel added a project: Core Platform Team Workboards (Clinic Duty Team). daniel added a comment. The stack trace reads like a fun chain of lazy initialization logic causing a User object to be loaded prematurely. There are several places where this chain could potentially be cut, but I

[Wikidata-bugs] [Maniphest] [Retitled] T238959: Make TextPassDumperTest work with 0.11 dump schema

2019-12-09 Thread daniel
daniel renamed this task from "Make TextPassDumper work with 0.11 dump schema" to "Make TextPassDumperTest work with 0.11 dump schema". daniel updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T238959 EMAIL PREFERENCES https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Updated] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-12-03 Thread daniel
daniel added a comment. In T238878#5708511 <https://phabricator.wikimedia.org/T238878#5708511>, @matthiasmullie wrote: > So page_latest can never point to a revdel'ed revision? SHOULD never ;) And confusingly, rev_deleted is unrelated to "revision deletion",

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-12-03 Thread daniel
daniel added a comment. > I was thinking it made sense to exclude rev-deleted revisions: if a page only has (SDC) revisions that are partly restricted for most people, that we might not want to count those. If you want to count //pages//, then you are only looking at the curr

[Wikidata-bugs] [Maniphest] [Commented On] T238878: Data about how many file pages on Commons contain at least one structured data element

2019-11-28 Thread daniel
daniel added a comment. In T238878#5700408 <https://phabricator.wikimedia.org/T238878#5700408>, @Nuria wrote: > Can someone explain why the content table is as large as the revision table? I though these tables were not used much other than commons but content table is big

[Wikidata-bugs] [Maniphest] [Updated] T238959: Make TextPassDumper work with 0.11 dump schema

2019-11-23 Thread daniel
daniel added a parent task: T238972: switch xml/sql (and adds-changes) dumps to use 0.11 schema with content from multiple slots. TASK DETAIL https://phabricator.wikimedia.org/T238959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc

[Wikidata-bugs] [Maniphest] [Updated] T238959: Make TextPassDumper work with 0.11 dump schema

2019-11-23 Thread daniel
daniel added a parent task: T238921: MCR: Include all slots in XML dumps per default. TASK DETAIL https://phabricator.wikimedia.org/T238959 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: CCicalese_WMF, Aklapper, Fjalapeno, ArielGlenn

[Wikidata-bugs] [Maniphest] [Commented On] T238959: Make TextPassDumper work with 0.11 dump schema

2019-11-22 Thread daniel
daniel added a comment. @CCicalese_WMF I overlooks this. We use this mode in production, but nothing else does. The tests for this class use the default schema, so they'll pass as long as the default is 0.10. This is unfortunate, since it means that support for the 0.11 schema output

[Wikidata-bugs] [Maniphest] [Reopened] T174031: MCR: Include all slots in XML dumps

2019-11-22 Thread daniel
daniel reopened this task as "Open". daniel added a comment. Re-opening due to T238959 <https://phabricator.wikimedia.org/T238959> TASK DETAIL https://phabricator.wikimedia.org/T174031 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Created] T238959: Make TextPassDumper work with 0.11 dump schema

2019-11-22 Thread daniel
daniel created this task. daniel added projects: Wikidata, Structured Data Engineering, Multi-Content-Revisions (New Features), CPT Initiatives (MCR), Structured-Data-Backlog, Core Platform Team. TASK DESCRIPTION TextPassDumper does a streaming read of an XML document and at the same time

[Wikidata-bugs] [Maniphest] [Updated] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2019-11-22 Thread daniel
daniel added a comment. In T199121#5684558 <https://phabricator.wikimedia.org/T199121#5684558>, @ArielGlenn wrote: > As usual no one has given anyone any decision making powers so I'll claim it :-P I should make a task, announce it on the mailing lists, give a 2 mont

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2019-11-22 Thread daniel
daniel added a comment. In T199121#5684250 <https://phabricator.wikimedia.org/T199121#5684250>, @ArielGlenn wrote: > In T199121#5684237 <https://phabricator.wikimedia.org/T199121#5684237>, @daniel wrote: > >> In T199121#5683594 <https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps

2019-11-22 Thread daniel
daniel added a comment. In T199121#5683594 <https://phabricator.wikimedia.org/T199121#5683594>, @ArielGlenn wrote: > In T199121#5682911 <https://phabricator.wikimedia.org/T199121#5682911>, @Nuria wrote: > >> I see this ticket is resolved but the dumps

[Wikidata-bugs] [Maniphest] [Closed] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-10-28 Thread daniel
daniel closed this task as "Resolved". daniel claimed this task. daniel added a comment. All subtasks are resolved. I just went over the remaining open patches for this task and abandoned a few obsolete ones. There are only two patches remaining open, one for the Duplicator extensi

  1   2   3   4   5   6   7   8   9   10   >