[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

2022-05-11 Thread hashar
hashar added a comment. When trying the jobs yesterday they failed again. The reason is that the extension dependencies are not injected by Zuul since the change is in progress and not deployed. I have been testing them by manually triggering them on Jenkins, I have added a temp change

[Wikidata-bugs] [Maniphest] T304147: jenkis CI wikibase-repo-docker failing with new quibble version

2022-05-10 Thread hashar
hashar closed this task as "Resolved". hashar claimed this task. hashar added a comment. I have tested https://gerrit.wikimedia.org/r/c/integration/config/+/790621 against https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/767776 the jobs work with Quibble 1.4.5 +

[Wikidata-bugs] [Maniphest] T307586: wbsearchentities produces no results on 1.39.0-wmf.10

2022-05-04 Thread hashar
hashar added a comment. @Lucas_Werkmeister_WMDE maybe that can be reproduced on `testwikidatawiki` (no clue about the domain / URL though). TASK DETAIL https://phabricator.wikimedia.org/T307586 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T281122: Wikibase selenium tests timeout, seemingly due to "memory compaction" events on CI VMs

2022-04-21 Thread hashar
hashar added a comment. I am not sure whether anything is actionable for this task. It got filed in August 2021 and a lot of things have changed since then (Quibble improvements, change of the underlying WMCS and Docker infra). The Wikibase test suites are definitely heavy though and we

[Wikidata-bugs] [Maniphest] T304147: jenkis CI wikibase-repo-docker failing with new quibble version

2022-03-18 Thread hashar
hashar added a comment. @kostajh has found the issue, the failing jobs are the one that do not start supervisord and thus do not have memcached server running. Quibble 1.4.4 configure the caches to use memcached whenever the PHP extension is loaded but since there is no memcached server

[Wikidata-bugs] [Maniphest] T295601: wikidata-query-gui-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place)

2022-03-16 Thread hashar
hashar added a comment. I supposed the code is somewhere in https://github.com/dependabot/dependabot-core/ but I could not find out how `---\n` is injected :-\ TASK DETAIL https://phabricator.wikimedia.org/T295601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T295601: wikidata-query-gui-build doesn’t work when latest commit is by dependabot (commit-msg hook adds Change-Id in wrong place)

2022-02-23 Thread hashar
hashar added a comment. The hook in upstream is at https://gerrit.googlesource.com/gerrit/+/refs/heads/master/resources/com/google/gerrit/server/tools/root/hooks/commit-msg (git log <https://gerrit.googlesource.com/gerrit/+log/refs/heads/master/resources/com/google/gerrit/server/tools/r

[Wikidata-bugs] [Maniphest] T299933: Wikibase CI builds failing with npm errors: corrupted tarball data, ENOENT in cacache

2022-01-24 Thread hashar
hashar added a comment. I am not quite sure what happened with the npm cache so I have nuked the cache for both jobs. npm reported them as being corrupted, I thought about T295351 <https://phabricator.wikimedia.org/T295351> but that one is caused when some files have zero bytes.

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2022-01-20 Thread hashar
hashar closed subtask T299211: Request increased quota for integration Cloud VPS project as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: aborrero, dcaro, Aklapper, dduvall

[Wikidata-bugs] [Maniphest] T299389: Wikibase CI broken due to missing PHP extensions: dom, intl, mbstring, xml, xmlreader, xmlwriter

2022-01-18 Thread hashar
hashar closed this task as "Resolved". hashar claimed this task. hashar added a comment. Solved! Apparently the Quibble 1.3.0 images were the sole affected, I still have rebuild the rest of the images for good measure :D TASK DETAIL https://phabricator.wikimedia.org/T299

[Wikidata-bugs] [Maniphest] T299389: Wikibase CI broken due to missing PHP extensions: dom, intl, mbstring, xml, xmlreader, xmlwriter

2022-01-18 Thread hashar
hashar added a comment. It is fixed by https://gerrit.wikimedia.org/r/c/integration/config/+/754905 which would stop getting php8.1 being installed. I have verified the new images have the proper php version: Successfully published image docker-registry.discovery.wmnet/releng

[Wikidata-bugs] [Maniphest] T299389: Wikibase CI broken due to missing PHP extensions: dom, intl, mbstring, xml, xmlreader, xmlwriter

2022-01-18 Thread hashar
hashar added a comment. In T299389#7627900 <https://phabricator.wikimedia.org/T299389#7627900>, @kostajh wrote: > Can/should we use pecl to install apcu and xdebug? e.g. `pecl install apcu` & `pecl install xdebug` That is a bit of a pain, we would need various

[Wikidata-bugs] [Maniphest] T299389: Wikibase CI broken due to missing PHP extensions: dom, intl, mbstring, xml, xmlreader, xmlwriter

2022-01-18 Thread hashar
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T299389 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, kostajh, Aklapper, Lucas_Werkmeister_WMDE, 786, Suran38, Biggs657, Invadibot, Lalamarie69

[Wikidata-bugs] [Maniphest] T299389: Wikibase CI broken due to missing PHP extensions: dom, intl, mbstring, xml, xmlreader, xmlwriter

2022-01-18 Thread hashar
hashar added a comment. From `apt list`: | php-apcu| 5.1.21+4.0.11-7+0~20220117.31+debian10~1.gbp9a887a | | php-common | 2:92+0~20220117.43+debian10~1.gbpe0d14e | | php-xdebug | 3.1.2+2.9.8+2.8.1+2.5.5-1+0~20220117.45+debian10~1

[Wikidata-bugs] [Maniphest] T299389: Wikibase CI broken due to missing PHP extensions: dom, intl, mbstring, xml, xmlreader, xmlwriter

2022-01-18 Thread hashar
hashar added subscribers: kostajh, hashar. hashar added a project: Continuous-Integration-Infrastructure. hashar triaged this task as "High" priority. hashar added a comment. I have upgraded the Jenkins jobs this morning to use Quibble 1.3.0 which has patches by @kostajh . I have th

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2022-01-14 Thread hashar
hashar added a subtask: T299211: Request increased quota for integration Cloud VPS project. TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: aborrero, dcaro, Aklapper, dduvall, bd808

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2022-01-14 Thread hashar
hashar added subscribers: dcaro, aborrero. hashar added a comment. I have talked to @aborrero and @dcaro about the limits. They are inclined to further tune the limit like has been done last year by Andrew ( T266777#6589231 <https://phabricator.wikimedia.org/T266777#6589

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2022-01-13 Thread hashar
hashar added a comment. @awight potentially though `tmpfs` goes in memory and is expensive. A run with core + Wikibase and all the npm dependencies turn out to be around 9G iirc which is a lot to put in RAM. I was looking at a stall build today and it `iotop` definitely showed up

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

2022-01-13 Thread hashar
hashar added a comment. I have found the issue! I have created the Selenium jobs after the wikibase-client-docker and wikibase-repo-docker phpunit jobs which invoke the `extensions/Wikibase/build/jenkins/mw-apply-wb-settings.sh` with `-r client` or `-r repo` respectively. For Selenium

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

2022-01-13 Thread hashar
hashar added a comment. I got the `repo` variant passing by adding a few extensions as dependencies: | mediawiki/skins/MinervaNeue| | mediawiki/extensions/Cite | | mediawiki/extensions/MobileFrontend| | mediawiki/extensions

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

2022-01-13 Thread hashar
hashar added a comment. In T287582#7368381 <https://phabricator.wikimedia.org/T287582#7368381>, @Addshore wrote: > I have a suspicion that we would not want to split out `client/data-bridge` tests. > data-bridge integrated directly with MediaWiki and should be gated,

[Wikidata-bugs] [Maniphest] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2022-01-06 Thread hashar
hashar added a comment. In T194299#4840260 <https://phabricator.wikimedia.org/T194299#4840260>, @Addshore wrote: > From yesterday: > > Wikibase\UpsertSqlIdGenerator::upsertId 10.64.48.26 1205Lock wait timeout exceeded; try restarting transaction (10.64.4

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-06 Thread hashar
hashar added a comment. Maybe related is T194299 <https://phabricator.wikimedia.org/T194299>, there are mentions of `$wgWBRepoSettings['idGenerator'] = 'mysql-upsert'`, I don't know what the default is or what is set on the CI job. The comment T194299#4840260

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-06 Thread hashar
hashar added a parent task: T226869: Run browser tests in parallel. TASK DETAIL https://phabricator.wikimedia.org/T298682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Aklapper, kostajh, hashar, Invadibot, maantietaja, Akuckartz

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-06 Thread hashar
hashar created this task. hashar added projects: Wikidata, ci-test-error. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: wdwb-tech. TASK DESCRIPTION The webdriver.io Selenium tests are run serially. As part of T226869 <ht

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2021-11-12 Thread hashar
hashar added a comment. I have checked in Docker and it does a `os.removeAll` which is waited for completion. If a container has huge amount of files that have to be deleted, that would file the memory cache for writes which is is known in Linux as the Dirty memory. From `proc(5

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2021-11-12 Thread hashar
hashar added a comment. Pfff I am not focusing today. The `INFO:backend.MySQL:Terminating MySQL` is the last message send by Quibble and it has indeed completed (at max roughly 2 seconds after the message got written). What is taking age and got thoroughly investigated previously

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2021-11-12 Thread hashar
hashar added a comment. Quibble terminates MySQL via `quibble.backend.Backend.stop()` which does: def stop(self): if self.server is not None: self.log.info('Terminating %s', self.__class__.__name__) self.server.terminate() try

[Wikidata-bugs] [Maniphest] T293885: wmf-quibble-selenium-php72-docker jobs failing repeatedly: Undefined index: rc_logid

2021-10-26 Thread hashar
hashar added a comment. Thank you @Urbanecm for fixing up the CI jobs! The original patch is included in 1.38.0-wmf.6 which hence does not a backport. TASK DETAIL https://phabricator.wikimedia.org/T293885 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread hashar
hashar closed this task as "Resolved". hashar added a comment. There was just a few of those happening in production (once per hour or so). I have deployed the change to production. Thank you for the quick fix! TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL P

[Wikidata-bugs] [Maniphest] T293885: wmf-quibble-selenium-php72-docker jobs failing repeatedly: Undefined index: rc_logid

2021-10-20 Thread hashar
hashar added a comment. Out of curiosity, how has it been possible to get the faulty patch to pass through our testsuite? Is that due to some race condition? Since patch to mediawiki/core are tested against Wikibase a patch causing Wikibase to fail should not pass. TASK DETAIL https

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread hashar
hashar added a parent task: T287216: ParserOutput should implement ContentMetadataCollector. TASK DETAIL https://phabricator.wikimedia.org/T293860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, hashar Cc

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread hashar
hashar added a comment. That has been deprecated as part of T287216: ParserOutput should implement ContentMetadataCollector <https://phabricator.wikimedia.org/T287216> specially by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/727402 . A code search has definitely bee

[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread hashar
hashar created this task. hashar added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseClient, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - - mwversion: `1.38.0-wmf.5` - reqId: `b189c229-467f-484e-9b29

[Wikidata-bugs] [Maniphest] T287459: wikidata-dev instances causing git "Internal error during upload-pack" every 5 minutes

2021-09-29 Thread hashar
hashar closed this task as "Resolved". hashar claimed this task. hashar added a comment. It was still an issue last time I checked but I have been unable to reproduce it. I agree with Lucas, given it is harmless, there is no point in spending more time on this. Thank you! T

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2021-09-23 Thread hashar
hashar reopened this task as "Open". hashar added a comment. Sorry @Lucas_Werkmeister_WMDE , I have missed your comment. @kostajh raised it again today so reopening. 21:26:14 hashar: does it seem normal for `INFO:backend.MySQL:Terminating MySQL` to take ~2 minutes? looking

[Wikidata-bugs] [Maniphest] T291215: Wikibase\Lib\Store\RevisionedUnresolvedRedirectException: Unresolved redirect from Q100917584 to Q95304986

2021-09-17 Thread hashar
hashar updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T291215 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Michael, Aklapper, hashar, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T291215: Wikibase\Lib\Store\RevisionedUnresolvedRedirectException: Unresolved redirect from Q100917584 to Q95304986

2021-09-16 Thread hashar
hashar created this task. hashar added projects: Wikimedia-production-error, Wikidata-Campsite, Wikidata. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: wdwb-tech. TASK DESCRIPTION Error - - mwversion: `1.37.0-wmf.21` - reqId

[Wikidata-bugs] [Maniphest] T281122: Wikibase selenium tests timeout, seemingly due to "memory compaction" events on CI VMs

2021-09-08 Thread hashar
hashar moved this task from INBOX to Seen on the Release-Engineering-Team board. hashar edited projects, added Release-Engineering-Team (Seen); removed Release-Engineering-Team. TASK DETAIL https://phabricator.wikimedia.org/T281122 WORKBOARD https://phabricator.wikimedia.org/project/board

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

2021-08-03 Thread hashar
hashar moved this task from INBOX to Next on the Release-Engineering-Team board. hashar edited projects, added Release-Engineering-Team (Next); removed Release-Engineering-Team. TASK DETAIL https://phabricator.wikimedia.org/T287582 WORKBOARD https://phabricator.wikimedia.org/project/board

[Wikidata-bugs] [Maniphest] T287459: wikidata-dev instances causing git "Internal error during upload-pack" every 5 minutes

2021-08-02 Thread hashar
hashar triaged this task as "Low" priority. hashar added a comment. Thanks @Lucas_Werkmeister_WMDE as far as I can tell that is the proper git and v2 is usually nice. The update script looks really straightforward: cd ${GIT_PATH} git pull origin master 2>> &q

[Wikidata-bugs] [Maniphest] T287151: UnexpectedValueException: Cache key collision; IDs ('"Ey_Reqîb"','"Ey Reqîb"') map to 'commonswiki:wbmi-mediasearch-entities:"Ey_Req%C3%AEb":en'

2021-07-30 Thread hashar
hashar added a project: Structured-Data-Backlog. hashar added a comment. That is in WikibaseMediaInfo and I had added Wikidata/WMDE to the task due to the Wikibase prefix. It seems the extension is instead maintained by the Structured Data team. The key collision is due to space versus

[Wikidata-bugs] [Maniphest] T203666: Voting integration of extensions requires breaking changes to be forced

2021-07-29 Thread hashar
hashar closed this task as "Declined". hashar added a comment. If Wikibase has a breaking change, the other extensions should have patches written to adjust and the Wikibase change can then be marked as depending on the others. This way the integration tests pass. Then on

[Wikidata-bugs] [Maniphest] T287582: Move some Wikibase selenium tests to a standalone job

2021-07-28 Thread hashar
hashar added a comment. I have renamed the bridge Jenkins job to client. Amended the configuration to run `extensions/Wikibase/build/jenkins/mw-apply-wb-settings.sh` with either `-r client` or `-r repo`. `selenium-test:repo` https

[Wikidata-bugs] [Maniphest] T287445: wikidata-query-rdf-maven-release-docker build is too slow and always times out

2021-07-27 Thread hashar
hashar added a subscriber: RKemper. hashar added a comment. The timeout for https://integration.wikimedia.org/ci/job/wikidata-query-rdf-maven-release-docker/ has been raised from 45 minutes to 60 minutes which should give it enough time to complete. The saved maven cache would

[Wikidata-bugs] [Maniphest] T287459: wikidata-dev instances causing git "Internal error during upload-pack" every 5 minutes

2021-07-27 Thread hashar
hashar created this task. hashar added projects: Wikidata, Wikidata-Campsite, Gerrit. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION While browsing Gerrit logs on logstash <https://logstash.wikimedia.org/app/dashboards#/view/AW1f-0k0ZKA7RpirlnKV>, I found out tw

[Wikidata-bugs] [Maniphest] T287445: wikidata-query-rdf-maven-release-docker build is too slow and always times out

2021-07-27 Thread hashar
hashar claimed this task. hashar edited projects, added Release-Engineering-Team (Doing); removed Release-Engineering-Team. hashar added a comment. The two root causes are: - archiva.wikimedia.org has very poor latency/bandwith. I have filed a task about it but haven't raised much

[Wikidata-bugs] [Maniphest] T210260: Stretch in docker registry forces ascii encoding

2021-07-21 Thread hashar
hashar closed subtask T220763: Rebuild CI Docker images to drop ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8 as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T210260 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: akosiaris

[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files

2021-07-19 Thread hashar
hashar added a comment. An example is `mediawiki/libs/metrics-platform.git` which co host code for NodeJs, PHP, Swift and Java, each in their own directory having the relevant package manager file: | JS | https://gerrit.wikimedia.org/r/c/mediawiki/libs/metrics-platform/+/690049

[Wikidata-bugs] [Maniphest] T51236: populateSitesTable.php load-from should be configurable via a $wg setting

2021-06-11 Thread hashar
hashar closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T51236 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hoo, aude, Ricordisamoa, Aklapper, Wikidata-bugs, hashar, Denny, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T51236: populateSitesTable.php load-from should be configurable via a $wg setting

2021-06-11 Thread hashar
hashar closed subtask T51240: populateSitesTables.php should be run automatically on new wiki addition as Declined. TASK DETAIL https://phabricator.wikimedia.org/T51236 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hoo, aude

[Wikidata-bugs] [Maniphest] T51240: populateSitesTables.php should be run automatically on new wiki addition

2021-06-11 Thread hashar
hashar closed this task as "Declined". TASK DETAIL https://phabricator.wikimedia.org/T51240 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hoo, aude, Ricordisamoa, Aklapper, Wikidata-bugs, Krenair, hashar, Denny, Lydia

[Wikidata-bugs] [Maniphest] T51242: populateSitesTable script should clear cached sites data

2021-06-11 Thread hashar
hashar closed subtask T51240: populateSitesTables.php should be run automatically on new wiki addition as Declined. TASK DETAIL https://phabricator.wikimedia.org/T51242 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Wikidata-bugs, Denny

[Wikidata-bugs] [Maniphest] T46749: Sync sites table with site matrix or rebuild interwiki update script

2021-06-11 Thread hashar
hashar closed subtask T51238: addWiki.php should have some hooks as Declined. TASK DETAIL https://phabricator.wikimedia.org/T46749 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Addshore, Denny, JeroenDeDauw, aude, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T51240: populateSitesTables.php should be run automatically on new wiki addition

2021-06-11 Thread hashar
hashar closed subtask T51238: addWiki.php should have some hooks as Declined. TASK DETAIL https://phabricator.wikimedia.org/T51240 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hoo, aude, Ricordisamoa, Aklapper, Wikidata-bugs, Krenair

[Wikidata-bugs] [Maniphest] T178722: Remove puppet class role::labs::lvm::mnt

2021-06-09 Thread hashar
hashar closed this task as "Declined". hashar added a comment. Indeed that is the same, still tools / paws. From: https://openstack-browser.toolforge.org/puppetclass/role::labs::lvm::mnt > Project: tools > > tools-paws-* > > Project: toolsbeta

[Wikidata-bugs] [Maniphest] T211035: SlowTimer for two PHPunit tests, possibly from Wikibase

2021-06-04 Thread hashar
hashar closed this task as "Resolved". hashar claimed this task. hashar added a comment. Closing as probably obsolete. It might have been related to the underlying MySQL database being too slow at the time for whatever reasons. Nowadays it is running with Innodb datafiles

[Wikidata-bugs] [Maniphest] T279068: Wikibase data-client bridge selenium failure on buster but not stretch

2021-04-26 Thread hashar
hashar added a comment. Danke Schon @Jakob_WMDE ! TASK DETAIL https://phabricator.wikimedia.org/T279068 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, hashar Cc: Jakob_WMDE, Michael, Addshore, Lucas_Werkmeister_WMDE, Aklapper

[Wikidata-bugs] [Maniphest] T279068: Wikibase data-client bridge selenium failure on buster but not stretch

2021-04-26 Thread hashar
hashar added a comment. @Ladsgroup thank you so much for fixing this test! TASK DETAIL https://phabricator.wikimedia.org/T279068 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, hashar Cc: Michael, Addshore, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T279068: Wikibase data-client bridge selenium failure

2021-04-01 Thread hashar
hashar renamed this task from "Wikibase data-client bridge selenium " to "Wikibase data-client bridge selenium failure". TASK DETAIL https://phabricator.wikimedia.org/T279068 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T279068: Wikibase data-client bridge selenium

2021-04-01 Thread hashar
hashar added a comment. Will try to figure out the reproduction command with the image used by the CI job `docker-registry.wikimedia.org/releng/quibble-buster-php72:0.0.46-s1` TASK DETAIL https://phabricator.wikimedia.org/T279068 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T279068: Wikibase data-client bridge selenium

2021-04-01 Thread hashar
hashar created this task. hashar added projects: Wikibase, Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION We are trying to update the CI jobs for Quibble from Stretch to Buster (which bring in a new

[Wikidata-bugs] [Maniphest] T274506: PHP Warning: Wikibase\Repo\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder: No RDF builder defined for data type globe-coordinate nor for value type bad.

2021-02-11 Thread hashar
hashar added a project: Wikibase. Restricted Application added a project: wdwb-tech-focus. TASK DETAIL https://phabricator.wikimedia.org/T274506 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Aklapper, hashar, Akuckartz, darthmon_wmde

[Wikidata-bugs] [Maniphest] T274506: PHP Warning: Wikibase\Repo\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder: No RDF builder defined for data type globe-coordinate nor for value type bad.

2021-02-11 Thread hashar
hashar created this task. hashar added projects: Wikimedia-production-error, Wikidata-Campsite. hashar triaged this task as "High" priority. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION name=Error message P

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

2021-02-02 Thread hashar
hashar added a comment. I had dinner, come back and magic the task is closed. Thank you! TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, hashar Cc: hashar, WMDE-leszek

[Wikidata-bugs] [Maniphest] T273622: Deprecation warning: Expected RevisionRecord to belong to ...

2021-02-02 Thread hashar
hashar added a comment. I guess we "just" need to backport those two merged changes to 1.36.0-wmf.29 ? If so please cherry pick to `wmf/1.36.0-wmf.29` and either sync them or I can do it. 1.36.0-wmf.29 is still blocked on other changes though so I am most probably not goi

[Wikidata-bugs] [Maniphest] T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job)

2021-02-01 Thread hashar
hashar added a comment. Restricted Application added a project: wdwb-tech-focus. Another one: name=Unresolved redirect from Q104821940 to Q56305763 /w/rest.php/en.wikipedia.org/v3/page/pagebundle/Template%3AISO_15924%2Fqid/1003335501 Wikibase\DataModel\Services\Lookup

[Wikidata-bugs] [Maniphest] T272998: Wikibase CI test failure in FederatedProperties SetClaimTest: Argument 1 passed to PHPUnit\Framework\Assert::fail() must be of the type string, array given

2021-01-27 Thread hashar
hashar added a comment. Nice Lucas. EventBus should be added to the wmf-quibble* jobs as well (T272863 <https://phabricator.wikimedia.org/T272863>) and PHPUnit tests currently fail because of that string/array mismatch. TASK DETAIL https://phabricator.wikimedia.org/T272998

[Wikidata-bugs] [Maniphest] T271933: PHP Fatal Error: Cannot redeclare Wikibase\MediaInfo\Search\closureToAnonymousClass() (previously declared in /srv/mediawiki/php-1.36.0-wmf.26/extensions/WikibaseM

2021-01-13 Thread hashar
hashar added subscribers: Cparle, dcausse, matthiasmullie, hashar. hashar added a comment. The code comes from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/640820 (and depends on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/640809

[Wikidata-bugs] [Maniphest] T242959: A database query error has occurred. Query: SELECT wby_id AS `id`, wby_name AS `name` FROM `wbt_type` ORDER BY id Function: MediaWiki\Storage\NameTableStore::loadT

2021-01-07 Thread hashar
hashar added a comment. Spotted again on commonswiki: /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/Database.php:1680 counterexample #0 /srv/mediawiki/php-1.36.0-wmf.25/includes/libs/rdbms/database/Database.php(1658): Wikimedia\Rdbms\Database

[Wikidata-bugs] [Maniphest] T269608: Several failing tests in Wikibase CI (CentralAuthApiSessionProviderTest, CentralAuthHeaderSessionProviderTest, EditEntityActionTest, ViewEntityActionTest, HtmlPage

2020-12-24 Thread hashar
hashar added a comment. @Lucas_Werkmeister_WMDE congratulations on finding MW_API as being the root cause! TASK DETAIL https://phabricator.wikimedia.org/T269608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, hashar Cc

[Wikidata-bugs] [Maniphest] T210286: Create docker based CI job to build the wikidata-query-gui

2020-12-18 Thread hashar
hashar edited projects, added Continuous-Integration-Infrastructure; removed Continuous-Integration-Infrastructure (Slipway). TASK DETAIL https://phabricator.wikimedia.org/T210286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Jakob_WMDE

[Wikidata-bugs] [Maniphest] T269608: Several failing tests in Wikibase CI (CentralAuthApiSessionProviderTest, CentralAuthHeaderSessionProviderTest, EditEntityActionTest, ViewEntityActionTest, HtmlPage

2020-12-07 Thread hashar
hashar added a comment. I don't have any lead myself beside the CentralAuth one (which does not seem to change anything since my proposal fails still). It is late so yeah lets check what we can do tomorrow and maybe loop other people. Thank you Luca! TASK DETAIL https

[Wikidata-bugs] [Maniphest] T269608: Several failing tests in Wikibase CI (CentralAuthApiSessionProviderTest, CentralAuthHeaderSessionProviderTest, EditEntityActionTest, ViewEntityActionTest, HtmlPage

2020-12-07 Thread hashar
hashar added a comment. Sorry Lucas I have misread your earlier comment about the failure occurring with just Wikibase / FlaggedRevs. The test I have done reverting a CentralAuth patch doesn't help indeed, that still fails :-\ TASK DETAIL https://phabricator.wikimedia.org/T269608 EMAIL

[Wikidata-bugs] [Maniphest] T269608: Several failing tests in Wikibase CI (CentralAuthApiSessionProviderTest, CentralAuthHeaderSessionProviderTest, EditEntityActionTest, ViewEntityActionTest, HtmlPage

2020-12-07 Thread hashar
hashar added a comment. Next trick, download the Jenkins console log, filter for lines matching `Prepared` to match the informational messages emitted by `zuul.cloner`. That is the bit in Quibble which takes care of cloning the repositories, fetch the patches / branch. Doing a diff yields

[Wikidata-bugs] [Maniphest] T269608: Several failing tests in Wikibase CI (CentralAuthApiSessionProviderTest, CentralAuthHeaderSessionProviderTest, EditEntityActionTest, ViewEntityActionTest, HtmlPage

2020-12-07 Thread hashar
hashar added a comment. It is very unlikely the Jenkins upgrade is any related. The jobs are running in Docker containers and Jenkins is really just running `docker run` commands over ssh to WMCS instances. I am not entirely ruling it out though, but it has a very low chance

[Wikidata-bugs] [Maniphest] T269315: Fatal error: Cannot pass parameter 1 by reference (Wikibase\DataModel\Entity)

2020-12-03 Thread hashar
hashar added a comment. Thank you Lucas and Amir for the investigation. TASK DETAIL https://phabricator.wikimedia.org/T269315 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: hashar, Lucas_Werkmeister_WMDE, Ladsgroup, mmodell, RhinosF1

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-11-25 Thread hashar
hashar closed this task as "Resolved". hashar added a comment. That has been more or less fixed by raising the newish IO quota for the integration instances. It is still not ideal and enhancements will be made later on via the infrastructure task T266777 <https://phabricator.

[Wikidata-bugs] [Maniphest] T213089: Upgrade memcached cluster to Debian Stretch/Buster

2020-11-06 Thread hashar
hashar closed subtask T267388: Puppet failure on deployment-memc08.deployment-prep.eqiad.wmflabs as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T213089 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Ladsgroup, Krenair

[Wikidata-bugs] [Maniphest] T213089: Upgrade memcached cluster to Debian Stretch/Buster

2020-11-06 Thread hashar
hashar added a subtask: T267388: Puppet failure on deployment-memc08.deployment-prep.eqiad.wmflabs . TASK DETAIL https://phabricator.wikimedia.org/T213089 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Ladsgroup, Krenair, elukey, jijiki

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-11-03 Thread hashar
hashar merged a task: T267075: Pipeline jobs freezing during teardown. TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Aklapper, dduvall, bd808, jeena, Daimona, thcipriani, hashar

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-11-03 Thread hashar
hashar merged a task: T267075: Pipeline jobs freezing during teardown. hashar added subscribers: jeena, bd808, dduvall, Aklapper. TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-29 Thread hashar
hashar added a comment. @Lucas_Werkmeister_WMDE yes Wikibase kind of highlights the issue since it has so many files. I have also noticed the disk slowness on various other jobs though, some started to timeout as a result due to the number of IO operations they perform. I thought

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-29 Thread hashar
hashar added a subtask: T266777: integration instances suffer from high IO latency due to Ceph. TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: Daimona, thcipriani, hashar, awight

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-28 Thread hashar
hashar added a comment. I have found out the root cause which is in the underlying infrastructure. Will file a task about it tomorrow. TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-28 Thread hashar
hashar added a comment. I have looked at it live by running strace profiling against `dockerd` while a container was being reaped: name=strace -C -e trace=file -f -p `pidof dockerd` % time seconds usecs/call callserrors syscall

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-28 Thread hashar
hashar added a comment. So my best assumption is that the source code / package install etc are done inside the Docker container. Upon removal, Docker spends a lot of time to delete all those files which might explain the issue. If that is true, that can be reproduced by spawning

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-28 Thread hashar
hashar added a comment. Looks like the container is stuck in `removing` status. For a build with: 13:09:39 INFO:backend.MySQL:Terminating MySQL 13:10:33 [wmf-quibble-selenium-php72-docker] $ /bin/bash -xe /tmp/jenkins4716707043969520657.sh Running `docker container inspect

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-28 Thread hashar
hashar added a comment. No with child tracing (`-f`) and time spent in system call (`-T`). PID 23094 invokes `epoll_pwait` which resumes after 3 seconds for whatever reason. name=strace -s 128 -tt -yy -T -f [pid 23092] 10:21:51.923319 write(2, "time=\"2020-10-28T10:21:5

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-28 Thread hashar
hashar added a comment. With `TINY_VERBOSITY=3` and `docker -D -l debug run`: 08:58:27 [INFO tini (1)] Main child exited normally (with status '1') 08:58:28 time="2020-10-28T08:58:28Z" level=debug msg="[hijack] End of stdout" 08:58:38 Build step 'Execute

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-27 Thread hashar
hashar added a comment. I have done various hacking here and there nothing conclusive. I have rolled back: - https://integration.wikimedia.org/ci/job/integration-quibble-fullrun/ - Dockerd --- Dockerd running with `docker: true` gives a lot more logs in the journal

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-26 Thread hashar
hashar added a comment. Same for Docker 19.03.13 / 1.3.7 . wmf-quibble-selenium-php72-docker builds still have a minute delay or so. TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-26 Thread hashar
hashar added a comment. I have upgraded containerd from 1.2.10-3 to 1.2.13-2 on eight hosts but that unfortunately does not seem to help :-( TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-26 Thread hashar
hashar added a comment. For later reference: 11:23:24 INFO:backend.MySQL:Terminating MySQL 11:24:41 [wmf-quibble-selenium-php72-docker] $ /bin/bash -xe /tmp/jenkins937915457220888713.sh And in containerd the log shows the process got reaped properly?: Oct 26 10:56:21

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-21 Thread hashar
hashar added a comment. I was watching integration-agent-docker-1004 which had 3 builds involving Quibble. I have opened pages using the Jenkins monitoring interface that lets one list processes and java threads. As soon as one showed the delay I refreshed the two pages. On the list

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-21 Thread hashar
hashar claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T265615 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: thcipriani, hashar, awight, kostajh, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-20 Thread hashar
hashar added a comment. Next fun, digging into Jenkins! I looked at https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/64820/ which got affected by the same issue (all times are UTC): counterexample 18:08:34 [wmf-quibble-selenium-php72-docker] $ /bin

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-20 Thread hashar
hashar added a comment. After many attempts, I finally got a lead https://integration.wikimedia.org/ci/job/integration-quibble-fullrun/153/console The job executes a shell script utils/ci-fullrun.sh in integration/quibble.git, I have edited it to `echo CI FULLRUN completed` when

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-16 Thread hashar
hashar added a comment. I tried various combination and I can not reproduce it. Maybe it is race condition between us sending SIGKILL (`self.server.kill()`) and python reaping the processed on garbage collection when we set `self.server = None` :-\ TASK DETAIL https

[Wikidata-bugs] [Maniphest] T265615: Terminating MySQL takes several minutes in (Wikibase?) CI jobs

2020-10-16 Thread hashar
hashar added a comment. Gave it a try with a bit more logging. One run with a 2 seconds delay which is too short and trigger a SIGKILL: 00:22:05.191 INFO:quibble.commands:Shutting down backends: 00:22:05.191 INFO:backend.MySQL:Stopping MySQL 00:22:05.192

  1   2   3   4   5   6   7   8   9   >