[Wikidata-bugs] [Maniphest] T270158: [12h] Decide on the "secondary" CI for Wikibase code repository

2020-12-16 Thread hoo
hoo added a comment. In T270158#6692094 <https://phabricator.wikimedia.org/T270158#6692094>, @Lucas_Werkmeister_WMDE wrote: > The main use of the Travis CI that I can remember is that it uses wikis with non-English content languages, so occasionally it flags up t

[Wikidata-bugs] [Maniphest] T270353: Wikibase client Scribunto tests fail due to ParserOptions-option handling change

2020-12-16 Thread hoo
hoo created this task. hoo added projects: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION 5413678f068c47325ce4e9c7c612746cf3c459a0 <https://phabricator.wikimedia.org/rMW5413678f068c47325ce4e9c7c612746cf3c45

[Wikidata-bugs] [Maniphest] T264883: Prepare deployment of JSON dumps for Lexeme

2020-11-10 Thread hoo
hoo added a comment. I still need to test my changes (sadly there are no automated tests for these scripts and it would be excruciatingly hard to write some for the current bash scripts). Once that is done, this is good to go from my side. TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T266496: Not possible to add new statements with any Math properties

2020-10-28 Thread hoo
hoo added a comment. Poking around and git bisect point to 7f430f142d7f19cb575f0e665719619c9312ae57 <https://phabricator.wikimedia.org/rEWBA7f430f142d7f19cb575f0e665719619c9312ae57>. TASK DETAIL https://phabricator.wikimedia.org/T266496 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T265899: Investigate where explicit D.en usages on English Wikipedia come from

2020-10-21 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo added a comment. In T265899#6560252 <https://phabricator.wikimedia.org/T265899#6560252>, @Lydia_Pintscher wrote: > Wild guess: so

[Wikidata-bugs] [Maniphest] T264883: Prepare deployment of JSON dumps for Lexeme

2020-10-12 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T264883 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T264295: Reinstate $wgExtraLanguageCodes in production

2020-10-05 Thread hoo
hoo moved this task from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T264295 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field

2020-10-03 Thread hoo
hoo added a comment. @Physikerwelt Nowadays we pull in some of the (JS) libraries using git submodules. Are your submodules in Wikibase all initialized and up to date? TASK DETAIL https://phabricator.wikimedia.org/T229939 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] T264385: Wikibase client Scribunto tests are broken

2020-10-01 Thread hoo
hoo created this task. hoo added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION With 7bb47b6 <https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] T264066: Disable termbox v2 on desktop Wikidata

2020-09-30 Thread hoo
hoo added a comment. The relevant configuration has just been removed, meaning that this is disabled on beta again (but might still be in caches). TASK DETAIL https://phabricator.wikimedia.org/T264066 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T232620: Trying to create entities via wbeditentity when blocked should not assign a fresh entity ID

2020-09-30 Thread hoo
hoo added a comment. In T232620#6503844 <https://phabricator.wikimedia.org/T232620#6503844>, @Bugreporter wrote: > The scope of this task is a bit wider than the patch. If an item can not be created because of an label/description conflict, the ID is still allocated.

[Wikidata-bugs] [Maniphest] T232620: Trying to create entities via wbeditentity when blocked should not assign a fresh entity ID

2020-09-22 Thread hoo
hoo renamed this task from "Trying to create entities via wbeditentity when blocked should not assigned a fresh entity ID" to "Trying to create entities via wbeditentity when blocked should not assign a fresh entity ID". hoo claimed this task. TASK DETAIL https://phabr

[Wikidata-bugs] [Maniphest] T127088: When Content Translation connects articles in Wikidata, it should also add a label

2020-09-14 Thread hoo
hoo closed this task as a duplicate of T119964: Update Wikidata item label after publishing based on translated title. TASK DETAIL https://phabricator.wikimedia.org/T127088 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: 1234qwer1234qwer4

[Wikidata-bugs] [Maniphest] T119964: Update Wikidata item label after publishing based on translated title

2020-09-14 Thread hoo
hoo merged a task: T127088: When Content Translation connects articles in Wikidata, it should also add a label. hoo added subscribers: 1234qwer1234qwer4, YonaB, Bugreporter, hoo, daniel. TASK DETAIL https://phabricator.wikimedia.org/T119964 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T260771: Add signal: has a statement linking to a media file

2020-08-26 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Item Quality Scoring Improvement (Item Quality Scoring Improvement - Sprint 2) board. TASK DETAIL https://phabricator.wikimedia.org/T260771 WORKBOARD https://phabricator.wikimedia.org/project/board/4945/ EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T247690: Detail of error message is no longer shown in Wikidata edit interface

2020-07-04 Thread hoo
hoo closed this task as "Resolved". hoo moved this task from To Do to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo added a comment. In T247690#6228627 <https://phabricator.wikimedia.org/T247690#6228627>, @Lydia_Pintscher wrote: > T

[Wikidata-bugs] [Maniphest] [Created] T257113: Reivew list of messages marked as ignored for translation

2020-07-04 Thread hoo
hoo created this task. hoo added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Per T247690#6176937 <https://phabricator.wikimedia.org/T247690#6176937> we should review the list of messages we don't want to translate. Why did we choose to

[Wikidata-bugs] [Maniphest] [Commented On] T253027: Add LabelEdit component to Termbox storybook

2020-05-20 Thread hoo
hoo added a comment. @toan Which of the two patches should be reviewed? Are they still WIP (if not, you should publish them for review in Gerrit). TASK DETAIL https://phabricator.wikimedia.org/T253027 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Declined] T114251: [RFC] Magic Infobox implementation

2020-05-19 Thread hoo
hoo closed this task as "Declined". hoo added a comment. As this never really got anywhere, let's abandon this (at least for the foreseeable future). TASK DETAIL https://phabricator.wikimedia.org/T114251 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailp

[Wikidata-bugs] [Maniphest] [Unblock] T114477: [RfC] Future of the Article Placeholder Extension

2020-05-19 Thread hoo
hoo closed subtask T114251: [RFC] Magic Infobox implementation as Declined. TASK DETAIL https://phabricator.wikimedia.org/T114477 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucie, hoo Cc: Qgil, aude, daniel, Ricordisamoa, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T252632: Restart wikidata entity dumps

2020-05-19 Thread hoo
hoo added a comment. Just a note for the future: While the individual dump run recovered and eventually produced a dump, the cron itself (which was supposed to start other RDF dump flavours afterwards) got killed. TASK DETAIL https://phabricator.wikimedia.org/T252632 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T247690: Detail of error message is no longer shown in Wikidata edit interface

2020-05-15 Thread hoo
hoo added a comment. I tagged the release now, so we only need to update the submodule in Wikibase now. TASK DETAIL https://phabricator.wikimedia.org/T247690 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Addshore, Petar.petkovic

[Wikidata-bugs] [Maniphest] [Closed] T252632: Restart wikidata entity dumps

2020-05-13 Thread hoo
hoo closed this task as "Resolved". hoo claimed this task. hoo added a comment. Seems this automatically recovered :) hoo@snapshot1008:/var/log/wikidatadump$ grep -A 1 -B 1 -rni fail *2020051* dumpwikidatattl-wikidata-20200511-all-BETA-4.log-30269- dumpwikidatatt

[Wikidata-bugs] [Maniphest] [Commented On] T247690: Detail of error message is no longer shown in Wikidata edit interface

2020-05-13 Thread hoo
hoo added a comment. This still needs the release preparation patch to be merged (https://gerrit.wikimedia.org/r/c/wikibase/javascript-api/+/596231), then we can tag it (while doing that, we should also tag the past `3.1.1` release as that was forgotten back then). After

[Wikidata-bugs] [Maniphest] [Updated] T249613: Cleanup rows from wb_items_per_site that should not be there any more

2020-05-11 Thread hoo
hoo added a comment. I just created a one-off script for getting the items the above items conflict with: https://gist.github.com/mariushoch/ae4538741ec3e5409dfa4e9a90c346dc. With that I was able to find, for each of the above items, the items we have sitelink-conflicts with: P11176

[Wikidata-bugs] [Paste] [Updated] P11175: rebuildItemsPerSite 2020-04-27 failures (items that failed saving again on 2020-05-11)

2020-05-11 Thread hoo
hoo changed the title of this paste from "rebuildItemsPerSite 2020-04-27 failures" to "rebuildItemsPerSite 2020-04-27 failures (items that failed saving again on 2020-05-11)". hoo edited the content of this paste. PASTE DETAIL https://phabricator.wikimedia.org/P1117

[Wikidata-bugs] [Maniphest] [Updated] T249613: Cleanup rows from wb_items_per_site that should not be there any more

2020-05-11 Thread hoo
hoo added a comment. The rebuild items per site run finished. Sadly the following 2,738 items produced errors, where one or more of their sitelinks could not be saved to the table (typically because the sitelink is already recorded for another item): P11175 rebuildItemsPerSite 2020-04-27

[Wikidata-bugs] [Maniphest] [Claimed] T247690: Detail of error message is no longer shown in Wikidata edit interface

2020-05-06 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T247690 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Created] T251961: Wikibase rows in enhanced recentchanges sometimes miss a separating space

2020-05-05 Thread hoo
hoo created this task. hoo added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Wikibase client's ChangeLineFormatter misses a word separator when used

[Wikidata-bugs] [Maniphest] [Retitled] T251382: Use strict types everywhere in Wikibase

2020-04-30 Thread hoo
hoo renamed this task from "Use strict types everywhere in WIkibase" to "Use strict types everywhere in Wikibase". TASK DETAIL https://phabricator.wikimedia.org/T251382 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore,

[Wikidata-bugs] [Maniphest] [Commented On] T249811: Add more properties to the PageImages list

2020-04-29 Thread hoo
hoo added a comment. Deployed and verified: After purging with "forcelinkupdate", the page image for "Pudong" (`Q125378`) changed from "locator map image" (`P242`) to "collage image" (`P2716`), as can be seen on https://www.wikidata.org/wiki/Sp

[Wikidata-bugs] [Maniphest] [Claimed] T249811: Add more properties to the PageImages list

2020-04-28 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T249811 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Claimed] T239707: remove feedback link from tainted references again once feedback round is finished

2020-04-28 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T239707 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Closed] T251119: change the data type of International Standard Identifier for Libraries (P791)

2020-04-28 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo closed this task as "Resolved". hoo added a comment. Done hoo@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/changePropertyDa

[Wikidata-bugs] [Maniphest] [Commented On] T249613: Cleanup rows from wb_items_per_site that should not be there any more

2020-04-27 Thread hoo
hoo added a comment. I just ran the script (and it ran within about 10m!), it deleted 743 outdated rows. $ mwscript extensions/Wikibase/repo/maintenance/pruneItemsPerSite.php --wiki wikidatawiki | tee logs/pruneItemsPerSite-2020-04-27.log $ echo $(("$(grep Deleted

[Wikidata-bugs] [Maniphest] [Commented On] T249613: Cleanup rows from wb_items_per_site that should not be there any more

2020-04-23 Thread hoo
hoo added a comment. I scheduled the deployment of the script for Monday (April 27, 9:30 UTC), after that I will run it and then I'll do a complete run of `rebuildItemsPerSite`. TASK DETAIL https://phabricator.wikimedia.org/T249613 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Claimed] T249613: Cleanup rows from wb_items_per_site that should not be there any more

2020-04-22 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T249613 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T249811: Add more properties to the PageImages list

2020-04-09 Thread hoo
hoo added a comment. Current order (from `wmgWBRepoPreferredPageImagesProperties` in `mediawiki-config` `InitialiseSettings.php`): 'wikidatawiki' => [ // Photos 'P18', // Complex graphics 'P41', 'P94', 'P154', 'P1

[Wikidata-bugs] [Maniphest] [Closed] T248612: Wikibase dump scripts fail as they can't find 'Wikibase\Lib\WikibaseSettings'

2020-04-02 Thread hoo
hoo closed this task as "Resolved". hoo added a comment. Closing this as new JSON and RDF dumps are available on https://dumps.wikimedia.org/wikidatawiki/entities/ now (not for all kinds of dumps yet, but that's just a matter of time). TASK DETAIL https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Edited] T248984: Client recentchanges entries sometimes don't have their wb_changes.change_id reference set

2020-03-31 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T248984 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Liuxinyu970226, hoo, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Created] T248984: Client recentchanges entries sometimes don't have their wb_changes.change_id reference set

2020-03-31 Thread hoo
hoo created this task. Restricted Application added subscribers: Liuxinyu970226, Aklapper. TASK DESCRIPTION Apparently some recentchanges rows which we inject into wikibase clients don't have their "id" (referring to `wb_changes.change_id` on the repo) set: wikiadmin@10.64.32.

[Wikidata-bugs] [Maniphest] [Updated] T248984: Client recentchanges entries sometimes don't have their wb_changes.change_id reference set

2020-03-31 Thread hoo
hoo removed subscribers: MediaWiki-extensions-WikibaseClient, Wikidata. hoo added projects: Wikidata, MediaWiki-extensions-WikibaseClient, Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T248984 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Edited] T248656: entitysources: Directly create entitySources config for beta cluster sites

2020-03-30 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T248656 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Addshore, Aklapper, Ladsgroup, WMDE-leszek, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T248612: Wikibase dump scripts fail as they can't find 'Wikibase\Lib\WikibaseSettings'

2020-03-30 Thread hoo
hoo added a comment. JSON dumpers in production are working again and thus new JSON and RDF dumps should appear as usual. TASK DETAIL https://phabricator.wikimedia.org/T248612 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Envlh

[Wikidata-bugs] [Maniphest] [Changed Project Column] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

2020-03-27 Thread hoo
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo added a comment. Moving this to test verification as all keys will go through `makeKey` now. Sadly we don't have a programmatic way to ensure all callers follow our

[Wikidata-bugs] [Maniphest] [Commented On] T248672: quibble-vendor-selenium-docker CI builds broken for Wikibase

2020-03-27 Thread hoo
hoo added a comment. Seems to be fixed: https://integration.wikimedia.org/ci/job/quibble-vendor-selenium-docker/6215/console :) TASK DETAIL https://phabricator.wikimedia.org/T248672 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Retitled] T248612: Wikibase dump scripts fail as they can't find 'Wikibase\Lib\WikibaseSettings'

2020-03-27 Thread hoo
hoo renamed this task from "Wikibase dump scripts fail due as they can't find 'Wikibase\Lib\WikibaseSettings'" to "Wikibase dump scripts fail as they can't find 'Wikibase\Lib\WikibaseSettings'". TASK DETAIL https://phabricator.wikimedia.org/T248612 EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T248612: Wikibase dump scripts fail due as they can't find 'Wikibase\Lib\WikibaseSettings'

2020-03-26 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T248612 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Created] T248612: Wikibase dump scripts fail due as they can't find 'Wikibase\Lib\WikibaseSettings'

2020-03-26 Thread hoo
hoo created this task. hoo added projects: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION From snapshot1008: (2020-03

[Wikidata-bugs] [Maniphest] [Edited] T248612: Wikibase dump scripts fail due as they can't find 'Wikibase\Lib\WikibaseSettings'

2020-03-26 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T248612 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, ArielGlenn, Aklapper, hoo, Iflorez, darthmon_wmde, alaa_wmde, Nandana

[Wikidata-bugs] [Maniphest] [Closed] T248264: Convert property CPDL ID (P2000) from String to External identifier

2020-03-23 Thread hoo
hoo closed this task as "Resolved". hoo claimed this task. hoo added a comment. Done hoo@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/changePropertyDataType.php --wiki wikidatawiki --new-data-type external-id --property-id P2000 Successfully updated th

[Wikidata-bugs] [Maniphest] [Closed] T231948: : Attribute "longitude" has an invalid value - when value is close to zero

2020-03-21 Thread hoo
hoo closed this task as "Resolved". hoo removed a project: Patch-For-Review. hoo assigned this task to TheDJ. TASK DETAIL https://phabricator.wikimedia.org/T231948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: TheDJ, hoo Cc: thiemow

[Wikidata-bugs] [Maniphest] [Claimed] T248160: Wikibase Travis CI jobs failing when wiki language is other than English

2020-03-21 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T248160 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T247300: Investigate what it takes to add a __EXPECTED_UNCONNECTED_PAGE__ magic word to exclude pages from Special:UnconnectedPages

2020-03-10 Thread hoo
hoo added a comment. Maybe we should see how many pages might be affected by this (as upper bound, count all pages that currently aren't linked to wikidata)... with that number we will be able to make a reasonable decision. If not terribly many pages are affected by this, `page_props

[Wikidata-bugs] [Maniphest] [Edited] T245865: Remove legacy Wikibase service containers

2020-03-06 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Edited] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-03-06 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T241975 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek, hoo Cc: Ladsgroup, WMDE-leszek, Addshore, Aklapper, Beast1978, Un1tY, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Edited] T245870: Remove RepositorySettings

2020-03-05 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Edited] T241975: entitysources: Remove old MultiRepository & PerRepository Service containers and config

2020-03-05 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T241975 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek, hoo Cc: Ladsgroup, WMDE-leszek, Addshore, Aklapper, Beast1978, Un1tY, Hook696, Daryl-TTMG

[Wikidata-bugs] [Maniphest] [Edited] T245865: Remove legacy Wikibase service containers

2020-03-05 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Claimed] T245865: Remove legacy Wikibase service containers

2020-03-05 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T245865 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Edited] T245865: Remove legacy Wikibase service containers

2020-03-05 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Edited] T245870: Remove RepositorySettings

2020-03-05 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Edited] T245831: Remove conditional "federation mode" logic from the remaining "low-level" Wikibase code

2020-03-04 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245831 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Edited] T245831: Remove conditional "federation mode" logic from the remaining "low-level" Wikibase code

2020-03-04 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245831 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Edited] T245860: Remove conditional "federation mode" logic from the Wikibase "top-level" factories

2020-03-04 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Changed Project Column] T244023: GetEntities, DivergingEntityIdException: Revision 1072801264 belongs to Q354111 instead of expected d:Q354111

2020-02-24 Thread hoo
hoo moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo added a comment. I addressed the problem mentioned above, but this potentially affects all places where we: a) Take user supplied entity ids b) check EntityLookup::hasEntityId

[Wikidata-bugs] [Maniphest] [Edited] T245865: Remove legacy Wikibase service containers

2020-02-24 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A

[Wikidata-bugs] [Maniphest] [Edited] T245830: Remove conditional "federation mode" logic from the Wikibase API and hook code

2020-02-21 Thread hoo
hoo updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T245830 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Addshore, WMDE-leszek, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A

[Wikidata-bugs] [Maniphest] [Claimed] T244023: GetEntities, DivergingEntityIdException: Revision 1072801264 belongs to Q354111 instead of expected d:Q354111

2020-02-21 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T244023 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T243951: Lua creates lots of ItemId and PropertyId objects

2020-02-19 Thread hoo
hoo added a comment. I just thought about this a bit and did some very basic benchmarks: On my system I can assemble 1 million item ids in about 1.6 seconds, so I don't think this is a huge problem (also it means that whatever cache we use here needs to be damn fast, or it will be slower

[Wikidata-bugs] [Maniphest] [Commented On] T245513: Retire wikibase-term-store and archive repo

2020-02-18 Thread hoo
hoo added a comment. In T245513#5893016 <https://phabricator.wikimedia.org/T245513#5893016>, @WMDE-leszek wrote: > I've archived the github repository, which might have premature move given https://gerrit.wikimedia.org/r/572652 is not merged yet. Please advise if I should und

[Wikidata-bugs] [Maniphest] [Created] T245513: Retire wikibase-term-store and archive repo

2020-02-18 Thread hoo
hoo created this task. hoo added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION After T244916 <https://phabricator.wikimedia.org/T244916> `wikibase/term

[Wikidata-bugs] [Maniphest] [Changed Project Column] T196165: Commons image: when pasting the exact title, get the correct file first in the suggester

2020-02-17 Thread hoo
hoo moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo added a comment. Moving back to doing, because this needs a submodule update in Wikibase. TASK DETAIL https://phabricator.wikimedia.org/T196165 WORKBOARD https

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-13 Thread hoo
hoo added a comment. PR for new datamodel services release (which will feature our new interfaces): https://github.com/wmde/WikibaseDataModelServices/pull/235 TASK DETAIL https://phabricator.wikimedia.org/T244916 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Changed Project Column] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-12 Thread hoo
hoo moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. hoo added a comment. For creating the new narrow interfaces in WikibaseDataModelServices: https://github.com/wmde/WikibaseDataModelServices/pull/234 TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-12 Thread hoo
hoo added a comment. In T244916#5876959 <https://phabricator.wikimedia.org/T244916#5876959>, @Tarrow wrote: > I'm also probably adding un thought through ideas to this but... > If TermStores can't read is having them in lib the right place? Wouldn't we be smarter to

[Wikidata-bugs] [Maniphest] [Commented On] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-12 Thread hoo
hoo added a comment. In T244916#5876096 <https://phabricator.wikimedia.org/T244916#5876096>, @Lucas_Werkmeister_WMDE wrote: > If this is done, I’d say the interface(s) should be renamed, because having a “store” that’s write-only and doesn’t support reads doesn’t make se

[Wikidata-bugs] [Maniphest] [Claimed] T244916: (Property|Item)TermStore::getTerms() is unused

2020-02-12 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T244916 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove

2020-02-11 Thread hoo
hoo added a comment. We now have fairly conclusive test coverage of this (covers all from-global-state-factory methods I could find), so I think we can consider this done. TASK DETAIL https://phabricator.wikimedia.org/T243729 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Claimed] T243729: Check Wikibase services for expensive setup patterns (db & api calls etc) & fix / remove

2020-02-10 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T243729 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T244529: mw.wikibase.getLabelByLang not return item label for some items

2020-02-07 Thread hoo
hoo added a comment. We don't know what happened, but the fix to this caused cluster wide timeouts, maybe the new term storage couldn't yet handle the additional load? Will need to be investigated and we need another short-term fix. TASK DETAIL https://phabricator.wikimedia.org/T244529

[Wikidata-bugs] [Maniphest] [Commented On] T244529: mw.wikibase.getLabelByLang not return item label for some items

2020-02-07 Thread hoo
hoo added a comment. Interesting: > $wbRepo = Wikibase\Repo\WikibaseRepo::getDefaultInstance(); > $wbClient = Wikibase\Client\WikibaseClient::getDefaultInstance(); > $clientTermLookup = $wbClient->getTermLookup(); > $repoTermL

[Wikidata-bugs] [Maniphest] [Claimed] T244529: mw.wikibase.getLabelByLang not return item label for some items

2020-02-07 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T244529 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Changed Project Column] T243782: Create a dashboard representing the "yes that's fine" confirmation clicks data

2020-02-07 Thread hoo
hoo moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint10 board. hoo added a comment. Added as "Clicks on the "Remove warning" button" on https://grafana.wikimedia.org/d/hyhG5l1Wk/tainted-references. TASK DETAIL https://phabricator.w

[Wikidata-bugs] [Maniphest] [Claimed] T243782: Create a dashboard representing the "yes that's fine" confirmation clicks data

2020-02-07 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint10 board. TASK DETAIL https://phabricator.wikimedia.org/T243782 WORKBOARD https://phabricator.wikimedia.org/project/board/4537/ EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Claimed] T238403: Create Grafana boards

2020-02-06 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Peer Review on the Wikidata-Tainted-References-Sprint10 board. hoo added a comment. See the new "Statement Edits (UI only)" panel on https://grafana.wikimedia.org/d/hyhG5l1Wk/tainted-references?orgId=1. TASK DETA

[Wikidata-bugs] [Maniphest] [Commented On] T243817: Browsertest for showing tainted icon after cancelling edit

2020-02-06 Thread hoo
hoo added a comment. In T243817#5840035 <https://phabricator.wikimedia.org/T243817#5840035>, @Rosalie_WMDE wrote: > The Gerrit patch depends on this pull request: https://github.com/wmde/wdio-wikibase/pull/14 Merged and released as 2.3.0. TASK DETAI

[Wikidata-bugs] [Maniphest] [Claimed] T243392: Move storybook to doc.wikimedia.org

2020-01-27 Thread hoo
hoo claimed this task. hoo edited projects, added Wikidata-Tainted-References-Sprint9; removed Wikidata Tainted References. TASK DETAIL https://phabricator.wikimedia.org/T243392 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper

[Wikidata-bugs] [Maniphest] [Claimed] T234789: Step 2: confirm existing reference when edit doesn't influence it

2020-01-20 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint9 board. TASK DETAIL https://phabricator.wikimedia.org/T234789 WORKBOARD https://phabricator.wikimedia.org/project/board/4516/ EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T242119: StopEditing Hook should dispatch STOP_EDIT action

2020-01-20 Thread hoo
hoo added a comment. The patch up now doesn't change the visible behaviour, as it still explicitly untaints the statement once the edit is cancelled. Changing that behavior (so that the statement will be shown as tainted still) is just a matter of deleting a line now, though. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Claimed] T242119: Cancel hook handler should set taintState to false

2020-01-17 Thread hoo
hoo claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T242119 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Lydia_Pintscher, Aklapper, Rosalie_WMDE, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild

[Wikidata-bugs] [Maniphest] [Claimed] T242117: Test that icon shows only when taintedState is true and editState is false

2020-01-10 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint8 board. TASK DETAIL https://phabricator.wikimedia.org/T242117 WORKBOARD https://phabricator.wikimedia.org/project/board/4461/ EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Claimed] T242121: Add Cancel hook

2020-01-08 Thread hoo
hoo claimed this task. hoo moved this task from To Do to Peer Review on the Wikidata-Tainted-References-Sprint8 board. TASK DETAIL https://phabricator.wikimedia.org/T242121 WORKBOARD https://phabricator.wikimedia.org/project/board/4461/ EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Retitled] T242119: Cancel hook handler should set taintState to false if taintState is true and editState is false

2020-01-08 Thread hoo
hoo renamed this task from "Change cancel hook to set taintState to false if taintState is true and editState is false" to "Cancel hook handler should set taintState to false if taintState is true and editState is false". TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Claimed] T233097: Step 1: Localise any currently hardcoded messages

2019-12-09 Thread hoo
hoo claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T233097 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Aklapper, Tarrow, Sarai-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] [Commented On] T185313: mw.wikibase.entity:getBacklinks (lua API in wikibase client)

2019-11-28 Thread hoo
hoo added a comment. So I just looked into this a bit and sadly this is not a trivial change. First of all, I don't think we want to expose backlinks (as in Special:WhatLinksHere) as these don't have the semantics the use cases here call for (and using them still would probably lead

[Wikidata-bugs] [Maniphest] [Changed Project Column] T231730: Step 1: Help link

2019-11-21 Thread hoo
hoo moved this task from To Do to Test (Product Review) on the Wikidata-Tainted-References-Sprint5 board. hoo added a comment. I think thisis actually fully done by now. TASK DETAIL https://phabricator.wikimedia.org/T231730 WORKBOARD https://phabricator.wikimedia.org/project/board/4376

[Wikidata-bugs] [Maniphest] [Commented On] T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”

2019-11-19 Thread hoo
hoo added a comment. Thanks @Anomie, that makes sense. IMO it's probably best to revert the change for SQLite only, this seems fairly clunky and probably has a good chance of breaking installations (with old data!) in the wild. TASK DETAIL https://phabricator.wikimedia.org/T238575

[Wikidata-bugs] [Maniphest] [Commented On] T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”

2019-11-19 Thread hoo
hoo added a comment. But what is actually stored in the database (`SELECT TYPEOF`)? TASK DETAIL https://phabricator.wikimedia.org/T238575 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, WMDE-leszek, Anomie, tstarling, Addshore

[Wikidata-bugs] [Maniphest] [Commented On] T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”

2019-11-19 Thread hoo
hoo added a comment. In T238575#5675025 <https://phabricator.wikimedia.org/T238575#5675025>, @Lucas_Werkmeister_WMDE wrote: > Hm, it still fails when calling `initState()` with `[ '0' => 'foowiki' ]`, so I don’t think casting `$siteID` to a string in `initState()` would chan

  1   2   3   4   5   6   7   8   9   10   >