[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
kostajh added a comment. In T353961#9595656 <https://phabricator.wikimedia.org/T353961#9595656>, @Lucas_Werkmeister_WMDE wrote: >> The tests mostly work in secondary CI, and I think I managed to fix all of them > > Update: With this commit <https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/06ce15d63ccc205a3fa64034b86a6c863ec60440> (incorporating the fixes in Wikibase and the above patch to MediaWiki core), all the secondary CI runs are indeed green <https://github.com/wikimedia/mediawiki-extensions-Wikibase/actions/runs/8139893743> \o/ which would also be useful for T359043 <https://phabricator.wikimedia.org/T359043>, I assume. Thanks. I added T359043 <https://phabricator.wikimedia.org/T359043> as a parent task, assuming that this task is also about fixing the CI errors when AutoCreateTempUser is enabled. The three errors I see (log <https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php74-docker/39519/consoleFull>): 13:15:46 8) Wikibase\Repo\Tests\Specials\SpecialSetSiteLinkTest::testExecutePostModifySiteLink 13:15:46 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled 13:15:46 13:15:46 /workspace/src/includes/user/ActorStore.php:639 13:15:46 /workspace/src/includes/user/ActorStore.php:416 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:875 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:760 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:626 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:477 13:15:46 /workspace/src/includes/libs/rdbms/database/Database.php:2300 13:15:46 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119 13:15:46 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:672 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:485 13:15:46 /workspace/src/includes/Storage/PageUpdater.php:1375 13:15:46 /workspace/src/includes/Storage/PageUpdater.php:923 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:416 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:275 13:15:46 /workspace/src/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php:84 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEntityStore.php:53 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/EditEntity/MediaWikiEditEntity.php:610 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEditEntity.php:77 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/Specials/SpecialWikibaseRepoPage.php:193 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/Specials/SpecialModifyEntity.php:224 13:15:46 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:120 13:15:46 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:50 13:15:46 /workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:75 13:15:46 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialSetSiteLinkTest.php:266 13:15:46 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106 Logs generated by test Show Details 13:15:46 13:15:46 9) Wikibase\Repo\Tests\Specials\SpecialSetSiteLinkTest::testExecutePostRemoveSiteLink 13:15:46 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled 13:15:46 13:15:46 /workspace/src/includes/user/ActorStore.php:639 13:15:46 /workspace/src/includes/user/ActorStore.php:416 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:875 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:760 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:626 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:477 13:15:46 /workspace/src/includes/libs/rdbms/database/Database.php:2300 13:15:46 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119 13:15:46 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:672 13:15:46 /workspace/src/includes/Revision/RevisionStore.php:485 13:15:46 /workspace/src/includes/Storage/PageUpdater.php:1375 13:15:46 /workspace/src/includes/Storage/PageUpdater.php:923 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:416 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:275 13:15:46 /workspace/src/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php:84 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEntityStore.php:53 13:15:46 /workspace/src/extensions/Wikibase/repo/includes/Edi
[Wikidata-bugs] [Maniphest] T326908: Update WMDE Engineering-owned products that may be affected by IP Masking
kostajh removed a parent task: T359043: Enable temp account creation in DevelopmentSettings.php. TASK DETAIL https://phabricator.wikimedia.org/T326908 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: TAdeleye_WMF, Michael, WMDE-Fisch, WMDE-leszek, ItamarWMDE, Niharika, ARamirez_WMF, SCherukuwada, Aklapper, Tchanders, Ullasoff, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
kostajh added a parent task: T359043: Enable temp account creation in DevelopmentSettings.php. TASK DETAIL https://phabricator.wikimedia.org/T353961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, kostajh Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T326908: Update WMDE Engineering-owned products that may be affected by IP Masking
kostajh added a parent task: T359043: Enable temp account creation in DevelopmentSettings.php. TASK DETAIL https://phabricator.wikimedia.org/T326908 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: TAdeleye_WMF, Michael, WMDE-Fisch, WMDE-leszek, ItamarWMDE, Niharika, ARamirez_WMF, SCherukuwada, Aklapper, Tchanders, Ullasoff, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
kostajh added a comment. In T353961#9595415 <https://phabricator.wikimedia.org/T353961#9595415>, @Lucas_Werkmeister_WMDE wrote: > In T353961#9532074 <https://phabricator.wikimedia.org/T353961#9532074>, @kostajh wrote: > >> T355879: Create jobs that run PHPUnit, Selenium, and API testing tests with temp account feature flag enabled <https://phabricator.wikimedia.org/T355879> is also relevant, and would handle running CI tests for Wikibase with temp accounts enabled in WMF infrastructure. > > Yeah, that sounds like a good thing to have for browser and API tests (which we currently don’t run in secondary CI, as mentioned in the task description). But apart from that, I think it’s still a good idea to test IP masking in secondary CI too; we already have five secondary CI jobs, so I think we can just change some of them to enable IP masking (rather than add more jobs). Sounds good. > I’ll try out whether the tests even work or not. Just as a heads up, I think we are leaning towards enabling temp account creation by default in CI rather than having a second set of jobs (T359043: Enable temp account creation in DevelopmentSettings.php <https://phabricator.wikimedia.org/T359043>). TASK DETAIL https://phabricator.wikimedia.org/T353961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, kostajh Cc: kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344984: Wikibase: Fire postEdit hook after making an edit
kostajh added a comment. In T344984#9537155 <https://phabricator.wikimedia.org/T344984#9537155>, @Michael wrote: > In T344984#9534559 <https://phabricator.wikimedia.org/T344984#9534559>, @kostajh wrote: > >> Is there a list somewhere of the types of edits made on Wikidata? > > Not sure if such a list exists anywhere, but it is bound to be long. Just the things from the top of my head: > > - editing Item/Property terms via the legacy desktop Termbox > - editing Item/Property terms via the mobile Vue Termbox > - soon™️ that Vue Termbox will also be used to edit EntitySchema terms on desktop > - editing statements via the Wikibase UI > - editing sitelinks on Items via the Wikibase UI > - Restoring a previous good revisions via the history > - //undoing// specific previous edits on Items/Properties/Lexemes via the history (I //think// this is a home-grown Wikibase functionality) > - Editing the Lemmas, Forms and Senses via the WikibaseLexeme vue-based UI > - //undoing// specific previous edits on EntitySchema via the history (Reimplementation of the Wikibase thing) > - Editing a EntitySchema text via the `edit` action > > This does not include edits from Special pages, because based on https://wikitech.wikimedia.org/wiki/User-agent_client_hints Client Hints seem to not be enabled there? > Also, I probably forgot a bunch of places, and also did not yet consider whether we have any popular Gadgets for editing. > Further, as mentioned above, there are edits made on Wikidata from other WMF wikis via the Link-Item widget for Sitelinks and (in practice for now disabled) Wikidata Bridge. > Finally, it is worth noting that majority of edits on Wikidata are not made by humans via the UI but by bots or somewhat external tools like quickstatements (https://www.wikidata.org/wiki/Help:QuickStatements). Thanks for this list! I suppose this is a question for checkuser users on Wikidata--which of these is most important for collecting signals when doing sock puppet investigations? Then focus on an implementation for just that editing entrypoint, rather than trying to deal with all of them. TASK DETAIL https://phabricator.wikimedia.org/T344984 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: WMDE-leszek, Ifrahkhanyaree_WMDE, Michael, Lucas_Werkmeister_WMDE, Dreamy_Jazz, Aklapper, kostajh, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344984: Wikibase: Fire postEdit hook after making an edit
kostajh added a comment. In T344984#9453620 <https://phabricator.wikimedia.org/T344984#9453620>, @Michael wrote: > I think this is to the largest degree about the Edits as they made on Wikidata, right? There is //some// impact on WikibaseClient(=Wikibase code that runs on Wikipedias, Wikisource, Wikivoyage, Wiktionary,...) especially around WikiData-Bridge and maybe the Link-Item widget, but that's not the primary focus, right? Is there a list somewhere of the types of edits made on Wikidata? On the Wikipedias, editing a page (source editor or VisualEditor) or using DiscussionTools will fire the postEdit hook, which CheckUser extension listens to in order to collect and store client hint data. Ideally, any interface used on Wikidata for creating a revision would also fire the postEdit hook, so that CheckUser can collect and store client hint data. TASK DETAIL https://phabricator.wikimedia.org/T344984 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: WMDE-leszek, Ifrahkhanyaree_WMDE, Michael, Lucas_Werkmeister_WMDE, Dreamy_Jazz, Aklapper, kostajh, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled
kostajh added a comment. T355879: Create job that runs PHPUnit unit and integration tests with temp account feature flag is enabled <https://phabricator.wikimedia.org/T355879> is also relevant, and would handle running CI tests for Wikibase with temp accounts enabled in WMF infrastructure. TASK DETAIL https://phabricator.wikimedia.org/T353961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T349118: Migrate node-based services in production to node18
kostajh added a project: Trust and Safety Product Team (Engineering). TASK DETAIL https://phabricator.wikimedia.org/T349118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Sbailey, WMDE-leszek, KartikMistry, Michael, gmodena, Ottomata, elukey, WDoranWMF, Ahoelzl, MSantos, Jdforrester-WMF, GLima-WMF, Danny_Benjafield_WMDE, BartTerpstra, Isabelladantes1983, Themindcoder, Dominika_Naumiuk, Kappakayala, Mohamed-Awnallah, Adamm71, Jersione, Hellket777, LisafBia6531, Wangombe, Astuthiodit_1, 786, lbowmaker, VPuffetMichel, Arnoldokoth, BTullis, Biggs657, ihurbain, karapayneWMDE, Kritisinghh, Vyaki, bwang, Deek9399, Invadibot, Surya742, Dasgupta002, Deveshprasad577, Atharva17, Tsiruot, sobhanbera, UOzurumba, Bharatkhatri351, Ywats0ns, PallaviPatke, diegodlh, Aishik_Rehman, maantietaja, Juan90264, Tiputini, wkandek, JMeybohm, Alter-paule, Beast1978, Rileych, ItamarWMDE, Un1tY, DAlangi_WMF, Nintendofan885, Akuckartz, Ironie, 50019062, Hook696, darthmon_wmde, Kent7301, joker88john, Tris_T7, CucyNoiD, Nandana, jijiki, Gaboe420, Mihailo, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, chapulina, QZanden, srishakatux, KimKelting, Alfa80, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Jdrewniak, Jason_Quinn, Soum213, Taiwania_Justo, Neuronton, Nizil, Scott_WUaS, Shangkuanlc, Ixocactus, Verdy_p, Wikidata-bugs, Base, aude, Amire80, Mvolz, Dalba, Lydia_Pintscher, Jsahleen, mxn, Nikerabbit, Arrbee, santhosh, Arlolra, TheDJ, Mbch331, Jay8g, Krenair, Clement_Goubert ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T349118: Migrate node-based services in production to node18
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T349118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Sbailey, WMDE-leszek, KartikMistry, Michael, gmodena, Ottomata, elukey, WDoranWMF, Ahoelzl, MSantos, Jdforrester-WMF, GLima-WMF, Danny_Benjafield_WMDE, BartTerpstra, Isabelladantes1983, Themindcoder, Dominika_Naumiuk, Kappakayala, Mohamed-Awnallah, Adamm71, Jersione, Hellket777, LisafBia6531, Wangombe, Astuthiodit_1, 786, lbowmaker, VPuffetMichel, Arnoldokoth, BTullis, Biggs657, ihurbain, karapayneWMDE, Kritisinghh, Vyaki, bwang, Deek9399, Invadibot, Surya742, Dasgupta002, Deveshprasad577, Atharva17, Tsiruot, sobhanbera, UOzurumba, Bharatkhatri351, Ywats0ns, PallaviPatke, diegodlh, Aishik_Rehman, maantietaja, Juan90264, Tiputini, wkandek, JMeybohm, Alter-paule, Beast1978, Rileych, ItamarWMDE, Un1tY, DAlangi_WMF, Nintendofan885, Akuckartz, Ironie, 50019062, Hook696, darthmon_wmde, Kent7301, joker88john, Tris_T7, CucyNoiD, Nandana, jijiki, Gaboe420, Mihailo, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, chapulina, QZanden, srishakatux, KimKelting, Alfa80, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Jdrewniak, Jason_Quinn, Soum213, Taiwania_Justo, Neuronton, Nizil, Scott_WUaS, Shangkuanlc, Ixocactus, Verdy_p, Wikidata-bugs, Base, aude, Amire80, Mvolz, Dalba, Lydia_Pintscher, Jsahleen, mxn, Nikerabbit, Arrbee, santhosh, Arlolra, TheDJ, Mbch331, Jay8g, Krenair, Clement_Goubert ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T354730: Support creating items as not-logged-in user when TempAccounts is enabled
kostajh added a project: Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)). TASK DETAIL https://phabricator.wikimedia.org/T354730 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Lucas_Werkmeister_WMDE, dcausse, Tchanders, Michael, Lydia_Pintscher, Arian_Bozorg, Aklapper, ArthurTaylor, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T266706: element (".wb-tr-tainted-icon") still not existing after 10000ms
kostajh added a comment. It would be helpful to have a policy (or maybe there is one already?) about flaky tests. My understanding is that for more than one case of a non-deterministic failure of a test, it is reasonable to disable it alongside a phabricator task explaining the error, so that there is an audit trail and relevant teams could follow up on it later. TASK DETAIL https://phabricator.wikimedia.org/T266706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Michael, matmarex, Lucas_Werkmeister_WMDE, kostajh, Aklapper, Reedy, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344984: Wikibase: Fire postEdit hook after making an edit
kostajh added a comment.
In T344984#9120046 <https://phabricator.wikimedia.org/T344984#9120046>,
@Lucas_Werkmeister_WMDE wrote:
> Which arguments is the hook supposed to be fired with? Is there
documentation for it anywhere?
AIUI, it is acceptable to fire without any arguments, from
`resources/src/mediawiki.action/mediawiki.action.view.postEdit.js`:
/**
* Fired after an edit was successfully saved.
*
* Does not fire for null edits.
*
* Code that fires the postEdit hook should first set `wgRevisionId` and
`wgCurRevisionId`
* to the revision associated with the edit that triggered the postEdit
hook, then fire
* the postEdit hook, e.g.:
*
* mw.config.set( {
*wgCurRevisionId: data.newrevid,
*wgRevisionId: data.newrevid
* } );
* // Now fire the hook.
* mw.hook( 'postEdit' ).fire();
*/
TASK DETAIL
https://phabricator.wikimedia.org/T344984
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: kostajh
Cc: Lucas_Werkmeister_WMDE, Dreamy_Jazz, Aklapper, kostajh,
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,
ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic,
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude,
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344984: Wikibase: Fire postEdit hook after making an edit
kostajh added a parent task: T257893: [EPIC] Support User-Agent Client Hints header in CheckUser. TASK DETAIL https://phabricator.wikimedia.org/T344984 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Dreamy_Jazz, Aklapper, kostajh, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344984: Wikibase: Fire postEdit hook after making an edit
kostajh added a project: http-client-hints. TASK DETAIL https://phabricator.wikimedia.org/T344984 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Dreamy_Jazz, Aklapper, kostajh, ItamarWMDE, Akuckartz, lucamauri, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344984: Wikibase: Fire postEdit hook after making an edit
kostajh created this task. kostajh added a project: MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION For the #http-client-hints <https://phabricator.wikimedia.org/tag/http-client-hints/> project, #CheckUser <https://phabricator.wikimedia.org/tag/checkuser/> listens to the `postEdit` hook to obtain the newly created revision ID, and it sends this information along with user agent client hints to a CheckUser REST endpoint for storage (see https://www.mediawiki.org/wiki/Extension:CheckUser/Client_Hints and https://wikitech.wikimedia.org/wiki/User-agent_client_hints for more information.) Wikibase does not fire the `postEdit` hook, and this task proposes that it starts doing so, so that we can receive client hint data alongside Wikibase edits. (Doing so would also provide more consistency in having JS editing interfaces use a common hook for signaling that they've made an edit, although, see T330831: Make postEdit hook reliably support user interaction <https://phabricator.wikimedia.org/T330831> for critiques of `postEdit` and an alternative proposal.) TASK DETAIL https://phabricator.wikimedia.org/T344984 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Aklapper, kostajh, ItamarWMDE, Akuckartz, lucamauri, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332953: Migrate PipelineLib repos to GitLab
kostajh added a comment. In Gerrit / PipelineLib workflow, the PipelineBot makes a comment in Gerrit with the newly published image tag names, example <https://gerrit.wikimedia.org/r/c/research/mwaddlink/+/927609/2#message-219bf96a57fae363ef1a2dd3f0c08809e42e39f1>. Are there plans to implement similar functionality for GitLab merge requests? TASK DETAIL https://phabricator.wikimedia.org/T332953 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Gehel, jnuche, isarantopoulos, BPirkle, Tgr, Eevans, Seddon, MSantos, kevinbazira, odimitrijevic, BTullis, Ottomata, calbon, fgiunchedi, WMDE-leszek, fkaelin, ItamarWMDE, elukey, KartikMistry, santhosh, Martaannaj, sbassett, bking, bd808, Ladsgroup, Krinkle, Legoktm, tstarling, Physikerwelt, dcausse, Jdrewniak, taavi, hnowlan, Michaelcochez, cjming, Jdforrester-WMF, dduvall, Aklapper, thcipriani, Uata1122, fbalicchia, Iarya3, Isabelladantes1983, Bellucii32, Themindcoder, Adamm71, Jersione, Itsmeduncan, Hellket777, Cleo_Lemoisson, LisafBia6531, JArguello-WMF, Astuthiodit_1, Atieno, 786, TheReadOnly, Biggs657, karapayneWMDE, toberto, joanna_borun, Simonmaignan, Invadibot, DAbad, Devnull, maantietaja, Juan90264, Muchiri124, Confetti68, Anerka, Alter-paule, Beast1978, CBogen, Un1tY, Nintendofan885, Akuckartz, Otr500, Hook696, WDoranWMF, Ddurigon, MJL, Kent7301, brennen, Mateo1977, EvanProdromou, joker88john, Legado_Shulgin, ReaperDawn, CucyNoiD, Nandana, NebulousIris, Namenlos314, aezell, skpuneethumar, Gaboe420, Zylc, Giuliamocci, Davinaclare77, Abdeaitali, Cpaulf30, 1978Gage2001, Techguru.pc, Lahi, Operator873, Gq86, Af420, Xinbenlv, Vacio, Sharvaniharan, Bsandipan, scblr, Xover, GoranSMilovanovic, SPoore, TBolliger, Chicocvenancio, Hfbn0, QZanden, Tbscho, Taquo, LawExplorer, catalandres, Eginhard, Lewizho99, Zppix, JJMC89, Maathavan, TerraCodes, DDJJ, _jensen, rosalieper, Agabi10, PEarleyWMF, Neuronton, RuyP, Liudvikas, Scott_WUaS, Pchelolo, Karthik_sripal, Izno, Wong128hk, Luke081515, Bsadowski1, Niharika, Wikidata-bugs, Jitrixis, aude, Bawolff, Dbrant, Dinoguy1000, Gryllida, Lydia_Pintscher, faidon, Grunny, ssastry, scfc, Alchimista, Arlolra, csteipp, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332953: Migrate PipelineLib repos to GitLab
kostajh closed subtask T337714: Migrate mediawiki/services/ipoid to GitLab as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T332953 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: jnuche, isarantopoulos, BPirkle, Tgr, Eevans, Seddon, MSantos, kevinbazira, odimitrijevic, BTullis, Ottomata, calbon, fgiunchedi, WMDE-leszek, fkaelin, ItamarWMDE, elukey, KartikMistry, santhosh, Martaannaj, sbassett, bking, bd808, Ladsgroup, Krinkle, Legoktm, tstarling, Physikerwelt, dcausse, Jdrewniak, taavi, hnowlan, Michaelcochez, cjming, Jdforrester-WMF, dduvall, Aklapper, thcipriani, Iarya3, Isabelladantes1983, Bellucii32, Themindcoder, Stevemunene, Adamm71, Jersione, Itsmeduncan, Hellket777, Cleo_Lemoisson, Brielikethecheese, LisafBia6531, JArguello-WMF, Astuthiodit_1, Atieno, 786, EChetty, TheReadOnly, Biggs657, karapayneWMDE, toberto, joanna_borun, Simonmaignan, Invadibot, DAbad, MPhamWMF, Devnull, maantietaja, Juan90264, Muchiri124, Confetti68, Anerka, Alter-paule, Beast1978, CBogen, Un1tY, Nintendofan885, Akuckartz, Otr500, Hook696, WDoranWMF, Ddurigon, MJL, Kent7301, brennen, Mateo1977, EvanProdromou, joker88john, Legado_Shulgin, ReaperDawn, CucyNoiD, Nandana, NebulousIris, Namenlos314, aezell, skpuneethumar, kostajh, Gaboe420, Zylc, Giuliamocci, Davinaclare77, Abdeaitali, Cpaulf30, 1978Gage2001, Techguru.pc, Lahi, Operator873, Gq86, Af420, Xinbenlv, Vacio, Sharvaniharan, Bsandipan, scblr, Xover, GoranSMilovanovic, SPoore, TBolliger, Chicocvenancio, Hfbn0, QZanden, EBjune, Tbscho, Taquo, LawExplorer, catalandres, Eginhard, Lewizho99, Zppix, JJMC89, Maathavan, TerraCodes, DDJJ, _jensen, rosalieper, Agabi10, PEarleyWMF, Neuronton, RuyP, Liudvikas, Scott_WUaS, Pchelolo, Karthik_sripal, Izno, Wong128hk, Luke081515, Bsadowski1, Niharika, Wikidata-bugs, Jitrixis, aude, Bawolff, Dbrant, Dinoguy1000, Gryllida, Lydia_Pintscher, faidon, Grunny, ssastry, scfc, Alchimista, Arlolra, csteipp, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars()
kostajh triaged this task as "Unbreak Now!" priority. kostajh added a comment. CI broken for multiple extensions + beta wikis offline => UBN. TASK DETAIL https://phabricator.wikimedia.org/T338213 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, daniel, Aklapper, Lucas_Werkmeister_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars()
kostajh added a comment. In T338213#8905378 <https://phabricator.wikimedia.org/T338213#8905378>, @Lucas_Werkmeister_WMDE wrote: > In T338213#8905338 <https://phabricator.wikimedia.org/T338213#8905338>, @kostajh wrote: > >> Hmm, beta wikis are offline too with a similar error: >> >> [ZH73@OA1dX58GXh@K8XaKgAAAJA] /wiki/Main_Page Error: Call to undefined method MediaWiki\Extension\TorBlock\TorBlockAbuseFilterHooks::onAbuseFilter-builder() >> ... > > Which beta wiki is that? The URL says Main Page, but beta enwiki <https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page>, beta Wikidata <https://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page> and beta Commons <https://commons.wikimedia.beta.wmflabs.org/wiki/Main_Page> all work for me at the moment. Sorry, cs beta wiki: https://cs.wikipedia.beta.wmflabs.org/wiki/Speci%C3%A1ln%C3%AD:Uv%C3%ADtac%C3%AD_dotazn%C3%ADk TASK DETAIL https://phabricator.wikimedia.org/T338213 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, daniel, Aklapper, Lucas_Werkmeister_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars()
kostajh added a comment. In T338213#8905354 <https://phabricator.wikimedia.org/T338213#8905354>, @gerritbot wrote: > Change 927590 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): > > [mediawiki/core@master] Revert "Simplify HookContainer" > > https://gerrit.wikimedia.org/r/927590 I've +2'ed the patch. Beta should be fixed within ~60 minutes. TASK DETAIL https://phabricator.wikimedia.org/T338213 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, daniel, Aklapper, Lucas_Werkmeister_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T338213: Wikibase CI failing: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars()
kostajh added a comment. Hmm, beta wikis are offline too with a similar error: [ZH73@OA1dX58GXh@K8XaKgAAAJA] /wiki/Main_Page Error: Call to undefined method MediaWiki\Extension\TorBlock\TorBlockAbuseFilterHooks::onAbuseFilter-builder() Backtrace: from /srv/mediawiki/php-master/includes/HookContainer/HookContainer.php(158) #0 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Hooks/AbuseFilterHookRunner.php(51): MediaWiki\HookContainer\HookContainer->run(string, array) #1 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/KeywordsManager.php(219): MediaWiki\Extension\AbuseFilter\Hooks\AbuseFilterHookRunner->onAbuseFilter_builder(array) #2 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/KeywordsManager.php(283): MediaWiki\Extension\AbuseFilter\KeywordsManager->getBuilderValues() #3 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/KeywordsManager.php(245): MediaWiki\Extension\AbuseFilter\KeywordsManager->getVarsMappings() #4 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(798): MediaWiki\Extension\AbuseFilter\KeywordsManager->isVarInUse(string) #5 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(817): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->varExists(string) #6 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(459): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->getVarValue(string) #7 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(546): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode) #8 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(551): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode) #9 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(590): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode) #10 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(590): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode) #11 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(590): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode) #12 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(590): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode) #13 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(590): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode) #14 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(439): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalNode(MediaWiki\Extension\AbuseFilter\Parser\AFPTreeNode) #15 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(383): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->evalTree(MediaWiki\Extension\AbuseFilter\Parser\AFPSyntaxTree) #16 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/Parser/FilterEvaluator.php(349): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->parse(string) #17 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(372): MediaWiki\Extension\AbuseFilter\Parser\FilterEvaluator->checkConditions(string, string) #18 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(333): MediaWiki\Extension\AbuseFilter\FilterRunner->checkFilter(MediaWiki\Extension\AbuseFilter\Filter\ExistingFilter) #19 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/FilterRunner.php(224): MediaWiki\Extension\AbuseFilter\FilterRunner->checkAllFiltersInternal() #20 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php(89): MediaWiki\Extension\AbuseFilter\FilterRunner->run() #21 /srv/mediawiki/php-master/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php(66): MediaWiki\Extension\AbuseFilter\AbuseFilterPreAuthenticationProvider->testUser(User, User, boolean) #22 /srv/mediawiki/php-master/includes/auth/AuthManager.php(1836): MediaWiki\Extension\AbuseFilter\AbuseFilterPreAuthenticationProvider->testUserForCreation(User, string, array) #23 /srv/mediawiki/php-master/includes/Setup.php(578): MediaWiki\Auth\AuthManager->autoCreateUser(User, string, boolean)
[Wikidata-bugs] [Maniphest] T332953: Migrate PipelineLib repos to GitLab
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T332953 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: jnuche, isarantopoulos, BPirkle, Tgr, Eevans, Seddon, MSantos, kevinbazira, odimitrijevic, BTullis, Ottomata, calbon, fgiunchedi, WMDE-leszek, fkaelin, ItamarWMDE, elukey, KartikMistry, santhosh, Martaannaj, sbassett, bking, bd808, Ladsgroup, Krinkle, Legoktm, tstarling, Physikerwelt, dcausse, Jdrewniak, taavi, hnowlan, Michaelcochez, cjming, Jdforrester-WMF, dduvall, Aklapper, thcipriani, Bellucii32, Themindcoder, Stevemunene, Adamm71, Jersione, Itsmeduncan, Hellket777, Cleo_Lemoisson, Brielikethecheese, LisafBia6531, JArguello-WMF, Astuthiodit_1, Atieno, 786, EChetty, TheReadOnly, Biggs657, karapayneWMDE, toberto, joanna_borun, Simonmaignan, Invadibot, DAbad, MPhamWMF, Devnull, maantietaja, Juan90264, Muchiri124, Confetti68, Anerka, Alter-paule, Beast1978, CBogen, Un1tY, Nintendofan885, Akuckartz, Otr500, Hook696, WDoranWMF, Ddurigon, MJL, Kent7301, brennen, Mateo1977, EvanProdromou, joker88john, Legado_Shulgin, ReaperDawn, CucyNoiD, Nandana, NebulousIris, Namenlos314, aezell, skpuneethumar, kostajh, Gaboe420, Zylc, Giuliamocci, Davinaclare77, Abdeaitali, Cpaulf30, 1978Gage2001, Techguru.pc, Lahi, Operator873, Gq86, Af420, Xinbenlv, Vacio, Sharvaniharan, Bsandipan, scblr, Xover, GoranSMilovanovic, SPoore, TBolliger, Chicocvenancio, Hfbn0, QZanden, EBjune, Tbscho, Taquo, LawExplorer, catalandres, Eginhard, Lewizho99, Zppix, JJMC89, Maathavan, TerraCodes, DDJJ, _jensen, rosalieper, Agabi10, PEarleyWMF, Neuronton, RuyP, Liudvikas, Scott_WUaS, Pchelolo, Karthik_sripal, Izno, Wong128hk, Luke081515, Bsadowski1, Niharika, Wikidata-bugs, Jitrixis, aude, Bawolff, Dbrant, Dinoguy1000, Gryllida, Lydia_Pintscher, faidon, Grunny, ssastry, scfc, Alchimista, Arlolra, csteipp, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332953: Migrate PipelineLib repos to GitLab
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T332953 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: jnuche, isarantopoulos, BPirkle, Tgr, Eevans, Seddon, MSantos, kevinbazira, odimitrijevic, BTullis, Ottomata, calbon, fgiunchedi, WMDE-leszek, fkaelin, ItamarWMDE, elukey, KartikMistry, santhosh, Martaannaj, sbassett, bking, bd808, Ladsgroup, Krinkle, Legoktm, tstarling, Physikerwelt, dcausse, Jdrewniak, taavi, hnowlan, Michaelcochez, cjming, Jdforrester-WMF, dduvall, Aklapper, thcipriani, Bellucii32, Themindcoder, Stevemunene, Adamm71, Jersione, Itsmeduncan, Hellket777, Cleo_Lemoisson, Brielikethecheese, LisafBia6531, JArguello-WMF, Astuthiodit_1, Atieno, 786, EChetty, TheReadOnly, Biggs657, karapayneWMDE, toberto, joanna_borun, Simonmaignan, Invadibot, DAbad, MPhamWMF, Devnull, maantietaja, Juan90264, Muchiri124, Confetti68, Anerka, Alter-paule, Beast1978, CBogen, Un1tY, Nintendofan885, Akuckartz, Otr500, Hook696, WDoranWMF, Ddurigon, MJL, Kent7301, brennen, Mateo1977, EvanProdromou, joker88john, Legado_Shulgin, ReaperDawn, CucyNoiD, Nandana, NebulousIris, Namenlos314, aezell, skpuneethumar, kostajh, Gaboe420, Zylc, Giuliamocci, Davinaclare77, Abdeaitali, Cpaulf30, 1978Gage2001, Techguru.pc, Lahi, Operator873, Gq86, Af420, Xinbenlv, Vacio, Sharvaniharan, Bsandipan, scblr, Xover, GoranSMilovanovic, SPoore, TBolliger, Chicocvenancio, Hfbn0, QZanden, EBjune, Tbscho, Taquo, LawExplorer, catalandres, Eginhard, Lewizho99, Zppix, JJMC89, Maathavan, TerraCodes, DDJJ, _jensen, rosalieper, Agabi10, PEarleyWMF, Neuronton, RuyP, Liudvikas, Scott_WUaS, Pchelolo, Karthik_sripal, Izno, Wong128hk, Luke081515, Bsadowski1, Niharika, Wikidata-bugs, Jitrixis, aude, Bawolff, Dbrant, Dinoguy1000, Gryllida, Lydia_Pintscher, faidon, Grunny, ssastry, scfc, Alchimista, Arlolra, csteipp, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T228527: Support nested package.json files
kostajh added subscribers: Sgs, kostajh. kostajh added a comment. I'd love to see this as well, for #growthexperiments <https://phabricator.wikimedia.org/tag/growthexperiments/> where we have a `documentation` site with its own package.json <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GrowthExperiments/+/refs/heads/master/documentation/frontend/package.json> (cc @Sgs ) TASK DETAIL https://phabricator.wikimedia.org/T228527 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Sgs, hashar, Pablo-WMDE, darthmon_wmde, WMDE-leszek, Addshore, Daimona, Michael, Legoktm, Jdforrester-WMF, Aklapper, Lucas_Werkmeister_WMDE, Esanders, Astuthiodit_1, karapayneWMDE, Invadibot, Lectrician1, Zabe, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T335468: Wikibase\Lexeme\Tests\MediaWiki\Api\ApiUserBlockedTest::testAddForm test failures
kostajh claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T335468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Michael, Jdforrester-WMF, matmarex, kostajh, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T335468: Wikibase\Lexeme\Tests\MediaWiki\Api\ApiUserBlockedTest::testAddForm test failures
kostajh added subscribers: matmarex, Jdforrester-WMF. kostajh added a comment. The failure was introduced by rMW3fbd9c815385: ApiBase: Remove special error messages for blocks <https://phabricator.wikimedia.org/rMW3fbd9c815385c9db5eb616f34b5aa991bc9b75b1> (cc @matmarex @Jdforrester-WMF ) TASK DETAIL https://phabricator.wikimedia.org/T335468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Jdforrester-WMF, matmarex, kostajh, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328497: Remove unnecessary targets definitions
kostajh closed subtask T328544: GrowthExperiments: Remove unnecessary target definitions as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T328497 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: KSiebert, WMDE-Fisch, StudiesWorld, Jdforrester-WMF, Aklapper, Krinkle, Catrope, Legoktm, TrevorParscal, ori, Ricordisamoa, Krenair, gerritbot, Florian, brion, Nikerabbit, Tgr, pmiazga, Ciencia_Al_Poder, Tacsipacsi, JohanahoJ, Ltrlg, AntiCompositeNumber, Lens0021, kostajh, Universal_Omega, Michael, alistair3149, Jdlrobson, Themindcoder, Mohamed-Awnallah, KLawal-WMF, Adamm71, PMenon-WMF, gonzalez.actor, Jersione, PWaigi-WMF, Hellket777, LisafBia6531, Wangombe, Astuthiodit_1, vyuen, Gethan, STH, 786, Sgs, fenpedia, lbowmaker, MaryMunyoki, VPuffetMichel, BTullis, Biggs657, karapayneWMDE, toberto, Simonmaignan, Invadibot, LaMagiaaa, DesignerThan, Func, Zabe, MPhamWMF, Ywats0ns, H0bby, Asartea, Dentonius, diegodlh, Bebiezaza, HNordeenWMF, Timbaaa, maantietaja, Parlautan, calbon, Wilmanbeno, GhostInTheMachine, Juan90264, Zblace, Pietrasagh, Rost_WMDE, Anerka, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Nintendofan885, Akuckartz, Soda, Ironie, Demian, apaskulin, Dzaky17, Hook696, CptViraj, Bouzinac, Erdinc_Ciftci_WMDE, darthmon_wmde, Eihel, Jtneill, abi_, taavi, MJL, Kent7301, Chambersjay, FriedrickMILBarbarossa, Jd3main, joker88john, Dinadineke, DannyS712, wildly_boy, CucyNoiD, Nandana, Chief_Mike, Klaas_Z4us_V, Matlin, Tumz24, Gaboe420, Urfiner, Jony, lucamauri, Patriccck, CycloneIsaac, Giuliamocci, tabish.shaikh91, Cpaulf30, Lahi, Gq86, Af420, Xinbenlv, Vacio, Ramsey-WMF, SapphieWillie, Inductiveload, dmaza, Bsandipan, Daimona, Xover, Lucas_Werkmeister_WMDE, Gboyers, GoranSMilovanovic, Fz-29, TheDragonFire, Chicocvenancio, JakeTheDeveloper, Mahir256, QZanden, EBjune, cmadeo, Pppery, Viveksr96, Esc3300, merbst, LawExplorer, spatton, RIT_RAJARSHI, Flycatchr, Vali.matei, Samuele2002, Lewizho99, Lemondoge, Maathavan, Wugapodes, elukey, Assassas77, Tshrinivasan, Iniquity, YonaB, _jensen, Jseddon, rosalieper, Jason_Quinn, Agabi10, Bodhisattwa, Mkdw, XanonymusX, Taiwania_Justo, Neuronton, shinjiman, gabriel-wmde, Scott_WUaS, mb, Cirdan, Info-farmer, Samwilson, DStrine, Shangkuanlc, Volker_E, XenoRyet, Izno, SBisson, Wong128hk, Luke081515, freephile, Unapersona, IKhitron, Uzume, abian, MusikAnimal, Zache, Hsarrazin, Wikidata-bugs, Snowolf, Base, aude, SPQRobin, Candalua, AndyRussG, Ebe123, Pcoombe, Dinoguy1000, Amire80, jeblad, jayvdb, Mvolz, RandomDSdevel, Kipod, Shizhao, fbstj, Yurik, Paladox, Tpt, Arrbee, santhosh, KartikMistry, Isarra, Alchimista, Billinghurst, TheDJ, Ladsgroup, Jackmcbarn, Mbch331, jayantanth, Jay8g, ashley, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T332540: Error 1213 from MediaWiki\Storage\NameTableStore::store, Deadlock found when trying to get lock; try restarting transaction INSERT IGNORE INTO `change_tag_def` (ct
kostajh created this task.
kostajh added projects: MediaWiki-extensions-WikibaseClient,
Data-Persistence-Misc, MediaWiki-Change-tagging, Quibble.
TASK DESCRIPTION
seen in a CI build running Selenium jobs
(https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/27049/console),
passed on a recheck. Not sure if it's something that needs further
investigation or an unavoidable edge case of how deferreds/jobs are run in our
CI environment.
01:28:17 mw-dberror.log:Mon Mar 20 0:28:02 UTC 2023 ebfd34de8aa9wikidb
Error 1213 from MediaWiki\Storage\NameTableStore::store, Deadlock found when
trying to get lock; try restarting transaction INSERT IGNORE INTO
`change_tag_def` (ctd_name,ctd_user_defined,ctd_count) VALUES ('mobile web
edit',0,0) localhost:/workspace/db/quibble-mysql-81ubnknv/socket
01:28:17 mw-dberror.log:#0
/workspace/src/includes/libs/rdbms/database/Database.php(1481):
Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string,
string)
01:28:17 mw-dberror.log:#1
/workspace/src/includes/libs/rdbms/database/Database.php(854):
Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string,
boolean)
01:28:17 mw-dberror.log:#2
/workspace/src/includes/libs/rdbms/database/Database.php(1755):
Wikimedia\Rdbms\Database->query(string, string, integer)
01:28:17 mw-dberror.log:#3
/workspace/src/includes/libs/rdbms/database/DBConnRef.php(119):
Wikimedia\Rdbms\Database->insert(string, array, string, array)
01:28:17 mw-dberror.log:#4
/workspace/src/includes/libs/rdbms/database/DBConnRef.php(400):
Wikimedia\Rdbms\DBConnRef->__call(string, array)
01:28:17 mw-dberror.log:#5
/workspace/src/includes/Storage/NameTableStore.php(409):
Wikimedia\Rdbms\DBConnRef->insert(string, array, string, array)
01:28:17 mw-dberror.log:#6
/workspace/src/includes/libs/rdbms/database/Database.php(2610):
MediaWiki\Storage\NameTableStore->MediaWiki\Storage\{closure}(Wikimedia\Rdbms\DatabaseMysqli,
string)
01:28:17 mw-dberror.log:#7
/workspace/src/includes/libs/rdbms/database/DBConnRef.php(119):
Wikimedia\Rdbms\Database->doAtomicSection(string, Closure, string)
01:28:17 mw-dberror.log:#8
/workspace/src/includes/libs/rdbms/database/DBConnRef.php(680):
Wikimedia\Rdbms\DBConnRef->__call(string, array)
01:28:17 mw-dberror.log:#9
/workspace/src/includes/Storage/NameTableStore.php(430):
Wikimedia\Rdbms\DBConnRef->doAtomicSection(string, Closure, string)
01:28:17 mw-dberror.log:#10
/workspace/src/includes/Storage/NameTableStore.php(168):
MediaWiki\Storage\NameTableStore->store(string)
01:28:17 mw-dberror.log:#11
/workspace/src/includes/changetags/ChangeTags.php(472):
MediaWiki\Storage\NameTableStore->acquireId(string)
01:28:17 mw-dberror.log:#12
/workspace/src/includes/changetags/ChangeTags.php(335):
ChangeTags::updateTags(array, array, integer, integer, string, NULL,
RecentChange)
01:28:17 mw-dberror.log:#13
/workspace/src/includes/changes/RecentChange.php(488):
ChangeTags::addTags(array, integer, integer, string, NULL, RecentChange)
01:28:17 mw-dberror.log:#14
/workspace/src/extensions/Wikibase/client/includes/Changes/InjectRCRecordsJob.php(265):
RecentChange->save()
01:28:17 mw-dberror.log:#15
/workspace/src/includes/jobqueue/JobRunner.php(362):
Wikibase\Client\Changes\InjectRCRecordsJob->run()
01:28:17 mw-dberror.log:#16
/workspace/src/includes/jobqueue/JobRunner.php(323):
JobRunner->doExecuteJob(Wikibase\Client\Changes\InjectRCRecordsJob)
01:28:17 mw-dberror.log:#17
/workspace/src/includes/jobqueue/JobRunner.php(227):
JobRunner->executeJob(Wikibase\Client\Changes\InjectRCRecordsJob)
01:28:17 mw-dberror.log:#18 /workspace/src/includes/MediaWiki.php(1197):
JobRunner->run(array)
01:28:17 mw-dberror.log:#19 /workspace/src/includes/MediaWiki.php(647):
MediaWiki->triggerSyncJobs(integer)
01:28:17 mw-dberror.log:#20
/workspace/src/includes/deferred/TransactionRoundDefiningUpdate.php(26):
MediaWiki->{closure}()
01:28:17 mw-dberror.log:#21
/workspace/src/includes/deferred/DeferredUpdates.php(473):
TransactionRoundDefiningUpdate->doUpdate()
01:28:17 mw-dberror.log:#22
/workspace/src/includes/deferred/DeferredUpdates.php(398):
DeferredUpdates::attemptUpdate(TransactionRoundDefiningUpdate,
Wikimedia\Rdbms\LBFactorySimple)
01:28:17 mw-dberror.log:#23
/workspace/src/includes/deferred/DeferredUpdates.php(213):
DeferredUpdates::run(TransactionRoundDefiningUpdate,
Wikimedia\Rdbms\LBFactorySimple, MediaWiki\Logger\LegacyLogger,
BufferingStatsdDataFactory, MediaWiki\JobQueue\JobQueueGroupFactory, string)
01:28:17 mw-dberror.log:#24
/workspace/src/includes/deferred/DeferredUpdatesScope.php(267):
DeferredUpdates::{closure}(TransactionRoundDefiningUpdate, integer)
01:28:17 mw-dberror.log:#25
/workspace/src/includes/deferred/DeferredUpdatesScope.php(196):
DeferredUpdatesScope-&
[Wikidata-bugs] [Maniphest] T329262: Consider making the Wikibase extension directory contain a single extension
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T329262 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T329262: Consider making the Wikibase extension directory contain a single extension
kostajh created this task. kostajh added projects: Wikibase and Wikidata Architecture Overview, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION The Wikibase directory contains two extensions, WikibaseClient and WikibaseRepository, in addition to a bunch of code shared between the two extensions. (WikibaseView is apparently also an extension, but without an extension.json?) This requires things like the `mw-apply-wb-settings` script for CI to work properly (since CI assumes one extension per directory). It also makes tooling changes (like if we wanted to use file based patterns for PHPUnit test directory) harder, because the assumption that there is one extension per directory doesn't hold up with Wikibase. Creating two separate directories and extensions (e.g. extensions/WikibaseClient and extensions/WikibaseRepository) seems hard with the amount of shared code, but maybe it is possible to have the shared code exist as a PHP library that is versioned and pulled in via composer.json for each extension. Alternatively, perhaps there can just be a single "Wikibase" extension, with one extension.json, and config flags would determine if the repo/client functionality is enabled? TASK DETAIL https://phabricator.wikimedia.org/T329262 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, ItamarWMDE, Akuckartz, lucamauri, Gq86, Wikidata-bugs, Lydia_Pintscher ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328601: TypeError: Argument 2 passed to Parser::parse() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.40.0-wmf.21/exten
kostajh added projects: MediaWiki-extensions-WikibaseRepository, Maps (Kartographer). TASK DETAIL https://phabricator.wikimedia.org/T328601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: dancy, Aklapper, mrephabricator, ItamarWMDE, Akuckartz, Alilje, darthmon_wmde, Nabetaro, Rosalie_WMDE, MSantos, lucamauri, Gq86, Looniverse, Sturm, Orienteerix, Ddproxy, JGirault, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Verdy_p, Planemad, Wikidata-bugs, awight, Yurik, TheDJ, Jdforrester-WMF, Jay8g, Ltrlg ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328500: ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions
kostajh edited projects, added MediaWiki-ResourceLoader; removed wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester. Restricted Application added a project: Performance-Team. TASK DETAIL https://phabricator.wikimedia.org/T328500 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Jdlrobson, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Vali.matei, Lewizho99, Maathavan, xSavitar, Neuronton, Nirmos, Dinoguy1000, Jdforrester-WMF, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328500: ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions
kostajh reopened this task as "Open". kostajh added a comment. Leaving this open as a parent task, let's make subtasks for specific extensions. I don't know how to "unmerge" T328522 <https://phabricator.wikimedia.org/T328522> but I've added it as a subtask of this one. TASK DETAIL https://phabricator.wikimedia.org/T328500 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Jdlrobson, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328500: ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions
kostajh lowered the priority of this task from "Unbreak Now!" to "Needs Triage". TASK DETAIL https://phabricator.wikimedia.org/T328500 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Jdlrobson, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328500: ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions
kostajh added a subtask: T328522: ResourcesTest::testUnsatisfiableDependencies: The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.ControllerViewFactory' does not have it. TASK DETAIL https://phabricator.wikimedia.org/T328500 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Jdlrobson, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328500: ResourcesTest::testUnsatisfiableDependencies blocks CI on certain extensions
kostajh closed this task as "Resolved". kostajh claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T328500 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Jdlrobson, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Sjoerddebruin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328522: ResourcesTest::testUnsatisfiableDependencies: The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.Contro
kostajh removed projects: Wikidata, MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T328522 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Aklapper, Jdlrobson, kostajh, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Vali.matei, Lewizho99, Maathavan, xSavitar, Neuronton, Nirmos, Dinoguy1000, Sjoerddebruin, Jdforrester-WMF, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328522: ResourcesTest::testUnsatisfiableDependencies: The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.Contro
kostajh added a project: MediaWiki-extensions-PropertySuggester. TASK DETAIL https://phabricator.wikimedia.org/T328522 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Aklapper, Jdlrobson, kostajh, ItamarWMDE, Akuckartz, lucamauri, Vali.matei, xSavitar, Nirmos, Wikidata-bugs, Dinoguy1000, Sjoerddebruin, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T328522: ResourcesTest::testUnsatisfiableDependencies: The module 'propertySuggester.suggestions' must not have target 'mobile' because its dependency 'wikibase.view.Contro
kostajh created this task.
kostajh triaged this task as "Unbreak Now!" priority.
kostajh added projects: MediaWiki-ResourceLoader,
MediaWiki-extensions-WikibaseClient, ci-test-error (WMF-deployed Build Failure).
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Performance-Team.
TASK DESCRIPTION
09:29:40 There was 1 failure:
09:29:40
09:29:40 1) ResourcesTest::testUnsatisfiableDependencies
09:29:40 * The module 'propertySuggester.suggestions' must not have target
'mobile' because its dependency 'wikibase.view.ControllerViewFactory' does not
have it
09:29:40
09:29:40 Failed asserting that two arrays are equal.
09:29:40 --- Expected
09:29:40 +++ Actual
09:29:40 @@ @@
09:29:40 Array (
09:29:40 +0 => 'propertySuggester.suggestions'
09:29:40 )
09:29:40
09:29:40 /workspace/src/tests/phpunit/structure/ResourcesTest.php:150
09:29:40 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:519
09:29:40 === Logs generated by test case
09:29:40 [objectcache] [debug] MainWANObjectCache using store {class}
{"class":"EmptyBagOStuff"}
09:29:40 [localisation] [debug] LocalisationCache using store LCStoreNull []
09:29:40 ===
09:29:40
09:29:40 FAILURES!
09:29:40 Tests: 27892, Assertions: 93348, Failures: 1, Skipped: 84.
Blocking CI and merges to GrowthExperiments, among other extensions. Caused
by rMW01aec63c217f: ResourceLoader: Default File modules to mobile and desktop
targets
<https://phabricator.wikimedia.org/rMW01aec63c217f80426cb98179897a960cabd2>,
I assume.
TASK DETAIL
https://phabricator.wikimedia.org/T328522
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: kostajh
Cc: Aklapper, Jdlrobson, kostajh, ItamarWMDE, Akuckartz, lucamauri, Vali.matei,
xSavitar, Nirmos, Wikidata-bugs, Dinoguy1000, Jdforrester-WMF
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310255: PHPUnit failure in various extensions: Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'ce
kostajh closed this task as "Resolved". kostajh claimed this task. kostajh added a comment. In T310255#7992532 <https://phabricator.wikimedia.org/T310255#7992532>, @Lucas_Werkmeister_WMDE wrote: > No longer UBN!; I’ll leave @kostajh to decide whether this task should be kept open or closed, since the revert isn’t a permanent solution. This task is no longer relevant. Work to block access to main wiki DB in test scenarios can be tracked in the various vendor/bin/phpunit migration tasks (T90875 <https://phabricator.wikimedia.org/T90875> and subtasks). TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: matmarex, Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, Zabe, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, taavi, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, Mbch331, Jay8g, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T326621: Wikibase\Lexeme\Tests\MediaWiki\Specials\HTMLForm\LemmaLanguageFieldTest::testValidateWithValidLanguageCodeReturnsTrue HTMLFormField::__construct: Constructing an
kostajh closed this task as "Resolved". kostajh claimed this task. kostajh added a comment. Thank you! TASK DETAIL https://phabricator.wikimedia.org/T326621 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Jakob_WMDE, kostajh, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324525: The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' because its dependency 'jquery.ui.languagesuggester' does not have it
kostajh lowered the priority of this task from "Unbreak Now!" to "High". kostajh added a comment. Lowering UBN status, but keeping at high because backports to wmf.13 will be broken until the revert patch is backported to wmf.13, and it would be nice to have input from the authors/reviewers of the patch before backporting it to wmf.13. TASK DETAIL https://phabricator.wikimedia.org/T324525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Physikerwelt, Jdlrobson, Krinkle, kostajh, EBernhardson, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Scott_WUaS, Nirmos, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324525: The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' because its dependency 'jquery.ui.languagesuggester' does not have it
kostajh added a comment. In T324525#8445860 <https://phabricator.wikimedia.org/T324525#8445860>, @kostajh wrote: > In T324525#8445709 <https://phabricator.wikimedia.org/T324525#8445709>, @kostajh wrote: > >> Testing a revert: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864907 > > The revert unbreaks CI, just needs a +2 from someone. It will need a backport to wmf.13 is as well. TASK DETAIL https://phabricator.wikimedia.org/T324525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Physikerwelt, Jdlrobson, Krinkle, kostajh, EBernhardson, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Scott_WUaS, Nirmos, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324525: The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' because its dependency 'jquery.ui.languagesuggester' does not have it
kostajh added a comment. In T324525#8445709 <https://phabricator.wikimedia.org/T324525#8445709>, @kostajh wrote: > Testing a revert: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864907 The revert unbreaks CI, just needs a +2 from someone. TASK DETAIL https://phabricator.wikimedia.org/T324525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Physikerwelt, Jdlrobson, Krinkle, kostajh, EBernhardson, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Scott_WUaS, Nirmos, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324525: The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' because its dependency 'jquery.ui.languagesuggester' does not have it
kostajh added a comment. Testing a revert: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/864907 TASK DETAIL https://phabricator.wikimedia.org/T324525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Jdlrobson, Krinkle, kostajh, EBernhardson, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Scott_WUaS, Nirmos, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324525: The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' because its dependency 'jquery.ui.languagesuggester' does not have it
kostajh added projects: Performance-Team, MediaWiki-ResourceLoader. kostajh added subscribers: Krinkle, Jdlrobson. kostajh added a comment. Fallout from T323542: Forbid new modern code from not targeting mobile <https://phabricator.wikimedia.org/T323542>? TASK DETAIL https://phabricator.wikimedia.org/T324525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Jdlrobson, Krinkle, kostajh, EBernhardson, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Scott_WUaS, Nirmos, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324525: The module 'wikibase.lexeme.lexemeview' must not have target 'mobile' because its dependency 'jquery.ui.languagesuggester' does not have it
kostajh triaged this task as "Unbreak Now!" priority. kostajh added a project: ci-test-error (WMF-deployed Build Failure). kostajh added a comment. Presumably affecting many extensions (I came here via a failed GrowthExperiments build.) TASK DETAIL https://phabricator.wikimedia.org/T324525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, EBernhardson, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, RhinosF1 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321422: Use buildComparison() instead of raw SQL
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T321422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matmarex, kostajh Cc: Dreamy_Jazz, matmarex, Aklapper, Adamm71, Jersione, Hellket777, MPGuy2824, LisafBia6531, IAmChaos, Astuthiodit_1, 786, KSiebert, Biggs657, karapayneWMDE, NRodriguez, Invadibot, Novem_Linguae, MPhamWMF, Asartea, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, CBogen, GeneralNotability, ItamarWMDE, Un1tY, Akuckartz, apaskulin, Dzaky17, Hook696, ST47, HMonroy, WDoranWMF, Kent7301, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Tks4Fish, kostajh, Gaboe420, Jony, lucamauri, Amorymeltzer, Giuliamocci, Force_Radical, Cpaulf30, Lahi, Gq86, Af420, Xinbenlv, dmaza, Bsandipan, GoranSMilovanovic, Nattes, QZanden, EBjune, LawExplorer, Sethakill, Lewizho99, JJMC89, Maathavan, B20180, dg711, _jensen, rosalieper, AGK, xSavitar, XanonymusX, Taiwania_Justo, TheresNoTime, Neuronton, RuyP, JEumerus, Scott_WUaS, Cirdan, Samwilson, SBisson, Nakon, Bsadowski1, mys_721tx, MusikAnimal, Zache, Niharika, Wikidata-bugs, Snowolf, aude, Huji, geraki, jeblad, jayvdb, Ricordisamoa, -jem-, Tacsipacsi, Catrope, Ladsgroup, Jackmcbarn, Mbch331, Jay8g, Glaisher, Krenair ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
kostajh closed this task as "Resolved". kostajh claimed this task. kostajh added a comment. Thanks @Lucas_Werkmeister_WMDE! TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Lucas_Werkmeister_WMDE, kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320952: Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander Wikimedia\Services\RecursiveServ
kostajh added a comment. Restricted Application added a project: User-ItamarWMDE. > Is this happening on all Quibble builds now? AFAICS, yes. Lucas_Werkmeister_WMDE writes: > Lucas_Werkmeister_WMDE added a comment. > > Probably the same as T315489 <https://phabricator.wikimedia.org/T315489>: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> > ContentLanguage -> LanguageFactory, which seems to reappear and vanish again from time to time. (I also had these errors > in early patch sets of this change, where I managed to fix them with this refactoring.) Is this happening on all Quibble > builds now? > > TASK DETAIL > https://phabricator.wikimedia.org/T320952 > > EMAIL PREFERENCES > https://phabricator.wikimedia.org/settings/panel/emailpreferences/ > > STAMPS > actor(@Lucas_Werkmeister_WMDE) application(Maniphest) author(@kostajh) herald(H293) monogram(T320952 <https://phabricator.wikimedia.org/T320952>) object-type(TASK) > phid(PHID-TASK-3v2nx4r24n2sbzpaiqf5) space(S1 <https://phabricator.wikimedia.org/S1>) subscriber(@kostajh) subscriber(@Lucas_Werkmeister_WMDE) subtype(default) > tag(#mediawiki-extensions-wikibaserepository <https://phabricator.wikimedia.org/tag/mediawiki-extensions-wikibaserepository/>) tag(#quibble <https://phabricator.wikimedia.org/tag/quibble/>) tag(#wikidata <https://phabricator.wikimedia.org/tag/wikidata/>) task-priority(90) task-status(open) > task-unassigned() via(web) > > To: Lucas_Werkmeister_WMDE > Cc: Lucas_Werkmeister_WMDE, kostajh, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, > Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, > aude, Jdforrester-WMF, Mbch331, hashar TASK DETAIL https://phabricator.wikimedia.org/T320952 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Lucas_Werkmeister_WMDE, kostajh, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320952: Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander Wikimedia\Services\RecursiveServ
kostajh created this task. kostajh added projects: Quibble, MediaWiki-extensions-WikibaseRepository. TASK DESCRIPTION Seen on Quibble CI builds: 1) Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander 12:30:09 Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! UserOptionsLookup -> UserOptionsManager -> DBLoadBalancer -> DBLoadBalancerFactory -> UserNameUtils -> TitleParser -> _MediaWikiTitleCodec -> GenderCache -> DBLoadBalancer 12:30:09 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:435 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:944 12:30:09 /workspace/src/includes/ServiceWiring.php:676 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:1016 12:30:09 /workspace/src/includes/ServiceWiring.php:2255 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/ServiceWiring.php:1961 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:1845 12:30:09 /workspace/src/includes/ServiceWiring.php:2069 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:1949 12:30:09 /workspace/src/includes/session/SessionBackend.php:765 12:30:09 /workspace/src/includes/session/SessionBackend.php:236 12:30:09 /workspace/src/includes/session/Session.php:75 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:443 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:952 12:30:09 /workspace/src/includes/ServiceWiring.php:540 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:944 12:30:09 /workspace/src/includes/ServiceWiring.php:2087 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:1965 12:30:09 /workspace/src/includes/ServiceWiring.php:2079 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:1957 12:30:09 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/OutputPageBeforeHTMLHookHandlerTest.php:117 12:30:09 /workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Hooks/OutputPageBeforeHTMLHookHandlerTest.php:195 12:30:09 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:516 12:30:09 12:30:09 Caused by 12:30:09 Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! UserOptionsLookup -> UserOptionsManager -> DBLoadBalancer -> DBLoadBalancerFactory -> UserNameUtils -> TitleParser -> _MediaWikiTitleCodec -> GenderCache -> DBLoadBalancer 12:30:09 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:435 12:30:09 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:411 12:30:09 /workspace/src/includes/MediaWikiServices.php:302 12:30:09 /workspace/src/includes/MediaWikiServices.php:944 12:30:09 /workspace/src/includes/ServiceWiring.php:676 12:30:09 /workspace/src/vendor/wikimedia/services/src/Servi
[Wikidata-bugs] [Maniphest] T320952: Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander Wikimedia\Services\RecursiveServ
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T320952 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, ItamarWMDE, Akuckartz, lucamauri, Gq86, Wikidata-bugs, Jdforrester-WMF, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: Login broken for beta cluster and Selenium tests
kostajh lowered the priority of this task from "Unbreak Now!" to "Needs Triage". TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: abi_, Zabe, Mabualruz, Lucas_Werkmeister_WMDE, hashar, Winston_Sung, dom_walden, kostajh, Aklapper, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, taavi, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, xSavitar, Taiwania_Justo, Neuronton, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: Login broken for beta cluster and Selenium tests
kostajh added a parent task: T314194: 1.40.0-wmf.5 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Lucas_Werkmeister_WMDE, hashar, Winston_Sung, dom_walden, kostajh, Aklapper, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, taavi, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, xSavitar, Taiwania_Justo, Neuronton, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: Login broken for beta cluster and Selenium tests
kostajh added a comment. The Selenium job that has failing has ArticlePlaceholder, CentralAuth, FlaggedRevs, PropertySuggster, Renameuser, SyntaxHighlight, WikibaseLexeme, WikibaseLexemeCirrusSearch, WikibaseQualityConstraints, WikimediaBadges, WikimediaEvents cloned, while one that is passing (WikibaseQualityConstraints, with quibble-vendor) does not have those extensions cloned. TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Lucas_Werkmeister_WMDE, hashar, Winston_Sung, dom_walden, kostajh, Aklapper, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, taavi, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: Login broken for beta cluster and Selenium tests
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: hashar, Winston_Sung, dom_walden, kostajh, Aklapper, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, taavi, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: Login broken for beta cluster and Selenium tests
kostajh renamed this task from "All Selenium tests using authentication are broken" to "Login broken for beta cluster and Selenium tests". TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: hashar, Winston_Sung, dom_walden, kostajh, Aklapper, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, taavi, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: All Selenium tests using authentication are broken
kostajh added a project: MediaWiki-Authentication-and-authorization. TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Winston_Sung, dom_walden, kostajh, Aklapper, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, taavi, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T320471: All Selenium tests using authentication are broken
kostajh added a project: MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T320471 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Sgs, caldera, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, lucamauri, Nattes, Iniquity, xSavitar, Taiwania_Justo, SBisson, Wikidata-bugs, geraki, Catrope, zeljkofilipin, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
kostajh edited projects, added Growth-Team; removed Growth-Team (Current Sprint). kostajh added a comment. Not happening anymore, as far as I know, so removing from our current sprint. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331, IdtrA, 94rain ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T266706: element (".wb-tr-tainted-icon") still not existing after 10000ms
kostajh reopened this task as "Open". kostajh edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error. kostajh added a comment. Seen again on September 13: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-selenium-docker/140003/console#console-section-12 for this patch <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/811919>. TASK DETAIL https://phabricator.wikimedia.org/T266706 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, kostajh Cc: kostajh, Addshore, Aklapper, Reedy, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T213426: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle
kostajh removed a project: Growth-Team-Filtering. TASK DETAIL https://phabricator.wikimedia.org/T213426 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Seb35, Ladsgroup, BEANS-X2, Xover, Woolvia, Esanders, Krinkle, Aklapper, gerritbot, Jdforrester-WMF, Volker_E, Schnark, Rivaldid, Galobtter, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, G1964j, 786, Trngsh15, Zekwn, Biggs657, karapayneWMDE, the0001, Invadibot, Lectrician1, Mengs21, Zabe, Selby, Florian_COLLIN, AndreCstr, caldera, Universal_Omega, maantietaja, XeroS_SkalibuR, Juan90264, Alter-paule, EgbeRef, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Vaibhav0199, Akuckartz, Hook696, Tinzawoo533, darthmon_wmde, Kent7301, Onmir, RhinosF1, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Mirahamira, Tumz24, kostajh, Gaboe420, Mh-3110, Yahya, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Markhalsey, GoranSMilovanovic, Jayprakash12345, Nattes, QZanden, EBjune, enigmaeth, rohitt, EnricoCNC, LawExplorer, spatton, Lewizho99, Maathavan, _jensen, Jseddon, rosalieper, Taiwania_Justo, Neuronton, gabriel-wmde, Scott_WUaS, DStrine, Dixtosa, XenoRyet, Izno, Wikidata-bugs, Base, matthiasmullie, aude, AndyRussG, Pcoombe, geraki, Dinoguy1000, Gryllida, jeblad, fbstj, Catrope, Paladox, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T213426: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T213426 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Seb35, Ladsgroup, BEANS-X2, Xover, Woolvia, Esanders, Krinkle, Aklapper, gerritbot, Jdforrester-WMF, Volker_E, Schnark, Rivaldid, Galobtter, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, G1964j, 786, Trngsh15, Zekwn, Biggs657, karapayneWMDE, the0001, Invadibot, Lectrician1, Mengs21, Zabe, Selby, Florian_COLLIN, AndreCstr, caldera, Universal_Omega, maantietaja, XeroS_SkalibuR, Juan90264, Alter-paule, EgbeRef, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Vaibhav0199, Akuckartz, Hook696, Tinzawoo533, darthmon_wmde, Kent7301, Onmir, RhinosF1, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Mirahamira, Tumz24, kostajh, Gaboe420, Mh-3110, Yahya, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Markhalsey, GoranSMilovanovic, Jayprakash12345, Nattes, QZanden, EBjune, enigmaeth, rohitt, EnricoCNC, LawExplorer, spatton, Lewizho99, Maathavan, _jensen, Jseddon, rosalieper, Taiwania_Justo, Neuronton, gabriel-wmde, Scott_WUaS, DStrine, Dixtosa, XenoRyet, Izno, Wikidata-bugs, Base, matthiasmullie, aude, AndyRussG, Pcoombe, geraki, Dinoguy1000, Gryllida, jeblad, fbstj, Catrope, Paladox, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T213426: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T213426 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Seb35, Ladsgroup, BEANS-X2, Xover, Woolvia, Esanders, Krinkle, Aklapper, gerritbot, Jdforrester-WMF, Volker_E, Schnark, Rivaldid, Galobtter, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, G1964j, 786, Trngsh15, Zekwn, Biggs657, karapayneWMDE, the0001, Invadibot, Lectrician1, Mengs21, Zabe, Selby, Florian_COLLIN, AndreCstr, caldera, Universal_Omega, maantietaja, XeroS_SkalibuR, Juan90264, Alter-paule, EgbeRef, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Vaibhav0199, Akuckartz, Hook696, Tinzawoo533, darthmon_wmde, Kent7301, Onmir, RhinosF1, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Mirahamira, Tumz24, kostajh, Gaboe420, Mh-3110, Yahya, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Markhalsey, GoranSMilovanovic, Jayprakash12345, Nattes, QZanden, EBjune, enigmaeth, rohitt, EnricoCNC, LawExplorer, spatton, Lewizho99, Maathavan, _jensen, Jseddon, rosalieper, Taiwania_Justo, Neuronton, gabriel-wmde, Scott_WUaS, DStrine, Dixtosa, XenoRyet, Izno, Wikidata-bugs, Base, matthiasmullie, aude, AndyRussG, Pcoombe, geraki, Dinoguy1000, Gryllida, jeblad, fbstj, Catrope, Paladox, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T243590: Fix WikibaseDataModel CI for php 7.4
kostajh reopened this task as "Open".
kostajh added a comment.
Restricted Application added a project: wdwb-tech.
This seems to be an issue again now that CI is running PHP 7.4. See
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/56135/console
09:46:58 There was 1 failure:
09:46:58
09:46:58 1)
Wikibase\DataModel\Tests\ReferenceListTest::testSerializationStability
09:46:58 Failed asserting that two strings are identical.
09:46:58 --- Expected
09:46:58 +++ Actual
09:46:58 @@ @@
09:46:58
-'a:1:{i:0;O:28:"Wikibase\DataModel\Reference":1:{s:35:"Wikibase\DataModel\Referencesnaks";O:32:"Wikibase\DataModel\Snak\SnakList":2:{s:4:"data";a:1:{i:0;C:43:"Wikibase\DataModel\Snak\PropertyNoValueSnak":2:{P1}}s:5:"index";i:0;}}}'
09:46:58
+'a:1:{i:0;O:28:"Wikibase\DataModel\Reference":1:{s:35:"Wikibase\DataModel\Referencesnaks";C:32:"Wikibase\DataModel\Snak\SnakList":100:{a:2:{s:4:"data";a:1:{i:0;C:43:"Wikibase\DataModel\Snak\PropertyNoValueSnak":2:{P1}}s:5:"index";i:0;'
09:46:58
09:46:58
/workspace/src/extensions/Wikibase/lib/packages/wikibase/data-model/tests/unit/ReferenceListTest.php:545
09:46:58
09:46:58 FAILURES!
09:46:58 Tests: 24800, Assertions: 86154, Failures: 1, Skipped: 97.
TASK DETAIL
https://phabricator.wikimedia.org/T243590
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: toan, kostajh
Cc: kostajh, Pablo-WMDE, WMDE-leszek, Daimona, Jdforrester-WMF, srishakatux,
Reedy, Addshore, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot,
maantietaja, ItamarWMDE, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Wikidata-bugs, aude, Lydia_Pintscher, Nikerabbit, MaxSem, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T316853: ResourcesTest::testUnsatisfiableDependencies: The module 'wikibase.lexeme.lexemeview' must not depend on modules with requiresES6=true
kostajh added a parent task: T316324: ResourceLoader: Modules that are not marked as es6 that import es6 modules should log a JavaScript warning/exception. TASK DETAIL https://phabricator.wikimedia.org/T316853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, xSavitar, Scott_WUaS, Nirmos, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315966: Figure out what to do with phpspec/prophecy
kostajh added a comment. Removing its usage seems like a reasonable way forward, IMHO, based on the low usage across repos <https://codesearch.wmcloud.org/search/?q=prophesize=nope===> and the commentary in https://github.com/sebastianbergmann/phpunit/issues/5033. TASK DETAIL https://phabricator.wikimedia.org/T315966 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Michael, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
kostajh removed kostajh as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, IdtrA, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315892: PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed.
kostajh added a comment. The fastest way might be to pin to phpunit 8.5.28 in core. An alternative would be for WikibaseLexeme and Wikibase to add phpspec/prophecy to require-dev in their composer.json files? TASK DETAIL https://phabricator.wikimedia.org/T315892 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Reedy, TheresNoTime, Michael, kostajh, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
kostajh raised the priority of this task from "High" to "Unbreak Now!". kostajh added a comment. In T315489#8174478 <https://phabricator.wikimedia.org/T315489#8174478>, @WMDE-leszek wrote: > @kostajh shouldn't it even be Unbreak Now? As it essentially blocks your work as I understand it? Yeah, I think that's right. > Thanks for the Wikibase patch, asking WMDE engineers to have a look today if still feasible. Feel free to merge it by your team if we do not get to it quickly enough. We can always revert and redo it, no reason to block your team. Thanks! We might merge it and a more comprehensive fix could come later from one of our teams. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331, RhinosF1 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
kostajh moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board. kostajh claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T315489 WORKBOARD https://phabricator.wikimedia.org/project/board/3450/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Hellket777, LisafBia6531, Astuthiodit_1, 786, Sgs, Biggs657, karapayneWMDE, Invadibot, caldera, IdtrA, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
kostajh triaged this task as "High" priority. kostajh added a comment. Blocking patches for #growthexperiments <https://phabricator.wikimedia.org/tag/growthexperiments/> so upping the priority for our team. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, IdtrA, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, 94rain, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T315489: Wikibase circular dependency CI break: LanguageFactory -> NamespaceInfo -> UserNameUtils -> ContentLanguage -> LanguageFactory
kostajh edited projects, added Growth-Team (Current Sprint); removed Growth-Team. TASK DETAIL https://phabricator.wikimedia.org/T315489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: WMDE-leszek, Urbanecm_WMF, Aklapper, Tgr, Astuthiodit_1, Sgs, karapayneWMDE, Invadibot, caldera, IdtrA, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, 94rain, DannyS712, Nandana, kostajh, lucamauri, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T277464: Multiple Wikibase service wiring tests fail when run as unit tests
kostajh added a parent task: T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php. TASK DETAIL https://phabricator.wikimedia.org/T277464 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Addshore, WMDE-leszek, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T312983: Consider running wikibase-kind-docker tests for core patches
kostajh added a project: Developer Productivity. kostajh added a comment. Example patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/813203 and the Wikibase CI patch that fails https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/813687 TASK DETAIL https://phabricator.wikimedia.org/T312983 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: hashar, kostajh, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz, Totolinototo3, Zanziii, Sadisticturd, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T312983: Consider running wikibase-kind-docker tests for core patches
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T312983 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: hashar, kostajh, Aklapper, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz, Totolinototo3, Zanziii, Sadisticturd, lucamauri, Gq86, Wikidata-bugs ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T312983: Consider running wikibase-kind-docker tests for core patches
kostajh created this task.
kostajh added projects: Continuous-Integration-Config,
MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
In working on changes to PHPUnit bootstrapping, I currently need to make a
patch to core, and then a "DNM" patch for Wikibase that depends-on the core
patch, in order to be certain that the wikibase-{repo/client}-docker jobs don't
fail.
TASK DETAIL
https://phabricator.wikimedia.org/T312983
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: kostajh
Cc: hashar, kostajh, Aklapper, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz,
Totolinototo3, Zanziii, Sadisticturd, lucamauri, Gq86, Wikidata-bugs
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T312849: PHPUnit dataProviders access the main DB, not the cloned database
kostajh created this task.
kostajh added projects: MediaWiki-Core-Tests,
MediaWiki-extensions-WikibaseRepository.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Seen while debugging test failures for
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/813209.
Modify
`extensions/Wikibase/repo/tests/phpunit/includes/Hooks/HtmlPageLinkRendererEndHookHandlerTest.php`
to query user names for your wiki. You'd expect to just see `UTSysop`, but
instead the full list of user names on your local wiki is output: `php
tests/phpunit/phpunit.php
extensions/Wikibase/repo/tests/phpunit/includes/Hooks/HtmlPageLinkRendererEndHookHandlerTest.php
--filter=testExtractForeignIdString`
newInstance() );
$output = $wrapper->extractForeignIdString( $linkTarget );
$this->assertSame( $expectedOutput, $output );
}
public function linkTargetProvider() {
$db = wfGetDB( DB_PRIMARY );
$selectQuery = new SelectQueryBuilder( $db );
$result = $selectQuery
->table( 'user' )
->field( 'user_name' )
->fetchFieldValues();
var_dump( $result );
return [
'NS=MAIN, title=null' => [ Title::makeTitle( NS_MAIN, null ),
null ], // T260853
'NS=SPECIAL, title=null' => [ Title::makeTitle( NS_SPECIAL,
null ), null ],
'NS=SPECIAL, title=EntityPage/Q123' => [
Title::newFromTextThrow( 'Special:EntityPage/Q123' ), 'Q123' ],
// One of the defaults from MediaWiki's
maintenance/interwiki.list (but not Wikidata, as this might be the local test
wiki name)
'NS=MAIN, title=Special:EntityPage/Q123' => [
Title::newFromTextThrow( 'metawikimedia:Special:EntityPage/Q123' ), 'Q123' ],
];
}
Note that with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/813209,
access to the main DB is prevented, and the `interwiki` table is empty, which
is why the test fails.
TASK DETAIL
https://phabricator.wikimedia.org/T312849
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: kostajh
Cc: kostajh, Aklapper, ItamarWMDE, Akuckartz, DannyS712, lucamauri, Gq86,
Wikidata-bugs, Jdforrester-WMF
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T255319: Deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal
kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T255319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mabualruz, kostajh Cc: Nikerabbit, AndyRussG, Esanders, Ladsgroup, Osnard, Pwirth, Aklapper, Krinkle, Ammarpad, Jdlrobson, Rwv37, Fernandobacasegua34, Astuthiodit_1, Nishu02, 786, VPuffetMichel, Suran38, Biggs657, karapayneWMDE, ycrepeau, bwang, cjming, Invadibot, Gaurav24072002, Abhinay76, Lectrician1, H0bby, Florian_COLLIN, Annysah01, R4356th, caldera, Mohammadmalek554, Rohitgeddam, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, ItamarWMDE, Un1tY, SCIdude, Akuckartz, Soda, keithbrianpadilla, Chaytanya, JorisDarlingtonQuarshie, dlo, Hook696, darthmon_wmde, Tombolano, Saimongoltinio, WikimeSteve, wiki-helenatxu, abi_, Kent7301, pdehaye, ppelberg, BryghtShadow, joker88john, Kfield, 94rain, Dinadineke, DannyS712, CucyNoiD, Klein, Nandana, JamesDriscoll, Schtom, Mirahamira, Tks4Fish, marcella, Tumz24, alistair3149, kostajh, Gaboe420, Revansx, Mh-3110, Mmiller0712, OhKayeSierra, Bhaskargoyal24, priyanshu_varshney, Amorymeltzer, Giuliamocci, AbhinavKhare, Nikhil-nk, tabish.shaikh91, 2angelic1, Cpaulf30, AkinkuotuFunmi, takidelfin, Lahi, Himanshuc3, Gq86, Af420, Necroarcano, Bsandipan, Robinma, Andrawaag, GoranSMilovanovic, Fz-29, Kamsuri5, The-Gradient, Jayprakash12345, Nakohdo, Jonathan3, JakeTheDeveloper, Nattes, QZanden, Xephyr826, YULdigitalpreservation, Nicolas_NALLET, EnricoCNC, merbst, LawExplorer, Winter, spatton, EHCliffe, Salgo60, Lewizho99, Maathavan, Wess, Kc5vcx, SteffenFelix, _jensen, Jseddon, rosalieper, xSavitar, Taiwania_Justo, Neuronton, shinjiman, gabriel-wmde, Scott_WUaS, Srdjan, MuhammadShuaib, Samwilson, DStrine, XenoRyet, Izno, MGChecker, Lmorillas, Vedmaka, MisterSynergy, Tmalhotra, Oetterer, SimmeD, Aschroet, Jrf, Husun1297, abian, Wikidata-bugs, Yaron_Koren, Base, aude, Pcoombe, geraki, Jongfeli, SuperHamster, Bawolff, Dinoguy1000, Gryllida, jeblad, Harej, brion, Swainr, Tacsipacsi, fbstj, Prtksxna, Catrope, Lydia_Pintscher, KartikMistry, TheDJ, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310492: Wikibase page link notifications should show entity labels in display language instead of page name (the entity ID)
kostajh moved this task from Inbox to Triaged on the Growth-Team board. kostajh added a comment. Duplicate of T116762: Notifications in Echo on Wikidata should display label as well as Q id <https://phabricator.wikimedia.org/T116762>? TASK DETAIL https://phabricator.wikimedia.org/T310492 WORKBOARD https://phabricator.wikimedia.org/project/board/1114/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Lectrician1, Astuthiodit_1, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, _jensen, rosalieper, xSavitar, Taiwania_Justo, Scott_WUaS, SBisson, Wikidata-bugs, aude, geraki, Catrope, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure
kostajh added a comment.
In T310255#7991842 <https://phabricator.wikimedia.org/T310255#7991842>,
@kostajh wrote:
> In T310255#7991676 <https://phabricator.wikimedia.org/T310255#7991676>,
@Lucas_Werkmeister_WMDE wrote:
>
>> Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test
already, both by location (`tests/phpunit/structure/`) and type (`extends
MediaWikiIntegrationTestCase`).
>>
>> But I guess the data providers are evaluated before the
`onUnitTestsAfterDatabaseSetup()` hook runs
>>
>> I’m actually not sure how this would’ve worked before.
>
> Something I observed before the vendor/bin/phpunit switch is that data
providers with exceptions would silently fail, and thus the test wouldn't run
at all. But that doesn't seem to be the case here.
>
> In T310255#7991644 <https://phabricator.wikimedia.org/T310255#7991644>,
@Lucas_Werkmeister_WMDE wrote:
>
>>> I think we’re now running anything that claims to be a unit test against
the real database of the wiki
>>
>> Confirmed:
>>
>> name=tests/phpunit/unit/includes/LucasTest.php
>> >
>> class LucasTest extends \PHPUnit\Framework\TestCase {
>>
>>public function testDatabaseAccess(): void {
>>var_dump( wfGetDB( DB_PRIMARY )->selectRow(
>>'recentchanges',
>>[ 'rc_title', 'rc_timestamp' ],
>>'',
>>__METHOD__,
>>[
>>'LIMIT' => 1,
>>'ORDER BY' => 'rc_timestamp DESC',
>>]
>>) );
>>}
>>
>> }
>>
>>
>>
>> $ vendor/bin/phpunit tests/phpunit/unit/includes/LucasTest.php
>> Using PHP 8.1.2
>> PHPUnit 8.5.26 #StandWithUkraine
>>
>> LucasTest
>>☢ testDatabaseAccess
>> /var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:12:
>> class stdClass#876 (2) {
>> public $rc_title =>
>> string(21) "Page_with_1000_commas"
>> public $rc_timestamp =>
>> string(14) "20220604150204"
>> }
>>
>> “Page with 1000 commas” is indeed the latest recentchanges entry on my
local wiki, from 2022-06-04. This test is accessing the real wiki database. In
my opinion, **this should never happen** – integration tests should have the
test DB, and for unit tests, database access should fail.
>
> Unit (as opposed to integration) tests need to run with a separate
bootstrap file. Can you test with `vendor/bin/phunit --bootstrap
tests/phpunit/bootstrap.php tests/phpunit/unit/includes/LucasTest.php` ? That
is what `composer phpunit:unit` is using.
@Lucas_Werkmeister_WMDE there's another test to fix as well, see
https://integration.wikimedia.org/ci/job/wikibase-client-docker/28093/console:
13:03:46 INFO:quibble.commands:php tests/phpunit/phpunit.php --verbose
--log-junit "$LOG_DIR/junit-wikibase-client.xml" --group Wikibase,WikibaseClient
13:03:46 Using PHP 7.3.33-1+0~2029.91+debian10~1.gbp618351
13:03:46 PHP Deprecated: tests/phpunit/phpunit.php is deprecated and will
be removed. Please use `composer phpunit` or `vendor/bin/phpunit` [Called from
unknown in /workspace/src/tests/phpunit/phpunit.php at line 75] in
/workspace/src/includes/debug/MWDebug.php on line 381
13:03:46 Deprecated: tests/phpunit/phpunit.php is deprecated and will be
removed. Please use `composer phpunit` or `vendor/bin/phpunit` [Called from
unknown in /workspace/src/tests/phpunit/phpunit.php at line 75] in
/workspace/src/includes/debug/MWDebug.php on line 381
13:03:48 [e70351983cbb3759ca54c6bb] [no req] Exception: entitySources
must be configured for non-repo client wikis
13:03:48 Backtrace:
13:03:48 from
/workspace/src/extensions/Wikibase/client/config/WikibaseClient.default.php(211)
13:03:48 #0
/workspace/src/extensions/Wikibase/lib/includes/SettingsArray.php(68):
Wikibase\Lib\WikibaseSettings::{closure}(Wikibase\Lib\SettingsArray)
13:03:48 #1
/workspace/src/extensions/Wikibase/client/WikibaseClient.ServiceWiring.php(433):
Wikibase\Lib\SettingsArray->getSetting(string)
13:03:48 #2
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(447):
Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
13:03:48 #3
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(416):
Wikimedia\Services\ServiceContainer->createService(string)
13:03:48 #4 /workspace/src/includes/MediaWikiServices.php(295):
Wikimedia\Services\ServiceContainer->getService(st
[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure
kostajh added a comment. Let's see if https://gerrit.wikimedia.org/r/c/mediawiki/core/+/804319 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/804283 work, otherwise we should revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/741970 (cc @Krinkle). TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, Mbch331, Jay8g, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure
kostajh added a comment. In T310255#7991664 <https://phabricator.wikimedia.org/T310255#7991664>, @Lucas_Werkmeister_WMDE wrote: > In T310255#7991620 <https://phabricator.wikimedia.org/T310255#7991620>, @gerritbot wrote: > >> Change 804283 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)): >> >> [mediawiki/extensions/Wikibase@master] Change API tests from unit tests to integration tests >> >> https://gerrit.wikimedia.org/r/804283 > > Ugh, this doesn’t work yet because there’s one more warning (and those also make gate-and-submit fail): > > PHPUnit\Framework\WarningTestCase >⚠ Warning > │ > │ The data provider specified for ApiStructureTest::testParameters is invalid. > │ Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'centralauth' (localhost:/workspace/db/quibble-mysql-wc4x6073/socket) > │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1465 > │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:958 > │ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:931 > │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:65 > │ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:270 > │ /workspace/src/extensions/CentralAuth/includes/GlobalGroup/GlobalGroupLookup.php:56 > │ /workspace/src/extensions/CentralAuth/includes/Api/ApiQueryGlobalAllUsers.php:273 > │ /workspace/src/includes/api/ApiBase.php:1782 > │ /workspace/src/tests/phpunit/structure/ApiStructureTest.php:175 > │ phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97 > > This is a unit test in core… should it also be an integration test? It tests that the parameter definitions of API modules are valid, and in CentralAuth that requires accessing the database so that the defined groups can be used for the `group` and `excludegroup` params. (Presumably, other APIs do something similar for `tags` parameters, that just doesn’t produce an error because the `change_tag_def` table would exist in the real wiki.) If anyone is able to reproduce this error locally, please let me know. So far I haven't been able to, with the same set of extensions as CI. TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, Mbch331, Jay8g, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure
kostajh added a comment.
In T310255#7991676 <https://phabricator.wikimedia.org/T310255#7991676>,
@Lucas_Werkmeister_WMDE wrote:
> Wait, no. `ApiStructureTest` isn’t a unit test, it’s an integration test
already, both by location (`tests/phpunit/structure/`) and type (`extends
MediaWikiIntegrationTestCase`).
>
> But I guess the data providers are evaluated before the
`onUnitTestsAfterDatabaseSetup()` hook runs
>
> I’m actually not sure how this would’ve worked before.
Something I observed before the vendor/bin/phpunit switch is that data
providers with exceptions would silently fail, and thus the test wouldn't run
at all. Is it possible that ApiStructureTest did not run in CI prior to T90875
<https://phabricator.wikimedia.org/T90875>?
In T310255#7991644 <https://phabricator.wikimedia.org/T310255#7991644>,
@Lucas_Werkmeister_WMDE wrote:
>> I think we’re now running anything that claims to be a unit test against
the real database of the wiki
>
> Confirmed:
>
> name=tests/phpunit/unit/includes/LucasTest.php
>
> class LucasTest extends \PHPUnit\Framework\TestCase {
>
> public function testDatabaseAccess(): void {
> var_dump( wfGetDB( DB_PRIMARY )->selectRow(
> 'recentchanges',
> [ 'rc_title', 'rc_timestamp' ],
> '',
> __METHOD__,
> [
> 'LIMIT' => 1,
> 'ORDER BY' => 'rc_timestamp DESC',
> ]
> ) );
> }
>
> }
>
>
>
> $ vendor/bin/phpunit tests/phpunit/unit/includes/LucasTest.php
> Using PHP 8.1.2
> PHPUnit 8.5.26 #StandWithUkraine
>
> LucasTest
>☢ testDatabaseAccess
> /var/www/html/wiki1/tests/phpunit/unit/includes/LucasTest.php:12:
> class stdClass#876 (2) {
> public $rc_title =>
> string(21) "Page_with_1000_commas"
> public $rc_timestamp =>
> string(14) "20220604150204"
> }
>
> “Page with 1000 commas” is indeed the latest recentchanges entry on my
local wiki, from 2022-06-04. This test is accessing the real wiki database. In
my opinion, **this should never happen** – integration tests should have the
test DB, and for unit tests, database access should fail.
Unit (as opposed to integration) tests need to run with a separate bootstrap
file. Can you test with `vendor/bin/phunit --bootstrap
tests/phpunit/bootstrap.php tests/phpunit/unit/includes/LucasTest.php` ? That
is what `composer phpunit:unit` is using.
TASK DETAIL
https://phabricator.wikimedia.org/T310255
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: kostajh
Cc: Nikerabbit, ngkountas, Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh,
Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786,
Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja,
Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696,
CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD,
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420,
Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99,
Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno,
Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc,
Jdforrester-WMF, Mbch331, Jay8g, hashar
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure
kostajh added a comment. In T310255#7991592 <https://phabricator.wikimedia.org/T310255#7991592>, @Lucas_Werkmeister_WMDE wrote: > Okay, CentralAuth sets up its database in `UnitTestsHookHandler::onUnitTestsAfterDatabaseSetup()`, but that hook is only run by `MediaWikiIntegrationTestCase::setupTestDB()`. `ApiFormatReferenceTest` and `QuerySearchEntitiesTest` are nominally unit tests, not integration tests, so the database doesn’t get set up, but then CentralAuth still runs as if it’s in an integration test. > > I think the correct solution here is to declare those tests as integration tests. +1, that makes sense to me. As for the general problem about separate unit/integration runs, `composer phpunit:unit` runs which uses a fairly restrictive bootstrap file. Any attempts to access the database there or MediaWiki services would fail, for example. That command looks for tests that are in the `tests/phpunit/unit` subdirectory. So, we need to update Quibble's PHPUnit commands to then ensure that `tests/phpunit/unit` is excluded from integration test runs. We could do that by applying `@group Unit` to each unit test class and then using `--exclude Unit` in Quibble. That's a lot of work, though. We could also have ExtensionTestSuite manually exclude any tests that are in `tests/phpunit/unit` subdirectory, but that wouldn't handle the test run that happens for core. Maybe it is most straightforward (but also another hack) to just remove the `tests/phpunit/unit` directory from each project after `composer phpunit:unit` runs. TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, Zabe, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, CptViraj, Majavah, Kent7301, joker88john, DannyS712, wildly_boy, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, Wong128hk, thcipriani, Wikidata-bugs, Snowolf, aude, fredw, Pkra, scfc, Jdforrester-WMF, Mbch331, Jay8g, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310255: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure
kostajh renamed this task from "Math CI tests fail" to "Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure". kostajh updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt, Akuckartz, DannyS712, lucamauri, Maosef, Debenben, Izno, thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310255: Math CI tests fail
kostajh added a project: MediaWiki-extensions-WikibaseClient. TASK DETAIL https://phabricator.wikimedia.org/T310255 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Jakob_WMDE, Lucas_Werkmeister_WMDE, kostajh, Krinkle, Aklapper, Physikerwelt, Akuckartz, DannyS712, lucamauri, Maosef, Debenben, Izno, thcipriani, Wikidata-bugs, fredw, Pkra, scfc, Jdforrester-WMF, Jay8g, hashar ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310252: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure
kostajh closed this task as a duplicate of T310255: Math CI tests fail. TASK DETAIL https://phabricator.wikimedia.org/T310252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Akuckartz, DannyS712, lucamauri, Wikidata-bugs, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T310252: Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest#testInvalidReferenceJson failure
kostajh created this task. kostajh added projects: ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Seen on GrowthExperiments builds, e.g. https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/156996/console Wikibase\Client\Tests\Unit\Api\ApiFormatReferenceTest 11:30:30 ✘ testInvalidReferenceJson 11:30:30│ 11:30:30│ Failed asserting that exception of type "Wikimedia\Rdbms\DBConnectionError" matches expected exception "ApiUsageException". Message was: "Cannot access the database: Access denied for user 'wikiuser'@'localhost' to database 'centralauth' (localhost:/workspace/db/quibble-mysql-0qcjx7do/socket)" at 11:30:30│ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:1465 11:30:30│ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:958 11:30:30│ /workspace/src/includes/libs/rdbms/loadbalancer/LoadBalancer.php:931 11:30:30│ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:65 11:30:30│ /workspace/src/includes/libs/rdbms/database/DBConnRef.php:649 11:30:30│ /workspace/src/includes/libs/rdbms/database/Database.php:4281 11:30:30│ /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:640 11:30:30│ /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1692 11:30:30│ /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1520 11:30:30│ /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:660 11:30:30│ /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:465 11:30:30│ /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:714 11:30:30│ /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:807 11:30:30│ /workspace/src/extensions/CentralAuth/includes/CentralAuthHooks.php:568 11:30:30│ /workspace/src/includes/HookContainer/HookContainer.php:160 11:30:30│ /workspace/src/includes/HookContainer/HookRunner.php:1942 11:30:30│ /workspace/src/includes/block/BlockManager.php:179 11:30:30│ /workspace/src/includes/user/User.php:1436 11:30:30│ /workspace/src/includes/user/User.php:1752 11:30:30│ /workspace/src/includes/api/ApiBase.php:1285 11:30:30│ /workspace/src/includes/api/ApiBase.php:1528 11:30:30│ /workspace/src/extensions/Wikibase/client/includes/Api/ApiFormatReference.php:56 11:30:30│ /workspace/src/extensions/Wikibase/client/tests/phpunit/unit/includes/Api/ApiFormatReferenceTest.php:141 11:30:30│ phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97 11:30:30│ . 11:30:30│ 11:30:30│ phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97 TASK DETAIL https://phabricator.wikimedia.org/T310252 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Akuckartz, DannyS712, lucamauri, Wikidata-bugs, Jdforrester-WMF ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move
kostajh removed a project: Growth-Team. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, caldera, NavinRizwi, Nattes, Taiwania_Justo, geraki ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T308443: Phan broken due to ResourceLoader namespace move
kostajh removed a project: GrowthExperiments. TASK DETAIL https://phabricator.wikimedia.org/T308443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Daimona, Ladsgroup, Reedy, ItamarWMDE, Michael, RhinosF1, Krinkle, tstarling, kostajh, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, caldera, maantietaja, NavinRizwi, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Nattes, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, aude, geraki, Jdforrester-WMF, Mbch331, Sgs, Iniquity ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T308210: CI Error: count(): Parameter must be an array or an object that implements Countable
kostajh edited projects, added ci-test-error (WMF-deployed Build Failure), GrowthExperiments; removed ci-test-error. kostajh triaged this task as "Unbreak Now!" priority. kostajh added a comment. Restricted Application added a project: Growth-Team. Blocking merges to #GrowthExperiments <https://phabricator.wikimedia.org/tag/growthexperiments/> (and presumably lots of other repos) so marking as unbreak now. TASK DETAIL https://phabricator.wikimedia.org/T308210 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: kostajh, Aklapper, Jakob_WMDE, Sgs, caldera, NavinRizwi, Eihel, DannyS712, Lucas_Werkmeister_WMDE, Nattes, Esc3300, Iniquity, Agabi10, Taiwania_Justo, abian, Wikidata-bugs, geraki, Jdforrester-WMF, RhinosF1 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304147: jenkis CI wikibase-repo-docker failing with new quibble version
kostajh added a comment. @hashar are there any other jobs to update? Is every Quibble job now using supervisord entrypoint? TASK DETAIL https://phabricator.wikimedia.org/T304147 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Lens0021, Lucas_Werkmeister_WMDE, kostajh, Silvan_WMDE, WMDE-leszek, hashar, toan, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz, Totolinototo3, Zanziii, Sadisticturd, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array
kostajh added a comment.
Seen again in
https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/94745/console
09:38:08 mw-error.log:2022-04-06 07:28:40 ba9c06094630 wikidb:
[836ae96dbb37c0bf76790a53] /index.php?title=Special:Badtitle/JavaScriptTest
ParseError: syntax error, unexpected end of file, expecting ']'
09:38:08 mw-error.log:#0
/workspace/src/includes/cache/localisation/LocalisationCache.php(1044):
LCStoreStaticArray->startWrite(string)
09:38:08 mw-error.log:#1
/workspace/src/includes/cache/localisation/LocalisationCache.php(496):
LocalisationCache->recache(string)
09:38:08 mw-error.log:#2
/workspace/src/includes/cache/localisation/LocalisationCache.php(370):
LocalisationCache->initLanguage(string)
09:38:08 mw-error.log:#3
/workspace/src/includes/cache/localisation/LocalisationCache.php(311):
LocalisationCache->loadItem(string, string)
09:38:08 mw-error.log:#4
/workspace/src/includes/language/LanguageFallback.php(106):
LocalisationCache->getItem(string, string)
09:38:08 mw-error.log:#5
/workspace/src/includes/language/LanguageFactory.php(167):
MediaWiki\Languages\LanguageFallback->getAll(string)
09:38:08 mw-error.log:#6
/workspace/src/includes/language/LanguageFactory.php(126):
MediaWiki\Languages\LanguageFactory->newFromCode(string)
09:38:08 mw-error.log:#7 /workspace/src/includes/libs/MapCacheLRU.php(274):
MediaWiki\Languages\LanguageFactory->MediaWiki\Languages\{closure}()
09:38:08 mw-error.log:#8
/workspace/src/includes/language/LanguageFactory.php(127):
MapCacheLRU->getWithSetCallback(string, Closure)
09:38:08 mw-error.log:#9
/workspace/src/includes/language/LanguageFactory.php(208):
MediaWiki\Languages\LanguageFactory->getLanguage(string)
09:38:08 mw-error.log:#10
/workspace/src/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php(140):
MediaWiki\Languages\LanguageFactory->getParentLanguage(string)
09:38:08 mw-error.log:#11
/workspace/src/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php(180):
Wikibase\Lib\LanguageFallbackChainFactory->addLanguageAndVariantsToChain(LanguageEn,
array, array)
09:38:08 mw-error.log:#12
/workspace/src/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php(211):
Wikibase\Lib\LanguageFallbackChainFactory->addLanguageAndVariantsAndFallbacksToChain(LanguageEn,
array, array)
09:38:08 mw-error.log:#13
/workspace/src/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php(78):
Wikibase\Lib\LanguageFallbackChainFactory->buildFromLanguage(LanguageEn)
09:38:08 mw-error.log:#14
/workspace/src/extensions/Wikibase/lib/includes/Store/LanguageFallbackLabelDescriptionLookupFactory.php(70):
Wikibase\Lib\LanguageFallbackChainFactory->newFromLanguage(LanguageEn)
09:38:08 mw-error.log:#15
/workspace/src/extensions/Wikibase/client/WikibaseClient.ServiceWiring.php(845):
Wikibase\Lib\Store\LanguageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup(LanguageEn)
09:38:08 mw-error.log:#16
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(447):
Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
09:38:08 mw-error.log:#17
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(416):
Wikimedia\Services\ServiceContainer->createService(string)
09:38:08 mw-error.log:#18
/workspace/src/includes/MediaWikiServices.php(294):
Wikimedia\Services\ServiceContainer->getService(string)
09:38:08 mw-error.log:#19
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(424):
MediaWiki\MediaWikiServices->getService(string)
09:38:08 mw-error.log:#20
/workspace/src/extensions/Wikibase/client/includes/WikibaseClient.php(326):
Wikimedia\Services\ServiceContainer->get(string)
09:38:08 mw-error.log:#21
/workspace/src/extensions/Wikibase/client/WikibaseClient.ServiceWiring.php(588):
Wikibase\Client\WikibaseClient::getSidebarLinkBadgeDisplay(MediaWiki\MediaWikiServices)
09:38:08 mw-error.log:#22
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(447):
Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
09:38:08 mw-error.log:#23
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(416):
Wikimedia\Services\ServiceContainer->createService(string)
09:38:08 mw-error.log:#24
/workspace/src/includes/MediaWikiServices.php(294):
Wikimedia\Services\ServiceContainer->getService(string)
09:38:08 mw-error.log:#25
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(424):
MediaWiki\MediaWikiServices->getService(string)
09:38:08 mw-error.log:#26
/workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.php(211):
Wikimedia\Services\ServiceContainer->get(string)
09:38:08 mw-error.log:#27
/workspace/src/vendor/wikimedia/object-factory/src/ObjectFactory.ph
[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array
kostajh added a comment. In T304515#7815997 <https://phabricator.wikimedia.org/T304515#7815997>, @Krinkle wrote: > - I explained at T304515#7804508 <https://phabricator.wikimedia.org/T304515#7804508> that this is strange given we don't modify files. This might mean we just need to increase the size, or it might mean php-opcache is worse than we thought and can cause this race even during normal compiling of new files to opcache. If it's opcache related, then the immediate cause would be the switch from php-webserver to php-fpm with Apache. T285649 <https://phabricator.wikimedia.org/T285649> GrowthExperiments is using a hack to get Parsoid working with VisualEditor in CI; we modify LocalSettings.php to require_once the `GrowthExperiments.LocalSettings.php` file, see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GrowthExperiments/+/refs/heads/master/tests/selenium/wdio.conf.js#45. And then we restart php-fpm. I don't know if that is related to this bug, but just wanted to note it here in case it is. TASK DETAIL https://phabricator.wikimedia.org/T304515 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Esanders, toan, Michael, Lucas_Werkmeister_WMDE, matmarex, RhinosF1, hashar, Krinkle, kostajh, Aklapper, Astuthiodit_1, Trngsh15, VPuffetMichel, karapayneWMDE, ycrepeau, Invadibot, Mengs21, Mohammadmalek554, maantietaja, EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, keithbrianpadilla, Tinzawoo533, Saimongoltinio, WikimeSteve, ppelberg, Onmir, DannyS712, Nandana, marcella, Revansx, lucamauri, Mh-3110, Yahya, OhKayeSierra, Amorymeltzer, takidelfin, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, merbst, LawExplorer, Wess, _jensen, rosalieper, Scott_WUaS, Srdjan, Dixtosa, Jrf, Husun1297, Wikidata-bugs, aude, Dinoguy1000, Swainr, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304147: jenkis CI wikibase-repo-docker failing with new quibble version
kostajh added a parent task: T300340: Use Memcached with Quibble. TASK DETAIL https://phabricator.wikimedia.org/T304147 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: Lucas_Werkmeister_WMDE, kostajh, Silvan_WMDE, WMDE-leszek, hashar, toan, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Peteosx1x, ItamarWMDE, Mgagat, Akuckartz, Totolinototo3, Zanziii, Sadisticturd, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array
kostajh lowered the priority of this task from "Unbreak Now!" to "Needs Triage". kostajh added a comment. Is it possibly an instance of T245183: PHP7 corruption reports in 2020-2022 (Call on wrong object, etc.) <https://phabricator.wikimedia.org/T245183>? Resetting the priority, as merges are going through again now. TASK DETAIL https://phabricator.wikimedia.org/T304515 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: toan, Michael, Lucas_Werkmeister_WMDE, matmarex, RhinosF1, hashar, Krinkle, kostajh, Aklapper, Astuthiodit_1, Trngsh15, karapayneWMDE, Invadibot, Mengs21, maantietaja, EgbeRef, ItamarWMDE, Vaibhav0199, Akuckartz, Tinzawoo533, Onmir, DannyS712, Nandana, lucamauri, Mh-3110, Yahya, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, _jensen, rosalieper, Scott_WUaS, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array
kostajh removed projects: GrowthExperiments, Growth-Team. kostajh added a comment. In T304515#7801441 <https://phabricator.wikimedia.org/T304515#7801441>, @matmarex wrote: > The issue doesn't seem related to GrowthExperiments, I've seen the same failure for mediawiki/core changes. OK, untagging Growth then. TASK DETAIL https://phabricator.wikimedia.org/T304515 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh Cc: matmarex, RhinosF1, hashar, Krinkle, kostajh, Aklapper, Astuthiodit_1, Trngsh15, karapayneWMDE, Invadibot, Mengs21, maantietaja, EgbeRef, Vaibhav0199, Akuckartz, Tinzawoo533, Onmir, DannyS712, Nandana, lucamauri, Mh-3110, Yahya, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, enigmaeth, rohitt, LawExplorer, _jensen, rosalieper, Scott_WUaS, Dixtosa, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Sgs, caldera, NavinRizwi, Nattes, Iniquity, Taiwania_Justo, geraki ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304515: PHP Warning: Cannot use a scalar value as an array
kostajh added a comment.
In T304515#7801115 <https://phabricator.wikimedia.org/T304515#7801115>,
@kostajh wrote:
> Thanks for that context. I can't find it now, but there was another stack
trace with a different error, where it looks like the PHP file for the
localisation cache was corrupted; it was missing a closing `'` somewhere
perhaps. I'll see if I can dig it up.
Found it:
https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/93336/console
00:13:23.534 mw-error.log:2022-03-23 14:33:16 8b3a3186d2ea wikidb:
[da4a66e39ff387f350450fda] /index.php?title=Special:Badtitle/JavaScriptTest
ParseError: syntax error, unexpected ''apihel' (T_ENCAPSED_AND_WHITESPACE)
00:13:23.535 mw-error.log:#0
/workspace/src/includes/cache/localisation/LocalisationCache.php(448):
LCStoreStaticArray->get(string, string)
00:13:23.535 mw-error.log:#1
/workspace/src/includes/cache/localisation/LocalisationCache.php(494):
LocalisationCache->isExpired(string)
00:13:23.535 mw-error.log:#2
/workspace/src/includes/cache/localisation/LocalisationCache.php(370):
LocalisationCache->initLanguage(string)
00:13:23.535 mw-error.log:#3
/workspace/src/includes/cache/localisation/LocalisationCache.php(311):
LocalisationCache->loadItem(string, string)
00:13:23.535 mw-error.log:#4
/workspace/src/includes/language/LanguageFallback.php(106):
LocalisationCache->getItem(string, string)
00:13:23.535 mw-error.log:#5
/workspace/src/includes/language/LanguageFactory.php(167):
MediaWiki\Languages\LanguageFallback->getAll(string)
00:13:23.535 mw-error.log:#6
/workspace/src/includes/language/LanguageFactory.php(126):
MediaWiki\Languages\LanguageFactory->newFromCode(string)
00:13:23.535 mw-error.log:#7
/workspace/src/includes/libs/MapCacheLRU.php(274):
MediaWiki\Languages\LanguageFactory->MediaWiki\Languages\{closure}()
00:13:23.535 mw-error.log:#8
/workspace/src/includes/language/LanguageFactory.php(127):
MapCacheLRU->getWithSetCallback(string, Closure)
00:13:23.535 mw-error.log:#9
/workspace/src/includes/language/LanguageFactory.php(208):
MediaWiki\Languages\LanguageFactory->getLanguage(string)
00:13:23.535 mw-error.log:#10
/workspace/src/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php(140):
MediaWiki\Languages\LanguageFactory->getParentLanguage(string)
00:13:23.535 mw-error.log:#11
/workspace/src/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php(180):
Wikibase\Lib\LanguageFallbackChainFactory->addLanguageAndVariantsToChain(LanguageEn,
array, array)
00:13:23.535 mw-error.log:#12
/workspace/src/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php(211):
Wikibase\Lib\LanguageFallbackChainFactory->addLanguageAndVariantsAndFallbacksToChain(LanguageEn,
array, array)
00:13:23.535 mw-error.log:#13
/workspace/src/extensions/Wikibase/lib/includes/LanguageFallbackChainFactory.php(78):
Wikibase\Lib\LanguageFallbackChainFactory->buildFromLanguage(LanguageEn)
00:13:23.535 mw-error.log:#14
/workspace/src/extensions/Wikibase/lib/includes/Store/LanguageFallbackLabelDescriptionLookupFactory.php(70):
Wikibase\Lib\LanguageFallbackChainFactory->newFromLanguage(LanguageEn)
00:13:23.535 mw-error.log:#15
/workspace/src/extensions/Wikibase/client/WikibaseClient.ServiceWiring.php(845):
Wikibase\Lib\Store\LanguageFallbackLabelDescriptionLookupFactory->newLabelDescriptionLookup(LanguageEn)
00:13:23.535 mw-error.log:#16
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(447):
Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
00:13:23.535 mw-error.log:#17
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(416):
Wikimedia\Services\ServiceContainer->createService(string)
00:13:23.535 mw-error.log:#18
/workspace/src/includes/MediaWikiServices.php(294):
Wikimedia\Services\ServiceContainer->getService(string)
00:13:23.535 mw-error.log:#19
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(424):
MediaWiki\MediaWikiServices->getService(string)
00:13:23.535 mw-error.log:#20
/workspace/src/extensions/Wikibase/client/includes/WikibaseClient.php(326):
Wikimedia\Services\ServiceContainer->get(string)
00:13:23.535 mw-error.log:#21
/workspace/src/extensions/Wikibase/client/WikibaseClient.ServiceWiring.php(588):
Wikibase\Client\WikibaseClient::getSidebarLinkBadgeDisplay(MediaWiki\MediaWikiServices)
00:13:23.535 mw-error.log:#22
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(447):
Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
00:13:23.535 mw-error.log:#23
/workspace/src/vendor/wikimedia/services/src/ServiceContainer.php(416):
Wikimedia\Services\ServiceContainer->createService(string)
00:13:23.535 mw-error.log:#24
/workspace/src/includes/MediaWikiService
