[Wikidata-bugs] [Maniphest] T266861: Wikibase browser tests are flaky

2020-10-30 Thread toan
toan added a comment. might be worth mentioning this here as well -> https://phabricator.wikimedia.org/T265596 TASK DETAIL https://phabricator.wikimedia.org/T266861 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, toan Cc: toan, Aklap

[Wikidata-bugs] [Maniphest] T260915: Move DataValues away from “withered” PHPUnit 4

2020-10-28 Thread toan
toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T260915 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, toan Cc: ItamarWMDE, Daimona, MaxSem, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez

[Wikidata-bugs] [Maniphest] T260915: Move DataValues away from “withered” PHPUnit 4

2020-10-28 Thread toan
toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T260915 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, toan Cc: ItamarWMDE, Daimona, MaxSem, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez

[Wikidata-bugs] [Maniphest] T265897: Create implicit use of description in content language

2020-10-28 Thread toan
toan removed Lucas_Werkmeister_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T265897 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Lydia_Pintscher, ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T265897: Create implicit use of description in content language

2020-10-28 Thread toan
toan added a comment. Moving this back to TODO as we should now enable and test it. TASK DETAIL https://phabricator.wikimedia.org/T265897 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, toan Cc: toan, Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T265897: Create implicit use of description in content language

2020-10-28 Thread toan
toan added a comment. I tried this out locally and it seems to do what we want so I've +2ed both patches! Should we move this back to "todo" to enable the setting? TASK DETAIL https://phabricator.wikimedia.org/T265897 EMAIL PREFERENCES https://phabricator.wikimedia.org/sett

[Wikidata-bugs] [Maniphest] T266144: Use a caching service in newLanguageIndependentLuaBindings()

2020-10-23 Thread toan
toan added subscribers: Addshore, hoo. toan added a comment. After talking to @hoo about this at the daily we thought it might be a good idea to hold this off until monday and bring @Addshore into the discussion to find the preferred way forward on how we are to solve the problems identified

[Wikidata-bugs] [Maniphest] T266141: Check that getting labels with and without language fallbacks doesn’t share the cache inappropriately

2020-10-23 Thread toan
toan added a comment. I set this up locally as such updating the independent lua bindings to use CachingPrefetchingTermLookup supported by the shared cache. simple module allowing to pass the language to getLabelByLang and one using the default language local p = {} --p stands

[Wikidata-bugs] [Maniphest] T266144: Use a caching service in newLanguageIndependentLuaBindings()

2020-10-23 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T266144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T266141: Check that getting labels with and without language fallbacks doesn’t share the cache inappropriately

2020-10-23 Thread toan
toan removed toan as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T266141 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde

[Wikidata-bugs] [Maniphest] T266141: Check that getting labels with and without language fallbacks doesn’t share the cache inappropriately

2020-10-22 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T266141 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T266144: Use a caching service in newLanguageIndependentLuaBindings()

2020-10-22 Thread toan
toan removed toan as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T266144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde

[Wikidata-bugs] [Maniphest] T266144: Use a caching service in newLanguageIndependentLuaBindings()

2020-10-22 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T266144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T266144: Use a caching service in newLanguageIndependentLuaBindings()

2020-10-22 Thread toan
toan removed toan as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T266144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde

[Wikidata-bugs] [Maniphest] T266144: Use a caching service in newLanguageIndependentLuaBindings()

2020-10-22 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T266144 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T93273: UnresolvedRedirectException "Unresolved redirect to Q…" from WikiPageEntityRevisionLookup.php

2020-10-22 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T93273 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Lucas_Werkmeister_WMDE, BPirkle, gerritbot, PokestarFan, Krinkle, mmodell, Addshore, Bene, hoo, JanZerebecki

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-22 Thread toan
toan added a comment. We discussed the way forward for this task this morning and decided we will not spend more time investigate what could have been the root cause now ( even though it would be very satisfying ) but keep this ticket on the board and monitor if there any changes

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-22 Thread toan
toan added a subscriber: Tarrow. toan added a comment. I did some more tests with @Tarrow yesterday evening and seems this might just have been noise as we could not reproduce it again. Looking at the profile of https://de.wikivoyage.org/wiki/Halle_(Saale) this morning

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-21 Thread toan
toan added a comment. Ok, so after looking at this yesterday and today I've tried to replicate my local environment to what has been and what currently is deployed on https://de.wikivoyage.org/wiki/Spezial:Version LuaSandbox3.0.3 Lua 5.1.5 Installing luasandbox

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-20 Thread toan
toan added a comment. > Leaving T263999 <https://phabricator.wikimedia.org/T263999>: Some lua-calls with language specified does not end up in formatterCache because it has similar buzz words but I don't know if they are related. Yeah I'm suspecting this could be th

[Wikidata-bugs] [Maniphest] T265562: [6hr.] Investigation - Wikibase Lua: addStatementUsage seems unjustifiably expensive

2020-10-20 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T265562 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Lucas_Werkmeister_WMDE, toan, hoo, Lydia_Pintscher, RolandUnger, Aklapper, Akuckartz, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

2020-10-20 Thread toan
toan removed toan as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T252595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, Addshore, Alter

[Wikidata-bugs] [Maniphest] T255410: Termbox SSR connection terminated very often

2020-10-19 Thread toan
toan added a comment. Documentation looks great in my opinion. TASK DETAIL https://phabricator.wikimedia.org/T255410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, toan Cc: toan, Lucas_Werkmeister_WMDE, Sakretsu, akosiaris, JMeybohm

[Wikidata-bugs] [Maniphest] T264884: Enable dumpJson.php to output Lexemes

2020-10-16 Thread toan
toan added a comment. Thanks sounds promising, will have a look. TASK DETAIL https://phabricator.wikimedia.org/T264884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Lucas_Werkmeister_WMDE, hoo, toan, ItamarWMDE, Pablo-WMDE, Alter-paule

[Wikidata-bugs] [Maniphest] T220883: JSON dumps for Lexemes

2020-10-16 Thread toan
toan removed toan as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T220883 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Pablo-WMDE, WMDE-leszek, DVrandecic, Addshore, ArielGlenn, VIGNERON, Aklapper, hoo

[Wikidata-bugs] [Maniphest] T264884: Enable dumpJson.php to output Lexemes

2020-10-16 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T264884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Lucas_Werkmeister_WMDE, hoo, toan, ItamarWMDE, Pablo-WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696

[Wikidata-bugs] [Maniphest] T220883: JSON dumps for Lexemes

2020-10-16 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T220883 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Pablo-WMDE, WMDE-leszek, DVrandecic, Addshore, ArielGlenn, VIGNERON, Aklapper, hoo, Lydia_Pintscher, Envlh

[Wikidata-bugs] [Maniphest] T264884: Enable dumpJson.php to output Lexemes

2020-10-16 Thread toan
toan added a subscriber: hoo. toan added a comment. @hoo pointed out in the test (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/633196/2/tests/phpunit/maintenance/DumpJsonTest.php#155) that it is not sure that forms / senses will get the correct datatype when

[Wikidata-bugs] [Maniphest] T264884: Enable dumpJson.php to output Lexemes

2020-10-16 Thread toan
toan removed toan as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T264884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, ItamarWMDE, Pablo-WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez

[Wikidata-bugs] [Maniphest] T264884: Enable dumpJson.php to output Lexemes

2020-10-15 Thread toan
toan claimed this task. toan added a subscriber: ItamarWMDE. TASK DETAIL https://phabricator.wikimedia.org/T264884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: ItamarWMDE, Pablo-WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696

[Wikidata-bugs] [Maniphest] T265596: Investigate and possibly improve stability of browser tests

2020-10-15 Thread toan
toan created this task. toan added a project: Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION During the wb_terms leftover hike (https://phabricator.wikimedia.org/project/view/5012/) we think we noticed

[Wikidata-bugs] [Maniphest] T263435: `content was: ""` (empty string) when deleting Lexemes

2020-10-14 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T263435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Pablo-WMDE, Lydia_Pintscher, darthmon_wmde, abian, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T255410: Termbox SSR connection terminated very often

2020-10-13 Thread toan
toan added a comment. First off, thank you @akosiaris for your time investigating this. At the start of this task we were presented with the title "Termbox SSR connection terminated very often" and the logstash screenshot of the events that took place starting at 2020-06

[Wikidata-bugs] [Maniphest] T255410: Termbox SSR connection terminated very often

2020-10-13 Thread toan
toan reassigned this task from toan to Michael. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T255410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, toan Cc: toan, Lucas_Werkmeister_WMDE

[Wikidata-bugs] [Maniphest] T263435: `content was: ""` (empty string) when deleting Lexemes

2020-10-13 Thread toan
toan changed the point value for this task from "13" to "8". TASK DETAIL https://phabricator.wikimedia.org/T263435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: abian, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde,

[Wikidata-bugs] [Maniphest] T263435: `content was: ""` (empty string) when deleting Lexemes

2020-10-13 Thread toan
toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T263435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: abian, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256

[Wikidata-bugs] [Maniphest] T263435: `content was: ""` (empty string) when deleting Lexemes

2020-10-13 Thread toan
toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T263435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: abian, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256

[Wikidata-bugs] [Maniphest] T261218: Upgrade WebdriverIO to v6 in wdio-wikibase

2020-10-12 Thread toan
toan added a comment. All PR:s mentioned here seems to be merged, and the package has been released here https://github.com/wmde/wdio-wikibase/releases/tag/v4.0.1 Can this to be considered done? TASK DETAIL https://phabricator.wikimedia.org/T261218 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

2020-10-05 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T252595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

2020-10-02 Thread toan
toan removed toan as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T252595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez

[Wikidata-bugs] [Maniphest] T264298: wb_terms is getting removed

2020-10-01 Thread toan
toan added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T264298 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Addshore, LucasWerkmeister, toan, jannee_e, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-29 Thread toan
toan added a comment. Suggested way forward: stop incrementing the statsd counter for PrefetchingItemTermLookup::prefetchTerms to get the correct result. TASK DETAIL https://phabricator.wikimedia.org/T262923 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] T262924: Investigate how to implement different DB load groups in Wikibase

2020-09-29 Thread toan
toan added a comment. I'm not sure if this can be figured out any more other than starting to do this in some cases and see what happens? It seems a general approach other than find all ```getConnectionRef, getConnection``` and figure out what group should go in there is not applicable

[Wikidata-bugs] [Maniphest] T263999: Some lua-calls with language specified does not end up in formatterCache

2020-09-28 Thread toan
toan renamed this task from "Language dependent lua-calls does not end up in formatterCache" to "Some lua-calls with language specified does not end up in formatterCache". TASK DETAIL https://phabricator.wikimedia.org/T263999 EMAIL PREFERENCES https://phabricator.wi

[Wikidata-bugs] [Maniphest] T263999: Language dependent lua-calls does not end up in formatterCache

2020-09-28 Thread toan
toan added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T263999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] T263999: Language dependent lua-calls does not end up in formatterCache

2020-09-28 Thread toan
toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T263999 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] T263999: Language dependent lua-calls does not end up in formatterCache

2020-09-28 Thread toan
toan created this task. toan added a project: Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION While looking into some formatterCache things I noticed this. Creating a module like such local p = {} --p stands for package function p.hello

[Wikidata-bugs] [Maniphest] T255410: Termbox SSR connection terminated very often

2020-09-25 Thread toan
toan added a comment. @akosiaris I did some tinkering in the kibana ui and came up with this (hopefully) shareable link <https://logstash.wikimedia.org/app/kibana#/discover?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-12h,mode:quick,to:now))&_a=(columns:!(

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

2020-09-25 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T252595 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Aklapper, Addshore, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86

[Wikidata-bugs] [Maniphest] T255410: Termbox SSR connection terminated very often

2020-09-24 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T255410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Sakretsu, akosiaris, JMeybohm, WMDE-leszek, Pablo-WMDE, Tarrow, Jakob_WMDE, Addshore, Aklapper, Michael, Akuckartz

[Wikidata-bugs] [Maniphest] T262923: Investigate sensible DB load group splits for Wikidata / Wikibase

2020-09-24 Thread toan
toan added a comment. Playing around with a new panel on grafana and looking at how these statsd things are called from the code. the statsd measurement of PrefetchingItemTermLookup_prefetchTerms is always followed by DatabaseTermIdsResolver_selectTermsViaJoin which both seem

[Wikidata-bugs] [Maniphest] T261071: Malformed input error on text which is not malformed

2020-09-22 Thread toan
toan claimed this task. toan added a subscriber: guergana.tzatchkova. TASK DETAIL https://phabricator.wikimedia.org/T261071 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: guergana.tzatchkova, toan, WMDE-leszek, Pablo-WMDE, Addshore

[Wikidata-bugs] [Maniphest] T261071: Malformed input error on text which is not malformed

2020-09-22 Thread toan
toan added a comment. After discussion with @guergana.tzatchkova we decided I will inherit this task as she is moving on to a hike starting tomorrow. TASK DETAIL https://phabricator.wikimedia.org/T261071 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

2020-09-16 Thread toan
toan added a comment. This looks like it has been investigated fully. moving to done. TASK DETAIL https://phabricator.wikimedia.org/T261942 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, toan Cc: toan, Lydia_Pintscher, Nikki

[Wikidata-bugs] [Maniphest] T260853: TypeError from Wikibase: Argument 1 passed to extractForeignIdStringSpecialNs() must implement interface MediaWiki\Linker\LinkTarget, null given, called in repo/in

2020-08-20 Thread toan
toan added a comment. This is the patch that caused this https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/618991 The suggested fix would allow the links to take the same path as before this was merged. TASK DETAIL https://phabricator.wikimedia.org/T260853 EMAIL

[Wikidata-bugs] [Maniphest] T260853: TypeError from Wikibase: Argument 1 passed to extractForeignIdStringSpecialNs() must implement interface MediaWiki\Linker\LinkTarget, null given, called in repo/in

2020-08-20 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T260853 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Michael, Tacsipacsi, Aklapper, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, Pablo-WMDE

[Wikidata-bugs] [Maniphest] T259785: ArticleRevisionVisibilitySetHookHandlerTest fails on CI

2020-08-06 Thread toan
toan created this task. toan added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Steps to Reproduce: - upload a new patch https

[Wikidata-bugs] [Maniphest] T94019: Generate RDF from JSON

2020-08-03 Thread toan
toan added a project: Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T94019 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Tonina_Zhelyazkova_WMDE, JAllemandou, Pintoch, Smalyshev, hoo, Liuxinyu970226, mkroetzsch

[Wikidata-bugs] [Maniphest] T250974: Create a new wdqs docker file and image for the latest snapshot of wdqs used by the wmf

2020-07-14 Thread toan
toan added a comment. Verification could be verifying that it's listed here https://hub.docker.com/r/wikibase/wdqs/tags TASK DETAIL https://phabricator.wikimedia.org/T250974 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc

[Wikidata-bugs] [Maniphest] T250974: Create a new wdqs docker file and image for the latest snapshot of wdqs used by the wmf

2020-07-14 Thread toan
toan added a comment. This has now been merged and can be used by using image: wikibase/wdqs:0.3.40 TASK DETAIL https://phabricator.wikimedia.org/T250974 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Samantha_Alipio_WMDE

[Wikidata-bugs] [Maniphest] T250974: Create a new wdqs docker file and image for the latest snapshot of wdqs used by the wmf

2020-07-10 Thread toan
toan added a comment. The RWStore.properties file has now been updated to match 0.3.40 defaults. The Pull request can be reviewed here -> https://github.com/wmde/wikibase-docker/pull/128 TASK DETAIL https://phabricator.wikimedia.org/T250974 EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] [Claimed] T250974: Create a new wdqs docker file and image for the latest snapshot of wdqs used by the wmf

2020-07-08 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T250974 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Samantha_Alipio_WMDE, Headingtona, Mstyles, Addshore, Aklapper, Jimfhahn, CBogen, Akuckartz, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Commented On] T253863: SetDescription/Label/Aliases special pages on commons specifies Item/Property in messages but can be used for MediaInfo

2020-07-03 Thread toan
toan added a comment. This could be supported by -> https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608903 TASK DETAIL https://phabricator.wikimedia.org/T253863 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: t

[Wikidata-bugs] [Maniphest] [Claimed] T255505: Travis test failure FederatedPropertiesErrorTest::testOutputShouldGenerateMissingLabel

2020-06-16 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T255505 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: WMDE-leszek, Michael, toan, Aklapper, Addshore, Liuxinyu970226, Jimfhahn, darthmon_wmde, Nandana, lucamauri, Lahi

[Wikidata-bugs] [Maniphest] [Retitled] T254443: Refactor EntityRevisionLookup::LATEST_FROM_* to LookupConstants::

2020-06-05 Thread toan
toan renamed this task from " Refactor EntityRevisionLookup::LATEST_FROM_* to Store interface." to " Refactor EntityRevisionLookup::LATEST_FROM_* to LookupConstants::". toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254443 EMAIL

[Wikidata-bugs] [Maniphest] [Claimed] T251880: Special:Search RevisionedUnresolvedRedirectException logspam

2020-06-04 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T251880 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri

[Wikidata-bugs] [Maniphest] [Commented On] T251880: Special:Search RevisionedUnresolvedRedirectException logspam

2020-06-04 Thread toan
toan added a comment. [6c4a644ae6c0fe4a34e65310] /mediawiki/index.php?search=Item%3AQ1=Special%3ASearch=advanced=1=1 Wikibase\Lib\Store\RevisionedUnresolvedRedirectException from line 127 of /home/toan/Documents/dev/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php

[Wikidata-bugs] [Maniphest] [Commented On] T251880: Special:Search RevisionedUnresolvedRedirectException logspam

2020-06-04 Thread toan
toan added a comment. I think this is actually caused by double redirects. I created locally item1, item2 and merged them. -> the search works fine I created item3 and merged item2 into it -> the search returns Internal Error. TASK DETAIL https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Created] T254443: Refactor EntityRevisionLookup::LATEST_FROM_* to Store interface.

2020-06-04 Thread toan
toan created this task. toan added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION During work in T251878 <https://phabricator.wikimedia.org/T251

[Wikidata-bugs] [Maniphest] [Retitled] T253737: Release and use wikibase/data-model 9.5.1 everywhere

2020-06-04 Thread toan
toan renamed this task from "Release and use wikibase/data-model 9.5.0 everywhere" to "Release and use wikibase/data-model 9.5.1 everywhere". toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T253737 EMAIL PREFERENCES https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T254387: SpecialSetSiteLinkTest::testExecutePostRemoveSiteLink & testExecutePostModifySiteLink failing for no apparent reason

2020-06-04 Thread toan
toan added a comment. Yay my hero! TASK DETAIL https://phabricator.wikimedia.org/T254387 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, toan Cc: Ladsgroup, Addshore, Aklapper, toan, Liuxinyu970226, Blissjay007, Oblanco79, Alter-paule

[Wikidata-bugs] [Maniphest] [Edited] T254387: SpecialSetSiteLinkTest::testExecutePostRemoveSiteLink & testExecutePostModifySiteLink failing for no apparent reason

2020-06-03 Thread toan
toan updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T254387 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Aklapper, toan, Liuxinyu970226, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Created] T254387: SpecialSetSiteLinkTest::testExecutePostRemoveSiteLink & testExecutePostModifySiteLink failing for no apparent reason

2020-06-03 Thread toan
toan created this task. toan added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added subscribers: Liuxinyu970226, Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION There were 2 errors: 1) Wikibase\Repo\Tests

[Wikidata-bugs] [Maniphest] [Claimed] T251876: wbsgetsuggestions RevisionedUnresolvedRedirectException logspam

2020-06-02 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T251876 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi

[Wikidata-bugs] [Maniphest] [Claimed] T253737: Release and use wikibase/data-model 9.5.0 everywhere

2020-06-02 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T253737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Aklapper, Addshore, Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Commented On] T251878: UpdateRepoOnMove RevisionedUnresolvedRedirectException logspam

2020-06-02 Thread toan
toan added a comment. Added a patch here -> https://phabricator.wikimedia.org/T251878 TASK DETAIL https://phabricator.wikimedia.org/T251878 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Krinkle, Aklapper, WMDE-leszek, Ladsgr

[Wikidata-bugs] [Maniphest] [Claimed] T251878: UpdateRepoOnMove RevisionedUnresolvedRedirectException logspam

2020-05-27 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T251878 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: toan, Krinkle, Aklapper, WMDE-leszek, Ladsgroup, Addshore, Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri

[Wikidata-bugs] [Maniphest] [Commented On] T253637: Ensure WikibaseDataModel has hash stability tests for all hash methods

2020-05-27 Thread toan
toan added a comment. Added a PR -> https://github.com/wmde/WikibaseDataModel/pull/825 TASK DETAIL https://phabricator.wikimedia.org/T253637 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Jdforrester-WMF, Addshore, Aklapper, Iflo

[Wikidata-bugs] [Maniphest] [Claimed] T253637: Ensure WikibaseDataModel has hash stability tests for all hash methods

2020-05-26 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T253637 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Addshore, Aklapper, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Commented On] T243590: Fix WikibaseDataModel CI for php 7.4

2020-05-26 Thread toan
toan added a comment. Added pull request here -> https://github.com/wmde/WikibaseDataModel/pull/824 TASK DETAIL https://phabricator.wikimedia.org/T243590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Pablo-WMDE, WMDE-leszek, Daim

[Wikidata-bugs] [Maniphest] [Claimed] T243590: Fix WikibaseDataModel CI for php 7.4

2020-05-25 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T243590 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Pablo-WMDE, WMDE-leszek, Daimona, Jdforrester-WMF, srishakatux, Reedy, Addshore, Aklapper, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Commented On] T253027: Add LabelEdit component to Termbox storybook

2020-05-25 Thread toan
toan added a comment. I should have moved this back to in progress on when i stopped on thursday. The only step left was confirming that the selenium tests were ok, thats why i put the gerrit patches back to WIP. TASK DETAIL https://phabricator.wikimedia.org/T253027 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T253027: Add LabelEdit component to Termbox storybook

2020-05-25 Thread toan
toan added a comment. In T253027#6154376 <https://phabricator.wikimedia.org/T253027#6154376>, @hoo wrote: > @toan Which of the two patches should be reviewed? Are they still WIP (if not, you should publish them for review in Gerrit). Hey, yes they are still not ready f

[Wikidata-bugs] [Maniphest] [Updated] T253027: Add LabelEdit component to Termbox storybook

2020-05-20 Thread toan
toan added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Restricted Application added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T253027 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Pablo-WMDE, WMDE

[Wikidata-bugs] [Maniphest] [Commented On] T198703: Form grammatical features: Form field labels not connected

2020-05-19 Thread toan
toan added a comment. This can be tried on beta, e.g. https://wikidata.beta.wmflabs.org/wiki/Lexeme:L50 TASK DETAIL https://phabricator.wikimedia.org/T198703 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: WMDE-leszek, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Claimed] T198703: Form grammatical features: Form field labels not connected

2020-05-13 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T198703 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Pablo-WMDE, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen

[Wikidata-bugs] [Maniphest] [Claimed] T198702: Form representations: Form field labels not connected

2020-05-11 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T198702 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Pablo-WMDE, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Claimed] T251652: Using assertContains() with string haystacks is deprecated

2020-05-11 Thread toan
toan claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T251652 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: toan Cc: Pablo-WMDE, Aklapper, Liuxinyu970226, Reedy, Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86