[Wikidata-bugs] [Maniphest] [Commented On] T153964: add -lexeme- to all WikibaseLexeme messages

2018-09-18 Thread WMDE-leszek 
WMDE-leszek added a comment.
Any of these

"wikibase-lexeme"

should actually be sort of magic keys generate by Wikibase code, based on the entity type. Therefore making the prefix of these to be "wikibaselexeme" without a hyphen was not possible without breaking some functionality (user facing).TASK DETAILhttps://phabricator.wikimedia.org/T153964EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Addshore, WMDE-leszek, Izno, gerritbot, Aklapper, Amire80, Mringgaard, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, TerraCodes, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Darkdadaah, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153964: add -lexeme- to all WikibaseLexeme messages

2018-09-18 Thread Addshore 
Addshore added a comment.
@Amire80 Are there any exceptions to the rule that all i18n messages should be prefixed with some extension prefix?

Looking at the current list of i18n messages for WikibaseLexeme we have the following message prefixes:


"wikibaselexeme" - I guess these are all okay, this should be the prefix that we aim for
"wikibase-lexeme" - This is probably unique to the extension, but I guess we should remove the hyphen here and just have "wikibaselexeme"
"special" - I believe these are some sort of magic keys and have to have this prefix, so they can remain?
"datatypes" - This is currently another magic i18n message and the Wikibase extension expects messages to have this prefix
"apihelp" - Another magic one from core, I guess this one is okay to stay
"content-model" - Again another magic one
TASK DETAILhttps://phabricator.wikimedia.org/T153964EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, WMDE-leszek, Izno, gerritbot, Aklapper, Amire80, Mringgaard, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, TerraCodes, Srdjan_m, MuhammadShuaib, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Darkdadaah, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153964: add -lexeme- to all WikibaseLexeme messages

2016-12-26 Thread gerritbot 
gerritbot added a comment.
Change 328712 merged by jenkins-bot:
Change a duplicate message key wikibase-newentity-language

https://gerrit.wikimedia.org/r/328712TASK DETAILhttps://phabricator.wikimedia.org/T153964EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Izno, gerritbot, Aklapper, Amire80, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153964: add -lexeme- to all WikibaseLexeme messages

2016-12-26 Thread Izno 
Izno added a comment.
This is a problem, because it can lead to the creation of different messages with identical keys, and indeed, this already happened with wikibase-newentity-language, and caused issues in translatewiki.net.

Is there a way to write an automated test to check that all messages are unique in an extension? Or on translatewiki's side to do the same?TASK DETAILhttps://phabricator.wikimedia.org/T153964EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: IznoCc: Izno, gerritbot, Aklapper, Amire80, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, MuhammadShuaib, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T153964: add -lexeme- to all WikibaseLexeme messages

2016-12-26 Thread gerritbot 
gerritbot added a comment.
Change 328712 had a related patch set uploaded (by Amire80):
Change a duplicate message key wikibase-newentity-language

https://gerrit.wikimedia.org/r/328712TASK DETAILhttps://phabricator.wikimedia.org/T153964EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Amire80, D3r1ck01, MuhammadShuaib, Izno, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs