[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-23 Thread gerritbot 
gerritbot added a comment.
Change 412675 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove plain message CPE serializations from cache map

https://gerrit.wikimedia.org/r/412675TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-21 Thread gerritbot 
gerritbot added a comment.
Change 411309 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage in ConstraintParameterParser

https://gerrit.wikimedia.org/r/411309TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, abian, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-21 Thread gerritbot 
gerritbot added a comment.
Change 411308 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Support ViolationMessage in ConstraintParameterException

https://gerrit.wikimedia.org/r/411308TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, abian, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-20 Thread gerritbot 
gerritbot added a comment.
Change 411307 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessageRenderer in CheckConstraintParameters

https://gerrit.wikimedia.org/r/411307TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, abian, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-19 Thread gerritbot 
gerritbot added a comment.
Change 411306 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Extract ConstraintParameterException serialization

https://gerrit.wikimedia.org/r/411306TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-19 Thread gerritbot 
gerritbot added a comment.
Change 411305 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ConstraintParameterException::getViolationMessage()

https://gerrit.wikimedia.org/r/411305TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-19 Thread gerritbot 
gerritbot added a comment.
Change 412675 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove plain message CPE serializations from cache map

https://gerrit.wikimedia.org/r/412675TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-16 Thread gerritbot 
gerritbot added a comment.
Change 411307 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessageRenderer in CheckConstraintParameters

https://gerrit.wikimedia.org/r/411307TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-16 Thread gerritbot 
gerritbot added a comment.
Change 411308 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Support ViolationMessage in ConstraintParameterException

https://gerrit.wikimedia.org/r/411308TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-16 Thread gerritbot 
gerritbot added a comment.
Change 411309 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ViolationMessage in ConstraintParameterParser

https://gerrit.wikimedia.org/r/411309TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-16 Thread gerritbot 
gerritbot added a comment.
Change 411306 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Extract ConstraintParameterException serialization

https://gerrit.wikimedia.org/r/411306TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-16 Thread gerritbot 
gerritbot added a comment.
Change 411305 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use ConstraintParameterException::getViolationMessage()

https://gerrit.wikimedia.org/r/411305TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-16 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Regarding the transition period… I’m not sure if we even need to have one. At some point we will have to throw out invalid CPEs, and just doing it up-front shouldn’t hurt too much, I think. We have plenty of other checks that always hit WDQS, so I think a few more queries to WDQS should be acceptable. (Keep in mind that the CPE only happens in the first place in case of an invalid regex, which should be rare.)TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-14 Thread gerritbot 
gerritbot added a comment.
Change 410420 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Inject ViolationMessageSerializer and -Deserializer

https://gerrit.wikimedia.org/r/410420TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-14 Thread gerritbot 
gerritbot added a comment.
Change 410420 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Inject ViolationMessageSerializer and -Deserializer

https://gerrit.wikimedia.org/r/410420TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T187186: Use ViolationMessage in ConstraintParameterException

2018-02-13 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.
Actually, the transition period will have to be a bit longer, since we need to support pre-rendered messages out of the SparqlHelper regexp cache for at least the duration of one deployment. And in fact we might need to find some mechanism to explicitly evict such old entries, otherwise the more commonly used ones might stay in cache for a long time.TASK DETAILhttps://phabricator.wikimedia.org/T187186EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, gerritbot, WMDE-leszek, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs