[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-07-01 Thread gerritbot
gerritbot added a comment.


  Change 607051 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Reenable upstream tests for 
SimpleCacheWithBagOfStuff
  
  https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /607051

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: WMDE-leszek, Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, 
Jdforrester-WMF, Ladsgroup, Aklapper, MaxSem, Alter-paule, Beast1978, Un1tY, 
Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-06-22 Thread Michael
Michael added a comment.


  In T237164#6234226 , 
@Addshore wrote:
  
  > I think "Just copy the test code we need and ditch the library."
  
  Did that with the version currently in the HEAD of their master branch, but 
I'm getting test failures:
  
111) 
Wikibase\Lib\Tests\SimpleCacheWithBagOStuffTest::testDeleteMultipleInvalidKeys 
with data set #17 (2)
Failed asserting that exception of type 
"Psr\SimpleCache\InvalidArgumentException" is thrown.

/app/maintenance/doMaintenance.php:105
  
  Have you seen that before? The tests for invalid keys are in principle in 
there since the beginning.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: WMDE-leszek, Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, 
Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-06-22 Thread gerritbot
gerritbot added a comment.


  Change 607051 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/extensions/Wikibase@master] Reenable upstream tests for 
SimpleCacheWithBagOfStuff
  
  https://gerrit.wikimedia.org/r/607051

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: WMDE-leszek, Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, 
Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-06-19 Thread Ladsgroup
Ladsgroup added a comment.


  In T237164#6234226 , 
@Addshore wrote:
  
  > In T237164#6192621 , 
@Ladsgroup wrote:
  >
  >> which option shall we pursue? Any preference?
  >
  > I think "Just copy the test code we need and ditch the library."
  
  +1

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, 
Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-06-18 Thread Addshore
Addshore added a comment.


  In T237164#6192621 , 
@Ladsgroup wrote:
  
  > which option shall we pursue? Any preference?
  
  I think "Just copy the test code we need and ditch the library."

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: WMDE-leszek, Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, 
Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-06-04 Thread Ladsgroup
Ladsgroup added a comment.


  which option shall we pursue? Any preference?

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, 
Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Blissjay007, 
Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-03-11 Thread Ladsgroup
Ladsgroup added a comment.


  In T237164#5954747 , 
@Addshore wrote:
  
  > See T237164#5896034 
  >
  > In T237164#5896034 , 
@Addshore wrote:
  >
  >> So to move forward this would have to be re added, pinned at the specific 
version too.
  >> And then this starts becoming messier, as outlined in T199440 
 this is not an ideal situation but 
apparently the only way we could make it work with the WMF CI.
  >> I'd propose we also restore this require-dev in the core composer.json for 
now pinned to the same version as in Wikibase, essentially restoring the way 
things were.
  
  I understand but as I mentioned the quote, it's not enough because one of the 
fixes (there are several problems) is not even merged to master so we can't 
even pinpoint to a commit (and not wait for a release): 
https://github.com/php-cache/integration-tests/pull/107

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, 
Ladsgroup, thiemowmde, Aklapper, MaxSem, Alter-paule, Beast1978, Un1tY, 
Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Iflorez, darthmon_wmde, 
alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-03-09 Thread Addshore
Addshore added a comment.


  See T237164#5896034 
  
  In T237164#5896034 , 
@Addshore wrote:
  
  > So to move forward this would have to be re added, pinned at the specific 
version too.
  > And then this starts becoming messier, as outlined in T199440 
 this is not an ideal situation but 
apparently the only way we could make it work with the WMF CI.
  > I'd propose we also restore this require-dev in the core composer.json for 
now pinned to the same version as in Wikibase, essentially restoring the way 
things were.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, 
Ladsgroup, thiemowmde, Aklapper, MaxSem, Alter-paule, Beast1978, Un1tY, 
Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Iflorez, darthmon_wmde, 
alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-03-06 Thread Ladsgroup
Ladsgroup added a comment.


  In T237164#5893896 , 
@Daimona wrote:
  
  > Also, the library is currently broken: its public interface is using 
symfony/phpunit-bridge, but it's listed in `require-dev` instead of `require`, 
see https://github.com/php-cache/integration-tests/pull/107. I believe we had 
discussed this briefly on gerrit at the time, and agreed that disabling the 
test was the best solution for the time being.
  
  This is not merged and fixed, I guess we can't move forward unless upstream 
merges it and since the project seems to be abandoned (the whole org is 
abandoned), I wouldn't hold my breath...

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, 
Ladsgroup, thiemowmde, Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, 
RomaAmorRoma, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-19 Thread Daimona
Daimona added a comment.


  In T237164#5896034 , 
@Addshore wrote:
  
  > It looks like that was removed in 
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/552166/ but not linked to 
this ticket.
  
  Ah, thanks, I forgot about that step.
  
  > And then this starts becoming messier
  
  +1
  
  > I'd propose we also restore this require-dev in the core composer.json for 
now pinned to the same version as in Wikibase, essentially restoring the way 
things were.
  
  And +1, let's restore the status quo.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, Daimona
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-18 Thread Daimona
Daimona added a comment.


  For some reason, cache/integration-tests is not being installed, see 
https://integration.wikimedia.org/ci/job/wikibase-repo-docker/11815/console. 
This used to work before the test was disabled.
  
  Also, the library is currently broken: its public interface is using 
symfony/phpunit-bridge, but it's listed in `require-dev` instead of `require`, 
see https://github.com/php-cache/integration-tests/pull/107. I believe we had 
discussed this briefly on gerrit at the time, and agreed that disabling the 
test was the best solution for the time being.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, Daimona
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-18 Thread gerritbot
gerritbot added a comment.


  Change 572923 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  [mediawiki/extensions/Wikibase@master] Revert "Disable a broken test"
  
  https://gerrit.wikimedia.org/r/572923

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, gerritbot
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-18 Thread gerritbot
gerritbot added a comment.


  Change 572904 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Use HEAD of cache/integration-tests
  
  https://gerrit.wikimedia.org/r/572904

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, gerritbot
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-18 Thread gerritbot
gerritbot added a comment.


  Change 572904 had a related patch set uploaded (by Rosalie Perside (WMDE); 
owner: Rosalie Perside (WMDE)):
  [mediawiki/extensions/Wikibase@master] Use HEAD of cache/integration-tests
  
  https://gerrit.wikimedia.org/r/572904

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, gerritbot
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-18 Thread thiemowmde
thiemowmde added a comment.


  Thanks a lot for the detailed response! However, I feel my main point got 
lost. My question really is what the benefit of an isolated unit test for 
"being compatible with PSR-16" is? It's not like the class 
SimpleCacheWithBagOStuff is used in isolation. It's not even used in an 
external context we don't know anything about but that it expects compatibility 
with PSR-16. No. This class is used in Wikibase. We know where it is used. My 
question is: Isn't it enough to have good coverage for all the code that is 
using this class?
  
  "Coverage" is not about a number. Coverage is about the team having 
confidence the code they own does not break without a test protecting them. As 
far as I can see these tests exist.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, thiemowmde
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-18 Thread Addshore
Addshore added a comment.


  In T237164#5889530 , 
@thiemowmde wrote:
  
  > Wasn't this what @MaxSem tried already in 
https://gerrit.wikimedia.org/r/547911?
  
  Yes it looks like it, and that seemed to pass CI
  
  > What's the point of this library anyway?
  
  A shared test base and set of tests for a shared interface shared between 
multiple projects.
  It includes tests for all of the basic functionality and spec of the PSR, 
making sure implementations are doing the right things.
  
  > As far as I can tell it's used in a single (!) file: 
SimpleCacheWithBagOStuffTest.
  
  Yes
  
  > What does it do?
  
  Runs more tests
  
  > What do we loose when we get rid of the library? A bit of coverage maybe? 
Can't we restore this coverage by writing a few more test cases, without 
relying on the external library?
  
  We either:
  
  - choose to have less coverage
  - copy and paste the test cases into our own code and have the same coverage
  - send time writing other different tests probably resulting in the same or 
less coverage
  
  > Or even better, aren't the existing test cases enough to cover the code?
  
  Probably not, we only test a few very specific cases on top of what is 
provided by the base tests

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Rosalie_WMDE, Addshore
Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, 
Aklapper, MaxSem, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-17 Thread thiemowmde
thiemowmde added a comment.


  Wasn't this what @MaxSem tried already in 
https://gerrit.wikimedia.org/r/547911?
  
  What's the point of this library anyway? As far as I can tell it's used in a 
single (!) file: SimpleCacheWithBagOStuffTest. What does it do? What do we 
loose when we get rid of the library? A bit of coverage maybe? Can't we restore 
this coverage by writing a few more test cases, without relying on the external 
library? Or even better, aren't the existing test cases enough to cover the 
code?

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, 
MaxSem, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-17 Thread Addshore
Addshore added a comment.


  Option #3 point to a specific commit hash in composer.json
  Lets do this one!

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, 
MaxSem, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-02-15 Thread Ladsgroup
Ladsgroup added a comment.


  In T237164#5827895 , 
@Addshore wrote:
  
  > Disabling this test looks fine for now until upstream releases
  
  Apparently the latest release of this library just had its second 
anniversary. I think we should drop using it altogether?

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, 
MaxSem, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-01-23 Thread Addshore
Addshore added a comment.


  Disabling this test looks fine for now until upstream releases

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, 
MaxSem, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-01-23 Thread Daimona
Daimona added a comment.


  In T237164#5827203 , 
@Jdforrester-WMF wrote:
  
  > Is this going anywhere, or are we just going to leave it disabled forever?
  
  I guess it's going to sit in the bitrot limbo until a new version is released 
upstream. Which, in turn, seems implausible, judging from the last commit dates 
and the open issues/PRs.

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8

2020-01-23 Thread Jdforrester-WMF
Jdforrester-WMF added a comment.


  Is this going anywhere, or are we just going to leave it disabled forever?

TASK DETAIL
  https://phabricator.wikimedia.org/T237164

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs