[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-24 Thread Mrjohncummings 
Mrjohncummings added a comment.


  @Lea_Lacroix_WMDE thanks

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mrjohncummings
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-24 Thread Lea_Lacroix_WMDE 
Lea_Lacroix_WMDE added a comment.


  @Mrjohncummings No problem, I removed the line from the newsletter.

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_Lacroix_WMDE
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-24 Thread Mrjohncummings 
Mrjohncummings added a comment.


  @Lea_Lacroix_WMDE also the tours don't work properly till this bug gets fixed 
so best hold off for now

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mrjohncummings
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-22 Thread Mrjohncummings 
Mrjohncummings added a comment.


  @Lea_Lacroix_WMDE please wait a little but to share it, I've got several more 
to add and I want to redo the main Tours page

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mrjohncummings
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-20 Thread Lea_Lacroix_WMDE 
Lea_Lacroix_WMDE added a comment.


  Thanks a lot for your work! I'll add a note in the next newsletter.

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_Lacroix_WMDE
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-19 Thread Mrjohncummings 
Mrjohncummings added a comment.


  A small update
  
  We have now redesigned the main tours page and published some of the new 
tours, several more to come including a section on creating common kinds of 
items e.g people, museums etc based on schemas
  
  https://www.wikidata.org/wiki/Wikidata:Tours

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mrjohncummings
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, Rosalie_WMDE, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-16 Thread NavinoEvans 
NavinoEvans added a comment.


  I'm going to be bold and go ahead with updating the Guided Tours library 
 to the new version 
I made on test.wikidata. I'm rushing it through as the finding GLAMs Challenge 
 starts tomorrow and 
there are 5 new tours ready to be added that won't work correctly with the 
current version of the tours library. 
  The currently live 'items' and 'statements' tours also have serious issues 
that will resolve with the update.
  
  I will copy over my latest version from test Wikidata 

 shortly. The revision of the current live version is here in case anyone needs 
to refer to it or revert back: 
https://www.wikidata.org/w/index.php?title=MediaWiki:Guidedtour-lib.js=1109740624

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: NavinoEvans
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, Rosalie_WMDE, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-13 Thread NavinoEvans 
NavinoEvans added a comment.


  Hi all, I think I've managed to combine the best of both versions and fix 
most of the outstanding issues I was planning to report.
  
  There are some hacky parts which need to be resolved by making small changes 
to the guiders library 
,
 but for me this is fine to go live so we have everything working instead of 
broken. Then we can clean it up after some discussion over the coming 
weeks/months.
  
  You can check how this tour works 
https://test.wikidata.org/w/index.php?title=Q211911=wbcoordinates 
  Note: The reference slide is a bit mismatched with slide text and attachment 
as there's a new UI on test.wikidata.
  
  What I've fixed is:
  
  - Next step is now triggered whether you click the next button or complete an 
action in the UI.
  - However you complete the step, the next slide will wait for the new 
elements to be loaded so that it can attach to it correctly (instead of 
floating in the middle of the page).
  - The `onShow` event only fires once, so you do not get actions repeated twice
  - Once a step is completed, the action will not be triggered again. This 
means you can move back/forward through steps without the actions repeating 
every time (and creating multiple "new statement" boxes for example)
  - Fixed T244747: Wikidata Tours: Stepping back shows next and previous steps 
at once 
  
  The main hack is that I've added a new `actionBtn2` property in the step 
options. This is to prevent the automatic clicking on the `actionBtn` element 
whenever a slide advances (in the guiders library). 
  We need to wait to advance the slide until the DOM is ready with the element 
to attach the guider to.
  The other hack is closely related, I just needed to remove the click event 
for the "next" button, so we could trigger the DOM change and wait for 
completion before advancing.
  
  Does anyone have any objections to me adding this as the main new version?  
As well as temporarily changing the two tours we currently have live to use 
`actionBtn2` instead of `actionBtn`.

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: NavinoEvans
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, Rosalie_WMDE, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-13 Thread NavinoEvans 
NavinoEvans added a comment.


  Yes that is indeed true @Lea_Lacroix_WMDE, I just wanted to make sure 
everyone was aware of the issue and check for any objections to copying over 
the new version. My hope is that we can then organise a git repository that 
everyone can contribute to avoid all the difficulty tracking what versions are 
where, but that will be another ticket ;)

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: NavinoEvans
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, Rosalie_WMDE, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-13 Thread Lea_Lacroix_WMDE 
Lea_Lacroix_WMDE added a comment.


  @NavinoEvans As far as I understand, nothing prevents you to add 
MediaWiki:Guidedtour-lib2.js to wikidata.org yourself, right?

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_Lacroix_WMDE
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, Rosalie_WMDE, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-13 Thread Mrjohncummings 
Mrjohncummings added a comment.


  Thanks very much @Lea_Lacroix_WMDE , let me know if there's anything muggles 
can help with

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mrjohncummings
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, Rosalie_WMDE, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-13 Thread Lea_Lacroix_WMDE 
Lea_Lacroix_WMDE added a comment.


  Hello all, thanks for preparing this ticket.
  We're going to look into it as soon as possible. However, what I can say for 
sure is that this is not just an easy bug to fix, and we won't be able to 
change anything before Monday. I'm sorry for that.
  I'll share more information with you when I can.

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_Lacroix_WMDE
Cc: Lea_Lacroix_WMDE, Lydia_Pintscher, Pasleim, Ijon, Saturae, DDJJ, 
Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, Rosalie_WMDE, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, Pavithraes, darthmon_wmde, 
Nandana, Cpaulf30, Lahi, Gq86, GoranSMilovanovic, Ivana_Isadora, 
Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-12 Thread Ijon 
Ijon added a comment.


  Yes yes yes! This is important. Usable tours are crucial for self-onboarding 
for volunteers not able to get in-person training.

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ijon
Cc: Ijon, Saturae, DDJJ, Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, 
WMDE-leszek, Rosalie_WMDE, Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T244994: Wikidata tours: Reconcile versions of MediaWiki:Guidedtour-lib.js

2020-02-12 Thread Richard_Nevell_WMUK 
Richard_Nevell_WMUK added a comment.


  I would love to have the tours functioning on Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T244994

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Richard_Nevell_WMUK
Cc: Richard_Nevell_WMUK, Fuzheado, Ainali, Aklapper, WMDE-leszek, Rosalie_WMDE, 
Alicia_Fagerving_WMSE, Mrjohncummings, NavinoEvans, darthmon_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs