[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-27 Thread gerritbot 
gerritbot added a comment.


  Change 592257 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: Add capability to provoke 
generic save error to browser tests
  
  https://gerrit.wikimedia.org/r/592257

TASK DETAIL
  https://phabricator.wikimedia.org/T249715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper, Blissjay007, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, Michael, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  > not sure whether it will ever acquire more functions than those two.
  
  At least it will have an intuitive, easy to discover file name then.
  
  I can totally see this functionality in wdio-mediawiki as well (it also has a 
`Util` already). Maybe we can suggest it there and keep our own clone for now - 
getting the best of the boyscout rule //and// rapid iterations.

TASK DETAIL
  https://phabricator.wikimedia.org/T249715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Pablo-WMDE
Cc: Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper, Blissjay007, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, Michael, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread Michael 
Michael added a comment.


  In T249715#6079408 , 
@Pablo-WMDE wrote:
  
  > Hmm, I see a `canSave.js` patch landed. Was about to add such a test to the 
(new) errorHandling test, using network outage as the reason for the initial 
loading to fail (retry does hardly make sense on an invalid entity id [the only 
pre-existing case]). I'd be happy with no util at all, or it moving into the 
page objects (or any other centrally reachable place), but an individual spec 
will almost always leave something to be desired…
  
  Makes sense. Since there now might be multiple places after all where we 
might need it, I opted for a separate `NetworkUtils.js` file, though I'm not 
sure whether it will ever acquire more functions than those two.

TASK DETAIL
  https://phabricator.wikimedia.org/T249715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper, Blissjay007, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, Michael, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  Hmm, I see a `canSave.js` patch landed. Was about to add such a test to the 
(new) errorHandling test, using network outage as the reason for the initial 
loading to fail (retry does hardly make sense on in invalid entity id [the only 
pre-existing case]). I'd be happy with no util at all, or it moving into the 
page objects (or any other centrally reachable place), but an individual spec 
will almost always leave something to be desired…

TASK DETAIL
  https://phabricator.wikimedia.org/T249715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Pablo-WMDE
Cc: Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper, Blissjay007, Oblanco79, 
Alter-paule, Beast1978, Un1tY, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 
E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, Michael, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-23 Thread gerritbot 
gerritbot added a comment.


  Change 592257 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/extensions/Wikibase@master] bridge: Add capability to provoke 
generic save error to browser tests
  
  https://gerrit.wikimedia.org/r/592257

TASK DETAIL
  https://phabricator.wikimedia.org/T249715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T249715: Add capability to provoke generic save error to browser tests

2020-04-22 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  > I'm not sure that this needs to be wrapped in a helper function on its own. 
If it does - where would that helper function live?
  
  Since we’ll likely only need it for the save tests, I’d put it in 
`specs/canSave.js`.

TASK DETAIL
  https://phabricator.wikimedia.org/T249715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs