[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[WMDE-leszek]

WMDE-leszek closed this task as "Resolved".
WMDE-leszek moved this task from Test (Verification) to Done on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
WMDE-leszek claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed subtask T265984: Create first exemplary services 
in WikibaseRepo as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[WMDE-leszek]

WMDE-leszek closed subtask T266215: Implement the FormatterCache versioning as 
"Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[WMDE-leszek]

WMDE-leszek closed subtask T265983: Make shared caching service (ObjectCache) 
injectable into FormatterCacheFactory as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[gerritbot]

gerritbot added a comment.


  Change 630188 **abandoned** by Tobias Andersson:
  [mediawiki/extensions/Wikibase@master] Add formatterCacheVersion
  
  Reason:
  https://phabricator.wikimedia.org/T265983
  
  https://gerrit.wikimedia.org/r/630188

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a project: Story.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[gerritbot]

gerritbot added a comment.


  Change 635532 had a related patch set uploaded (by Pablo Grass (WMDE); owner: 
Pablo Grass (WMDE)):
  [mediawiki/extensions/Wikibase@master] FormatterCacheFactory: add version to 
cache key(s)
  
  https://gerrit.wikimedia.org/r/635532

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Pablo-WMDE]

Pablo-WMDE added a comment.


  We split this into subtasks
  
  *T265983: Make shared caching service (ObjectCache) injectable into 
FormatterCacheFactory 
  
  - T265983: Make shared caching service (ObjectCache) injectable into 
FormatterCacheFactory 
  
  to ease discussing the challenges in isolation.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[toan]

toan removed toan as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T252595#6536854 , 
@Michael wrote:
  
  > At the very least, the patch that introduces the new formatter version (and 
possibly invalidates the current keys in the process?) should probably be 
flagged as a risky patch 
 to 
watch out for during the next deployment.
  
  The way the change is currently written, it shouldn’t invalidate the current 
cache contents (though we can still flag it as risky).

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, 
Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Michael]

Michael added subscribers: Ladsgroup, Michael.
Michael added a comment.


  In T252595#6498006 , 
@Addshore wrote:
  
  > @toan and I had a chat about this ticket this morning and summarized we 
said that:
  >
  > - For formatter cache version patches need a few tweaks but all look like 
the right direction
  >   - We have never tried "dumping" the whole formatter cache at once before, 
but predict that it should just result in a small spike in slowness (and more 
db load) as the first spike of repopulation gets dealt with and then a long 
small tail
  >   - One thing that came up was that using WANCache inside the formatter 
cache would probably result in a slightly better internal situation when and if 
this were to happen.
  >   - It will be very hard to figure out what any of this would look like in 
advance of trying it.
  >   - One thing that could be done to make possible usage less interesting 
would be some sort of % based rollout of the new version.
  
  In his analysis of Wikidata S8 database load in T246415#6474756 
 @Ladsgroup wrote:
  
  > 56% of the total load is term store (and it's heavily cached, this is 
actually 1% of the actual amount of read that reaches to the database, this is 
scary).
  
  Considering that insight, throwing the entire cache for Terms away in one go 
would seem to be a very bold move. Can we make that "% based rollout of the new 
version" with our current setup and config, or are code change needed to make 
this possible?
  
  At the very least, the patch that introduces the new formatter version (and 
possibly invalidates the current keys in the process?) should probably be 
flagged as a risky patch to watch out for during the next deployment.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, Michael
Cc: Michael, Ladsgroup, Pablo-WMDE, toan, Aklapper, Addshore, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Pablo-WMDE]

Pablo-WMDE reassigned this task from Pablo-WMDE to toan.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, Pablo-WMDE
Cc: Pablo-WMDE, toan, Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, 
CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, 
Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Pablo-WMDE]

Pablo-WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: toan, Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[toan]

toan claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan
Cc: toan, Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[toan]

toan removed toan as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan
Cc: toan, Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05).

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, ReleaseTaggerBot
Cc: Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[gerritbot]

gerritbot added a comment.


  Change 630173 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Move the duplicated code into lib and 
use it as a factory on client and repo.
  
  https://gerrit.wikimedia.org/r/630173

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, gerritbot
Cc: Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Addshore]

Addshore added a comment.


  @toan and I had a chat about this ticket this morning and summarized we said 
that:
  
  - For formatter cache version patches need a few tweaks but all look like the 
right direction
- We have never tried "dumping" the whole formatter cache at once before, 
but predict that it should just result in a small spike in slowness (and more 
db load) as the first spike of repopulation gets dealt with and then a long 
small tail
- One thing that came up was that using WANCache inside the formatter cache 
would probably result in a slightly better internal situation when and if this 
were to happen.
- It will be very hard to figure out what any of this would look like in 
advance of trying it.
- One thing that could be done to make possible usage less interesting 
would be some sort of % based rollout of the new version.
  
  Regarding the idea of allowing action=purge to purge the formatter cache:
  
  - We discussed this on the client side
- The usage tracking mechanisms don't have an index on page_id, so getting 
from the page to the entities used would not be ideal.
- We also doubted the value in this approach given the main issue is when 
incident happen, and in this case the formatter cache version would need to be 
incremented instead.
  - We also discussed this on the repo side
- This would be easier, but less useful.
- Purging the formatter cache for Q64 when doing action=purge on Q64 is 
odd, as that cache is not actually used in the page rendering at all.
  
  Perhaps we could look at the above ideas further if we ever need more 
solutions in this area, but for now not having them is probably fine, as we 
have a version key in the cache key now.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, Addshore
Cc: Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[gerritbot]

gerritbot added a comment.


  Change 630188 had a related patch set uploaded (by Tobias Andersson; owner: 
Tobias Andersson):
  [mediawiki/extensions/Wikibase@master] Add formatter cache version and a 
script to manage this from repo.
  
  https://gerrit.wikimedia.org/r/630188

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, gerritbot
Cc: Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[gerritbot]

gerritbot added a comment.


  Change 630173 had a related patch set uploaded (by Tobias Andersson; owner: 
Tobias Andersson):
  [mediawiki/extensions/Wikibase@master] Move the duplicated code into lib and 
use it as a factory on client and repo.
  
  https://gerrit.wikimedia.org/r/630173

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, gerritbot
Cc: Aklapper, Addshore, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, 
jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan, gerritbot
Cc: Aklapper, Addshore, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
jijiki, Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[toan]

toan claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan
Cc: Aklapper, Addshore, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, 
jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[WMDE-leszek]

WMDE-leszek edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Aklapper, Addshore, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, 
jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Addshore]

Addshore edited projects, added Wikidata-Campsite; removed Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞).

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Aklapper, Addshore, Akuckartz, darthmon_wmde, Nandana, jijiki, 
Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, elukey, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Jay8g, Iflorez, alaa_wmde
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T252595: Consider ways to invalidate FormatterCache when things go wrong

[Addshore]

Addshore edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T252595

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Aklapper, Addshore, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, 
jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs