[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Arian_Bozorg]

Arian_Bozorg closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Arian_Bozorg, Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, 
Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Arian_Bozorg]

Arian_Bozorg added a comment.


  Hi all,
  
  Based on the discussion here we are going to close the ticket. If you 
*strongly* disagree please feel free to reopen the ticket.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Arian_Bozorg, Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, 
Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Michael]

Michael removed projects: Patch-For-Review, User-Michael.
Michael moved this task from Peer Review to Product Verification on the 
Wikidata Dev Team (Sprint-∞) board.
Michael removed Michael as the assignee of this task.
Michael added a comment.


  I'm closing the open PRs, and am handing this over to product.
  
  It will be easy to reopen those PRs and continue work on them, in case we 
want to change something after all.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[gerritbot]

gerritbot added a comment.


  Change 857705 **abandoned** by Michael Große:
  
  [mediawiki/extensions/WikibaseLexeme@master] Ensure that infopanel comes 
directly after main app in tab-order
  
  Reason:
  
  We probably don't want to do this after all (this discussion in task)
  
  https://gerrit.wikimedia.org/r/857705

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Sarai-WMDE]

Sarai-WMDE added a comment.


  In T322686#8401616 , 
@Sarai-WMDE wrote:
  
  >> You can actually create the lexeme without tabbing out of the lexical 
category field at all, by pressing Enter there.
  >
  > Probably @Nikki (like myself) wasn't aware of this behavior, which removes 
the need to actually tab and select the button in order to submit the form. I 
think the tab order modifications we were considering to solve this ticket are, 
after all, unnecessary (for now) in a context where the form can be submitted 
implicitly, from any input (once the form is filled). With Nikki's and 
@Lydia_Pintscher's permission: I'd say we can resolve this task?
  
  Hi, @Nikki   We believe this task can be resolved, but would appreciate 
your input. Thanks a bunch!

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T322686#8400106 , 
@Michael wrote:
  
  > That's not the intended tab-flow #328 + Ensure that infopanel comes 
directly after main app in tab-order (Ia8f374ae) 
.
 I will have to look into that again o.O
  
  Sorry, I might’ve done something wrong when taking the screenshots. Feel free 
to ping me if you want to look at it together…

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Sarai-WMDE]

Sarai-WMDE added a comment.


  > You can actually create the lexeme without tabbing out of the lexical 
category field at all, by pressing Enter there.
  
  Probably @Nikki (like myself) wasn't aware of this behavior, which removes 
the need to actually tab and select the button in order to submit the form. I 
think the tab order modifications we were considering to solve this ticket are, 
after all, unnecessary (for now) in a context where the form can be submitted 
implicitly, from its last input.
  This is probably behind this other piece of feedback, documented in T322684: 
keyboard navigation issues on Special:NewLexeme 
:
  
  > Pressing enter after entering a language name or lexical category tries to 
submit the form instead of selecting the top entry.
  
  In that case, one needs to highlight the match from the menu and then press 
enter to make a selection/fill the input. Pressing enter on the input without 
having made a selection will, as I now understand, try to submit the form.
  
  Now, coming back to the UX perspective on this: my concern is that applying 
this standard to certain contexts (like, probably, the NewLexeme form) can be 
problematic. Implicit behavior is not discoverable and might be, as mentioned, 
a source of unwanted results. There's only so much validation can do to prevent 
unintentional submissions. Now, based on the context that Michael and Noa 
kindly provided (https://phabricator.wikimedia.org/T305359#7955779), this 
behavior is backed by current patterns (throughout WD and the web), and I also 
understand the clear accessibility value of this practice (it allows screen 
reader users to move faster). I wonder, though, if it would be a good idea to 
keep an eye on more complex forms like the one we have in our hands: it'd be 
great to track unwanted submissions (e.g. request for deletion of lexemes 
created on enter) or at least keep our ears peeled for feedback related to this 
behavior.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[noarave]

noarave added a comment.


  > What motivated this decision?
  
  I think this is the context in which this was decided: 
https://phabricator.wikimedia.org/T305359#7955779
  It is consistent with other parts of Wikidata, but i remembered we scrambled 
over this quite a bit.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, noarave
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Sarai-WMDE]

Sarai-WMDE added a comment.


  > You can actually create the lexeme without tabbing out of the lexical 
category field at all, by pressing Enter there.
  
  Oh wow. Ok, that actually removes the extra tabbing inconvenience for heavy 
keyboard users entirely. At the same time, this sounds quite error prone...What 
motivated this decision? Are we tracking how many invalid Lexemes (e.g. require 
deletion) are being submitted this way?

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Michael]

Michael added a comment.


  That's not the intended tab-flow #328 + Ensure that infopanel comes directly 
after main app in tab-order (Ia8f374ae) 
.
 I will have to look into that again 廊

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > Again, no solution seems to be perfect, and I feel that responding to this 
request is actually making us apply antipatterns and modifying a perfectly 
valid default tab flow.
  
  I feel the same way, to be honest… I think leaving the tab order as it is 
might be better than either of the two approaches? (You can actually create the 
lexeme without tabbing out of the lexical category field at all, by pressing 
Enter there.)
  
  This is the tab order with #328 
 (`fixTabOrder` 
branch) + the above Gerrit change :
  F35786862: image.png 
  
  And this is the tab order with #329 
 
(`keyboardSkipLicense` branch):
  {F35786874}
  
  (Edited to fix the second screenshot, sorry.)

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[gerritbot]

gerritbot added a comment.


  Change 857705 had a related patch set uploaded (by Michael Große; author: 
Michael Große):
  
  [mediawiki/extensions/WikibaseLexeme@master] Ensure that infopanel comes 
directly after main app in tab-order
  
  https://gerrit.wikimedia.org/r/857705

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Sarai-WMDE]

Sarai-WMDE attached a referenced file: F35786262: Nov-16-2022 15-33-34.gif.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Sarai-WMDE]

Sarai-WMDE attached a referenced file: F35786452: Group 1.png.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Sarai-WMDE]

Sarai-WMDE added a comment.


  I see your point. But the outcome of modifying the default tab order as a 
result of the changes applied via #328 
 is disrupting the 
page's structure and navigation order for both keyboard and screen reader users:
  
  F35786103: Nov-16-2022 14-49-22.gif 

  
  In a more recent attempt, I seem to abandon the page entirely when following 
the new tab flow (VoiceOver announces: "Leaving new Lexeme" when tabbing away 
from the last link):
  
  F35786173: Nov-16-2022 15-13-00.gif 

  
  I'd like to explore this direction and prevent completely hiding the links 
from the tab order (which I understand the problematic side of). Will be 
working on outlining an alternative tab flow.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Michael]

Michael added a comment.


  > Subtracting interactive elements from the flow (using `tabindex=-1`) is 
definitely not ideal either, but has a smaller impact/override effect on the 
overall navigation flow.
  
  Why?
  
  I might agree with this //if// those elements are actually still reliably 
reachable in a different way. I think we so far have established this to be the 
case for the VoiceOver screen reader, and I also just now verified it for the 
Orca screen reader on Linux. However, NVDA and JAWS, the most common screen 
readers, still need to be tested.
  If they also work with the `tabindex=-1` solution, then I'd be unhappily ok 
with picking that. (We'd only be making it completely inaccessible to people 
who are forced to use the keyboard, but are not using screen readers, because 
they are still sighted)
  
  But otherwise, the solution still accessible to everyone is to adjust the tab 
order, which is also what the foundation uses (For example when you click 
"Edit" on the very article that Noa linked).

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Sarai-WMDE]

Sarai-WMDE added a comment.


  In T322686#8399322 , 
@Michael wrote:
  
  >> Add tabindex=-1 to the copyright/terms of use links (this seems to be the 
preferred way a11y-wise )
  >
  > I think, I would challenge that notion in that generality. Would be nice to 
hear more about the reasoning behind that statement.
  
  As stated in the guidelines linked by Noa, from an accessibility perspective 
"DOM order is preferred wherever possible", and thus `tabindex` > 0 should be 
avoided to not interfere with that default flow. Subtracting interactive 
elements from the flow (using `tabindex=-1`) is definitely not ideal either, 
but has a smaller impact/override effect on the overall navigation flow).

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Sarai-WMDE
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Michael]

Michael added a comment.


  Now we have two PRs up that show-case the different options:
  
  - https://github.com/wmde/new-lexeme-special-page/pull/328 (move inputs and 
create lexeme button to the beginning of the tab-order)
  - https://github.com/wmde/new-lexeme-special-page/pull/329 (make Terms of Use 
and License unreachable by tab)

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Michael]

Michael claimed this task.
Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team 
(Sprint-∞) board.
Michael added a comment.
Restricted Application added a project: User-Michael.


  > Add tabindex=-1 to the copyright/terms of use links (this seems to be the 
preferred way a11y-wise )
  
  I think, I would challenge that notion in that generality. Would be nice to 
hear more about the reasoning behind that statement.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, 
Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[noarave]

noarave added a comment.


  **Task breakdown notes:**
  
  - We see two possible ways forward with this:
1. Add tabindex=-1 to the copyright/terms of use links (this seems to be 
the preferred way a11y-wise 
 )
2. Add positive tabindexes to the input fields and the button
  
  The plan of action in this case would be to try out the option and then 
decide.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, Nikki, 
Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lydia_Pintscher]

Lydia_Pintscher moved this task from Unified prioritized backlog to Sprint-∞ on 
the Wikidata Dev Team board.
Lydia_Pintscher edited projects, added Wikidata Dev Team (Sprint-∞); removed 
Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T322686#8390013 , 
@mrephabricator wrote:
  
  > I will point out that the terms and conditions section does not actually 
render as intended in every locale. For pnb it shows raw wiki markup and the 
links do not resolve.
  
  (This unrelated issue is now T322946 
.)

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lydia_Pintscher]

Lydia_Pintscher set the point value for this task to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[mrephabricator]

mrephabricator added a comment.


  I will point out that the terms and conditions section does not actually 
render as intended in every locale. For pnb it shows raw wiki markup and the 
links do not resolve.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: mrephabricator
Cc: mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Hello there. There's no perfect solution for this: If we placed the text 
below the button, we would risk hiding the conditions from screen reader users 
(and making them easier to ignore, due to reading order, for everyone else). I 
think we should follow the usual approach (see source edit pages in enwiki) and 
keep the conditions text above the 'Create Lexeme' button, reflecting the 
recommended/logical reading order.
  
  Now, I've noticed that source edit pages on Wikipedia exclude terms and 
conditions links from the tab flow (i.e. so one moves directly to the 'Publish 
changes' button when tabbing from the last checkbox – 'Watch this page'). This 
is a solution that would solve the issue risen by this ticket. Nevertheless, 
I'm not sure whether this is totally friendly for people with reduced mobility, 
so we should be aware of this potential compromise.
  
  F35754907: Nov-11-2022 17-21-03.gif 

  
  In order to easily remove the copyright message links from the tab flow, 
while keeping them accessible via screen reader (using control key), we could 
apply `tabindex=-1` to them:
  
  F35754891: Nov-11-2022 17-18-22.gif 


TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lydia_Pintscher]

Lydia_Pintscher triaged this task as "High" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

[Lydia_Pintscher]

Lydia_Pintscher created this task.
Lydia_Pintscher added projects: Special:NewLexeme revival, Wikidata 
Lexicographical data, Wikidata Dev Team, Wikidata.

TASK DESCRIPTION
  **Problem:**
  The terms of use/license info text is between the input fields and the submit 
button. The current tab order now means that in most browsers, you now have to 
tab three times to get from the lexical category field to the submit button.
  
  **Screenshots/mockups:**
  F35722293: image.png 
  
  **Acceptance criteria:**
  
  [ ] tab order has been improved
  
  **Open questions:**
  
  - What should the order be?
  - Should we just move the text below the button?

TASK DETAIL
  https://phabricator.wikimedia.org/T322686

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org