hoo claimed this task. hoo added subscribers: aude, daniel, Anomie. hoo added projects: MediaWiki-extensions-AbuseFilter, MediaWiki-API. hoo added a comment.
The problem here got visible with @aude's https://phabricator.wikimedia.org/rMWa225cbdca89563e878c19580fb04c9e1d805d6c7 which made it possible to use `ApiEditPage` for undoing edits on entity content. `ApiEditPage` always runs `APIEditBeforeSave`, even when undoing an edit. That is inconsistent with for example `EditFilterMergedContent`. I see two ways to fix this: - Don't run the hook on undo (this is a breaking change, but would make the behavior consistent with `EditFilterMergedContent`) - Make AbuseFilter ignore undos coming in via that hook Whatever we chose to do, we should document the new behavior of the hook properly (right now its not obvious whether it's supposed to run on undo or not). TASK DETAIL https://phabricator.wikimedia.org/T126861 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: Anomie, daniel, aude, Ricordisamoa, Lydia_Pintscher, hoo, Aklapper, StudiesWorld, matej_suchanek, dg711, Izno, Luke081515, Wikidata-bugs, jayvdb, Se4598, Jackmcbarn, Mbch331, Legoktm _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
