gerritbot added a comment.
Change 218308 had a related patch set uploaded (by Aude):
Increase max conflicts returned for conflict detections
https://gerrit.wikimedia.org/r/218308
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
gerritbot added a comment.
Change 218308 merged by jenkins-bot:
Increase max conflicts returned for conflict detections
https://gerrit.wikimedia.org/r/218308
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
aude added a comment.
deployed the fix to wikidata.
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: aude
Cc: Candalua, Bugreporter, gerritbot, aude, Bene, daniel, Aklapper,
Lydia_Pintscher,
gerritbot added a comment.
Change 218351 merged by jenkins-bot:
Update Wikidata - fix property label constraint bug
https://gerrit.wikimedia.org/r/218351
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
gerritbot added a comment.
Change 218351 had a related patch set uploaded (by Aude):
Update Wikidata - fix property label constraint bug
https://gerrit.wikimedia.org/r/218351
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
aude added a comment.
@daniel can backport it tomorrow, and totally agree about the *real* fix.
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: aude
Cc: Candalua, Bugreporter, Liuxinyu970226,
daniel added a comment.
I can only add that I, too, am quite confused. I can' t reproduce the issue
locally, nor can I think of a way for this to happen, except for extreme slave
lag. The uniqueness checks are run against the slave database. This is
something we could change, and it has the
Bene added a comment.
See also http://quarry.wmflabs.org/query/3972: it is possible that the same
label gets tracked in wb_terms twice.
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Bene
Cc:
aude added a subscriber: aude.
aude added a comment.
this is the query that is run and it is quite fast:
select term_entity_type,term_type,term_language,term_text,term_entity_id
FROM `wb_terms` WHERE ((term_language='en' AND term_search_key='title' AND
term_type='label' AND
Bene added a comment.
The query posted by @aude gives us the expected result (cf.
http://quarry.wmflabs.org/query/3973)
It seems that also label-description duplicates are possible:
https://www.wikidata.org/w/index.php?title=Property%3AP357type=revisiondiff=222062411oldid=222000959
TASK
daniel added a comment.
@bene: yes, this is no database level constraint, so it's possible on that
level. The question is just, how does it happen? Our business logic (the
uniqueness validators) should prevent that.
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
daniel added a comment.
@aude I think you got that exactly right! Ouch. That was my fault. I somehow
got it in my head that 10 conflicting items would always be sufficient. But it
was 10 conflicting terms, which of course may all be self-conflicts.
The reason I introduced the post-filtering
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 217849 had a related patch set uploaded (by Aude):
Increase max conflicts returned for conflict detections
https://gerrit.wikimedia.org/r/217849
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
aude added a comment.
What I see is that LabelUniquenessValidator requests all conflicting labels (in
all languages), including self-conflicts on the same item, then filters out
self-conflicts.
TermSqlIndex is what detects conflicts and it returns a maximum of 10
conflicts. If these are all
Bene added a comment.
What are those self-conflicts actually? How can a label be found more than
once? Don't we filter by entity type? Also, why don't we just filter out
self-conflicts in the where clause?
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
gerritbot added a comment.
Change 217849 merged by jenkins-bot:
Increase max conflicts returned for conflict detections
https://gerrit.wikimedia.org/r/217849
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
aude added a comment.
@bene terms being searched for conflicts included:
array (
'fr' = 'titre (OBSOLETE - P1476)',
'en' = '(OBSOLETE) title (use P1476, title)',
'ja' = '題名 ＊廃止（P1476を使用）',
'nl' = '(VEROUDERD) titel van publicatie',
'it' = '(obsoleta) titolo (usare P1476)',
Bene added a comment.
As far as I can see the terms table contains the correct terms and search keys
so I wonder how my edits could pass the uniqueness filters.
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
Bene added a comment.
Note that this issue does not happen on test.wikidata.org. You can play around
with https://test.wikidata.org/wiki/Property:P155 and
https://test.wikidata.org/wiki/Property:P164. When entering the same label on
both properties, I get the expected error message.
TASK
Lydia_Pintscher added a comment.
Is it possibly related to the fact that we are trying to edit an already
conflicting label?
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lydia_Pintscher
Cc:
Lydia_Pintscher added a comment.
Do I read those queries correctly that the terms table has them differently?
TASK DETAIL
https://phabricator.wikimedia.org/T102148
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lydia_Pintscher
Cc: Bene, daniel,
21 matches
Mail list logo
