Jdlrobson added a comment.
Using the mechanism in https://gerrit.wikimedia.org/r/#/c/238654/ we should be
able to inject it under the revisions... in theory... not sure how problematic
not having this is to the community in the meantime.
TASK DETAIL
https://phabricator.wikimedia.org/T110384
Jdlrobson added a comment.
Mmm... is there any way we can add it when encountered rather than use
prependHtml?
I guess this will cause problems with multiple uses of the banner code or
adding a banner at the bottom of the page causing it to render at the bottom?
How does the diff get added?
Nicolas_Raoul added a comment.
From a user experience point of view, I agree with Tgr that the banner should
appear between the diff (or source edit box) and the actual page content, so
that the preview is as close to reality as possible.
TASK DETAIL
Sumit added a comment.
Banner has been showing above diff because by nature it is meant to be the
first element of page body. For this it uses OutputPage::prependHtml() on page
body. In case of a diff, it does not distinguish it from other content.
TASK DETAIL
Tgr added a subscriber: Tgr.
Tgr added a comment.
Is that a good idea? Patrolling changes to the pagebanner parameters seems kind
of annoying without seeing the effect. The banner should be on top of the
article, not top of the page, but otherwise it seems useful to have it.
TASK DETAIL
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 235492 had a related patch set uploaded (by Sumit):
WikidataPageBanner disable on diff pages
https://gerrit.wikimedia.org/r/235492
TASK DETAIL
https://phabricator.wikimedia.org/T110384
EMAIL PREFERENCES
gerritbot added a comment.
Change 235492 merged by jenkins-bot:
WikidataPageBanner disable on diff pages
https://gerrit.wikimedia.org/r/235492
TASK DETAIL
https://phabricator.wikimedia.org/T110384
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
Sumit added a subscriber: Sumit.
Sumit added a comment.
Is there a way to detect that we are viewing a diff page, other than resorting
to **ArticleContentOnDiff** hook.
TASK DETAIL
https://phabricator.wikimedia.org/T110384
EMAIL PREFERENCES
Jdlrobson added a comment.
You could check for the existence of the diff parameter that should be enough.
$diff = $request->getVal( 'diff' );
TASK DETAIL
https://phabricator.wikimedia.org/T110384
EMAIL PREFERENCES
