gerritbot added a comment.
Change 434193 abandoned by Jdlrobson:
Add a "standard" compatible wikidata summary endpoint
https://gerrit.wikimedia.org/r/434193
TASK DETAIL
https://phabricator.wikimedia.org/T111231
EMAIL PREFERENCES
Lydia_Pintscher added a comment.
We said it'd be nice to display the number of statements and sitelinks in order to give people a quick way to see how "good/useful" the item behind the link is. If you see an item has no sitelinks and statements then it's probably not worth clicking because it'll
Jdlrobson added a comment.
Happy to chat through this. No rush. Please let me know if you would like me to attend any services sync relating to this. It feels like we have a few things to work out with the accept-language header before this patch is ready anyway.TASK
bearND added a comment.
@Jdlrobson As long as you and @phuedx agree on what it should be and it's all in sync with the documentation that sounds all fine to me. It's certainly fine to introduce the new type in a later patch.
#Services: The current version of the patch takes the accept-language
Jdlrobson added a comment.
@bearND I've clarified in the commit that this is seen as iterative and the goal for https://gerrit.wikimedia.org/r/434193 is to be compatible with the standard endpoint. Doing this would allow us to begin experimentation on the beta cluster
I've written a POC to
Jdlrobson added a comment.
Long term we'll probably want to add a 'type' 'wikidata' to https://www.mediawiki.org/wiki/Page_Previews/API_Specification rather than lean on the 'standard' type
The first iteration of the patch implements yhe
I am happy to drop sitelinks and claims on the short term
bearND added a comment.
@Jdlrobson Thanks for the updated patch!
@Jdlrobson @phuedx I see some discrepancies between https://www.mediawiki.org/wiki/Page_Previews/API_Specification and this task description.
"type": "wikidata" vs "wikidata_preview"
Extra attributes: number of sitelinks and
gerritbot added a comment.
Change 434193 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/services/mobileapps@master] Add a wikidata summary endpoint
https://gerrit.wikimedia.org/r/434193TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL
Jdlrobson added a comment.
I worked on this during the hackathon.
This seems relatively straightforward. It needs a new endpoint (POC=https://gerrit.wikimedia.org/r/434193 WIP: Add a wikidata summary endpoint) and configuration like so ($wgPopupsRestGatewayEndpoint =
Jdlrobson added a comment.
http://jdlrobson.com/DEMO2.movTASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude,
ovasileva added a comment.
@Jdlrobson - upload video hereTASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ovasilevaCc: ovasileva, Lucas_Werkmeister_WMDE, Mholloway, Sjoerddebruin, Pchelolo, pmiazga, aude,
Lydia_Pintscher added a comment.
The reason is that labels are what represents a concept. They are used in all kinds of places. They need to have "proper" casing in order to make them usable in all contexts.
I am not sure what you mean by differentiating display of content and content in this
Nirzar added a comment.
@Lydia_Pintscher what is the primary reason for doing that? also is there a way we can differentiate display of content and content itself?TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL
Lydia_Pintscher added a comment.
Yes. The community is spending quite some time explaining to people that labels and descriptions should not start with a capital letter (unless it is a proper noun). If we're showing people the opposite a lot in page previews that'll cause more people to do it
Nirzar added a comment.
We use sentence-case for articles, ui elements, and most of the in-product communication as well. ugly seems like a subjective opinion, unless there is an objective reason for changing our conventions, I would avoid making it lowercase.
Some relevant information about the
Sjoerddebruin added a comment.
Oh yes, sorry. I mean that indeed.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer,
Nirzar added a comment.
you mean titlecase?TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NirzarCc: Sjoerddebruin, Pchelolo, bmansurov, pmiazga, aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson,
Sjoerddebruin added a comment.
Are you actually deciding on making all titles uppercase? I still think that is a ugly design choice.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc:
Nirzar added a comment.
This is barebones page previews for wikidata. it only has item title and description.
F8453797: missing desc.png
F8453796: only desc.png
F8453795: missing desc with image.png
I would like for us to investigate more into relevant and useful metadata that we can surface,
Jdlrobson added a comment.
Needs mock from Nirzar to show how this looks.TASK DETAILhttps://phabricator.wikimedia.org/T111231EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: aude, Nirzar, Tbayer, CKoerner_WMF, Yurik, phuedx, Jdlrobson,
20 matches
Mail list logo
