[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox because of rate limit?

2016-06-13 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a comment.Looking at the actual screenshots on Saucelabs, e.g. https://assets.saucelabs.com/jobs/e6cd0f782ac54c04bfaa75923bff8f00/0022screenshot.png suggested that it is a problem with the corresponding article on beta Wikipedia. I've just checked that, and indeed the article "Test" was not existing on German beta Wikipedia. I've re-created it, and I assume this test failure is fixed now.
However, as I've stated before, we need to make the test more robust, e.g. by ensuring the used test data does actually exist. We could do this in an extra Given-step.TASK DETAILhttps://phabricator.wikimedia.org/T126585EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tobi_WMDE_SWCc: hoo, gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, Aklapper, D3r1ck01, Izno, Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-18 Thread adrianheine 
adrianheine added a comment.


  I checked again: This works locally.

TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: hoo, gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, 
Aklapper, Izno, Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-17 Thread adrianheine 
adrianheine added a comment.

Locally this failed because of rate limiting and stopped failing after I 
changed config. I'll try again locally.


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: hoo, gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, 
Aklapper, Izno, Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-17 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a comment.

The failures seem unrelated to this. It seems that the some of the articles 
used for testing do not really exist on the corresponding test wikis. Either we 
need to change the test data or ideally make the test cases more robust.


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tobi_WMDE_SW
Cc: hoo, gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, 
Aklapper, Izno, Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-16 Thread adrianheine 
adrianheine added a comment.

Not fixed :/


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: hoo, gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, 
Aklapper, Izno, Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-16 Thread hoo 
hoo added a subscriber: hoo.
hoo added a comment.

Change deployed, please verify.


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: hoo, gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, 
Aklapper, Izno, Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-16 Thread gerritbot 
gerritbot added a comment.

Change 269944 merged by jenkins-bot:
Exclude Sauce Labs IP ranges from rate limits on beta

https://gerrit.wikimedia.org/r/269944


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, 
Aklapper, Izno, Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-11 Thread Addshore 
Addshore added a subscriber: Addshore.
Addshore added a comment.

Probably something relating to 
https://www.mediawiki.org/wiki/Manual:$wgRateLimits ?


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, adrianheine, Aklapper, Izno, Wikidata-bugs, aude, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-11 Thread adrianheine 
adrianheine added a comment.

This is a rate limiting problem. Whenever the test fails, I have the following 
in my debug log:

  [ratelimit] User '0:0:0:0:0:0:0:1' (IP ::1) tripped 
my_wiki:limiter:edit:ip:%3A%3A1 at 8 (limit 8 in 60s)


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: adrianheine
Cc: adrianheine, Aklapper, Izno, Wikidata-bugs, aude, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-11 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 269944 had a related patch set uploaded (by Aude):
Exclude Sauce Labs IP ranges from rate limits on beta

https://gerrit.wikimedia.org/r/269944


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, 
Aklapper, Izno, Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-11 Thread aude 
aude added a comment.

do we need more than saucelabs ip range for this? e.g. our office IP range if 
we run these also from the office?


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, Aklapper, Izno, 
Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T126585: Sitelink browser test sometimes fails with firefox

2016-02-11 Thread aude 
aude added a comment.

I think 
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings-labs.php#L555-L557
 is where this can be set.

https://webcache.googleusercontent.com/search?q=cache:4MupWMgYdcEJ:https://support.saucelabs.com/customer/en/portal/questions/13054963
 tells us their ip range, current of at least December.


TASK DETAIL
  https://phabricator.wikimedia.org/T126585

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aude
Cc: aude, JanZerebecki, Tobi_WMDE_SW, Addshore, adrianheine, Aklapper, Izno, 
Wikidata-bugs, Mbch331, greg



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs