gerritbot added a comment.
Change 405925 merged by jenkins-bot:
[mediawiki/core@master] ExtensionRegistry: Properly detect if a global is already set
https://gerrit.wikimedia.org/r/405925TASK DETAILhttps://phabricator.wikimedia.org/T128661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings
hoo added a comment.
Looked into this some more:
wfLoadExtension only enqueues loading the extension in question, but doesn't actually load it. The actual extension loading only happens later on in Setup.php. Usually that's fine, ExtensionRegistry is not overwriting any explicitly given globals…
gerritbot added a comment.
Change 405925 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/core@master] ExtensionRegistry: Properly detect if a global is already set
https://gerrit.wikimedia.org/r/405925TASK DETAILhttps://phabricator.wikimedia.org/T128661EMAIL PREFERENCESht
hoo added a comment.
This is indeed still a problem:
hoo@terbium:~$ mwscript eval.php --wiki commonswiki
> var_dump($wgWikimediaBadgesCommonsCategoryProperty);
string(4) "P373
The extension is now loaded (via wfLoadExtension( 'WikimediaBadges' );) before the setting is set to null, thus this is (
matej_suchanek added a comment.
Still happens, T173818 did no magic.TASK DETAILhttps://phabricator.wikimedia.org/T128661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, matej_suchanekCc: matej_suchanek, SandraF_WMF, Lydia_Pintscher, Multichill, Framawiki,
hoo added a comment.
In order to fix this, the extension needs to be explicitly loaded via the Wikidata.php entry point in the Wikidata extension.TASK DETAILhttps://phabricator.wikimedia.org/T128661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: SandraF
Stashbot added a comment.
Mentioned in SAL [2016-03-03T00:10:00Z] Synchronized
wmf-config/Wikibase-production.php: Set
$wgWikimediaBadgesCommonsCategoryProperty to null on commons
(https://phabricator.wikimedia.org/T128661) (duration: 01m 09s)
TASK DETAIL
https://phabricator.wikimedia.or
gerritbot added a comment.
Change 274506 merged by jenkins-bot:
Set $wgWikimediaBadgesCommonsCategoryProperty to null on commons
https://gerrit.wikimedia.org/r/274506
TASK DETAIL
https://phabricator.wikimedia.org/T128661
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/
gerritbot added a comment.
Change 274506 had a related patch set uploaded (by Hoo man):
Set $wgWikimediaBadgesCommonsCategoryProperty to null on commons
https://gerrit.wikimedia.org/r/274506
TASK DETAIL
https://phabricator.wikimedia.org/T128661
EMAIL PREFERENCES
https://phabricator
