[Wikidata-bugs] [Maniphest] [Commented On] T138627: Enable WDQS admins to enable/disable updater service

2016-06-29 Thread Dzahn 
Dzahn added a comment.
Patch needs to be amended to reflect the latest comments?TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DzahnCc: Dzahn, akosiaris, gerritbot, Zppix, JanZerebecki, Aklapper, Gehel, Smalyshev, Avner, Lewizho99, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, mark, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T138627: Enable WDQS admins to enable/disable updater service

2016-06-29 Thread akosiaris 
akosiaris added a comment.
I support that as well. The code in wdqs::updater should probably anyway be amended to use base::service_unit at some point, at which point the question of whether puppet should also manage a service resource will probably be posed. We would at least be ready from that point of view.TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: akosiarisCc: akosiaris, gerritbot, Zppix, JanZerebecki, Aklapper, Gehel, Smalyshev, Avner, Lewizho99, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, mark, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T138627: Enable WDQS admins to enable/disable updater service

2016-06-28 Thread Smalyshev 
Smalyshev added a comment.
I'm fine with that.TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: akosiaris, gerritbot, Zppix, JanZerebecki, Aklapper, Gehel, Smalyshev, Avner, Lewizho99, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, mark, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T138627: Enable WDQS admins to enable/disable updater service

2016-06-28 Thread Gehel 
Gehel added a comment.
Some discussion with Stas to clarify the need:


We do not declare a service in puppet, so puppet will not restart that service. This is on purpose, as we don't want updater to start before the initial import is done. This might be improved at some point.
As in this case, there is nothing that will restart that service except a server reboot, mask/unmask does not bring anything more than enable/disable.
The wdqs puppet module also supports upstart, but this is used only in labs, so can be ignored for the purpose of this discussion.


I'd be inclined to grant both mask/unmask and enable/disable as I don't think it adds much possibility for abuse and will let us see what the actual useage is.TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: GehelCc: akosiaris, gerritbot, Zppix, JanZerebecki, Aklapper, Gehel, Smalyshev, Avner, Lewizho99, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, mark, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T138627: Enable WDQS admins to enable/disable updater service

2016-06-28 Thread Smalyshev 
Smalyshev added a comment.
Maybe I misunderstand what mask/unmask does, but I though it disables service completely. That's not what I need. What I need is to either make it start on boot automatically (when data is loaded) or not start on boot (when data is not loaded). Isn't that what enable/disable does? Documentation seems to say so.TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: akosiaris, gerritbot, Zppix, JanZerebecki, Aklapper, Gehel, Smalyshev, Avner, Lewizho99, Maathavan, debt, D3r1ck01, Jonas, FloNight, Xmlizer, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, mark, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T138627: Enable WDQS admins to enable/disable updater service

2016-06-24 Thread gerritbot 
gerritbot added a comment.
Change 295968 had a related patch set uploaded (by Smalyshev):
Allow wdqs admins to control wdqs-updater service

https://gerrit.wikimedia.org/r/295968TASK DETAILhttps://phabricator.wikimedia.org/T138627EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Zppix, JanZerebecki, Aklapper, Gehel, Smalyshev, Avner, debt, D3r1ck01, Jonas, FloNight, Izno, jkroll, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, mark, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs