[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-30 Thread Jonas 
Jonas added a comment.

In T145932#4453638, @Lydia_Pintscher wrote:

The error message currently says "Must be no more than 250 characters long". Can we make that a proper sentence? "The Label must not be more than 250 characters long."? (And the same for Alias and Description.)  Or if splitting it is too hard then "The input must not be more than 250 characters long."



This is the message key used in the validator that is why it also appears in our current API and UI.
F24332368: image.png

I would suggest to create a new ticket to change the message also in those other places.TASK DETAILhttps://phabricator.wikimedia.org/T145932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: gerritbot, Addshore, Gstupp, Liuxinyu970226, Thryduulf, Mbch331, Sjoerddebruin, Aklapper, hoo, aude, daniel, Lydia_Pintscher, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, Dinoguy1000, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-28 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.
Ok cool. Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T145932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Lydia_PintscherCc: gerritbot, Addshore, Gstupp, Liuxinyu970226, Thryduulf, Mbch331, Sjoerddebruin, Aklapper, hoo, aude, daniel, Lydia_Pintscher, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, Dinoguy1000, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-27 Thread thiemowmde 
thiemowmde added a comment.
Are we really checking characters? I seem to remember something else but am not entirely sure.

The StringLengthValidator responsible for these checks allows to specify if it should count bytes (strlen) or characters (mb_strlen). In the current code it counts bytes for URLs (including URL values, calendar models, globes, and units), and characters for everything else.TASK DETAILhttps://phabricator.wikimedia.org/T145932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, thiemowmdeCc: gerritbot, Addshore, Gstupp, Liuxinyu970226, Thryduulf, Mbch331, Sjoerddebruin, Aklapper, hoo, aude, daniel, Lydia_Pintscher, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, Dinoguy1000, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-26 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.
\o/

Two things:


The error message currently says "Must be no more than 250 characters long". Can we make that a proper sentence? "The Label must not be more than 250 characters long."? (And the same for Alias and Description.)  Or if splitting it is too hard then "The input must not be more than 250 characters long."
Are we really checking characters? I seem to remember something else but am not entirely sure.
TASK DETAILhttps://phabricator.wikimedia.org/T145932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, Lydia_PintscherCc: gerritbot, Addshore, Gstupp, Liuxinyu970226, Thryduulf, Mbch331, Sjoerddebruin, Aklapper, hoo, aude, daniel, Lydia_Pintscher, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, Dinoguy1000, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-20 Thread gerritbot 
gerritbot added a comment.
Change 446302 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix: Special:NewItem does not validate maximum label length

https://gerrit.wikimedia.org/r/446302TASK DETAILhttps://phabricator.wikimedia.org/T145932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, Addshore, Gstupp, Liuxinyu970226, Thryduulf, Mbch331, Sjoerddebruin, Aklapper, hoo, aude, daniel, Lydia_Pintscher, thiemowmde, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, Dinoguy1000, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-17 Thread gerritbot 
gerritbot added a comment.
Change 446302 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix: Special:NewItem does not validate maximum label length

https://gerrit.wikimedia.org/r/446302TASK DETAILhttps://phabricator.wikimedia.org/T145932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, gerritbotCc: gerritbot, Addshore, Gstupp, Liuxinyu970226, Thryduulf, Mbch331, Sjoerddebruin, Aklapper, hoo, aude, daniel, Lydia_Pintscher, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Jonas, Wikidata-bugs, Dinoguy1000, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-03 Thread daniel 
daniel added a comment.
Isn't that validation in the ChangeOp? Or is the ChangeOp not used?TASK DETAILhttps://phabricator.wikimedia.org/T145932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, danielCc: Addshore, Gstupp, Liuxinyu970226, Thryduulf, Mbch331, Sjoerddebruin, Aklapper, hoo, aude, daniel, Lydia_Pintscher, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, Dinoguy1000, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T145932: [Bug] Special:NewItem does not validate maximum label length

2018-07-03 Thread Addshore 
Addshore added a comment.
The good news is is you provide a value that is too big other things get in the way of it being saved:

eg:

[Wzt3LQpEEj4AAB1omtQF] /wiki/Q479234 RemexHtml\Tokenizer\TokenizerError from line 1486 of /srv/mediawiki/php-master/vendor/wikimedia/remex-html/RemexHtml/Tokenizer/Tokenizer.php: RemexHtml\Tokenizer\Tokenizer: pcre.backtrack_limit exhausted

Backtrace:

#0 /srv/mediawiki/php-master/vendor/wikimedia/remex-html/RemexHtml/Tokenizer/Tokenizer.php(866): RemexHtml\Tokenizer\Tokenizer->throwPregError()
#1 /srv/mediawiki/php-master/vendor/wikimedia/remex-html/RemexHtml/Tokenizer/Tokenizer.php(1011): RemexHtml\Tokenizer\Tokenizer->handleCharRefs(string, integer)
#2 /srv/mediawiki/php-master/vendor/wikimedia/remex-html/RemexHtml/Tokenizer/Tokenizer.php(462): RemexHtml\Tokenizer\Tokenizer->emitDataRange(integer, integer)
#3 /srv/mediawiki/php-master/vendor/wikimedia/remex-html/RemexHtml/Tokenizer/Tokenizer.php(310): RemexHtml\Tokenizer\Tokenizer->dataState(boolean)
#4 /srv/mediawiki/php-master/vendor/wikimedia/remex-html/RemexHtml/Tokenizer/Tokenizer.php(151): RemexHtml\Tokenizer\Tokenizer->executeInternal(boolean)
#5 /srv/mediawiki/php-master/includes/parser/Sanitizer.php(1982): RemexHtml\Tokenizer\Tokenizer->execute()
#6 /srv/mediawiki/php-master/includes/OutputPage.php(998): Sanitizer::stripAllTags(string)
#7 /srv/mediawiki/php-master/includes/page/Article.php(695): OutputPage->setPageTitle(string)
#8 /srv/mediawiki/php-master/includes/page/Article.php(648): Article->adjustDisplayTitle(ParserOutput)
#9 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(79): Article->view()
#10 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(54): Wikibase\ViewEntityAction->showEntityPage()
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(500): Wikibase\ViewEntityAction->show()
#12 /srv/mediawiki/php-master/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(867): MediaWiki->performRequest()
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(524): MediaWiki->main()
#15 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#16 /srv/mediawiki/w/index.php(3): include(string)
#17 {main}TASK DETAILhttps://phabricator.wikimedia.org/T145932EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, AddshoreCc: Addshore, Gstupp, Liuxinyu970226, Thryduulf, Mbch331, Sjoerddebruin, Aklapper, hoo, aude, daniel, Lydia_Pintscher, thiemowmde, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Wikidata-bugs, Dinoguy1000, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs