[Wikidata-bugs] [Maniphest] [Commented On] T150060: Implement functionality for RC page 'Type of change' filters
SBisson added a comment. In T150060#2924130, @jmatazzoni wrote: So, given the above, can we close this ticket? yesTASK DETAILhttps://phabricator.wikimedia.org/T150060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: Etonkovidova, gerritbot, Aklapper, Pginer-WMF, Trizek-WMF, Catrope, Quiddity, Liuxinyu970226, Mattflaschen-WMF, SBisson, jmatazzoni, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T150060: Implement functionality for RC page 'Type of change' filters
jmatazzoni added a comment. The team met about this today and made the following decisions: As per T154486, all Flow edits will be captured by the Page Edits filter. We will NOT distinguish between new Flow topic creations and other flow edits, which means Flow topic creations will not be captured by the Page Creations filter. However, new Flow Topics will continue, as now, to be marked with the N by the system. @SBisson and @Mattflaschen-WMF, let me know if I've misstated or missed anything.TASK DETAILhttps://phabricator.wikimedia.org/T150060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBisson, jmatazzoniCc: Etonkovidova, gerritbot, Aklapper, Pginer-WMF, Trizek-WMF, Catrope, Quiddity, Liuxinyu970226, Mattflaschen-WMF, SBisson, jmatazzoni, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T150060: Implement functionality for RC page 'Type of change' filters
SBisson added a comment. In T150060#2922068, @jmatazzoni wrote: In the scheme we've defined, Flow edits (excluding Flow edits that create a new topic) belong with Page edits and only Page edits. That should be our goal. So, to use a negative example, if I uncheck everything except Category changes, I should see Category changes only—and no Flow edits. If that is not what is happening—if Flow edits are slipping through because they're not addressed by the RC page filters—then we should fix that. @SBisson, can you clarify? Will Flow edits be included with Page edits and only Page edits? (If not, do you want to fix it in this ticket or should we create a separate ticket?) tldr: I'm working on T154486, which rolls new topics into the "new pages" filter. I will include all other Flow changes in the "page edits" filter as part of the same ticket, which I've updated accordingly. It's unfortunately not as simple as it sounds since from RC's perspective, all this data is only tagged as "Flow". There's no notion of "new" or anything else. It makes it quite hard to filter. I'll probably have to change how data is stored. The "N" is added during rendering when all the data is loaded and we can check a number of Flow-specific conditions (first version of the first reply to a non-moderated topic - it has nothing to do with the related Topic page).TASK DETAILhttps://phabricator.wikimedia.org/T150060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBissonCc: Etonkovidova, gerritbot, Aklapper, Pginer-WMF, Trizek-WMF, Catrope, Quiddity, Liuxinyu970226, Mattflaschen-WMF, SBisson, jmatazzoni, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T150060: Implement functionality for RC page 'Type of change' filters
jmatazzoni added a comment. In the scheme we've defined, Flow edits (excluding Flow edits that create a new topic) belong with Page edits and only Page edits. That should be our goal. So, to use a negative example, if I uncheck everything except Category changes, I should see Category changes only—and no Flow edits. If that is not what is happening—if Flow edits are slipping through because they're not addressed by the RC page filters—then we should fix that. @SBisson, can you clarify? Will Flow edits be included with Page edits and only Page edits? (If not, do you want to fix it in this ticket or should we create a separate ticket?)TASK DETAILhttps://phabricator.wikimedia.org/T150060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBisson, jmatazzoniCc: Etonkovidova, gerritbot, Aklapper, Pginer-WMF, Trizek-WMF, Catrope, Quiddity, Liuxinyu970226, Mattflaschen-WMF, SBisson, jmatazzoni, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T150060: Implement functionality for RC page 'Type of change' filters
Etonkovidova added a comment. @jmatazzoni: Edits on Flow boards won't be filtered out by hidepageedits (the similar issue is with hidenewpages which is being addressed with T154486: Special:RC - hidenewpages should filter out new Flow topics). Should we filed it as a separate ticket? QA recommendation: Product should weigh in.TASK DETAILhttps://phabricator.wikimedia.org/T150060EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SBisson, EtonkovidovaCc: Etonkovidova, gerritbot, Aklapper, Pginer-WMF, Trizek-WMF, Catrope, Quiddity, Liuxinyu970226, Mattflaschen-WMF, SBisson, jmatazzoni, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
