LucasWerkmeister added a comment.

I don’t think this is specific to both axes being numeric – dimple just always includes 0 in the range for numerical values. I’ve suggested an upstream fix: PMSI-AlignAnalytics/dimple#256. I went over all the chart example queries and didn’t see any obvious errors with this patch; several of the line chart queries can in fact be improved: if you remove the STR workaround, gaps in the years become visible (in STR form, there’s no indication that 2016 does not directly follow 2013 if there are no results for 2014 and 2015).

Since there hasn’t been any activity on the dimple repository for over half a year (last commits on master and merged pull requests on March 23rd), we might want to go ahead and just apply this fix without waiting for them to merge and release it, provided someone here can review it (it’s a fairly small patch).


TASK DETAIL
https://phabricator.wikimedia.org/T150515

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister
Cc: LucasWerkmeister, Jonas, Aklapper, WikidataFacts, EBjune, mschwarzer, Avner, debt, Gehel, D3r1ck01, FloNight, Xmlizer, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Deskana, Manybubbles, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to