gerritbot added a comment.
Change 491535 **merged** by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Change colors to align with
WikimediaUI color palette
https://gerrit.wikimedia.org/r/491535
TASK DETAIL
https://phabricator.wikimedia.org/T151194
EMAIL PREFERENCES
gerritbot added a comment.
Change 491535 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Change colors to align with WikimediaUI color palette
https://gerrit.wikimedia.org/r/491535TASK
gerritbot added a comment.
Change 491535 had a related patch set uploaded (by Addshore; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Change colors to align with WikimediaUI color palette
https://gerrit.wikimedia.org/r/491535TASK
gerritbot added a comment.
Change 344880 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Convert badge and entity/rank selector icons to conform WikimediaUI color palette
https://gerrit.wikimedia.org/r/344880TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
Ladsgroup added a comment.
Gerrit-bot is still broken. Here's the last patch. https://gerrit.wikimedia.org/r/#/c/344880/ Once this is merged, we can call this done.TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
gerritbot added a comment.
Change 343760 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Minor cleanups in colors to align them with WikimediaUI color palette
https://gerrit.wikimedia.org/r/343760TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
Ladsgroup added a comment.
https://github.com/Wikidata/primarysources/pull/135TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Volker_E, gerritbot, Jonas, thiemowmde, Lydia_Pintscher,
Ladsgroup added a comment.
The +1 sign:
Before:
F6820375: pasted_file
After:
F6820353: pasted_file
We decided to go with WikimediaUI's blue instead of greenTASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Ladsgroup added a comment.
https://gerrit.wikimedia.org/r/#/c/343760/ will do some cleanups. Only svg files for badges and snakview will need change, that can happen later.TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
Ladsgroup added a comment.
Okay, a simple grep shows these are not moved to the color palette:
amir@amir-GL552VW:~/Wikibase2/view$ grep -irE "#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})" . | grep -viE "eaf3ff|fee7e6|c8ccd1|eaecf0|000|72777d|f8f9fa|fff|a2a9b1|54595d|2a4b8d|b6c8ec|efa0a0|0645ad"
gerritbot added a comment.
Change 343661 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Align red colors with WikimediaUI color palette
https://gerrit.wikimedia.org/r/343661TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
Lydia_Pintscher added a comment.
{icon thumbs-up}TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lydia_PintscherCc: Volker_E, gerritbot, Jonas, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper,
Ladsgroup added a comment.
Started red ones: https://gerrit.wikimedia.org/r/#/c/343661/
Before:
F6775199: pasted_file
After:
F6775188: pasted_file
This one is almost impossible to notice.TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
gerritbot added a comment.
Change 343449 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Align blue colors with WikimediaUI color palatte
https://gerrit.wikimedia.org/r/343449TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
gerritbot added a comment.
Change 343450 merged by jenkins-bot:
[data-values/value-view] Align blue with the Wikimedia UI color palette
https://gerrit.wikimedia.org/r/343450TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
Jan_Dittrich added a comment.
Looks good to me – thanks @Ladsgroup !TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Jan_DittrichCc: Volker_E, gerritbot, Jonas, thiemowmde, Lydia_Pintscher,
Lydia_Pintscher added a comment.
@Jan_Dittrich designer eye please ^ ;-)TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lydia_PintscherCc: Volker_E, gerritbot, Jonas, thiemowmde,
Ladsgroup added a comment.
Now we have two patches to align the blue colors: https://gerrit.wikimedia.org/r/343449 and https://gerrit.wikimedia.org/r/#/c/343450/
Old:
F6700538: pasted_file
New:
F6700673: pasted_fileTASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
gerritbot added a comment.
Change 343315 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Align gray colors with WikimediaUI color palette
https://gerrit.wikimedia.org/r/343315TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
Lydia_Pintscher added a comment.
Thanks for the screenshots. That helps. Let's do it! :)TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lydia_PintscherCc: Volker_E, gerritbot, Jonas, thiemowmde,
Jan_Dittrich added a comment.
+2, too :-)TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Jan_DittrichCc: Volker_E, gerritbot, Jonas, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper, Ladsgroup,
thiemowmde added a comment.
I made some screenshots of what the patch https://gerrit.wikimedia.org/r/343315 actually does. Terms before and after:
F6670482: Color_scheme_terms_before.pngF6670492: Color_scheme_terms_after.png
Sitelinks before and after:
F6670500:
Ladsgroup added a comment.
https://gerrit.wikimedia.org/r/#/c/343315/TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Volker_E, gerritbot, Jonas, thiemowmde, Lydia_Pintscher, Jan_Dittrich,
Jan_Dittrich added a comment.
@Ladsgroup @thiemowmde
In this case, please change the colors, I'm looking forward to the changes.
breakage…
I did not expect code to fail; breakage from the point of the user (and something I can imagine to happen when changing colors) would be a contrast, which
Ladsgroup added a comment.
I define breakage in a programmatical manner, like fatal error, stuff like that ;) If these gadgets are in mediawiki namespace, I can take care of that.TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
thiemowmde added a comment.
No, it's not possible
Depends on what you call a "breakage". I just noticed that the colors are already broken when using the PrimarySources tool. Other gadgets and tools might also use the current colors. This should not block us from changing the current Wikibase UI
Ladsgroup added a comment.
@Jan_Dittrich:
Yes, so instead of "#E8E8E8" we use "#eaecf0" and instead of "#D6F3FF" we use "#eaf3ff". Most (if not all) of these changes are almost invisible to the human eye. The color palette has indeed light blue (#eaf3ff), it's so beautiful in fawiki's opinion that
Jan_Dittrich added a comment.
@Ladsgroup:
I assume this would mean shifting the hues towards the ones the standard palette uses?
Because there is no light blue in that palette and changing to another much darker/saturated tone may require and extensive review. In that case I would be hesitant,
Ladsgroup added a comment.
@Volker_E: I gave it a try rather long time ago but this requires PM's approval and also you need to talk to our UX designer: @Jan_Dittrich if they give me green light, I make this happen in no time.TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL
Volker_E added a comment.
@Ladsgroup What's the status here?TASK DETAILhttps://phabricator.wikimedia.org/T151194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Volker_ECc: Volker_E, gerritbot, Jonas, thiemowmde, Lydia_Pintscher, Jan_Dittrich, Aklapper,
30 matches
Mail list logo
