[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
gerritbot added a comment. Change 378723 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Make Wikibase code base compatible with current DataModel master https://gerrit.wikimedia.org/r/378723TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
gerritbot added a comment. Change 378723 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)): [mediawiki/extensions/Wikibase@master] Make Wikibase code base compatible with current DataModel master https://gerrit.wikimedia.org/r/378723TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
daniel added a comment. @Aleksey_WMDE I agree, this ticket does not require the data model release. Just the code to be merged in all repos.TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
Ladsgroup added a comment. I'm fine.TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
Aleksey_WMDE added a comment. I suggest to mark this ticket as done, as soon as we don't use setId(int) in Wikibase* repositories and make release later when we have more changes.TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Aleksey_WMDECc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
Ladsgroup added a comment. https://github.com/wmde/WikibaseDataModel/pull/754 To releaseTASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
gerritbot added a comment. Change 367463 merged by jenkins-bot: [mediawiki/extensions/WikibaseMediaInfo@master] Do not let MediaInfo::setId accept int as Id https://gerrit.wikimedia.org/r/367463TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
gerritbot added a comment. Change 367461 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Do not let Lexeme::setId accept int as Id https://gerrit.wikimedia.org/r/367461TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
Ladsgroup added a comment. https://github.com/wmde/WikibaseDataModel/pull/753TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
gerritbot added a comment. Change 367463 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/WikibaseMediaInfo@master] Do not let MediaInfo::setId accept int as Id https://gerrit.wikimedia.org/r/367463TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
gerritbot added a comment. Change 367461 had a related patch set uploaded (by AnotherLadsgroup; owner: Amir Sarabadani): [mediawiki/extensions/WikibaseLexeme@master] Do not let Lexeme::setId accept int as Id https://gerrit.wikimedia.org/r/367461TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
Ladsgroup added a comment. Already on it, github PR has a tag for breaking we can use that.TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
gerritbot added a comment. Change 367024 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use EntityIdComposer instead of sending numeric id to EntityId::setId() https://gerrit.wikimedia.org/r/367024TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
gerritbot added a comment.Herald added a subscriber: PokestarFan. Change 367024 had a related patch set uploaded (by AnotherLadsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] Use EntityIdComposer instead of sending numeric id to EntityId::setId() https://gerrit.wikimedia.org/r/367024TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, PokestarFan, Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T151577: Do not call Entity::setId() with an int parameter
thiemowmde added a comment. I triaged this as high because it is quite nasty, extremely old technical debt we want to pay for a long, long time. Luckily it became very easy to finally fix this with what we build in the past months. Just use the existing entity-id-composer-callbacks in WikiPageEntityStore::assignFreshId, and be done. I believe this will be the last instance of numeric calls to setId(). We can remove this feature from all entity types then! (Probably have some kind of deprecation phase for Item and Property.) I believe this is not a blocker for any of the projects we are currently working on. MediaInfo already works around this issue.TASK DETAILhttps://phabricator.wikimedia.org/T151577EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: Aleksey_WMDE, aude, Lydia_Pintscher, WMDE-leszek, thiemowmde, Aklapper, daniel, D3r1ck01, Izno, Wikidata-bugs, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
