[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2017-06-25 Thread aude
aude added a comment. We have lost some of the error descriptions, but think that can be fixed by adding i18n messages for api errors. currently on Wikidata: https://www.wikidata.org/w/api.php?action=""> { "error": { "code": "param-missing", "info": "A parameter that is requi

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2017-06-22 Thread gerritbot
gerritbot added a comment. Change 360872 abandoned by Thiemo Mättig (WMDE): Minor refactorings and cleanups in ApiErrorReporter and tests Reason: This became obsolete because Ib5b1eae got merged. https://gerrit.wikimedia.org/r/360872TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2017-06-22 Thread gerritbot
gerritbot added a comment. Change 321464 abandoned by Anomie: WIP: Update for API error i18n Reason: Done in Ib5b1eae2ab66e633a438d2705d7b96f386f16939 https://gerrit.wikimedia.org/r/321464TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settin

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2017-06-22 Thread gerritbot
gerritbot added a comment. Change 353545 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don't use deprecated methods in ApiErrorReporter. https://gerrit.wikimedia.org/r/353545TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setti

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2017-06-22 Thread gerritbot
gerritbot added a comment. Change 360872 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)): [mediawiki/extensions/Wikibase@master] Minor refactorings and cleanups in ApiErrorReporter and tests https://gerrit.wikimedia.org/r/360872TASK DETAILhttps://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2017-06-19 Thread daniel
daniel added a comment. Pending: get https://gerrit.wikimedia.org/r/#/c/353545/ and its follow-ups merged.TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, danielCc: hoo, aude, Aleksey_WMDE, daniel,

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2017-04-28 Thread Anomie
Anomie added a comment. In T153359#3220755, @Lydia_Pintscher wrote: What still needs to be done here? Updating your ApiErrorReporter class to not use the deprecated methods. There was some relevant discussion on https://gerrit.wikimedia.org/r/#/c/327704/ after it was abandoned.TASK DETAILhttps:/

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2017-04-28 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. What still needs to be done here?TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, Lydia_PintscherCc: hoo, aude, Aleksey_WMDE, daniel, Lydia_Pintscher, gerritbot, th

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-29 Thread gerritbot
gerritbot added a comment. Change 328153 merged by jenkins-bot: Remove ApiUsageException related dead code from EntityLoadingHelperTest https://gerrit.wikimedia.org/r/328153TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpr

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-29 Thread gerritbot
gerritbot added a comment. Change 328151 merged by Daniel Kinzler: Inject ApiBase into ItemByTitleHelper for proper error reporting https://gerrit.wikimedia.org/r/328151TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefer

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-19 Thread gerritbot
gerritbot added a comment. Change 327545 merged by jenkins-bot: Replace all deprecated UsageException in Repo with ApiUsageException https://gerrit.wikimedia.org/r/327545TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-19 Thread gerritbot
gerritbot added a comment. Change 328153 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Remove ApiUsageException related dead code from EntityLoadingHelperTest https://gerrit.wikimedia.org/r/328153TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-19 Thread gerritbot
gerritbot added a comment. Change 328151 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Inject ApiBase into ItemByTitleHelper for proper error reporting https://gerrit.wikimedia.org/r/328151TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-19 Thread gerritbot
gerritbot added a comment. Change 327704 abandoned by Thiemo Mättig (WMDE): Replace deprecated methods in ApiErrorReporter Reason: If you believe that a first small, incomplete step forward deserves a -1 just for being what it is, I'm wasting my time. Feel free to continue working on this. https:

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-16 Thread gerritbot
gerritbot added a comment. Change 327704 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Replace deprecated methods in ApiErrorReporter https://gerrit.wikimedia.org/r/327704TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/p

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-15 Thread gerritbot
gerritbot added a comment. Change 327545 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Replace all deprecated UsageException in Repo with ApiUsageException https://gerrit.wikimedia.org/r/327545TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T153359: Replace use of deprecated methods (mainly in ApiErrorReporter)

2016-12-15 Thread gerritbot
gerritbot added a comment. Change 321464 had a related patch set uploaded (by Anomie): WIP: Update for API error i18n https://gerrit.wikimedia.org/r/321464TASK DETAILhttps://phabricator.wikimedia.org/T153359EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerr