gerritbot added a comment.
Change 355879 merged by jenkins-bot:
[mediawiki/core@master] Introduce MessageLocalizer interface for exposing msg() method
https://gerrit.wikimedia.org/r/355879TASK DETAILhttps://phabricator.wikimedia.org/T162594EMAIL
Krinkle added a comment.
In T162594#3347436, @daniel wrote:
In T162594#3341141, @Krinkle wrote:
I doubt anyone would extend ContextSource for a class just to get a msg() method. That seems rather unnecessary. I would not consider that acceptable for code in MediaWiki core.
Well, using
daniel added a comment.
Related patch: https://gerrit.wikimedia.org/r/#/c/355879/5TASK DETAILhttps://phabricator.wikimedia.org/T162594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: Nikerabbit, Krinkle, Nemo_bis, Agabi10, gerritbot,
daniel added a comment.
In T162594#3341141, @Krinkle wrote:
I doubt anyone would extend ContextSource for a class just to get a msg() method. That seems rather unnecessary. I would not consider that acceptable for code in MediaWiki core.
Well, using subclassing for this kind of thing shouldn't
gerritbot added a comment.
Change 357353 abandoned by Ladsgroup:
[POC] Add LanguageMessageLocalizer implementing MessageLocalizer
Reason:
It's better to go with I1864afb8bcc641698689828914949a06506d8f3a, restore if you want to pick this up and work on it
https://gerrit.wikimedia.org/r/357353TASK
Krinkle added a comment.
To avoid reliance on global state, and dragging in the kitchen sink that is IContextSource, a narrow interface called MessageLocalizer should be introduced [..]
Calling code that only needs the msg() method can then start using MessageLocalizer instead of IContextSource
