gerritbot added a comment.
Change 350863 abandoned by Lucas Werkmeister (WMDE):
Ignore Range violations due to needed parameters
Reason:
See last comment in Change 350855.
https://gerrit.wikimedia.org/r/350863TASK DETAILhttps://phabricator.wikimedia.org/T164087EMAIL
gerritbot added a comment.
Change 351337 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Reduce duplication and split long lines in RangeChecker
https://gerrit.wikimedia.org/r/351337TASK DETAILhttps://phabricator.wikimedia.org/T164087EMAIL
gerritbot added a comment.
Change 351333 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Let RangeChecker fall back to {minimum,maximum}_quantity
https://gerrit.wikimedia.org/r/351333TASK DETAILhttps://phabricator.wikimedia.org/T164087EMAIL
gerritbot added a comment.
Change 351337 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Reduce duplication and split long lines in RangeChecker
https://gerrit.wikimedia.org/r/351337TASK
gerritbot added a comment.
Change 351333 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Let RangeChecker fall back to {minimum,maximum}_quantity
https://gerrit.wikimedia.org/r/351333TASK
Lucas_Werkmeister_WMDE added a comment.
Actually, once we import constraints from statements, we’ll have different qualifiers for “quantity” and “time”, so perhaps let’s not lose that distinction yet… what if RangeChecker checks for _date, but falls back to _quantity if it doesn’t exist? And we
Lucas_Werkmeister_WMDE added a comment.
I think I’ll go for the second solution for now, and always use {minimum,maximum}_quantity – it’s a bit ugly, but consistent with DiffInRangeChecker, and perhaps we can change both to just {minimum,maximum} at a later time.
It’s just a bit unfortunate that
Lucas_Werkmeister_WMDE added a comment.
Note: the attached change is related, but not a fix for this issue. Don’t close this task only because that change was merged.TASK DETAILhttps://phabricator.wikimedia.org/T164087EMAIL
gerritbot added a comment.
Change 350863 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Ignore Range violations due to needed parameters
https://gerrit.wikimedia.org/r/350863TASK
Lucas_Werkmeister_WMDE added a comment.
{{Constraint:Range|min=-5000|max=now}}
Mostly unrelated, but I just noticed this: As far as I can tell, nothing in RangeChecker currently maps that now to an actual, comparable value… so even if the checker got the right parameters, it still might not
10 matches
Mail list logo
