[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
gerritbot added a comment. Change 358963 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Reword Echo notification text https://gerrit.wikimedia.org/r/358963TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, gerritbotCc: Liuxinyu970226, gerritbot, jmatazzoni, Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
Ladsgroup added a comment. I was able to build a live test setup. It's redis-dispatching-repo.wmflabs.org and redis-dispatching-client.wmflabs.org. I applied my patch and the result is like this: F8460077: image.png It looks nice.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, jmatazzoni, Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
Lydia_Pintscher added a comment. @jmatazzoni Ahh! Now I get what you mean. Good point. Amir already made that change in the patch. Thanks.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, jmatazzoni, Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
gerritbot added a comment. Change 358963 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/Wikibase@master] [WIP] Reword Echo notification text https://gerrit.wikimedia.org/r/358963TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, jmatazzoni, Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, GoranSMilovanovic, QZanden, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
jmatazzoni added a comment. In T164375#3344940, @Lydia_Pintscher wrote: Ok let's go with "The page FOO was connected to the BAR item ITEMID. It contains data relevant to the topic." and link the whole thing to the Wikidata item. In English, this formulation has the same problem. "It" here grammatically refers back to "Page FOO," which I think is now what you mean. Again, in English, this issue could be fixed by changing this to: "The page FOO was connected to the BAR item ITEMID, which contains data relevant to the topic." Then ITEMID is the referent of "which." But I'm out of my depth here in terms of knowing how various permutations of any phrasing will be interpreted in different languages...TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jmatazzoniCc: jmatazzoni, Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, GoranSMilovanovic, QZanden, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
Lydia_Pintscher added a comment. Ok let's go with "The page FOO was connected to the BAR item ITEMID. It contains data relevant to the topic." and link the whole thing to the Wikidata item.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: jmatazzoni, Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, GoranSMilovanovic, QZanden, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
jmatazzoni added a comment. The new text should be: "The page foo was connected to a bar item. It holds additional data about the topic." In the second sentence, "it" would refer to the subject of the previous sentence, which is "the page." I don't think that's what you mean here. Also, I don't see the phrase "Wikidata" here, which seems a little confusing. How about something like this: The page pagename was connected to the Wikidata item dataitem, which contains data relevant to the subject.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jmatazzoniCc: jmatazzoni, Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, QZanden, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T164375: [Task] improve Wikidata Echo notification text
Mattflaschen-WMF added a comment. Or reverse it, and have the primary link go to Wikidata and a secondary link go to the local page. Nothing actually happened to the local page, so there's nothing to see there really.TASK DETAILhttps://phabricator.wikimedia.org/T164375EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMFCc: Mattflaschen-WMF, Catrope, matej_suchanek, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, thiemowmde, Aklapper, QZanden, MuhammadShuaib, Izno, SBisson, LNDDYL, Psychoslave, Luke081515, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
