[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2020-07-01 Thread gerritbot 
gerritbot added a comment.


  Change 603496 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
owner: Thiemo Kreuz (WMDE)):
  [mediawiki/tools/codesniffer@master] Add (optional) 
FullQualifiedClassNameSniff from WikibaseCodeSniffer
  
  https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/ /603496

TASK DETAIL
  https://phabricator.wikimedia.org/T164653

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, 
Aklapper, Alter-paule, Beast1978, Un1tY, Hook696, darthmon_wmde, Kent7301, 
joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Lethexie, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2020-06-30 Thread gerritbot 
gerritbot added a comment.


  Change 603495 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
owner: Thiemo Kreuz (WMDE)):
  [mediawiki/tools/codesniffer@master] Add optional ClassLevelLicense sniff 
(from WikibaseCodeSniffer)
  
  https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/ /603495

TASK DETAIL
  https://phabricator.wikimedia.org/T164653

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, 
Aklapper, Alter-paule, Beast1978, Un1tY, Hook696, darthmon_wmde, Kent7301, 
joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Lethexie, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2020-06-21 Thread gerritbot 
gerritbot added a comment.


  Change 603493 **merged** by jenkins-bot:
  [mediawiki/tools/codesniffer@master] Add RedundantVarNameSniff from 
WikibaseCodeSniffer
  
  https://gerrit.wikimedia.org/r/603493

TASK DETAIL
  https://phabricator.wikimedia.org/T164653

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, 
Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Lethexie, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2020-06-10 Thread gerritbot 
gerritbot added a comment.


  Change 603493 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
owner: Thiemo Kreuz (WMDE)):
  [mediawiki/tools/codesniffer@master] Add RedundantVarNameSniff from 
WikibaseCodeSniffer
  
  https://gerrit.wikimedia.org/r/603493

TASK DETAIL
  https://phabricator.wikimedia.org/T164653

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, 
Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, 
Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, 
joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Lethexie, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2018-05-29 Thread gerritbot 
gerritbot added a comment.
Change 434646 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add InArrayUsageSniff from Wikibase CodeSniffer

https://gerrit.wikimedia.org/r/434646TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2018-05-29 Thread gerritbot 
gerritbot added a comment.
Change 434646 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Legoktm):
[mediawiki/tools/codesniffer@master] Add InArrayUsageSniff from Wikibase CodeSniffer

https://gerrit.wikimedia.org/r/434646TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2017-12-21 Thread gerritbot 
gerritbot added a comment.
Change 398679 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Require that an explicit visiblity is set on methods and properties

https://gerrit.wikimedia.org/r/398679TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2017-12-21 Thread gerritbot 
gerritbot added a comment.
Change 398678 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Check function definitions for the same variable name

https://gerrit.wikimedia.org/r/398678TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2017-12-16 Thread Legoktm 
Legoktm added a comment.
I tried enabling Squiz.WhiteSpace.FunctionSpacing but it did not play well with global functions (probably needs an upstream bug report).TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2017-12-16 Thread gerritbot 
gerritbot added a comment.
Change 398679 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Require that an explicit visiblity is set on methods and properties

https://gerrit.wikimedia.org/r/398679TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Lethexie, Maathavan, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS

2017-12-16 Thread gerritbot 
gerritbot added a comment.
Change 398678 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Check function definitions for the same variable name

https://gerrit.wikimedia.org/r/398678TASK DETAILhttps://phabricator.wikimedia.org/T164653EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, Lethexie, Wikidata-bugs, aude, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs