[Wikidata-bugs] [Maniphest] [Commented On] T165597: Item selector in Special:NewLexeme should show description

2018-06-29 Thread gerritbot
gerritbot added a comment.
Change 441555 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Show description in the item selector on Special:NewLexeme

https://gerrit.wikimedia.org/r/441555TASK DETAILhttps://phabricator.wikimedia.org/T165597EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Nikki, Aklapper, WMDE-leszek, Jonas, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T165597: Item selector in Special:NewLexeme should show description

2018-06-26 Thread Pablo-WMDE
Pablo-WMDE added a comment.
What was the decision on showing the id generally? Answered by "as consistent with the item selector on item pages as possible"?

No label and description properties on data in getLookupMenuOptionsFromData() if not present in item - provide a fallback to id, maybe? Admittedly a strange situation but happened to be the case in my dev. 
F22663938: Bildschirmfoto von 2018-06-26 10-06-28.png

If an list item with existing label and description is selected the newly created HTML - in escaped fashion - is used as input value.
F22663998: Bildschirmfoto von 2018-06-26 10-09-33.png
F22663999: Bildschirmfoto von 2018-06-26 10-09-43.pngTASK DETAILhttps://phabricator.wikimedia.org/T165597EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, Pablo-WMDECc: Pablo-WMDE, Lexicographical data, Lea_Lacroix_WMDE, KaMan, gerritbot, Nikki, Aklapper, WMDE-leszek, Jonas, Lydia_Pintscher, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T165597: Item selector in Special:NewLexeme should show description

2018-06-22 Thread gerritbot
gerritbot added a comment.
Change 441555 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Show description in the item selector on Special:NewLexeme

https://gerrit.wikimedia.org/r/441555TASK DETAILhttps://phabricator.wikimedia.org/T165597EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jakob_WMDE, gerritbotCc: gerritbot, Nikki, Aklapper, WMDE-leszek, Jonas, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T165597: Item selector in Special:NewLexeme should show description

2017-05-18 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.
My first thought is that we want to be as consistent with the item selector on item pages as possible.TASK DETAILhttps://phabricator.wikimedia.org/T165597EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Aklapper, WMDE-leszek, Jonas, Lydia_Pintscher, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs