[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

abian added a comment. I'm sorry I put this aside (my fault). I didn't include tests, but I feel I don't know the architecture well enough to write them; I sense that these will be complex or that I'll need to touch code elsewhere. I think it's better for me to officially give up on these te

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

Lydia_Pintscher added a comment. 👍 TASK DETAIL https://phabricator.wikimedia.org/T166470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper, abian, Blissjay007, Oblanco79, Al

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

Ladsgroup added a comment. In T166470#6199297 , @Lydia_Pintscher wrote: > What is this waiting for/stalled on? The patch needs to address some code review concerns :) TASK DETAIL https://phabricator.wikimedia.org/T166470 EMAIL PR

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

Lydia_Pintscher added a comment. What is this waiting for/stalled on? TASK DETAIL https://phabricator.wikimedia.org/T166470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Ladsgroup, Lydia_Pintscher, Addshore, daniel, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

gerritbot added a comment. Change 547739 had a related patch set uploaded (by Abián; owner: Abián): [mediawiki/extensions/Wikibase@master] Include Link headers in HTTP responses https://gerrit.wikimedia.org/r/547739 TASK DETAIL https://phabricator.wikimedia.org/T166470 EMAIL PREFEREN

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

Addshore added a comment. ViewEntityAction has access to OutputPage via $this->getOutput() which has addLinkHeader which is what you need afaik. TASK DETAIL https://phabricator.wikimedia.org/T166470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

Ladsgroup added a comment. I would go with the place that we put `og:description` meta tags but I'm not sure if it's possible to add response headers there (It's in `ViewEntityAction.php`) TASK DETAIL https://phabricator.wikimedia.org/T166470 EMAIL PREFERENCES https://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

abian added a comment. Okay! But I'd need some help to know what/where to touch. To set HTTP headers for the Special:EntityData pages I would probably change /repo/includes/LinkedData/EntityDataRequestHandler.php

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

Lydia_Pintscher added a comment. Let's do it then :) @abian Do you want to propose a patch? TASK DETAIL https://phabricator.wikimedia.org/T166470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, Addshore, dani

[Wikidata-bugs] [Maniphest] [Commented On] T166470: Include links in Wikidata HTTP responses to different entity representations as Link headers

Addshore added a comment. I see no reason not to do this. TASK DETAIL https://phabricator.wikimedia.org/T166470 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lydia_Pintscher, Addshore, daniel, Aklapper, abian, darthmon_wmde, DannyS